[01:35] ubiquity: cjwatson * r3174 ubiquity/ (debian/changelog scripts/install.py): [01:35] ubiquity: Sync with netcfg 1.44: Define IPv6 ::1 address as "localhost" (thanks, [01:35] ubiquity: Robb Topolski; LP: #301430). [01:45] base-installer: cjwatson * r361 ubuntu/ (debian/changelog library.sh): Silently skip non-existent devices in /proc/swaps (LP: #290947). [01:47] ubiquity: cjwatson * r3175 ubiquity/ (debian/changelog scripts/install.py): Silently skip non-existent devices in /proc/swaps (LP: #290947). [02:43] steve, in the metalink for the beta there are some entries with preference = 110 (>> bittorrent) [03:30] wubi: Agostino Russo * r108 trunk/ (18 files in 8 dirs): [03:30] wubi: * Disabled ISO backup because download resume is not fully supported [03:30] wubi: at the moment [03:30] wubi: * Isolist.ini now points to the final release URLs [03:30] wubi: * Allow the uninstaller to delete the directory containing itself by [03:30] wubi: running the python code from a different process/location (LP: [03:30] wubi: #341605) [09:36] cjwatson: I like the new colour scheme on the partitioning section of ubiquity [09:42] thank evand :) [09:43] os-prober: cjwatson * r232 ubuntu/debian/ (changelog rules): [09:43] os-prober: Install Mac OS X probe on i386/amd64 too, although it will be marked as [09:43] os-prober: unsupported in grub-installer as AFAIK it can only be booted directly [09:43] os-prober: from EFI (LP: #353639). [09:45] I would do but he seems to be away :( [09:47] os-prober: cjwatson * r233 ubuntu/ (debian/changelog os-probes/mounted/x86/30utility): Detect Acronis Secure Zone (thanks, Alexey Fisher; LP: #354334). [09:47] davmor2: yeah, off this week [09:51] os-prober: cjwatson * r234 ubuntu/debian/changelog: releasing version 1.29ubuntu2 [10:52] cjwatson, ubiquity still inhibits screensaver and dpms, right ? [10:52] should do [10:52] (or did that change at some point) [10:52] ok [10:52] because i see screen blanking on the babbage board ... must be a kernel setting then [10:52] see poke_screensaver in ubiquity/frontend/gtk_ui.py [10:53] it's on a timer, so I suppose the timer could be wrong; ideally we ought to switch to --inhibit [10:53] i belive you, no need to look, i'll check the kernel config [10:53] screen blanking might not be through the screensaver though? [10:53] thats what i think [10:53] i think there is some additional backlight control stuff from freescale [10:55] grin ... there is a kernel setting called CONFIG_ARCH_MXC_CANONICAL=y [10:56] aha ... CONFIG_BACKLIGHT_MXC=Y and CONFIG_BACKLIGHT_MXC_MC13892=y ... MC18392 is the framebuffer driver if i'm not wrong [10:59] superm1: hmm, I tried out that langpack filtering code with 120 language-support-* names, and the filtering is instantaneous here [11:02] superm1: do you think you could try it out with something like this instead of the list comprehension? [11:02] new_to_install = [] [11:02] for lp in to_install: [11:02] syslog.syslog('Testing language pack: %s' % lp) [11:02] if self.get_cache_pkg(cache, lp) is not None: [11:02] syslog.syslog('Language pack found') [11:02] new_to_install.append(lp) [11:02] to_install = new_to_install [11:02] superm1: then we'd get more detailed timestamps [11:59] hi davmor2 [11:59] Hello xivulon [12:00] could you please test r108? http://people.ubuntu.com/~evand/wubi/jaunty/wubi-r108.exe [12:00] yes was going to [12:00] xivulon: this is the one that should allow removal correct? [12:00] correct [12:00] cool :) [12:01] Other than 341605 it might also address: #341607 and #347529 [12:03] Could you please also re-test 207137? [12:04] cjwatson I have a recursive dir deletion code I would like you to review [12:04] , that has been in for some time, but because of a bug that code path was only rarely hit [12:05] http://bazaar.launchpad.net/%7Eubuntu-installer/wubi/trunk/annotate/head%3A/src/pylauncher/deletedir.c [12:05] called by pylauncher.c [12:05] It seems ok to me but it would be very annoying if something goes wrong there [12:06] xivulon: would it be possible to call python code instead? [12:06] davmor2, would you mind adding comments to the above bugs? [12:06] since there's shutil.rmtree [12:06] xivulon: np's [12:07] cjwatson, that is the code that actually launches python itself, and python is contained in the dir that has to be deleted, which is something you cannot do in windows [12:07] I don't think I'm qualified to review that function, unfortunately; I don't know the Win32 file handling API at all [12:07] the top-level logic looks fine but there could be all sorts of lurking gotchas in there that I'd never spot [12:08] you have far better overall understanding than I do anyway [12:08] is there any possibility that it would need to cope with symlinks? [12:09] not in the wubi dir to be deleted, I have no symlinks there [12:09] just plain files and dirs [12:09] do you need to handle errors from line 59 before going on to attempt to delete the file? [12:10] if you intend to ignore errors there, it would be better to just not set result and try to delete the file anyway, I'd have thought [12:10] it appears that at the moment if setting attributes fails but deleting the file succeeds, then the function will fail, which seems unnecessary [12:10] I don't know if that is possible [12:11] oh, it looks like you leak memory from file_path every time around the inner loop [12:12] In our case all files should have normal attributes anyway, ah good catch [12:12] you need to freestr that each time round [12:13] and probably then remove the freestr outside the loop (line 74) [12:13] also you leak pattern if file_handle == INVALID_HANDLE_VALUE [12:13] I think that's everything I can see [12:13] will patch that tonight, please have also a look at pylauncher.c, that is where actually things could be problematic (in terms of wrong delete_dir argument) [12:14] literal strings should have type const char[] not char[] [12:15] (assuming that doesn't cause trouble when passing to other functions, in which case you might need casts) [12:15] do you need to handle errors from delete_directory in main? [12:16] I wouldn't think so, there isn't much I can do if that fails, they will just have a dungling temp directory [12:16] I'd use sprintf instead of all of those strcats personally, but that's a style point [12:17] best hope that targetdir is not very long ... [12:17] are you sure you don't want to make cmd bigger, calculated based on MAX_PATH? [12:17] and message should clearly be allocated 14 bytes bigger than cmd :-) [12:17] C:\Documents and Settings\arusso\Local Settings\Temp [12:18] personally I'd allocate cmd and message dynamically [12:18] reallocing if necessary around the argument loop [12:18] does CreateProcess not have any way to avoid having to parse the command out of a string? [12:19] not that I am aware of, I would love to poass an array of strings [12:21] mm, subprocess.py does similar stuff [12:21] do you need to take care to quote strings in the command line the way it does? [12:21] I assume that it would be safer to quote strings [12:22] I did that in header.c might have to do that again in pylauncher.c [12:22] In fact I think that is pretty much required [12:25] xivulon: it got 90's-ified blue block going across the bar rather than the plush green throbber [12:25] davmor2, when you test r108, please do so _without_ admin privileges, you should be prompted once by UAC [12:26] can you provide me with a screenshot? [12:26] xivulon: I'm just running as is from normal user [12:26] with no admin rights... [12:27] cjwatson: thx, will incorporate your comments tonight/tomorrow [12:27] cool [12:29] davmor2, I am going over the remaining UI glitches this w/e please file a bug for the bar [12:31] xivulon: http://www.davmor2.co.uk/vistabar.jpg [12:32] by the way I bought a macook :) [12:33] I think we can have a mubi at some stage, since grub2 efi is coming along quite nicely (thanks to bean123) [12:33] macbook [12:34] although because of lack of journal support in hfs , I doubt it will be possible to do loopinstallations [12:35] on the plus side, osx supports online resizing, so it would be possible to do a bootcamp type of app [12:37] cool [12:41] davmor2 I know the issue for the vista bar [12:41] xivulon: it hasn't whinged about the cd not being there. But after dinner I'll add wubi to a cd and try that for sure [12:42] cjwatson, sure. will do [12:42] thanks [12:42] the windows resource declaring that themes have to be used is associated to pylauncher, which in turns runs python.exe, but python.exe does not have that resource [12:44] ubiquity: cjwatson * r3176 ubiquity/ (5 files in 4 dirs): Use small print rather than italics in "Who are you?" (LP: #287626). [13:12] * cjwatson establishes some runes for booting a live CD in kvm with an arbitrary screen resolution (or at least something that the relevant X driver supports) [13:13] boot without splash and with break=casper-bottom, then: sed -i '/Modes.*"/s/".*/"800x600"/' /root/usr/bin/dexconf [13:13] and exit 0 to continue booting [13:57] oem-config: cjwatson * r646 trunk/ (debian/changelog lib/timezone_map.py): [13:57] oem-config: * GTK frontend: [13:57] oem-config: - Use the full size of the underlying images for the timezone map if the [13:57] oem-config: screen is big enough. [13:59] oem-config: cjwatson * r647 trunk/ (debian/changelog gui/glade/step_timezone.glade): Fix spacing on timezone page (LP: #336745). [14:19] xivulon: ah good your still around. I'm just going for a removal now [14:24] xivulon: windows app removal gave a error and removed ubuntu from the app list but all the folders are still in place so not quite sure what happened there [14:27] cjwatson, unfortunately those partman-base changes did hurt us as I'm finally testing the daily today with new ubiquity [14:28] the partman screen comes up with the warning [14:32] superm1: nngh. --debug output please? [14:32] simultaneously (on a diff box w/ older ubiquity) I tested that patch again that you proposed a few days ago before adding the debug info from earlier this morning. it worked this time, so I am going to run it once more to ensure the previous data point is a read herring caused by multiple ubiquity runs w/o a reboot [14:33] that'd be a relief, that's an RC bug :) [14:33] s/read/red/ that is [14:34] sure give me a bit, i'm letting that install finish off anyhow to see if grub2 stuff works out with it [14:55] cjwatson, so the second run with that patch was successful too, so I'd say pull that in and ignore my old data point w/ the multiple ubiquity runs [15:07] superm1: cool, that's good news, thanks [15:19] ubiquity: cjwatson * r3177 ubiquity/ (debian/changelog scripts/install.py): [15:19] ubiquity: Revert r2984 from ubiquity 1.11.5, and instead filter out language packs [15:19] ubiquity: that don't exist in the live filesystem's apt cache; this allows us to [15:19] ubiquity: accurately produce incomplete language support notifications again. [15:19] ubiquity: Thanks to Mario Limonciello for testing (LP: #337748). [15:27] ubiquity: cjwatson * r3178 ubiquity/ (debian/changelog ubiquity/frontend/mythbuntu_ui.py): [15:27] ubiquity: * Mythbuntu frontend: [15:27] ubiquity: - Don't crash if --no-migration-assistant was used (LP: #354368). [15:44] cjwatson, bug 354534 is the results of grub2 testing, i'll do one more to file the partman-base change separately however [15:45] Error: Could not parse data returned by Launchpad: timed out (https://launchpad.net/bugs/354534/+text) [15:46] thanks [15:46] thanks for the mythbuntu fix above too [15:48] np [16:09] /cdrom/scripts/chroot.sh: line 32: /target/var/log/installer/chroot.sh.log: No such file or directory [16:09] superm1: I assume that's from your preseeding? if so heads-up ... [16:12] cjwatson, it's because it's not really ran in a factory server, but a faked env I believe [16:12] ah [16:12] this is odd, looks like all the progress templates are missing ... [16:16] 14:27 cjwatson, unfortunately those partman-base changes did hurt us as I'm finally testing the daily today with new ubiquity [16:16] 14:28 the partman screen comes up with the warning [16:16] superm1: but it's a warning at the top of the screen rather than a dialog, right? [16:16] cjwatson, yes [16:16] superm1: I'm not clear on why that's bad - you genuinely can't create, resize, or delete partitions on that device, surely [16:16] and that seems like something it's appropriate to warn about [16:16] I still need to keep ubiquity/partman-skip-unmount boolean true otherwise there is a popup warning dialog [16:17] Oh I was certainly able to make a partition on the device [16:17] I picked the free space and made an ext3 partition to install to [16:17] but the kernel will not be able to reread the partition table unless /cdrom is unmounted [16:17] from /dev/sda2 [16:18] which is what I've always thought too, but it's worked out fine [16:18] I never really could identify why it worked [16:18] maybe it works provided that it's at the end [16:18] I really don't want to imply that it's supported, though [16:18] because I'll have to deal with the bugs when it breaks [16:18] cjwatson: we're up [16:18] cjwatson, yeah, i'm fine with a preseed like before to just support this case [16:18] but i think the warning is good for the general case [16:20] superm1: bet it wouldn't work if you attempted to resize /dev/sda2, for example [16:21] cjwatson, yeah I think resizing a live filesystem itself is asking for trouble, but just adding new partitions appears to be fine [16:21] especially since /dev/sda2 was vfat [16:21] can I reject all bugs from your users about breakage? ;-) [16:22] haha, well I doubt they would get to that point of filing bugs if they got a system broken from this [16:22] although, if it's just in the factory process, then it doesn't seem important to tweak the UI [16:22] I can do something about the continuing need for ubiquity/partman-skip-unmount [16:23] yeah it's just factory process. the recovery media imitates factory process as best as possible, but just asks a yes/no do you want to recover question [16:23] and then noninteractive? [16:23] well we're switching to automatic-ubiquity for 9.04 since vesa appears to finally be a feasible fallback [16:24] if it'd be useful, I can post an ISO of recovery media generated from today's daily CD and you can take a look at how things work [16:25] nah, it's OK, ISO downloads pretty slow for me as previously advertised :) [16:38] ok, i've added bug 354573 to keep track of the partman-base breakage. let me know if you need anything else for it [16:38] Launchpad bug 354573 in partman-base "Can no longer perform factory installs due to changes in partman-base" [Undecided,New] https://launchpad.net/bugs/354573 [16:38] superm1: ah, looking into the kernel in a bit more detail, it looks as if you can modify partitions precisely if they're after any mounted ones on the disk [16:39] superm1: "can no longer perform factory installs" is not the same as "there's a warning on-screen, but it works anyway" [16:39] which is it? :) [16:39] haha, well i'll put automated back in there :) [16:40] but it would work with ubiquity/partman-skip-unmount, wouldn't it? [16:41] superm1: BTW, in general I need the syslog too, but I'm assuming that it's the same log as in 354534 [16:41] well I did this w/o grub2, so it's a tad different. i'll add it [16:41] so I had ubiquity/partman-skip-unmount in the seed (attached the seed too) [16:42] warning still comes up with it there. [16:42] if that's taken out, then there is a ubiquity dialog box that pops up talking about /cdrom being mounted [16:42] the installation_medium_mounted warning should have no effect on automation, so we can take that out of the equation [16:43] I'd like to identify the dialog though [16:59] installation_medium_mounted is what's showing up on the partitioner page. w/o ubiquity/partman-skip-unmount, ubiquity/partman-failed-unmount is also shown (and the install can't proceed) [17:01] perhaps, the reason why the automation is bogging out for the partitioner page - the recovery partition does not take up "most of the disk", so that check for it doing so wouldn't pass === Nicke_ is now known as Nicke [17:28] superm1: that check only governs the warning, which shouldn't affect automation [17:28] oh [17:29] well, it also governs whether the device shows up in partman at all, but in that respect the current behaviour is in your favour === nxvl_ is now known as nxvl [21:40] cjwatson, oh, i was just reading through changelogs a little, and then saw that partman-auto 84ubuntu2's stood out. "Exclude devices containing the installation medium from automatic partitioning (LP: #347916)". That sounds like the situation considering we've got a recipe that uses automatic [21:45] cjwatson, yup, I just tried reverting the diff from 84ubuntu1 to 84ubuntu2 and --automatic works again [22:04] cjwatson: hey, for intrepid, in the alternate installer, we have some debconf text that tells the user to record their randomly generated passphrase if they setup an encrypted private [22:05] cjwatson: we seem to have lost that page in the alt/server installer for jaunty [22:05] cjwatson: could we get that page back? [22:18] superm1: sigh, I wish your requirements weren't so different from everyone else's :-/ [22:18] superm1: I think we'll just have to reintroduce partman/filter_mounted [22:18] kirkland: um, you removed that [22:18] cjwatson: okay, i'll go take a look [22:19] kirkland: was it not obsolete with encrypted-home? [22:19] cjwatson: the first half is obsolete [22:19] cjwatson: "do you want to pick a password, or generate one" [22:19] cjwatson: we always generate one [22:19] cjwatson: the next screen though is needed [22:20] cjwatson: "your generated password is BLAH, write this down!" [22:20] put a branch up and I'll review it [22:20] aim for minimal string changes (ideally a strict subset of what was there before, if possible), please [22:20] cjwatson: k, will do [22:20] cjwatson: i think it will be identical [22:20] cjwatson: what's the specific package? usersetup? [22:21] user-setup [22:21] cjwatson: thanks. [22:21] lp:~ubuntu-core-dev/user-setup/ubuntu [23:28] partman-base: cjwatson * r150 ubuntu/ (debian/changelog init.d/parted): [23:28] partman-base: Support partman/filter_mounted preseeding again, for some special cases [23:28] partman-base: that know they can get away with modifying partitions after the one [23:28] partman-base: containing the installation medium (LP: #354573). [23:31] superm1: I'm reverting your description back to the original; partman-auto uses information that partman-base writes out, and so simply restoring partman/filter_mounted preseeding is both more generally applicable and more elegant [23:31] well, more or less the original [23:34] partman-base: cjwatson * r151 ubuntu/debian/changelog: releasing version 129ubuntu6 [23:39] ubiquity: cjwatson * r3179 ubiquity/ (d-i/manifest debian/changelog): Automatic update of included source packages: partman-base 129ubuntu6. [23:45] ubiquity: cjwatson * r3180 ubiquity/debian/changelog: releasing version 1.12.3