| === Ursinha is now known as Marvin_ | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === salgado-afk is now known as salgado | ||
| barry | #startmeeting | 15:01 |
|---|---|---|
| MootBot | Meeting started at 09:01. The chair is barry. | 15:01 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:01 |
| barry | hello and welcome to this week's ameu reviewer's meeting. who's here today? | 15:01 |
| bac | me | 15:01 |
| abentley | me | 15:01 |
| gary_poster | me | 15:01 |
| rockstar | me | 15:01 |
| mars | me | 15:01 |
| al-maisan | me | 15:01 |
| adeuring | me | 15:01 |
| BjornT | me | 15:01 |
| henninge | me | 15:01 |
| noodles775 | me | 15:01 |
| bigjools | me | 15:01 |
| gmb | me | 15:02 |
| barry | cprov: ping | 15:02 |
| barry | danilos: ping | 15:02 |
| danilos | me | 15:02 |
| barry | EdwinGrubbs: ping | 15:02 |
| cprov | me | 15:02 |
| EdwinGrubbs | me | 15:03 |
| barry | intellectronica: ping | 15:03 |
| intellectronica | me | 15:03 |
| barry | salgado: ping | 15:03 |
| barry | [TOPIC] agenda | 15:03 |
| MootBot | New Topic: agenda | 15:03 |
| salgado | me | 15:03 |
| barry | * Roll call | 15:03 |
| barry | * Don't forget your OCR slot | 15:03 |
| barry | * Action items | 15:03 |
| barry | * Mentoring update | 15:03 |
| barry | * need a volunteer to mentor noodles | 15:03 |
| barry | * Peanut gallery (anything not on the agenda) | 15:03 |
| barry | * JS coding guidelines (mars, intellectronica) | 15:03 |
| barry | * ampersands-in-urls (abentley) | 15:03 |
| barry | [TOPIC] * Don't forget your OCR slot | 15:04 |
| MootBot | New Topic: * Don't forget your OCR slot | 15:04 |
| barry | i've heard some rumors that folks sometimes miss their ocr slot. just wanted to ask that you please try to fill them. we all count on each other to get branches reivewed and landed | 15:05 |
| barry | i know we're all busy, but think of the team! | 15:05 |
| barry | if you really can't fill your slot for some reason, please let me or your fellow reviewers know, and try to find a backup if possible | 15:05 |
| barry | and remember, we have sabbaticals if you're burned out for a while | 15:06 |
| barry | that's it from me! any thoughts? | 15:06 |
| cprov | yeah, I feel guilty. | 15:06 |
| al-maisan | I will be on secondment to the foundations team for the next 3 months | 15:07 |
| abentley | barry: Perhaps, let everyone know if you | 15:07 |
| fjlacoste | me | 15:07 |
| abentley | 're sick and can't find a replacement. | 15:07 |
| bigjools | al-maisan: Ubuntu Foundations, to be precise | 15:07 |
| barry | abentley: +1 | 15:07 |
| al-maisan | ..and hence not in a position to review on Tuesdays | 15:07 |
| abentley | (rather than just reviewers) | 15:07 |
| barry | a quick email to the ml would help | 15:07 |
| al-maisan | bigjools: thanks for the correction :) | 15:07 |
| cprov | fjlacoste: is this nick the dutch version for 'flacoste' ? | 15:08 |
| barry | al-maisan: cool, we'll need to shuffle ocr schedule around | 15:08 |
| al-maisan | barry: thanks! | 15:08 |
| barry | al-maisan: i'll mark up ReviewerSchedule. tuesdays aren't too bad, with gmb in euro and bac & rockstar in west | 15:09 |
| al-maisan | OK .. that's good. | 15:09 |
| danilos | I am off this Thursday (swap day) | 15:09 |
| danilos | which means, no euro coverage tomorrow unless someone wants to take over | 15:09 |
| cprov | danilos: err, me too, I was counting on you ... | 15:09 |
| * bigjools has a 10k branch coming soon as well, what a shame | 15:10 | |
| danilos | any candidate willing to take Thursday out of my hands is welcome to | 15:10 |
| bigjools | 10k LOC, that is | 15:10 |
| barry | danilos: ouch! no coverage for tomorrow? | 15:10 |
| rockstar | This meeting probably isn't a good venue to share when you'll miss OCR | 15:10 |
| cprov | barry: it's already bad now that I'm on EU timezone. | 15:10 |
| danilos | rockstar: well, if we are reminded how we need to find a replacement, it might be a good place to find one | 15:10 |
| danilos | cprov, barry: ok, let's take this outside the meeting | 15:11 |
| gmb | bigjools: Good luck with that ;) | 15:11 |
| rockstar | danilos: at the expense of the other things on the agenda? | 15:11 |
| * cprov nods | 15:11 | |
| bigjools | r=gmb! | 15:11 |
| al-maisan | :) | 15:11 |
| gmb | AHAHAAHAHANo. | 15:11 |
| danilos | rockstar: if it's easy, yes... since nobody has volunteered, it's not, so let's move on | 15:11 |
| barry | cprov: we can move you to euro slot and we can split up bac/rockstar or salgado/barry | 15:11 |
| barry | i will now skip around | 15:12 |
| barry | [TOPIC] mentoring update | 15:12 |
| MootBot | New Topic: mentoring update | 15:12 |
| barry | * need a volunteer to mentor noodles | 15:12 |
| barry | we need a mentor for noodles, preferrably in euro timeslot | 15:12 |
| cprov | I can do it. | 15:12 |
| noodles775 | Thanks cprov :) | 15:13 |
| barry | cprov: awesome thanks | 15:13 |
| cprov | It's my pleasure. | 15:13 |
| barry | cprov, noodles775 we'll discuss off line where we can slot you guys in | 15:13 |
| noodles775 | Yup | 15:13 |
| cprov | okay | 15:13 |
| henninge | off-line? like writing letters? | 15:13 |
| henninge | ;) | 15:14 |
| rockstar | henninge: yes. Support your local post. | 15:14 |
| barry | henninge: pigeon (not pidgin :) | 15:14 |
| barry | henninge: any word on your mentoring? how's it going? | 15:14 |
| abentley | rockstar: In soviet canada, posts support you. | 15:14 |
| rockstar | abentley: :) | 15:14 |
| henninge | barry: very well, thank you | 15:14 |
| henninge | barry: very well, thank you | 15:15 |
| henninge | barry: adeuring is doing a good job | 15:15 |
| barry | i knew he would! good to hear, thanks | 15:15 |
| barry | any other mentoring issues? | 15:16 |
| adeuring | well, I'd say, no complaints with henninge's work :) | 15:16 |
| henninge | adeuring: ;) | 15:16 |
| barry | adeuring: i hope you're cracking the whip! | 15:17 |
| barry | :) | 15:17 |
| adeuring | barry: from time to time ;) | 15:17 |
| barry | :-D | 15:17 |
| barry | [TOPIC] action items | 15:17 |
| MootBot | New Topic: action items | 15:17 |
| barry | * gary_poster to take importfascist and rSP() discussion to ml | 15:18 |
| gary_poster | h'ain't done it. Intend to do it today. | 15:18 |
| barry | gary_poster: cool | 15:18 |
| barry | * allenap to look into storm/sqlobject result set compatibility | 15:19 |
| barry | oops, he's not here | 15:19 |
| gmb | allenap's away this week | 15:19 |
| barry | * flacoste to work on API reviewer cheat sheet | 15:19 |
| gmb | I suspect he didn't get very far though | 15:19 |
| fjlacoste | i didn't | 15:19 |
| barry | gmb: nod | 15:19 |
| barry | fjlacoste: keep it on the list? :) | 15:19 |
| fjlacoste | sure | 15:20 |
| bigjools | he changed his nick this week out of embarassment maybe | 15:20 |
| fjlacoste | lol | 15:20 |
| barry | cool | 15:20 |
| barry | [TOPIC] * Peanut gallery (anything not on the agenda) | 15:20 |
| MootBot | New Topic: * Peanut gallery (anything not on the agenda) | 15:20 |
| barry | actually, there were two items we didn't get to from last week | 15:20 |
| barry | * JS coding guidelines (mars, intellectronica) | 15:20 |
| fjlacoste | mthaddon: can we close merge to devel? | 15:20 |
| barry | mars, intellectronica can either of you talk about this today? | 15:21 |
| gary_poster | fjlacoste: wrong room :-) | 15:21 |
| intellectronica | i don't remember raising this. mars? | 15:21 |
| mars | barry, yep | 15:21 |
| barry | mars: the floor is yours | 15:21 |
| intellectronica | perhaps just to remind about testing with devmode off as part of the review | 15:21 |
| mars | so this is a question to the JavaScript coders in the room | 15:21 |
| mars | in Python, we are always explicit in comparisons: if x is not None | 15:22 |
| mars | instead of: if !x | 15:22 |
| === fjlacoste is now known as flacoste | ||
| barry | mars: does js have the same expanded notion of trueness/falseness as python, or is it more strict like java? | 15:23 |
| mars | so Tom and I were debating doing the same in JavaScript. I prefer the coercive form, he prefers explicit | 15:23 |
| mars | barry, the types aren't as clean | 15:23 |
| intellectronica | barry: it's even more lax, and very confusing, with coercing to boolean | 15:23 |
| rockstar | I prefer the explicit, but it's not always possible. | 15:23 |
| mars | barry, in JavaScript, null == undefined == 0 == false | 15:23 |
| rockstar | Er, not always clean. | 15:24 |
| intellectronica | my position was that i like the explicit version, having learned to appreciate it coding (and reading) python | 15:24 |
| mars | right | 15:24 |
| rockstar | intellectronica: I tend to agree with you. | 15:24 |
| barry | rockstar: why is it not always possible? | 15:24 |
| mars | and mine was that because JavaScript can throw 'undefined' at you, you need the coercive form | 15:24 |
| intellectronica | rockstar: both options are possible technically. it's just a matter of style | 15:24 |
| gary_poster | mochikit has a whole equivalence framework in part because of the JS bool mess (but there are other nastinesses as well) | 15:24 |
| mars | gary_poster, yech | 15:24 |
| mars | didn't know that | 15:25 |
| rockstar | barry: intellectronica: I've been bitten by bugs in cases of empty strings evaluating to true. | 15:25 |
| barry | ew | 15:25 |
| EdwinGrubbs | I just worry about all tests having to be (x === null or x === undefined) which is unweildy. | 15:25 |
| bigjools | oof | 15:25 |
| mars | barry, and [] and {} are also true | 15:25 |
| intellectronica | rockstar: well, that's exactly why you'd want to compare explicitly | 15:25 |
| barry | ew ew | 15:25 |
| rockstar | I feel like === means we're back to php land. | 15:25 |
| rockstar | intellectronica: so you're saying I should have used if x != '' | 15:26 |
| intellectronica | rockstar: yup | 15:26 |
| barry | remember that in our python style guide, we're allowed to use "if not foo:" when foo can be of several types (e.g. None or [] for example) | 15:26 |
| intellectronica | rockstar: or use foo.length | 15:26 |
| barry | we just require a comment explaining that the simpler choice was deliberate | 15:26 |
| rockstar | We kinda lose the loose typing at that point. :/ | 15:26 |
| intellectronica | explicit comparison is an easy rule to follow. just compare explicitly to anything you might expect be in the value | 15:26 |
| flacoste | rockstar: if x !== '' | 15:26 |
| mars | barry, ok, in JavaScript, you sometimes still want explicit comparison, if null is a flag value | 15:27 |
| rockstar | flacoste: yea, I know. Was in a hurry. | 15:27 |
| barry | mars: yep | 15:27 |
| abentley | barry: Even so, I find "if foo == [] or foo is None" shorter than "if not foo" plus a comment. | 15:27 |
| mars | barry, so in my mind the question more revolves around the 'wandering undefineds' problem | 15:27 |
| rockstar | Okay, I think we should be explicit, and anywhere we aren't requires some serious 'splainin. | 15:28 |
| intellectronica | rockstar: loose typing is sometimes great, and sometimes it makes the code hard to read. if you have loose typing it's up to you to protect against getting values you don't expect | 15:28 |
| barry | abentley: well, if len(foo) == 0 or foo is None, but it /is/ more explicit | 15:28 |
| rockstar | intellectronica: yes, this is true. Python really is awesome at its typing. | 15:28 |
| barry | aren't unexpected undefineds a sign of buggy code? | 15:29 |
| mars | so, is "if (!config) {}" hard to read? | 15:29 |
| barry | mars: not hard to read, hard to know the intent | 15:30 |
| mars | intellectronica, rockstar, because 'config' could be null, if the user explicity said "I don't want this parameter", or "undefined", if the user just passed in some_config_obj.some_attr | 15:30 |
| intellectronica | mars: it is, yes, harder than if (config !== null && config !== undefined) | 15:30 |
| rockstar | mars: yeah, I agree with intellectronica | 15:30 |
| mars | ok. I should ask what you guys thing of trinary operators too, because that is the other place where I use coercion | 15:31 |
| intellectronica | trinary operators? as in condition ? then-expr : else-expr ? | 15:31 |
| mars | var bar = cfg ? cfg.foo : 0; | 15:31 |
| * barry looks at his own first pathetic attempt at js and realizes he needs to fix his code ;) | 15:32 | |
| mars | but I guess the intent there is clear | 15:32 |
| mars | and it's idiomatic, so no issue? | 15:32 |
| intellectronica | mars: thses should be used sparingly, but when you do, there's no reason why you can't use the verbose version | 15:32 |
| intellectronica | the case above is quite idiomatic | 15:32 |
| barry | mars: i would love to see parentheses after the = and before the ; | 15:32 |
| rockstar | mars: let us avoid them. Clarity in code, and optimization when the javascript is "compiled" | 15:32 |
| intellectronica | but following a simple rule is so much easier than making exceptions for idioms or whatever | 15:33 |
| rockstar | intellectronica: +1 | 15:33 |
| barry | intellectronica: +1 | 15:33 |
| gmb | +1 | 15:33 |
| noodles775 | +1 | 15:34 |
| barry | do we need to vote? mars? | 15:34 |
| mars | you guys would have a great time browsing the jquery source code then :) | 15:34 |
| intellectronica | :D | 15:34 |
| mars | barry, ^ that looks like a vote to me | 15:34 |
| rockstar | mars: :) | 15:34 |
| mars | a majority vote, rather | 15:34 |
| barry | yep | 15:34 |
| rockstar | DONE! | 15:35 |
| barry | [AGREED] explicit is better than implicit in javascript comparisons | 15:35 |
| MootBot | AGREED received: explicit is better than implicit in javascript comparisons | 15:35 |
| barry | * ampersands-in-urls (abentley) | 15:35 |
| barry | abentley: i don't remember the details on this, do you? | 15:35 |
| abentley | barry: We didn't talk much. | 15:35 |
| barry | abentley: the floor is yours | 15:36 |
| abentley | Everyone knows that ampersands must be provided as entity references in HTML, right? | 15:36 |
| abentley | e.g. & | 15:36 |
| abentley | Everyone knows that this applies when the ampersand is part of a URL in an attribute, right? | 15:37 |
| mars | yes :) | 15:37 |
| abentley | e.g. <a href="example.ort?a=b&c=d"> | 15:37 |
| mars | no, I didn't know that | 15:37 |
| abentley | mars: It is very common to do otherwise, but it's not valid HTML. | 15:38 |
| mars | would the w3c validator catch that? Or our linter? | 15:38 |
| intellectronica | abentley: i think the nest solution for that is to build your URL in python, using a formatter | 15:38 |
| intellectronica | it's quite rare that you'll have a fixed URL with GET parameters you can include in a template directly | 15:38 |
| abentley | mars: I think the wc3 validator would. I can report back if you like. | 15:39 |
| barry | abentley: wouldn't that be example.ort?a=b%26b&b=c ? | 15:39 |
| abentley | intellectronica: That's kinda where I'm going to. Should we be calling "escape" on URLs that we provide to TAL as part of a structure? | 15:39 |
| mars | abentley, we first need to answer a larger question - it is valid HTML, but do we actually feel the need to adhere to it strictly? | 15:40 |
| rockstar | barry: yea, that is right. | 15:40 |
| mars | abentley, I ask because I don't know if we absolutely ensure we have valid markup throughout Launchpad | 15:40 |
| mars | abentley, or if it is a "nice to have" | 15:40 |
| rockstar | mars: it's a goal we should aspire to. | 15:40 |
| abentley | barry: No, that would make the value of a "b&" | 15:40 |
| abentley | barry: I think. | 15:40 |
| intellectronica | abentley: i think we need to go further, and have a function that builds the url for us from base url and a two-tuple of query parameters | 15:40 |
| mars | rockstar, agreed | 15:41 |
| barry | th evalue would be 'b&b' | 15:41 |
| barry | was that not the intent? | 15:41 |
| abentley | barry: no. | 15:41 |
| barry | er, sorry, 'b&' | 15:41 |
| abentley | The intent was a=b, c=d | 15:41 |
| rockstar | Well, in the case that brought this up, I was just using canonical_url, so maybe canonical_url would be good to escape these things. | 15:42 |
| BjornT | rockstar: canonical_url is used in other places than html templates | 15:42 |
| abentley | rockstar: If canonical_url html-escaped the URLs, they would not be valid URLs. They would be the HTML-escaped forms of valid URLs. | 15:43 |
| barry | intellectronica: well, urlllib.urlencode() is more or less what we should be using i think | 15:43 |
| rockstar | BjornT: okay, I was just throwing it out there. | 15:43 |
| barry | and we may already be using it | 15:43 |
| abentley | barry: The unescaped URL is "example.ort?a=b&c=d" and the escaped version is "example.ort?a=b&c=d" | 15:44 |
| intellectronica | but if canonical_url would accept query parameters, all we need is for fmt:url to escape the result | 15:44 |
| intellectronica | or maybe i'm talking nonsense, because how would you pass the parameters to fmt:url :-/ | 15:45 |
| barry | abentley: how does a url parser know that your second example doesn't map to {'a':'b', 'amp;c':'d'} ? | 15:45 |
| abentley | intellectronica: Right. TAL can DTRT if we let it. But if we pass it as a structure, we have to take care of it ourselves. | 15:45 |
| abentley | barry: A URL parser should not see the escaped version, because the HTML parser should have already decoded it. | 15:46 |
| intellectronica | abentley: so i guess just 1. make canonical_url accept query_parameters. 2. add a wrapper around it that escapes the result | 15:46 |
| rockstar | intellectronica: +1 | 15:46 |
| barry | well, the html parser then. seems ambiguous syntax to me | 15:46 |
| abentley | barry: & always introduces an entity reference. Where's the ambiguity? | 15:46 |
| flacoste | abentley: you are saying that all urls containing & to separate query parameters in HTML should be escaped? | 15:47 |
| BjornT | intellectronica: why do we need a wrapper, instead of using escape() on the result? | 15:47 |
| barry | well not always. it doesn't in the a=b&c=d case (even if that's not standard, its widespread common practice) | 15:47 |
| intellectronica | BjornT: one less function to call. but i agree, it doesn't matter that much | 15:47 |
| abentley | flacoste: Yes. | 15:48 |
| flacoste | <a href="?param1=value1&param2=value2">? | 15:48 |
| flacoste | the above would be correct? | 15:48 |
| BjornT | flacoste: you could simplify that by saying that all urls in html should be escaped | 15:48 |
| flacoste | but nobody does that! | 15:48 |
| abentley | barry: The spec is unambiguous. Browsers have to be more careful. | 15:48 |
| flacoste | that's non-sense | 15:48 |
| flacoste | all of the web is broken | 15:48 |
| flacoste | i mean even gmail doesn't escape it's URLs | 15:48 |
| abentley | flacoste: Okay, so your vote is to ignore the parts of HTML that we don't like? | 15:48 |
| flacoste | yes | 15:49 |
| barry | abentley: maybe, but in that case, it's all guesswork | 15:49 |
| flacoste | especially if it's a part that nobody cares about | 15:49 |
| BjornT | intellectronica: well, using escape means one less function to maintain. it also seems that passing query parameters to canonical_url is quite rare; usually we have specific views we pass the parameters to | 15:49 |
| mars | flacoste, yes, same goes for CSS IE hacks - it generates invalid CSS, but pragmatism justifies it | 15:49 |
| rockstar | flacoste: that sounds very Microsoft of you. :) | 15:49 |
| abentley | barry: That's right. Wouldn't it be nice if more sites provided valid HTML so they didn't have to? | 15:49 |
| barry | abentley: sure. but it'll never happen :) | 15:49 |
| flacoste | abentley: did you try HTML escaping a URL in an href? | 15:49 |
| barry | abentley: can you tell me, are you trying to solve a real problem (i.e. is there an open bug)? | 15:50 |
| abentley | flacoste: I've done it in the past. I didn't do it specifically for this meeting. | 15:50 |
| flacoste | abentley: and the browser submitted the right thing? | 15:50 |
| barry | abentley: i'm not being facetious. i'm really curious if we have users who are affected by this | 15:50 |
| abentley | barry: It's not related to a bug. It's something that came up in a review. | 15:51 |
| barry | abentley: ah, ok, thx | 15:51 |
| abentley | flacoste: Yes. | 15:51 |
| barry | abentley: i'm sorry, we've run out of time again. and apologies for going late today. perhaps we can take this to the ml? | 15:51 |
| BjornT | flacoste: gmail's front page does escape &. at least the links i looked at | 15:51 |
| flacoste | really! | 15:52 |
| BjornT | flacoste: also, we usually do it in launchpad as well, because tal does it for us | 15:53 |
| abentley | flacoste: On this page, the "wish I were an asshole" link is escaped: http://aaronbentley.com/music/news/myspaced-11-09-2006 | 15:53 |
| flacoste | and amazon too, look at that! | 15:53 |
| flacoste | you learn something new everyday! | 15:54 |
| abentley | barry: No worries. I'm not sure it's worth ML discussion, even. | 15:54 |
| barry | we should do this by not doing this <wink>. iow, whatever code we use to inject these urls into html pages should do it for us | 15:54 |
| barry | abentley: ok. let's cut this off then, since we're 10 minutes over | 15:55 |
| BjornT | barry: that's how it works today, except that you can turn it off by using structure | 15:55 |
| barry | BjornT: so structure should dtrt! | 15:55 |
| barry | anyway, we can take this up again next week or go to the ml | 15:56 |
| abentley | barry: I think that would involve AI... | 15:56 |
| barry | #endmeeting | 15:56 |
| MootBot | Meeting finished at 09:56. | 15:56 |
| intellectronica | thanks barry | 15:56 |
| barry | apologies for going over today | 15:56 |
| abentley | thanks barry | 15:56 |
| barry | abentley: thanks for bringing this up! | 15:56 |
| === salgado is now known as salgado-lunch | ||
| === salgado-lunch is now known as salgado | ||
| === Marvin_ is now known as Ursinha | ||
| === Ursinha is now known as Marvin_ | ||
| === salgado is now known as salgado-afk | ||
| mwhudson | barry: hello | 23:31 |
| barry | #startmeeting | 23:32 |
| MootBot | Meeting started at 17:32. The chair is barry. | 23:32 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 23:32 |
| barry | mwhudson: hi | 23:32 |
| barry | jml: hi | 23:32 |
| barry | thumper: hi | 23:32 |
| barry | jml, thumper ping? | 23:32 |
| jml | hi | 23:32 |
| barry | [TOPIC] agenda | 23:33 |
| MootBot | New Topic: agenda | 23:33 |
| barry | * Roll call | 23:33 |
| barry | * Action items | 23:33 |
| barry | * Peanut gallery (anything not on the agenda) | 23:33 |
| barry | * JS coding guidelines (mars, intellectronica) | 23:33 |
| barry | * ampersands-in-urls (abentley) | 23:33 |
| barry | any word from thumper? | 23:33 |
| jml | he said he was going to attend. | 23:34 |
| mwhudson | i'm sure he'll read this eventually :) | 23:34 |
| barry | ok, we'll just start anyway :) | 23:34 |
| thumper | hereish | 23:34 |
| barry | [TOPIC] update from ameu | 23:34 |
| MootBot | New Topic: update from ameu | 23:34 |
| barry | so a couple of things from the ameu meeting... | 23:35 |
| barry | al-maisan will be on load to ubuntu foundations for the next 3 months so won't be doing reviews | 23:35 |
| barry | cprov moved to euro timezone and will be mentoring noodles | 23:35 |
| mwhudson | ubuntu foundations ? | 23:35 |
| barry | i'll need to juggle the ocr schedule a bit | 23:35 |
| barry | mwhudson: apparently so! | 23:36 |
| mwhudson | which team is that again? cjwatson's? | 23:36 |
| jml | well, Robbie's the manager, but yes. | 23:36 |
| barry | danilo_ and cprov are off tomorrow, lots of people are off on friday (not us nose-to-the-grindstone americans tho) | 23:36 |
| barry | dunno what he'll be working on | 23:36 |
| mwhudson | ok | 23:37 |
| barry | we talked about javascript coding guidelines for true/false comparisons and decided that our js code should follow python's eibti rules | 23:37 |
| barry | i.e. if (foo === undefined) over if (!foo) | 23:38 |
| mwhudson | okay | 23:38 |
| * thumper hopes if (!foo) | 23:38 | |
| jml | sure. as long as it works. | 23:38 |
| barry | we also had a long discussion about escaping & in url query strings, without any resolution | 23:38 |
| barry | thumper: sorry, nope | 23:38 |
| mwhudson | are our javascript coding guidelines written down anywhere? | 23:39 |
| thumper | :( | 23:39 |
| barry | thumper: mars was the lone holdout | 23:39 |
| jml | I can't spot the question being responded to | 23:39 |
| mars | mwhudson, http://dev.launchpad.net/JavaScriptReviewNotes | 23:39 |
| barry | mwhudson: such as they are: https://dev.launchpad.net/JavaScriptReviewNotes | 23:39 |
| barry | mars: hi! this reminds me: can you capture this decision on that page? | 23:40 |
| mars | sure | 23:40 |
| mwhudson | mars, barry: thanks | 23:40 |
| barry | mars: thanks | 23:40 |
| barry | that's it from ameu | 23:40 |
| barry | [TOPIC] action items | 23:40 |
| MootBot | New Topic: action items | 23:40 |
| barry | no action items for asiapac | 23:41 |
| barry | [TOPIC] mentoring update | 23:41 |
| MootBot | New Topic: mentoring update | 23:41 |
| barry | none for you guys ;) | 23:41 |
| barry | that's really all i have, so... | 23:41 |
| barry | [TOPIC] peanut gallery | 23:42 |
| MootBot | New Topic: peanut gallery | 23:42 |
| barry | do you guys have anything you want to bring up? | 23:42 |
| jml | nothing from me. there's not been any code to review :) | 23:42 |
| mwhudson | heh yeah | 23:42 |
| mwhudson | integration iz us | 23:42 |
| barry | you guys are welcome to join me friday america time :) | 23:42 |
| barry | well, if there's nothing else... | 23:43 |
| jml | still no. | 23:44 |
| barry | okay! | 23:44 |
| barry | #endmeeting | 23:44 |
| MootBot | Meeting finished at 17:44. | 23:44 |
| barry | thanks guys | 23:44 |
| mwhudson | thanks barry | 23:44 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!