=== salgado-afk is now known as salgado | ||
=== salgado is now known as salgado-afk | ||
=== salgado-afk is now known as salgado | ||
=== mrevell is now known as mrevell-lunch | ||
barry | #startmeeting | 15:00 |
---|---|---|
MootBot | Meeting started at 09:00. The chair is barry. | 15:00 |
MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:00 |
gary_poster | me | 15:00 |
barry | hello everyone and welcome to this week's ameu reviewer's meeting. who's here today? | 15:01 |
gary_poster | (first post, first post!) | 15:01 |
gary_poster | uh, me | 15:01 |
danilos | me | 15:01 |
danilos | gary_poster: :) | 15:01 |
adeuring | me | 15:01 |
noodles775 | me too | 15:01 |
henninge | me!!! ;) | 15:01 |
bigjools | me | 15:01 |
gmb | Mi. | 15:01 |
mars | me | 15:01 |
henninge | gmb: It's Mii | 15:01 |
bac | me | 15:01 |
henninge | as in Wii | 15:01 |
intellectronica | me | 15:02 |
gmb | henninge: I was banging on the keyboard like a monkey. Be thankful you got what you did. | 15:02 |
salgado | me | 15:02 |
gary_poster | lol | 15:02 |
barry | allenap: ping | 15:02 |
allenap | me | 15:03 |
barry | BjornT, cprov, EdwinGrubbs ping | 15:03 |
cprov | me | 15:03 |
BjornT | me | 15:03 |
flacoste | me | 15:03 |
barry | rockstar: sinzui ping | 15:04 |
barry | [TOPIC] == Agenda == | 15:04 |
barry | * Roll call | 15:04 |
barry | * Action items | 15:04 |
barry | * Mentoring update | 15:04 |
barry | * Peanut gallery (anything not on the agenda) | 15:04 |
MootBot | New Topic: == Agenda == | 15:04 |
sinzui | me | 15:04 |
barry | [TOPIC] * Action items | 15:04 |
MootBot | New Topic: * Action items | 15:04 |
barry | * gary_poster to take importfascist and rSP() discussion to ml | 15:04 |
gary_poster | no, sorry | 15:04 |
barry | gary_poster: next time? :) | 15:04 |
gary_poster | I hope so :-) Looking for that info now | 15:05 |
barry | cool, thx | 15:05 |
barry | * flacoste to work on API reviewer cheat sheet | 15:05 |
* flacoste whistles | 15:05 | |
barry | :) | 15:05 |
barry | [TOPIC] * Mentoring update | 15:05 |
MootBot | New Topic: * Mentoring update | 15:05 |
bigjools | whistling while you work? | 15:05 |
sinzui | It's not exported until there is a test | 15:06 |
* sinzui found a field that was not really exported, and there was no test to verify it was broken | 15:06 | |
barry | any updates, problems, issues, questions, comments from mentats or mentors? | 15:06 |
henninge | I'm fine . | 15:06 |
noodles775 | not really... I'm enjoy the learning process so far :) | 15:06 |
barry | great! | 15:07 |
barry | thanks mentors | 15:07 |
barry | [TOPIC] * Peanut gallery (anything not on the agenda) | 15:07 |
MootBot | New Topic: * Peanut gallery (anything not on the agenda) | 15:07 |
barry | that's all i have for today, do you all have anything? | 15:08 |
barry | i guess not | 15:09 |
barry | looks like maybe we're done in record time? | 15:09 |
henninge | Y nodd | 15:09 |
henninge | ;) | 15:09 |
barry | 5 | 15:09 |
barry | 4 | 15:09 |
barry | 3 | 15:09 |
barry | 2 | 15:09 |
barry | 1 | 15:09 |
barry | #endmeeting | 15:09 |
MootBot | Meeting finished at 09:09. | 15:09 |
bigjools | wow | 15:09 |
allenap | Wow. | 15:09 |
barry | thanks everyone! see you in barcelona | 15:10 |
bigjools | si | 15:10 |
gary_poster | bye | 15:10 |
barry | where we'll have a 5 hour reviewers meeting to make up for lost time | 15:10 |
bigjools | barry: don't forget your "friends" :) | 15:10 |
allenap | Can everyone leave the swine flu at home? | 15:10 |
barry | bigjools: thanks! :) | 15:10 |
barry | bye bye | 15:11 |
=== mrevell-lunch is now known as mrevell | ||
=== e-jat is now known as b | ||
=== b is now known as e-jat | ||
=== salgado is now known as salgado-lunch | ||
=== salgado-lunch is now known as salgado | ||
=== mrevell is now known as mrevell-dinner | ||
barry | #startmeeting | 23:32 |
jml | hi? | 23:32 |
MootBot | Meeting started at 17:32. The chair is barry. | 23:32 |
MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 23:32 |
jml | wasn't it in +0.5? | 23:32 |
barry | i think we're on the half hour | 23:32 |
barry | AsiaPac Wednesday 13-May-2009 2230 UTC - 2315 UTC | 23:33 |
barry | thumper, mwhudson are you here? | 23:33 |
mwhudson | yeah | 23:33 |
thumper | yeah | 23:33 |
barry | i really have almost nothing, so i'll dispense with the formalities and throw it open to you guys | 23:33 |
mwhudson | hey, this cycle is really short | 23:34 |
barry | mwhudson: indeed, but it's been my most productive one in months :) | 23:34 |
barry | thumper: you had an item? | 23:34 |
thumper | yes | 23:34 |
thumper | I've moved the LaunchpadObjectFactory to live in lp.testing.factory | 23:35 |
thumper | and login, logout et al lp.testing | 23:35 |
thumper | reviews should check this now | 23:35 |
jml | phone, sorry | 23:35 |
thumper | there are compability shims in canonical.launchpad.testing | 23:35 |
thumper | that I'd like to see go | 23:35 |
barry | thumper: cool, thanks for doing the rename. | 23:35 |
thumper | but there were like a million places in the code | 23:35 |
thumper | so I didn't do that | 23:35 |
thumper | and my awk foo isn't that good | 23:35 |
barry | thumper: i know a great language that you could write it in | 23:36 |
thumper | I did consider it | 23:36 |
thumper | but it isn't a simple 1 -> 1 move | 23:36 |
barry | thumper: actually (seriously) check with sinzui. he may have all the basic pieces | 23:36 |
thumper | not enough | 23:36 |
thumper | I used the rename-module script for most of it | 23:36 |
thumper | but due to circular import crap | 23:37 |
barry | thumper: oh, and doctests /should/ be easy since none of them should explicitly import it | 23:37 |
thumper | I couldn't import the factory into lp.testing.__init__ | 23:37 |
sinzui | lp-dev-utils/migrater/rename_module path_to_old path_to_new | 23:37 |
thumper | barry: they are done | 23:37 |
thumper | barry: I fixed the globs | 23:37 |
barry | thumper: cool | 23:37 |
barry | thumper: why does lp.testing.__init__ need it? | 23:37 |
thumper | barry: it doesn't | 23:38 |
thumper | but the old import did that | 23:38 |
sinzui | thumper: do you want to do a find and replace of an import path across the whole tree? | 23:38 |
thumper | so you could get the factory from canonical.launchpad.testing | 23:38 |
barry | oh i see, and call sites used the old import | 23:38 |
thumper | now you need to get it from lp.testing.factory | 23:38 |
thumper | but login et al can come from lp.testing | 23:38 |
thumper | sinzui: for a single class, yes | 23:38 |
thumper | sinzui: although you could do it if you like :) | 23:39 |
thumper | also, much mail stuff moved into lp.services.mail | 23:39 |
thumper | so | 23:39 |
thumper | sendmail | 23:39 |
thumper | signed_message | 23:39 |
thumper | some others | 23:39 |
thumper | more needs to move | 23:39 |
thumper | but I did some | 23:39 |
sinzui | lp-dev-utils/migrater/find.py [-s 'new.path'] . . 'python_re_pattern' | 23:40 |
sinzui | thumper: send me the module old and new path | 23:40 |
barry | thumper: can you add deprecation warnings to the shims? i think that will fail the tests though | 23:40 |
thumper | sinzui: LaunchpadObjectFactory from canonical.launchpad.testing to lp.testing.factory | 23:40 |
thumper | barry: that was all | 23:41 |
thumper | barry: that and poking others to continue moving stuff | 23:41 |
thumper | :( | 23:41 |
thumper | plasma just died | 23:41 |
barry | thumper: cool. i suggest an email to the ml to motivate devs to do drive bys | 23:41 |
thumper | relentless poking at all hands should suffice | 23:42 |
barry | cool, thanks | 23:42 |
barry | anything else from you guys? | 23:42 |
thumper | not from me | 23:42 |
barry | jml, mwhudson ? | 23:42 |
barry | 4 | 23:43 |
barry | 3 | 23:43 |
mwhudson | i'm moving canonical.codehosting to lp.codehosting\ | 23:43 |
mwhudson | noone else should care though | 23:43 |
barry | mwhudson: +1 | 23:43 |
barry | 5 | 23:43 |
barry | 4 | 23:43 |
barry | 3 | 23:43 |
barry | 2 | 23:43 |
barry | 1 | 23:43 |
barry | #endmeeting | 23:43 |
MootBot | Meeting finished at 17:43. | 23:43 |
barry | thanks guys | 23:43 |
mwhudson | thanks barry :) | 23:43 |
thumper | ta | 23:43 |
* sinzui uses find.py -s lp-dev-utils/migrater/'lp.testing.factory' . . 'canonical.launchpad.testing' | 23:46 | |
sinzui | hmm that is not good, login_person is broken in a few places | 23:47 |
thumper | sinzui: we want login_person from lp.testing | 23:51 |
thumper | that was my problem | 23:51 |
sinzui | and TestCase? | 23:51 |
thumper | lp.testing | 23:51 |
sinzui | I think I do this in two passes | 23:52 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!