| === sattam1 is now known as sattam | ||
| === fddfoo is now known as fdd | ||
| ara | morning all! | 07:06 |
|---|---|---|
| davmor2 | Morning all | 08:36 |
| === ogasawara_ is now known as ogasawara | ||
| eeejay | hi jcollado | 17:32 |
| jcollado | eeejay: Hi. I'm on a meeting now. | 17:33 |
| eeejay | jcollado: ok, sorry. hope we could chat after | 17:33 |
| jcollado | eeejay: Sure. Sorry for not being very active on desktop-testing branch this week. I've been busy | 17:34 |
| jcollado | eeejay: Are you there? | 18:03 |
| eeejay | hey jcollado | 18:03 |
| jcollado | hey | 18:03 |
| eeejay | jcollado: i have been doing a lot of work based on your branch | 18:04 |
| eeejay | jcollado: i just did a merge from trunk and fixed more bugs | 18:05 |
| jcollado | eeejay: Sounds good | 18:05 |
| eeejay | jcollado: i would like to get this into trunk sooner rather than later, did you see my last comments? | 18:05 |
| jcollado | eeejay: Yes, I saw them | 18:06 |
| eeejay | jcollado: my checkbox plugin depends on these changes | 18:06 |
| jcollado | eeejay: I think the code changing trick works fine, but if you don't feel comfortable with that solution we may find another one | 18:06 |
| eeejay | jcollado: the upside of my proposal is that it is all contained in globals.py | 18:07 |
| eeejay | jcollado: and not across multiple files | 18:07 |
| eeejay | jcollado: also MAGO_PATH=.:$MAGO_SHARE | 18:07 |
| * jcollado is looking into eeejay branch | 18:08 | |
| eeejay | jcollado: got rid of -d | 18:08 |
| jcollado | eeejay: The recursive directory traversal may be removed as well if isn't being very useful | 18:09 |
| eeejay | jcollado: right, that was another change i did. i forgot | 18:09 |
| jcollado | eeejay: Is everything already in your branch? | 18:10 |
| eeejay | jcollado: yup | 18:10 |
| jcollado | eeejay: Let me have a look at it | 18:11 |
| eeejay | jcollado: i think searching for "setup.py" is a robust way of knowing if we are in the build path | 18:12 |
| jcollado | eeejay: Well, I still don't like it much, but I can go with that. The most important for me was to separate the discovery and the running part and that is done. | 18:14 |
| eeejay | jcollado: i agree, the changes you made are very important | 18:14 |
| eeejay | jcollado: is it ok if i propose my branch for merge? | 18:16 |
| jcollado | eeejay: I think we agree on the essential part so please do it. | 18:16 |
| jcollado | eeejay: I hope you remember this when I eventually try to push some changes in the discovery part to get rid of xml files (he, he) | 18:17 |
| eeejay | jcollado: Gracias, amigo | 18:17 |
| jcollado | eeejay: No problem. | 18:18 |
| eeejay | jcollado: this was an essential change for the checkbox plugin, but in general i think we should start stabilizing what we already have | 18:19 |
| === fader is now known as fader|lunch | ||
| === fader|lunch is now known as fader | ||
| === asac__ is now known as asac | ||
| === asac_ is now known as asac | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!