=== asac_ is now known as asac === fta_ is now known as fta [02:33] asac: i can't suppress quivering fingers. i had to add the oneliner. [02:34] asac: look here https://code.launchpad.net/~bdrung/mozilla-devscripts/moz-version === jtv is now known as jtv-afk === jtv-afk is now known as jtv === micahg1 is now known as micahg [09:11] 'morning [09:19] sparc - ulrunner-1.9.1-1.9.1.2+nobinonly/build-tree/mozilla/js/src/./nanojit/Assembler.cpp:975: undefined reference to `sync_instruction_memory' [10:09] asac: morning. saw my changes to -devscripts? [10:16] bdrung_: i saw your ping ;) .... but didnti come to it yet. did you request another merge? [10:16] hi [10:17] asac: no, i pushed it into the same branch. [10:21] hi... i keep getting this error when using apport > http://paste.ubuntu.com/248524/ [10:22] how do i correct it? [10:28] asac: ^ ? [10:31] mac_v: yeah. [10:31] mac_v: its a bug. i hav ea bandaid fix for it which is in firefox-3.6 branch for now [10:32] mac_v: but actually it went away here like 1 or 2 days ago .... are you on up-to-date karmic? [10:32] asac: i'v lost a couple of firefox reports because of that , [10:32] system is up-to date [10:33] firefox-3.5.2 [10:33] mac_v: yeah. sorry about that. i didnt want to hide this bug with the bandaid for now [10:33] mac_v: the firefox-3.6 dailies shouldnt have that problem though [10:33] mac_v: are you using any mirror? [10:33] mac_v: might be that your mirror is lacking behind [10:33] asac: no mirrors [10:33] as i said, i always saw that all the time and its gone [10:33] hmm ... odd [10:34] let me get you the bug id [10:34] asac: asac: the problem is when firefox is not open, if i open firefox first ,this problem doesnt happen always [10:35] mac_v: ack [10:35] bug 401055 [10:35] Launchpad bug 401055 in firefox "Gdk-ERROR **: The program 'firefox-3.5' received an X Window System error (BadWindow)" [Unknown,Confirmed] https://launchpad.net/bugs/401055 [10:35] mac_v: the problem only happens if firefox isnt running [10:35] mac_v: so try to open until it work and keep it open for now [10:37] asac: that was my workaround so long , but recent firefox update 3.5.2 , has changed something , this happened couple of times with firefox open also [10:37] asac: the firefox3.5.2 is not closing properly , i tried to submit the bug , but the latest apport overwrote the report! [10:38] in 3hrs firefox crashed twice! [10:38] from not properly closing [11:03] asac: how do i make ......ubuntu3 higher than ...... ubuntu6? [11:03] i scred up and would love to fix it. im assuming skipping ubuntu# is not a great idea [11:13] asac, all-in-one sidebar uploaded plus bugmail pushed to new too [11:14] the guys who worked on them were nice and wanted to learn more without dropping the ball at the first problem [11:14] the learnt from you [11:14] I guess [11:14] ;) [11:26] andv: oh bugmail ... nice. [11:27] asac, an archive admin should process it [11:27] dunno in which day they do that [11:42] i suspect this question has been asked many times before, but how do you turn on PGO for a dpkg build of firefox 3.5? [11:44] find o9ut whot he people were that built it with pgo enabled and have them push to a PPA :) <<< easiest way but i suspect something along the lines of --pgo-enable in rules file but i havent tried it so cant tell you for sure [12:04] asac: we looked at ia32-libs, and while in universe, it seems easy enough to refresh, so I shall [12:09] jdstrand: thats great news. let me know or something. if you want to stage it in ppa i can call for testing [12:10] asac: for hardy, I think I'll just upload-- pitti already did it post release for the openssl issue, so this will only have security updates [12:11] jdstrand: openssl issue? [12:11] asac: unless I am missing something and you think more needs to be done there [12:11] jdstrand: he updated nss because of that or sent a complete new snapshot in? [12:11] asac: the openssl back after hardy released: CVE-2008-0166 [12:11] jdstrand: i think its ok to upload after some happy testing. if you have amd64 you can test with chromium-browser for instance [12:12] hmm. guess you dont have 64-bit at hand [12:12] no I don't [12:12] jdstrand: ok kenvandine has a 64-bit laptop [12:13] asac: alright, I'll get it somewhere then and ping you [12:13] he even uses chromium [12:13] cool [12:14] so perfect tester ... and he already agreed [12:14] hmm ... hardy ... i guess thats a problem though [12:14] maybe i can convince him to setup a chroot [12:14] jdstrand: [12:14] I plan to do it for hardy-jaunty [12:15] I guess I can do karmic too, if noone has done it [12:15] jdstrand: we have big problems with creating an updated ia32libs based on current state, so i guess we need to do karmic as well [12:17] jdstrand: so he will setup a hardy VM now [12:17] jdstrand: but hasnt enough space for the rest. [12:17] i guess hardy is most risky? or do we rather want jaunty testing? [12:17] asac: just so we are clear-- I will use hardy, hardy-security and hardy-updates for hardy, intrepid, intrepid-security and intrepid-updates for intrepid, ... [12:18] asac: so it isn't particularly risky-- it is all stuff that has been thoroughly tested in the main archive for that release [12:18] again, unless you think I am missing something [12:19] s/main/Ubuntu/ [13:07] it would seem that the ubuntu / debian mozilla source doesn't support PGO, it seems like it has been ripped out of the source tree [13:08] I can see plenty of stuff to disable PGO, but there are no instances of build target that should work, the build targets have been remove from the source [13:11] TankEnMate: at this time you are right pgo is not enabled. IIRC this will change in future (not sure when) [13:11] not only is it not enabled, it isn't even in the base source package [13:12] aka it's not removed by build patches, its not there at all.. [13:12] I'm d/l'ing the full 3.5.2 source from mozilla and i'm going to graft it onto my current deb build tree.. [13:12] it'll probably take ages getting all the build stuff to work, but at least i'll get PGO [13:15] is the ubuntu / debian base package a non-PGO trunk? or is it a handcrafted source tar ball with the PGO stuff ripped out? [13:30] TankEnMate: i dont think upstream builds with PGO either. I know there were/is bugs on it upstream [13:34] TankEnMate: see bug 231708 and mozilla 418866 [13:34] Launchpad bug 231708 in sameplace "Allow setting personal information (including avatar)" [High,Triaged] https://launchpad.net/bugs/231708 [13:35] Mozilla bug 418866 in Build Config "turn on profile-guided optimization (pgo) on linux" [Normal,New] http://bugzilla.mozilla.org/show_bug.cgi?id=418866 [13:37] maybe that will answer most if not all your PGO concerns [14:07] jdstrand: no its ok. go for it [14:15] fta: thanks, the converter works [14:15] asac: ok im fixing sunbird branch to condense all fixes in ubuntu3 and add the fix for arm gcc [14:16] gnomefreak: it seems that there is no more fix needed .... just use the default compiler - at least it seems to work [14:17] asac: ok cool i didnt know if i needed your rules control fix from tb [14:17] gnomefreak: if you explicitly use gcc 4.3 atm on armel then you need it [14:17] but i think you didnt do that ... better check though [14:18] asac: no i used default [14:19] sounds good then [14:19] good than condence revisions and ask you to review and push [14:19] just have to let people know to downgrade to official release [14:20] * gnomefreak screwed up when commiting [14:23] asac: were you the one that said tracemonkey had 64bit enabled already? [14:38] someone interested in fixing iceape build failure on mips* in Debian (https://buildd.debian.org/fetch.cgi?&pkg=iceape&ver=1.1.17-1&arch=mips&stamp=1249209663&file=log) aka making sure that only gets linked with position independent code? [14:40] and pushed updated branch [14:40] do we have that same issue in seamonkey in ubuntu? [14:40] * gnomefreak doesnt have a mips [14:42] making sure something only gets linked with position independent code should not be arch specific unless there is an arch specific build option... [14:44] *ugh* the mozilla build environment is just soo crufty.. [14:49] ah found it, for mips* it configures to static (without fPIC), that both explains the build failure as well as it being arch specific [14:53] gnomefreak: thanks for the pointers.. i have a version of gcc that is too old.. [14:54] TankEnMate: np [14:54] asac, http://codereview.chromium.org/164035 so much for the 1.2 branch [14:55] asac: branch should be updated shortly. can you add this to the review and push list [14:55] updated https://code.edge.launchpad.net/~gnomefreak/sunbird/ubuntu-0.x.9.10 [15:07] found the nightly builds of lightning now i hope updte-orig will grab it [15:29] hi asac, updated branch for you to review when you have a minute bzr+ssh://bazaar.launchpad.net/~ubuntuone-control-tower/bindwood/ubuntu/ [15:32] why the hell doesnt ./debian/rules update-orig or update-orig source work [15:33] niether does get-orig [15:34] fta: does m-d for sunbird just place the lighting.xpi into sunbird source? [15:36] * gnomefreak would prefer to build together but it doesnt seem to use ftp.mozilla and i cant get the update-orig rules to work for some odd reason. [15:42] damn source [16:09] EruditeHermit: why? [16:10] fta: yeah. is 1.3.6 from trunk? [16:10] asac: apparently tracemonkey isn't enabled for 64bit builds [16:13] is the git problem in m-d due to the name change of git? [16:16] problems with twitter can be found http://blogs.usatoday.com/technologylive/2009/08/twitter-investigating-site-outage.html [16:23] morning guys [16:23] eagles0513875: morning sort of [16:24] how are things looking on the karmic front this morning [16:24] karmic == ok [16:25] woohoo [16:25] dont get too excited i dont have same apps as you [16:25] well maybe a few [16:26] be back sm 2.1 is taking forever need to walk around [16:53] ok running 1 test build of SM2.1 if it fails at all i will be putting it off till next week [17:02] jdstrand: do you have ia32libs for hardy somewhere so kenvandine can do a quick test or did you push that already? [17:02] asac: I will upload it very soon [17:03] EruditeHermit: yes. thought i already said that i was wrong ;) [17:03] asac: I uploaded to karmic already [17:03] asac: oh I didn't see =p [17:03] jdstrand: good. if you want kenvandine can do the testing ... he has a 64-bit VM setup now ;) [17:03] (for hardy) [17:03] asac: cool, it'll be a few minutes [17:04] jdstrand: good. let me know where you put it === kenvandif is now known as kenvandine [17:05] asac: https://launchpad.net/~ubuntu-security-proposed/+archive will have it. jaunty is already in there [17:06] jdstrand: yeah. we wont have testing for jaunty as it seems. do you have users on it? [17:06] i can dent about it ... maybe someone jumps on it then [17:07] asac: I can on Tuesday, otherwise I can only download the debs and confirm that the new libs are in there [17:08] jdstrand: ok i dont think there might be breakage, but let me dent and see if someone tests it [17:09] fta: can you redent http://identi.ca/notice/7672024 please [17:10] ? [17:10] hmm ... actually it should have been different ... wait a sec [17:11] fta: this one: http://identi.ca/notice/7672066 [17:19] fta: you think you could sponsor gnomefreaks lighting-sunbird merge? [17:19] https://code.edge.launchpad.net/~gnomefreak/sunbird/ubuntu-0.x.9.10 [17:19] anyone else ;)? [17:34] jdstrand: verified ffox 3.5 in jaunty. thanks! [17:49] asac: ack [17:56] asac: jaunty ff35 and xl191 pushed [18:04] asac, kenvandine: fyi, intrepid and hardy ia32-libs uploaded to https://launchpad.net/~ubuntu-security-proposed/+archive/ppa. They aren't finished building yet, but should be soon [18:04] heading off now... [18:50] bdrung, please forward that change [18:50] to Debian [18:54] has anyone else experienced a loss of open tabs after a firefox update? [18:57] I haven't been able to find this bug anywhere on the debian or mozilla bug tracker, so I assume it's ubuntu specific, considering it's happened during the last few updates. though thats an assumption [19:09] andv: yes, i will. it's already on my todo list [19:10] andv: thanks for sponsoring and for pointing me to the updated maintainer field specification. [19:44] bdrung, np [19:56] asac, where is the debdiff? [19:56] asac, for the thing to sponsor [20:04] fta, you aware of this bug?? it is a funny one http://code.google.com/p/chromium/issues/detail?id=18385 [20:05] asac, I'm off, ping me later with details for the thing to sponsor/review [21:52] hey guys [22:01] why is multisearch enabled by default in 3.5? [22:01] yes [22:02] see my most recent comment in #ubuntu-devel [22:03] and, if you haven't already, see asac's blog post on the matter [22:03] dtchen, I voiced my opine long ago [22:04] I have nothing more to say about it. I came in here to see if the other dude was in here [22:04] i have no opinion on it, as i don't generally use firefox [22:04] * BUGabundo simply disabled it [22:04] dtchen: ? you don't ? [22:04] LOLOL [22:05] however, the prescription for getting some disabled is to _clearly document why something is a use case regression_ [22:05] BUGabundo, Thats what I did too [22:05] I disabled it too, but it's about to be a pain in my ass [22:05] !multisearch [22:05] http://www.asoftsite.org/s9y/archives/162-What-is-this-Multisearch-thing-in-my-Firefox-about.html [22:05] I expressed my mind, accept upstream decission and did what I could to minimize on my side [22:06] What I'm about to do to minimize it on my side is install fedora on a bunch of desktops. [22:06] godspeed, then [22:06] goldins: it's only in the alpha releases in karmic [22:06] it'll be gone by release [22:06] okay [22:06] thanks [22:07] at least I think so... [22:07] wait so firefox3.5 isn't available in 9.04? [22:07] it is [22:07] without multisearch [22:07] as a second version of ff [22:07] yes [22:07] micahg: i have read no such commitment, so i'm not going to voice as much [22:07] that's correct [22:07] I have it as a second version on karmic [22:08] that is, I tried to install only it, but it installed 3.0 as a dependency [22:08] goldins: that'll be fixed soon [22:08] thanks [22:08] dtchen: yeah, I reread asac's blog post, and there might be some form of multisearch in karmic, but nothing is set in stone [22:08] * micahg should be more careful when committing to things [22:09] goldins: I've been using FF3.5 on jaunty for 4 months now [22:10] pff [22:10] I started using FF 3.6 4 months ago [22:10] LOLOL [22:10] once 3.5 went beta [22:10] too stable for me :) [22:13] BUGabundo: i like running development software [22:14] * micahg generally waits for beta before trying new stuff [22:14] pace_t_zulu: I like testing stuff and help devel [22:14] micahg: is it safe to say you aren't running karmic? [22:14] indeed [22:15] I'll upgrade when it hits beta [22:15] * micahg has 1 system [22:15] and it needs to be stable [22:15] micahg: you'll take BUGabundo's cast offs? ;) [22:15] i use virtual machines [22:15] the host system is stable [22:15] ah, if I had more time, I might do that [22:17] I ran bare metal [22:17] on my main machine [22:18] only way to nag dtchen about breaking audio [22:18] not that he will fix any thing :p [22:18] "breaking audio" is about as vague and useless a description as "my foot hurts- make it stop" [22:19] or my firefox is broken [22:19] :D [22:19] dtchen: ok, want more descrition? here we go: [22:20] dtchen: volume below 60% == mute, 50% boot start muted. flat volume sucks! try listening to something at a low volume, it keeps floatoaiting and increasing on it own [22:20] dtchen: having audio at 100% makes it go crazy and go up to 140% or even 200% (like happened once) [22:20] please complain again after you've upgraded to pulse 1:0.9.16~test4-0ubuntu2 [22:21] dtchen: I have to kill pa at least once every 3 h, or it will die and not restart [22:21] ok [22:21] full-upgrading NOW [22:21] The following packages have been kept back: [22:21] hplip-data libpulse-browse0 libpulse-mainloop-glib0 libpulse0 mobile-broadband-provider-info pulseaudio pulseaudio-esound-compat [22:21] pulseaudio-module-bluetooth pulseaudio-module-gconf pulseaudio-module-x11 pulseaudio-module-zeroconf{a} pulseaudio-utils [22:22] dtchen: that's enough complaing for today! you have enough bugs to be bother with mine, that I can workaround easilly [22:23] sure I would like to have them fixed for other users not be hit by them, but we lack manpower to do it all === BUGabundo1 is now known as BUGabundo [22:59] BUGabundo, do you have an handy jaunty installation there? [23:00] jaunty?? [23:00] yes [23:00] LOLOL [23:00] andv: I run cutting edge [23:00] hence my pidgin crashes today [23:00] lol [23:00] I need 3 ppl with jaunty [23:00] to test a backport [23:00] :) [23:01] andv: i'd help you, but i gotta run to the airport to pick up my gf... ping me later if you still need jaunty people... [23:01] andv: fyi.. i run jaunty in a vm... so if your backport requires a native install - sorry [23:01] pace_t_zulu, I'll be here for like 1 hour or more [23:02] pace_t_zulu, I guess a VM works too [23:02] * BUGabundo missread airport with apport [23:02] andv: https://code.edge.launchpad.net/~gnomefreak/sunbird/ubuntu-0.x.9.10 ... thats gnomefreaks branch. there is no debdiff [23:02] too much bug reporting here [23:02] pace_t_zulu, ping me when back please [23:02] asac, so it's not a merge [23:02] andv: sure [23:02] pace_t_zulu: I was finding strange how your gf fited in apport [23:02] pace_t_zulu, ty [23:02] later y'all [23:02] BUGabundo, lol [23:03] andv: well. if its good i can merge it into the main branch. but i cannot test and build it this week [23:03] BUGabundo: i don't know about you... but my gfs are real... ;) [23:03] asac, is it huge to build? [23:03] basically its building sunbird using his branch .... i guess the orig.tar.gz is in gnomefreaks ppa [23:03] andv: its similar to tbird/ffox etc. [23:03] damn [23:03] more than an hour build [23:04] this hotel is so crowded with local people ... all occupying the bar and stuff [23:04] * asac feels a bit unhappy [23:04] asac, where are you? [23:04] dublin [23:04] for ubuntu conf? [23:04] not conference ... platform team sprint [23:04] e.g. sitting together and working on all kind of stuff [23:05] how many developers are there? [23:05] got massively side trackeedand have to make ffox 3.5 by default happening this week [23:06] besides from NM trunk and bluetooth default switch etc. [23:06] who works with you on ffox stuff there? [23:07] noone ... .thats why i get side tracked so much because everybody wants something else from me [23:07] we are about 100 [23:08] basically all ubuntu employees and a few from other parts of the company (e.g. design team etc.) [23:08] all core-devs? [23:09] not all core-devs are canonical employees [23:09] true [23:09] and lots of platform team members are not even motu [23:09] oh :D [23:09] like kernel folks for instance.... they dont need to upload [23:09] asac, they have special permissions [23:09] to upload kernel stuff only [23:10] yes. but just 2 of them [23:10] i think 2 or 3 upload [23:10] yeah [23:10] kernel team is like 18 [23:10] anyway I've pushed all-in-one siderbar earlier [23:10] yeah saw that. thanks [23:11] and bugmail-ext will be processed by jdstrand tomorrow [23:11] andv: did you push the branch to ~ubuntu-dev too? [23:11] asac, I approved it but it needs your review as well [23:11] andv: processed? [23:11] ah [23:11] its a new package?= [23:11] it was NEW [23:11] so have to be processed by archive admins [23:11] oh ok. right. forgot that jamie is archive admin [23:12] and tomorrow is jdstrand turn [23:12] to be archive admin [23:12] so he will do that [23:12] heh. well. i dont know ... but we are all so busy in getting all the stuff together that goes on alpha4 that i owuldnt bet on it getting processed tomorrow [23:12] but who knows ;) [23:13] i will check with him to see if he has time :) [23:13] I told him to ping me when done [23:13] then I'll leave for holidays [23:13] ok .... doing some work on xulrunner transition now ... - which i couldnt do [23:14] like half an a week [23:14] nice. enjoy in case we dont talk [23:14] do you have anything you need to review/sponsor? [23:14] apart from that huge package [23:15] wait a sec [23:16] andv: you could check if you see any issues with lp:~ubuntuone-control-tower/bindwood/ubuntu [23:16] and let me know. [23:16] its a firefox extension [23:16] so in general simple [23:17] so just basic checks like: proper licensing, proper branch layout (e.g. .bzr-builddeb/default.conf ...) etc. [23:17] ok [23:18] andv: oh ... also there are a bunch of universe packages in the ffox 3.5 transition ppa [23:18] andv: https://edge.launchpad.net/~mozillateam/+archive/ffox35 [23:18] those basically need to be checked if they are still up to date with current archive version and get uploaded [23:18] if the archive version has been bumped in the meantime they need to be rebased on the other stuff [23:19] of course only "green" ones are good candidates [23:19] andv: like videolink [23:19] swt-gtk - 3.4-2ubuntu3.0xul191 [23:20] and miro - 2.0.5-1ubuntu1.xul191 [23:20] with some luck you just need to get those ..., sign them and upload [23:20] all the rest i will do tonight or tomorrow morning i hope [23:21] asac, they are all new upst? [23:21] no ... almost everything is just .xul19 [23:22] err 191 [23:22] so just packaging changes for the xulrunner 1.9 -> 1.9.1 transition [23:22] andv: anyway. reviewing the extension from above would be great [23:23] andv: so you said you already uploaded all-in-one ... right? or are you waiting on my review (a bit confused now) [23:23] asac, all-in-one is already uploaded [23:23] you need to review the merge request [23:24] for the branch [23:24] andv: oh ok. [23:24] the extension from above --> lp:~ubuntuone-control-tower/bindwood/ubuntu [23:24] ? [23:24] yeah [23:25] basically do a NEW review on it and tell me if you see anything bad. i will do just a quick review then [23:25] is it new? [23:25] like bugmail-ext [23:26] yes [23:26] its new [23:27] ok [23:27] gonna review it [23:27] then send it on my karmic pc [23:27] and check if it works [23:29] thx [23:29] * merged all-in-one-sidebar 0.7.4-0ubuntu2. Thanks to Andrea Veri for noticing it was missing [23:29] was that something forgotten in intrepid? [23:29] yes [23:30] someone lost the changelog entry [23:30] ah ok [23:30] so just changelog [23:30] and watch file [23:30] if I remember it right [23:31] changes from that revision got lost too [23:33] asac, when reviewed/tested should I wait your review too before uploading' [23:33] ? [23:35] andv: let me know ... i will do a quick check too - better have two reviews on NEW [23:36] ok, one thing: [23:36] is this necessary firefox (>= 3.5),? [23:36] I mean > of 3.5 [23:36] it could be >=3.0 [23:36] or is that right? [23:39] andv: extension? [23:40] asac, im checking the ubuntuone package [23:40] bindwood package sorry === BUGabundo1 is now known as BUGabundo [23:41] andv: for extensions the minimum version should match what is in install.rdf [23:41] asac, deps says firefox (>= 3.5) [23:42] asac, min e max version are 3.5 [23:42] asac, so it should be firefox (=3.5) [23:42] no [23:42] its probably ok [23:42] kk [23:43] I leave it as it is then [23:43] maxversion is 3.5? not 3.5.* [23:43] ? [23:43] 3.5.* [23:43] yes [23:43] so (>=) is right [23:44] yeah. seems so [23:44] apturl (>= 0.1.2ubuntu1), why this particular version? [23:44] not sure. note those things down and i will consider that in my review [23:44] k [23:44] for things i am not sure i will ask the author [23:45] hmm. i think te guy copied the control from u bufox ...ok thanks for spotting it... no need to review further [23:45] i will tell them they have to do it proper [23:46] looked strange [23:46] ^^ [23:46] builds fine [23:46] now installing it [23:46] is it a ffox ext right? [23:47] yes. it syncs bookmarks to couchdb ... so you can sync it using couchdb tools among different systems [23:47] asac, http://identi.ca/notice/7690850 [23:47] a bit similar to weave. just that it doesnt require a server [23:47] ok, so it will have an interface for that [23:48] fta: hoped it was a ia32libs confirm [23:49] asac, installed fine [23:49] on ffox3.5 [23:49] how can I check it works? [23:49] can't find any interface on bookmarks [23:49] reconnect :) [23:49] asac, installed fine [23:49] on ffox3.5 [23:49] how can I check it works? [23:49] can't find any interface on bookmarks [23:50] http://launchpadlibrarian.net/29963998/buildlog_ubuntu-karmic-i386.xulrunner-1.9.2_1.9.2~a1~hg20090806r31180%2Bnobinonly-0ubuntu1~umd1_FAILEDTOBUILD.txt.gz [23:50] patch failed [23:51] andv: start firefox -P and create a new profile. all your bookmarks should appear there [23:51] k [23:51] let me see [23:52] fta: let me check . i am thinking about just dropping that patch [23:56] fta: removed [23:56] ok this lobby is getting too crowded. i hope that dropping this patch didnt require adjusting another patch. [23:56] if so i am sorry ... if i find the time i will try it tomorrow [23:56] cu;)! [23:57] asac_: you leaving?