| === _thumper_ is now known as thumper | ||
| Ursinha | MootBot, owner | 03:12 |
|---|---|---|
| Ursinha | poor MootBot | 03:12 |
| Ursinha | !owner | 03:12 |
| ubottu | This bot is owned by jussi01 - Questions about ubottu should be asked in #ubuntu-bots | 03:12 |
| Ursinha | oops | 03:12 |
| === Ursinha is now known as Ursinha-afk | ||
| === salgado-afk is now known as salgado | ||
| === mrevell is now known as mrevell-lunch | ||
| === mrevell-lunch is now known as mrevell | ||
| === cprov1 is now known as cprov | ||
| === danilo-afk is now known as danilos | ||
| barry | #startmeeting | 15:00 |
| MootBot | Meeting started at 09:00. The chair is barry. | 15:00 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:00 |
| barry | hello everybody and welcome to this week's ameu reviewers meeting. who's here today? | 15:00 |
| gary_poster | me | 15:00 |
| EdwinGrubbs | me | 15:00 |
| bac | me | 15:00 |
| noodles775 | me | 15:00 |
| adeuring | me | 15:00 |
| barry | we have apologies from rockstar and jtv | 15:00 |
| intellectronica | me | 15:00 |
| henninge | me, what time zone is 9:00 anyway? | 15:00 |
| salgado | me | 15:00 |
| bac | CDT | 15:01 |
| deryck | me | 15:01 |
| bac | er, central daylight, henninge | 15:01 |
| henninge | bac: why, servers running there? | 15:01 |
| bac | must be EdwinGrubbs | 15:01 |
| barry | bigjools sends apologies for soyuz folks, who may be late | 15:01 |
| * barry wonders if any non-canonical folks are joining us today | 15:02 | |
| danilos | me | 15:02 |
| barry | [TOPIC] agenda | 15:03 |
| MootBot | New Topic: agenda | 15:03 |
| barry | * Roll call | 15:03 |
| barry | * Action items | 15:03 |
| barry | * Mentoring update | 15:03 |
| barry | * Peanut gallery (anything not on the agenda) | 15:03 |
| barry | 15:03 | |
| barry | let me start today by thanking bac for chairing the meetings while i was out | 15:03 |
| gary_poster | yay bac! | 15:03 |
| henninge | way to go bac! | 15:03 |
| bac | it was no problem, barry. | 15:03 |
| bac | barry: you'll note we were done in twenty one minutes both weeks! | 15:04 |
| barry | bac: i think i will let you chair every time there are outstanding actions :) | 15:04 |
| barry | bac: let's beat that record today! :) | 15:04 |
| barry | [TOPIC] action items | 15:04 |
| MootBot | New Topic: action items | 15:04 |
| barry | nothing! wow, thanks everyone! | 15:04 |
| barry | [TOPIC] mentoring update | 15:04 |
| MootBot | New Topic: mentoring update | 15:04 |
| barry | i think it's fantastic that leonardr graduated and that now all coders are reviewers. i want to keep this item on the agenda for when wgrant applies for mentat status :) | 15:05 |
| gary_poster | :-) | 15:05 |
| barry | any other comments on mentoring before i move on? | 15:05 |
| barry | [TOPIC] peanut gallery | 15:06 |
| MootBot | New Topic: peanut gallery | 15:06 |
| intellectronica | perhaps just to remind that a similar program is now going on with ui reviews | 15:06 |
| barry | intellectronica: right! thanks. to the extent that we can share wisdom or there's overlap it might be good to have a summary of those meetings over here | 15:06 |
| barry | intellectronica: would you like to be the bridge between the two groups, at least until i get mentored over there? <wink> | 15:07 |
| gary_poster | there's a move afoot (in the softarch CoP) to try and get a company-wide guideline for reviews. I pointed them to our stuff. Some of it needs to be transferred from the old-old wiki, not just the old wiki! | 15:07 |
| intellectronica | sure | 15:07 |
| barry | intellectronica: thanks | 15:07 |
| barry | gary_poster: yes, +1 i think we need to give that as an action for someone. does anybody want to volunteer? | 15:08 |
| barry | i will do it then :) | 15:08 |
| gary_poster | I'll probably volunteer next week if nobody does this week :-) | 15:08 |
| gary_poster | oh ok, nm ;-) | 15:08 |
| barry | curses! | 15:09 |
| gary_poster | lol | 15:09 |
| barry | gary_poster: maybe we can both take an action on that? | 15:09 |
| gary_poster | actually I had that written and was just waiting to see someone else volunteer ;-) | 15:09 |
| gary_poster | sure | 15:09 |
| * barry must remember to read /more/ email during these meetings | 15:09 | |
| gary_poster | lol | 15:09 |
| barry | [ACTION] gary_poster and barry will transfer review guidelines from the old{1,2} wiki to the new wiki | 15:10 |
| MootBot | ACTION received: gary_poster and barry will transfer review guidelines from the old{1,2} wiki to the new wiki | 15:10 |
| gary_poster | barry, I won't have time between now and next mtg, which was why I said that, but am happy to work on it next wk. | 15:10 |
| barry | gary_poster: cool, np | 15:10 |
| barry | thanks | 15:10 |
| barry | anyway, there's nothing else on the agenda. does anybody have any other topics for today? | 15:11 |
| barry | 5 | 15:11 |
| barry | 4 | 15:12 |
| danilos | short and sweet, I guess | 15:12 |
| barry | 3 | 15:12 |
| barry | 2 | 15:12 |
| barry | 1 | 15:12 |
| barry | #endmeeting | 15:12 |
| MootBot | Meeting finished at 09:12. | 15:12 |
| danilos | good job barry, thanks all | 15:12 |
| barry | thanks everyone. a new record :) | 15:12 |
| sinzui | new record | 15:12 |
| bac | thanks barry | 15:12 |
| danilos | ;) | 15:12 |
| gary_poster | :-) thanks | 15:12 |
| === danilos is now known as danilo-bbl | ||
| === salgado is now known as salgado-lunch | ||
| === danilo-bbl is now known as danilos | ||
| === salgado-lunch is now known as salgado | ||
| === EdwinGrubbs is now known as Edwin-afk | ||
| === Edwin is now known as Guest11851 | ||
| === Guest11851 is now known as EdwinGrubbs | ||
| === salgado is now known as salgado-afk | ||
| === EdwinGrubbs is now known as Edwin-afk | ||
| barry | #startmeeting | 23:31 |
| MootBot | Meeting started at 17:31. The chair is barry. | 23:31 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 23:31 |
| barry | hi everyone and welcome to this week's asiapac reveiwers meeting. who's here today? | 23:31 |
| rockstar | ni! | 23:31 |
| rockstar | wgrant, ping | 23:31 |
| barry | wgrant: you are welcome to lurk or join in! | 23:31 |
| barry | thumper, jml ping | 23:31 |
| wgrant | me! | 23:32 |
| barry | \o/ | 23:32 |
| rockstar | barry, jml is traipsing around Europe this week. | 23:32 |
| thumper | barry: hi | 23:32 |
| barry | rockstar: gotcha | 23:32 |
| thumper | rockstar: shh | 23:32 |
| barry | so... | 23:32 |
| thumper | barry: jml is unavailable :) | 23:32 |
| barry | [TOPIC] agenda | 23:32 |
| MootBot | New Topic: agenda | 23:32 |
| barry | ;) | 23:32 |
| barry | well it was a very short ameu meeting, so to summarize... | 23:33 |
| barry | intellectronica is going to keep these teams abreast of what happens in the new ui reviewer meetings | 23:33 |
| barry | at least until i s/mentat/reviewer/ | 23:33 |
| barry | gary_poster and /me will work on transferring review guidelines from the old old wiki and old wiki to the new wiki | 23:34 |
| barry | that's about it | 23:34 |
| barry | we don't really have any action items, so let me open things up to y'all | 23:34 |
| rockstar | To be honest, I think we should actually have a section lead by the UI reviewers in the reviewer meetings, instead of the super sekrit phone call. | 23:34 |
| barry | what's been going on and what's on your mind? | 23:34 |
| rockstar | That way, we can involve the community more. | 23:35 |
| gary_poster | [peanut gallery] rockstar: +1 in theory | 23:35 |
| barry | rockstar: i'd be in favor of that | 23:35 |
| rockstar | gary_poster, why not in practice? | 23:35 |
| gary_poster | (in theory simply because I haven't thought about the practicalities too much) | 23:35 |
| rockstar | gary_poster, yeah, but I think having that interaction between UI reviewers should be a bit more public. I think the phone call should be for keeping the teams up to date with other UI matters. | 23:36 |
| rockstar | Also, another thing that came up in a review with thumper yesterday. | 23:37 |
| rockstar | In the new views, we have to implement a page_title attribute. Sometimes this is a function. | 23:37 |
| rockstar | In generic edit views, we also need a label attribute, which can also be an @property | 23:38 |
| rockstar | Do those two functions need docstrings? We often don't include them in initialize and other functions that need implementing, unless there is a specific reason. | 23:38 |
| thumper | barry: also worth noting there is a new lp/app/templates/generic-edit.pt that should suit most general editing needs | 23:39 |
| barry | rockstar: the way to think about it is if/when we get sphinx output for api docs. would the docstring help? | 23:39 |
| thumper | barry: the docstring would be the same every time | 23:39 |
| thumper | barry: the label is rendered as the h1 | 23:39 |
| rockstar | barry, in this case, no, because in thumper's branch, all the docstrings were the same. That's why I had him remove them. | 23:39 |
| thumper | barry: and the page_title is the html title for the page | 23:39 |
| * rockstar will let thumper talk about generic-edit.pt | 23:40 | |
| barry | well, another way to think about it is that when they /are/ just attributes they won't have docstrings | 23:40 |
| barry | i think we can play those by ear. i.e. let the dev and reviewer decide | 23:41 |
| thumper | I'm +1 on not having docstrings for label and page_title properties | 23:41 |
| barry | i wouldn't say they /can't/ but i agree they don't need to | 23:41 |
| barry | thumper: tell me about generic-edit.py | 23:41 |
| thumper | barry: a new very simple template | 23:42 |
| thumper | barry: new 3.0 style | 23:42 |
| thumper | barry: just renders the form | 23:42 |
| thumper | barry: so the view has page_title, label, and other bits | 23:42 |
| barry | from the object's schema? | 23:42 |
| thumper | barry: refer to the generic-edit.pt (not py) | 23:42 |
| barry | s/py/pt/ | 23:42 |
| barry | ;) | 23:42 |
| rockstar | lp/app/templates/generic-edit.pt | 23:42 |
| thumper | barry: I found there were many similar edit pages in code | 23:43 |
| thumper | barry: and sinzui also had many in registry | 23:43 |
| barry | cool. i'll add this to the summary so other reviewers are on the lookout for when we can use it | 23:43 |
| rockstar | And me in answers. | 23:43 |
| thumper | barry: there are no bugs in no code (or pages) | 23:43 |
| rockstar | Yes, so we remove templates. | 23:43 |
| barry | which is always good! | 23:43 |
| thumper | that's all I think | 23:44 |
| barry | [ACTION] reviewers should watch for opportunities to remove custom templates in favor of generic-edit.pt | 23:44 |
| MootBot | ACTION received: reviewers should watch for opportunities to remove custom templates in favor of generic-edit.pt | 23:44 |
| barry | thumper: thanks. rockstar or wgrant anything from you? | 23:45 |
| barry | wgrant how have things gone with the branches you've submitted? | 23:45 |
| rockstar | barry, maybe I should start coming to the AsiaPac meetings instead of the early morning one for me. :) | 23:45 |
| thumper | barry: then we could have almost all the code team at one | 23:46 |
| barry | rockstar: they go quicker that's for sure, though this one has already gone longer than the ameu one this morning :) | 23:46 |
| barry | seriously: +1 | 23:46 |
| barry | abentley too? | 23:46 |
| barry | it wouldn't be a bad time for him | 23:46 |
| wgrant | barry: It has gone pretty well. | 23:47 |
| rockstar | Wait, that might not be good. Next you'll round the code team up in camps and experiment on us. | 23:47 |
| wgrant | Although it's sometimes awkward to find Soyuz people around, it's been fairly quick and painless. | 23:47 |
| barry | wgrant: great! i'm really psyched to see you blazing the trail | 23:48 |
| thumper | barry: nah, abentley will probably still go to the other one | 23:48 |
| wgrant | ... although ec2test for contributors would be nice. | 23:48 |
| thumper | barry: this would be too late in his evening | 23:48 |
| barry | wgrant: +1 | 23:48 |
| rockstar | wgrant, +1 | 23:48 |
| barry | thumper: it's only 6:30pm for us | 23:48 |
| thumper | barry: :) | 23:48 |
| barry | 'sup to him of course | 23:48 |
| thumper | barry: do you have a few minutes for a skype call after this? | 23:48 |
| barry | thumper: i do | 23:49 |
| barry | are we done? | 23:49 |
| barry | 5 | 23:49 |
| barry | 4 | 23:49 |
| barry | 3 | 23:49 |
| barry | 2 | 23:49 |
| barry | 1 | 23:49 |
| barry | #endmeeting | 23:49 |
| MootBot | Meeting finished at 17:49. | 23:49 |
| barry | thanks guys | 23:49 |
| * barry puts on headphones | 23:49 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!