=== _thumper_ is now known as thumper [03:12] MootBot, owner [03:12] poor MootBot [03:12] !owner [03:12] This bot is owned by jussi01 - Questions about ubottu should be asked in #ubuntu-bots [03:12] oops === Ursinha is now known as Ursinha-afk === salgado-afk is now known as salgado === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell === cprov1 is now known as cprov === danilo-afk is now known as danilos [15:00] #startmeeting [15:00] Meeting started at 09:00. The chair is barry. [15:00] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [15:00] hello everybody and welcome to this week's ameu reviewers meeting. who's here today? [15:00] me [15:00] me [15:00] me [15:00] me [15:00] me [15:00] we have apologies from rockstar and jtv [15:00] me [15:00] me, what time zone is 9:00 anyway? [15:00] me [15:01] CDT [15:01] me [15:01] er, central daylight, henninge [15:01] bac: why, servers running there? [15:01] must be EdwinGrubbs [15:01] bigjools sends apologies for soyuz folks, who may be late [15:02] * barry wonders if any non-canonical folks are joining us today [15:02] me [15:03] [TOPIC] agenda [15:03] New Topic: agenda [15:03] * Roll call [15:03] * Action items [15:03] * Mentoring update [15:03] * Peanut gallery (anything not on the agenda) [15:03] [15:03] let me start today by thanking bac for chairing the meetings while i was out [15:03] yay bac! [15:03] way to go bac! [15:03] it was no problem, barry. [15:04] barry: you'll note we were done in twenty one minutes both weeks! [15:04] bac: i think i will let you chair every time there are outstanding actions :) [15:04] bac: let's beat that record today! :) [15:04] [TOPIC] action items [15:04] New Topic: action items [15:04] nothing! wow, thanks everyone! [15:04] [TOPIC] mentoring update [15:04] New Topic: mentoring update [15:05] i think it's fantastic that leonardr graduated and that now all coders are reviewers. i want to keep this item on the agenda for when wgrant applies for mentat status :) [15:05] :-) [15:05] any other comments on mentoring before i move on? [15:06] [TOPIC] peanut gallery [15:06] New Topic: peanut gallery [15:06] perhaps just to remind that a similar program is now going on with ui reviews [15:06] intellectronica: right! thanks. to the extent that we can share wisdom or there's overlap it might be good to have a summary of those meetings over here [15:07] intellectronica: would you like to be the bridge between the two groups, at least until i get mentored over there? [15:07] there's a move afoot (in the softarch CoP) to try and get a company-wide guideline for reviews. I pointed them to our stuff. Some of it needs to be transferred from the old-old wiki, not just the old wiki! [15:07] sure [15:07] intellectronica: thanks [15:08] gary_poster: yes, +1 i think we need to give that as an action for someone. does anybody want to volunteer? [15:08] i will do it then :) [15:08] I'll probably volunteer next week if nobody does this week :-) [15:08] oh ok, nm ;-) [15:09] curses! [15:09] lol [15:09] gary_poster: maybe we can both take an action on that? [15:09] actually I had that written and was just waiting to see someone else volunteer ;-) [15:09] sure [15:09] * barry must remember to read /more/ email during these meetings [15:09] lol [15:10] [ACTION] gary_poster and barry will transfer review guidelines from the old{1,2} wiki to the new wiki [15:10] ACTION received: gary_poster and barry will transfer review guidelines from the old{1,2} wiki to the new wiki [15:10] barry, I won't have time between now and next mtg, which was why I said that, but am happy to work on it next wk. [15:10] gary_poster: cool, np [15:10] thanks [15:11] anyway, there's nothing else on the agenda. does anybody have any other topics for today? [15:11] 5 [15:12] 4 [15:12] short and sweet, I guess [15:12] 3 [15:12] 2 [15:12] 1 [15:12] #endmeeting [15:12] Meeting finished at 09:12. [15:12] good job barry, thanks all [15:12] thanks everyone. a new record :) [15:12] new record [15:12] thanks barry [15:12] ;) [15:12] :-) thanks === danilos is now known as danilo-bbl === salgado is now known as salgado-lunch === danilo-bbl is now known as danilos === salgado-lunch is now known as salgado === EdwinGrubbs is now known as Edwin-afk === Edwin is now known as Guest11851 === Guest11851 is now known as EdwinGrubbs === salgado is now known as salgado-afk === EdwinGrubbs is now known as Edwin-afk [23:31] #startmeeting [23:31] Meeting started at 17:31. The chair is barry. [23:31] Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] [23:31] hi everyone and welcome to this week's asiapac reveiwers meeting. who's here today? [23:31] ni! [23:31] wgrant, ping [23:31] wgrant: you are welcome to lurk or join in! [23:31] thumper, jml ping [23:32] me! [23:32] \o/ [23:32] barry, jml is traipsing around Europe this week. [23:32] barry: hi [23:32] rockstar: gotcha [23:32] rockstar: shh [23:32] so... [23:32] barry: jml is unavailable :) [23:32] [TOPIC] agenda [23:32] New Topic: agenda [23:32] ;) [23:33] well it was a very short ameu meeting, so to summarize... [23:33] intellectronica is going to keep these teams abreast of what happens in the new ui reviewer meetings [23:33] at least until i s/mentat/reviewer/ [23:34] gary_poster and /me will work on transferring review guidelines from the old old wiki and old wiki to the new wiki [23:34] that's about it [23:34] we don't really have any action items, so let me open things up to y'all [23:34] To be honest, I think we should actually have a section lead by the UI reviewers in the reviewer meetings, instead of the super sekrit phone call. [23:34] what's been going on and what's on your mind? [23:35] That way, we can involve the community more. [23:35] [peanut gallery] rockstar: +1 in theory [23:35] rockstar: i'd be in favor of that [23:35] gary_poster, why not in practice? [23:35] (in theory simply because I haven't thought about the practicalities too much) [23:36] gary_poster, yeah, but I think having that interaction between UI reviewers should be a bit more public. I think the phone call should be for keeping the teams up to date with other UI matters. [23:37] Also, another thing that came up in a review with thumper yesterday. [23:37] In the new views, we have to implement a page_title attribute. Sometimes this is a function. [23:38] In generic edit views, we also need a label attribute, which can also be an @property [23:38] Do those two functions need docstrings? We often don't include them in initialize and other functions that need implementing, unless there is a specific reason. [23:39] barry: also worth noting there is a new lp/app/templates/generic-edit.pt that should suit most general editing needs [23:39] rockstar: the way to think about it is if/when we get sphinx output for api docs. would the docstring help? [23:39] barry: the docstring would be the same every time [23:39] barry: the label is rendered as the h1 [23:39] barry, in this case, no, because in thumper's branch, all the docstrings were the same. That's why I had him remove them. [23:39] barry: and the page_title is the html title for the page [23:40] * rockstar will let thumper talk about generic-edit.pt [23:40] well, another way to think about it is that when they /are/ just attributes they won't have docstrings [23:41] i think we can play those by ear. i.e. let the dev and reviewer decide [23:41] I'm +1 on not having docstrings for label and page_title properties [23:41] i wouldn't say they /can't/ but i agree they don't need to [23:41] thumper: tell me about generic-edit.py [23:42] barry: a new very simple template [23:42] barry: new 3.0 style [23:42] barry: just renders the form [23:42] barry: so the view has page_title, label, and other bits [23:42] from the object's schema? [23:42] barry: refer to the generic-edit.pt (not py) [23:42] s/py/pt/ [23:42] ;) [23:42] lp/app/templates/generic-edit.pt [23:43] barry: I found there were many similar edit pages in code [23:43] barry: and sinzui also had many in registry [23:43] cool. i'll add this to the summary so other reviewers are on the lookout for when we can use it [23:43] And me in answers. [23:43] barry: there are no bugs in no code (or pages) [23:43] Yes, so we remove templates. [23:43] which is always good! [23:44] that's all I think [23:44] [ACTION] reviewers should watch for opportunities to remove custom templates in favor of generic-edit.pt [23:44] ACTION received: reviewers should watch for opportunities to remove custom templates in favor of generic-edit.pt [23:45] thumper: thanks. rockstar or wgrant anything from you? [23:45] wgrant how have things gone with the branches you've submitted? [23:45] barry, maybe I should start coming to the AsiaPac meetings instead of the early morning one for me. :) [23:46] barry: then we could have almost all the code team at one [23:46] rockstar: they go quicker that's for sure, though this one has already gone longer than the ameu one this morning :) [23:46] seriously: +1 [23:46] abentley too? [23:46] it wouldn't be a bad time for him [23:47] barry: It has gone pretty well. [23:47] Wait, that might not be good. Next you'll round the code team up in camps and experiment on us. [23:47] Although it's sometimes awkward to find Soyuz people around, it's been fairly quick and painless. [23:48] wgrant: great! i'm really psyched to see you blazing the trail [23:48] barry: nah, abentley will probably still go to the other one [23:48] ... although ec2test for contributors would be nice. [23:48] barry: this would be too late in his evening [23:48] wgrant: +1 [23:48] wgrant, +1 [23:48] thumper: it's only 6:30pm for us [23:48] barry: :) [23:48] 'sup to him of course [23:48] barry: do you have a few minutes for a skype call after this? [23:49] thumper: i do [23:49] are we done? [23:49] 5 [23:49] 4 [23:49] 3 [23:49] 2 [23:49] 1 [23:49] #endmeeting [23:49] Meeting finished at 17:49. [23:49] thanks guys [23:49] * barry puts on headphones