=== sadmac_ is now known as sadmac
[11:59] <Keybuk> http://bazaar.launchpad.net/~upstart-devel/upstart/trunk-translations/revision/1212
[11:59] <Keybuk> that's kinda cute ;)
[13:05] <plautrba> nih_config_token doesn't accept token with any expansion
[13:06] <plautrba> is there another function or this should be fixed?
[13:06] <plautrba> ehm back
[13:07] <plautrba> nih_config_next_arg is that function which calls nih_config_token with NIH_CONFIG_CNLWS delimiters
[13:09] <plautrba> idea is in parse_job.c - stanza_utmp() get utmp arg with nih_config_next_arg() and then expand it with environ_expand()
[13:10] <soren> 7win 21
[13:10] <soren> Doh.
[14:26] <Keybuk> plautrba: not sure what you mean?
[14:29] <plautrba> Keybuk: I call nih_config_next_arg() on positition where is "${TTY#tty}\n"
[14:29] <plautrba> and it returns "${TTY"
[14:29] <plautrba> because there is '#' in delimiters
[14:29] <Keybuk> really, even though it's in quotes?
[14:30] <plautrba> quotes are mine, just that is string
[14:30] <Keybuk> oh, right
[14:30] <Keybuk> that sounds likely
[14:31] <Keybuk> nih_config_token() would probably need to be extended to ignore # inside { .. }
[14:31] <plautrba> so I think nih_config_token() should also take care about ${ .. }
[14:31] <plautrba> yes
[14:31] <plautrba> not just ignore # but work with everything in ${ } in same way as it would be quoted or so
[14:31] <Keybuk> could probably argue inside [ ... ] and ( ... ) too
[14:32] <Keybuk> dunno whether you'd treat ${ specially
[14:33] <plautrba> utmp ${TTY#tty}
[14:33] <Keybuk> I mean compared to just { ... }
[14:33] <Keybuk> author <foo@#bar.com>
[14:33] <Keybuk> should that # be a comment? :)
[14:34] <plautrba> i see
[14:35] <plautrba> but that would be simply quoted
[14:36] <Keybuk> one could argue that the utmp example should be quoted
[14:36] <plautrba> or maybe escaped - ${TTY\#tty}
[14:37] <Keybuk> right, either of those works
[14:37] <Keybuk> that's kinda ugly though
[14:38] <Keybuk> the reason obviously is that $... and ${...} aren't part of the config grammar
[14:38] <Keybuk> they're expansions selectively applied to certain arguments
[14:38] <Keybuk> well after config parsing
=== robbiew_away is now known as robbiew
[15:07] <sadmac2> Keybuk: responded to your comments
[16:02] <Keybuk> sadmac2: great, will take a look in a second
[16:02] <Keybuk> sadmac2: could you forward them to the LP review system if you haven't already?
[16:02] <Keybuk> mp+9968@code.launchpad.net
[16:02] <sadmac2> Keybuk: ok..
[16:03] <sadmac2> Keybuk: I should have a patch for most of the stuff tonight.
[16:04] <Keybuk> thanks
=== robbiew is now known as robbiew-afk
=== robbiew-afk is now known as robbiew
=== robbiew is now known as robbiew_away