| * thumper primal screams | 00:47 | |
| spm | thumper: fwiw. supermirror on staging is revno 8386. does that help? or you need app as well. ?? | 00:47 |
|---|---|---|
| thumper | spm: app | 00:47 |
| spm | bleh | 00:48 |
| thumper | my great plan to speed something up has been derailed | 00:48 |
| * thumper needs to rethink | 00:48 | |
| * thumper heads to class | 02:14 | |
| thumper | spm: can you poke stub when he arrives and point him at his build failures? | 02:15 |
| === thumper is now known as thumper-afk | ||
| spm | thumper: sure | 02:15 |
| thumper-afk | ta | 02:15 |
| === thumper-afk is now known as thumper | ||
| spm | thumper: as I'm sure you've noticed, no stub yet. tho he was sprinting last week, so may be in transit or similar. | 06:28 |
| === henninge is now known as henninge-bbl | ||
| adeuring | good morning | 08:36 |
| jtv | hi adeuring | 08:44 |
| adeuring | hi jtv! | 08:44 |
| gmb | Good morning, people of Launchpad. | 08:52 |
| === henninge-bbl is now known as henninge | ||
| jtv | hi henninge! | 09:00 |
| jtv | and hi gmb, as well :) | 09:00 |
| gmb | :) | 09:00 |
| henninge | hi jtv! | 09:00 |
| jtv | henninge: how are things coming along with the new model class? | 09:01 |
| henninge | jtv: it's still Monday morning here! | 09:02 |
| jtv | henninge: I'm not expecting you to have code, just asking if you have any ideas about it yet. :) | 09:02 |
| jtv | henninge: (in other words, whether you have any interest in a pre-imp call or whether you want to look at it some more) | 09:03 |
| henninge | jtv: no pre-imp yet ;-) | 09:03 |
| jtv | ok :) | 09:03 |
| wgrant | Um, why are bugnotificationrecipients being archived, but not the actually useful bugnotifications? | 09:07 |
| BjornT | wgrant: the idea was to archive both, so stub probably forgot to archive the BugNotification table, or intend to do that later. | 09:21 |
| BjornT | stub: ^^^^ | 09:21 |
| mrevell | Morning :) | 09:22 |
| wgrant | BjornT: Or maybe the intention is to not prune bugnotification, as that isn't too supermassive at the moment. | 09:24 |
| BjornT | wgrant: the intention was to prune bugnotication and have a cascading delete that delets the bugnotificationrecipients records as well. | 09:27 |
| wgrant | BjornT: Ah. | 09:27 |
| gmb | I hate software. | 10:21 |
| thumper | gmb: so do I | 10:26 |
| thumper | gmb: I hate hardware too | 10:26 |
| gmb | thumper: Hmm. I also hate ISPs over whose network a connection to Canonical IRC seems astonishingly laggy. | 10:27 |
| gmb | (As does any connection to my IRC proxy. I wonder if that's because both are over SSL). | 10:27 |
| === mrevell changed the topic of #launchpad-dev to: Launchpad Development Channel | Week 3 of 2.2.8 | https://dev.launchpad.net/ | Please use #launchpad for support. | https://launchpad.net/~launchpad-dev | Get it: https://dev.launchpad.net/Getting | http://people.canonical.com/~herb/ | http://paste.ubuntu.com/ | ||
| gmb | BjornT, FTR, I'm not able to connect to the internal IRC server reliably ATM for the morning call.. | 10:41 |
| gmb | s/call/meeting | 10:41 |
| BjornT | gmb: ok. does skype still work? | 10:42 |
| gmb | BjornT: Yes. | 10:43 |
| === danilo-afk is now known as danilo | ||
| === danilo is now known as danilos | ||
| * gmb lunches | 12:58 | |
| === mrevell is now known as mrevell-lunch | ||
| beuno | gooooood morning everyone | 13:26 |
| noodles775 | hiya beuno :) | 13:27 |
| deryck | morning beuno | 13:27 |
| beuno | how's it going noodles775? | 13:27 |
| noodles775 | beuno: yeah ok, glad to be back to doing some actual dev work :) (had a busy OCR day last thursday). And you? | 13:28 |
| beuno | noodles775, sprinting with the Ubuntu One guys | 13:29 |
| noodles775 | beuno: ah, great! Hope it's lots of fun! | 13:29 |
| beuno | noodles775, it is :) | 13:31 |
| === mrevell-lunch is now known as mrevell | ||
| allenap | Does anyone know when is edge going to update? It's been *ages*! | 13:44 |
| intellectronica | allenap: yeah, it's a bit annoying. staging is up-to-date, though, if you need to test stuff | 13:45 |
| beuno | allenap, let's stalk flacoste as soon as he comes up | 13:45 |
| allenap | intellectronica: Cool. | 13:45 |
| allenap | beuno: Yeah :) I want to *see* new stuff already :) | 13:45 |
| beuno | me too! | 13:46 |
| intellectronica | beuno: not urgent but just a reminder, that we still need to figure out a nice hover image for pages with large clusters of edit icons | 13:48 |
| beuno | intellectronica, yes, it's on the top of my list | 13:48 |
| beuno | I will try and get something out today or tomorrow | 13:48 |
| intellectronica | coolio | 13:48 |
| jtv | herb, question: did my CP of 9107 and 9030 really go onto the codehosting server? | 14:06 |
| === barry is now known as barry-away | ||
| === barry-away is now known as barry | ||
| gary_poster | hey leonardr. My branch to put all of the zope code as distributions as assembled by buildout is waiting for review from flacoste. I know that was a prerequisite for migrating launchpad to the newer versions of lazr.restful and friends, but I don't remember why--and particularly, if there was something else that needed doing before it could be merged in. Do you remember? | 14:15 |
| leonardr | gary: i don't remember. i think it had something to do with the interplay between launchpad, lazr.restfulclient, and launchpadlib | 14:18 |
| leonardr | but at this point i think the best thing to do is just try it | 14:18 |
| gary_poster | leonardr: ok. I might give that a brief whirl sometime today to just get a feel for the problems. | 14:21 |
| gary_poster | barry: btw, Jim Fulton now has a predefined set of Zope packages ("Known Good Set") that work together and with Python 2.5 and 2.6. (the improvement over the previous situation is that each package was supposed to be ready for 2.5/2.6, but there was no automated testing to show that the individual packages all worked together reasonably). This should hopefully help us in our migration path. | 14:24 |
| barry | gary_poster: fantastic! | 14:25 |
| barry | leonardr: lazr.restful.simple isn't in the released version of lazr.restful yet, is it? | 14:26 |
| leonardr | barry: no, but if you need it i can do a release | 14:26 |
| barry | leonardr: if you can do that this morning it might be cool. i think i can at least do a partial simplification of my code before i give my lazr.restful talk tonight | 14:27 |
| leonardr | barry: ok, i'll do that now, should just take a minue | 14:27 |
| barry | leonardr: awesome, thanks! | 14:28 |
| === kiko-afk is now known as kiko | ||
| leonardr | barry, can you review this trivial diff: https://pastebin.canonical.com/21213/ | 14:32 |
| barry | sure | 14:32 |
| barry | r=me | 14:32 |
| henninge | jtv: ping | 14:35 |
| jtv | henninge: pong | 14:35 |
| henninge | jtv: ah, you dropped of the internal IRC | 14:35 |
| henninge | jtv: Is there an existing example for something like "TranslatedMessage" ? | 14:35 |
| jtv | henninge: the new model class? Not that I can think of, and that's why we are having these problems. TranslationMessage sort of fakes it right now by keeping track of the "browser_pofile." | 14:36 |
| henninge | jtv: I see. | 14:37 |
| adeuring | I'm getting the error "Sender not authorised to commit to branch lp:~launchpad-pqm/lazr.restful/trunk" when I try to pqm-submit a lazr.restful branch. Any ideas what I'm doing wrong? | 14:37 |
| jtv | henninge: you could see ProductSeriesLanguage as a recent example of the general construct though. | 14:38 |
| henninge | jtv: let me look at that. Yes, I was looking for the general construct. | 14:39 |
| jtv | henninge: at its heart it's a "tuple" of two proper model objects." | 14:39 |
| BjornT | adeuring: i would try specifying the bzr+ssh url instead of the lp one | 14:39 |
| adeuring | BjornT: thanks, I'll try that | 14:39 |
| henninge | jtv: a productseries and ... a pofile ... a language? | 14:40 |
| jtv | henninge: in that case, a productseries and a language. There can be multiple POFiles, otherwise there'd be little point. :-) | 14:40 |
| henninge | jtv: ah, of course ... | 14:40 |
| intellectronica | adeuring: yes, using the bzr+ssh protocol should work. however, it didn't work for me last time i tried for independent reasons, so let me know if it works for you or not | 14:41 |
| henninge | jtv: there is a ProductSeriesLanguage and a -Set. | 14:41 |
| adeuring | intellectronica: sure... just isuued the pqm-submit again... | 14:41 |
| henninge | jtv: so analogous a TranslatedMessageSet would be potmsgsetset (a potemplate) bound to a pofile. | 14:42 |
| jtv | henninge: no, that's your TranslatedMessage AFAICS. If you want a -Set, that's basically the POFile. | 14:43 |
| jtv | henninge: sorry, I misread. What you said is basically a POFile. | 14:43 |
| jtv | henninge: or maybe I'm confused about your terminology, since the "Set" in POTMsgSet is in no way related to the -Set in TranslatorSet, POTemplateSet etc. | 14:45 |
| leonardr | barry: ok, lazr.restful 0.9.3 is out | 14:45 |
| henninge | jtv: yes, I used "SetSet" there ... | 14:45 |
| * jtv cries softly into his keyboard | 14:46 | |
| henninge | jtv: so I a aware of the different meaning of set | 14:46 |
| * henninge gets jtv something to wipe his keyboard with . | 14:46 | |
| barry | leonardr: thanks! | 14:46 |
| henninge | jtv: We will need a DummyTranslatedMessage, too. | 14:47 |
| henninge | won't we? | 14:48 |
| jtv | henninge: yes, I think we need one for dummypofiles. | 14:48 |
| jtv | henninge: but it may depend on the details... a TranslatedMessage referring to a DummyPOFile may be good enough. | 14:49 |
| henninge | jtv: ok, details later ;-) | 14:49 |
| jtv | I certainly wouldn't introduce a DummyTranslatedMessage unless it's necessary. | 14:49 |
| henninge | jtv: ok | 14:49 |
| henninge | jtv: hm | 14:50 |
| henninge | jtv: I just realized I am not sure what we are trying to accomplish with the new model class. | 14:51 |
| henninge | jtv: please don't cry!1 | 14:51 |
| jtv | henninge: you're trying to build a model class that we can attach the "one translatable message plus translation & suggestions" view to. | 14:52 |
| henninge | jtv: A TranslationMessage is already specific to a POFile. Why can't we work with TranslationMessage directly | 14:52 |
| henninge | oh! | 14:52 |
| henninge | jtv: So it is "All TtranslationMessages for this POTMsgSet for this POFile" ? | 14:52 |
| jtv | Pretty much, yes... I'd say "the translation state for this POTMsgSet as seen in this POFile." | 14:53 |
| henninge | jtv: ok, or that ;-) | 14:53 |
| jtv | As you can see, the TM is "one step too far down" to do this well. | 14:53 |
| henninge | jtv: Yes, I see that now. I was only confused for a short time. | 14:54 |
| jtv | Also, right now, there's the weird problem that when you look at an individual message now, you're basically looking at a TranslationMessage that may be shared between POFiles. So... how do we get the sequence number? | 14:54 |
| henninge | jtv: So I need to provid acces to 1. The current message 2. the imported message 3. the shared message 4. all local suggestions 5. the external suggestions. | 14:55 |
| henninge | jtv: POFile gives us POTEmplate | 14:56 |
| henninge | jtv: doesn't it? | 14:56 |
| henninge | oh no, it's the other way round. | 14:56 |
| jtv | henninge: there's no reference to either (except if the TM is diverged, but let's not count on our luck :) | 14:56 |
| henninge | jtv: so the model class needs a concept of which potemplate it refers to. | 14:56 |
| jtv | henninge: exactly, that's the other bit of information you'll be holding onto in your new class. | 14:57 |
| henninge | so init would be (POTMsgSet, POFile, POTemplate) | 14:57 |
| jtv | henninge: POTemplate == POFile.potemplate | 14:57 |
| jtv | henninge: but otherwise, yes, that's it. | 14:57 |
| henninge | jtv: oh, it does | 14:57 |
| * henninge has to look at jtv's great diagram again ... | 14:58 | |
| henninge | jtv: that's what I meant when I said | 14:59 |
| henninge | jtv: POFile gives us POTEmplate | 14:59 |
| jtv | henninge: and you were right there, not wrong :) | 15:00 |
| henninge | jtv: so init would just be (POTMsgSet, POFile) | 15:00 |
| jtv | henninge: yup | 15:00 |
| jtv | that's the basic information you're holding together, and everything else will follow from that. | 15:01 |
| henninge | jtv: let me draft the interface to see what I might be missing. | 15:01 |
| henninge | jtv: btw, should we stick with "TranslatedMessage"? | 15:02 |
| jtv | henninge: it's going to suck typing that, but I guess we'll have to get used to it. I can't think of anything better. (Even if the message is untranslated, it's basically just a TranslatedMessage without a current translation) | 15:03 |
| danilos | henninge, jtv: TranslatableMessage is what it is | 15:07 |
| jtv | \o/ | 15:07 |
| barry | OMG ugly: notfound-traversals.txt | 15:07 |
| henninge | danilos: The probelm is just that "Set" is already used in different places for a "List" ... ;-D | 15:08 |
| danilos | henninge: oh well, I believe 'TranslatableMessage' is good, except that I don't like our choice of 'TranslationMessage' then :) | 15:08 |
| sinzui | bac loot at the firefox project as sample person in dev to see a converted layout. The sidebar uses all the conventions | 15:09 |
| * henninge just noticed the "able" instead of "ed" | 15:09 | |
| henninge | but that's ok. | 15:09 |
| jtv | barry: hey, at least it's not spending all its time in sleep() any more! | 15:09 |
| sinzui | bac: mozzila is also a good one to look at | 15:09 |
| jtv | danilos, henninge: I initially coined -able, but I think -ed is just fine; less confusion possible with POTMsgSet | 15:09 |
| * henninge halts in the middle of renaming | 15:10 | |
| danilos | jtv: POTMsgSet is English/SourceMessage :) | 15:10 |
| henninge | danilos ? | 15:10 |
| jtv | danilos: don't go there today... just... don't. :-) | 15:10 |
| danilos | jtv, henninge: there's no solution possible that works well for everything, but I like Translat*able*Message much more than anything else | 15:11 |
| * barry wants to spend all his time in sleep() | 15:11 | |
| henninge | danilos: you're the boss | 15:11 |
| danilos | one could say that we never fixed this because we couldn't come up with a proper name :) | 15:11 |
| jtv | ...but changing names every few years is almost as good, right? ;-) | 15:12 |
| danilos | barry: you can instead look at the incremental diff for the review you did for me on Friday (thanks!), per your request, I made it another 800 lines :) | 15:12 |
| jtv | barry: one of those things in life we shouldn't automate | 15:12 |
| barry | ooh! pretty footers | 15:12 |
| danilos | jtv: heh, yeah, definitely, that helps a lot keep the momentum | 15:12 |
| barry | jtv: oh trust me, i'm not assigning that task to my clone army, i'm keeping that one for myself. sure, i'll let a clone eat for me now and then, or shave or stuff like that | 15:13 |
| henninge | oh, here comes a review ... | 15:13 |
| jtv | barry: I wouldn't want to automate eating either, but frankly, "hungry" is a problem I already fixed. Why does it keep regressing? | 15:14 |
| beuno | sinzui, https://staging.launchpad.net/ubuntuone-client | 15:16 |
| beuno | TraversalError: (<canonical.launchpad.webapp.tales.MenuAPI object at 0xb3ebfd0>, 'specications')<br /> | 15:16 |
| sinzui | beuno: if someone would only review my fix | 15:16 |
| sinzui | form friday | 15:16 |
| beuno | sinzui, I should of know you had already fixed it :) | 15:17 |
| beuno | flacoste, hi | 15:17 |
| barry | jtv: i don't know, but my unit test for that is always dumping core | 15:17 |
| beuno | flacoste, where's my edge rollout? :) | 15:17 |
| sinzui | beuno: The Involvement portlet will work with everything as soon as I can land it | 15:17 |
| flacoste | hi beuno! | 15:17 |
| flacoste | beuno: good question | 15:17 |
| jtv | barry: that's invariable a sign of bad input | 15:18 |
| barry | jtv: bzr rm dairy.txt | 15:18 |
| jtv | barry: please don't take this analogy to "bzr push"... :) | 15:18 |
| barry | :-D | 15:20 |
| flacoste | beuno: should be back later this morning | 15:21 |
| beuno | flacoste, merce beaucoup | 15:22 |
| danilos | rockstar: have you guys seen something like https://code.edge.launchpad.net/~danilo/launchpad/bug-410579/+merge/10179 (OOPS-1325EA163) before? | 15:23 |
| flacoste | beuno: hay no problema | 15:23 |
| danilos | flacoste: I think you want plural there (i.e. 'problemas') :) | 15:25 |
| beuno | actually, just invert the words: no hay problema | 15:26 |
| danilos | oh well, I guess I have no clue :) | 15:26 |
| bigjools | but what about the Spanish? | 15:26 |
| beuno | danilos, you need more sprints in Argentina | 15:26 |
| danilos | beuno: we'll have them, I am all for it :) | 15:27 |
| bigjools | beuno: do you know the runes to get those vertical lines I needed in the two-row-headed table on the DSPR mockup I showed you? | 15:29 |
| beuno | rockstar, hi | 15:29 |
| beuno | bigjools, css rules? | 15:29 |
| henninge | jtv: I have a review on the list now. What was that about your time? | 15:29 |
| jtv | henninge: I'm past EOD, I need to grab dinner, and I've got a call coming up. | 15:30 |
| bigjools | beuno: I would hope so, but I don't know much about how to do that sort of thing | 15:30 |
| jtv | henninge: so find another sucker. :-P | 15:30 |
| henninge | jtv: ok, talk to you tomorrow, then. I'll grab the other sucker, then... ;-) | 15:30 |
| beuno | bigjools, border-right-style: solid;? | 15:30 |
| jtv | henninge: Hals- und Beinbruch. :) | 15:30 |
| * jtv runs | 15:31 | |
| henninge | lol | 15:31 |
| === jtv is now known as jtv-brb | ||
| barry | sinzui, beuno ping | 15:32 |
| sinzui | Hi barry | 15:32 |
| beuno | barry, pong | 15:33 |
| barry | beuno, sinzui: hi. so on /people, there is a small action portlet to view projects, view distributions, view people, view meetings, register a team, merge accounts. i'm making this page w/o side portlets. how much of those functions to we want to migrate inline | 15:33 |
| barry | beuno, sinzui i have already moved merge accounts inline. is it useful to keep the 4 view actions and teh register a team action? | 15:34 |
| sinzui | barry: That is an excellent question. | 15:34 |
| sinzui | barry: For content objects, that menu would be rendered as a related pages section; the last portlet in main content. | 15:35 |
| beuno | sinzui, barry, would you guys like to joins us in the UI call today? | 15:35 |
| barry | beuno: sure what time | 15:35 |
| barry | sinzui: yeah. i really don't want to add a portlet just for those actions | 15:35 |
| beuno | mars, rockstar, EdwinGrubbs, noodles775, intellectronica, jtv-brb, barry, sinzui, UI call in 25' | 15:36 |
| noodles775 | yup. | 15:36 |
| sinzui | barry: beuno: the top-level collections are not common content objects, may be should consider a sidebar for them with an action style menu | 15:36 |
| barry | i'm just not sure how useful the 4 'view' links are. registering a new team, yeah i can see that, and i could easily add that inline | 15:36 |
| beuno | sinzui, maybe that's the right thing to do, yes | 15:36 |
| barry | beuno: cool | 15:36 |
| intellectronica | beuno: sure. cheers for the reminder | 15:36 |
| sinzui | barry: the two new menu presentations work with NavigationMenus. | 15:37 |
| barry | beuno, sinzui so, add an action style menu for this page and move those links into that? | 15:37 |
| barry | beuno, sinzui and put that menu in a sidebar? | 15:38 |
| beuno | barry, probably, but a screenshot would give you a definite answer :) | 15:38 |
| sinzui | barry: It is possible to define one menu in browser/__init__, then use it on all the top level collections. | 15:38 |
| barry | sinzui: they are slightly different among the three top level pages | 15:38 |
| barry | (currently) | 15:38 |
| barry | beuno: gotcha ;) | 15:39 |
| rockstar | beuno, hi | 15:39 |
| sinzui | barry: should they be? We can use enable to enable some links. | 15:39 |
| beuno | rockstar, I've been wondering what's up with answers? | 15:39 |
| barry | sinzui: if we move some of the actions inline, then they would share the 'View Thing' links. there are some admin functions in the sidebars currently, but like with /people, i think we can move those inline | 15:40 |
| salgado | sinzui, beuno, should https://edge.launchpad.net/codeofconduct/1.0.1/+sign be locationless? | 15:40 |
| barry | sinzui: so shared would be view projects, view distributions, view people, and view meetings | 15:40 |
| beuno | salgado, I think so, or "Launchpad.net"? | 15:41 |
| rockstar | beuno, what do you mean? | 15:41 |
| sinzui | barry: these pages could be the first legitimate use of a context and view navigation menu. Consider that (+) Register <yourself|product> is in a action menu, and the other collections are inline in a related searches menu | 15:41 |
| beuno | rockstar, I haven't seen any landings? | 15:41 |
| rockstar | beuno, it's because I haven't yet landed anything. | 15:41 |
| salgado | beuno, "Launchpad.net"? | 15:41 |
| barry | sinzui: that makes sense | 15:41 |
| beuno | rockstar, any reason for it? as in, are you going to land everything in one chunk? | 15:42 |
| rockstar | beuno, I have a pipeline here where Answers is being ported. It's getting along. | 15:42 |
| barry | sinzui: okay cool. let me see what i can mock up | 15:42 |
| beuno | salgado, I think the location for everything that's not in a context is "Launchpad.net". sinzui? | 15:42 |
| sinzui | barry: I think we need to move the browse/search links inline if they exist | 15:42 |
| sinzui | beuno: salgado: yes. | 15:42 |
| beuno | rockstar, I'm asking because we're tracking progress in https://devpad.canonical.com/~mars/conversions.html | 15:43 |
| beuno | rockstar, and answers is at zero, and I get asked about it a lot :) | 15:43 |
| rockstar | beuno, I understand this. If I wasn't filling in for abentley on CHR today, we'd probably see changes. | 15:43 |
| barry | sinzui: /people doesn't have those links | 15:43 |
| rockstar | beuno, why anyone is asking you I don't know. | 15:43 |
| sinzui | beuno: everyone. do not just look at the number of templates converted. thumper ans I are also deleting pages | 15:43 |
| beuno | sinzui, we don't have a way of tracking that, do we? | 15:44 |
| rockstar | sinzui, good point. I've deleted probably 8 templates so far. | 15:44 |
| === deryck_ is now known as deryck | ||
| sinzui | barry: true, but a related pages menu should be shared by all the top-level collections, that Is why I mention that we want a common menu in __init__.py and that is related, not action | 15:45 |
| sinzui | rockstar: you rock | 15:45 |
| === jtv-brb is now known as jtv | ||
| salgado | beuno, sinzui, I'm not following you. what's this "Launchpad.net" location? is it just another name for the locationless macro? | 15:45 |
| barry | sinzui: yes, i think so | 15:45 |
| sinzui | beuno: we needed to save the count of total pages when we started | 15:45 |
| rockstar | sinzui, :) I'm not done yet. | 15:45 |
| rockstar | sinzui, generic-edit is frakkin awesome. | 15:45 |
| sinzui | yep | 15:46 |
| beuno | salgado, yes | 15:46 |
| danilos | henninge: I've filed a https://blueprints.edge.launchpad.net/rosetta/+spec/pofile-translate-page and the first bug for you (bug #414856, linked from the blueprint as well) | 15:55 |
| mup | Bug #414856: Provide a model class for TranslatableMessage <cleanup> <Launchpad Translations:Triaged by henninge> <https://launchpad.net/bugs/414856> | 15:55 |
| henninge | danilos: cheers, now I find purpose in life! | 15:59 |
| henninge | ;) | 15:59 |
| danilos | henninge: there you go, I am always happy to be so helpful :) | 16:01 |
| beuno | barry, UI call! | 16:03 |
| beuno | kiko's # | 16:05 |
| kiko | yay | 16:05 |
| beuno | hola kiko | 16:05 |
| barry | beuno: ah dang. calling in now | 16:12 |
| flacoste | beuno: edge updated and will be updated daily from now on | 16:15 |
| beuno | flacoste, danke | 16:15 |
| sidnei | gary_poster, flacoste: ping | 16:22 |
| gary_poster | sidnei: pong | 16:22 |
| sidnei | gary_poster: we found an issue that seems like it might affect launchpad too | 16:23 |
| gary_poster | sidnei: what's up? | 16:23 |
| sidnei | gary_poster: request.supportsRetry() does a sleep() with a random number in the version of zope3 we are using | 16:23 |
| gary_poster | heh, uh...weird | 16:23 |
| gary_poster | sidnei: is that as insane as it sounds? | 16:24 |
| sidnei | gary_poster: yeah :/ | 16:24 |
| sidnei | gary_poster: seems like this was reported as #401586 | 16:25 |
| mup | Bug #401586: Zope sleeps during tests <test-system> <Launchpad Foundations:Fix Committed by jml> <https://launchpad.net/bugs/401586> | 16:25 |
| sidnei | except it's being papered over during tests, and might still affect production | 16:25 |
| gary_poster | sidnei: looks like it's only being papered over for one test, if I read that bug report correctly. have you seen if this is in trunk for that package? | 16:26 |
| sidnei | gary_poster: about to check | 16:27 |
| gary_poster | me too ;-) | 16:27 |
| gary_poster | sidnei: yes | 16:27 |
| gary_poster | sidnei: not an env; apparently supposed to be used as a monkey patch... | 16:28 |
| gary_poster | changed I mean | 16:28 |
| sidnei | gary_poster: yeah. also, the sleep() should probably be in retry() not in supportsRetry() right? | 16:29 |
| gary_poster | sidnei: yeah, I would sure think so. have you done an annotate yet to see who did this thing? I went to the web interface. | 16:30 |
| gary_poster | sidnei: stevea did it, with Jim following along behind... | 16:31 |
| sidnei | gary_poster: indeed | 16:32 |
| gary_poster | sidnei: you wanna follow up on list/IRC/steve, or me? | 16:32 |
| gary_poster | maybe we should look at doctests really wuickly | 16:33 |
| gary_poster | quickly | 16:33 |
| BjornT | sidnei, gary_poster: my guess would be that if two requests collides with each other, causing a retry, they shouldn't be retried at the same time, causing them to collide again. not sure how feasible that use case is, though... | 16:35 |
| gary_poster | sidnei: I don't see anything explaining it in doctests, interfaces, or tests | 16:35 |
| gary_poster | BjornT: yes, but why in supportsRetry rather than retry? | 16:35 |
| sidnei | gary_poster: actually, it was jim that added it, and stevea just cleaned up 1/True | 16:36 |
| gary_poster | sidnei: ah, ok, I was not paying attention to the revids closely :-/ | 16:37 |
| BjornT | gary_poster: yeah, that seems a bit crackful... could it be that the transaction gets started before retry() is called? | 16:37 |
| BjornT | nope, doesn't look like that would be the case | 16:38 |
| gary_poster | BjornT: no don't think so either | 16:38 |
| gary_poster | sidnei: you want me to contact Jim about this? Or are you going to pursue? | 16:39 |
| sidnei | gary_poster: let me ask therve, he's the one that found it. we are about to leave for lunch. | 16:40 |
| gary_poster | sidnei: ack | 16:40 |
| sidnei | gary_poster: so, if you can ping jim that would be great, as you know we are resource constrained. :) | 16:42 |
| gary_poster | sidnei: ok will do. | 16:42 |
| bigjools | beuno: colgroup FTW -> http://people.canonical.com/~ed/dspr_mockup4.png | 16:50 |
| beuno | bigjools, NAIS | 16:50 |
| beuno | that page still has issues, but getting there | 16:51 |
| bigjools | beuno: I am only aware of the file size one now ...? | 16:51 |
| beuno | bigjools, yes, and things are kind of squished? | 16:52 |
| beuno | fonts are wonky | 16:52 |
| bigjools | it renders differently in Konq vs FF | 16:52 |
| Ursinha | danilos, hi | 16:53 |
| danilos | Ursinha: hi, how's it going? | 16:53 |
| Ursinha | danilos, good, good | 16:54 |
| beuno | flacoste, https://dev.launchpad.net/UserInterfaceReviewNotes | 16:57 |
| barry | beuno: https://dev.launchpad.net/ReviewerSchedule | 16:58 |
| barry | leonardr: ping | 16:59 |
| leonardr | barry, yo | 16:59 |
| barry | leonardr: there's a critical bug in lazr.restful 0.9.3. can you do a quick update to 0.9.4? simple.py does not import traceback | 16:59 |
| leonardr | dammit | 17:00 |
| leonardr | sure | 17:00 |
| === matsubara is now known as matsubara-lunch | ||
| barry | let me make sure my test works with that change... | 17:00 |
| barry | leonardr: yep. my test fails but for unrelated reasons. adding traceback to simple.py will fix the problem | 17:02 |
| rockstar | flacoste, I have a user asking me why we're using SSL. What should I tell him? | 17:02 |
| barry | leonardr: rs=me | 17:03 |
| gary_poster | leonardr: before you make another release... | 17:03 |
| leonardr | ... | 17:03 |
| gary_poster | maybe you should remove this 2.5-ism | 17:03 |
| gary_poster | File "/home/gary/canonical/lp-sourcedeps/eggs/tmpm4lpr9/lazr.restful-0.9.3-py2.4.egg/lazr/restful/example/wsgi/root.py", line 44 | 17:03 |
| gary_poster | self.schema = ('https' if config.use_https else 'http') | 17:03 |
| barry | gary_poster: 2.6'ism? | 17:04 |
| gary_poster | barry, heh, I couldn't remember :-) . I went for being confident in the hope that at least I'd communicate my point ;-) | 17:04 |
| barry | :-D | 17:04 |
| beuno | kfogel, any news on the LP badge? | 17:05 |
| beuno | deryck, description editing on edge, woooooooooooooooooo | 17:12 |
| deryck | beuno, excellent!!! | 17:12 |
| beuno | deryck, what do you think about making the descriptiuon text larger? | 17:14 |
| deryck | beuno, totally fine with that. I did wonder if it was small once. Early on. :) | 17:14 |
| beuno | :) | 17:14 |
| deryck | beuno, I hate to be too lazy, but do you mind opening a bug on that for me? | 17:16 |
| beuno | deryck, damn, I was about to ask you the same thing | 17:17 |
| deryck | heh | 17:17 |
| beuno | you win for being slightly less lazy | 17:17 |
| barry | leonardr: i'm going to get some lunch. ping me if you need a review. would love to get 0.9.4 out today (for my talk tonight) | 17:17 |
| * barry -> lunch | 17:17 | |
| deryck | beuno, and that's the grown-folks version of the little kids "not it!" played out in IRC. | 17:17 |
| leonardr | gary: since barry just left, would you review https://pastebin.canonical.com/21222/ ? | 17:17 |
| beuno | deryck, LOL | 17:17 |
| gary_poster | leonardr: yes. looking | 17:21 |
| gary_poster | leonardr: r=gary | 17:21 |
| leonardr | yay | 17:21 |
| === beuno is now known as beuno-lunch | ||
| === salgado is now known as salgado-lunch | ||
| leonardr | gary: argh, i forgot this part | 17:23 |
| leonardr | === modified file 'src/lazr/restful/version.txt' | 17:23 |
| leonardr | --- src/lazr/restful/version.txt 2009-08-17 13:38:04 +0000 | 17:23 |
| leonardr | +++ src/lazr/restful/version.txt 2009-08-17 16:23:45 +0000 | 17:23 |
| leonardr | @@ -1,1 +1,1 @@ | 17:23 |
| leonardr | -0.9.3 | 17:23 |
| leonardr | +0.9.4 | 17:23 |
| leonardr | gimme an ok on that and i'll do the release | 17:24 |
| gary_poster | leonardr: +1 | 17:24 |
| leonardr | barry: 0.9.4 is out | 17:27 |
| gary_poster | leonardr: awesome thanks | 17:27 |
| rockstar | sinzui, could I get you to look at https://answers.edge.launchpad.net/launchpad/+question/80132 ? | 17:30 |
| sinzui | rockstar: I am replying. I need to read the code first | 17:33 |
| rockstar | sinzui, great, thanks. | 17:33 |
| bigjools | beuno-lunch, sinzui: I made a few tweaks: http://people.canonical.com/~ed/dsp_mockup_with_linkage.png | 17:39 |
| bigjools | any comments? | 17:39 |
| sinzui | bigjools: If you review my involvement branch, I can fix a big error on edge and you get a one-line replacement for the dsp involvement portlet. | 17:53 |
| bigjools | sinzui: can its context be set differently to the pillar? | 17:54 |
| bigjools | sinzui: I can review it, but I have to disappear for 2h first, it's food + kids bed time | 17:54 |
| sinzui | bigjools: I was *very* clever in my branch, I adapt to the pillar, read the official apps, then enable only those menu items | 17:54 |
| bigjools | sinzui: in my case, it needs to work with a DSP, not a D | 17:55 |
| sinzui | bigjools: I was thinking of you when I wrote the branch | 17:55 |
| bigjools | even though the pillar is a D (distribution) | 17:55 |
| bigjools | anyway, bbiab | 17:56 |
| sinzui | bigjools: I still do not understand th latest releases portlet. How often does *all* that information change. It looks like package details which I expect to be in the main content. | 17:56 |
| * sinzui is still an idiot about anything that has a sourcepackage in its name | 17:57 | |
| bigjools | sinzui: it *can* change on any upload, whether it does or not is another matter | 17:57 |
| sinzui | bigjools: for example, I always expect the maintainer and version to be the first portlet in the top-left of the main content like project and product | 17:58 |
| * bigjools has to go, I can chat about this later! | 17:58 | |
| * gmb -> food | 18:01 | |
| === matsubara-lunch is now known as matsubara | ||
| gary_poster | leonardr: getting some basic failures from attempt to switch to distributions for lazr.* . One: "import lazr.restful.testing.layers" fails. Indeed, that module does not exist in 0.9.4. Where is it now? (See lib/canonical/lazr/testing/layers.py for this particular usage) | 18:06 |
| leonardr | gary: sorry, i gotta go pick up lunch. i have questions for you as well; we'll swap when i come back | 18:10 |
| gary_poster | leonardr: cool, I'll do the same | 18:11 |
| === gary_poster is now known as gary-lunch | ||
| === leonardr is now known as leonardr-lunch | ||
| barry | leonardr-lunch: thanks! | 18:14 |
| greg-g | dang, edge.lp just got even sexier with the inline description editing and new description layout | 18:16 |
| beuno-lunch | bigjools, in the portlet | 18:23 |
| beuno-lunch | "Uploaded by:" should be in a separate line than the person's name | 18:23 |
| === beuno-lunch is now known as beuno | ||
| === salgado-lunch is now known as salgado | ||
| flacoste | rockstar: sorry, forgot to hit ENTER before getting distracted by something else: SSL, we are using to secure logged in connection, we should drop it for anonymous users | 18:29 |
| flacoste | there is a bug open about that | 18:29 |
| rockstar | flacoste, well, I think the user was confused. He was calling it an "SSL leak" because Google could index our bugs. | 18:30 |
| flacoste | hmm, yeah, that is confused | 18:30 |
| beuno | salgado, how are those breadcrumbs going? | 18:40 |
| === leonardr-lunch is now known as leonardr | ||
| salgado | beuno, I need to talk to flacoste about them, but if he's ok with the idea of using canonical_url(obj, rootsite='mainsite') for the links there, I should have it ready for review RSN | 18:45 |
| flacoste | salgado!!! | 18:45 |
| flacoste | salgado: can I call you? | 18:45 |
| salgado | flacoste, sure, I'm ready | 18:45 |
| barry | sinzui: i guess you can't have a searchless main_side page, eh? | 18:53 |
| beuno | barry, did you file the bug about the language editing not working anymore? | 18:53 |
| barry | beuno: i thought so, but maybe not :/ | 18:54 |
| sinzui | barry: indeed we cannot. Have you discovered a new layout? "collection" is what I would name it if we need it. | 18:55 |
| barry | omg bork! someone confirm that https://edge.launchpad.net/lazr-js is giving a TraversalError | 18:55 |
| barry | that looks like a bad typo that slipped through :( | 18:56 |
| beuno | barry, it is, and sinzui knows all about it | 18:56 |
| barry | beuno: well then, good! otoh, i can't confirm whether i filed a bug on that or not ;) | 18:56 |
| beuno | barry, go for another one, free karma | 18:58 |
| deryck | sinzui, hi. | 18:58 |
| sinzui | beuno: barry: the fix is being reviewed now | 18:58 |
| sinzui | Hi deryck | 18:58 |
| salgado | flacoste, https://wiki.canonical.com/Launchpad/UI/Navigation | 18:58 |
| barry | beuno: bug 413793 | 18:59 |
| mup | Bug #413793: inline editing doesn't play nicely with launchpad 3.0 UI <LAZR Javascript Library:New> <https://launchpad.net/bugs/413793> | 18:59 |
| deryck | sinzui, can you look at my question on bug 413611? | 18:59 |
| mup | Bug #413611: Convert the comment add templates to 3.0 UI <Launchpad Bugs:In Progress by deryck> <https://launchpad.net/bugs/413611> | 18:59 |
| * sinzui looks at diff | 19:00 | |
| sinzui | deryck: The answer is not good | 19:01 |
| deryck | thanks! | 19:01 |
| deryck | oh bummer | 19:02 |
| sinzui | deryck: form does not use the form-layout-macros, so the label is not being made for you | 19:02 |
| beuno | flacoste, joey, kiko, one second drop with the new design: http://www.webpagetest.org/result/090812_22DN/1/details/ vs http://www.webpagetest.org/result/090817_235W/1/details/ | 19:02 |
| sinzui | deryck: I think we should hack the missing pieces in | 19:03 |
| beuno | I don't quite understand the request count though, ti says it only went down by 4 | 19:04 |
| kiko | beuno, how about we get some sprites in there now? :) | 19:04 |
| deryck | sinzui, I wondered if it was because of the custom form class. But was confused by the branch using edit-generic showing the same issue. | 19:04 |
| beuno | kiko, yeah. Although, the biggest impact would be if flacoste finished his CSS compression branch so we don't make so many calls | 19:05 |
| kiko | beuno, why doesn't the JS start loading earlier? | 19:05 |
| beuno | kiko, 13 calls *just* for CSS | 19:05 |
| kiko | I know | 19:05 |
| kiko | beuno, note the 404 btw | 19:05 |
| beuno | kiko, order on the page. The JS comes after all those CSS | 19:05 |
| beuno | kiko, yeah, no idea what that is about, but should be looked into | 19:06 |
| sinzui | deryck: Many forms that have a good schema can use generic-edit.pt. which calls the form macros. Some pages forms need some extra-form info so they need their own template. | 19:06 |
| sinzui | deryck: I'll copy the diff, and pastebin a suggestion | 19:06 |
| kiko | beuno, can you put the JS before and see if it makes a difference? | 19:08 |
| deryck | sinzui, right, but shouldn't my branch using the generic-edit.pt have the correct heading styles applied to page? (This is a second question, apparently unrelated to the comment branch diff you looked at.) | 19:08 |
| sinzui | no | 19:08 |
| sinzui | deryck: the macro makes that, not the template | 19:08 |
| === mrevell is now known as mrevell-dinner | ||
| === gary-lunch is now known as gary_poster | ||
| joey | beuno: they both look great to me. no immediate pref | 19:09 |
| sinzui | deryck: This is the macro used in *most* forms that make the label a <h1> and get the cancel button right: | 19:10 |
| sinzui | metal:use-macro="context/@@launchpad_form/form" | 19:10 |
| beuno | kiko, I'll look into it, yes | 19:10 |
| sinzui | deryck: does the view descend from LaunchpadFormView? | 19:11 |
| beuno | kiko, it looks like it should make a difference | 19:11 |
| * deryck looks.... | 19:11 | |
| beuno | will test tough | 19:11 |
| beuno | though | 19:11 |
| deryck | sinzui, no, it's: LaunchpadEditFormView --> BugEditViewBase --> BugEditView | 19:13 |
| deryck | sinzui, this is my problem then, no? | 19:13 |
| sinzui | deryck: that is great, we can still us use it | 19:13 |
| * sinzui hacks | 19:13 | |
| deryck | excellent, thanks for the help. | 19:14 |
| leonardr | gary: here's my question | 19:16 |
| gary_poster | leonardr: cool, listening | 19:16 |
| leonardr | i've got a branch at lp:~leonardr/lazr.restful/django-helpers that adds a useful django bit to the django zcml file | 19:16 |
| leonardr | to test this zcml bit i need to import a django class | 19:16 |
| leonardr | but i don't want lazr.restful to depend on django | 19:16 |
| leonardr | what do i do? | 19:16 |
| gary_poster | leonardr: maybe you could get away with something less drastic depending on the goal of your test(s), but sys.modules hacks are an option. | 19:17 |
| leonardr | you mean create a fake version of that class? | 19:18 |
| leonardr | would you take a look at the branch and tell me what you'd do? | 19:18 |
| gary_poster | leonardr: yeah, in a fake module, stuffed into sys.omdules. sure | 19:18 |
| kiko | beuno, it should, since it's the largest file and it seems to be downloadable together with the CSS right? | 19:19 |
| gary_poster | leonardr: Looked at it. I don't see too many options other than a sys.modules hack or simply not testing it. :-/ Are you asking for guidelines in the evils of sys.modules hacks? | 19:22 |
| leonardr | gary: since that's your suggestion, yes please | 19:22 |
| sinzui | deryck: https://pastebin.canonical.com/21228/ | 19:23 |
| beuno | kiko, yeap. Will let you know how it goes | 19:24 |
| kiko | beuno, is 150ms time to first byte not a lot? | 19:26 |
| kiko | beuno, and actually, 1s for the actual HTML | 19:26 |
| kiko | wow | 19:26 |
| kiko | oh maybe that is the time to render the actual page | 19:27 |
| deryck | sinzui, thanks! Reading through it and trying to get things working... | 19:28 |
| beuno | kiko, 821 ms for the first byte | 19:29 |
| beuno | DNS + Initial connection + SSL | 19:29 |
| kiko | beuno, I mean why so different between the two different page loads you showed? | 19:29 |
| beuno | kiko, hrm, I didn't notive that | 19:30 |
| beuno | notice | 19:30 |
| kiko | beuno, maybe do a few runs to see if it's stable | 19:30 |
| === brianchidester_ is now known as brianchidester | ||
| beuno | kiko, very flaky: http://www.webpagetest.org/result/090817_235Y/1/details/ | 19:32 |
| beuno | 4067 ms TTFB | 19:32 |
| gary_poster | leonardr: I'm writing up an example and making sure it works. didn't see an example with a quick Google search. Meanwhile, did you see my previous question about the lazr.restful.testing.layers? | 19:33 |
| beuno | kiko, I wonder if it's LP server or their servers? | 19:33 |
| leonardr | gary: yeah, i'll look into that | 19:33 |
| sinzui | beuno: https://devpad.canonical.com/~curtis/editlang.png | 19:33 |
| sinzui | ^I tripled the number of languages the user can see in the form. | 19:33 |
| kiko | beuno, no idea either. but the JS change and the 404 alone are worth the time investment | 19:34 |
| beuno | kiko, I'm working on a branch for the JS, and will look into the 404 | 19:35 |
| kiko | cool | 19:35 |
| beuno | sinzui, left-to-right ordering is bad | 19:35 |
| beuno | sinzui, if it's going to have that layout, I think I'd prefer a one column list | 19:35 |
| sinzui | beuno: yes it is, but it is better than it was before | 19:35 |
| beuno | sinzui, https://edge.launchpad.net/@@/images/code-arrow-right.png | 19:36 |
| beuno | that is being referenced in /bzr | 19:37 |
| beuno | and, as you can see, the arrow for code is missing | 19:37 |
| sinzui | That is fixed in my branch. It passed review, I am testing it noe | 19:37 |
| sinzui | and the blueprint arrow is fixed | 19:37 |
| sinzui | and the specifications spelling is fixe | 19:37 |
| sinzui | and the portlet runs on pillars, series, and sourcepackages | 19:37 |
| sinzui | I rock | 19:37 |
| beuno | kiko, tests from the UK are *much* faster, but flaky as well: http://www.webpagetest.org/result/090817_2361/ | 19:38 |
| beuno | repated tests, that is | 19:38 |
| beuno | sinzui, AWESOMENESS | 19:38 |
| leonardr | gary: the MockRootFolder defined in testing/layers.py has been moved to testing/webservice.py | 19:38 |
| beuno | sinzui, I think that languages in 3 columns are actually harder to find | 19:38 |
| gary_poster | leonardr: back atcha: https://pastebin.canonical.com/21231/ | 19:39 |
| beuno | sinzui, so, a one column, longer, scrollable, is a big win | 19:39 |
| sinzui | beuno: I can fix that | 19:39 |
| leonardr | gary: great, should i worry about tearing that down afterwards? i don't think it matters since we aren't using django | 19:40 |
| gary_poster | leonardr: if you were being super careful, you'd only do that if the import doesn't work in the first place, and yes, you'd tear it down if you had to set it up. If I were doing it, I would be obsessive enough to do all of that, I suspect; and if I were reviewing, I'd ask for it, I suspect. It wouldn't add much, and it's best practice. OTOH, I don't object if you just see if it gets past your reviewer, because you are rig | 19:43 |
| leonardr | gary: ok, just tell me how to tear it down. del? | 19:45 |
| gary_poster | leonardr: yeah | 19:45 |
| gary_poster | leonardr: MockRootFolder is in __all__ of webservice.py but is not actually defined :-/ | 19:52 |
| gary_poster | (not defined anywhere in package) | 19:52 |
| === danilos is now known as danilo-afk | ||
| gary_poster | leonardr: if you don't need MockRootFolder in lazr.restful maybe I'll move it back out to lib/canonical/lazr/testing... | 20:00 |
| beuno | intellectronica, bug 414982 | 20:08 |
| mup | Bug #414982: Long milestone names break the bugtask table <Launchpad Bugs:New> <https://launchpad.net/bugs/414982> | 20:08 |
| beuno | BjornT, the new bug comment button is super mega cool | 20:08 |
| intellectronica | beuno: yeah, using the long names was a bit short sighted. i'll switch back to the short name | 20:09 |
| gary_poster | leonardr: doing that gets all -t blueprint tests to pass, which has been my smoke test. could you recommend a test command to exercise lazr.restful within launchpad? | 20:09 |
| gary_poster | trying -t webservice | 20:10 |
| beuno | intellectronica, ah, cool, you know about it | 20:10 |
| intellectronica | beuno: yeah, just noticed this happening earlier today when playing with a foundations bug | 20:11 |
| leonardr | gary: -t webservice | 20:11 |
| beuno | intellectronica, super | 20:11 |
| gary_poster | leonardr: cool. Total: 620 tests, 33 failures, 3 errors in 1 minutes 23.013 seconds. | 20:12 |
| gary_poster | leonardr: this is a big culprit for many of the failures: AttributeError: 'LaunchpadWebServiceCaller' object has no attribute 'domain' | 20:13 |
| gary_poster | leonardr: have a quick suggestion to try to fix, or should I just pass this to you? | 20:14 |
| gary_poster | (or I can dig in on it; I'll probably move on to something else for now though unless you have an immediate suggestion) | 20:14 |
| leonardr | gary: paste the failruies and i'l take a look | 20:15 |
| gary_poster | leonardr: http://pastebin.ubuntu.com/254676/ which is 17000+ lines, but if you just look at the first traceback you've seen the partinent bit | 20:20 |
| gary_poster | pertinent | 20:21 |
| leonardr | ok | 20:22 |
| kiko | beuno, sinzui: in general I really like the new project pages, good job | 20:22 |
| * beuno high-fives sinzui | 20:22 | |
| kiko | sinzui, minor quirk: listing the milestones for the current series in the project group's project listing would make my life a lot easier | 20:23 |
| sinzui | kiko: salgado and I discussed that | 20:23 |
| sinzui | kiko: I ask him not to make changes just yet, I want the same listing on project, product, distro, and +series | 20:24 |
| beuno | flacoste, kiko, any of you interested in reviewing the javascript move on the header? https://code.edge.launchpad.net/~beuno/launchpad/move-js-in-header/+merge/10267 | 20:24 |
| kiko | okay, but if you look at the listing at | 20:24 |
| kiko | sinzui, https://edge.launchpad.net/launchpad-project you'll see what I mean | 20:24 |
| kiko | beuno, what does the code look like? | 20:24 |
| kiko | beuno, also, does it actually change the rendering profile? I'd be happy to cowboy that onto staging and then run a test against it | 20:25 |
| gary_poster | leonardr: hm, this looks a bit tricky. Seems to come down to a switch from the zope caller to the wsgi intercept bit... | 20:25 |
| sinzui | I will add a consistent representation of milestones when I update the other pages. | 20:25 |
| kiko | sinzui, cool | 20:25 |
| beuno | kiko, just moves it on the main-template. I need to run it on staging to show the rendering profile, so if we can cowboy it in, that would be great | 20:26 |
| flacoste | beuno: what is this about? | 20:26 |
| beuno | flacoste, if you look at: http://www.webpagetest.org/result/090817_235W/1/details/ | 20:27 |
| flacoste | beuno: the diff on the m+p is screwed up | 20:27 |
| beuno | flacoste, you'll see that, in theory, if the large javascript file was loaded first, we'd get more parallelization | 20:27 |
| beuno | argh.... | 20:27 |
| beuno | why did that happen to the diff? | 20:29 |
| beuno | flacoste, the diff is very simple | 20:29 |
| beuno | just moves in in the main template | 20:30 |
| kiko | sinzui, ugly ugly: OOPS-1325ED287 | 20:30 |
| kiko | TraversalError: (<canonical.launchpad.webapp.tales.MenuAPI object at 0x2aaaad048bd0>, 'specications')<br /> | 20:30 |
| beuno | flacoste, look at like 450 | 20:30 |
| kiko | somebody's not testing something :-( | 20:30 |
| intellectronica | thekorn_: nice catch! (the overly eager bug linkification). should be very easy to fix. would you be interested in having a go at that? i'll be happy to help | 20:32 |
| leonardr | gary: here's a suggestion | 20:33 |
| leonardr | add a super() call to LaunchpadWebServiceCaller | 20:33 |
| leonardr | pass in a domain based on base_url | 20:33 |
| gary_poster | leonardr: ah! ok, and the protocol from that too | 20:34 |
| flacoste | beuno: why is the diff screwed? do you have merge unmerged branches? | 20:34 |
| flacoste | beuno: badly stacked? | 20:35 |
| flacoste | beuno: can you try it out on staging? | 20:35 |
| beuno | flacoste, no idea. I updated trunk locally, branched it, and pushed | 20:35 |
| beuno | flacoste, did what I always do | 20:35 |
| flacoste | ok | 20:36 |
| beuno | flacoste, if you can get it on staging, we can test to see if it does help loading or not | 20:36 |
| thekorn_ | intellectronica, sure, if you could point me to the right direction (file to look at), I can look at it tomorrow | 20:36 |
| kiko | sinzui? | 20:37 |
| kiko | bac, EdwinGrubbs: can either of you look into that OOPS? | 20:37 |
| sinzui | kiko: It was fixed in my branch las friday | 20:37 |
| kiko | sinzui, oh, but not on edge? | 20:38 |
| sinzui | kiko: I am testing the branch now. The fix will be merged in about 2 hours | 20:38 |
| kiko | sinzui, perfect thanks. | 20:38 |
| beuno | sinzui, shouldn't this case be an h2 for the project's name? https://code.edge.launchpad.net/~launchpad | 20:38 |
| kiko | sinzui, some untested code somewhere? | 20:38 |
| sinzui | kiko: yes. | 20:39 |
| sinzui | kiko: We intended to replace the involvement portlet with something better. I started work on the issue since we already had plans | 20:39 |
| intellectronica | thekorn_: see lib/canonical/launchpad/webapp/tales.py | 20:41 |
| sinzui | beuno: I think so. Think about the bread crumbs. | 20:45 |
| sinzui | beuno: I think this relates to the misnamed heading-slot. | 20:46 |
| sinzui | beuno: I really need to rename that before more mistakes are made | 20:46 |
| beuno | sinzui, yeah. Who needs to make the change? code? noodles? or salgado? | 20:46 |
| sinzui | code forced the <h1> into the heading-slot | 20:47 |
| sinzui | Can I rename it context-slot? | 20:47 |
| beuno | uhm, I don't care :) | 20:47 |
| sinzui | beuno: barry is making an action menu for /people | 20:48 |
| sinzui | beuno: barry is adding Register a team | 20:49 |
| beuno | sinzui, great | 20:49 |
| sinzui | beuno: but should he also as "Register yourself" if you are not logged in. yes it duplicates the login, but it is also consistent | 20:49 |
| beuno | sinzui, yes, although maybe not with those words | 20:50 |
| beuno | "Create an account"? | 20:50 |
| sinzui | Yes, thate is better | 20:50 |
| barry | beuno, sinzui cool, i'll add it with 'Create an account' | 20:51 |
| sinzui | beuno: I think the top collection pages need two menus: the action menu on the side to create items like projects and team, and a related menu at the bottom of the content for things like browse Projects. | 20:52 |
| beuno | sinzui, sounds like a plan | 20:53 |
| sinzui | beuno: this is the first legitimate use for an action menu and related menu on the same page. This then may need to happen for /bugtrackers and /lauguages | 20:54 |
| beuno | sinzui, yes, I'm fine with that | 20:55 |
| EdwinGrubbs | beuno: ping | 21:32 |
| beuno | EdwinGrubbs, pong | 21:33 |
| EdwinGrubbs | beuno: for the team index page, poolie had a couple of suggestions that I want to run by you first | 21:35 |
| EdwinGrubbs | beuno: 1. remove the map | 21:35 |
| beuno | EdwinGrubbs, completely remove it? | 21:36 |
| EdwinGrubbs | beuno: 2. The portlets have a black link in the row for the portlet's title, such as ">> All members". He thinks they should be blue and inside the portlet body. | 21:37 |
| beuno | re: 2, screenshot? | 21:38 |
| EdwinGrubbs | beuno: well, he said the map was really useful, so putting it towards the bottom would probably also be ok. | 21:39 |
| EdwinGrubbs | beuno: see the links in the Related Projects and Latest Questions portlets in this screenshot https://dev.launchpad.net/TeamIndexPage | 21:40 |
| beuno | EdwinGrubbs, I agree that it's not the primary thing there | 21:40 |
| beuno | the map, tha tis | 21:40 |
| beuno | EdwinGrubbs, sounds like the "created by" should be in the same place it is for every other object? | 21:41 |
| beuno | top-right? | 21:41 |
| beuno | sinzui? | 21:41 |
| sinzui | Hi beuno | 21:42 |
| beuno | EdwinGrubbs, the polls portlet looks very messy | 21:42 |
| sinzui | hmm | 21:42 |
| bac | hi sinzui. i just sent in a MP for the +announcements branch. would you like to review it? | 21:42 |
| sinzui | I was going to hack on poll to ight | 21:42 |
| sinzui | bac: thanks | 21:42 |
| beuno | EdwinGrubbs, I think the location of those links are fine | 21:43 |
| beuno | not sure if theys hould be blue | 21:43 |
| sinzui | poll have always been a problem | 21:43 |
| beuno | EdwinGrubbs, I'm inclined to say they should be, and maybe drop the triangle as well | 21:44 |
| EdwinGrubbs | beuno: so, yes to blue, in the body, and no triangle. | 21:44 |
| beuno | EdwinGrubbs, no, the location is fine | 21:44 |
| beuno | so minus the "in the body", yes | 21:45 |
| beuno | and I think moving the map down is ok, in place of the "Members" portle | 21:45 |
| beuno | EdwinGrubbs, related projects portlet is wonky | 21:45 |
| beuno | as the link is aligned to the far-right | 21:45 |
| beuno | it should be closer to it's content | 21:45 |
| beuno | as ion, shouldn't use up 100% width | 21:46 |
| sinzui | EdwinGrubbs: The polls portlet is doing three things. Current and "(+) Register a new poll" are legitimate. Recent polls needs to be a link to (i) Show recent polls. I do not think we should be showing polls that are not active yet to non-owners. We only show pending annoucements to owner, the same rule should apply | 21:48 |
| sinzui | EdwinGrubbs: why is your pool portlet with square corners? | 21:48 |
| sinzui | EdwinGrubbs: The lines that divide content are not in 3.0 style. The fact that it has more than one heading indicates it does too much | 21:49 |
| EdwinGrubbs | sinzui: the square corners are purely accidental. What is the css class for 3.0 style content dividers? | 21:56 |
| sinzui | EdwinGrubbs: we do not support dividers in 3,0 | 21:57 |
| sinzui | A portlet uses class="portlet" | 21:57 |
| sinzui | EdwinGrubbs: It get 1 <h2> | 21:57 |
| EdwinGrubbs | ok | 21:58 |
| sinzui | EdwinGrubbs: The poll portlet does not justify dividers or two heads | 21:58 |
| * beuno feels 3.0 in the air | 21:59 | |
| sinzui | EdwinGrubbs: The basic structure of other portlets on ths side look like this: https://pastebin.canonical.com/21243/ | 22:01 |
| sinzui | EdwinGrubbs: The challenge then is to settle what information goes into the Poll item. Just the heading? I think the poll close time is important | 22:02 |
| sinzui | EdwinGrubbs: when you want to create a list of links at the bottom of content such as in a portlet, use <ul class="horizontal"> To be consistent | 22:03 |
| bac | sinzui: can you paste the URL for the page template assignments, please? | 22:07 |
| sinzui | bac: https://dev.launchpad.net/UI/ThreeDotOPages | 22:09 |
| sinzui | bac: I have approval to land all the form pages for distromirrors and packages You only need to do the | 22:10 |
| sinzui | main pages | 22:11 |
| bac | sinzui: ok | 22:11 |
| === salgado is now known as salgado-afk | ||
| thumper | hi ho, hi ho, it's off to work I go | 22:13 |
| bac | sinzui: so here: https://edge.launchpad.net/ubuntu/+cdmirrors you are saying i need to do 'cd mirrors' and 'archive mirrors' but you've already done 'register mirror'? | 22:14 |
| sinzui | Correct | 22:15 |
| bac | sinzui: and what is the "package" portion of that task? | 22:15 |
| sinzui | Wow. I don' think there is anything to do for mirror except incorporate the menu and add the missing RSS feed | 22:16 |
| thumper | beuno: did you read my rambling email about the branch page? | 22:16 |
| sinzui | bac: You should coordinate with soyuz bigjoolshas already proposed a DSP. Only the SP needs design I think | 22:16 |
| bac | sinzui: ok | 22:17 |
| sinzui | bac: I might give you something harder like Polls | 22:17 |
| beuno | thumper, I did. I've been trying all day to sit down and make changes to the mockup. Have failed. | 22:17 |
| bac | ok | 22:17 |
| sinzui | Or the completely unintelligible +releated-software | 22:17 |
| thumper | beuno: heh | 22:17 |
| rockstar | thumper, is jml still on holiday? | 22:27 |
| thumper | rockstar: yep | 22:27 |
| thumper | rockstar: just you and me baby | 22:28 |
| rockstar | thumper, so it's just us again today? | 22:28 |
| thumper | rockstar: call? | 22:28 |
| * rockstar is not thumper's baby | 22:28 | |
| rockstar | Just FYI | 22:28 |
| rockstar | thumper, sure | 22:28 |
| thumper | OMG, edge has been updated | 22:32 |
| thumper | damn | 22:32 |
| thumper | now I *have* to fix the bug about the branch context | 22:32 |
| === matsubara is now known as matsubara-afk | ||
| rockstar | thumper, the internets, they fell over. | 22:49 |
| thumper | sinzui: ping | 23:04 |
| thumper | sinzui: where has the query count gone? | 23:04 |
| sinzui | Hi thumper | 23:04 |
| thumper | https://code.edge.launchpad.net/~beuno | 23:04 |
| thumper | sinzui: it used to be easy to find with firebug | 23:04 |
| thumper | now, not so much | 23:04 |
| sinzui | thumper: The whole meta data comment is missing ! | 23:05 |
| thumper | yeah | 23:05 |
| thumper | can we have it back? | 23:05 |
| thekorn | what is the best way to run one doctest, let's say ./lib/canonical/launchpad/doc/displaying-paragraphs-of-text.txt | 23:06 |
| rockstar | thumper, https://edge.launchpad.net/blogsharp | 23:07 |
| sinzui | thumper: We need to make a change to base-layout.pt to print for beta as well as devmod | 23:07 |
| sinzui | thumper: <tal:template tal:condition="not: is_lpnet"> | 23:08 |
| sinzui | will fix the issue | 23:08 |
| thumper | we don't do it for prod? | 23:08 |
| sinzui | or...lets always print it | 23:08 |
| thumper | sinzui: yes please | 23:09 |
| thumper | sinzui: always | 23:09 |
| sinzui | I do not see any reason to not print this info | 23:09 |
| thumper | me neither | 23:09 |
| sinzui | Do you agree this is a regression? | 23:09 |
| thumper | oh, yes | 23:09 |
| sinzui | I will prepare a branch for this in a few hours. I wan a test to show it is there. | 23:10 |
| thumper | flacoste: ping | 23:12 |
| === Ursinha is now known as Ursinha-nom | ||
| wgrant | Why are lots of links on the project index view black? | 23:37 |
| wgrant | Aren't LP links meant to be blue or green? | 23:37 |
| thumper | wgrant: link? | 23:38 |
| wgrant | thumper: https://edge.launchpad.net/launchpad | 23:38 |
| wgrant | Note the 'Uses Launchpad for' section. | 23:38 |
| wgrant | Each of those is a link. | 23:38 |
| wgrant | This is unobvious. | 23:38 |
| thumper | wgrant: looks like a bug to me | 23:40 |
| wgrant | thumper: But a deliberate bug. | 23:40 |
| wgrant | Like those 'See all blahblah' links that appear in the top right of sections in the body. | 23:41 |
| wgrant | That look like non-links with expanders. | 23:41 |
| rockstar | wgrant, well, it could be that we just had a CSS oversight. | 23:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
