/srv/irclogs.ubuntu.com/2009/08/19/#launchpad-dev.txt

beunokiko, approved00:00
beunoalthough it makes me wonder why *you* can't approve it  :)00:00
kikobeuno, sinzui: https://edge.launchpad.net/notify-osd persistently oopses with the same error I saw yesterday -- sorry I was out, but is this still not fixed?00:01
beunokiko, PQM was closed, so the branch didn't go in00:02
beunonot sure if sinzui managed to get it in now00:02
wgrantdevel r9131 - it landed like 20 hours ago.00:04
beunothere you go00:04
beunothe benefits of being open source *and* having wgrant around00:04
kikoheh00:05
kikookay, I gotta split00:05
kikocatch you all later00:05
=== kiko is now known as kiko-afk
rockstarOh bugger, looks like I need to port a bugs page...00:06
=== Ursinha-nom is now known as Ursinha
thumperbeuno: you around for a chat?00:34
* thumper is a very frustrated monkey00:37
* thumper does lunch01:00
=== matsubara is now known as matsubara-dinner
cprovwgrant: that's not true, all xmlrpc commands on the master side are asynchronous01:48
cprovwgrant: the slave side isn't.01:48
=== matsubara-dinner is now known as matsubara
wgrantcprov: But I've seen it cease to make XML-RPC requests to the other slave while the first one is downloading the chroot.01:55
wgrant(I verified this morning)01:55
cprovwgrant: are you using daemon/buildd-manager.tac ?01:59
wgrantcprov: That's the one.01:59
wgrantIt certainly looks like it should be async.02:01
cprovwgrant: right, check BuilddManager.scan(), the slave used for dispatching is non-blocking02:01
wgrantcprov: I'll try again this evening when I have my other buildd back, but I'm pretty sure it ceased to scan while the download was occurring.02:05
wgrantWhich makes no sense, given the code.02:05
cprovwgrant: maybe you can add more debug to the manager in order to prove your hypothesis02:06
wgrantcprov: How do I inform twistd that I want to increase the logging level?02:06
wgrantThere's lots of useful debug logging points, but they're not shown.02:07
cprovwgrant: you don't twistd doesn't accept args, needs code/config change02:07
wgrantcprov: Ah, OK.02:07
cprovwgrant: BM._setupLogger()02:08
wgrantcprov: Yup, just found that.02:08
cprovwgrant: you probably need more debugs, specially for ensurePresent() at the xmlrpc proxy. The current logging timestamp precision should be enough for spotting blockers.02:10
wgrantcprov: It is definitely synchronous somehow. I added a time.sleep(30) in the slave's ensurepresent, started a build on a real builder, and marked a non-existent builder as OK. As expected, I can see it calling ensurepresent for each file for the build. 32 or so seconds later, it logs the response.02:18
wgrantThere is no scan in between.02:18
wgrantAnd my builder that is uncontactable is still marked OK, when it should have been deactivated 90 seconds ago.02:18
wgrantOnce the build call went through after the 30 second wait for each file, the scanning started again and killed the bogus builder.02:19
wgrantSo it is synchronous, somehow.02:19
cprovwgrant: the scan cycle is synchronous with and 5 s delay, it won't finish the cycle if the dispatching started haven't finished.02:20
wgrantcprov: Ohh, I see. That's a bit bad. It is still fairly synchronous!02:22
cprovwgrant: not really, there is an async burst of dispatching ... and that combined with 60 s timeout on the xmlrpc proxy guarantees that cycles won't take much longer than that.02:23
cprovwgrant: of course we could be more async, I don't see any harm on that, but it requires more refactoring.02:24
wgrantcprov: This explains why builds often seem to take ages to finish. I'd been wondering about that.02:25
cprovwgrant: how so ? *ages*  to be scanned again ?02:26
wgrantcprov: Right.02:26
wgrantOften I'll see a logtail that is right near the end of the build.02:27
wgrantBut the build won't complete for a couple of minutes afterwards.02:27
cprovwgrant: this perception comes mostly from the collecting task02:27
cprovwgrant: specially when we have to collect and process dozens of jobs, calling process-upload several times.02:28
wgrantYep.02:28
wgrantAnd starting that isn't exactly quick...02:28
cprovwgrant: the dispatching cycle itself will always take about 80s (10s resuming, up to 60s dispatching, and some cruft) for 1 or 100 builders02:29
cprovwgrant: no, initZopeless() takes about 8s (IIRC)02:29
cprovwgrant: one change that would immediately remove that would be replacing the process-upload calls by directly instantiation of UploadProcessor()02:31
wgrantcprov: Why wasn't that done in the first place?02:31
cprovwgrant: the only gotcha with it is that we need to switch db_user02:31
wgrantcprov: Isn't it more appropriate to grant the builddmanager DB user the required privs?02:32
cprovwgrant: because the gain on async dispatching was higher02:32
wgrantAh.02:32
cprovwgrant: ehe, not from the isolation PoV02:32
cprovwgrant: uploading and publishing binaries doesn't necessarily fit in build-dispatching domain.02:33
wgrantcprov: True.02:34
cprovwgrant: but if you ask my personal opinion, I'd say that we have too-many-db-users atm ;)02:34
=== cprov is now known as cprov-zzz
cprov-zzzgood night, guys!02:45
=== matsubara is now known as matsubara-afk
thumperwho changed make TAGS to make the tags file 53Meg? at 15 it was bad enough03:43
thumperor is it just the result of buildout chagnes?03:44
sidneithumper: i suspect it should exclude the paths that contain the dependencies04:19
thumperarse06:06
thumperfor the second time in as many days my laptop's keyboard stops responding06:06
thumperHmm, some bugs say slow-keys06:18
* thumper must check that next time06:18
jtvjml, did you get word of the Mysterious Unfinished Branch Jobs?06:54
gmbHmm. Did the session DB get nuked when I wasn't looking?08:19
adeuringgood morning08:26
stubgmb: Yup08:28
gmbstub: Okay. As long as I've not gone mad.08:28
gmbOkay, madder.08:28
stubThats a seperate bug08:28
gmbArgh! I've just double-filed two bugs. Damn chromium.08:32
gmbHitting enter for form auto-completion apparently submits the form, too.08:32
jtvhi henninge08:50
jtvhi stub, gmb & all the rest :)08:51
henningehi jtv !08:51
gmbjtv: Goedemorgen.08:52
jtvgmb: Geweldig, je spreekt Nederlands!08:52
gmbjtv: Niet erg veel.08:53
jtvgmb: I seem to be making progress with your language as well: I think in the past week at least 4 Brits had me pinpointed as English with absolute confidence.08:53
jtvgmb: my girlfriend's learning Dutch... want to set up a weekly practice session on skype?  :)08:53
gmbjtv: That generally means that you're making all the right mistakes. As BjornT once told me: English doesn't have many rules, but it has a lot of exceptions.08:54
gmbjtv: It's tempting. I think I'll try to convince someone to let us sprint in Amsterdam first. It's nice to have an aim in mind :)08:55
jtvgmb: English is the lest prescriptive European language I can think of... matches the legislative culture as well.  You just do whatever everyone else does.  :)08:55
gmb:)08:55
jtvOooh, sprint in Amsterdam...  high time for another one of those08:55
jtvgmb: the drawback is that more than any other European language, English makes me feel I don't know the meanings of many words.  I merely _associate_ them with things.08:56
gmbjtv: Oh, that isn't how language is supposed to work? Damn, I've been doing it wrong all this time...08:56
gmbBut yes. that's a problem even for native English speakers.08:57
* jtv finally looks up "acrid"08:57
jtvApparently it means "The program 'dict' is currently not installed."  Some examples follow.08:58
gmbjtv: The trouble is that once you learn the words there's a good chance you'll hold on to their meanings when no-one else does and become something of a sesquipedalian.08:59
jtvSharp and harsh, or bitter and not harsh; pungent (but presumably in some particular way).  Basically a copout for "we don't know either, we only ever use it to describe gun smoke"08:59
jtvdict sesquipedalian08:59
jtva dwarf?08:59
gmbjtv: Also, the smell of powersupply smoke.09:00
jtvlol09:00
gmbjtv: Sadly, not a dwarf. Though the idea is interesting. Sesquipedalian == "Person who uses long words." Synonyms: Smartarse.09:00
jtvah, from: one apt to the usage of words like sesquipedalian09:01
jtvDict said "measuring or containing a foot and a half; as, a sequipedalian pygmy."09:02
gmbAwesome!09:02
gmbAnd, this being English, probably completely accurate.09:02
gmbYes, according to wiktionary anyway, "a foot and a half" is it's literal meaning.09:03
jtvIn Dutch, or German, or French etc, when you look up a word, you expect a definition.  Not a series of loose associations, a list of references in last year's TV programs, and an artist's impression.  (Yes Wikipedia, I'm looking at you).09:04
jtvNow Thai, Thai is the master of loosely-associated words.  Try "translating" some on thai2english.com.  It won't even find all the words' beginnings and endings, let alone conclusive meanings.09:05
gmblol.09:05
gmbThat used to be a game on some radio station or other: Translate a song title into Thai, translate it back again, see what comes out.09:06
jtvgmb: an observation.  Like English, Thai doesn't normally distinguish between orange the fruit and orange the colour. The word for juice also means water, or pretty much anything that's fluid or gel-like (basically anything you could take on a plane before 2002 but not after).  And "100%" basically means "to a significant extent."09:16
jtvThus, the Thai for "100% orange juice," strictly read, says no more than "a fluid that is to a significant extent orange in colour."09:16
gmbExcellent.09:16
mrevellHello!09:21
wgrantgmb: Does PQM still hate me?09:55
gmbwgrant: It did earlier this morning. You're number 3 in the queue at the moment so we should know within an hour whether you're cursed or not.09:59
wgrantgmb: It has so far expressed its intense dislike for me twice on this branch?09:59
gmbwgrant: Well, once was because we were in testfix, the other *looked* like a testfix issue but there's no email for a relevant breakage so I don't know.10:00
gmbwgrant: You have to remember, though, that PQM hates *me*. You, OTOH, might well have done nothing wrong :)10:00
gmb(Ask sinzui; it hates him too)10:01
wgrantHeh.10:01
wgrantThird time lucky..10:01
gmbHere's hopping10:02
gmbEr.10:02
gmbHoping.10:02
wgrantbigjools: Um, so it's not a bug that the pillar shown on the DSP code index is the distro?10:10
wgrantOh, but the app tabs link to the source package.10:11
wgrantThat's confusing,.10:11
bigjoolson phone, one sec10:12
thumperlaunchpad just passed 200000 branches \o/10:12
wgrantthumper: Ouch.10:13
wgrantthumper: Can you say how much disk space?10:13
thumperwgrant: we'll hit 300k before all the package branches are up10:13
thumperwgrant: lots10:13
wgrantAh, PQM is alive after all.10:19
bigjoolswgrant: yes it's confusing10:19
danilosmrevell: shall we mark https://launchpad.net/launchpad/2.1 as either 'stable', 'supported' or 'obsolete'?  (I hate how it's showing up among active series on the graph on launchpad.net/launchpad)10:20
bigjoolswe talking about having a packaging tab, but that would screw over bugs10:20
wgrantbigjools: A packaging tab only makes sense for products/projects/people.10:20
bigjoolsexactly10:20
bigjoolsso if it's a bug on a package ...10:21
wgrantAnd has little to do with this strange dual-context thingy.10:21
bigjoolswell it has a lot to do with it10:21
mrevelldanilos: I'm not sure what applies in our case. Obsolete I guess because you can't really run 2.1.10:21
danilosmrevell: yeah, I'd likely agree10:21
mrevelldanilos: done10:23
danilosmrevell: great, thanks (fwiw, that's what we have on old series like https://launchpad.net/rosetta/1.0)10:23
mrevelldanilos: Cool, I'll keep on top of that then, at least until our PM starts :)10:24
danilosmrevell: yes, prime minister :)10:24
mrevellheh10:24
wgrantPM? New project manager?10:25
bigjoolsyes, there a position open10:26
wgrantAh.10:28
bigjoolscan you say "singing from the same hymn sheet?" and "blue-sky thinking" ?10:29
wgrantHuh?10:31
bigjoolsPM BS bingo10:33
wgrantAh, right.10:34
* wgrant isn't quite sure who is what.10:34
stubThe closest I can get is 'drinking from the same toilet'.10:35
bigjoolslaying the same cable10:35
mrevell:)10:36
wgrantHeh.10:36
gmbwgrant: So, I suck at reading regexes. Resubmitting again. Should work this time.10:37
wgrantgmb: Thanks.10:41
deryckgood morning, all.10:51
wgrantMorning deryck.10:52
bigjoolshi deryck10:53
jtvjml: did you get word yesterday about the mysterious lingering branch jobs?11:42
=== beuno_ is now known as beuno
=== al-maisan_ is now known as al-maisan
=== salgado-afk is now known as salgado
wgrantgmb: I presume it didn't?13:04
wgrantOr is PQM even slower than I thought?13:04
BjornTwgrant: pqm is processing a lazr.restful branch, which means that it runs the full test suite13:06
wgrantBjornT: Ah.13:07
=== kiko-afk is now known as kiko
=== matsubara-afk is now known as matsubara
barrybac: ping13:41
bacgood morning barry13:41
barrybac: good morning!  i have a question for you regarding private teams13:42
bacok13:42
barryif i'm an admin for a private team, but not an owner, it appears as if i cannot make other members admins13:42
barrybac: i'm not sure of the exact combination of PMT/private, owner/admin, etc13:42
barrybac: is this a bug or a feature?13:43
bacbarry: that is true of all teams.  even on public teams only the owner can beknight others13:43
bacbarry: i think it is a (questionable) design decision13:43
barrybac: i guess when i've done this before i've been the owner too13:43
barrybac: agreed13:43
bacyeah, i was surprised when i first discovered that behavior13:44
barrybac: thanks.  i'm going to file a bug on this, unless you know there's already one open13:44
bacbarry: should be a super easy fix.  i don't know if there is a bug yet.  it's worth a discussion on the list, though, to ensure there is no reason for why it is so.13:45
barrybac: cool, thanks13:45
gary_posterintellectronica: I saw you tried to land the lazr.restful thing on pqm last night.  I got a bunch of librarian-related failures on mine that seem verrry unlikely to be caused by my change (a two line patch that casts a token from unicode to str and passes on ec2test).  Did yours succeed?13:56
intellectronicagary_poster: yeah, my patch landed13:58
gary_posterintellectronica: huh.  ok, I'll just try again, I guess.  I have a branch I'm working on now to switch lazr.* out of sourcecode/pqm land, but canonical-identity-provider and shipit will be pqm forever atm. :-/  thanks14:00
intellectronicagary_poster: oh cool, does that mean that we'll converge on a single restful trunk which will be included using buildout?14:01
gary_posterintellectronica: yes14:01
intellectronicaexcellent!14:01
deryckEdwinGrubbs, ping14:20
EdwinGrubbsderyck: pong14:20
=== carlos_ is now known as carlos
sinzuiWhy wasn't edge update?14:52
danilossinzui: hi there, I have a case where object doesn't have canonical_url defined (and it shouldn't), but there are subpages on it14:54
sinzui??14:54
danilossinzui: that totally breaks with new templates with something like "NoCanonicalUrl: No url for <Translator at 0x64dfb90> because <Translator at 0x64dfb90> broke the chain."14:54
sinzuidanilos: what breaks? The code that makes the branding?14:55
sinzuiyes, I bet that is it14:55
danilossinzui: yeah, or perhaps breadcrumbs (I'd suspect breadcrumbs)14:55
danilosif there are breadcrumbs :)14:56
sinzuidanilos: the breadcrumb code is from 2.014:56
barryreviewers (and lurkers) -> #launchpad-meeting in 4m14:56
sinzuidanilos: The branching searches (traverses) to IHasLogo14:56
danilossinzui: it might come as a surprise then that this page was never migrated to 2.0 either (I am actually trying to use generic-edit.pt for the form)14:57
sinzuidanilos: Send an email to thumper. He is creating an alternate way to get branding...IRootContext. I think his solution will fix your problem14:57
danilossinzui: right, it does fail in IHasLogo, will do that14:58
barryreviewers (and lurkers) -> #launchpad-meeting15:00
flacosteChex: hi there! could you delete the following vcs-import when you have time: https://code.edge.launchpad.net/~vcs-imports/windmill/trunk ?15:00
flacosteChex: nevermind, it seems i have permission to do so15:01
sinzuidanilos: thanks for bring this up. your use case is better justification than the ones I was thinking of15:01
danilossinzui: sure, thanks15:01
Chexflacoste: ok, no problem :)15:02
barrybeuno: do you want to join our reviewer's meeting?15:08
beunoflacoste, http://morgamic.com/2009/08/18/optimizing-your-js-and-css/15:16
flacostebeuno: tell me something i don't already know :-)15:17
beunoflacoste, this is my attempt to keep the CSS minifying on the table, rather than informing!  :)15:17
james_wdid edge rollout this morning?15:18
james_wsomething seems to have happened at ~08:4415:18
flacostejames_w: i think there was an edge server that didn't updated properly15:19
flacostejames_w: btw, we should be upgrading to HAProxy soon for load balancing, that should really makes thing better for you15:19
flacosteas it catches when backend server are not available15:19
flacostejames_w: https://wiki.canonical.com/IncidentReports/2009-08-19-launchpad-edge-fail/15:20
james_wthat might be related15:20
james_wI'm still seeing issues though15:20
james_wnot described there15:20
flacostejames_w: what issue?15:21
james_whmm, might have *just* gone away15:21
james_wbug 41594315:21
mupBug #415943: branch.lp_save() often give PreconditionFailed <Launchpad Bazaar Integration:New> <https://launchpad.net/bugs/415943>15:21
james_wnope, still there15:21
flacosteleonardr: could you help out james_w in diagnosing the source of bug 415943?15:22
mupBug #415943: branch.lp_save() often give PreconditionFailed <Launchpad Bazaar Integration:New> <https://launchpad.net/bugs/415943>15:22
leonardrflacoste, sure15:22
flacostethanks15:22
=== henninge_ is now known as henninge
james_wah, a little more insight I think15:23
james_wso something changed this morning that means lp_save() on a branch will now fail if you didn't change anything15:25
james_wbut before it worked whether you changed it or not15:25
leonardrjames_w: the first step in diagnosis is to set httplib2.debuglevel = 1 before creating the Launchpad object15:26
leonardrthis will give you dumps of the http requests/responses15:26
leonardrwe're especially interested in the http headers ETag, Last-Modified, If-Modified-Since, and If-None-Match15:26
leonardrsince those are the ones that determine whether the server will give you Precondition Failed15:27
james_whttp://paste.ubuntu.com/255765/15:28
leonardryou commented on bug 336866. that bug was caused by an interaction between an ObjectModifiedEvent and the unmarshalled field cache15:29
mupBug #336866: When adding tag or updating description, lp_save() gives "HTTP Error 412: Precondition Failed" <lazr.restful:Fix Committed by leonardr> <python-launchpadlib (Ubuntu):Invalid> <https://launchpad.net/bugs/336866>15:29
leonardri backported a fix to the lazr.restful branch used by launchpad, but apparently launchpad didn't pick it up, because people are still having that problem15:29
leonardrare there any interesting ObjectModifiedEvents triggered when save() is called on a branch object?15:29
james_wI think my comment on that bug was mistaken15:30
james_wI think when I was getting this before the errors were legitimate, as scanning updates the last_scanned entry in the branch or something15:30
james_wand that would happen shortly after pushing, around the time I was setting the status15:30
james_wI implemented retry support to handle that15:31
james_wbut this morning the retries don't help15:31
james_wfurther to the paste above, retrieving the object again gives the same ETag: 7bdbf8234351ddfa1c58adf96ab423eb41ab8f6e15:31
leonardrthanks, i was just about to ask that15:31
james_wso something fishy is going on15:31
leonardrjames_w, can you reproduce this in your local launchpad installation?15:33
james_wI haven't tried15:33
abentleysinzui: It seems like account creation refuses to create accounts for email addresses used by SSO, etc, but password recovery only works for Launchpad accounts.  Is that possible?  example address: paul.szwajkiewicz@wp.pl15:33
sinzuisalgado: ^15:34
leonardrjames_w: please give it a try, as the only ways to debug it at this point are by backtraces in the code or manual examination of the code15:34
leonardron the http level everything looks like it should be working15:34
bigjoolssinzui: where is PillarView tested?15:34
sinzuiabentley: I believe this /was/ true, but salgado fixed it15:34
james_wleonardr: yeah, that's why I'm asking if edge rolled out today, that would narrow it down15:35
salgadoabentley, password recovery on login.launchpad.net should work for SSO accounts15:35
james_wI'll try and get launchpad.dev fired up15:35
sinzuilp/registry/browser/tests/pillar-views.txt15:35
abentleysinzui: It seems to not be fixed as of r912915:35
intellectronicaadeuring: gary_poster mentioned something about failures related to the librarian he had trying to land branches15:35
adeuringintellectronica: thanks!15:36
abentleysinzui, salgado: Try the example address I gave on edge.15:36
bigjoolssinzui: thanks, grep was not my friend15:36
abentleysinzui, salgado: paul.szwajkiewicz@wp.pl15:36
gary_posteradeuring, intellectronica: yes, I don't see the background in history, but I got a *lot* of librarian failures on pqm15:36
salgadoabentley, if that email is of an SSO account, then it can't use edge.launchpad.net15:36
gary_posteradeuring: I just retried, since intellectronica had success15:36
adeuringgary_poster: OK, I'll try that15:37
abentleysalgado: Just tested on prod, and it also doesn't work there.15:37
salgadoabentley, prod shouldn't work either15:38
salgadoonly login.lp.net should work15:38
abentleysalgado: !?15:38
salgadoabentley, this is not a launchpad account -- it's an SSO one15:38
abentleysalgado: A user tried to create an LP account and was told they couldn't, because the address was already in use.  So they tried to recover their password, and they couldn't, because it wasn't a Launchpad account.15:39
salgadoabentley, as I said earlier, they can reset the password on login.launchpad.net.  once that's done they can use the new password to log into launchpad.net15:40
abentleysalgado: I think that we should make that much easier for users, potentially by letting them recover an SSO password from launchpad.15:41
abentleysalgado: There is nothing to indicate to the user that they need to do this.15:43
salgadoabentley, agreed, but when we prevent the user from registering we say that they can use the SSO credentials to login15:45
salgado(agreed about making it easier, I mean)15:45
abentleysalgado: But we don't say how to recover the SSO credentials, so that's not really enough.15:45
abentleysalgado: Is the launchpad.net password recovery a subset of the login.launchpad.net password recovery?  If so, I think it would be sensible to always use the login.launchpad.net password recovery.15:49
salgadoit's not15:49
salgadoabentley, ^15:49
abentleysalgado: What are you pointing me to?15:50
salgadothe line above, where I said it's not a subset15:50
abentleysalgado: Okay, in that case it would be great if we could add "If you have forgotten your password, use login.launchpad.net (not this page) to recover it."15:53
rockstarbarry, I think you forgot that we decided I'd attend the AsiaPac reviewer meetings now.15:53
abentleysalgado: To the specific error.15:53
barryrockstar: right!15:54
=== Ursinha is now known as Ursinha-food
salgadoabentley, agreed, can you file a bug about that?16:01
gmbI'm sick of IRC clients now. Can we please go back to carrier pigeons?16:01
* gmb goes to find a cup of tea16:02
=== gmb is now known as gmb-afk
abentleygmb: Actually, I'm using a Pidgin right now :-)16:02
=== gmb-afk is now known as gmb
rockstarabentley, boo.  :)16:02
gmbArgh. Didn't want to change my nick. Damn thing...16:02
james_wleonardr: I can't seem to reproduce with the latest devel16:02
=== jtv is now known as jtv-night
leonardraaargh16:03
leonardrjames_w: what about my earlier question about ObjectModifiedEvents?16:04
leonardrthat's almost certianly not the problem because you'd have it reliably16:04
james_w"<leonardr> are there any interesting ObjectModifiedEvents triggered when save() is called on a branch object?" ?16:07
leonardryes. more generally, does anything unusual at all happen when you save a branch, that doesn't happen for other objects?16:08
james_wI assumed you were asking your fellow LP devs, I don't know the answer, sorry16:08
leonardroh, i see16:08
james_wI've just updated the bug16:08
leonardrrockstar, maybe you can help?16:08
james_wlp.me.lp_save() also gives the error16:08
maxbflacoste: New python-apt available in ~maxb/launchpad for syncing to ~launchpad/ppa (in response to new version in karmic primary)16:14
flacostemaxb: great, thanks! i'll copy over16:14
flacostedone16:15
rockstarleonardr, james_w, we haven't gone out of way to do anything special on save through the API.  What's the actual issue?16:16
leonardrrockstar: james_w gets a 412 Precondition Failed every time he saves a branch object16:16
leonardrapparently this just started happening recently16:16
rockstarHm, does it say what the precondition is, or give an oops?16:17
leonardrrockstar: well, the precondition is almost certainly an etag failure16:17
leonardrmeaning the server-side calculated etag doesn't match what he sent16:17
* rockstar hasn't gotten that far in the Rest book yet...16:17
james_w{'status': '412', 'content-length': '0', 'via': '1.1 wildcard.edge.launchpad.net', 'x-powered-by': 'Zope (www.zope.org), Python (www.python.org)', 'vary': 'Cookie,Authorization,Accept', 'server': 'zope.server.http (HTTP)', 'x-content-type-warning': 'guessed from content', 'date': 'Wed, 19 Aug 2009 15:05:22 GMT', 'content-type': 'text/plain'}16:17
leonardrbut when he GETs the object again immediately after the failure, it still has the same etag16:17
rockstarSo the etag is kinda like a hash then?16:18
jtv-nightmrevell: just watched the screencast... Love it!  The only thing missing is that the screen that says "The Next Day" should be while lettering on a scratchy and wobbly black background, bordered in Art Nouveau style, and accompanied by piano music.16:18
jtv-nightwhite.  White lettering.16:18
mrevelljtv-night: :-D16:18
mrevellthanks jtv-night16:19
jtv-night:)16:19
leonardrrockstar: yes16:19
leonardrit's calculated from the current values of all the object's non-read-only fields16:19
rockstarjames_w, do you have a script I can test?16:19
leonardrrockster: he put a really simple on in the bug16:19
james_wlp.me.lp_save()16:19
james_wor yeah, see the bug16:20
leonardr<https://launchpad.net/bugs/415943>16:20
mupBug #415943: lp_save now gives PreconditionFailed if unchanged <Launchpad Foundations:New> <https://launchpad.net/bugs/415943>16:20
rockstarjames_w, where's the bug?16:20
leonardrjames_w: you're getting it on lp.me?!?!16:20
james_wyeah, I said that 10 minutes ago! :-)16:20
leonardri must have missed it in the confusion16:21
leonardrok, so it's a thoroughly general problem16:21
leonardrand since it only shows up in production i think it might have something to do with an intermediary16:21
leonardrsuch as a cache16:21
leonardrrockstar: nm, it isn't a problem with branches per se16:21
rockstarSo I'm off the hook then.16:22
rockstarYay!16:22
leonardrjames_w: give me a minute to get a branch into review and then i'll pay more attention to this16:23
james_wthanks16:23
salgadosinzui, how much time should I spend trying to improve https://devpad.canonical.com/~salgado/poll-shots/poll-30.png?16:33
=== beuno is now known as beuno-lunch
=== matsubara is now known as matsubara-lunch
sinzuisalgado: Did we commit to redesigning that page?16:40
* sinzui looks16:40
salgadosinzui, I hope not.  where is the list of pages that we committed to redesign?16:41
sinzuisalgado: I would not spend more than 1h cleaning the presentation.16:42
salgadook16:44
=== salgado is now known as salgado-lunch
gary_posteryo barry.  We didn't talk about transferring the wiki stuff that I saw in the reviewers mtg.  that should be a reviewers mtg action item for next week, and we ought to coordinate.  Maybe coordination should just be as simple as pinging the other person whenever we start doing a bit of it, so we don't bump into each other17:07
leonardrjames_w: i can't duplicate your problem with launchpad.me.lp_save(), either on staging or edge17:08
james_wneither can I now :-/17:09
leonardrnor with your original load() code17:10
leonardrjames_w: are you willing to come back to this if/when it recurs?17:11
leonardri think the problem may have been some transient problem with the cache17:12
james_wI'll be back, don't worry17:12
james_wit's rather unsatisfying though17:12
leonardragreed17:13
james_wthe last failure I have is slightly before 17:0017:13
kfogeldanilos: http://paste.ubuntu.com/255805/   :-)17:15
kfogelNote the huge block under wgrant's name.17:15
daniloskfogel: yeah, looks great :)17:16
=== bigjools is now known as bigjools-afk
leonardrjames_w: when it happens again we should probably get the losas involved, because a problem with this profile is almost certainly being caused by an intermediary17:16
leonardrsince the http looks fine17:16
james_wsomething dropping Etag in the response perhaps?17:17
leonardrjames_w: if something were modifying the ETag on the request before launchpad saw it, launchpad would say "this doesn't match" and give a 41217:18
leonardri know that apache plugins for things like content compression munge the etag on the response (in a way that defeats the purpose of etags)17:18
james_wyeah, that's what I meant17:18
james_wnothing like what I actually said, granted :-)17:18
leonardrbut i don't know of anything that would modify it on the request17:19
james_wdid anyone do anything 20 minutes ago?17:19
=== Ursinha-food is now known as Ursinha
james_wrestart servers, move a cache or anything?17:19
rockstarsinzui, I just noticed that question-add.pt is not in the zcml but in the view code.  Is there a reason for this?17:20
statikhi! does launchpad have a trademark policy? i'm making a project that stores bug data from launchpad into couchdb, and I was considering calling it "offpad", but I don't want to have any hassle over the name17:23
statikshort for "offline launchpad"17:23
rockstarkfogel, ^^17:23
leonardr<mthaddon> leonardr: I updated edge - the auto update failed overnight so we had servers on different versions, was just fixing that17:24
leonardrjames_w -^17:24
intellectronicastatik: you should call it lounge-pad17:24
kfogelstatik: Launchpad is trademarked by Canonical.17:25
james_wthanks leonardr, mthaddon17:25
kfogelstatik: I can ask internally about the "offpad" name if you want; my guess is the legal department would have no choice about enforcing there, but I'm not a lawyer, so can't be sure without asking.17:25
kfogelstatik: shall I?17:26
leonardrjames_w: <mthaddon> leonardr: edge was in an inconsistent state - two app servers on one revno and two app servers on another revno17:26
kfogelintellectronica: nice :-)17:26
james_wleonardr: could that have caused it?17:26
leonardrabsolutely17:26
leonardrthe etag incorporates the current revno17:26
james_wleonardr: if they were calculating etags from different sets of parameters17:26
james_woh17:26
* sinzui looks at what rockstar is seeing17:26
james_wwell, there we go then17:26
leonardrif GETs go to rev N and PATCHes go to rev N-1, you'll see exactly the behavior you describe17:27
rockstarsinzui, it looks like it's more about using the same view for two templates.17:27
sinzuirockstar: yes and SearchQuestionsView does the same I think17:28
rockstarsinzui, yeah.  I just found them when I was checking for templates I forgot to port.17:29
sinzuirockstar: you really should have been landing these small branches17:29
rockstarsinzui, well, I've divided them up into three branches.17:30
sinzuiyou wont conflict with anyone, so it is not a problem I think17:30
rockstar(One's in review currently, I'm fixing tests for the 2nd and third one now)17:30
=== matsubara-lunch is now known as matsubara
sinzuirockstar: is you change the workflow rules to allow the [Add comment] to always display, you will be a hero17:30
rockstarsinzui, I will do that in a separate branch, but I think that's how it should be.17:31
sinzuirockstar: while the fix to canAddComment() is just a test self.user is not None, I believe test_question_workflow will be angry.17:32
sinzuiwell. I can know the answer to that right now17:33
rockstarsinzui, well, of course the test workflow test would fail, since you're changing the workflow.17:33
rockstarIf it didn't, I would be afraid.17:34
sinzuirockstar: it does not! The comment is designed to not influence the workflow. I was certain the test verified it the non-event could not happen until after the bug is solved or invalid17:36
* sinzui sees he ran only the unittest17:37
* sinzui boggles and to success17:38
sinzuirockstar: I'll subscribe you to the bug and the change I made. I think I am doing something wrong because the tests I expected to fail did not17:38
rockstarsinzui, huh.  Okay, I'll make sure that the workflow test actually tests the workflow then.17:40
statikkfogel, thanks. I like intellectronicas suggestion of loungepad even better. when you say "would have no choice about enforcing", do you mean that you think the name is too similar, or not similar enough to worry about?17:40
sinzuirockstar: they do...comments are meant to outside the workflow. I thought there was verification that the comment button does not appear when the question is OPEN, ANSWERED , or NEEDSINFO.17:41
kfogelstatik: well, they'll have to determine that.  What I mean is that trademark law is funny in that if you let the name get diluted too much, you lose the trademark by default.17:41
kfogelstatik: let me ask them; I'll CC you.17:42
statikkfogel, thanks!17:42
rockstarsinzui, ah, you and I were thinking about different views.  Now I understand.17:42
rockstarkfogel, random question: Does that mean "Kleenex" is no longer a trademark, since we use it when we mean "tissue" ?17:44
kfogelrockstar: Kleenex polices it as best they can, but it's a constant danger.  Try marketing a product using that name and see how fast you get a phone call :-).17:46
kfogelstatik: sent17:46
statikwikkid17:47
=== beuno-lunch is now known as beuno
leonardrflacoste, grant_w, i've marked bug 415943 invalid with an explanation17:47
mupBug #415943: lp_save now gives PreconditionFailed if unchanged <Launchpad Foundations:Invalid> <https://launchpad.net/bugs/415943>17:47
=== abentley is now known as abentley-lunch
intellectronicastatik: is that a funky misspelling of 'wicked', or the past tense of a novel verb meaning 'to edit a wiki page'?17:50
statikintellectronica, with me it's always funky misspelling, i don't even know what a tense is17:51
statiki'm pretty sure i know what verbs are and i don't like them one bit17:51
intellectronicayou seem very tense17:51
statikit's living in this teepee that does it17:52
statiki want to trade it in for a yurt17:52
rockstarstatik, I want whatever you're on.17:56
rockstar(Unless it's the pink pants, then I'd prefer to get my own.)17:57
=== gary_poster is now known as gary-lunch
barrysinzui: eta for bug 413158 follow up review?18:01
mupBug #413158: Convert /people page to UI 3.0 <ui> <Launchpad Registry:In Progress by barry> <https://launchpad.net/bugs/413158>18:01
sinzuibarry: I am sorry. I am still writing emails18:02
barrysinzui: no worries18:02
intellectronicarockstar: it's a competition. we're trying to see who can fail the turing most elegantly18:03
intellectronicathe winner gets to be canonical's submission for the next loebner prize18:03
=== EdwinGrubbs is now known as Edwin-lunch
mrevellsee you tomorrow guys18:07
=== salgado-lunch is now known as salgado
* gmb -> dinner, etc. Back later.18:11
beunobarry, how's our "projects use launchpad by default" plan going?18:20
beunoabentley-lunch, I hate the changes done to reviewing in MPs18:22
beunocan we talk at some point about them?18:22
beunoI no longer have a "review" button close to the reviewers list18:22
beunoand now ahve to scroll down to the bottom of all the comments18:22
beunoplease lets not do these changes without some broader agreement18:24
barrybeuno: on hold for 3.1 ui conversions18:24
beunobarry, roger, thanks18:24
beunoflacoste, I love you for using google calendar18:34
flacostebeuno: :-)18:39
salgadosinzui, beuno, is there any reason why style-3.0.css defines font-weight:bold for <dt>s only when they're inside a portlet?18:41
salgado.portlet dt {18:41
salgado    font-weight: bold;18:41
salgado    }18:41
sinzuisalgado: I did not want to presume18:42
sinzuisalgado: bold might be right for all cases since we expect that by default18:42
salgadoI used a <dt> in a page and wanted it to be bold as well, but it doesn't get that automatically because it's not inside a class="portlet"18:42
sinzuisalgado: the same may also be true for <th>18:42
salgadoindeed18:42
sinzuisalgado: I think you should make the change. There are very few uses of <dt> out side of 3.0 pages, and we can fix them if we discover an issue18:43
salgadosinzui, cool, I'll do that18:44
beunoagreed18:44
=== gary-lunch is now known as gary_poster
barrybeuno: so i'm now using a generic action menu for the top level overview pages.  on /people it makes sense to have an action for +requestmerge.  it probably don't make sense to put that on the /projects page, but... does it hurt?  of course it's more work to selectively remove it, but i can do that if you want19:13
barrybeuno: similarly for the admin tasks, which make sense on /people but maybe not on /projects.  otoh, maybe these are useful conveniences anyway, and maybe consistency on the top level collections is more important.  thoughts?19:15
beunobarry, I don't think we should have people merging on /projects19:15
beunoso, keep the relevant links on the relevant pages19:16
barrybeuno: right, agreed. actually, it should only be a minor refactor, but i'll do that in the /projects branch instead of the one sinzui is reviewing currently19:17
barrybeuno: thanks19:17
beunocool19:17
* barry thanks abentley for looms once again19:17
beunointellectronica, how about pasting the number of converted and unconverted templates in the weekly emails?19:18
salgadobeuno, before: https://devpad.canonical.com/~salgado/poll-shots/poll.png19:23
salgadoafter: https://devpad.canonical.com/~salgado/poll-shots/poll-30.png19:23
salgadoui=you? ;)19:23
* beuno looks19:23
beunosalgado, almost19:24
beunoit has 2 titles19:24
salgadowhere?19:25
beunoand, I don't understand the "Your current vote" and "Vote now" headings19:25
salgadowrong screenshots19:25
beunosalgado, "a public poll that never closes" and "Vote"19:25
salgadodamm19:25
beuno:)19:25
salgadohttps://devpad.canonical.com/~salgado/poll-shots/index.png19:26
salgadohttps://devpad.canonical.com/~salgado/poll-shots/index-30.png19:26
=== abentley-lunch is now known as abentley
salgadobeuno, those (^) are the correct ones19:26
beunosalgado, MUCH better19:27
beunono h2?19:27
beuno"A public pole.." should be an H2, no?19:27
beunoalso19:27
beunocahnge details should be in the actions portlets19:27
beunoand maybe19:27
beunoopens and closes19:28
salgado<h2>A public poll that has not opened yet</h2>19:28
beunoshould be beneath eachother19:28
beunoah19:28
beunoI meant H119:28
beunoh2 is the projects' name19:28
beunowhich is correct19:28
beunothere's always an H2 and an H119:28
salgadobeuno, do you really think it's worth moving the 'Change details' to a side portlet even if it's going to be alone there and take a good 20% of real estate?19:30
salgadothe page will never have any side portlets or anything19:30
beunosalgado, yes19:30
beunoconsistency19:31
salgadobeuno, what should be in the H1?19:31
beunoand, we don't need that much space on that page19:31
beunosalgado, the H1 is "A public poll that has not opened yet", which I assume is the polls' name19:31
salgadoright19:31
salgadoso just turn the existing h2 into an h1?19:32
beunoyeap19:32
beunosalgado, and, this may be too much design on the conversion19:34
beunobut19:34
beunoyou could isntead of having an "active" column19:34
beunojust say "Active" or "Inactive"19:34
beunobut that's just for the bonus points  :)19:34
salgadoright, right, I'll think about that19:36
salgadobeuno, should the +newoption link be in the side menu as well?19:36
salgadoor just in the main area?19:36
beunosalgado, no, I think that's the right place to put it19:37
salgadook, now I need to find out how to achieve that19:38
abentleybeuno: You reviewed that as Needs Fixing, I replied, you never responded, eventually I merged it.  https://code.edge.launchpad.net/~abentley/launchpad/comment-as-review/+merge/768519:38
beunoabentley, was the wrong thing to do19:39
abentleybeuno: I thought you were making non-madatory suggestions.19:40
beunoabentley, it says "needs fixing"19:40
beunoabentley, please revert19:40
salgadobeuno, that's not easy to achieve. is it a problem if I leave the +newoption link both in the main area and side menu for now?19:41
intellectronicabeuno: that's a good idea. i'll do that in next week's report19:41
abentleybeuno: Needs fixing was intended as the equivalent of BB tweak.19:41
barrybeuno: how would you like to do a quick review of some screenshots?19:41
intellectronicabeuno: a while back you mentioned that we may have licenses to use balsamiq. is that still on? what do i need to do to get one?19:41
beunointellectronica, I will forward it to you19:42
thumperabentley: actually for the equivalent of BB tweak we tend to use Approve with comments19:42
intellectronicabeuno: awesome, thanks19:42
thumperabentley: need-fixing I consider blocking19:42
beunome too19:42
abentleythumper, beuno: Okay, but "resubmit" is meant to be the blocking one.19:43
thumperabentley: needs-fixing means that you need to fix it :)19:43
beunobarry, sure, hit me, I'll put it on the queue19:43
barrybeuno: awesome, there's three, should be self evident...19:44
barryhttps://devpad.canonical.com/~barry/projects-anon.png19:44
barryhttps://devpad.canonical.com/~barry/projects-search.png19:44
barryhttps://devpad.canonical.com/~barry/projects-user.png19:44
barrybeuno: ^^19:44
abentleythumper: Well, I suggested calling it "tweak" :-)19:45
thumperanyway...19:45
beunoabentley, setting aside this issue, which we need to clear up, please revert the cahnge19:45
beunochange19:45
thumperabentley: what is the issue19:45
thumperbeuno: what is the issue here19:45
beunothumper, the approach os wrong on the UI19:46
beunofor that MP19:46
beunos/os/is19:46
beunoand19:46
beunonow, to review something you haven't been requested, you need to scroll down in bewtween commetns and the diff19:46
beuno*very* hard19:46
beunoI don't agree with merging in comments and reviews19:47
thumpersurely if you are going to review, you are going to read the comments?#19:47
beunothey are not the same thing19:47
beunothumper, I am not19:47
abentleybeuno: That is why, in my mp-tweakage branch, I move the add comment or review button up.19:47
thumperbeuno: *everyone* else does19:47
beunoI don't care about the code, I do UI reviews19:47
beunoand19:47
beunoI may ahve read them already19:47
beunovie email19:47
beunoor last time I was on that page19:47
beunoit VERY HARD to find that link19:47
abentleybeuno: I would like to improve the situation, not go back to status quo.19:48
beunoand, review and commenting are separate things19:48
beunoabentley, me too19:48
thumperbeuno: no, they are not19:48
beunothumper, yes they are19:48
beunoI've thought about this, discussed this with other people using the system19:48
beunoit's consistent19:48
abentleybeuno: They are not.  Even you've said you don't know whether it's a comment or review until you're partway through.19:48
beunoI've discussed with kiko as well19:49
beunoreviews and comments are not the same19:49
beunothey are not the same anywhere else19:49
beunoand19:49
beunothis branch makes things worst19:49
beunoplease revert it19:49
beunocommenting is a lightweight well-known operation19:50
beunoreviewing is not19:50
beunocramming them together beacuse they make sense to *you* is the wrong thing to do19:51
beunoit's why I did not approve the branch19:51
beunoand the change, besides that issue, made commetning *and* reviewing harder now19:51
abentleybeuno: You abandoned that review.19:51
abentleybeuno: It's not like you disapproved.19:52
beunoabentley, yes, at "needs fixing". You should follow up, not merge it.19:52
beunoabentley, I will be more blunt in the future then19:52
thumperbeuno: with due respect, he tried19:52
abentleybeuno: I did follow it up.19:52
beunoyou did not address the concerns19:53
beunoand landed it19:53
beunoonly following up on one bit, and landing, is not exactly following up19:54
abentleyI followed up on the specific issue that you're complaining about now.19:55
beuno"I'm glad we've re-introduced reviewing from comments, but I feel that there's no point in removing it from the table. We can have it in both places, leaving the option in the obvious place."19:56
beunoI mentioned on IRC19:56
beunothat the complaints where not about that19:56
beuno"If you don't select a value for "Reviewer says", then it's a comment.  If you select a value, it's a review."19:57
beunohow are users suppose to guess that?19:57
beunoevery other review I've done, as long as the status is "needs fixing", it needs fixing19:57
abentleybeuno: Well, we could improve the labels.19:59
abentleybeuno: anyhow, I will revert the change.19:59
beunobarry, I wonder if we want all thos info icons20:02
beunobarry, also, coloring the "7 bugs reported, 3 have tran.." would rock20:03
abentleybeuno: At the time, you said "I'm glad we've re-introduced reviewing from comments...".  Now you seem to be saying the opposite.20:03
beunobarry, other than that, it looks nice20:03
beunoabentley, yes. Not so happy that we loose the (perceived) ability to comment because of it20:04
beunocommenting and reviews rock20:04
beunobut why do we have to kill commenting because of it?20:04
abentleybeuno: I don't think we do.20:05
beunoright, me neither20:05
beunoor, reviewing from where the reviews are20:06
beunoso the problem with the branch as that it introduced other orthognal UI changes20:06
abentleybeuno: They are not orthagonal, they are related.20:07
beunorelated, but not needed as part of "add comments to reviews"20:08
beunoadding comments to reviews:  awesome20:08
beunoremoving the link from the reviews table, and moving the review link to a hard-to-fine place: bad20:09
abentleyThis branch was about adding the ability to review from a comment.20:09
beunothat was what we've been talking about on the MP and on IRC20:09
beunoright, inver the awesome phrase20:10
beunoit needs more thought on how to do it20:10
abentleybeuno: I have been trying to put the link in an easy to find place, and the branch is stalled, waiting for your reply, since Aug 4.20:12
beunook, so you can either prod me on IRC to remind me, or land it20:13
beunoI'm upset because I pointed out, especially on IRC that this was a regression, and you picked the latter20:13
beunoI'm sorry I stalled on getting back to you20:13
=== danilos is now known as danilo-afk
=== Edwin-lunch is now known as EdwinGrubbs
abentleybeuno: You understand that the branch which is currently stalled is not the one I landed?20:14
beunoabentley, I do not20:14
beunothe MP I'm looking at is merged20:15
abentleybeuno: The mp-tweakage branch is the one where I move the link right into the review table: https://code.edge.launchpad.net/~abentley/launchpad/mp-tweakage/+merge/947520:15
barrybeuno: yeah, i'm not sure what to do about the info icons.  i think on the whole i like them, otherwise we should also remove the add and edit icons, or it'll look weird20:15
beunobarry, well, one is a link, and the other is an action20:16
beunonot sure20:16
barrybeuno: actually, i don't think it will be easy to remove the icons because i'm using "structure view/@@+global-actions" and "structure context/@@+related-pages"20:17
barrybeuno: so all that rendering "just happens"20:17
beunobarry, it's not a super-popular page20:17
barrybeuno: oh, but maybe i can remove them in the menu code20:17
beunoso if it's going to take a lot of time, it's fine20:17
barrybeuno: let me mock it up and take a screenshot.  if it takes me more than 90 seconds i'll leave it :)20:17
barrybeuno: as for coloring, i removed the colored numbers from the original template because /people doesn't color its stat numbers.  i'd like for them to be consistent, so... what color would you like them to be?! :)20:18
beunoabentley, so you removed the link next to the reviewers table, and that branch, among other things, adds it back in a different form?20:18
beunobarry, see https://edge.launchpad.net/bzr/+milestone/2.020:18
abentleybeuno: It moves the existing "add comment or review link".  The difference is that it does not have the greyed-out review link for yourself, which was a cause of confusion and complaint.20:19
beunobarry, specifically,  0 blueprints  and 27 bugs  targeted20:19
barrybeuno: ah, app colored20:20
barrybeuno: i think i can do that20:20
beunobarry, cool, other than that, I can smell it landing today20:20
barrybeuno: it's dependent on the big branch sinzui's reviewing, so that has to land first, but yes!20:21
barrybeuno: https://devpad.canonical.com/~barry/projects-noicon.png20:21
beunoabentley, ok. So, add a link to review/comment back on the reviewers table, and we'll go from there20:22
barrybeuno: as an aside, the column headings on https://edge.launchpad.net/bzr/+milestone/2.0 is there a policy on the heading text color?  i know bugs are red and code is gray, but what about top level collections?  the one i did for people i just left the default text color20:23
beunobarry, registry is black20:23
barrybeuno: a musician like me can get behind that20:24
sinzuiRegistry is the *new* black20:24
beunohehe20:24
barry:-D20:25
abentleybeuno: Okay.  I'll extract that change from the mp-tweakage branch into a separate branch and post it for review.  Have I understood you correctly?20:25
barrybeuno: so, icons or no icons?20:25
beunoabentley, yes. And will try and work on a mockup for MPs like I did for the branch index, so we can discuss around something easy to change20:25
beunobarry, can I see no icons cheaply?20:26
abentleybeuno: Roger wilco.20:26
barrybeuno: https://devpad.canonical.com/~barry/projects-noicon.png20:26
beunobarry, no icons!20:26
beunoand20:26
beunomaybe20:26
beunojsut maybe20:26
beunodrop the word "View"?20:26
barrybeuno: mockup on its way...20:27
barrybeuno: https://devpad.canonical.com/~barry/projects-succinct.png20:30
beunobarry, what do you think?20:30
barrybeuno: i don't like all the whitespace to the right of the words20:30
barrybeuno: but i think that's hardcoded in the portlet templates20:31
beunobarry, whitespace is like air20:31
barrybeuno: so i'd probably keep either the icons or the View...20:31
beunoyou need reasonable amounts of it20:31
beunobarry, I super like this20:31
beuno:)20:31
barrybeuno: you da man.  we'll go with this then!20:31
beunoit's easy to scan20:31
barrybeuno: only thing i'd change is s/People/Peeeeeeeeeople/  :)20:32
beunobarry, I will look the other way if you do  ;)20:32
beunobrb20:32
beunofsck needs me20:32
barry:-D  thanks beuno20:32
rockstarabentley, how do I diff against the lower pipe again?20:39
rockstarEr, s/lower/previous/20:39
abentleyrockstar: bzr diff -r branch::prev20:39
rockstarAh, okay.20:39
barrybeuno, sinzui you know what would be helpful?  if style-3.0.css had a list of app colors like it does for font-size percentages20:40
rockstarbarry, fwiw, I agree.  In my personal projects, that's usually the first thing after reset I put in the css file.20:41
sinzuibarry: If only I knew what those colours were20:41
sinzuibarry: I am not convinced there is just one colour for each app either20:41
barryrockstar: yep!  sinzui dang20:41
sinzuibarry: To start, someone could record the <h2> colours used in style.css as a comment in style-3.0.css20:42
barrysinzui: i think i will steal them from the milestone page to start with and i'll document them in this branch i'm working on20:43
sinzuibarry: secondly the app is a class of the body so20:44
sinzuibody.bugs h2, body.bugs th {color: #89abcd;}20:44
sinzuibarry: the milestone page only shows two colours20:44
barrysinzui: it shows blueprints in the blueprint color and bugs in the bugs color20:45
barryblueprint color: #3594BB20:45
barryor rgb(53,148,187)20:45
sinzuibarry: yes, I stole them from the h2 declarations in the css20:45
barrysinzui: perfect.  cargo cult ftw20:46
sinzuikeep the rgb() out of the CSS. I think in hex, not that Windows nonsense.20:46
rockstarsinzui, https://pastebin.canonical.com/21332/  I didn't change anything here, so I'm not sure why it's failing.20:46
barryit's already in the old code, but yes agreed20:47
rockstarsinzui, what I'm wondering is "Does this really matter?"  and "Can I change the test?"20:47
sinzuirockstar: could this be a merge screw up from changes made to projectgroups that landed last Friday?20:48
rockstarsinzui, possibly.  Lemme merge from trunk and find out.20:48
sinzuirockstar: Sorry, you cannot. It is not possibly to ask a question in a project (I think that is wrong). The title and the heading should indicate that the user must choose a project from the form....20:49
sinzuirockstar: I know20:49
sinzuirockstar: you added page_title to the view, but the view is used by two cases, IProject, and IQuestionTarget20:50
rockstarsinzui, okay.  Just as long as there's a real constraint.20:50
sinzuirockstar: So we have a choice. 'fuhgetaboutit', or add a condition to the property to change the title is IProject.providedBy(self.context)20:51
rockstarsinzui, well, the pagetitles.py was using view.pagetitle, so I just renamed it to view.page_title.  I didn't change the implementation.20:51
sinzuirockstar: questions often ignored pagetitles. We hated that file.20:52
rockstarsinzui, I'll take the former.  I just want to be making mechanical changes here.  I have just a few more tests failing, and there's light at the end of the tunnel.20:52
rockstar:)20:52
rockstarsinzui, _I_ hate that file. :)20:52
sinzuirockstar: many views implement page_heading or something like that that provides alternate titles20:52
* sinzui looks are view20:52
sinzuirockstar: look at ProjectAddQuestionView.pagetitle20:55
sinzuirockstar: That method can be renames to page_title to fix the failure20:55
rockstarsinzui, ah, thanks.20:56
rockstarsinzui, I have seen a few views in registry that might go better in answers.20:56
rockstarThat view is a good example.20:56
sinzuirockstar: Sorry. I always though I would be doing answers. I knew I was going to s/def pagetitle//def page_title/20:56
rockstarsinzui, actually, I quite like answers now that I know the various views.20:57
sinzuiIt predates LaunchpadView so it is a bit quirky, but it does teach you a lot about zope formlib20:58
bac sinzui: i'm stuck and need some help.  i'm trying to get an "(i) show all announcements" link on the announcements index page and cannot get it to work.20:59
bacsinzui: i've tried creating a Link( ) but cannot get it to format and render.  was looking at the top_contributors link used in product-index.21:01
sinzuibac: did you add the link to an ApplicationMenu with the 'overview' facet so that you can do context/menu:overview/show_announcements21:06
sinzuibac: paste a diff21:07
bacsinzui: i did try that.  recall i want this to be different from the global-actions.  i'm stuck trying to have that set of links in the portlet and this other link in-line21:08
sinzuibac: links that are inline are in an ApplicationMenu. I think the menu and the link definition should be the same as product21:10
bacsinzui: ok, i think i need to basically make an AnnouncementEditApplicationMenu like AnnouncementEditNavigationMenu21:13
sinzuiNo21:13
sinzuiThat does not sound right21:13
sinzuibac I think you want21:14
sinzuiclass AnnoucementOverviewMenu(ApplicationMenu):21:14
sinzui    facet = 'overview'21:14
* sinzui now looks a code because he really does not know what he is typing.21:14
sinzuibac: I think ProductOverviewMenu is what you want to copy. It ieven has the announcements link in it21:15
sinzuiOh!21:16
sinzuibac: we can cheat21:16
rockstarabentley, can I stick a pipe between two pipes?  I have two existing pipes that I'd like to stick a pipe between and hack on.21:38
abentleyrockstar: Absolutely.  bzr add-pipe --before $SECOND or bzr add-pipe --after $FIRST21:39
rockstarabentley, this plugin is a godsend.21:40
abentleyrockstar: glad you like it.21:40
rockstarBut not a Cthulusend.  He probably wouldn't send us something so nice.  :)21:40
thumperflacoste: if you can do the call earlier, I may be able to fill and hour :)21:44
=== salgado is now known as salgado-afk
=== cprov is now known as cprov-afk
flacostethumper: ok, i'll let you know as soon as i hung up the phone22:07
thumperflacoste: don't suppose you are free yet22:20
* rockstar goes on a short walk22:21
=== JamalFanaian is now known as jamalta
flacostethumper: i am now22:30
barryholy crap.  pqm is 9 deep.  yay for week 3!  but wait, we're not rolling out 2.2.8, so i guess people are having fun with ui22:36
=== matsubara is now known as matsubara-afk
wgrantgmb: I see it landed. Thanks again!22:40
jamoneI'm trying to set up a launchpad server on Ubuntu 9.04, while following the official WIKI's guides I try to use bzr to get rocketfuel-setup and it fails. It appears the WIKI's address to the rocketfuel-setup script is wrong22:43
jamoneI manually browsed the src online and got rocketfuel-setup and it ran, but when it came time for it to download the rest of launchpad it failed also22:44
jamoneit gave this: Making local branch of Launchpad trunk, this may take a while...22:44
jamoneGot a 200 response when asking for multiple ranges, does your server at bazaar.launchpad.net:80 support range requests?22:44
jamonebzr: ERROR: http://bazaar.launchpad.net/~launchpad-pqm/launchpad/devel/.bzr/repository/packs/1d0252d21c3632af79515b5e8c497c15.pack is redirected to https://launchpad.net22:44
jamoneERROR: Unable to create local copy of Rocketfuel trunk22:44
wgrantjamone: I'd just try again. It's possible that the branch changed significantly on the server while you were downloading it.22:46
barrythumper, jml, abentley let's meet today, in 45m22:47
abentleybarry: I already attended a reviewer meeting today, and I have plans for this evening.22:47
barryabentley: coolio22:48
abentleybarry: perhaps you meant rockstar?  (I'm the one who plays flute :-P)22:49
jamoneI can try running the rocketfuel-setup script again, but I had the same issue when trying to get the rocketfuel-setup script the way the wiki said, and I tried that a bunch22:49
jamoneOk I just reran rocketfuel-setup and got this make: *** No rule to make target `install'.  Stop.22:51
jamoneERROR: Unable to install apache config appropriately22:51
wgrantspm: Ping?22:53
spmwgrant: heyo22:53
wgrantspm: I need a branch made private, apparently.22:53
rockstarbarry, I don't think we'll have jml today.22:58
barryrockstar: cool23:00
rockstarthumper, standup?23:02
thumperrockstar: yes, just finishing with flacoste23:02
=== Ursinha is now known as Ursinha-afk
barryrockstar: -> #launchpad-meeting23:32
beunothumper, I'm off to the supermarket. If I get back before my gf, maybe we can have a call?23:48
thumperbeuno: when do you think you'll be back?23:49
beunothumper, 30-40 minutes23:49
thumperbeuno: ok23:49
beunothumper, unless you want to call me on my mobile23:50
thumperbeuno: no23:50
beunoI'm off, but do so if you'd like, number is in the directory23:50
beunoaight23:50
thumpersinzui: how do I create a sprint?23:53
thumpersinzui: nm23:55
thumperoh clucking bell!!!23:56

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!