[00:22] <cprov-afk> wgrant: your doctests are good, but I wonder if it would be nicer if we could extract the code that locates the key file and unittest it.
[00:23] <wgrant> cprov-afk: A good idea.
[00:23]  * wgrant works out how to add unittests.
[00:23] <cprov-afk> wgrant: there is on slip when the key file is found via glob, its content is not escaped.
[00:24] <cprov-afk> wgrant: we could have a locate_key(root, term) function
[00:24] <wgrant> cprov-afk: Well, it's no worse than before. But I suppose it should be improved.
[00:25] <wgrant> Oh.
[00:25] <wgrant> oops.
[00:25] <wgrant> I misunderstood.
[00:25] <wgrant> You're right.
[00:26] <cprov-afk> wgrant: np, it's our chance to make zeca a nicer app
[04:48] <thumper> spm: why is pqm stopped?
[04:48] <thumper> btw, edge is unusable on IE
[04:49] <spm> thumper: actually atm it's not. there's a sourcecode run going  thru. *then* it'll be stopped for try 174 of bac's megamerge
[04:49] <spm> thumper: is that a value judgement against IE?
[04:50] <spm> yay. naturally as soon as I type I waiting for PQM; it finishes. woot.
[05:09] <thumper> spm: I don't suppose you could let the queue through before the cp?
[05:09] <spm> thumper: I was just thinking I might do that anyway tbh.
[05:09] <thumper> spm: that'd be great!
[05:10] <thumper> spm: given the 13! waiting branches
[05:10] <spm> thumper: aye!
[05:10]  * thumper goes to put the roast chicken in the oven
[05:11] <spm> thumper: actually it's not a CP, is a manual merge; so the "rules" are a bit more lax in that regard.
[05:20] <noodles775> Hi sinzui - I just saw your comment on thumper's branch re 'branding vs watermark'. I'll update my renaming branch to do 'branding-apps-portlet' -> 'watermark-apps-portlet' ?
[05:20] <sinzui> noodles775: thanks.I think that is best though not clear to everyone
[05:21] <noodles775> OK, will do.
[05:21] <sinzui> noodles775: Are you an insomniac?
[05:21] <noodles775> sinzui: heh, nope - just got up but wanted to check with you before you go to bed ;)
[05:22] <sinzui> I should have been in bed an hour ago.
[05:38] <wgrant> gary_poster: Why is the new buildbot still invisible?
[05:40] <gary_poster> wgrant: (I'm not really here  ;-) ) The real reason: that's the way it was set up before.  The reason that it might stay that way for a little bit: we're behind the times on the buildbot debs, and there have been some XSS problems that we need to catch up on.
[05:41] <wgrant> gary_poster: I see, thanks.
[05:41] <gary_poster> np
[08:24] <adeuring> good morning
[09:19] <thumper>     - Created 0 seconds ago
[09:19] <thumper>     ?         ^       -
[09:19] <thumper>     + Created 1 second ago
[09:20] <thumper> lib/lp/soyuz/tests/../stories/ppa/xx-copy-packages.txt
[09:20] <thumper> failing on db_devel builder
[09:20] <thumper> please don't put time in tests like this
[09:20] <thumper> elide it out
[09:20] <thumper> please!
[09:20] <noodles775> thumper: I just had the same failure on ec2test and so fixed it with my landing.
[09:20] <thumper> noodles775: thanks
[09:21] <thumper> noodles775: may have to manually get it into db-devel though
[09:21] <noodles775> so it's included in devel 9171.
[09:21] <thumper> noodles775: where did your branch land?
[09:29] <mrevell> Morning
[09:31] <noodles775> thumper: so my r9171 with the fix for that spurious time-dependent test failure missed build 23. Do you want me to submit a patch directly to db_devel (as it could be quite a while before the patch goes from stable->db_devel?)
[09:32] <thumper> noodles775: I think the best solution is to wait until is passes on the lp builder, then create a branch of db-devel, merge in stable, and submit that as a testfix
[09:32] <noodles775> Morning mrevell - when you get a chance, could you do the normal mailing list moderations?
[09:32] <mrevell> noodles775: sure thing :)
[10:31] <wgrant> Some of the production Processor titles suck.
[10:32] <wgrant> "artigas (sparc) builds The SPARC architecture binaries"
[11:11] <deryck> Good morning, all.
[11:50]  * wgrant loves Windmill. Tested JS is so much better.
[11:52] <gmb> wgrant: I love tested JS (The YUI unittest framework isn't bad, actually). But I don't think that Windmill has got it right, yet. Far too fragile.
[11:52] <deryck> wow, did someone just use the words love and Windmill together?
[11:52] <gmb> deryck: I was trying to find a diplomatic way of backing away slowly, to be honest with you.
[11:52] <deryck> heh
[11:53] <wgrant> gmb, deryck: Well... it makes everything nicer than when you have to do manual testing.
[11:54] <gmb> This is true. Up to a point, anyway.
[11:54] <gmb> wgrant: Actually, to be fair, once I'd learned to bump all the timeouts up by an order of magnitude whenver I ran the tests on my desktop machine, it wasn't all that bad.
[11:54] <gmb> But it's annoyingly time-consuming.
[11:54] <deryck> I have made peace with Windmill and appreciate it when it goes well.  I might hold hands with her, but I ain't in love yet.
[11:54] <deryck> :0
[11:54] <deryck> :) rather
[11:54] <gmb> 0.o
[12:01] <gmb> Can anyone think of a good reason why I shouldn't use datetime.astimezone() when converting a non-UTC timezone to UTC? ISTR there being a reason not to do it (and other code that I've written actively avoids using it), but I can't remember what that reason is.
[12:15] <stub> gmb: I think that is fine. I've got an example of that in the pytz documentation at http://pytz.sourceforge.net/
[12:16] <gmb> stub: Awesome, thanks.
[12:16] <gmb> Perhaps I just didn't know about astimezone() when I wrote the old code.
[12:19] <BjornT> gmb: what does the old code look like?
[12:21] <gmb> BjornT: Well, I'm just looking at it, and it's basically this:
[12:21] <gmb> utc_datetime = other_tz_datetime - timedelta(seconds=utc_offset)
[12:21] <gmb> BjornT: Even though I have a timezone name available.
[12:22] <gmb> And it's in the TestBugzillaXMLRPCTransport rather than actual production code, so I wonder if it wasn't just a quick-and-dirty hack on my part.
[12:22] <BjornT> gmb: do you have a unique timezone name?
[12:24] <gmb> BjornT: What do you mean by unique? I have the short form of the name available (e.g 'EST', 'CET', 'UTC'). I wonder if that's why I'm not quite happy about doing it this way - I can't guarantee that the tz name will actually make sense to pytz.
[12:27] <wgrant> Those aren't at all unique.
[12:27] <BjornT> gmb: for example EST is used both in the US and Australia
[12:29] <gmb> wgrant, BjornT: Right, yes. Hmm. The long form of the name is also available...
[12:30] <wgrant> That should be unique. But not necessarily lookable up.
[12:30] <gmb> Right.
[12:30] <wgrant> (see the recent rename which kept crashing the wikis until they got a newer pytz)
[12:30] <gmb> BjornT: Do you ahve time for a brief call about this? There's a related issue that's bothering me and I'm not sure what's the best way to deal with it.
[12:30] <BjornT> gmb: but the plugin doesn't guarantee that the timezone name will be unique, so better not to rely on it, not even in tests
[12:31] <gmb> BjornT: Right.
[12:31] <BjornT> gmb: sure, we could have a call
[12:31] <gmb> BjornT: Cool. Skype?
[12:32] <BjornT> yeah
[12:32] <gmb> BjornT: Calling you now.
[12:49] <bac> can i submit to pqm with [ui=sinzui]?
[12:50] <bac> i mean, has the regex been expanded to accept non-beuno ui reviewers?
[12:51] <bac> hmm, looking at recent landings it doesn't look so...
[12:51] <intellectronica> bac: i think not. we should arrange that, actually
[12:52] <bac> intellectronica: yeah, that would be good.  for now i'll use ui=rs
[12:52] <intellectronica> bac: a workaround is to land with ui=rs and the mention the real reviewer later in the message, but let's talk to the losas when we can and change that
[12:52] <bac> great minds...
[12:59] <intellectronica> leonardr: the bug you just edited - do you have any ideas what it might be? also, do you really think it's a bug in lplib (rather than the webservice itself)?
[13:00] <leonardr> intellectronica: see my follow-up comment
[13:00] <leonardr> i think it's a guy who told launchpad to hide data from launchpadlib and forgot that's what he did
[13:01] <intellectronica> leonardr: right, yes, that makes sense. i couldn't reproduce it but haven't thought about that option
[13:48] <cprov> morning, launchpadders!
[13:48] <beuno> hiya cprov
[13:49] <maxb> Hi, does anyone have any idea what launchpad uses python-lxml for?
[13:50] <maxb> (wondering whether it could be dropped from launchpad-dependencies)
[13:51] <beuno> maxb, grep the source and find out  :)
[13:52] <wgrant> All I could find when I grepped last week was lazr.restfulsomething
[13:53] <maxb> There's one mention in a docstring in ./lib/canonical/launchpad/scripts/hwdbsubmissions.py which is clearly lying
[13:53] <beuno> maxb, sounds like a patch to me
[13:54] <beuno> ;)
[13:54] <wgrant> One of lazr.restful's tests uses it, but that's it.
[13:54]  * gmb -> lunch
[13:56] <wgrant> allenap: Some of those failures were being fixed by intellectronica.
[13:56] <wgrant> Not sure if that's all of them, though.
[13:57] <beuno> intellectronica, are you playing with balsamiq for the bug index?
[13:57] <allenap> wgrant: Okay, cool.
[13:58] <intellectronica> beuno: yeah, i'm just trying to finish a mockup for the bugs index
[13:58] <beuno> intellectronica, awesomeness, looking forward to it
[13:58] <beuno> how do you like the software?
[13:58] <allenap> intellectronica: If you're fixing any of failures that wgrant mentions <http://paste.ubuntu.com/256336/>, can you point me to a branch that I can merge to see what remains to fix?
[13:59] <intellectronica> allenap, wgrant: what failures?
[13:59] <wgrant> allenap: I'm rerunning those tests with devel merged.
[13:59]  * intellectronica looking
[13:59] <allenap> intellectronica: See the paste; it has an ec2test summary log.
[14:01] <intellectronica> allenap, wgrant: xx-also-affects-distribution-default-values.txt  is the only one i've fixed. the others, i guess, are a result of the new security changes?
[14:01] <intellectronica> beuno: it's really really good. especially for someone like myself who couldn't draw if my life depended on it
[14:01] <wgrant> intellectronica: Looks like it. Most of the rest seem to cascade from Milestone not being found.
[14:01] <allenap> intellectronica: Thanks Tom :)
[14:02]  * wgrant reruns those tests.
[14:07] <sinzui> bac: I think noodles775, rockstar, or beuno should have a look too.
[14:14] <noodles775> allenap: could you take a look at this bugs question (about dup emails): https://answers.edge.launchpad.net/launchpad/+question/80508
[14:14] <allenap> noodles775: Sure.
[14:16] <noodles775> sinzui: what's the branch/mp? (I can't see anything of bac's in +activereviews)
[14:17] <noodles775> (nor does my chat history find anything :/ ).
[14:17] <sinzui> noodles775: https://code.edge.launchpad.net/~bac/launchpad/lp3-announcements/+merge/10275
[14:17] <sinzui> ^ My mistake, I approve the whole MP last night.
[14:18] <noodles775> Np - it's already merged according to the status :)
[14:23] <allenap> intellectronica: Can you help me out with https://answers.edge.launchpad.net/launchpad/+question/80508? I am baffled by how LP chooses who to send mail to :-/
[14:24]  * wgrant declares BugTaskEditView to be one of the world's great evils.
[14:25] <intellectronica> allenap: sounds like either a bug or the user is confused by something. you shouldn't receive the email twice
[14:25] <wgrant> intellectronica, allenap: The team has a mailing list.
[14:25] <wgrant> Nothing LP can do.
[14:25] <intellectronica> ah of course
[14:26] <allenap> wgrant: Ah, because the bug mail machinery can't or doesn't take into account subscriptions to mailing lists?
[14:26] <intellectronica> but that's not quite the same as him receiving the email twice
[14:26] <wgrant> intellectronica: It is if you don't do filtering.
[14:26] <intellectronica> allenap: because it doesn't know who's on the mailing list
[14:26] <wgrant> allenap: Can't, doesn't, or shouldn't. I think the last.
[14:26] <allenap> wgrant: Yes, thinking about it, I agree.
[14:34] <bac> sinzui: ^^ are you referring to my announcement change?  you want them to do a UI review?  they can, but it's already through PQM.
[14:35] <wgrant> allenap: I think BugTaskEditView has got the better of me.
[14:35] <sinzui> bac: That is fine. I need it landed to complete distro. I am not a full UI reviewer so someone else should also take a lot
[14:35] <sinzui> look
[14:36] <bac> sinzui: ok, i'll arrange it today.  my fault for assuming you were.
[14:36] <allenap> wgrant: Heh :) I'll have a look.
[14:37] <wgrant> allenap: It will not make that field editable :(
[14:38] <allenap> wgrant: Odd. I'm just going to answer the mailing list question then I'll have a go.
[14:38] <wgrant> allenap: Thanks.
[14:40] <cprov> wgrant: hi there, re. your changes on zeca almost done, few tweaks and we can land it. Thanks for working on it.
[14:42] <wgrant> cprov: Hrm, so the test methods should contain the function name even though the function is mentioned in the class name?
[14:43] <cprov> wgrant: yes, let me find the corresponding guideline reference.
[14:45] <cprov> wgrant: https://dev.launchpad.net/TestsStyleGuide#Python%20Test%20Cases -> 'testing alternatives for a LP method'
[14:48] <wgrant> cprov: Thanks.
[14:48] <sinzui> barry: EdwinGrubbs, bac, salgado: Update your bugs. please
[14:50] <bac> sinzui: i prefer to wait until i know if i have to have another pass after the UI review.
[14:51] <sinzui> bac: okay
[14:52] <barry> sinzui: nothing to update yet (go pqm, go!)
[14:58] <wgrant> cprov: Fixed, pushed, replied. Thanks.
[14:59] <cprov> wgrant: no, thank you. Do you want me to land it for you ?
[14:59] <wgrant> cprov: Please do.
[15:25] <sinzui> salgado:  look at this list and updat any bugs you fixed or may have change: https://bugs.edge.launchpad.net/launchpad-registry/+bugs?field.searchtext=polls&orderby=-importance&search=Search&field.status%3Alist=NEW&field.status%3Alist=INCOMPLETE_WITH_RESPONSE&field.status%3Alist=INCOMPLETE_WITHOUT_RESPONSE&field.status%3Alist=CONFIRMED&field.status%3Alist=TRIAGED&field.status%3Alist=INPROGRESS&field.status%3Alist=FIXCOMMIT
[15:25] <salgado> sinzui, UnexpectedFormData: Unexpected value for field 'status'. Perhaps your bookmarks are out of date or you changed the URL by hand?<br />
[15:26]  * salgado appends TTED to the end of the URL and it works
[15:26] <salgado> sinzui, ^
[15:26] <sinzui> crack
[15:27] <sinzui> salgado: https://bugs.edge.launchpad.net/launchpad-registry and search for polls
[15:27] <sinzui> salgado: I think you may have fixed bug 335516
[15:27] <ubot3`> Malone bug 335516 in launchpad-registry "Team polls page has no main heading and misuses "recent"" [Low,Triaged] https://launchpad.net/bugs/335516
[15:29] <salgado> sinzui, I didn't; I only touched pages where the context was IPoll[Option], so ITeam's +polls was left untouched
[15:29] <sinzui> salgado: you just found you next page to fix
[15:29] <salgado> :)
[15:30] <sinzui> salgado: bac and barry observed that collections are context objects so I assume you will need to pass a <h1> to the heading-slot
[15:31] <salgado> sinzui, I'm not following you
[15:31] <wgrant> allenap: Any ideas on BugTaskEditView? It has me confused.
[15:32] <allenap> wgrant: Me too, but I'll persevere. It's not going to beat me today :)
[15:33] <allenap> wgrant: The milestone widget appears on the main bug page, but not on the +editstatus page (logged in as test@canonical.com). Weird.
[15:33] <wgrant> allenap: It beat me yesterday, so I'm going to bed... good luck!
[15:33] <allenap> wgrant: Cool, hopefully I'll have something for you when you're back on.
[15:33] <sinzui> salgado: I think the default context-heading will be wrong because polls is affectively the +index for IPollSet.
[15:33] <wgrant> allenap: Thanks.
[15:34] <salgado> sinzui, oh, right, the +polls page is on IPollSubset, IIRC
[15:34]  * salgado checks
[15:35] <sinzui> salgado: so if you think the heading is wrong, then pass the <h1> to the heading-slot, and it fixes bug 335516
[15:35] <ubot3`> Malone bug 335516 in launchpad-registry "Team polls page has no main heading and misuses "recent"" [Low,Triaged] https://launchpad.net/bugs/335516
[15:48] <matsubara> stub, herb, flacoste, rockstar, cprov, Ursinha, danilos, sinzui, intellectronica: meeting in #launchpad-meeting in 13 min
[15:48] <danilos> matsubara: thanks
[15:48] <cprov> matsubara: thx
[15:48] <intellectronica> matsubara: thanks for the reminder
[15:55] <salgado> sinzui, right, I've just fixed that.  should I spend some time redesigning this page or should I do just the mechanical changes plus fixing obvious mistakes?
[15:56] <herb> Chex, mbarnett, mthaddon: meeting in #launchpad-meeting in 4 min ^^^^
[15:56] <mthaddon> thx herb
[15:57] <sinzui> salgado: no redesign. convert to 3.0, fix anything that is easy.  I would limit myself to 1h of UI changes
[15:57] <flacoste> matsubara: gary_poster will now be standing in that meeting for foundations
[15:58] <matsubara> flacoste, right. I'll update MeetingAgenda. thanks
[16:15] <barry> EdwinGrubbs: ping
[16:15] <EdwinGrubbs> barry: pong
[16:16] <barry> EdwinGrubbs: hi.  re: label and page_title.  are you sure about this?  page_title seems to work, but not label
[16:17] <barry> hmm...
[16:17] <sinzui> barry: can you follow up on bug 403606
[16:17] <ubot3`> Malone bug 403606 in launchpad-registry "ExpatError errors should be handled to not generate the OOPSes" [High,Triaged] https://launchpad.net/bugs/403606
[16:17] <mup> Bug #403606: ExpatError errors should be handled to not generate the OOPSes <oops> <Launchpad Registry:Triaged by barry> <https://launchpad.net/bugs/403606>
[16:18] <mup> Bug #403606: ExpatError errors should be handled to not generate the OOPSes <oops> <Launchpad Registry:Triaged by barry> <https://launchpad.net/bugs/403606>
[16:18] <mup> Bug #403606: ExpatError errors should be handled to not generate the OOPSes <oops> <Launchpad Registry:Triaged by barry> <https://launchpad.net/bugs/403606>
[16:18] <barry> sinzui: sure
[16:18] <Ursinha> thanks barry :)
[16:19] <EdwinGrubbs> barry: label only works if you remove fill-slot="heading" from your template.
[16:20] <barry> EdwinGrubbs: i did remove that, and added label='People and teams' but it doesn't pick that up
[16:20] <barry> EdwinGrubbs: it's getting the label apparently from the content object
[16:21] <barry> EdwinGrubbs: and the Conversion page shows the fill-slot="heading" in there
[16:22] <EdwinGrubbs> barry: for which view is it not working?
[16:23] <barry> PersonSearchView
[16:23] <barry> people-index.pt
[16:23] <barry> EdwinGrubbs: if you want, i can push the changes
[16:29] <EdwinGrubbs> sinzui: I thought the view/label was included by the base layout templates, but I can't find where it gets included.
[16:29] <sinzui> EdwinGrubbs: no. It is optional for LaunchapdFormView
[16:30] <sinzui> EdwinGrubbs: form-macros converts the label to a <h1>
[16:30] <sinzui> EdwinGrubbs: So I think the page you are working on does not use form-macros
[16:30] <EdwinGrubbs> barry: ok, ^^^^ clears it up. The LaunchpadFormView also has a "heading" slot, but since you are not using a form, the label isn't used.
[16:30] <sinzui> EdwinGrubbs: you can manually call it to place it as the first element in the main slot
[16:35] <barry> EdwinGrubbs: sorry, i'm back now
[16:36] <barry> EdwinGrubbs: so i'm inclined to leave the heading slot in there, unless i can figure out why this isn't working
[16:41] <salgado> sinzui, beuno, shouldn't <h2>s have some margin-top to make some space between them and what comes above, just like the space between them and what comes below them.
[16:42] <sinzui> salgado: My instinct says yes, but I suspect they do not because we assume they are the first item in a portlet that sets a margin or padding.
[16:43] <salgado> sinzui, we have a rule to clear the margin when the h2 is in a portlet
[16:43] <sinzui> hmm
[16:44] <sinzui> I think they should be adjusted to look good, but I would ask beuno's opinion of the change
[16:45] <beuno> ah
[16:45] <beuno> then yes
[16:45] <beuno> good call salgado
[16:45] <salgado> beuno, should it be the same value used for margin-bottom (0.3em)?
[16:46] <beuno> salgado, yes
[16:46] <salgado> cool, /me changes it
[16:47] <beuno> thanks salgado
[16:47] <beuno> salgado, has the new breadcrumb layout landed yet?
[16:47] <salgado> beuno, layout?  we didn't talk about layout
[16:48] <beuno> salgado, UI
[16:50] <salgado> beuno, we have the vhost-specific breadcrumbs for the 'bugs' vhost and the ones for 'blueprints' and 'answers' should land today.  that will get us very close to the breadcrumbs we have on https://wiki.canonical.com/Launchpad/UI/Navigation
[16:50] <barry> EdwinGrubbs: sigh.  i don't know if you've been responding.  irc is teh suck
[16:50] <barry> leonardr: yes, i will work on that lazr.restful branch
[16:50] <barry> sinzui: what do you know about fill-slot="heading" ?
[16:50] <leonardr> barry, great
[16:51] <sinzui> barry: everything
[16:51] <salgado> beuno, but we didn't talk about the presentation of breadcrumbs. I thought noodles775 was in charge of that, but I don't remember where I get that idea from
[16:51] <sinzui> it should be named context-heading. It is not the page heading/title unless we are making the index of an content object or collection
[16:51] <sinzui> ^ barry
[16:51] <EdwinGrubbs> barry: I'm pulling your branch again, just to make sure I'm not telling you something wrong.
[16:52] <beuno> salgado, ah, maybe. noodles775, was that on your plate?
[16:52] <barry> sinzui: the UI/Conversion page says to use fill-slot="heading"
[16:52] <sinzui> barry: what object are you working with?
[16:52] <EdwinGrubbs> barry: where is PersonSearchView.
[16:52] <barry> EdwinGrubbs: lib/lp/registry/browser/person.py
[16:53] <sinzui> barry: I think is you read more carefully it qualifies that the to +index of a content object, which most pages are nto
[16:53] <barry> sinzui: this is for /person and /project
[16:53] <EdwinGrubbs> barry: is that a new part of your branch that isn't pushed up? I only see PersonSearchQuestionsView
[16:53] <sinzui> barry: override the slot. for the +index
[16:54] <barry> EdwinGrubbs: let me push an update
[16:55] <sinzui> barry: if there are alternates, (like /projectgroup/+all) then you place a <h1> in main. So that  the context-heading is "Project Groups" and the page <h1> and title is something like Browse all project groups.
[16:57] <barry> EdwinGrubbs: r9161 lp:~barry/launchpad/415542-projects
[16:59] <barry> sinzui: so wait, you're saying for the object's +index page, you do have to put the label in the template explicitly?
[17:01] <EdwinGrubbs> barry: I still don't see a PersonSearchView.
[17:03] <barry> EdwinGrubbs: sorry.  it should be PeopleSearchView
[17:06] <EdwinGrubbs> barry: yes, you will need to fill in the heading slot yourself, since PeopleSearchView is not a LaunchpadFormView and probably wouldn't work well as one.
[17:07] <barry> EdwinGrubbs: agreed.  question though, is this something we should push into LaunchpadView?  not that i'm suggesting doing that right now :)
[17:08] <rockstar> sinzui, it has become apparent that I have no idea what I'm doing with menus.  Tell me again why I can't use the menus already created?
[17:09] <sinzui> rockstar: Answers never got NavigationMenus
[17:09] <EdwinGrubbs> barry: I don't think it would hurt, but it probably wouldn't be as beneficial, since non-edit pages are more likely to use several templates with the same view class, which means you couldn't specify a distinct label in the view.
[17:09] <rockstar> sinzui, okay.  So maybe I need to figure out what the difference is between NavigationMenus and ApplicationMenus
[17:09] <sinzui> rockstar: It has ApplicationMenus (context/menu:facet/link_name)
[17:10] <sinzui> rockstar: We want to remove all ContextMenus
[17:10] <barry> EdwinGrubbs: you might be right.  anyway, i'm not going to worry about it and it's good to know i'm not going crazy.  also, moving page_titles is a good thing
[17:10] <rockstar> sinzui, and how do I identify ContextMenus?
[17:10] <sinzui> rockstar: We are using ApplicationMenu's for inline links. I think this is a waste
[17:10] <barry> EdwinGrubbs: i'll respond to your review in a few minutes.  thanks
[17:11] <sinzui> rockstar: because the links are often in NavMenus. In many cases I moved the AppMenu links to a mixin, then let the AppMenu and NavMenus define the facet and the links
[17:12] <sinzui> rockstar: class AMenu(ContextMenu) <- they are used by the menubox view and template
[17:14] <rockstar> sinzui, what do you mean by "menubox view and template" ?
[17:14] <rockstar> There seems to be a vocabulary you're using that I'm not familiar with.
[17:17] <sinzui> rockstar: If you do not know about them, then it is clear we do not need them. The menubox draws the combined application and context menu in the 0 and 1 designs
[17:17] <rockstar> sinzui, okay.  So I'm not even going to worry about ApplicationMenus at all, because it seems there's no point.
[17:18] <sinzui> rockstar: 2.0 switched to NavMenus and AppMenus. I have serious doubts about their overlap
[17:19] <sinzui> rockstar: did you move any links inline? Wasn't answers crafting links without using a menu?
[17:19] <rockstar> sinzui, it seems like it.  That's a big concern of mine.
[17:19] <rockstar> sinzui, I have not moved any links inline.  I haven't yet found a case where I need to.
[17:20] <sinzui> rockstar: I know answers did because when I added the FAQ portlet, it failed because the link from the page was trying to go to a context object that did not support the link. The menu will faile if you make a link to an unregistered view
[17:20]  * sinzui cursed answers at that point
[17:20] <rockstar> sinzui, yeah, so the FAQCollection stuff is what I'm working on now.
[17:21] <rockstar> sinzui, for instance, see https://answers.edge.launchpad.net/launchpad/+faqs
[17:22] <sinzui> this outlines the expected way the menus will work: https://dev.launchpad.net/VersionThreeDotO/UI/Conversion#Adding%20a%20NavigationMenu
[17:22] <rockstar> sinzui, yeah, I'm reading that, and I think I'm confusing myself.
[17:23] <sinzui> rockstar: to get to this form., create a FAQLinksMixin and move the appmenu links into it. The appmenu just needs a facet and a list of links
[17:24] <rockstar> sinzui, yeah, that's what I was doing.  I'm wondering why we need the marker interface and all that.  It seems like overkill.
[17:25] <sinzui> rockstar: You may be special
[17:25] <sinzui> rockstar: well faq and answers may be special. I am sure you did not ride the short bus
[17:27] <rockstar> sinzui, well, the short bus was for gifted children here (because there were less of them) but I still just walked to school.
[17:27] <sinzui> rockstar: To change a context object you can define a menu that will always be present on content object (IFAQCollection, IFAQ, IAnswersCollection, IQuestion) so you no not need a marker interface
[17:27] <rockstar> sinzui, yeah, I think that's what I need.
[17:28] <sinzui> rockstar: the marker interface is only need to tie a menu to 1 or more views.
[17:28] <rockstar> Because it's always the same.  When I discovered the FAQ views (I didn't know about them before yesterday) I thought they used separate views, but they don't.
[17:28] <sinzui> https://answers.edge.launchpad.net/launchpad/+faqs
[17:28] <sinzui> ^ The show... links are view based, th creation/modifcatiobn links are context-based
[17:30] <sinzui> rockstar: so we want to move all the show links in line. If we cannot we create a navmenu on the view. I think this page has links we need to toss.
[17:31] <sinzui> rockstar: (+) create a FAQ and (+) Set answer context belong in the action menu (a nav menu on the object)
[17:31] <sinzui> rockstar: I do not know where we put (+) Ask a question, maybe inline maybe in the menu
[17:32] <rockstar> sinzui, well, I think we need a large button for "Ask a question" like we have "Register a branch"
[17:32] <sinzui> rockstar: There are no large buttons in 3.0
[17:33] <rockstar> Yes, I know this, but I don't like it.
[17:33] <sinzui> There is an involvement portlet that provides that, but is also blurs out intent so I do not think it should be used
[17:34] <rockstar> sinzui, yeah.  So much for "only mechanical changes" in answers...  :)
[17:35] <sinzui> The other links (I) Open questions, (i) Answered questions, (i) My questions, (i) Need attention questions  either go inline or we create a nav menu with a marker interface to add these to the bottom of every page so users can find the related pages.
[17:35] <sinzui> menus are mechanical
[17:35] <rockstar> sinzui, so, for the show (Open|Answered|Mine|Need Attention) - How should they be put inline?
[17:36] <sinzui> rockstar: when you put the required icons on the links, it becomes easy to see which are actions and which as views
[17:37] <rockstar> sinzui, could we have maybe a mid-implementation call then?
[17:38] <sinzui> We know these links will be appears on most of the lists and _index pages in answers, so I think we want a navmenu attached to the view and we use view/@@+related-pages as the last portlet in main
[17:38] <sinzui> sure
[17:39] <sinzui> rockstar: I am ready
[18:01] <mrevell> okay guys, I'm off for the day
[18:04] <sinzui> https://answers.edge.launchpad.net/launchpad/+question/80521
[18:12] <sinzui> rockstar: https://edge.launchpad.net/bzr
[18:15] <sinzui> rochttps://answers.edge.launchpad.net/launchpad-registry/+question/77453
[18:16] <sinzui> rockstar: https://answers.edge.launchpad.net/launchpad-registry/+question/77453
[19:48] <matsubara> rockstar, thank you!
[19:51] <rockstar> matsubara, no, thank you, and welcome to open source contributions.  :)
[19:51] <matsubara> :-)
[19:56] <beuno> sinzui, font is a tad big, no?
[19:56] <beuno> https://edge.launchpad.net/ubuntu/+search?text=gnome-do
[20:00] <sinzui> tad? wtf? That is huge
[20:01] <beuno> :)
[20:02] <sinzui> beuno: I think this is a byproduct of CSS changes. I did not look like that when I landed it...it had to be the same size as the 2.0. I think this is 50% larger
[20:02] <sinzui> !!
[20:02] <beuno> sinzui, joey noticed it
[20:03] <sinzui> beuno: The classes uses summary, which is intended for 1 per page. We are using the summary for listing so we need a rule to set the selector context right
[20:09] <barry> flacoste: i think i got disconnected from our pvt chat
[20:09] <barry> beuno, sinzui is there any good reason why project group searching shouldn't look very similar to project searching?
[20:09] <flacoste> barry: you did
[20:10] <beuno> barry, none
[20:10] <barry> beuno: i was hoping you'd say that :)
[20:10] <barry> beuno: i might have some screen shots for you soon
[20:10] <beuno> barry, I aim to please
[20:11] <sinzui> barry: make it look the same. Please. It is "broken" in that I think it prefers to search for products not projects. look at how the view does the search
[20:11]  * sinzui thinks it is using unwanted params too
[20:14] <barry> sinzui: i'm not so sure.  i think it is searching project groups.  if you search on /projects for 'test' you get 4 projects, but if you search on /projectgroup for 'test' you get only the apache project group
[20:21] <sinzui> barry: look at bug 60055 and bug 390922
[20:21] <mup> Bug #60055: IProductSet.search() and IProjectSet.search() have unused untested optional arguments <registry> <ui> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/60055>
[20:21] <mup> Bug #390922: lp.project_groups.search doesn't return a result for exact matches <Launchpad Registry:Triaged> <https://launchpad.net/bugs/390922>
[20:21] <ubot3`> Malone bug 60055 in launchpad-registry "IProductSet.search() and IProjectSet.search() have unused untested optional arguments" [Low,Triaged] https://launchpad.net/bugs/60055
[20:21] <ubot3`> Malone bug 390922 in launchpad-registry "lp.project_groups.search doesn't return a result for exact matches" [Low,Triaged] https://launchpad.net/bugs/390922
[20:21] <mup> Bug #60055: IProductSet.search() and IProjectSet.search() have unused untested optional arguments <registry> <ui> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/60055>
[20:21] <mup> Bug #60055: IProductSet.search() and IProjectSet.search() have unused untested optional arguments <registry> <ui> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/60055>
[20:21] <mup> Bug #390922: lp.project_groups.search doesn't return a result for exact matches <Launchpad Registry:Triaged> <https://launchpad.net/bugs/390922>
[20:21] <mup> Bug #390922: lp.project_groups.search doesn't return a result for exact matches <Launchpad Registry:Triaged> <https://launchpad.net/bugs/390922>
[20:23] <barry> sinzui: it's a bit of a mission creep to address those while doing the 3.0 conversion.
[20:24] <sinzui> We did commit to add functionality to features we committed to redesign, That is why it is not mechanical
[20:25] <sinzui> barry: allI am asking is that you consider fixing them if they can be done in less that 2 hours
[20:25] <barry> sinzui: cool, that's what i was looking for :)
[20:26] <sinzui> barry: consider the pages were did not commit to redesign like answers. rockstar still needs to talk about the layout because the pages have sidebar content that has to move into the main area. He is doing layout work.
[20:27] <sinzui> We we commit to redesign a page, we are really asking what features to users need this to do for this to be effective, and how do we design that.
[20:27] <rockstar> barry, I'm learning that sometimes we end up doing things we didn't sign up for.  abentley and bzr-pipelines to the rescue!  :)
[20:28] <barry> sinzui, rockstar sure.  but given how many pages need to be redesigned, this doesn't seem like a high priority right now
[20:28] <barry> sinzui: as we discussed, i think we do the mechanicals we can take care of quickly and then come back around and do deeper redesigns/fixes
[20:29] <rockstar> barry, I don't know what you're working on, but what I'm working on blurs the line between "mechanical changes" and "redesign" to the point of there being no line.
[20:30] <sinzui> barry: yes
[20:30] <barry> rockstar: i sometimes stray too, but have to be careful!
[20:30] <sinzui> rockstar: you are not asking what features does the user require of this page? That is true redesign
[20:30] <barry> rockstar: btw, working on top level collections /projects /projectgroups /people /distros /sprints
[20:31] <barry> (2/5 done)
[20:32] <rockstar> sinzui, yeah, I guess you're right, but when I think redesign, I think CSS and markup and all that jazz, which is where I'm about to head (hopefully)
[20:34] <sinzui> I have had to change the markup on most pages I have changed. We do not used the excessive table and div markup used in 2.0-
[20:35] <beuno> intellectronica, working on the edit icon problem. Will send you something to look at within the next 30-40 minutes
[20:35] <sinzui> My only happy moments are when the changes are so extreme I can throw it all away and use generic-edit.py
[20:35] <intellectronica> beuno: that's excellent, thanks!
[20:43] <rockstar> sinzui, yes.  I've eliminated many templates that way.
[20:48] <sinzui> rockstar: I did not mention that when I needed narrative about the page, I moved the 1.0 help section into the top-portlet
[20:49] <rockstar> sinzui, I don't think I need to do that.
[20:54] <EdwinGrubbs> sinzui: I'm at the point where I only have four items to do to the team index page, but they are nontrivial. They are the info from karmacache, moving the contact this team link to sidebar, listing members with timezone, and fixing the recently approved query.
[20:54] <sinzui> EdwinGrubbs: You have found a good stopping point
[20:55] <EdwinGrubbs> sinzui: I was also wondering if you had any idea why the google map stopped working. It looks like it falls back on some stubs that don't do anything but prevent errors.
[20:55] <sinzui> EdwinGrubbs: I too hit the karmacache problem I will not fix it for 3.0
[20:56] <sinzui> EdwinGrubbs: I am not aware that the map stopped working. The page view registers that is needs the small map if the user has not deactivated it
[20:57] <EdwinGrubbs> sinzui: I must have broke it. It is disabled since this function is set to always return false:     gBrowserIsCompatible = mapping.RETURN_FALSE;
[20:58]  * rockstar goes to lunch
[20:59] <EdwinGrubbs> sinzui: there's nobody oncall right now. Could you review it?
[20:59] <beuno> intellectronica, http://people.canonical.com/~beuno/400997.html
[21:00] <sinzui> EdwinGrubbs: I would have thought the contact this team link would be easy to move the to sidebar. I am happy for that to be done later. I can do it when I do contact this person
[21:02] <EdwinGrubbs> sinzui: it's just that it is currently in a view and not in a menu. It shouldn't be too hard, but I'm not exactly sure how hard.
[21:04] <sinzui> EdwinGrubbs: As I said. you are at a good point to start landing. You really do not want a branch open for more than two days. We can add the other features net week or the week after
[21:15] <intellectronica> beuno: that looks lovely
[21:15] <intellectronica> especially if the icon will be better aligned with the text
[21:18] <beuno> intellectronica, so, I don't know if I'll have time to work on this
[21:18] <beuno> but I can land the icon, and see if someone else picks it up before I do
[21:18] <intellectronica> beuno: no worries, i'll take care of integrating it
[21:19] <beuno> intellectronica, will land today then, and re-assign it to you   :)
[21:19] <beuno> \o/
[21:19] <beuno> thank you
[21:29] <EdwinGrubbs> joey: ping
[21:30] <joey> hi EdwinGrubbs
[21:31] <EdwinGrubbs> joey: can you check if bug 402747 is fixed for you now? I can't recreate the problem on my workstation and I don't have access to that page on edge.
[21:31] <mup> Bug #402747: The requested URL /@@popup-window was not found on this server. <Launchpad Registry:Triaged by edwin-grubbs> <https://launchpad.net/bugs/402747>
[21:31] <ubot3`> Malone bug 402747 in launchpad-registry "The requested URL /@@popup-window was not found on this server." [Low,Triaged] https://launchpad.net/bugs/402747
[21:31] <mup> Bug #402747: The requested URL /@@popup-window was not found on this server. <Launchpad Registry:Triaged by edwin-grubbs> <https://launchpad.net/bugs/402747>
[21:31] <mup> Bug #402747: The requested URL /@@popup-window was not found on this server. <Launchpad Registry:Triaged by edwin-grubbs> <https://launchpad.net/bugs/402747>
[21:31] <joey> hmm sure
[21:31] <joey> mup vs ubot3
[21:32] <sinzui> Two men enter, one man leaves
[21:32] <flacoste> hey, nice post a bug comments AJAX!
[21:32]  * sinzui thinks mup is cheating just like Master Blaster
[21:33] <joey> EdwinGrubbs: so, there's still an error but not the same one. The new pop-up gives me a red error which says "Loading results failed."  nothing further
[21:33] <joey> EdwinGrubbs: let's see if I can send you a screenshot over irc
[21:34] <joey> EdwinGrubbs: actually, how about if I just attach it to the bug
[21:57] <barry> beuno: https://devpad.canonical.com/~barry/pgroup.png
[21:57] <barry> beuno: that's project groups ui 3.0
[21:58] <sinzui> barry: The icons are missing from the links
[21:58] <barry> sinzui: they're supposed to be.  see beuno :)
[21:59] <sinzui> barry: I assume you moves /people?
[21:59] <barry> sinzui: all top level pages will be consistent
[22:00] <sinzui> What of the alternate views like list all?
[22:00] <beuno> barry, I loves it
[22:00] <beuno> the description text is too tiny
[22:01] <barry> sinzui: anything that uses the shared menu will look exactly the same
[22:01] <barry> beuno: do you mean "There are 8 project groups..." part?
[22:01] <sinzui> barry: projects and project groups have a +all view
[22:01] <beuno> barry, no, the results' description
[22:02] <sinzui> barry: I fine with removing +all, maybe google will not be
[22:02] <barry> beuno: do you want it the same size as the descriptive text at the bottom, somewhere in between?
[22:02] <joey> Ursinha: do you know who owns ubot3?
[22:02] <Ursinha> hmm
[22:02] <Ursinha> ubot3`, owner
[22:02] <ubot3`> This bot is owned by jussi01 - Questions about ubottu should be asked in #ubuntu-bots
[22:02] <joey> Ursinha: wondering if we can get it removed or similar so we don't have it competing with mup
[22:02] <Ursinha> the same as ubottu
[22:03] <beuno> barry, isn't there a standard CSS style for it?  the answer would be in between
[22:03] <Ursinha> joey, I think ubot3` is better since it recognizes oops urls
[22:03] <barry> sinzui: i can redesign +all pages next.  those are different templates.  are there bugs open for those pages?
[22:03] <beuno> :)
[22:03] <Ursinha> :(
[22:03] <beuno> ah
[22:03] <beuno> oooop
[22:03] <barry> beuno: i don't think there is yet in style 3.0, that's why i was asking :)  i'll add it
[22:03] <Ursinha> bad bad operator
[22:03] <joey> beuno: lol
[22:03] <beuno> I knew I shouldn't of created an alias for that
[22:04] <Ursinha> LOL
[22:04] <sinzui> barry: no, because I did not consider them separate. They are links the the same view, often with a template that should not exist
[22:04] <barry> beuno: i want to make projects and projectgroups consistent
[22:04] <joey> lol
[22:04] <beuno> :)
[22:04] <joey> sorry, beuno
[22:04] <joey> I couldn't resist
[22:04] <Ursinha> that was mean
[22:04] <joey> I'll go back into my hole now
[22:04] <sinzui> barry: +all is doing search trickery to the view
[22:04] <beuno> I desirved it
[22:05] <joey> flacoste: : I still own the LP channels (I think).  You should appoint someone to look after them probably.  Like the ubot3 vs mup issue.
[22:06] <joey> flacoste: I can make the request to make all the changes to the freenode staff (I think I'm the registered LP contact)
[22:06] <barry> sinzui: i'll attack those as part of bug 273209
[22:06] <mup> Bug #273209: /projects, /distros, /people pages are missing application tabs <Launchpad Registry:In Progress by barry> <https://launchpad.net/bugs/273209>
[22:06] <sinzui> barry: thanks.
[22:07] <joey> flacoste: but I'm happy to keep them if you don't really care. I know Ursinha will help me. :-)
[22:07] <flacoste> joey: ok, i'm making a note of that
[22:08] <Ursinha> :)
[22:10] <thumper> morning
[22:11] <sinzui> rockstar: ping
[22:11] <barry> beuno: 116% looks good
[22:11] <rockstar> sinzui, hi
[22:12] <sinzui> rockstar: beuno okayed 'show' links on the top-level colleciton pages. You may want to ask for the same permission for the answers and faq listings
[22:13] <sinzui> rockstar: I mean show links in the side portlet, separate from actions, but in the side
[22:13] <rockstar> sinzui, yeah, I was planning on having all of this UI reviewed, because it's not really all mechanical anymore.
[22:24] <barry> intellectronica: thanks!
[22:31] <beuno> thumper, hi
[22:31] <thumper> beuno: hi
[22:31] <beuno> I just bumped into something interesting
[22:31] <beuno> https://code.edge.launchpad.net/~beuno/launchpad
[22:31] <beuno> is context-less
[22:31] <thumper> yes?
[22:31] <beuno> for the tabs at least
[22:32] <beuno> bah, not context-less
[22:32] <beuno> wrong words
[22:32] <beuno> "tabs" don't take you anyway
[22:32] <beuno> anywhere
[22:32] <beuno> I guess because you don't know where to take me
[22:32] <thumper> that is because they are not enabled
[22:32] <thumper> no
[22:32] <thumper> it knows where to take you
[22:32] <thumper> but no other app supports it yet
[22:32] <beuno> aha
[22:32] <beuno> true
[22:32] <beuno> and there's no link to that anywhere, right?
[22:32] <thumper> not yet
[22:33] <thumper> we are wanting to change the personal listings
[22:33] <thumper> but there are so many edge cases
[22:33] <thumper> it is proving difficult
[22:33] <beuno> got it
[22:34] <beuno> ok, it's cool
[22:34] <beuno> thumper, I'm off home, have a 40 minute drive from this hotel
[22:34] <beuno> I'll try and catch you for that call
[22:34] <thumper> ok
[23:02] <rockstar> thumper, standup?
[23:02] <thumper> rockstar: yesarooney
[23:03] <thumper> rockstar: skype says your not on line
[23:03] <rockstar> thumper, I just saw abentley get on.
[23:04] <rockstar> thumper, I just called you and hung up.
[23:21] <wgrant> Can somebody please ec2test-submit https://code.edge.launchpad.net/~wgrant/launchpad/make-zeca-useful? cprov did overnight, but it failed due to the breadcrumb breakage.
[23:48] <beuno> thumper, up for that quick chat in 10?
[23:53] <thumper> wgrant: can you go to https://code.edge.launchpad.net/groff ?
[23:53] <thumper> wgrant: I'm wonding about timeouts
[23:53] <thumper> wgrant: I know it will follow a different code path for you and me
[23:54] <thumper> CP in progress?
[23:54] <thumper> beuno: sure
[23:54] <wgrant> thumper: It's fairly quick, but the new templatehas lost the queries/time data.
[23:55] <thumper> wgrant: yeah, sinzui knows and I think is fixing
[23:55] <thumper> wgrant: but no timeouts?
[23:55] <wgrant> thumper: Not even close.
[23:55] <thumper> cool
[23:55]  * thumper marks bug fix committed
[23:56] <wgrant> Great.
[23:56] <beuno> thumper, ready when you are