| === kfogel is now known as johnlodder | ||
| * wgrant awards lazr.restful the award for Most Useless Error Message. | 02:57 | |
| jml | I don't know, one of the Launchpad forms has "Invalid value" | 03:00 |
|---|---|---|
| jml | is it worse than that? | 03:00 |
| wgrant | Well, that at least tells you which field is wrong. | 03:00 |
| wgrant | THis one doesn't. | 03:00 |
| jml | oooh. | 03:00 |
| wgrant | It's during the WADL generation, so the traceback is useless. It just tells you that there needs to be precisely one IEntry defined for None. | 03:00 |
| wgrant | It actually means that the interface specified in a Reference isn't exported as an entry of its own. | 03:01 |
| wgrant | I'd forgotten that this particular one wasn't, as it has no implementations that weren't already exported. | 03:01 |
| spm | "bus error. core dump." <== what more do you need in an error message? | 03:09 |
| === ursula_ is now known as Ursinha | ||
| wgrant | I have a branch that is going to exceed the 800 line limit. About 300 lines of it is repetitive addition of a new interface to lots of other interfaces, which could be reasonably split into a separate branch. Should I split it? | 03:49 |
| lifeless | will it be easier to review? | 03:56 |
| lifeless | [also, can you reduce the duplication somehow] | 03:56 |
| wgrant | lifeless: It'll be easier to review, but a little pointless. | 03:57 |
| wgrant | The duplication is irreducible. | 03:57 |
| lifeless | thats a shame. why? | 03:57 |
| wgrant | It's actually not adding a new interface, it's just shifting how the classes declare that they implement it. | 03:57 |
| wgrant | Because lazr.restful has a One Interface Policy. | 03:57 |
| wgrant | (it's IStructuralSubscriptionTarget, implemented by IProject, IProduct, IDistribution, IDistroSeries, IProductSeries, IDistributionSourcePackage) | 03:58 |
| === abentley1 is now known as abentley | ||
| === abentley1 is now known as abentley | ||
| jml | wgrant, I think I've filed a bug about that error message. | 06:11 |
| wgrant | jml: Ah, good. | 06:16 |
| adeuring | good morning | 08:28 |
| noodles775 | Morning adeuring | 08:28 |
| adeuring | hi noodles775! | 08:29 |
| gmb | Morning, Launchpeeps. | 09:15 |
| mrevell | Morning! | 09:34 |
| bigjools | morning mrevell | 09:36 |
| mrevell | hey bigjools | 09:36 |
| wgrant | Morning mrevell, bigjools, gmb. | 09:37 |
| bigjools | how's the bairn? | 09:37 |
| bigjools | good evening wgrant | 09:37 |
| wgrant | gmb: Can you have a look at my two questions on bug #297458? | 09:37 |
| mup | Bug #297458: setting nominations on a bug via the API <api> <launchpadlib :Invalid> <Launchpad Bugs:In Progress by wgrant> <https://launchpad.net/bugs/297458> | 09:37 |
| gmb | Sure | 09:37 |
| * gmb looks | 09:37 | |
| gmb | wgrant: Maybe there's a reason not to do this that I can't think of at sub-10am on a Monday but: Why does ISeriesBugTarget need to have no attributes? Couldn't it just descend from IBugTarget? | 09:44 |
| wgrant | gmb: An excellent idea. | 09:44 |
| gmb | Damn, that's my excellent idea for the day. | 09:45 |
| gmb | I was hoping to save it for the binary-blob processing bug. Oh well. | 09:45 |
| wgrant | Heh. | 09:45 |
| wgrant | That's an oldish one. | 09:45 |
| gmb | wgrant: Yeah. Unfortunately, kernel crashes are now getting uploaded to Launchpad, which makes it happen more often. | 09:47 |
| wgrant | gmb: Do you agree with my solution for the second? | 09:47 |
| gmb | wgrant: I can't think of any reason not to do it, so go for it. | 09:47 |
| wgrant | gmb: Thanks muchly. | 09:47 |
| gmb | wgrant: np. I'll reply to the bug for the sake of everyone knowing what's going on. | 09:48 |
| wgrant | gmb: I also noticed an oddity in IBug.addNomination: nomination for an obsolete distroseries is forbidden, but permitted for an obsolete productseries. | 09:56 |
| wgrant | Any idea why that is? | 09:57 |
| gmb | wgrant: Hmm. Not off the top of my head. | 09:58 |
| gmb | wgrant: One of the registry people might know, but they won't be around for another few hours. | 09:58 |
| wgrant | gmb: Thanks. | 09:58 |
| wgrant | gmb: Does Registry own structural subscriptions? They still live in canonical.launchpad. | 09:59 |
| wgrant | (and I want to export them) | 09:59 |
| gmb | wgrant: I don't know, actually. But I remember intellectronica doing a lot of work on structural subs, so if you have any questions he might be able to help you. | 10:01 |
| * bigjools basks is Ashes glory today | 10:03 | |
| bigjools | s/is/in/ | 10:03 |
| * wgrant wondered when that would come up. | 10:03 | |
| bigjools | now I wonder if there's an Aussie around who I can wind up.... ah wgrant! | 10:04 |
| wgrant | I'm so dedicated to cricket, I only heard the news through identi.ca this morning. | 10:04 |
| noodles775 | heh... what news? | 10:04 |
| noodles775 | ;) | 10:04 |
| bigjools | don't shout, I have a hangover | 10:05 |
| wgrant | bigjools: So, I cut up the librarian log parser on Saturday afternoon, and ended up with a working but broken in some cases PPA package download counter. | 10:16 |
| wgrant | I'm not sure how to handle the ambiguous cases. | 10:16 |
| danilos | stub: if I ask LOSAs to QA the modified langpack export script for long transactions, how could they tell if it's using long transactions or not? | 10:23 |
| stub | danilos: There is a graph of the longest running transaction on the system. They can monitor that, or that can query pg_stat_activity (select current_timestamp - xact_start as age from pg_stat_activity where usename='langpack') | 10:31 |
| danilos | stub: cool, thanks (I'd be doing it on staging before asking for a CP, so this helps) | 10:32 |
| bigjools | wgrant: great! I don't really have time to look at it right now, but maybe later this week. | 10:38 |
| wgrant | bigjools: Sure. | 10:39 |
| huangjs | Is it possible to make Launchpad work with GIT? | 10:57 |
| bigjools | huangjs: it can import git branches | 10:58 |
| huangjs | bigjools: i see. is there a way to do the importing periodically? | 10:59 |
| bigjools | huangjs: yes | 11:01 |
| bigjools | https://help.launchpad.net/Code/UploadingABranch#Mirroring%20a%20branch%20that%27s%20hosted%20elsewhere | 11:01 |
| bigjools | and https://help.launchpad.net/Code/Imports | 11:02 |
| huangjs | bigjools: thanks! | 11:02 |
| bigjools | welcome | 11:02 |
| thumper | night lp hackers | 11:29 |
| === thumper is now known as thumper-zzz | ||
| danilos | sinzui: hey, around? I'd like to talk some more about the IHasLogo generation; I had to do a similar fix to what thumper-zzz did, but in a different method | 11:57 |
| noodles775 | danilos: can I see your MP? Interested to know why you couldn't use the IRootContext that thumper added? (in browser/watermark.py) | 12:03 |
| noodles775 | or was it not related to the watermark logo? | 12:04 |
| danilos | noodles775: hum, I am using IRootContext | 12:04 |
| danilos | noodles775: read through "Implementation details" on https://code.edge.launchpad.net/~danilo/launchpad/translator-templates/+merge/10546 | 12:04 |
| noodles775 | danilos: Thanks! | 12:04 |
| danilos | noodles775: it's mostly about very similar methods, which is a bit weird | 12:04 |
| noodles775 | oh danilos, btw, the bzr issue I (thought) I had the other day was just because I was using pqm-submit before the branch had actually been scanned (hence not recognising the format). | 12:14 |
| danilos | noodles775: ah, right, nice to know | 12:14 |
| === henninge is now known as henninge-lunch | ||
| === mrevell is now known as mrevell-luncheon | ||
| === matsubara-afk is now known as matsubara | ||
| === salgado is now known as salgado-brb | ||
| === mrevell-luncheon is now known as mrevell | ||
| === salgado-brb is now known as salgado | ||
| rockstar | sinzui, ping | 13:54 |
| sinzui | Hi rockstar | 13:54 |
| === henninge_ is now known as henninge | ||
| beuno | noodles775, salgado, what did we agree for the breadcrumbs UI? | 15:08 |
| noodles775 | beuno: that we don't need to keep the existing formatting, just add the new formatting (using a template rather than inline)... | 15:09 |
| beuno | noodles775, and is that on your plate now? | 15:09 |
| noodles775 | unconverted pages will just have the new breadcrumbs in the wrong place. | 15:09 |
| noodles775 | beuno: if that's ok with bigjools, I'm happy to do it. | 15:09 |
| * beuno looks at bigjools with a sad face | 15:10 | |
| noodles775 | lol | 15:10 |
| beuno | pleeeeeeeeeeeeeeeeease | 15:11 |
| * bigjools is on the phone | 15:11 | |
| bigjools | will read back in a bit | 15:11 |
| beuno | bigjools, just type "yes" | 15:11 |
| beuno | (and hit enter) | 15:11 |
| beuno | no need to think | 15:11 |
| bigjools | I iz back | 15:23 |
| bigjools | beuno, noodles775: how much work? | 15:24 |
| beuno | I estimate about 10 minutes | 15:24 |
| beuno | but lets see what noodles775 has to say | 15:24 |
| noodles775 | bigjools: it *should* be very straight-forward... | 15:24 |
| bigjools | "yes" | 15:24 |
| * bigjools hits enter | 15:24 | |
| noodles775 | heh, not 10 minutes, but yes, small. :) | 15:24 |
| * beuno has a rare dyslexia that doesn't see quotes | 15:25 | |
| beuno | YAY | 15:25 |
| beuno | thank you bigjools, noodles775 | 15:25 |
| noodles775 | np! | 15:25 |
| beuno | with this, my evil Launchpad 3.0 navigation plan is all in motion | 15:25 |
| bigjools | beuno: I think Curtis' team will need some evil navigation help with +related-software | 15:26 |
| beuno | bigjools, sinzui has a 24/7 private phone line directly to me | 15:27 |
| sinzui | bigjools: We wont know that until we work out what that page and all its many incoming links do | 15:28 |
| bigjools | beuno: like I said, you have a big red phone, and I shall call you Commissioner Gordon | 15:28 |
| beuno | bigjools, I've been called worst | 15:28 |
| bigjools | sinzui! I knew you'd still be online on your vacation | 15:28 |
| bigjools | :D | 15:29 |
| beuno | I thought sinzui was just taking a vacation so he could do *more* UI | 15:29 |
| beuno | :) | 15:29 |
| bigjools | he said his self-esteem was proportional to the number of branches he lands | 15:29 |
| sinzui | I'm actually trying to fix a bug in my editor's plugins | 15:29 |
| beuno | sinzui, gedit mis-behaving? | 15:31 |
| * sinzui is tempted to hack on the milestone page because there are secret features he wants to add. | 15:31 | |
| sinzui | My plugin does not build on jaunty. | 15:31 |
| sinzui | I want a PPA that provides the project, bzr, and lp tools I use. | 15:32 |
| beuno | sinzui, ah, the gedit-bzr plugin | 15:32 |
| beuno | it's pretty unmaintained, no? | 15:32 |
| sinzui | Mine uses bzr-gtk. I did not want to reinvent other people's work | 15:33 |
| bigjools | I'd really like kdevelop to support Bzr and Python better | 15:33 |
| sinzui | bigjools: I thought kdevelop had great support for plugins/extensions | 15:34 |
| bigjools | I don't remember, I last used it 3 years ago for C++ | 15:34 |
| rockstar | abentley, it's intentional that bzr add-pipe --before and bzr add-pipe --after are different, right? | 15:47 |
| rockstar | Er, that the pipe that's created is different. | 15:48 |
| abentley | rockstar: possibly. The pipe that's created by add-pipe --before FOO should be the same revision as the pipe that's created by add-pipe --after FOO. | 15:49 |
| abentley | But that may be too clever. Maybe those options should only control position, not revision. | 15:50 |
| rockstar | abentley, if you do --before, it actually creates with the same revno the :next, and --after has the same revno as :prev | 15:50 |
| beuno | intellectronica, noodles775, rockstar, EdwinGrubbs, barry, jtv, mrevell, ajax call in 11'! | 15:50 |
| rockstar | beuno, 11 feet? | 15:50 |
| abentley | rockstar: Right, like I said above. | 15:50 |
| beuno | rockstar, yes. We are meeting above your house | 15:50 |
| beuno | did you now get the email? :) | 15:51 |
| * rockstar gets the ladder. | 15:51 | |
| barry | beuno: right! thanks | 15:51 |
| === carlos_ is now known as carlos | ||
| abentley | rockstar: https://code.edge.launchpad.net/launchpad/+activereviews seems to have become a lot less useful. Do you know what happened to "reviews I can do", etc? | 15:54 |
| rockstar | abentley, I know thumper was talking about doing something, but I don't know if he changed it. | 15:55 |
| rockstar | abentley, actually, it looks like there aren't any you CAN do. | 15:56 |
| abentley | rockstar: That gets the "other" header, though. | 15:57 |
| rockstar | abentley, the OTHER is for stuff that you could have done, but someone has already gotten to it. | 16:00 |
| abentley | rockstar: Roughly, yes. Where is it? | 16:01 |
| sinzui | bac: can you update or unassign bug 175448 and bug 187312 | 16:03 |
| mup | Bug #175448: RSS icon in FF url bar although no announcement is published yet <project-announcements> <Launchpad Registry:Triaged by bac> <https://launchpad.net/bugs/175448> | 16:03 |
| mup | Bug #187312: Standalone global announcements page doesn't seem useful <project-announcements> <Launchpad Registry:Triaged by bac> <https://launchpad.net/bugs/187312> | 16:03 |
| bac | yep | 16:03 |
| === cprov is now known as cprov-lunch | ||
| barry | beuno: am i on the right c/c #? | 16:04 |
| sinzui | barry: https://edge.launchpad.net/distros looks great | 16:04 |
| intellectronica | barry: if you're not hearing muzak then you're not | 16:05 |
| barry | sinzui: thanks! | 16:05 |
| barry | intellectronica: that's all i'm hearing. i am rocking to it, but still :) | 16:05 |
| beuno | barry, kiko's | 16:05 |
| barry | beuno: bueno! | 16:05 |
| sinzui | barry: what is the criteria for the * read-only on the distros page? | 16:06 |
| barry | sinzui: otp | 16:07 |
| rockstar | abentley, do you not see "Other reviews" ? I do. | 16:15 |
| rockstar | abentley, also, sorry for the delay; I'm on a phone call. | 16:15 |
| abentley | I don't see it. | 16:15 |
| rockstar | EdwinGrubbs, https://devpad.canonical.com/~mars/conversions.html | 16:16 |
| rockstar | abentley, that's odd. | 16:16 |
| barry | abentley: enable google.com in noscript | 16:17 |
| abentley | barry: I have all sites enabled in noscript. | 16:18 |
| barry | abentley: dunno. that wfm ;) | 16:20 |
| rockstar | abentley, and I assume you're logged in. | 16:21 |
| abentley | barry: I disabled the noscript extension, and still no workie. | 16:21 |
| abentley | rockstar: I am logged in. | 16:21 |
| beuno | rockstar, what are you doing about the major pages? | 16:26 |
| beuno | converting first and then designing? | 16:26 |
| beuno | there's no dsign for MP, for example | 16:26 |
| beuno | I can | 16:26 |
| beuno | cool | 16:27 |
| beuno | question for everyone: | 16:27 |
| beuno | how's the UI reviewing stgoing? | 16:27 |
| beuno | with all the new people? | 16:27 |
| beuno | yes, I have a bunch of tasks from our last call | 16:28 |
| beuno | sorry barry :) | 16:29 |
| beuno | I've been sprinting last week | 16:29 |
| abentley | gary_poster: I have a branch that adds bzr 1.18rc1 to bzr+ssh://bazaar.launchpad.net/%7Elaunchpad/lp-source-dependencies/trunk/. What's the procedure to get that merged? | 16:34 |
| === deryck is now known as deryck[lunch] | ||
| === matsubara is now known as matsubara-lunch | ||
| gary_poster | abentley: in the abstract, usually I like to test that the distribution does in fact work with launchpad (ec2test now has some flags to help). then you just add it. as long as you are not overwriting anything, everything is AOK. | 16:36 |
| abentley | gary_poster: I thought there was no risk to adding 1.18rc1 if versions.cfg does not reference it. | 16:37 |
| gary_poster | abentley: no there's not, I just am trying to be clean (since everybody has to download what's in the cache). So that's my only consideration. | 16:38 |
| abentley | gary_poster: I have a branch that updates Launchpad so it works with 1.18rc1, but I want to land that after landing the download_cache change, because it's not compatible with 1.17. | 16:40 |
| gary_poster | abentley: +1 . | 16:40 |
| abentley | gary_poster: cool. | 16:42 |
| barry | beuno: i got kicked off | 16:45 |
| beuno | barry, the conference calls can only handle a certain level of awesomeness | 16:46 |
| abentley | gary_poster: lp:launchpad/lp-source-dependencies/trunk is currently in pack-0.92 format. We should look at switching it sometime. | 16:49 |
| gary_poster | abentley: ack. will that be smooth if people have a check out rather than a branch, and then do bzr up after the lp repo has switched? | 16:51 |
| abentley | gary_poster: No. It would only be smooth if they had a lightweight checkout. | 16:52 |
| gary_poster | abentley: ok. I'll make an lp bug with the info. maybe we can make things simpler using rocketfuel-get. can you bzr upgrade a checkout after you did it for the branch, or is there some other relatively simple fix other than "wipe out the directory and get it again"? | 16:53 |
| abentley | gary_poster: You can bzr upgrade the checkout before or after the lp branch is upgraded. | 16:55 |
| abentley | gary_poster: (but if you do it before, you won't be able to commit) | 16:55 |
| gary_poster | abentley: ah ok, awesome. thanks | 16:56 |
| abentley | gary_poster: np | 16:56 |
| danilos | salgado: hey | 17:11 |
| salgado | hi danilos | 17:12 |
| danilos | salgado: I am trying to add breadcrumbs for Translation groups (translations.launchpad.dev/+groups) page, but it seems not to respect canonical_url() and returns just launchpad.dev/+groups | 17:12 |
| danilos | salgado: patch at http://pastebin.ubuntu.com/258759/ | 17:12 |
| danilos | salgado: (and thanks for getting rid of the limitation that '+something' can't have a breadcrumb, I was hitting that on Friday ;) | 17:13 |
| salgado | danilos, you need to set rootsite='translations' on your custom breadcrumb class | 17:13 |
| === deryck[lunch] is now known as deryck | ||
| danilos | salgado: ah, ok, I thought having rootsite in zcml was enough | 17:14 |
| danilos | salgado: I am wondering what's the reason though? basically, we have no rootsite set on most of our browser:urls in zcml, but we should; is this a work-around to fix such cases, or intentional? | 17:16 |
| salgado | danilos, it should be enough. can you file a bug about that? | 17:18 |
| danilos | salgado: certainly | 17:18 |
| salgado | danilos, it's not really a workaround. what happens is that we need to use canonical_url(object, rootsite='mainsite') when getting the URL for the breadcrumbs, or else all URLs will be under the vhost we're currently on | 17:18 |
| salgado | (it is a workaround but for another issue) | 17:19 |
| danilos | salgado: except those specified in zcml, right? | 17:19 |
| === gary_poster is now known as gary-lunch | ||
| danilos | salgado: I might be mistaken about how canonical_url works though | 17:19 |
| salgado | but for objects which already specify the rootsite in the zcml, that should be used instead of 'mainsite' | 17:19 |
| danilos | salgado: ah, right, this is for 'point people at the mainsite whenever possible' workaround | 17:20 |
| salgado | yes | 17:20 |
| === salgado is now known as salgado-lunch | ||
| danilos | salgado-lunch: fyi, bug 418214 | 17:33 |
| mup | Bug #418214: Breadcrumbs code doesn't respect rootsite specified in zcml <Launchpad Foundations:New> <https://launchpad.net/bugs/418214> | 17:33 |
| === cprov-lunch is now known as cprov | ||
| rockstar | barry, I just got spam from Barry Warshaw. | 17:43 |
| === beuno is now known as beuno-lunch | ||
| === matsubara-lunch is now known as matsubara | ||
| rockstar | abentley, am I being lied to when I push a branch and it says "Source branch format does not support stacking" even though I'm in Branch format 7? | 17:56 |
| abentley | rockstar: yes, Branch format 7 supports stacking. | 17:57 |
| rockstar | abentley, okay, so it's a bug in codehosting then? I remember there being a bug, but I thought that it had been fixed. | 17:58 |
| abentley | rockstar: It's a bug in bzr. | 17:59 |
| rockstar | abentley, otay. | 17:59 |
| === gary-lunch is now known as gary_poster | ||
| mrevell | okay guys, see you tomorrow | 18:03 |
| === cody-somerville_ is now known as cody-somerville | ||
| === salgado-lunch is now known as salgado | ||
| === beuno-lunch is now known as beuno | ||
| leonardr | barry, can you help me with some tricky python? | 19:04 |
| barry | leonardr: sure | 19:05 |
| leonardr | barry: https://pastebin.canonical.com/21438/ | 19:05 |
| leonardr | when i try to use this code i get TypeError: 'classmethod' object is not callable | 19:05 |
| barry | leonardr: line 43 looks weird; a return outside of a function? | 19:06 |
| leonardr | it is in a function, the WebServiceWSGIApplicationFactory function | 19:07 |
| barry | oh! i see that's a def | 19:07 |
| barry | i don't think you can use @classmethod outside of a class definition | 19:08 |
| barry | well, maybe you can, i've just never seen it done | 19:08 |
| leonardr | oh, i think i know what it is. i forgot to add configure_server to the dict | 19:08 |
| leonardr | no, no change | 19:08 |
| leonardr | barry: i was able to use @property outside of a class definition | 19:08 |
| barry | leonardr: where do you get the type error? | 19:09 |
| leonardr | barry: got it. i should call cls.configure_server instead of configure_server | 19:10 |
| barry | leonardr: yep. @classmethod takes a class as the first arg. | 19:10 |
| rockstar | sinzui, yo | 19:17 |
| cprov | barry: ping | 19:23 |
| barry | cprov: otp, sec... | 19:24 |
| cprov | barry: okay, ping when you are done. Is there a way to get `ulimit -n` value elegantly in python ? | 19:26 |
| maxb | cprov: python -c "import resource; print resource.getrlimit(resource.RLIMIT_NOFILE)" | 19:33 |
| barry | maxb: you beat me to it :) | 19:33 |
| cprov | maxb: yup, just found the resource module too :) | 19:33 |
| cprov | however, I think i need to get the number of currently open files. Anyone ? | 19:35 |
| cprov | btw, resource module is gold! | 19:35 |
| === abentley1 is now known as abentley | ||
| === abentley1 is now known as abentley | ||
| === abentley1 is now known as abentley | ||
| salgado | abentley, the links under the "Branches related to" section of https://code.edge.launchpad.net/~sinzui point to lp.net rather than code.lp.net. shall I file a bug for that? | 20:36 |
| abentley | salgado: For me, they point to code.edge.launchpad.net | 20:38 |
| salgado | abentley, the links to the teams at the bottom of the page? | 20:39 |
| abentley | salgado: Oh, that. | 20:39 |
| abentley | salgado: I dunno, I like person links to take me to the person's homepage. I don't know about team links. | 20:40 |
| beuno | all team/people/project/distro/etc links should take you to their overview page | 20:41 |
| salgado | abentley, that's how they should work, for people and teams, but the heading there implies that following the links will show me the branches related to those teams | 20:41 |
| salgado | beuno, ^ | 20:41 |
| beuno | sinzui did that change | 20:41 |
| abentley | salgado: I don't think that going to the code view for, e.g. "Launchpad API Hackers" would be especially useful. | 20:41 |
| salgado | even less so if you go to the team's home page, as there will certainly be no branches related to the team there | 20:42 |
| beuno | salgado, I agree that's an odd case, so maybe that listing needs to have a different format | 20:42 |
| beuno | that part of the page needs thought and re-design | 20:42 |
| salgado | ok, I'll file a bug | 20:43 |
| abentley | salgado: I'm not even sure what "Branches related to" is meant to mean. I think it means that sinzui has created branches related to Launchpad API Hackers, for example. | 20:43 |
| beuno | the behavior is correct though | 20:44 |
| abentley | salgado: So showing all the branches for Launchpad API Hackers wouldn't connect. | 20:44 |
| abentley | salgado: You might argue that it should show all the branches sinzui created which were related to Launchpad API Hackers. | 20:45 |
| abentley | salgado: Is there any reason to keep the import of canonical_url in hierarchial-menu.txt? | 20:52 |
| salgado | abentley, no, I've removed it after I sent that MP | 20:53 |
| abentley | salgado: Okay. | 20:53 |
| abentley | salgado: I think Heirarchy.items would be simpler if you used enumerate. Do you agree? | 20:58 |
| salgado | abentley, indeed, good catch | 21:00 |
| abentley | salgado: Other than that, looks great. r=me. | 21:02 |
| salgado | cool, thanks | 21:02 |
| sinzui | salgado: We are redesigning the distroseries +index page, we should not work on that without also working on the productseries +index page. They should be very similar | 21:03 |
| salgado | sinzui, where do I see the list of pages that we are redesigning? | 21:03 |
| sinzui | I cannot find it. beuno put it in a funny place | 21:05 |
| sinzui | https://dev.launchpad.net/UI/ThreeDotOPages | 21:09 |
| sinzui | ^ I am going to link it to something | 21:09 |
| === barry` is now known as barry | ||
| sinzui | salgado: I updated https://dev.launchpad.net/UI/ThreeDotOPage to make it clearer | 21:20 |
| salgado | thanks sinzui | 21:25 |
| salgado | sinzui, so, just to clarify, should I work on another item and wait until you're back to take distroseries? | 21:26 |
| sinzui | salgado: I would prefer to do the series myself. I have a secret agenda. | 21:26 |
| salgado | ok, it's all yours then. :) | 21:27 |
| sinzui | salgado: I use the series and milestones pages as a tool to do my job. I have a lot of small changes I what to make to make them rock | 21:28 |
| barry | can i scrounge up a ui review and a code review from anybody? | 21:33 |
| beuno | sinzui, if you're around, where can I poke at the 3.0 template? | 21:37 |
| beuno | the footer, specifically | 21:37 |
| sinzui | beuno: lp/app/template/base-layout-macros.pt | 21:38 |
| beuno | sinzui, thanks | 21:38 |
| sinzui | beuno: or lp/app/template/base-layout.pt if something else needs fixing | 21:38 |
| * beuno updates it to 2.2.8 | 21:39 | |
| barry | beuno: wanna do some screen shot ui reviews? | 21:41 |
| beuno | barry, sure | 21:42 |
| barry | beuno: excellent. coming up | 21:42 |
| barry | beuno: the following urls have screenshots. note that the +all pages are the new ones | 21:45 |
| barry | http://devpad.canonical.com/~barry/projectgroups-index.png | 21:46 |
| barry | http://devpad.canonical.com/~barry/projectgroups-all.png | 21:46 |
| barry | http://devpad.canonical.com/~barry/projects-index.png | 21:46 |
| barry | http://devpad.canonical.com/~barry/projects-all.png | 21:46 |
| barry | http://devpad.canonical.com/~barry/sprints-index.png | 21:46 |
| barry | http://devpad.canonical.com/~barry/sprints-all.png | 21:46 |
| * beuno loos | 21:46 | |
| barry | beuno: EOT | 21:46 |
| beuno | matsubara, ping | 21:52 |
| matsubara | hi beuno | 21:52 |
| beuno | matsubara, hi | 21:52 |
| matsubara | how can I help you? | 21:52 |
| beuno | I wanted to ask you about the impact of doing something on every page load | 21:52 |
| beuno | config.launchpad.beta_testers_redirection_host is not None and self.isBetaUser) | 21:52 |
| matsubara | beuno, I'm not sure about the impact of those. I think that check is quite cheap | 21:54 |
| matsubara | beuno, what do you have in mind? | 21:56 |
| beuno | matsubara, I want to show the edge redirect message on the footer | 21:56 |
| matsubara | beuno, you mean the one shown in launchpad.net? | 21:57 |
| beuno | barry, the only comment I have is that maybe the sprint dates could say "$fromdate to $todate" | 21:57 |
| matsubara | beuno, I did something similar for the oops timeout error page which is javascript only | 21:57 |
| Ursinha | rockstar, I think buildbot didn't like your branch | 21:57 |
| beuno | barry, istead of $from - $to | 21:57 |
| Ursinha | rockstar, but it seems a bzr hiccup | 21:57 |
| beuno | matsubara, shown for betatesters, yes | 21:58 |
| barry | beuno: i could try to clean that up, but i don't know where that's set (i.e. not in code i touched). thanks, and let's see if i can fix that | 21:58 |
| beuno | barry, ui=beuno | 21:58 |
| barry | thx! | 21:58 |
| matsubara | beuno, cool. see launchpad-requestexpired.pt for the js only I used in the timeout oops template | 21:59 |
| beuno | matsubara, it doesn't have a @cachedproperty around it | 21:59 |
| beuno | matsubara, this is not so much about the js, as it is on adding that call to every page load | 22:00 |
| barry | beuno: easy peasy. done. | 22:00 |
| === thumper-zzz is now known as thumper | ||
| beuno | barry, bring that count down then! | 22:01 |
| barry | beuno: i need a code review which looks like it'll have to wait until tomorrow :( | 22:01 |
| === salgado is now known as salgado-afk | ||
| beuno | matsubara, so, would you say it's OK to do the change? | 22:11 |
| beuno | I don't want to add 200ms to every page load :) | 22:11 |
| matsubara | beuno, you can always remove it if it does :-) | 22:13 |
| beuno | matsubara, how do I find out if I did? | 22:14 |
| matsubara | beuno, but I don't understand why it would be useful to have that on all page loads? do people want to leave the beta site as often as that? | 22:14 |
| beuno | matsubara, well, yes and no | 22:14 |
| beuno | we have a request from a super special stakeholder to move that to the footer on the homepage | 22:15 |
| matsubara | perhaps we could have a way to disable/enable edge's redirect for longer than 2h | 22:15 |
| beuno | my thought is, if I'm going to do that, I may as well be consistent | 22:15 |
| matsubara | I see | 22:17 |
| matsubara | beuno, I think that people already complain that LP is slow and adding more stuff to all page loads, that won't really benefit everyone is not a such a good idea, IMHO. | 22:19 |
| beuno | matsubara, I feel the same | 22:19 |
| barry | okay, i'm off to give my lazr.restful talk for real this time! | 22:19 |
| matsubara | beuno, and the best person to discuss this is mars as he was working on profiling LP pages, IIRC | 22:21 |
| beuno | :/ | 22:22 |
| beuno | matsubara, kiko seems to think we already do that check | 22:22 |
| beuno | is there anyway we can measure this? | 22:22 |
| beuno | can you help me? :) | 22:22 |
| matsubara | beuno, I'll look into it and get back to you tomorrow. I don't know from the top of my head if/how to measure that | 22:23 |
| matsubara | hmmm | 22:24 |
| matsubara | actually there's a way | 22:24 |
| matsubara | the ++oops++ page tim implemented a few cycles ago | 22:24 |
| matsubara | anyway, thinking out loud. I'll investigate and get back to you | 22:26 |
| jml | good morning | 22:27 |
| kfogel | jml: hey! | 22:29 |
| jml | kfogel, hello :) | 22:29 |
| lifeless | jml: hi hai | 22:29 |
| rockstar | Ursinha, has someone testfixed? | 22:30 |
| Ursinha | rockstar, nope, but gary is guiding me to do that | 22:31 |
| Ursinha | I need to learn :) | 22:31 |
| rockstar | Ursinha, okay, great. | 22:31 |
| rockstar | Ursinha, why do you think it was me specifically? | 22:31 |
| Ursinha | rockstar, it failed when trying to bzr co your branch | 22:32 |
| Ursinha | it seems | 22:32 |
| gary_poster | yeah, that's it. the cosmic rays fell on your name this time, rockstar | 22:32 |
| rockstar | gary_poster, yeah, I always land through ec2 just to be safe, so I was getting ready to throw a shit fit. :) | 22:33 |
| rockstar | gary_poster, as long as it's something spurious with failbot, I'm okay. | 22:33 |
| Ursinha | rockstar, it seems bzr co timed out | 22:33 |
| === matsubara is now known as matsubara-afk | ||
| rockstar | Ursinha, it looks like it timed out checking out devel. | 22:34 |
| gary_poster | lol | 22:34 |
| rockstar | https://lpbuildbot.canonical.com/builders/lp/builds/41/steps/bzr/logs/stdio | 22:34 |
| rockstar | Ursinha, so it looks like it had nothing to do with any of our branches. :) | 22:35 |
| Ursinha | rockstar, *whew* | 22:35 |
| Ursinha | :) | 22:35 |
| Ursinha | rockstar, yeah, I saw that | 22:35 |
| rockstar | Ursinha, someone needs to get buildbot some depends. It craps itself far too often. | 22:35 |
| rockstar | I guess that's what mwhudson signed up for. :) | 22:36 |
| mwhudson | hmmmmmmmmmmmm? | 22:37 |
| thumper | mwhudson: welcome back | 22:37 |
| mwhudson | thumper: hi | 22:37 |
| rockstar | mwhudson, I was just commenting on the fact that buildbot timed out trying to branch devel, and Ursinha has been blaming me. | 22:38 |
| mwhudson | rockstar: i see | 22:38 |
| * mwhudson will ignore all this until the email mountain is a little bit under control | 22:39 | |
| Ursinha | lol | 22:39 |
| Ursinha | hey mwhudson :) | 22:39 |
| Ursinha | rockstar, actually I was needing someone to kick buildbot :) | 22:39 |
| Ursinha | but doing that now | 22:39 |
| rockstar | mwhudson, by the way, welcome back newlywed. | 22:41 |
| mwhudson | rockstar: thanks | 22:42 |
| jml | mwhudson, hello! | 22:56 |
| jml | mwhudson, are you back? | 22:56 |
| mwhudson | jml: i am! | 22:57 |
| mwhudson | jml: it seems you are too | 22:57 |
| jml | mwhudson, welcome back! | 22:57 |
| mwhudson | jml: did you just get back today? | 22:57 |
| jml | mwhudson, yesterday | 22:57 |
| mwhudson | jml: welcome back to you too | 22:57 |
| jml | :D | 22:57 |
| mwhudson | jml: where have you been in the interim? | 22:57 |
| jml | mwhudson, Dublin, Prague, Berlin, Paris | 22:58 |
| jml | and Heathrow :P | 22:58 |
| mwhudson | jml: cool | 22:58 |
| rockstar | thumper, stand up? | 23:02 |
| thumper | yes | 23:02 |
| lifeless | jml: hows the lag? | 23:04 |
| jml | lifeless, ok ish | 23:05 |
| jml | lifeless, I woke up at 5:30am this morning :) | 23:05 |
| * mwhudson woke up at 4:50 am this morning | 23:08 | |
| lifeless | jml: heh. The wind woke me at 4 | 23:08 |
| lifeless | jml: OTOH its nearly lunchtime :) | 23:09 |
| jml | heh | 23:10 |
| wgrant | beuno: Are you touching requestexpired.pt, or just all of the other notices? | 23:12 |
| wgrant | 'cause there's a bit of inverted logic in that template. | 23:12 |
| beuno | wgrant, root-index and base-layour-macros | 23:12 |
| wgrant | beuno: Ah, damn. (bug #403863) | 23:13 |
| mup | Bug #403863: Timeout edge redirect notice logic inverted <Launchpad Foundations:New> <https://launchpad.net/bugs/403863> | 23:13 |
| beuno | wgrant, I'm way in too deep with this branch | 23:13 |
| beuno | ain't touchin that :) | 23:13 |
| rockstar | thumper, can you check and see if mars conversion table thing for code is reporting the work you've done recently? | 23:21 |
| Ursinha | hey beuno | 23:29 |
| beuno | hey Ursinha | 23:31 |
| Ursinha | hi beuno | 23:31 |
| Ursinha | I'm migrating the template of language pages, but not sure which layout to choose | 23:31 |
| Ursinha | beuno, like this one, https://translations.edge.launchpad.net/+languages/sr | 23:31 |
| Ursinha | beuno, danilo showed me a picture of a whiteboard, he said yours, https://devpad.canonical.com/~danilo/pages/language.jpg | 23:34 |
| wgrant | sinzui: So, I'm exporting structural subscriptions. Do you have time to talk a bit about that? | 23:57 |
| sinzui | I do | 23:57 |
| wgrant | sinzui: Great. | 23:58 |
| wgrant | sinzui: I'm thinking that for now the bug/blueprint levels shouldn't be exposed, since only one value is used and the rest will probably change before any others come into use. | 23:59 |
| * sinzui nods | 23:59 | |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
