/srv/irclogs.ubuntu.com/2009/09/11/#launchpad-dev.txt

mwhudsonoh, i mangled the stacked on url it seems00:00
jmlkfogel: so, from 'def prefer_recent_revs', you could instead write00:01
kfogeljml: ok, string extension all fixed00:01
jmls += ''.join(map(str, sorted(self._landings, key=lambda x: x.top_rev.revno)))00:01
kfogeljml: (blank line after class doc strings done)00:02
kfogelreading00:02
kfogeljml: nice00:02
jmlkfogel: and that would replace the for loop & function.00:02
jmlkfogel: if you prefer named functions (and We generally do, but I don't care), you can split out the lambda00:02
jmlkfogel: using 'key' is almost always faster than a cmp-based sort.00:02
kfogeljml: wait, that's not really from prefer_recent_revs, right?00:02
kfogeljml: it's from the outer  func00:03
kfogeljml: IOW, def prefer_recent_revs() would just go away00:03
jmlkfogel: I meant 'from' as in 'starting at'00:04
kfogeljml: nod00:04
jmlkfogel: but yes, you are right.00:04
kfogeljml: hmm, doing that resulted in a difference00:05
kfogeljml: let me investigate00:05
kfogeljml: oh, it reversed the order of the sort00:06
kfogeljml: note the order of a and b in prefer_recent_revs00:06
jmlkfogel: ahh, easy enough to add a negate to the key function.00:07
kfogeljml: beautiful00:07
jmlunless they are strings00:07
jmlin which case, umm...00:08
* jml learns Python again00:08
kfogeljml: they're numbres00:08
kfogeljml: they should be, anyway00:08
kfogelwait00:08
kfogelhmmm00:08
kfogeler00:08
jmlsorted(list, key=whatever, reverse=True)00:08
jmlthat's clearer anyway00:08
jmlhttp://docs.python.org/library/functions.html#sorted00:08
kfogeljml: wow, never knew about reverse=True00:08
kfogelgreat00:09
jmlkfogel: sometimes the stdlib is awesome :)00:09
kfogeljml: now there's no difference00:09
jmlcool.00:09
kfogeljml: there's another sort function elsewhere00:09
kfogelI'll see if I can do the same thing.00:09
jmlkfogel: when you're done with that can you commit & push the branch so I can take another look.00:11
kfogeljml: sure, one min00:11
jmlcheers.00:13
mwhudsonjml: in your branch that you sent to me, there are a bunch of XXXed questions in lib/devscripts/tests/test_sourcecode.py00:17
mwhudsonjml: i'm sure some of them have answers now00:17
mwhudson(like "can we rely on twisted")00:17
mwhudsonjml: can you run through and update them?00:17
kfogeljml: pushed.  UI doesn't show all revs yet, but presumably bzr has them.  r9384 is latest.00:18
kfogeljml: good advice on trivial bugs, btw (on ml)00:20
jmlkfogel: thanks00:21
jmlmwhudson, will do.00:21
jmlta :)00:21
mwhudsonjml: thanks00:21
mwhudsongosh, i know bash too well00:21
* jml is a little bit closer to my second cup of coffee00:21
jmlkfogel: more stylistic stuff coming your way00:23
jmlkfogel: # where "{X}" means "LogRevision for X" -- needs two more spaces of indent to align with the comment above00:24
jmland a blank line afterwards to sate the PEP 8 gods' thirst.00:24
jmlkfogel: don't align '=', but rather keep one space on either side.00:24
jmlkfogel: empty list is written like s = [], not s = [ ]00:24
jmlsimilarly empty dict is {} not { }00:25
kfogeljml:  reading00:25
jmlkfogel: indentation in get_ex_cons is still 2-space, should be 4-space.00:25
sinzuijml: I started writing a new linter. It uses pep9.py00:26
kfogeljml: ok, correcting, and dang it, I set the py-indent-offset var to 4, what the heck is up with that persistent 2 space then?00:26
sinzuijml: I started writing a new linter. It uses pep8.py00:26
jmlsinzui, I actually have pep8.py wired up to my emacs00:26
jmlsinzui, you don't think I _remember_ all this crap? :)00:26
jmlkfogel: blame barry's non-standard python mode :P00:26
sinzuijml: mine is wired in to gedit. I am announcing the release in two days00:26
jmlsinzui, cool.00:27
sinzuijml: I think we should abandon pylint. pyflakes + pep8 is good enough for me00:27
jmlkfogel: get_ex_cons could probably be a classmethod, rather than a top-level function00:27
kfogeljml: when you say "don't align '=', you mean for example in ContainerRevision.__str__() ?00:27
jmlsinzui, +100:27
kfogeljml: (missing " above, sorry)00:27
jmlkfogel: exactly so.00:27
kfogeljml: ok, fixing00:27
kfogeljml: but I don't have to like it :-)00:28
jmlkfogel: heh heh.00:32
jmlkfogel: in LogExCons.__init__, you assign to a local variable to no obvious effect (current_top_level_rev = None). A bug, perhaps?00:32
jmlkfogel: page_intro is really wide. Is it possible to wrap it without breaking wiki formatting?00:32
jmlkfogel: I dropped out, what was the last thing I said?00:33
kfogeljml: hunh, I made get_ex_cons() a class method, and now it produces an empty page00:33
kfogelone sec00:33
kfogeljml: last thing you said was:00:33
kfogelkfogel: page_intro is really wide. Is it possible to wrap it without breaking wiki formatting?00:33
kfogeljml: sure, I can use "\" at end of line in page_intro, right?00:34
jmlkfogel: thanks.00:34
jmlnothing got dropped the.00:34
kfogeljml: if a class method is to be used privately only, should I prefix its name with "_" ?00:34
jmlkfogel: yes, in general.00:35
jmlkfogel: but maybe I was mistaken about the classmethod thing...00:35
kfogeljml: ? no other class uses it, though it is sort of of general utility00:36
jmlkfogel: well, if it looks better, do it :)00:37
jmlkfogel: I just realized that I misinterpreted its purpose, and advised based on that bad interpretation00:37
* jml almost always uses classmethod to make factories for the class.00:37
kfogeljml: the current_top_level_rev intialization question is a deep philosophical question, actually: do we believe in "init explicitly to an invalid value" or do we believe in "don't init it if the initial value shouldn't matter" ?00:38
kfogeljml: I don't care which the answer is; if it's 2, I'll do 2.00:38
kfogeljml: re the get_ex_cons() thing: I think on balance top-level method feels a bit more right, so I'm going to uncommit that.  Not that it's a big deal either way.00:39
jmlkfogel: cool.00:40
kfogeljml: how about the init question?00:40
jmlkfogel: it's a post-2nd-coffee question.00:41
kfogeljml: there I have consulted with dusty tomes in Greek and Latin, and still find no certain answer.  I rely on your wisdom.00:41
jmlkfogel: I tend to prefer instantiating actual honest-to-goodness objects.00:41
kfogeljml: mmm, good point -- the initialization misleads as to the expected type00:42
kfogeljml: but I don't have an object yet00:42
jmlsec.00:43
* kfogel waits for the caffeine to reach jml's capillaries00:43
jmlkfogel: this is how I would do the string building stuff: http://pastebin.ubuntu.com/268841/00:44
* jml now turns to current_top_level_rev...00:44
jmlkfogel: ahh, right.00:45
jmlkfogel: set it to None.00:45
kfogeljml: thx, I didn't know about string.extend()00:45
jmlkfogel: it's list.extend00:45
jmlkfogel: what it's doing is building a list of lines.00:45
kfogeld'oh, sorry00:45
jmlkfogel: and then joining those lines together with '\n' as a separator.00:46
kfogeljml: I think I'm going to rename that var from "s" so as not to confuse anymore00:46
kfogeljml: one sec while I make everyone do that00:46
kfogeljml: (I think it's worth it; good habits now == easier reviews later)00:46
jmlkfogel: maybe even to something that actually means something about the problem domain? :)00:46
jmlkfogel: ok, while you do that, I'll make a coffee. :)00:46
kfogeljml: fwiw, my natural emacs indentation does not put the first " four spaces after the column of the [ above it, in this new list/string universe.00:47
kfogelsorry00:48
kfogelI mean00:48
kfogelit does not put it right under the [, but instead under the =00:48
kfogelI wonder if that is due to some indentation var still set to 200:48
* kfogel looks00:48
kfogelyup00:48
kfogelpy-indent-offset got reset to 200:48
kfogeldunno what's up with that; I'm just going to fix it in the vars line for the file00:48
kfogel(and deal with my .emacs later -- it has to be compatible with many projects, not just lp)00:49
jmlkfogel: emacs should be better at per-project configuration00:55
jmlkfogel: ok, so... where are we.00:55
kfogeljml: I'm still transforming the list/string stuff00:55
kfogeljml: interesting; when I have only one elt, I can still use .extend()00:56
jmlkfogel: yeah. it's just joining one list onto the end of another00:58
kfogeljml: yeah, just interesting that it will also join an elt -- i.e., won't create a terminal cdr, as (some) lisps might.00:58
barrybac: done to 10 failures00:59
jmlkfogel: can you give an example?00:59
mwhudsonkfogel: python lists are lisp vectors, not lisp lists01:00
kfogelmwhudson: thx01:00
mwhudson(gosh, brain fade, lisp does call 1-d arrays vectors, right?)01:00
kfogelmwhudson: I think so01:00
jmlkfogel: btw, you should have your name and the date in XXX comments01:04
kfogeljml: "XXX: Karl Fogel 2009-09-10: ..." ?01:05
kfogeljml: (trying to make you a lisp example, but it's back-burner)01:05
jmlkfogel: yeah. thanks.01:05
jmlI guess you are supposed to use WikiName...01:05
kfogeljml: really?01:05
kfogeljml: ok01:06
jmlbut I couldn't possibly force someone else to do that, given I dislike it and there's no actual reason.01:06
kfogeljml: ok :-)01:06
kfogeljml: anything else?01:07
kfogeljml: branch pushed again, to r938801:07
jmlkfogel: alpha-sort imports, blank line between stdlib imports and bzr imports. barry has an elisp thingy to do this for you on EmacsTips01:08
barrykfogel: if you grab the latest python-mode.el, C-c C-f is bound to py-sort-imports01:09
kfogelbarry:  it only works on multiline imports01:11
jml:(01:11
kfogelbarry: gets an "unbalanced parentheses" error for me01:11
kfogelsame from EmacsTips01:11
kfogeljml: is this right:01:11
kfogelimport getopt01:11
kfogelimport re01:11
kfogelimport sys01:11
kfogelfrom bzrlib.branch import Branch01:11
kfogelfrom bzrlib import log01:11
kfogelfrom bzrlib.osutils import format_date01:11
barrykfogel: yeah, it looks for names inside parens01:11
kfogelor should bzrlib be first?01:11
* mwhudson still needs to write something/figure out how to drive ropemacs to do the import statements automatically01:12
jmlkfogel: bzrlib first01:12
kfogeland sorted within that?01:12
jmlmwhudson, please please please.01:12
jmlkfogel: I don't understand.01:12
kfogeljml: I can think about about three different ways that might be Right.01:12
kfogelwant to just paste what the right way is?01:12
mwhudsonjml: after filtering those questions, can you commit and push?01:12
jmlyeah, ok.01:12
jmlmwhudson, yes, I will.01:12
mwhudsonthank you01:13
kfogeljml: there are 3 bzrlib lines; what order should they be in?  (granted that they come before the other imports)01:13
jmlmwhudson, this review is consuming all of my mental bandwidth right now01:13
kfogelmwhudson: he's mine, don't touch him01:13
mwhudsonjml: ok01:13
jmlthe slowness and unreliability of my internet connection is not helping...01:14
jmlkfogel: http://paste.ubuntu.com/268852/01:15
kfogeljml: thx01:15
jmlkfogel: don't use has_key01:16
kfogeljml: committed and pushed (r9389)01:16
kfogeldang it :-)01:16
kfogeljml: ok01:16
jmlyou want... umm...01:16
kfogeljml: 'in' ?01:17
kfogeljml: btw, why not use has_key()01:17
kfogel?01:17
jmlec = all_ex_cons.get(a, None)01:17
kfogeljml: ok, wait a sec01:17
kfogelHow is that better?01:17
kfogelIMHO it's worse, in terms of communicating what we're doing there.01:17
jmlif ec is None:\n    ec = ExCon(a); all_ex_cons[a] = ec01:17
jmlwell, you can do the if a in all_ex_cons01:17
jmlhas_key is deprecated, and won't be in future versions of python01:18
kfogelah01:18
jmleither use 'get' or 'in'.01:18
jmlI tend to lean to leap-before-you-look (hence the get), but both are appropriate here.01:19
kfogeljml: I'll wait for moer comments before pushing again01:19
kfogel(or for EOT)01:19
jmlkfogel: last thing01:20
kfogel?01:20
jmlkfogel: dict colon alignment is kind of like = alignment01:20
kfogelah01:20
jmlkfogel: {a: b, c: d, ...}01:20
kfogeljml: in main(), right?01:21
kfogeljml: any other places?01:21
jmlkfogel: no, just main01:22
kfogeljml: pushed to r939101:22
jmlkfogel: thanks.01:22
jmlkfogel: please merge it.01:23
kfogeljml: thank you for the thorough review01:23
jmlkfogel: np.01:23
jmlkfogel: are we going to have that phone call?01:24
kfogeljml: bzr pqm-submit -m "[r=jml][ui=none] Add utilities/community-contributions.py script, for updating https://dev.launchpad.net/Contributions."01:25
kfogel?01:25
kfogeljml: on second thought, leaving out the latter half, as the script already says that.01:25
kfogel(and if it ever changes, the script will change)01:25
jmlheh01:26
jmlsure.01:26
kfogeljml: submitted!01:29
kfogeljml: are you seeing my priv msgs?01:33
jmlsorry01:34
jmlI have dodgy internet01:34
kfogelnp01:36
kfogelintellectronica: hey, what's diff btw a welcome msg and a topic?01:56
intellectronicakfogel: a welcome message is sent to you once and can have more than one line01:58
intellectronicai don't remember seeing them on freenode, though, so maybe you can't use them01:58
kfogelintellectronica: well, it's important that the msg be re-gettable anyway, which /topic is01:58
kfogelintellectronica: so i think maybe topic is better anyway?01:58
kfogelintellectronica: I type "/topic" all the time in here, and in other channels.01:59
kfogelintellectronica: (I mean to read the topic, not to change it)01:59
intellectronicakfogel: fair enough. i don't rely on it as much, but that's hardly statistically significant02:00
kfogelintellectronica: my use is not be statistically significant either; so hard to get real data, unless Freenode chooses to share with us :-).02:00
intellectronicaindeed02:04
intellectronicaanyway...02:05
* intellectronica goes to dream in ascii art02:05
* jml more coffee & more toast, then mwh-related branches.02:09
* mwhudson lunches02:10
jmlfwiw, my internet connection today is really crappy, so please forgive my occasional lapses.02:22
jmlmwhudson, I've filtered those questions.02:26
mwhudsonjml: thanks02:38
jmlmwhudson, you aren't in #launchpad-reviews, I take it.02:44
=== abentley1 is now known as abentley
jmlinternet hates me05:37
jmlx hates me05:37
jtvjml: we don't hate you though05:38
jtv(Insert your favorite snide follow-up here)05:39
jmlit's entirely possible that firefox hates me most of all05:40
jtvwouldn't put it past it05:40
jtvjml: is it perhaps time to get to the root cause of all this hatred?05:41
jtvface it, with all the variables, the only constant is you.05:41
* jml bravely launches firefox again06:03
jmlmwhudson, hi06:28
mwhudsonjml: hello06:28
jmlmwhudson, I've pushed up my changes to that branch06:28
* mwhudson tests his ec2test-hackery branch on itself06:28
jmlmwhudson, how have things gone with you?06:28
jml(sorry, it's been a very distracty day)06:29
mwhudsonjml: i have moved some code around in ec2test06:29
mwhudsonjml: yeah, no worries06:29
jmlmwhudson, yay06:29
jmlI guess I'll resubmit the mp or something06:29
mwhudsonjml: specifically, the connect_as_user methods now return something rather than mutating instance state06:29
mwhudsonjml: and the code to make a unix user is on instance now06:29
jmlsoooo happy06:30
mwhudsonyeah, it's very much an improvement06:30
mwhudsonoh heavens06:30
jmlmwhudson, I really wanted to do that, but couldn't quite see how, at the time.06:30
jmlmwhudson, https://code.edge.launchpad.net/~jml/launchpad/better-sourcecode-update/+merge/1158006:30
* jml also wants to review all of maxb's recent branches.06:31
jmloh man.06:31
jmland my computer crashed / hanged before I could submit that other one, I think.06:31
mwhudsonjml: boto seems to import hashlib06:32
jmlmwhudson, why is this a problem?06:32
mwhudsonjml: does ec2test work with python 2.4 at all?06:32
jmlmwhudson, yeah, I think so.06:33
jmlbut maybe I'm wrong06:33
* jml files https://bugs.edge.launchpad.net/launchpad-foundations/+bug/42770306:35
ubot3Malone bug 427703 in launchpad-foundations "Way to see which branches I'm testing with ec2test right now" [Undecided,New]06:35
jmlok06:48
jmllet's see if my computer will stay up long enough for this to work.06:49
jmlthe ohloh import is up to phase 3!07:06
jmlStep 3 of 3: Counting lines of source code (Running 4875/66451)07:06
mwhudsonjml: cool07:09
jmlmwhudson, were you planning on reviewing the better-sourcecode-update branch today?07:31
jmldidrocks, wuuu.07:31
didrocks:)07:31
didrocksok, I'm trying to checkout it in intrepid07:31
jmldidrocks, the secret page is https://dev.launchpad.net/Getting07:32
jmldidrocks, getting a Launchpad dev environment up and running is not as easy as it should be.07:32
didrocksyes, I already read this "secret" page :)07:32
didrocksok, trying it right now07:32
mwhudsonjml: yeah, i'll try07:32
jmlmwhudson, cool. thanks.07:33
didrocksok, bzr doesn't know the format, let me have a look at the bzr ppa for intrepid07:33
mwhudsonjml: done07:38
jmlmwhudson, hanks.07:39
didrocksjml: Hum, it will definitevely broke my intrepid server if I accept a "Score is -9863" :)07:40
didrocksjml: Well, I will be able to do it from home, can you drop me some instructions so that I can start on it?07:40
jmldidrocks, ok. that sucks.07:41
jmldidrocks, sure. have you filed a bug for it yet?07:41
didrocksno, I'm doing it right now07:41
didrocksjml: against launchpadlib, right?07:41
jmlhttps://bugs.edge.launchpad.net/launchpad-registry/+bug/38987207:41
ubot3Malone bug 389872 in launchpad-registry "GPG keys not exposed in API" [Low,Triaged]07:41
didrocksok, it already exist, great :)07:42
jmldidrocks, I'll make some comments there.07:42
didrocksjml: thanks, and I try to assign it to myself :)07:42
jml:)07:42
jmldidrocks, done07:59
didrocksjml: yes, I'm assigning the bug to myself. I hope it will be a little more clear when seeing the code. Thanks :)08:02
jmldidrocks, np.08:02
jmldidrocks, good luck!08:02
didrocksjml: thanks! I will certainly ping you :)08:02
jmldidrocks, note that I'm in Australia for the next week and a bit, so you may find timezones to be a problem.08:03
jmldidrocks, people in this channel will gladly help you though, if I'm not around.08:03
didrocksjml: ok, I'll just ask here. Enjoy Australia :)08:04
* mwhudson eods08:15
jmlmwhudson, have a good weekend.08:16
mwhudsonjml: well i'm working tomorrow...08:16
jmlmwhudson, oops08:16
jmlmwhudson, have a good evening then :)08:16
mwhudson(swap day for later in the year, so i'm not that upset about it...)08:18
adeuringgood morning08:32
xaverhi i have trouble with launchpad repo. the download start with 900-1200 kb/s and slow down to 1000-3000 B/s09:19
xaverhi09:19
mrevellGuten morgen09:20
xaveri have trouble with launchpad repo. the download start with 900-1200 kb/s and slow down to 1000-3000 B/s (kann auch deutsch schreiben)09:20
xaver^^09:20
mrevellxaver: Sorry, that's the limit of my German :) What are you downloading? Launchpad itself or something from a PPA?09:22
xaverppa09:22
xaveri have no idear why09:22
xaverat home everything run fine09:23
noodles775xaver: kommisch - ist es genau so für anderer PPAs?09:24
xaveris nur bei ppa -> andere sidn kein problem nur die paketquelle09:24
xavernervig ist es bei großen files, keline da starte ich neu und shcon sind die da aber 30 mb aufwärts ist es müll09:25
jmlmrevell hello :)09:25
mrevellhi jml09:26
xaverhi09:26
noodles775xaver: hmm.. Ich habe kein problem - Ich hab jetzt ein update gemacht mit 3 ppas.09:28
xaveris immer also nicht nur heute09:28
xaverzuhause läuft es09:28
xavernur hier...09:28
noodles775bigjools: any idea why ppa's specifically would always slow down for xaver?09:28
bigjoolslocal networking issues09:29
noodles775xaver: ah, so it's probably a network issue specifically ...09:29
noodles775Yes, sounds like it, if it's specific to one location.09:29
xaverok thx09:29
noodles775np.09:29
xaverwir hängen direkt am RZ ;)09:29
bigjoolsis there a proxy in the way?09:29
bigjoolsetc.09:29
xaverno09:32
xaverwe a direct likned ion the data center09:32
xaveron09:32
xaverfrist 20 mb run with 900-1200kbs09:32
xavernext second down to 1000 b/s09:33
xaveranother question, i pack a lot of packages at home, is a good docu how i can help with packages for launchpad.... -> problem at home is my connetion very bad, but now i can upload it at work09:35
noodles775xaver: help with packages for Ubuntu? http://www.ubuntu.com/community/processes/newdev or https://wiki.ubuntu.com/UbuntuDevelopment09:37
xaveris in linux a programm for M$ exchange 2007 beside from evolution mail09:47
xaverbye reboot ;)09:59
wgrantnoodles775: Nice new archive views.10:11
noodles775wgrant: thanks! There are still a few changes to land - but it was in a landable state.10:12
noodles775wgrant: cprov is getting ready to land a simplified "Adding this PPA to your system" portlet which will mean the sources.list details are folded by default.10:12
wgrantnoodles775: Great!10:12
wgrantnoodles775: The multiple <dd>s in sequence on +packages look, IMO, much better if the non-final ones have a 'margin-bottom: 0' added.10:13
wgrantnoodles775: Otherwise there are awkward gaps.10:13
noodles775wgrant: hmm... I can't see the awkward gap... do you mean, for example, between the last dd under 'Number of packages' and the 'repository size' dt?10:16
wgrantnoodles775: The package filter on +index is set to the right distroseries by default, but the table contains packages for all seires. Is that known?10:16
wgrantnoodles775: Between the binary and source counts/sizes is the main one.10:16
wgrantThere's as much of a gap between those two and between the last and the following heading.10:17
maxbwoo. I just got my first ec2test email :-)10:17
* wgrant eats.10:18
noodles775wgrant: nope, first bug - (actually for me the package filter is *not* being set to the correct default even though the sources.list is... :/)10:20
=== henninge_ is now known as henninge
danilosjtv: hey, around?10:48
wgrantnoodles775: You're right about it not being set by default. Firefox was just doing bad cachy things.11:03
noodles775OK, I'll fix that today.11:04
wgrantWho is behind the new DSPR index?11:09
noodles775wgrant: bigjools initially, but I think cprov-afk ended up implementing it?11:10
wgrantnoodles775: I see.11:10
bigjoolsmostly cprov in fact, the original mockup was discarded since we decided it was no good11:11
wgranthttps://edge.launchpad.net/ubuntu/+source/empathy/2.27.92-1ubuntu111:11
wgrantThe '(New)' there looks very strange and it's somewhat unobvious what it means.11:11
wgrantmaxb: Aha! Your branch was merged. Very nice.11:13
jtvHmm... why is "bzr push" transferring a hundred MB again?11:25
maxbwgrant: 1 of 6 :-)11:26
maxbno, 2 of 6 :-)11:27
* wgrant prepares the second part of PPA download counts.11:28
noodles775wgrant: great! I've left space in the PPA stats portlet for that exact reason :)11:28
bigjoolsha11:28
noodles775danilos: did you have an issue where the last object of a traversal was being traversed but not being added to request.traversed_objects? If so, can you tell me more?11:29
danilosnoodles775: yes11:30
danilosnoodles775: you just need to provide an empty Navigation implementation for your interface; see the branch you reviewed (DistroSeriesLanguage adds navigation and registers it with browser:navigation)11:30
noodles775danilos: great, thanks!11:31
danilosnoodles775: salgado has a bug about it (i.e. wants to fix it so we don't have to introduce empty, silly, navigation implementations), but I forgot the number :)11:31
noodles775danilos: np - I'm unstuck now so I'm happy :)11:32
danilosnoodles775: heh, you should be, I spent entire day trying to figure that out (it was a public holiday in Brazil :)11:32
noodles775danilos: yeah, I just spent 45mins looking at it, and mentioned it to bigjools who remembered you'd had that issue - yay (I didn't take in the comment in the MP).11:33
bigjoolsfor once I actually remembered something11:33
noodles775;)11:34
danilosbigjools: good job, here's a candy! :P11:34
* bigjools licks danilo's lollipop11:34
* jtv tries to forget what he just read11:41
mrevellLaunchpad community meet-up in London on the 28th Sept: http://blog.launchpad.net/general/launchpad-meet-up-28th-september-the-warwick-london12:01
bigjoolsmrevell: we should offer a pint to anyone who turns up!12:14
mrevellbigjools: heh, maxb would get a pint in that case :)12:15
bigjoolsmrevell: I think I'm taking my bike down on the train this time. Walking to and from county hall was a PITA12:16
=== mrevell is now known as mrevell-luncheon
bigjoolsmrevell: btw, I really think the location should be in the pub opposite the Warwick12:26
intellectronicapretty much anywhere will be better than the warwick12:29
intellectronicasorry, didn't mean to be bitchy. it's about the company, not the location12:29
=== matsubara-afk is now known as matsubara
=== kiko-afk is now known as kiko
=== cprov-afk is now known as cprov
=== mrevell-luncheon is now known as mrevell
=== thekorn_ is now known as thekorn
=== deryck_ is now known as deryck
=== matsubara is now known as matsubara-lunch
=== salgado is now known as salgado-lunch
=== gary_poster is now known as gary-away
jtvgah... why did stacking stop working in my rf!?17:23
jtvFar as I can tell, everything is in 2a.  But:17:25
jtvSource branch format does not support stacking, using format:17:25
jtv  Branch format 717:25
=== matsubara-lunch is now known as matsubara
jtvdanilos: I don't think I can land that test fix for you.  For some reason some branches will push and some won't.  :(17:27
jtvah, and as soon as I said that, this one suddenly came through...  Let's see if PQM still thinks it's a "different VCSystem."17:28
intellectronicabarry: i've got a lovely patch for you to review. removals only17:35
=== deryck is now known as deryck[lunch]
mrevellI'm off for the weekend, byeeeee17:48
=== jtv is now known as jtv-afk
jtv-afkbye mrevell!17:48
intellectronicahave a loveleee weekend everyone18:05
=== salgado-lunch is now known as salgado
=== gary-away is now known as gary_poster
=== deryck[lunch] is now known as deryck
=== danilos is now known as danilo-afk
salgadorockstar, how can we get diffs for merge proposals on launchpadlib branches? (https://code.edge.launchpad.net/~gary/launchpadlib/lp-dev-utils/+merge/11607)19:36
gary_postersalgado: I think edge updates are broken.  I asked losas about it.19:36
salgadogary_poster, I don't understand what's the relation between these.  do you mean that the script which generates diffs on edge is not running?19:39
gary_postersalgado: yeah, that's my guess19:39
rockstarsalgado, I'm not sure what you mean.19:39
* rockstar thinks gary_poster might be telling lies19:40
gary_posterrockstar: unintentionally :-)19:40
rockstargary_poster, that's a given.  :)19:40
salgadorockstar, I was thinking that the script were only configured to generate diffs for launchpad branches.  should it generate diffs for any branches?19:41
gary_posterrockstar: :-) what salgado is asking about is that my MP has been sitting around for over two hours, and I still don't have a diff.  Similarly...19:41
rockstarsalgado, if you're talking about moving diffs, abentley and I are talking about an oops on edge that may be caused by trying to get these moving diffs generated.19:41
gary_posteroh, no, my "similarly" example is now ok19:41
rockstargary_poster, ah, okay, that's unrelated to what we're talking about then.19:41
gary_posterwell, I should say, "oh, yes! my "similarly" example is ok now!"19:42
gary_posterbut anyway, rockstar, should that page have a diff?  If not, does it indicate that something is not running somewhere, maybe?  (That was my suspicion given the recent troubles)19:43
rockstargary_poster, are the branches actually different?19:43
gary_posterrockstar: yeah, added a buncha files19:43
gary_posterrockstar: maybe adds are not noticed?19:43
* gary_poster doublechecks he has not done something stupid...19:44
abentleygary_poster: The diff is not being generated because the branches are not different.19:45
gary_posterI also moved a directory19:45
gary_posterI just tried repushing19:45
abentleygary_poster: Sorry, typo on my part.19:45
gary_posteroh?19:45
abentleygary_poster: I mistyped the command to determine whether the  branches were different.19:46
gary_postergotcha19:46
rockstarabentley, https://launchpad.net/bugs/42738319:51
mupBug #427383: ValueError: No JSON object could be decoded in merge through the API <api> <oops> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/427383>19:51
ubot3Malone bug 427383 in launchpad-code "ValueError: No JSON object could be decoded in merge through the API" [Medium,Triaged]19:51
mupBug #427383: ValueError: No JSON object could be decoded in merge through the API <api> <oops> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/427383>19:51
rockstarCan we get an admin to kick ubot3?19:52
maxbubot3 has been kicked before and has come back. To get rid of it permanently, ask #ubuntu-bots20:58
ubot3maxb: Error: I am only a bot, please don't think I'm intelligent :)20:58
maxbubot3 owner20:58
ubot3This bot is owned by jussi01 - Questions about ubottu should be asked in #ubuntu-bots20:58
abentleyrockstar: I updated bzr+ssh://bazaar.launchpad.net/~abentley/launchpad/codeimport_api and it seems to be failing differently now: http://pastebin.ubuntu.com/269372/21:15
rockstarabentley, contents of the test?21:18
rockstarabentley, actually, I'll take a look at it, and send the email to the list.21:18
abentleyrockstar: You mean text of the test file?21:18
rockstarabentley, I meant the text, but don't worry about it.  I'll do some sleuthing, and if I get stuck like last time, I'll email to the list.21:19
abentleyrockstar: No point sending mail to the list if this is a trivial problem.21:19
rockstarabentley, yeah, I'm not sure what's going on.  If it isn't a trivial problem, than I'll deal with it.  You're running out of core hours.21:19
abentleyrockstar: Cool.21:20
rockstarabentley, also, I'm having a hard time finding the diffstat field in the database.21:21
abentleyrockstar: Are you looking at the Diff table?21:21
rockstarabentley, no, I didn't know there was a Diff table.  Looking now.21:21
rockstarabentley, thanks.21:22
abentleyrockstar: np21:22
mwhudsongood morning21:27
abentleymwhudson: good morning.  Forgot you were around today.21:33
abentleymwhudson: Was about to invite rockstar to stand-up.21:34
Fly-Man-And another one bites the dust ....21:39
Fly-Man-What is happening with GIT imports these days ?21:39
didrocksHey guys, I'm trying to checkout LP on mmy updated karmic, but I have an issue: http://paste.ubuntu.com/269385/21:40
rockstarabentley, let's stand then.21:41
abentleymwhudson: skype?21:41
rockstarabentley, I couldn't hear you.21:45
abentleyrockstar: So I heard.21:45
mwhudsonabentley, rockstar: few minutes, i'm still eating toast?21:46
rockstarabentley, hm, try again.  We can chat before mwhudson can join.21:47
salgadosinzui, thanks a lot for the help in converting person-index21:49
sinzuisalgado: send me the review if you do not want to break it up21:50
salgadosinzui, ok21:51
salgadosinzui, I think the email addresses in contact-details should have a whole row for itself21:52
salgadoquite often people have email addresses that are too long for the space we have there, and they will overlap with the time zone there21:52
sinzuisalgado: Maybe, it was until I tried putting timezone there21:52
sinzuisalgado: if the address is long, timezone should fall below it. The overlap was cause by the odd contact markup that I put on the side21:53
* sinzui now doubt what he said is true21:53
salgadoand I'm thinking it might be a good idea to move the openid right below the email addresses, as it's only shown when the user is looking at their own page21:53
salgadolet me test it21:54
sinzuioh, yes. I prefer that too21:54
mwhudsonabentley, rockstar: invite me now?21:55
mwhudsoni am online, whatever skype says21:56
didrockswell, reading the mailing-list, I tried to execute make schema && make, without success, unfortunately: http://paste.ubuntu.com/269395/ :/21:56
salgadosinzui, indeed, the timezone doesn't fall below emails when they're too long21:56
sinzuisalgado: So I must have been sniffing glue for lunch. Oh well. Move it to where you like, or drop it since it is on the map already21:57
salgadosinzui, I'll move it inside the two-column div, together with the rest of the stuff there21:58
salgadothe problem really is with the email address thing, that needs the whole row for itself21:58
sinzuiirc is just as long21:59
salgadobut irc, as rendered there, can be broken into multiple lines22:00
salgadosinzui, should all of our "see-all" links not have the 'Show' bit in their text anymore?22:00
sinzuiNo, I had to remove them from a lot of portlets last week per beuno and kiko22:01
sinzuisalgado: you might fix bug 386163 by accident22:02
ubot3Malone bug 386163 in launchpad-registry "Inconsistencies in contact detail labels on person page" [Low,Triaged] https://launchpad.net/bugs/38616322:02
mupBug #386163: Inconsistencies in contact detail labels on person page <Launchpad Registry:Triaged> <https://launchpad.net/bugs/386163>22:02
mupBug #386163: Inconsistencies in contact detail labels on person page <Launchpad Registry:Triaged> <https://launchpad.net/bugs/386163>22:02
mupBug #386163: Inconsistencies in contact detail labels on person page <Launchpad Registry:Triaged> <https://launchpad.net/bugs/386163>22:02
salgadosinzui, not really by accident, but I will22:04
sinzuiI see edwin fixed the irc form by accident. I'll assign it for him to close22:05
salgadosinzui, jabberids will have the same problem, but this only happens when they don't have any character (e.g. a dash) that the browser considers when breaking words22:14
salgadomaybe what we need is to output our email addresses using user-part<wbr>@host.domain?22:15
sinzuiMaybe we should consider somethi....yes22:15
* sinzui cannot remember the name of the formatter22:16
salgadooh, a formatter?22:16
barrysinzui: ping22:16
sinzuisalgado: yes there is something in tales that makes long lines wrap22:16
salgadobreak_long_words!22:16
sinzuihi barry22:16
barrysinzui: hi.  let's talk base-layout.txt22:17
sinzuiokay22:17
barryis there anything we can do other than print huge gobs of html?  it's just so fragile and very difficult to strip down the output22:18
sinzuihow to you propose we verify each element that it is required to output?22:18
rockstarabentley, upon further inspection, it looks like that's a launchpadlib error.22:18
rockstarLike it's an error in marshalling an object to rest.22:19
barrysinzui: well, let's think about it.  i guess we don't have id's for the really essential bits do we?  and if not, should we?22:19
barryi have nothing against adding ids for testing purposes22:19
barry(we do that a lot)22:19
sinzuibarry: in the case of base layout, we are relying on it to make sane pages. so ids are not relevant22:19
barrysinzui: ids for testing purposes could make sense though22:20
sinzuigood luck putting an id in a comment22:20
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
barrysinzui: so then. we does base-layout.txt give us that other page tests don't give us indirectly?22:21
sinzuibarry: ids, will get you most of the way. You need to put parse <html> to get the whole doc22:21
rockstarmwhudson, could you look at https://lp-oops.canonical.com/oops.py/?oopsid=1348EA292 for me?22:21
rockstarmwhudson, I just need a hypothesis sanity check.22:21
sinzuibarry: ? title, scripts, styles, meta, body with classes, headers, footers, diagnostics22:22
mwhudsonrockstar: ok22:22
sinzuibarry: No test other than base layout verifies those, nor should they22:22
mwhudsonrockstar: simplejson.loads('') explodes like this, btw...22:22
barrysinzui: indirectly some of them are tested, e.g. titles22:22
barrysinzui: i'm not saying that's good, i'm just trying to boil this test down to essentials22:23
barrysinzui: as a doctest, you gotta admit, it's not readable :)22:23
rockstarmwhudson, yea, it's obvious there's a JSON issue here.  I feel like this might actually be lazr.restful not handling the blank correctly.22:23
sinzuibarry: I direct is not good enough in this case. that test is painful because base-layout is that important. add ids if you wish, and use BS to parse <html> you still need to verify doctype and comments22:24
sinzuibarry: I do not agree, because diagnosing failures in the macros was not possible without the test. You can improve the test, but I think you made changes without that test, and that is a big no no22:25
barrysinzui: well, one simple way to fix this would be to just blow away the view.render() output and paste in whatever the template outputs now.  but i wouldn't say that's a good solution.  otoh, it's not clear to me it's any worse that what it's doing now22:25
sinzuibarry: you proposed ids, I said fine, why are you backtrackin?22:26
barryi'm not.  i'm looking for options22:26
mwhudsonrockstar: hmm22:27
sinzuiI think ids are best because we do not really care about the element, except for title. In all other cases, I think we care about the atts (class, src, href, style) so...22:28
barryok.  i agree, let's go with ids22:28
barrythanks22:28
sinzuibarry:22:29
sinzui>>> print find_tag_by_id(page, 'body-tag')['class']22:29
sinzuibudy overview ponies22:29
barryyes, that's the idea22:29
sinzuibarry: I think the end comment is testing using a split, so that test will continue to work22:30
sinzuibarry: the doctype could be tested as a split on <html22:31
rockstarmwhudson, got time for a quick pre-imp call?22:31
barrysinzui: i'm not too worried about the doctype because ellipsis can ignore everything following.  ellipsis work less well the farther deep you go in the output22:32
mwhudsonrockstar: i will have after i've refilled my coffee cup, one sec22:32
barrysinzui: is it really that important to test end comments?22:32
rockstarmwhudson, that's fine.  I need you caffeinated anyway.22:32
sinzuibarry: yes, for the diagnostics at the end of the page22:33
barrysinzui: oh yes, those, but the <!-- yui-d0 --> comments?  or maybe i misunderstood what you meant22:34
sinzuibarry: and as you might guess from the the use of22:35
sinzui    >>> print content[content.index('</html>') + 7:]22:35
sinzuiI was desperate to isolate the one part I needed to fix at a late hour22:35
mwhudsonrockstar: ok22:35
barrysinzui: yep22:35
sinzuibarry: If you are using  BS you wont care because you can test containership22:35
rockstarmwhudson, "User Not Found"22:35
barrysinzui: right, that's what i think we really care about22:36
mwhudsonstupid skype22:36
sinzuibarry: agreed22:36
barrysinzui: cool, thanks.  will you be around for a while?  i may ping you to review this last change when it's ready22:36
sinzuibarry: I think I will be in an out for the next 8 hours22:37
* sinzui tries to change 38 pages before Monday22:37
barrysinzui: okay, that's cool.  if you're here and want to look, that's fine.  if not, i'm jfdi.  i'm tired of this branch and it needs to LAND! :)22:37
* barry will not sleep until this is in the tree22:38
didrockswell, my launchpad dev setup try on jaunty fails as well :/22:38
sinzuibarry: I agree. We can fix bugs next week, but we wont know about bugs if you don't land it22:38
barrysinzui: so right you are22:39
* barry hacks22:39
mwhudsonrockstar: http://pastebin.ubuntu.com/269419/22:43
mwhudson(gee thanks, postgres!)22:43
=== kiko is now known as kiko-afk
wgrantbuildbot is sad.22:52
rockstarwgrant, yeah, mwhudson said he was going to fix it, but I have a read lock on him right now.22:53
wgrantAh.22:53
mwhudsonhooray for test runs with 9 landings :/23:13
wgrantYes. It wasn't mine?23:14
mwhudsonwgrant: no23:16
mwhudsonit's a rosetta thing23:16
mwhudsonlib/lp/translations/browser/tests/translationmessage-views.txt23:16
wgrantmwhudson: Ah, great.23:17
mwhudsonseems a bit of the test that should have been deleted23:20
maxbWhen I make minor followup changes to a branch proposed for merging after comments from reviewers, should I resubmit the MP ?23:39
* mwhudson finally defeats pqm-submit for his '[testfix]23:39
wgrantmaxb: No.23:40
mwhudsonmaxb: if the changes are small, paste the diff between what was reviewed and the current state of the branch into a comment23:40
wgrantmaxb: Just reply saying that you've done it, and give the diff.23:40
mwhudsonmaxb: (we'll be fixing the workflow around this sort of thing soonish)23:40

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!