| === salgado is now known as salgado-lunch | ||
| === gary_poster is now known as gary-away | ||
| === adeuring changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,shipit || queue: [] | ||
| === matsubara-lunch is now known as matsubara | ||
| === deryck is now known as deryck[lunch] | ||
| === sinzui changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,shipit || queue: [sinzui] | ||
| sinzui | adeuring: salgado-lunch: My MP will arrive shortly. I need to take a lunch to my daughter, I'll be away about an hour | 17:41 |
|---|---|---|
| adeuring | sinzui: I'm a bit worn-out (18:40 local time)... salgado-lunch, can you take it? | 17:42 |
| sinzui | adeuring: thanks. I am sure you are worn from all the small things in my last branch | 17:43 |
| adeuring | sinzui: ;) | 17:43 |
| sinzui | Barry may be available in a few hours | 17:43 |
| === jtv is now known as jtv-afk | ||
| === salgado-lunch is now known as salgado | ||
| salgado | adeuring, sinzui, sure, I'll take it | 18:06 |
| === salgado changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,sinzui || queue: [] | ||
| === adeuring changed the topic of #launchpad-reviews to: on call: salgado || reviewing: sinzui || queue: [] | ||
| === gary-away is now known as gary_poster | ||
| gary_poster | salgado: adding https://code.edge.launchpad.net/~gary/launchpadlib/lp-dev-utils/+merge/11607 to your queue, if that's ok. | 18:28 |
| === gary_poster changed the topic of #launchpad-reviews to: on call: salgado || reviewing: sinzui || queue: [gary] | ||
| * gary_poster is being hopeful ;-) | 18:29 | |
| salgado | gary_poster, definitely. I'll get to it after sinzui's | 18:29 |
| gary_poster | thank you! | 18:29 |
| sinzui | salgado: I'm taking a look at your person branch now. | 18:31 |
| salgado | thanks sinzui | 18:31 |
| salgado | sinzui, I think the solution to my problem is in the branch I'm reviewing now | 18:35 |
| sinzui | salgado: I think so to | 18:36 |
| salgado | just put all the <dl>s inside a single div class="two-column-list" | 18:36 |
| sinzui | salgado: the dl's are conditional in one div | 18:36 |
| sinzui | salgado: +1 | 18:36 |
| sinzui | salgado: note that the really long items are not in the div | 18:36 |
| salgado | yeah, that's what I initially did to the email addresses in that contact-details portlet | 18:37 |
| === deryck[lunch] is now known as deryck | ||
| sinzui | salgado: I am moving the Contact this user in to the action menu. I think Edwin already reported a bug about this. | 19:06 |
| salgado | sinzui, is it not a problem that the link text might be really long? | 19:07 |
| salgado | in some cases, that is | 19:07 |
| sinzui | hmm | 19:07 |
| sinzui | right | 19:07 |
| salgado | I guess it's only really long when you're contacting a team | 19:08 |
| sinzui | indeed, that was edwin's concern | 19:08 |
| sinzui | salgado: person-portlet-contact-details.pt is not used by team. | 19:10 |
| === danilos is now known as danilo-afk | ||
| salgado | right, but it'd be nice to be consistent about where we put the link to contact people/teams | 19:11 |
| salgado | although we're not consistent about plenty of other things there, so there's no need to worry about this | 19:12 |
| salgado | 664+ tal:define="when python: bugtask.date_closed or | 19:18 |
| salgado | 665+ bugtask.date_fix_committed or | 19:18 |
| salgado | 666+ bugtask.date_inprogress or | 19:18 |
| salgado | 667+ bugtask.date_left_new" | 19:18 |
| salgado | sinzui, how about turning that (^) into an IBugTask property? :) | 19:18 |
| sinzui | oh, I forgot about that hack | 19:18 |
| sinzui | salgado: I was contemplating adding it to the decorated bugtask that is used for prenstation in lists | 19:19 |
| salgado | yeah, that sounds better | 19:20 |
| sinzui | salgado: *I* want that there, no user as ever asked for this feature | 19:20 |
| sinzui | I'll update the decorator class in a short while. | 19:20 |
| sinzui | salgado: the best this about this new design is that the map does not fit in columns when the browser is set at 1027 wide. | 19:21 |
| salgado | sinzui, why is that a good thing? | 19:22 |
| sinzui | I cannot put the map in a column near the top of the page ;) | 19:23 |
| sinzui | I do think the timezone should be near the email address though | 19:23 |
| salgado | where it used to be in 1.0 | 19:25 |
| === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [] | ||
| gary_poster | salgado: adding another one to queue. You'll like this one: three lines changed, and our make run is no longer overwhelmed with zc.zservertracelog blather: https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11618 | 19:51 |
| sinzui | salgado: I have some improvement for your branch. I am tempted to make some changes to the working on section. Do you have any uncommitted work on that portlet? | 19:52 |
| === gary_poster changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [gary] | ||
| salgado | sinzui, nope | 19:52 |
| salgado | gary_poster, is that to compensate for the 1500 lines diff of the other branch? ;) | 19:54 |
| salgado | maybe that's why the MP has no diff -- it's above the limit (800 lines) so the script doesn't even bother generating it | 19:55 |
| gary_poster | salgado: lol, yeah I guess so. I hope you don't feel like you have to review that all, though: it is just moving files from lp-dev-utils that have already been reviewed | 19:55 |
| gary_poster | salgado: no, I, um, have, ah, been over the 800 line limit once or twice before. :-) | 19:56 |
| gary_poster | and the diffs showed up | 19:56 |
| salgado | yeah, I was just kidding | 19:56 |
| gary_poster | :-) my branches tend to get big sometimes :-/ | 19:56 |
| salgado | you're not alone there | 19:58 |
| salgado | I have one which was at nearly 1000 lines when I sent to sinzui, and he's been doing lots of changes in it, so I imagine it will come back to me a lot bigger | 19:59 |
| gary_poster | heh | 19:59 |
| === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [] | ||
| sinzui | salgado: I will happily review it | 19:59 |
| salgado | gary_poster, anyway, r=me on the first one | 19:59 |
| gary_poster | salgado: actually, the diff for https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11618 looks odd | 20:00 |
| gary_poster | I didn't make those changes :-/ | 20:00 |
| gary_poster | That diff should only have the .conf changes | 20:00 |
| gary_poster | doublechecking | 20:00 |
| salgado | to me it looks big | 20:00 |
| salgado | huge, actually | 20:01 |
| gary_poster | Yeah it should be three lines like I said :-/ | 20:01 |
| salgado | let me try merging the branch | 20:01 |
| gary_poster | ok. This is what I expected: | 20:02 |
| gary_poster | https://pastebin.canonical.com/22049/ | 20:02 |
| gary_poster | salgado: ah-ha | 20:02 |
| gary_poster | salgado: I forgot to change the merge target | 20:02 |
| salgado | oh, right, it's targeted to db-devel | 20:03 |
| gary_poster | should be devel not db-devel | 20:03 |
| gary_poster | right | 20:03 |
| gary_poster | sorry about that | 20:03 |
| salgado | no worries | 20:03 |
| salgado | r=me on that too | 20:03 |
| === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: - || queue: [] | ||
| gary_poster | cool thanks :-) | 20:03 |
| salgado | gary_poster, I didn't notice it was against db-devel because the UI says it's against "lp:launchpad", but that's because we have db-devel configured as the development focus | 20:04 |
| gary_poster | right, me too | 20:04 |
| salgado | when devel was the development focus, it was obvious when a BMP's target was db-devel | 20:05 |
| gary_poster | and you had to make an explicit gesture for the unusual thing, while the usual thing was the default. that was nice. ;-) | 20:05 |
| salgado | indeed | 20:06 |
| salgado | gary_poster, but if you use 'bzr send' it should always create BMPs against devel, no? | 20:07 |
| salgado | at least that's what it does for me | 20:07 |
| gary_poster | salgado: ah, I have not yet migrated to that new wonderfulness. I do it through the web right now. I should probably look up how to set that up... | 20:08 |
| gary_poster | (through the browser I mean, of course) | 20:08 |
| salgado | you should -- bzr send works great | 20:09 |
| gary_poster | ok cool | 20:09 |
| gary_poster | salgado: you hadn't officially approved the merge into db-devel so I took the liberty of deleting the MP and creating a correct one to devel: https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11623 . If you want to approve now, the diff is now much more sane ;-) | 20:41 |
| salgado | that looks like something I'd approve. :) | 20:42 |
| gary_poster | heh | 20:42 |
| salgado | done | 20:42 |
| gary_poster | thanks | 20:42 |
| === salgado changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] | ||
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!