=== salgado is now known as salgado-lunch === gary_poster is now known as gary-away === adeuring changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,shipit || queue: [] === matsubara-lunch is now known as matsubara === deryck is now known as deryck[lunch] === sinzui changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,shipit || queue: [sinzui] [17:41] adeuring: salgado-lunch: My MP will arrive shortly. I need to take a lunch to my daughter, I'll be away about an hour [17:42] sinzui: I'm a bit worn-out (18:40 local time)... salgado-lunch, can you take it? [17:43] adeuring: thanks. I am sure you are worn from all the small things in my last branch [17:43] sinzui: ;) [17:43] Barry may be available in a few hours === jtv is now known as jtv-afk === salgado-lunch is now known as salgado [18:06] adeuring, sinzui, sure, I'll take it === salgado changed the topic of #launchpad-reviews to: on call: adeuring,salgado || reviewing: - ,sinzui || queue: [] === adeuring changed the topic of #launchpad-reviews to: on call: salgado || reviewing: sinzui || queue: [] === gary-away is now known as gary_poster [18:28] salgado: adding https://code.edge.launchpad.net/~gary/launchpadlib/lp-dev-utils/+merge/11607 to your queue, if that's ok. === gary_poster changed the topic of #launchpad-reviews to: on call: salgado || reviewing: sinzui || queue: [gary] [18:29] * gary_poster is being hopeful ;-) [18:29] gary_poster, definitely. I'll get to it after sinzui's [18:29] thank you! [18:31] salgado: I'm taking a look at your person branch now. [18:31] thanks sinzui [18:35] sinzui, I think the solution to my problem is in the branch I'm reviewing now [18:36] salgado: I think so to [18:36] just put all the

s inside a single div class="two-column-list" [18:36] salgado: the dl's are conditional in one div [18:36] salgado: +1 [18:36] salgado: note that the really long items are not in the div [18:37] yeah, that's what I initially did to the email addresses in that contact-details portlet === deryck[lunch] is now known as deryck [19:06] salgado: I am moving the Contact this user in to the action menu. I think Edwin already reported a bug about this. [19:07] sinzui, is it not a problem that the link text might be really long? [19:07] in some cases, that is [19:07] hmm [19:07] right [19:08] I guess it's only really long when you're contacting a team [19:08] indeed, that was edwin's concern [19:10] salgado: person-portlet-contact-details.pt is not used by team. === danilos is now known as danilo-afk [19:11] right, but it'd be nice to be consistent about where we put the link to contact people/teams [19:12] although we're not consistent about plenty of other things there, so there's no need to worry about this [19:18] 664 + tal:define="when python: bugtask.date_closed or [19:18] 665 + bugtask.date_fix_committed or [19:18] 666 + bugtask.date_inprogress or [19:18] 667 + bugtask.date_left_new" [19:18] sinzui, how about turning that (^) into an IBugTask property? :) [19:18] oh, I forgot about that hack [19:19] salgado: I was contemplating adding it to the decorated bugtask that is used for prenstation in lists [19:20] yeah, that sounds better [19:20] salgado: *I* want that there, no user as ever asked for this feature [19:20] I'll update the decorator class in a short while. [19:21] salgado: the best this about this new design is that the map does not fit in columns when the browser is set at 1027 wide. [19:22] sinzui, why is that a good thing? [19:23] I cannot put the map in a column near the top of the page ;) [19:23] I do think the timezone should be near the email address though [19:25] where it used to be in 1.0 === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [] [19:51] salgado: adding another one to queue. You'll like this one: three lines changed, and our make run is no longer overwhelmed with zc.zservertracelog blather: https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11618 [19:52] salgado: I have some improvement for your branch. I am tempted to make some changes to the working on section. Do you have any uncommitted work on that portlet? === gary_poster changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [gary] [19:52] sinzui, nope [19:54] gary_poster, is that to compensate for the 1500 lines diff of the other branch? ;) [19:55] maybe that's why the MP has no diff -- it's above the limit (800 lines) so the script doesn't even bother generating it [19:55] salgado: lol, yeah I guess so. I hope you don't feel like you have to review that all, though: it is just moving files from lp-dev-utils that have already been reviewed [19:56] salgado: no, I, um, have, ah, been over the 800 line limit once or twice before. :-) [19:56] and the diffs showed up [19:56] yeah, I was just kidding [19:56] :-) my branches tend to get big sometimes :-/ [19:58] you're not alone there [19:59] I have one which was at nearly 1000 lines when I sent to sinzui, and he's been doing lots of changes in it, so I imagine it will come back to me a lot bigger [19:59] heh === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: gary || queue: [] [19:59] salgado: I will happily review it [19:59] gary_poster, anyway, r=me on the first one [20:00] salgado: actually, the diff for https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11618 looks odd [20:00] I didn't make those changes :-/ [20:00] That diff should only have the .conf changes [20:00] doublechecking [20:00] to me it looks big [20:01] huge, actually [20:01] Yeah it should be three lines like I said :-/ [20:01] let me try merging the branch [20:02] ok. This is what I expected: [20:02] https://pastebin.canonical.com/22049/ [20:02] salgado: ah-ha [20:02] salgado: I forgot to change the merge target [20:03] oh, right, it's targeted to db-devel [20:03] should be devel not db-devel [20:03] right [20:03] sorry about that [20:03] no worries [20:03] r=me on that too === salgado changed the topic of #launchpad-reviews to: on call: salgado || reviewing: - || queue: [] [20:03] cool thanks :-) [20:04] gary_poster, I didn't notice it was against db-devel because the UI says it's against "lp:launchpad", but that's because we have db-devel configured as the development focus [20:04] right, me too [20:05] when devel was the development focus, it was obvious when a BMP's target was db-devel [20:05] and you had to make an explicit gesture for the unusual thing, while the usual thing was the default. that was nice. ;-) [20:06] indeed [20:07] gary_poster, but if you use 'bzr send' it should always create BMPs against devel, no? [20:07] at least that's what it does for me [20:08] salgado: ah, I have not yet migrated to that new wonderfulness. I do it through the web right now. I should probably look up how to set that up... [20:08] (through the browser I mean, of course) [20:09] you should -- bzr send works great [20:09] ok cool [20:41] salgado: you hadn't officially approved the merge into db-devel so I took the liberty of deleting the MP and creating a correct one to devel: https://code.edge.launchpad.net/~gary/launchpad/tracelog/+merge/11623 . If you want to approve now, the diff is now much more sane ;-) [20:42] that looks like something I'd approve. :) [20:42] heh [20:42] done [20:42] thanks === salgado changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] === salgado is now known as salgado-afk === matsubara is now known as matsubara-afk