/srv/irclogs.ubuntu.com/2009/09/11/#ubuntu-motu.txt

chrisccoulsonScottK - do you know why meta-gnome2 has a comment "no need to sync" on https://merges.ubuntu.com/universe.html ?00:03
chrisccoulsoni noticed you just sponsored an upload to fix a broken dependency. some of the existing dependencies it still has are very old and things that it really shouldn't depend on00:04
sorenScottK: Thanks for the ack on python-mhash. I used python-support so that Debian would like it. :)00:45
sorenScottK: It's in the queue, ready for review. Thanks!00:45
sorenScottK: And yes, it will turn out to be server related, so you have are acting within your authority :)00:46
* soren goes to bed00:47
LaserJockScottK: good grief, this latest rebuild test is concerning. So many FTBFS00:55
micahg1how do I know what's wrong with a quilt .rej file?01:22
=== micahg1 is now known as micahg
hyperairmicahg: it's a patch reject file. it just dumps out rejected hunks.01:31
hyperairmicahg: just manually merge in the changes01:31
hyperairthe changes specified in the *.rej file i mean01:31
micahgwhat do you mean by manually merge?01:32
micahgcopy in vi?01:32
hyperairpatches basically represent changes.01:33
hyperairand applying a patch is basically making said changes automatically.01:33
hyperairbut sometimes, a patch cannot be applied due to changes in the source hunk.01:33
hyperairin this case, you have to look at the block that was supposed to be changed, and make the changes manually.01:34
micahgin the source file?01:34
hyperairyes01:34
micahgah, then I can refresh?01:34
hyperairyes01:34
micahghyperair: thank you...that's what I was missing01:34
hyperair=)01:34
micahghyperair: that did it...01:36
=== qiyong is now known as qiy
stoojDoes anyone know of a python programme that uses policy kit?03:21
=== zooko is now known as zookox
ScottKjbernard_: OK.  Then maybe it's OK.  Thanks for looking.04:14
rgreeninghey ScottK04:17
ScottKWho, me?04:18
rgreeninglol04:19
mdeslaurDoes UI freeze also apply to universe?04:38
ScottKmdeslaur: Only if there is stuff the doc team touches (there may be for mobile stuff, Ubuntu Studio, Mythbuntu, or Xubuntu).  Otherwise, no.04:39
mdeslaurthanks ScottK04:41
mdeslaurso, if I change a string in a universe package...do I need to update the po files?04:57
mdeslauroh, I guess not05:01
porthoseScottK, if you have the time, would you mind looking at bug #426677 :)05:51
ubottuLaunchpad bug 426677 in pysvn "pysvn FTBFS" [High,New] https://launchpad.net/bugs/42667705:51
ScottKporthose: Just going to bed, but from reading your comment, you don't want to symlink it from pyshared.  Move it to dist-packages.05:54
* ScottK goes to bed.05:54
* porthose goes to bed also05:56
fabrice_spLucidFox, here?06:04
* virtuald ponders getting out of bed06:09
fabrice_spLucidFox, you're upstream of qink, right? it's about qink FTBFS with libinklevel 0.8. In case you didn't noticed it, libinklevel 0.8.0 version string is "libinklevel 0.8.0" and not "libinklevel v0.8.0", so qink does not recognise it...06:09
fabrice_sp(configure script, I mean)06:10
fabrice_spAnyway, I've reported it in the upstream bug tracker06:18
dholbachgood morning06:28
fabrice_sphey dholbach!06:35
dholbachhey fabrice_sp! :)06:36
fabrice_sphow are you doing this morning?06:36
=== cjwatson_ is now known as cjwatson
=== dholbach_ is now known as dholbach
=== qiyong_ is now known as qiy
seglerplease comment on my small rhythmbox plugin: http://revu.ubuntuwire.com/p/rhythmbox-radio-browser11:26
slytherinsegler: how is this different from the already available internet radio functionality in rhythmbox?11:27
seglerit makes the lists of dir.xiph.org and shoutcast.com searchable directly from rhythmbox, screenshot on http://programmierecke.net/programmed/rhythmbox-radio-browser.html11:28
segleriradio in rhythmbox is a minimal plugin, that radio stations can be played11:29
seglerat all11:29
slytherinsegler: looks good. but at this point we are past feature freeze, so new packages won't go in (unless there is very strong reason for it). And hence you will find MOTUs busy with fixing existing bugs.11:30
seglerthanks, but maybe for the next version then11:30
ScottKsegler: Of if you work on getting it into Debian now, more users will benifit and it will automatically come into Ubuntu for the next release.11:32
slytherinsegler: As I said, it is hard to find people not already busy with other things at this stage of development cycle. New packages get best reviewed at the early stage of development cycle.11:33
segleris there also good documentation on archiving this for debian11:33
segler?11:35
directhexmentors.debian.net i think11:35
directhexbut i'd talk to pkg-multimedia11:35
directhexor maybe pkg-gnome11:35
seglerthanks11:35
slytherinI guess pkg-gnome is right group.11:35
slytherinrhythmbox is official gnome module.11:36
directhexthere's some overlap anyway11:36
directhexisn't that right, slomo11:36
=== elky` is now known as elky
=== cprov-afk is now known as cprov
* RainCT thanks bdrung for fixing audacity! :)14:07
bdrungRainCT: np14:07
=== thekorn_ is now known as thekorn
jdong*tries to remember the bzr shorthand for pushing to the pull URL*14:37
jdongunfair; totally undocumented AFAICT!14:39
ScottKjdong: bzr push :parent14:39
jdongScottK: ah! thanks14:39
RoAkSoAxmorning14:39
ScottKI suspect you're right.  I found out about it asking on #bzr.14:40
RoAkSoAxdholbach, Heya. I'll have the interview ready by the end of this weekend14:40
dholbachRoAkSoAx: ŝuper!14:40
jdongScottK: yeah I overheard something like that before, so I knew it existed just not where.14:40
Ryan52what does MIR stand for?14:41
jdongMain Inclusion Report (Request?)14:41
ScottKReport14:41
Ryan52ah, cool.14:42
Pici!mir14:42
ubottumir is Main Inclusion Report - see https://wiki.ubuntu.com/MainInclusionProcess for more information.14:42
Ryan52asac, lool: once you guys get gnome-web-photo using the glue correctly, please let me know, I've been wanting to package it for Debian but that was what was holding me back. and of course I'm curious what I was doing wrong when I tried doing it myself :)14:47
loolRyan52: Eh ok14:48
asacRyan52: libxul.m4 is bogus14:48
asaci am not sure where all those m4 files come from14:48
asacthe glue code is at least in place14:49
asacits just a matter of build system from what i can see14:49
asacis gnome-web-photo in gnome git?14:49
asacfound it14:50
ScottKFYI, http://qa.ubuntuwire.com/bugs/rcbugs/ is updated and working.  Plenty of opportunity there for fixing stuff.14:53
Laneywoop woop14:53
bddebianHeya gang14:53
ScottKHeya bddebian.14:56
ScottKbddebian: I thought you all removed all the gtk1.2 stuff already?14:57
bddebianHeya ScottK14:58
ScottKI've noticed a couple like dillo that are still there.14:58
bddebianScottK: I've tried, see:  http://wiki.debian.org/Gtk1.2ImlibGnome1Removals14:58
slytherinany rsync experts here?14:59
kimushi, ubuntu does not provide a xserver-xorg-video-ast (ASPEED). how can be created?15:07
directhexkimus, poke the ubuntu x11 guys15:12
kimusdirecthex: ok... I'll try to do that thanx15:12
quadrisprohi folks15:32
quadrisproany release manager here?15:32
quadrisprosistpoty|work: ping15:32
sistpoty|workquadrispro: what's up?15:32
asacRyan52: http://people.canonical.com/~asac/tmp/0001-use-libxul-embedding-unstable.pc-.-plain-and-simple..patch15:35
asacRyan52: thats the right approach15:35
asacnow it fails to build because gnome-web-photo uses internal symbols directly15:35
asacnamely: in Writer.cpp ... it uses gfxSurface etc.15:35
asacthat should be done by using canvas.writeDocument15:35
asacrather than directly stabbing in the inner guts of gecko ;)15:36
asaci will do a second patch for that most likely removing almost everyhting that is in Writer.cpp15:36
asacanyway. off for the weekend15:36
jbernard_ScottK: im working on updating ksplice, is there something i should do to mark that as in-progress?15:51
ScottKjbernard_: Is this an updated merge?15:52
jbernard_ScottK: you're asking if there's a newer debian version?15:53
ScottKjbernard_: Yes.  Are you updating from Debian?15:53
jbernard_ScottK: yes15:53
ScottKjbernard_: You can leave a comment on merges.ubuntu.com that you are working on it.15:53
jbernard_ScottK: awesome, im on it15:53
jbernard_ScottK: im not able to find it in the list, am i missing something?15:55
ScottKjbernard_: I agree it's not there.  Not sure why.15:57
ScottKMaybe Adri2000 knows.15:57
jbernard_ScottK: the new debian version (0.9.9-1) hit sid about two weeks ago15:57
jbernard_ScottK: ill prepare a debdiff in any case15:58
geserwhy should it appear on MoM when the ubuntu version doesn't has an Ubuntu delta?15:58
ScottKOh.  Right15:58
ScottKgeser: Thanks.15:59
ScottKjbernard_: hopefully there is no debdiff, just a sync request.15:59
* ScottK wonders off in search of more coffee15:59
jbernard_ahh, ok, no i follow15:59
jbernard_/s/no/now15:59
* jbernard_ reaches for more coffee as well15:59
RoAkSoAxhey guys is there any wikipage  that shows the process to apply debdiff and upload the packages (for MOTUs)?16:08
james_whey RoAkSoAx16:09
james_wcongratulations16:09
RoAkSoAxjames_w, thanks :)16:09
james_wapt-get source package16:09
james_wcd package-*16:09
james_wwget -O- <debdiff> | patch -p116:10
james_wI think that's right16:10
james_wnew upstream versions are different16:10
james_wor16:10
james_wbzr branch lp:ubuntu/package16:10
james_wbzr patch --strip 1 <debdiff>16:11
odehi16:11
james_wmerges require different arguments to debuild as well16:11
odei uploaded an updated version of a package to revu but it is not showing up16:11
RoAkSoAxjames_w, awesome, thanks. But isn't there a wikipage that explains everything?16:11
james_wRoAkSoAx: I've not seen one. Write one!16:12
RoAkSoAxjames_w, yeah!! will do that. I'll just gather the information needed and will setup a wikipage :)16:13
james_wnice16:13
odeif i update a package to fix some problems that revu reports should I bump the version number i.e. ubuntu1 to ubuntu2, and then upload again. Or leave it as it is?16:20
geserfor REVU you can keep (and should) it at -0ubuntu116:21
odethanks16:22
slytherinode: did you use -f option for dput?16:30
ScottKRoAkSoAx: There is one.  I don't remember where it is. (wiki page)16:31
RoAkSoAxScottK, I've been trying to search for it with no luck :S :(16:31
ScottKRoAkSoAx: OK.  As james_w said, it's just like applying a patch.  Then debuild -S -k(yourkeyid/email...).  The dput like you would to a PPA, but to ubuntu.16:32
odeslytherin: yeah I did but I think I made an error with the version number16:33
odei'll fix and try again16:33
RoAkSoAxScottK, that's the same process for any kind of debdiff (which can be a merge debdiff or a bugfix debdiff)?16:34
ScottKRoAkSoAx: Yes, unless there is a new upstream release involved.16:34
RoAkSoAxScottK, and how are new upstream releases dealt?16:34
ScottKThen if you have the tarball, you need to add -sa to debuild.16:34
RoAkSoAxI see, I always build my packages both ways so it's ok16:35
ScottKYou should fetch the tarball from upstream yourself and then take the sponsoree's diff.gz and apply it (decompress and apply as a patch)16:35
ScottKOne of the key security principles is that we 'trust' upstream code, so you need to take the upstream code from upstream and not assume a non-developer has given it to you untampered.16:36
ScottKRoAkSoAx: ^^16:36
RoAkSoAxScottK, awesome! Thanks :)!16:38
ScottKRoAkSoAx: I also recall having approximately the same questions when I made MOTU two years ago.16:39
RoAkSoAxScottK, haha. Yeah, these are exciting moments :)16:40
iulianRoAkSoAx: You might find https://wiki.ubuntu.com/MOTU/New useful.16:53
RoAkSoAxthanks iulian :)16:53
ScottKiulian: That's the page I was thinking of.  Thanks.16:54
iulianNo problem.16:57
iulianSo, new MOTUs, eh?  Congratulations to them.16:58
ScottKSomeone who cares about latex might want to look into syncing vim-latexsuite.16:58
iulianHm, it seems that http://vim-latex.sourceforge.net/ is not responding.17:01
iulianAh.  It worked.17:02
ScottKiulian: What's in Debian represents a considerable update.17:06
fabrice_spHi. If a lib appears in the NBS page, and it's normal (changed from lib1 to lib2), should we fill a remove request for the binary package (lib1 in my example)?17:24
ScottKfabrice_sp: No.  Once it has no rdends left it'll get cleared up17:24
fabrice_spok17:25
fabrice_spthanks17:25
iulianScottK: Yea.  I couldn't find a ChangeLog or a NEWS file.  It will need a FFe.17:30
iulianScottK: There is a debian/RELEASE-1.5.txt file. I found out that 1.5 was released in 2003.17:31
iulianI'm definitely looking in the wrong direction.17:33
ScottKiulian: Yes.  I think it's enough of an update we ought to take it if someone can verify it works.17:33
iulianScottK: That's what I was planning.17:33
ScottKRoAkSoAx: If you want something to work on, http://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-gcc-4.4;users=debian-gcc@lists.debian.org probably has some patches we could do with.17:36
ScottKIf you find packages that FTBFS on http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20090909.html that have patches there, it's a good chance we need the patch17:37
diwicScottK: Is it just a coincidence that all packages on that list start with the letters a - f ?17:38
ScottKdiwic: The rebuild gets done in alphabetical order.  That's as far as it is.17:39
RoAkSoAxScottK, awesome! I'll work on it. Thanks :)17:39
ScottKAlso that page only updates every two hours.17:39
ScottKRoAkSoAx: Feel free to invite new contributors to help you and sponsor them.17:39
diwicscottk: somebody needs a faster build machine ;-)17:40
ScottKdiwic: It's done on the PPA builders whenever one is not otherwise in use.17:40
RoAkSoAxScottK, will do :)17:40
geserRoAkSoAx: don't forget to check if there isn't a fixed package in the archive already. I'm going through this list and trying to fix all those "invalid conversions" errors.17:43
RoAkSoAxgeser, ok :)17:47
ScottKgeser: At the release team meeting today slangasek and sistpoty discussed trying to get a training session together to teach MOTU/hopefuls how to work on solving these FTBFS.17:50
geserScottK: the "invalid conversion" ones are pretty easy to fix (mostly add a "const", but some C/C++ knowledge is still useful), so they would be a good candidates for new contributors17:53
slangasekgeser: eh, *don't* add const for the invalid conversion ones17:54
slangasekthat's a bug in the toolchain, not in the packages that are FTBFS17:54
slangasekand when the toolchain is fixed, they'll FTBFS again if changed17:54
geserslangasek: oh17:55
slangasekperhaps I should fix that in eglibc and ask for another rebuild test17:56
geserslangasek: the declaration for strchr() on a const char* seemed pretty logic to return a const char *17:56
slangasekgeser: but that's not how the function is defined17:56
slangasek(cf. the manpage)17:57
geserin that case it would be perhaps good to stop the rebuild till it's fixed as there are many of these in the FTBFS list for the rebuild17:58
geserso it's hard to find the real ones17:59
oussamahi everybody18:05
=== micahg1 is now known as micahg
randomactionI have packaged a new upstream version, do I have to upload to LP anything besides .diff.gz? (I assume that .tar.gz should be taken from upstream anyway, and .dsc generated from it)19:20
sistpotyhi folks19:22
geserrandomaction: only the .diff.gz is necessary19:22
randomactiongreat, thanks19:23
=== jrib1 is now known as jrib
geserif the package doesn't have a watch file which makes it easy to fetch the new .orig.tar.gz, perhaps a link to the new upstream tarball would be helpful to save your sponsor the time to go hunting for it19:25
randomactionYep, I have added both.19:30
sistpotyis anyone interested in an instant fix ftbfs session?19:46
sistpoty(as we've got lot's of ftbfs, see http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20090909.html)19:46
diwicsistpoty: there was a discussion two hours ago whether to fix them or not19:48
diwicsistpoty: seems like an error in the toolchain was causing at least some of them19:48
ScottKdiwic: It was decided that was not the case.19:48
diwicok19:49
geserdiwic: they should be fixed again (see the log for #ubuntu-devel)19:49
sistpotyso anyone interested in a fix ftbfs session here? I'd help with c/c++ issues20:11
sebnersistpoty: I'd attend for sure :)20:12
sistpoty:)20:12
sebnersistpoty: what do you mean with "instant", right now?20:13
sistpotysebner: yes20:13
sebnersistpoty: I have to fix something first :P20:13
sistpotyhehe20:13
* porthose has notpad and pen ready20:14
sebnerporthose: good you didn't write "notepad" :P20:14
sistpotyexcellent!20:14
porthosegod I can't type today :)20:14
sistpotyslangasek: got some time to jump in as well, if tough questions arise?20:15
* slangasek waves wildly20:15
sistpotywohoo, cool, so let's get started.20:15
sistpotyso first off, the list we'll deal with is http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20090909.html, which is the current rebuild test (still going on, so the list will increase as buildds come to it)20:16
sistpotylet's grab a nice one20:16
sistpotyhow about adanaxisgpl20:17
sistpotythe (F) link goes straight to the build log, so let's take a look at it20:17
sistpotyand also let's grab the source while looking at the build log20:17
sistpoty(crack, why did I pick a large package :/)20:18
sistpotywhile the source downloads, it's a good idea to also look at debian's BTS, maybe there's a bug there open already, or a new version which we can pick up20:18
sistpotywith the "PTS" link, you can see the package tracking system, and see if there's a newer version in unstable20:19
sistpotythe "BTS" link is straight to debian's bug tracking system20:19
geserI would help out in the session as I'm currently fixing FTBFS anyway :)20:20
sistpotygeser: excellent, so feel free to chime in :)20:20
sistpotyso we can see, that a) there's no new version in unstable, b) there is no build failure bug open in unstable... which means that we need to tackle it ourselves20:21
diwicthere is one in mentors.debian.net though20:22
sistpotydiwic: oh, nice, excellent!20:22
diwicwait20:22
diwicthat one's an older version?20:22
sistpotydiwic: got a link? (can't see it on mentors right now)20:23
diwicsistpoty: http://packages.qa.debian.org/a/adanaxisgpl.html lists it, but when I click on the link I just get an error. That version was older anyway20:24
sebnerdiwic: it's not on mentors --> http://mentors.debian.net/debian/pool/main/a/20:24
sistpotydiwic: yep, that's an older version, which got purged from mentors after the upload20:25
gesersistpoty: you should have picked avifile, it's a nice case that upstream got lucky that it worked till now20:25
ScottKsistpoty: You should just make bddebian fix this one himself.20:25
sistpotyScottK: haha20:26
sistpotygeser: I'll leave avifile for you to explain how to fix it ;)20:26
sistpotyok, so on PTS however there's also a link to svn, let's see if there's something that helps fixing it: http://svn.debian.org/wsvn/pkg-games/packages/trunk/adanaxisgpl/?op=log20:27
sistpotywhich somehow doesn't look like it's working... maybe it was moved to git, *shrug*20:28
sistpotyso at this point, it's get interesting, we'll have to fix it ourselves (so I guess I picked a good package *g+)20:28
sistpotylet's look at the first error in the build log20:28
sistpotyto make it clearer, I've pastebin'd it: http://paste.ubuntu.com/269361/20:29
sistpotyand forgot the interesting line, d'oh20:30
sebnersistpoty: websvn is working for me but nothing helpful there20:30
sistpotysebner: ah, k, then I clicked on something wrong *g*20:30
sebnerheh20:30
sistpotyso here's the interesting bit included: http://paste.ubuntu.com/269362/20:30
sistpotyit says invalid conversion from const char * to char *20:31
sistpotyw.o. looking at the code, this looks like a constant string was passed to a function requesting a char *20:32
ScottKWe have approximately a bazillion packages that FTBFS on they type of error.20:32
ScottKthey/this20:32
sistpotyso let's look at the C side...20:32
sistpotyin C, if you write "hello world", that will be of the type "const char *"20:32
sistpotythe content of the pointer is stored somewhere in the data section20:33
gesersistpoty: in most FTBFS listed on the page this error is caused by assigning a const char* to a const * (e.g. from strchr())20:33
geserthe return value from strchr()20:33
sistpotyah, I see20:34
sistpotyso the content in the data section should really change (i.e. "hello world" shouldn't get overwritten w. something else)20:34
sistpotyearlier on, gcc was lenient and didn't care too much20:35
sistpotyso to denote that the content doesn't change, there's the const keyword20:35
sistpotyso here comes the tricky part:20:35
sistpotyif a library function returns a pointer which points inside the string, the return value must also be declared const20:35
sistpoty(because you still mustn't be able to change the contents with the returned pointer)20:36
sistpotylet's take a look at the code at ./Platform/X11/PlatformMiscUtils.cpp:1245, and see if this is the case here20:36
geserwhich is the case now with g++ 4.4 and the reason why this appears now (see man strchr() for the C syntax)20:37
geserstrchr() has in C++ two declarations (one for char* and one for const char*) and g++-4.4 checks it now20:38
sistpotyso this line is: end = strrchr (path, '/');20:38
geserthe same applies for similar functions20:38
sistpotyand end is declared as char *20:38
sistpotyin this function, end is not modified, so we can simply change it to be a const char *20:40
sistpotylet's try a rebuild20:40
randomactionironically, the next line is: if (end == (const char *) NULL)20:40
sistpotyheh, yes20:40
sistpotyso while my box is rebuilding, a small side note:20:42
sistpotyif you have to fix more compile errors, or need several tries, it makes sense to simply install the build dependencies and rebuild with make -f debian/rules binary20:42
sistpotythat way, usually only the changed files will get rebuilt (given the upstream build system is getting it right)20:43
ScottKporthose: pysvn uploaded.  Thank you for your contribution to Ubuntu.20:43
porthosewoot thx ScottK :)20:43
sebnersistpoty: If seen many missing include <cstdio> stuff, what's the magic there?20:43
ScottKsebner: Google has lots of good answers on that one.20:44
* ScottK needs to run.20:44
RainCTLaney: did you get your system booting again? :)20:44
sebnerScottK: isn't that a Q&A session :P20:45
slangasek"magic"?20:45
slangasekthere's no magic, just include cstdio where it should be included? :)20:45
sistpotysebner: earlier on, many c++ headers included other headers20:45
ScottKYep20:45
sebnerslangasek: in other words: why does upstream don't do it20:45
sistpotysebner: so that <cstdio> was in fact included by a different header20:45
gesersistpoty: mine rebuild is done (successful)20:45
sistpotysebner: so it did built back then20:45
sistpotygeser: wohoo20:45
slangaseksebner: because g++ was less strict before and the headers were included by accident, so upstream didn't notice20:45
sebnergrrrr -.-20:46
sebnersistpoty: do you also have such an example, /me forgot the FTBFS message for this ones20:46
gesersistpoty: have you an idea how to fix the FTBFS for avifile? http://launchpadlibrarian.net/31591921/buildlog_ubuntu-karmic-i386.avifile_1%3A0.7.47.20070718-1.2ubuntu1_FAILEDTOBUILD.txt.gz20:46
geserhttp://bazaar.launchpad.net/~ubuntu-branches/ubuntu/karmic/avifile/karmic/annotate/head%3A/lib/aviplay/aviplay.cpp20:46
geser^^ that's the source file20:46
sistpotysebner: I'd have to look for this... iirc there also was a mail from Martin Michlmayr explaining a few c++ errors wrt the new gcc, but I don't recall right now where that mail is (anyone got a pointer)?20:47
sebnergeser: lol, isn't that the other way round?20:47
sebnersistpoty: kk, np20:48
diwicsistpoty: I decided to try another package just to follow, but apt-get build-depends failed, one of the packages got a 404 not found error. :-(20:48
sistpotydiwic: run apt-get update20:48
sistpotygeser: hm... should be the same thing actually, though I can't say for sure how strrchr is defined in c++ (or why it would be needed in the first place)20:50
c_kornp is not used after if(p). so *p=0 can be removed I think20:50
RainCTsistpoty, geser: yay, the coredump works with gnome-voice-control. Now I need to know wth I can do with this file, though :P20:50
sistpotyc_korn: no, the "." is removed in the string, should there be any (in a quite hacky way)20:51
geserc_korn: no, the idea it that the filename (fn) should be terminated at the place with "." (if there is any)20:51
sistpotygeser: according to http://www.cppreference.com/wiki/string/start, c_str() returns something non-modifiable20:52
geserthe problem here is that fn.c_str() returns a const char *, strrchr(const char*, int) returns also a const char *20:52
geserso *p should be a const char *20:52
geserin which case *p = 0 is illegal20:52
sistpotyyes20:53
geserthis code needs to be modified to work on "string" (C++)20:54
geserI'm curious why this didn't cause any problems (any crashes)20:54
slangasekwhy would it?20:55
sistpotygeser: how about size_t p = fn.rdin('.', 0)20:55
sistpotyif (p != std::string::n_pos) { fn.erase(p, 1); }20:55
sistpotyrfind even20:56
geserslangasek: I assume it didn't crash because c_str() used modifiable space (even when it returned it as const char *), correct?20:56
sistpotybleh, of course not 1, but fn.erase(p, fn.size() - index - 1)20:57
sistpoty(might still be off by one, /me recalculates)20:57
slangasekgeser: yes, that's almost always the case20:57
sistpotyfn.erase(p, fn.size() - index)... that should be it20:58
slangasekall pointers to read-only memory must be const by definition, but most const pointers don't point at read-only mem20:58
sistpotyslangasek: and iirc even string constants don't reside in read only pages, correct?20:59
sistpotygeser: anyways, since you were first to have the rebuild finished, maybe you'd like to explain the final steps (like getting the adanaxisgpl patch as a patch, forwarding it to debian and upload it?)21:01
gesersure21:02
sistpotythanks, then I'll go out for a smoke, be back in 5 mins :)21:02
geserso we know now how to fix it21:02
geserthe first step would be to check if the package uses a patch system21:03
geserwhat-patch (from ubuntu-dev-tools) helps with this21:03
slangaseksistpoty: string constants will usually be in read-only pages21:03
geserwhat-patch returns for this package that it uses quilt21:04
geser(an other way would be to look for debian/patches)21:04
geserso lets get the change into a quilt patch21:05
geseras I regularly forget the magic for quilt, I use https://wiki.ubuntu.com/PackagingGuide/Howtos/Quilt as a reminder21:06
DavieyHey, if i21:07
DavieyHey, if i'm cherry picking a patch from Debian.. should the changelog state "Cherry picked from Debian"?21:07
geserDaviey: yes, it makes it easier during the next merge to know that the patch is already in Debian21:08
Davieygeser: they way it's heading it's going to be constantly diverged from Debian :(21:08
gesercan you explain?21:09
sistpotyslangasek: ah, thanks21:10
geserback to our quilt patching: "export QUILT_PATCHES=debian/patches" to let quilt know where the existing patches are21:10
Davieygeser: Debian don't want to adropt dkms at the moment for this package.21:10
geserDaviey: but it's still good to know that the patch came from Debian and that we don't need to forward it (independent of any Ubuntu delta we need to keep for a longer time)21:12
Davieysure, thanks.21:12
geserthe next step is then to apply all existing patches (quilt push -a), create a new one (quilt new 40_fix-invalid-conversion.diff (or similar))21:13
geseradd the file we need to modify to it (quilt add src/Platform/X11/PlatformMiscUtils.cpp)21:14
geseredit the file with an editor of your choice21:14
sebnergeser: without looking at the patch list, why did you pick 40?21:15
loic-mjdstrand: thanks for the gmameui upload21:15
diwicgeser: are you actually rewriting the code a second time now?21:15
gesersorry, missed a step: look at the existing patches to see how they are numbered and named21:16
loic-mjdstrand: however I can't find a config.log file in the source package21:16
jdstrandloic-m: did you check the diff.gz?21:16
geserdiwic: perhaps I should mention that I check which patch system is used before I start changing anything21:16
* sistpoty usually modifies directly but adds a new changelog entry and then debdiffs to get a patch21:18
geserafter the look at debian/patches I picked 40 as that looked like the next step in numbering (we don't need to push our patch somewhere in between the existing patches)21:18
loic-mIjdstrand: yes, I always check for files not in debian/ . Is it possible the diff.gz sent to you wasn't exactly the one I uploaded to REVU21:18
Davieysistpoty: thought about scripting that process?21:19
=== Tonio__ is now known as Tonio_
sistpotyDaviey: not really... the main point is looking at the debdiff (to catch other maybe build system related changes, that shouldn't be there), and I wouldn't know how to automate this21:20
diwicsistpoty: If you modify directly, won't you get lintian warnings for having modifications outside debian subdir?21:20
geserwhen we are done with any changes, "quilt refresh" to update the quilt patch, and "quilt pop -a" to de-apply all patches21:21
geserin the case of quilt we don't need to add our patch to debian/series (quilt did it already for us) (for dpatch one has to add it manually to patches/00list)21:21
sistpotydiwic: well, if there's a patch system, yes... but I change directly and pick the patch then from the debdiff and integrate it into the patch system if everything works for the final upload (of course after rebuilding it again and running lintian *then*)21:22
c_korn(in karmic quilt now has an option "shell" which makes it behave like cdbs-patch)21:22
geserthe next step would be to add a changelog entry (dch -i)21:22
geserif our change is the first Ubuntu change to this package don't forget to run "update-maintainer"21:23
geserif I didn't forget anything we should be able to build the new source package now (debuild -S)21:24
sebnergeser: what would you do if patches are like this: 2_foo, 4_bar,  foobar, barfoo, 30_foobarfoo, 40_barfoobar?21:24
geserrunning "debdiff" inside the package dir will gives us the debdiff for our changes21:24
gesersebner: curse about the maintainer21:25
sebnergeser: heh21:25
sebnergeser: that too21:25
ScottKAlso if you're on Jaunty or earlier, don't forget that the correct Ubuntu maintainer is now Ubuntu Develpers <ubuntu-devel-discuss@lists.ubuntu.com>21:25
sebnergeser: pretty neutral would be to use 99 or? ^^21:26
geserI had a similar case for an other FTBFS. had to name my patch ubuntu_... go get it sorted last21:26
=== ahasenack is now known as andreas-away
gesersebner: IIRC 0-9 sorts before a-z, so I would name it with something larger than foobar21:27
jdstrandloic-m: I'm not sure how REVU will process the upload, but it certainly should be the same.21:28
randomactionactually, the order of patches is governed by patches/series, so their names are not really important21:28
geserif the package uses quilt or dpatch21:28
jdstrandloic-m: if you unpack the source package, it is in there21:28
sistpotyjdstrand: revu doesn't fiddle with the files (apart from the .changes file, which imo only gets made non-readable)21:28
ScottKrandomaction: That's true for Quilt21:28
geserfor cdbs-simple-patch no such file exists21:29
jdstrandloic-m: in the diff.gz: +++ gmameui-0.2.10/config.log21:29
jdstrandsistpoty: thanks21:29
slangasekif it uses cdbs-simple-patchsys, petition the Debian maintainer to use something sane instead :-P21:29
sistpotyjdstrand: np... at least that's true unless RainCT changed it *g*21:29
sebnergeser: kk, thx21:29
geseronce we checked that our debdiff contains only our expected changes we can redirect it into a file which we can use for attaching to LP21:30
randomactionoh thanks, live and learn21:30
geserin case a sponsoring is needed I put a "(lp: #xxx)" placeholder into my changelog entry, open a bug on LP, and replace the "xxx" inside the debdiff with the real bugnumber with an editor21:31
RainCTsistpoty: what have I done? :P21:31
gesernow just the normal sponsorship process follows21:31
sebnerslangasek: quilt quilt quilt is the only choice here ;-P21:32
geserfor submitting the patch to Debian, I edit the debdiff and remove the Ubuntu specific parts (like the changelog entry and the Maintainer change) (is there a tool for it?)21:33
slangasekgeser: submittodebian21:33
slangasek(removes the changelog entry, not the maintainer change)21:33
geserslangasek: does it filter out the Ubuntu specific changes?21:33
loic-mjdstrand: I'm really sorry, I must be blind. To make sure I'm looking at the same diff.gz, I dl it from http://revu.ubuntuwire.com/revu1-incoming/gmameui-0908292321/gmameui_0.2.10-0ubuntu1.diff21:33
loic-mjdstrand: and I can't find any config.log string21:33
jdstrandhttps://launchpad.net/ubuntu/karmic/+source/gmameui/0.2.10-0ubuntu121:33
jdstrandloic-m: ^ that is what was in the queue and what I accepted/commented on21:34
geserin case I needed to change something in debian/control, so that's it not simple to remove it from the debdiff, one needs to prepare a specific debdiff just for debian21:34
loic-mjdstrand: that's not what I uploaded. I only uploaded to REVU, and it's still there21:34
ScottKdeupdate-maintainer would be a simple enough script.21:34
geserand finally I use reportbug to open a bug about the problem in Debian and attach my trimmed debdiff to it21:34
diwicgeser: and lesson one; don't pick a package someone else did 4 hours ago. *bangs head against the wall*21:35
jdstrandloic-m: please bring it up to your reviewer on REVU21:35
geserdiwic: which one did you pick?21:35
diwicgeser: alsaplayer21:35
loic-mjdstrand: ok, I'll tell him, and ask what he did. Thanks21:35
geserdiwic: at least you can compare if you would have done it the same way21:35
loic-mRainCT: ping21:36
sistpotyRainCT: I only implied that I don't know what you have done :P21:36
RainCTloic-m: yeah, I'm here wondering what's up :P21:36
loic-mok, I'm puzzled. I'd never upload a diff like that21:36
RainCTohh, nice diff :P21:37
geserand if I didn't forget anything (like testbuilding before you submit your changes to Ubuntu and Debian) we are done and can pick the next FTBFS21:37
diwicgeser: solution was the same, yes.21:38
sebnergeser: yeah, next FTBFS \o/21:38
RainCTloic-m: why is there no orig.tar.gz on REVU?21:39
randomactiongeser: is it a good idea to submit the patch to upstream as well?21:39
loic-mRainCT: probably because the last upload I did, the gmameui page on REVU was already archived21:39
geserrandomaction: yes (but usually I'm too lazy to go looking how to submit it upstream and register in an amount of different bugtracking systems)21:40
RainCTShouldn't make a difference. Well, anyway21:41
sebnergeser: mail to DM with the debdiff and the note: Please also submit to upstream :P21:41
loic-m_RainCT, sorry, got disconnected21:41
loic-m_I missed everything since my line at [22:39]21:42
sistpotyloic-m: the 0902292321 changes file was signed by 5E593B80, your key? (keyserver is very slow for me :/)21:42
porthosesistpoty geser thx that was very informative :)21:42
loic-m_yes, my key21:42
loic-m_however, that's not what I uploaded to REVU21:42
gesernote: I've just uploaded our fix for adanaxisgpl21:43
sistpotyloic-m: can you explain?21:43
sistpotygeser: thanks a lot!21:43
sistpotyso for the session, I guess we'll continue now that everyone tries to fix a ftbfs21:44
sistpotyand if there are any c/c++ related questions, just ask here21:44
sistpotyideally providing a) a link to the build log and b) a link to the source file (or pasting the interesting bits of the source file)21:44
loic-m_RainCT: the config.log isn't the only problem, the .desktop file got processed borked too (encoding of non-English letters), which isn't the case for the diff.gz on REVU21:45
RainCTloic-m_: uhm I'm trying to reproduce getting a .diff.gz like that but everything shows up clean21:45
RainCTloic-m_: the encoding is a firefox problem, Edit -> Encoding -> UTF-821:45
sistpotyloic-m_, RainCT: oh, interesting, there's a .diff and a .diff.gz in that directory21:46
sistpotyRainCT: is the .diff generated from debdiff?21:46
RainCTsistpoty: On REVU? That's a gunzip or something like that21:46
sistpotyRainCT: yes, look at /srv/archive/revu1-incoming/gmameui-090829232121:46
bdmurrayHow do I request to join the universe sponsor's team?21:47
loic-m_RainCT: you're right, the encoding in the tar is correct21:47
sistpotyRainCT, loic-m_: the .changes file only lists the correct files (no .diff referenced)21:47
sistpotybdmurray: try contacting the team admins21:48
geserthe next easy "invalid conversion" error is bobcat21:48
RainCTsistpoty: (the .diff is created by a file in hook.d: http://paste.ubuntu.com/269391/, that's code from you or siretart I guess, but anyway not relevant to the discussion)21:48
geserI skipped some missing header errors for now, so they are still open21:49
sistpotypersia, TheMuso: ^^ (bdmurray)21:49
sistpotyRainCT: interesting snippet, which I'm sure that I didn't write it *g*21:50
loic-m_RainCT: is theer a way to see where the archive-admins got that diff.gz from?21:50
bdmurraysistpoty: thanks21:51
sistpotybdmurray: thank you for volunteering to sponsor packages ;)21:51
RainCTloic-m_: iirc I uploaded gmameui from http://revu.ubuntuwire.com/details.py?upid=6555 after fixing debian/copyright21:52
RainCTI recently clean my ~/tmp/ directory (where I do reviews and stuff) so I can't check how it looked21:52
loic-m_RainCT: the old diff.gz I uploaded didn't have the config.log file either, because else lintian would have complained21:53
sistpotyloic-m_: not knowing if the info is on lp somewhere, the karmic-changes list should have the details (though iirc nowadays the .changes file is stripped of the signature :/)21:53
loic-m_RainCT: for the copyright change, I did it on the August 29 upload21:54
loic-m_(and emailed you+archive admins)21:54
RainCTloic-m_: Yeah, I think I uploaded before that fixing it myself, but that was:  dget ..; cd ..; geany debian/copyright; debuild -S -sa -krainct@ubuntu.com, but now I've been trying running debuild and dpkg-buildpackage and the .diff.gz remains clean so I don't know how it can have got in there21:55
RainCT(maybe because now I'm on Debian and I did that on Karmic)21:56
loic-m_ok21:56
RainCT(err Jaunty rather)21:56
sistpotybdmurray: btw., regarding #ubuntu-review debate, did you mean it to be intended for upstream having questions about development on ubuntu?21:56
RainCTloic-m_: anyway, is this just about "omg where did that file come from?" or is there some problem?21:56
sistpotybdmurray: because after thinking a while, I think such a channel would indeed be worthwhile to have, if marketed properly21:57
loic-m_RainCT: I just didn't understand jdstrand comment on the n-p bug report, and was wondering how the file got there in the diff.gz, and if there was anything to check in debian/rules in case something didn't get cleaned up properly21:59
=== andreas-away is now known as ahasenack
ahei'd like to ask two questions about ppa:22:06
aheis it normal that my package always ends up in main although the section is universe/sound?22:06
RainCTahe: Yes, PPAs only have a "main" section22:06
ahecan i build jaunty and karmic packages (no differences except for the distribution name) from a single source package?22:07
aheRainCT: a thanks, so at least it is not my package :)22:07
RainCTahe: Nope, I think you have to upload it twice with different version numbers (I suggest appending ~ppa1 for Karmic and ~ppa1~jaunty1 for Jaunty).22:08
sistpotythere's a but about that though :)22:08
geserbug 23506422:10
ubottuLaunchpad bug 235064 in soyuz "Implement multi-release support for packages" [High,Triaged] https://launchpad.net/bugs/23506422:10
aheis it of any use to upload to revu during the freeze or should i better only maintain my packages in my ppa and wait for the time after the freeze?22:12
loic-m_ahe: you can still get reviews and work on your package, even if it only makes it for Karmic+122:13
sistpoty(though there won't be many motus doing reviews during freeze time, as they'll spend time on fixing bugs or ftbfs instead... at least I hope so *g*)22:15
sistpotyhm... I'm seeing no further questions regarding ftbfs... is everyone who listened to the session working on one? *g*22:19
=== sistpoty changed the topic of #ubuntu-motu to: Karmic Feature Freeze is in effect now! | Want to get involved with the MOTU? https://wiki.ubuntu.com/MOTU/Contributing | Sponsor queue: http://is.gd/2y76G | http://qa.ubuntuwire.com/ftbfs | http://people.canonical.com/~ubuntu-archive/NBS/ | http://qa.ubuntuwire.com/debcheck | latest rebuild failures: http://people.ubuntuwire.org/~wgrant/rebuild-ftbfs-test/test-rebuild-20090909.html
randomactionsistpoty: I fixed boswars22:23
sistpotyexcellent, randomaction!22:23
randomactiononly to find that it was already fixed in Debian (22:23
binarymutantalright I'm stumped, why is my watchfile not pulling? http://paste.debian.net/46323/22:24
randomactionso I filed a sync bug LP: #42811622:24
sistpotyrandomaction: if you find anything with maintainer "Debian Games Team", you could also try asking in #debian-games on oftc.net22:24
geserrandomaction: don't forget to subscribe the sponsors team if you want it ACKed22:26
sistpotybinarymutant: not too sure if uscan can actually deal with references within a page... the real download url for e.g. net-scp-1.0.2.tar.gz seems to be http://rubyforge.org/frs/download.php/51292/net-scp-1.0.2.tar.gz22:26
randomactiongeser: Sure. Usually requestsync did it for me, but it crashed this time.22:27
binarymutantsistpoty, hmm, this one works and it's from the same project though :/   http://paste.debian.net/46326/22:29
sistpotybinarymutant: sorry, no clue22:32
=== yofel_ is now known as yofel
binarymutantty for trying :D22:33
sebnersistpoty: I'll try to fix one tomorrow :) I wish a good night and thanks for the "instant" session =)22:48
sistpotysebner: thanks and good night22:49
LaneyRainCT: Didn't try yet, that's tomorrow's job22:53
Laney:(22:53
Ryan52asac: ah. I will admit that I didn't try that :)23:07
Ryan52asac: and wouldn't have thought to..23:07
Zhenechmezgani, hey23:23
phil_pshey I am trying to use printk23:37
phil_psI tried viewing with klogd23:37
c_kornI try to fix d4x. the diff.gz makes changes outside the debian/ directory (including configure) should I also move those changes into a patch ?23:37
phil_psI restarted it and then did #klogd -c 823:37
sistpotyc_korn: rule of thumb: if there's no patch system, don't add one ;)23:39
c_kornsistpoty: so also my fix about the FTBFS bug should directly go into the sources? without a patch system ?23:40
sistpotyc_korn: if there isn't one, yes. If there's a patch system, you should use this23:41
c_kornsistpoty: ok, thanks.23:41
c_kornok, I need the same solution as before: http://pastebin.com/d7e8e3a2023:43
c_kornwhat was it ?23:43
c_korntmp1 in line 3 should be const23:45
sistpotyc_korn: not 100% sure if it's as easy as declaring one variable from char * to const char *. Got the build log as well?23:45
c_kornsistpoty: build log is here http://launchpadlibrarian.net/31612667/buildlog_ubuntu-karmic-amd64.d4x_2.5.7.1-6_FAILEDTOBUILD.txt.gz23:46
sistpotyc_korn: that wouldn't work, then tmp1 couldn't be modified23:46
c_kornyes, I was about to mention that.23:46
c_kornline 1453 is line 3 in my paste23:47
sistpotywow, that are lots of warnings regarding string constants -> char *.23:47
Hosein-mec_i uploaded my package to Launchpad successfully but didnt receive email from Launchpad yet. any help ?23:47
c_kornHosein-mec_: how long did you wait ? it can take some minutes23:49
c_kornHosein-mec_: also #launchpad is the better place for such questions23:49
sistpotyc_korn: you could be evil and try to force cast it to char *.... char *tmp1=(char *)index(tmp,':');23:49
sistpotyc_korn: not too sure if that works though23:49
Hosein-mec_c_korn: more than 45 minutes23:49
c_kornsistpoty: this evil hack would solve all of those conversions then, wouldn'it ?23:50
sistpotyc_korn: not necessarily. For one thing, I'm not sure if it does indeed wor23:52
sistpoty+k23:52
* c_korn doubts it.23:52
sistpotyc_korn: apart from that, if tk_entry_get_text does indeed return a const pointer which resides in a read-only page, you'd get a segfault at runtime23:52
* c_korn tries to build it.23:52
c_kornsistpoty: yes, but then it would have segfaulted before,too.23:53
sistpotyc_korn: i.e. if you try const char *s = "hello"; char *t = (char *)s; *t=NULL; I guess that it would segfault23:53
sistpotyc_korn: that's right23:53
sistpotyc_korn: another soltion would be to strcpy the result from gtk_entry_get_text... that's for sure non-const then23:54
sistpoty(but you'd have to free it afterwards again)23:54
sistpotyoh, wrong in my example... *t = 0; of course23:55
c_kornsistpoty: to free it is just ... delete tmp2 ... (tmp2 being the strcpy'd non-const value ?23:56
sistpotyc_korn: free(tmp2)23:56
sistpotyc_korn: anything c-related uses malloc, the pendant is free23:56
sistpotyc_korn: anything allocated with c++ is "new", that would be deleted23:57
sistpoty(don't mix these two)23:57
c_kornsistpoty: ok, I just thought because in line 10 of my pastebin is: delete[] ns;23:58

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!