[00:07] :) [00:07] I shelved my filter machine [00:07] it tastes a bit funny IMO [00:19] oh, i don't use a machine [00:21] mwhudson: what do you use to filter then? [00:21] a filter cone [00:21] this sort of thing: http://www.hrhiggins.co.uk/accessories/coffee/plastic_filter_cones [00:21] (they are utter bastards to buy) [00:47] * mwhudson votes for writing all wiki pages in latex [00:53] heh [01:02] thumper, want to catch up some time today? [01:02] hi all [01:02] jml: might be ackward today [01:03] thumper, ok. later this week then. [01:03] (next week, scheduling calls will be _much_ harder) [01:03] jml: definitly [01:03] my irc client needs check spelling as you type [01:04] heh [01:23] jml: the vals thing in ec2test is horrible :( [01:23] mwhudson, yes. [01:32] i think i'm ok with having perform() do environment-based interpolation [01:32] that sort of thing has a tradition behind it after all [01:34] jml: so you reviewed libraryize-ec2test [01:34] mwhudson, I believe so. [01:34] jml: then i made some more changes [01:34] jml: *then* i fixed it so it works [01:35] mwhudson, heh [01:35] mwhudson, would you like to give me an interdiff to review? [01:35] jml: which is possibly backwards, but can i get you to look at the changes from libraryize-ec2test to ec2test-refactor-2 and then i'll land the latter branch? [01:35] jml: yeah [01:36] jml: https://pastebin.canonical.com/22056/ [01:37] mwhudson, use a free pastebin :P [01:37] jml: the full branch is at bzr+ssh://bazaar.launchpad.net/~mwhudson/launchpad/ec2test-refactor-2 if you want to look at the result rather than the changes [01:37] jml: oops [01:37] http://paste.ubuntu.com/270595/ [01:38] jml: thanks [02:05] mwhudson, sorry, I thought I'd deal with all of my work-related email first. Now I'm all over your diff. [02:06] jml: no worries [02:07] ooh, a connection object [02:07] what a lovely idea [02:07] mwhudson, is ec2test going to end up looking an awful lot like a twisted program? [02:08] jml: maybe [02:08] jml: too early to tell, probably [02:09] mwhudson, why did you change the _pythonpath import to manual sys.path mangling? [02:09] jml: because boto doesn't work with python2.4 [02:10] and _pythonpath _sets_ sys.path, it doesn't modify it [02:10] so importing dynamically loaded modules doesn't work [02:10] sucks! [02:11] jml: launchpad should work on 2.5!! [02:11] and nearly does now, thanks maxb [02:12] mwhudson, only a couple of other comments on the diff [02:12] mwhudson, I don't know how I feel about user_p as a variable name [02:12] it makes me think it's a predicate function :) [02:12] jml: heretic lisper! [02:13] mwhudson, and I don't know how to spell 'set up' in function names: set_up or setup [02:13] jml: i think user_connection.perform is a bit too long [02:13] maybe user_perform is ok [02:13] jml: should probably be 'set up' [02:13] even as_user [02:14] mwhudson, other than those things, I'm happy with the branch. Definite improvement. [02:15] jml: ok, thanks [02:48] mwhudson, do you know if maxb's timing patch landed? [02:48] if you don't, I'll find out myself [02:49] jml: i have this vague feeling it did, not sure though === bac changed the topic of #launchpad-dev to: This is Launchpad Development Channel | Week 2 of 3.0 | https://dev.launchpad.net/ | Get the code: https://dev.launchpad.net/Getting | On-call review in #launchpad-reviews | Use http://paste.ubuntu.com/ for pastes | 3.0 goal is to convert all templates: http://people.canonical.com/~beuno/conversions.html [02:52] mwhudson, Launchpad says it's moved. [02:52] merged, rather. [02:53] jml: it's probably right [03:01] * mwhudson dogfoods his ec2 branch and wanders off for lunch [03:01] * ajmitch looks for an easy bug to chew on [03:02] ajmitch, the 'trivial' tag should be a good starting point. [03:02] yeah, that's what I'm looking at [03:02] ajmitch, cool. [03:03] ajmitch, let me know if you need a hand with anything. [03:03] oh I will :) [03:05] I have LP running on karmic here at least, started looking at bug 238588, but saw that there is X-Launchpad-Message-Rationale being added [03:05] Bug #238588: "New code import" messages lack an X-Launchpad-Message-Rationale [03:05] Malone bug 238588 in launchpad-code ""New code import" messages lack an X-Launchpad-Message-Rationale" [Medium,Triaged] https://launchpad.net/bugs/238588 [03:05] Bug #238588: "New code import" messages lack an X-Launchpad-Message-Rationale [03:05] Bug #238588: "New code import" messages lack an X-Launchpad-Message-Rationale [03:05] so I now need to try & reproduce it on a local setup [03:06] * ajmitch should just pick some simple UI bugs [03:09] hmm. [03:09] spm, do you know who maintains mup and/or ubot3? [03:09] spm, because I think one of them should die [03:10] * ajmitch must agree, given the spam above [03:12] at least ubot3 seems to have repetition protection [03:12] otherwise there would be no end to it [03:12] yeah. [03:14] ajmitch, I'd definitely recommend a UI bug to start with. [03:15] ajmitch, the smaller the bug, the better -- especially for your first patch. [03:15] less chance of doing things completely wrong [03:16] ajmitch, that, but also it's a good way of learning all the boring things about Launchpad hacking :) [03:17] ajmitch, i.e. it's a good way of separating learning about LP process from the LP code base. [03:17] on a completely unrelated note [03:17] where the hell is google gears for 64 bit linux? [03:20] * ajmitch just gets a popup in firefox at random intervals that it can't be installed [03:20] yeah. === jamalta_ is now known as jamal === jamal is now known as jamalta [03:27] ubot3: owner [03:27] This bot is owned by jussi01 - Questions about ubottu should be asked in #ubuntu-bots [03:27] jml: ^ [03:28] (and yes I am awake in complete defiance of my physical timezone) [03:28] maxb, thanks. [03:44] Quick opinion poll: [03:45] lambda self: self.foo [03:45] or [03:45] from operator import attrgetter; attrgetter('foo') [03:45] ? [03:49] maxb: I believe the style guide says the latter [03:49] Although I probably prefer the former. [03:50] https://dev.launchpad.net/PythonStyleGuide, section 13. [03:52] oh [03:52] the style guide is so big :-/ [03:52] Ja. [03:53] Aren't you violating the "no coding after 3am" guideline? [03:55] I slept, then I woke up at a nonsense time and didn't feel like falling asleep again straight away :-) [03:55] I like lambda. I forget operator exists so never use it ;) [03:56] maxb, lambda is fine. [03:56] jml: The style guide needs fixing? [03:56] wgrant, yes, it does. [03:56] :( [03:56] wgrant, I agree. [03:57] tbh, I think it over-legislates. [03:57] stub, attrgetter & itemgetter ought to be builtins, imnsho [03:59] My disagreement with attrgetter is that IMO you should never write code in strings if you can possibly avoid it [04:01] hmm, merge proposals really need an "update to latest branch revision in-place" button [04:01] maxb, although I agree with the principle... [04:02] maxb, since Python lacks a separate type for symbols, and thus uses strings, I think it's perfectly ok to use strings for attribute access [04:03] maxb, and although dynamic attribute access is over-used by some & can be confusing, I think forbidding it entirely is unnecessarily restrictive. [04:04] * maxb wonders why superseding a merge proposal blocks the ability to further comment on it [04:05] maxb, there were reasons. [04:05] I'm reasonably confident that the whole workflow around updating diffs in being changed for the better. [04:06] but maybe thumper can say one way or the other. [04:06] jml: I do love how you always manage to ping me *just* after I go afk for eg lunch :-) [04:06] spm, it's rarely ever urgent :) [04:06] actually, I'm just about to go out to lunch. [04:07] jml: no, I'm not sure who maintains them. There was some noise around IS looking after same, but I'm unaware of the current status on that. [04:07] spm, I've asked jussi01 on #ubuntu-bots (who owns ubot3) to kill off ubot3 [04:07] cool, ta. [04:07] spm, if they don't respond, I humbly suggest that we kickban ubot3 and send a polite email explaining why. [04:08] booooooooooooot faster ec2! [04:08] maxb, I simply have to eat now. I'll review your branch when I get back from lunch. [04:10] i can review it now, while i wait for ec2 instances to do stuff [04:21] huh, property(attrgetter(attrname)) is a trick that hadn't occurred to me, i have to say [04:27] That wizardry came from allenap [04:35] maxb, replied [04:36] I was just thinking, it'd be nice to use that trick to make an 'alias' helper that took the old attribute name and an optional readonly boolean parameter. [04:41] jml: replied [04:42] gosh our test suite is really slow [04:44] yeah, we should do something about that. [04:44] jml: if we can make ec2test not rely on being able to ssh to devpad, it can be a bunch simpler [04:44] jml: luckily you did something about that recently :) [04:45] mwhudson, because all the agent stuff goes away? [04:45] jml: no, not that (we still need to ssh to launchpad) but some of the ssh config complexity [04:45] mwhudson, ahh, I see. [04:45] (no need to dig out the proxycommand you and i use to connect through chinstrap) [04:46] I guess ec2test needs to use SSH to get branches still? [04:46] yeah [04:46] we could update most of them over http i guess [04:46] ah, the old ProxyCommand ssh nc 22 trick? [04:47] which would let us --headless earlier, but would be a bit slower overall [04:47] maxb: yep [04:49] btw [04:49] does anyone know why i don't have a /usr/lib/jvm/default-java file? [04:49] apt-get install default-jdk ? [04:49] it looks like i have several jdk's installed [04:50] maxb: hm, that's doing something indeed [04:50] jml, thumper: do you have any branches that need ec2testing right now? [04:51] (or anyone else internal, but you should all be asleep :) [04:51] default-jdk is one of those packages which only really exists to serve as a build-dep [04:52] It's so that the distro-wide choice of OpenJDK/GCJ/Whatever can be made in a single place [04:52] mwhudson, looking... [04:53] mwhudson, nope [04:53] maxb: right, but i had openjdk, gcj and whatever installed already [04:53] maxb: i was expecting it to be more like the alternatives stuff i guess [04:53] maxb, wgrant: either of you have branches that need testing? [04:53] sorry, you've landed them all :-) [04:53] * mwhudson has a shiny new ec2test image [04:54] though actually I did have a fairly mechanical change I was planning on doing... [04:54] * maxb wields grep [04:56] jml: want to look at another ec2test knocking-about diff? http://pastebin.ubuntu.com/270655/ [04:57] jml: it's still fairly horrible, but it allows one-step updating of the ec2test image [04:58] mwhudson, wuu [04:58] * mwhudson runs "time ./utilities/ec2test.py --headless" for that branch [04:58] mwhudson, umm, could you please walk me through the changes? [05:00] jml: so one strand is ripping stuff out of testrunner (particularly EC2TestRunner.__init__) so that having a testrunner isn't vital to doing anything at all [05:00] jml: another strand is the stuff to add the bundling [05:00] and there are the inevitable driveby cleanups [05:03] jml: hang on, i'll annotate a diff [05:04] mwhudson, thanks. [05:06] oh heh heh, i think i broke --headless [05:08] jml: http://pastebin.ubuntu.com/270659/ [05:12] So, I have another branch which you could ec2test if you like...except launchpad is still falsely claiming it hasn't been pushed to yet :-/ [05:13] and I'm not getting the "Launchpad is processing new changes to this branch" banner on it either [05:15] maxb: new branches never say "processing changes" [05:15] (which is a bug) [05:17] How long do I wait before deciding that something is actually broken? [05:18] https://code.edge.launchpad.net/~maxb/launchpad/debuild--no-conf ftr [05:20] hmm, I deleted the MP I created and it changed from "has not been pushed to" to "has not been scanned" [05:20] hmm looks like the scanner is stuck [05:20] spm: hi [05:20] maxb: that's interesting [05:20] but maybe just a coincidence [05:20] mwhudson: heyo; stuck scanner? looking. [05:21] it may have just unstuck [05:22] seems like it [05:22] spm: can you sync the puller logs to devpad? [05:22] sure [05:22] tia [05:22] * mwhudson watches ec2test.py --headless do stuff [05:24] jml: wow, bug #420198 is next [05:24] Malone bug 420198 in launchpad-foundations "ec2test --headless takes way too long to detach" [High,Triaged] https://launchpad.net/bugs/420198 [05:24] Bug #420198: ec2test --headless takes way too long to detach [05:24] Bug #420198: ec2test --headless takes way too long to detach [05:24] Bug #420198: ec2test --headless takes way too long to detach [05:24] mwhudson, nice. [05:24] spm, do you have ops? [05:25] mup really needs a "30 sec delay" mindset on reprint the same bug id.... [05:25] jml: "ops"? [05:25] mwhudson: puller synced and bzrsyncd for good measure. [05:25] spm, IRC operator privileges [05:25] fortunately mup is written in a programming language we all know really well [05:26] (warning: may be a lie) [05:26] spm: thanks [05:26] I do :) [05:26] jml: no. and given I've been irc'ing for ~ 15 months, I wouldn't trust me :-) [05:27] jml: fwiw, i think "irc op" is quite different from "channel operator" [05:27] my mistake :) [05:28] farewell, ubot3 [05:29] mwhudson: If you need something to ec2test, here's a (literally) one-liner change https://code.edge.launchpad.net/~maxb/launchpad/debuild--no-conf/+merge/11680 [05:31] maxb: ta [05:43] ajmitch, heh. [05:45] it'll be back, when the banlist decays over time, as they always seem to do [05:46] easiest way is to just nag the owner [05:47] ajmitch, this has been done :) [05:47] I'm glad :) [05:50] mwhudson, ok, my attention is now returned to you [05:52] jml: hurrah [05:54] i think my stock of attention for today has almost run out ... [06:00] mwhudson, http://pastebin.ubuntu.com/270677/ [06:01] mwhudson, here's the quick version: [06:01] mwhudson, yay [06:01] mwhudson, did you think of making make_instance a classmethod on ec2instance? [06:01] And coffee just doesn't work like it used too. Now if I drink too much coffee I'm wired but can't pay attention to anything. [06:02] mwhudson, demo_networks should be split out, save it for a separate branch. I know how it works, so I can happily help you there. [06:02] mwhudson, it's a shame 'credentials' has to be a public attribute on account [06:03] mwhudson, did you think of making make_instance a classmethod on ec2instance? [06:03] no, that's probably a good idea [06:03] mwhudson, it's a shame 'credentials' has to be a public attribute on account [06:03] is it? [06:04] an EC2Credentials is a slightly strange thing, really [06:04] yes, it is. [06:04] mwhudson, demo_networks should be split out, save it for a separate branch. I know how it works, so I can happily help you there. [06:05] hooray [06:06] mwhudson, well, the only usage of the .credentials attribute is in bundle(), and it violates the Law of Demeter. I'm just worried (perhaps overly so) about tying this stuff together too much. [06:07] mwhudson, and one usage + lots of dots trips a flag. [06:07] mwhudson, but it's not a big deal. [06:08] jml: yeah, fair point [06:08] * mwhudson restructures a bit [06:14] jml: interdiff [06:14] http://pastebin.ubuntu.com/270681/ [06:16] mwhudson, wonderful! :) [06:16] jml: thanks [06:16] mwhudson, could you please add a docstring to make()? [06:17] jml: i should probably do a read through the diff adding/editing docstrings [06:17] jml: so sure [06:17] mwhudson, sweet. [06:27] mwhudson, btw, I have a note here to talk to you about pycon talk ideas [06:27] jml: ok [06:28] mwhudson, but I don't really have that kind of energy right now. [06:28] jml: heh, me neither [06:28] jml: tomorrow, when the caffeine is still fresh in our veins? [06:29] mwhudson, sounds good :) [06:43] jml: some docstrings to read: http://pastebin.ubuntu.com/270690/ [06:46] mwhudson, 'demo_networks' is a list of network strings (e.g. "192.168.1.0/24") and IP addresses [06:46] mwhudson, it specifies who is allowed to connect to the server [06:47] mwhudson, but also, if it's set at all, then tests aren't run and some other stuff is enabled/disabled. [06:47] jml: i.e. "represents a bunch of crack" [06:48] jml: i think i'd almost write "???" in the docstrings than explain the current truth [06:48] (and fix the current truth tomorrow) [06:48] mwhudson, fair enough. :) [06:48] mwhudson, just like _1984_! [06:49] mwhudson, it would be nice to have a little more explanation as to what make() does (or rather, how it's different from the constructor) [06:50] * jml looks over the code to make a suggestion. [06:50] perhaps there isn't much difference [06:51] hmm, yeah. [06:51] mwhudson, I'm happy to leave the current docstring as is. [06:51] maybe future code iterations will make the distinction clearer. [06:51] mwhudson, r=jml [06:52] jml: awesome, thanks [06:52] mwhudson, no, thank you. === beuno-on-vacatio is now known as beuni === beuni is now known as beuno [07:10] * mwhudson is done for the day [07:12] mwhudson, g'night. [07:46] good morning all [07:46] noodles775! [07:46] Hi beuno ! [07:47] noodles775, how are things? [07:48] beuno: ok - we just landed the the ppa-index re-design at the end of last week... still some tweaks to be done, but was good to get it landed. How are you going? [07:48] noodles775, I saw you guys won the race ;) [07:48] noodles775, things are great. Had a fantastic vacation [07:48] very relaxing [07:49] beuno: Great to hear :) I hope it didn't take too long to get to the relaxed state :) [07:49] noodles775, it took a day or two to really disconnect, but after that it was a smooth ride [07:49] Great! [07:50] so, is soyuz now turning its attention to blueprints templates? [07:50] noodles775, did you manage to get your hand on the padding issues? [07:50] jml: we're planning to do blueprint templates along with other high-priority bugs. [07:50] noodles775, awesome :) [07:51] beuno: nope - I had to focus on the ppa-index last week. I did do a few flybys that I needed for the ppa-index, but I'll look for the general padding bugs now (or do you have a list?) [07:52] noodles775, I don't have a list of bugs, not sure if they where filed [07:52] * beuno looks through bugs [07:53] beuno: I know jtv filed one general one, but am not aware of others. [07:54] noodles775, the main things I see is the breadcrumbs need more bottom padding, and the footer needs top padding [07:54] I'll play around with it and see if I can provide a branch (or a patch, my rf is busted) [07:55] beuno: I did already add more padding to the bottom of breadcrumbs (well, margin actually) - but perhaps not enough? [07:56] * beuno ponders [07:57] noodles775, https://edge.launchpad.net/~openshot.developers/+archive/ppa [07:58] beuno: that's an exception - the editable description has negative margin :/ [07:58] I think it's a combination of the description text being small, and having an icon the the breadcrumbs [07:58] Hmm... although it's the same as https://edge.launchpad.net/builders/palmer [07:59] I'm starting to think we don't want icons in the breadcrumbs [07:59] and maybe, just maybe, need to be a smaller font [07:59] Yeah, I'd agree there too - icons seem to make the breadcrumbs a bit too noisy... [08:00] I will file a bug [08:00] I need to get back on track with my karma [08:00] heh [08:00] noodles775, this page's header section is missing... something: https://edge.launchpad.net/ubuntu/+ppas [08:01] beuno: yes, it might be related to barry's landing which modified the way headings work - see the email. We all need to go through and re-adjust things a bit. [08:01] noodles775, known issue then, great [08:08] anyone know what could be causing this error? http://paste.ubuntu.com/270724/ [08:08] beuno, no, I don't. how do you get it? [08:09] jml, "make" [08:09] (I'm on karmic) [08:10] beuno, so am I. [08:10] beuno, are you up to date with dependencies, sourcecode and download-cache? [08:11] jml, yes, running rf-get [08:12] beuno, and launchpad-developer-dependencies is up to date? [08:16] jml, I'll look, but what does that have to do with it? [08:17] ah, you mean the package [08:17] yes [08:17] actually... [08:17] no [08:17] argh [08:17] updates are fun [08:18] installing 290mb of deps (again?) [08:18] thanks [08:18] beuno, np [08:23] beuno, what does 'bzr revno sourcecode/pygpgme' say? [08:24] * beuno checks [08:24] good morning [08:25] jml, 48 [08:25] moin abel [08:25] beuno, and no local changes? (cd sourcecode/pygpgme; bzr st) [08:26] jml, none [08:26] beuno, thanks. [08:26] beuno, let me know if it doesn't work after the upgrade -- it does work for me, even after a make clean. [08:27] jml, it's installing them already (560kb/sec!), I'll know in a minute [08:32] er, that's a strange error [08:34] jml, that fixed it [08:35] beuno, cool. [08:35] jml, thank you [08:36] maxb: hi [08:36] maxb: lp:~maxb/launchpad/py2.5-unittest-compatibility failed tests [08:37] lp.codehosting.puller.tests.test_scheduler fails to import [08:44] jml, FYI, the ohloh thing got kicked off again when I used devel instead of db-devel. *no* idea why that worked and the other didn't [08:45] s/db-devel/db-stable [08:45] maybe someone needs some reconciling? [08:45] beuno, I was about to suggest that. [08:46] beuno, looks like it'll still be a week or so before the listing is processed. [08:46] jml, yeah, I've been following it fairly closely [08:46] my guess is weeks [08:46] it seems to be doing a few thousand commits per day [08:47] no idea why it goes through all the commits to count number of lines [08:47] but maybe they do more than that [08:47] well, they are charting number of lines over time [08:48] my hunch is that if they asked the bazaar ML, they'd be able to make the whole thing a lot faster. [08:48] jml: hey o/ [08:48] didrocks, hello :) [08:48] jml: enjoying Australia? :) [08:49] didrocks, yes :) [08:49] He's abandoning us soon :( [08:49] * thumper waves at beuno [08:50] thumper! [08:50] hi [08:50] jml: I tried to setup launchpad on Friday evening and run into troubles. Apparently, nobody was there to have a clue: http://paste.ubuntu.com/269395/ (on up to date jaunty and karmic box). I'm a little bit stuck :) [08:50] thumper, how are things? [08:51] didrocks: What does 'rocketfuel-get' say? [08:51] beuno: somewhat frantic [08:51] thumper, 3.0 blues? [08:52] beuno: kinda [08:52] wgrant: unfortunately, I'm at work now and I don't have an available box. I can try to launch this this evening [08:52] beuno: I'm going to tackle the title and breadcrumb issues for branch pages this week [08:53] thumper, cool, I was noticing that headings are wonky now. How's the big redesigns going? [08:53]