| barry | bac: hi, you're on call tomorrow? | 00:08 |
|---|---|---|
| bac | barry: indeed i am | 00:39 |
| mwhudson | thumper: want to look at another simple ec2test branch? | 02:36 |
| stub | https://code.edge.launchpad.net/~stub/launchpad/pending-db-changes/+merge/11756 , one line change. Diff at https://pastebin.canonical.com/22095/ | 03:31 |
| mwhudson | stub: why is the diff in the merge proposal so bogus? | 03:35 |
| stub | mwhudson: Cause I targetted the wrong branch. Redoing the proposal now. | 03:35 |
| mwhudson | stub: ah ok | 03:35 |
| stub | mwhudson: https://code.edge.launchpad.net/~stub/launchpad/pending-db-changes/+merge/11757 should be better :) | 03:36 |
| mwhudson | stub: approved | 03:41 |
| stub | mwhudson: Ta. Some magic ec2test incantation you want me to use to submit it? | 03:41 |
| mwhudson | stub: yeah, tell me your aws id? | 03:42 |
| mwhudson | stub: and grab bzr+ssh://bazaar.launchpad.net/~mwhudson/launchpad/cache-the-download-cache | 03:42 |
| mwhudson | stub: by "aws id" i mean the 12 digit numeric one | 03:42 |
| stub | Merge it in or do I need a seperate branch? | 03:42 |
| mwhudson | stub: separate would be best | 03:43 |
| stub | 3409-8351-9589 | 03:43 |
| stub | Got that branch | 03:44 |
| * mwhudson slaps elastifox around a bit | 03:45 | |
| mwhudson | stub: ok, can you run ../cache-the-download-cache/utilities/ec2test.py --headless -s ... (or whatever options you usually use) in your branches dir? | 03:47 |
| mwhudson | stub: it should say "Using machine image version 16" | 03:47 |
| stub | Yup. Its booting the image now. | 03:49 |
| mwhudson | cool | 03:50 |
| mwhudson | if you're running --headless it should let go much quicker | 03:50 |
| stub | ../cache-the-download-cache/utilities/ec2test.py --headless --email=stuart.bishop@canonical.com --ignore-download-cache-changes -b launchpad=db-devel -s '[r=mwhudson][ui=none][bug=429306] replication_lag() returns an interval, not an integer' | 03:51 |
| mwhudson | let me know if it falls over in a heap :) | 03:51 |
| mwhudson | hm | 04:21 |
| mwhudson | stub: did you see my questions? | 04:21 |
| mwhudson | let me know if it falls over in a heap :) | 04:21 |
| mwhudson | stub: has it detached yet? | 04:21 |
| mwhudson | stub: er, your change just got merged into db-devel | 04:21 |
| mwhudson | stub: did you have an ec2test already running against you pending-db-changes branch? | 04:21 |
| stub | num | 04:21 |
| stub | nup | 04:21 |
| stub | didn't see | 04:21 |
| stub | it has detached now | 04:21 |
| stub | db-devel was the target. No I didn't have another ec2test run. | 04:22 |
| stub | Ahh... the merge was my fault. | 04:22 |
| stub | I'd sent off an earlier revision of that branch to pqm, and it took forever to land. | 04:23 |
| stub | So the tests are still running | 04:23 |
| mwhudson | stub: cool thanks | 04:23 |
| sinzui | I believe I have fix for the failing tests. | 05:56 |
| mwhudson | oh god there are still failures :( | 05:59 |
| mwhudson | sinzui: want me to review the fix? | 05:59 |
| sinzui | mwhudson: once I confirm it | 05:59 |
| sinzui | mwhudson: The problems are intermingled in my own branch that I was testing | 06:00 |
| mwhudson | sinzui: cool, i'm not going anywhere for a while... | 06:00 |
| sinzui | I toppled a view, but most of the errors are the one I understood danilo-afk was fixing | 06:00 |
| sinzui | mwhudson: Can you take a look at http://pastebin.ubuntu.com/271344/ | 06:20 |
| mwhudson | sinzui: i'm happy to rs=me that | 06:23 |
| mwhudson | sinzui: i don't really know all the details, but i trust you do :) | 06:23 |
| sinzui | mwhudson: if I submit with a preemptive testfix, will it be picked up automatically now? | 06:25 |
| mwhudson | sinzui: yes | 06:25 |
| === abentley1 is now known as abentley | ||
| noodles775 | gmb: will you have time to look at a pretty straight-forward 400 line code review? | 09:34 |
| gmb | noodles775: I'll take a look, sure. | 09:34 |
| noodles775 | gmb: thanks, the MP should arrive in a few seconds. | 09:35 |
| noodles775 | gmb: here 'tis: https://code.launchpad.net/~michael.nelson/launchpad/429263-no-value-option/+merge/11768 | 09:42 |
| gmb | noodles775: Awesome, thanks. Will look in a sec. | 09:42 |
| gmb | Ah, good old Zope. PEP 8 was something that happened to other people, wasn't it? | 09:50 |
| noodles775 | lol | 09:52 |
| gmb | noodles775: r=me; looks good. | 09:53 |
| noodles775 | gmb: great, thanks! | 09:53 |
| === stub1 is now known as stub | ||
| === beuno is now known as beuno-lunch | ||
| jtv | hey stub! interested in reviewing a not-trivial-but-not-widespread fix for a problem that just popped up in the translations auto-approver? https://code.edge.launchpad.net/~jtv/launchpad/bug-429811 | 11:52 |
| stub | jtv: IMasterStore(POTemplate) is a better spelling - it should be rare to need the IStoreSelector now. | 12:04 |
| stub | (line 73) | 12:04 |
| jtv | stub: ah yes, thanks, I'd forgotten about that | 12:05 |
| stub | jtv: You sure you want to start spitting warnings if you have more than 2 results? Perhaps you forgot a [:2] to the query, limiting it to a maximum of two rows returned. | 12:05 |
| jtv | stub: yes, I think I'm sure. Unfortunately there is still a case where you can validly have more results, and while I _could_ fold that in by sorting on a boolean, I don't think it's worth the complexity. | 12:06 |
| stub | Your better off spitting out your warning explicitly in that case, rather than the 'bad programmer' errors hopefully emitted by shortlist. | 12:07 |
| stub | I see we already cope sometimes, in that we proceed if there is only one preferred match, no matter now many results returned. | 12:08 |
| jtv | right, and that's worth a warning. This way I'm sure all the problem cases emit some kind of warning. | 12:09 |
| jtv | Ahh wait, it's coming back to me now. | 12:09 |
| stub | Just IIRC shortlist uses Python warn, rather than a nice log message | 12:10 |
| jtv | A double match should be a rare occurrence, and is worth a warning. A more-than-double match is downright "weird" and if the numbers get too big, mean that my approach may need the kind of query limit that you suggest, and in that case there'll be a shortlist warning. | 12:11 |
| stub | So do shortlist(100) or something, and 'if len(foo) > 2: log.warn('Weird number of matches %d') | 12:11 |
| jtv | How would that help? | 12:12 |
| stub | You won't need some sort of test ensuring the Python warning framework warning is actually emitted correctly by your script in this case. | 12:12 |
| stub | The shortlist warning is more a backup. | 12:13 |
| stub | Its to catch developer errors, where the developer assumed the length is bounded to a sane number of results but it isn't really. | 12:14 |
| jtv | Well if the shortlist warning doesn't get through, we'll still start seeing more and more of these warnings you see here. | 12:14 |
| jtv | The shortlist warning would be an additional reminder that if there's been a big shift in what kind of numbers we expect here, it may be worth updating the code. | 12:15 |
| stub | Sure. So the shortlist warning is redundant. You know this case can happen, and you handle it, so why emit noise if it does happen | 12:15 |
| jtv | I think that's appropriate. | 12:15 |
| jtv | How about I just jack up the expected size on the shortlist? | 12:15 |
| stub | I don't. It is to catch developer errors. It spits out a warning to untested channels, possibly at an arbitrary point in the output stream. | 12:15 |
| stub | Sure. | 12:16 |
| stub | Everything else I didn't mention looks good :) | 12:16 |
| jtv | Thanks. Now about the store selector... Is there no IDefaultStore? | 12:16 |
| stub | IStore(POWhatever) | 12:18 |
| stub | That gives you the default store. | 12:18 |
| jtv | great | 12:18 |
| * jtv runs tests | 12:19 | |
| jtv | tests pass | 12:19 |
| jtv | no lint | 12:19 |
| jtv | stub: for the shortlist I just removed the explicit expected-size argument, so the code really just says "this shouldn't be a long list, and if it is, consider re-balancing the code." | 12:21 |
| jtv | That okay with you? | 12:22 |
| stub | Sounds good. | 12:22 |
| jtv | Thanks. And how's the coffee? :) | 12:22 |
| stub | Great :-) | 12:22 |
| stub | Maybe John won't get his delivery ;) | 12:22 |
| jtv | lol | 12:22 |
| jtv | Robin has a grinder, so I've been enjoying it myself | 12:22 |
| === cprov changed the topic of #launchpad-reviews to: on call: - || reviewing: -|| queue: [cprov] | ||
| bac | gmb are you on call today? | 12:55 |
| bac | i'll be on in 15 minutes. | 12:56 |
| === beuno-lunch is now known as beuno | ||
| === matsubara-afk is now known as matsubara | ||
| === bac changed the topic of #launchpad-reviews to: on call bac: - || reviewing: -|| queue: [cprov] | ||
| bac | hi cprov | 13:25 |
| cprov | bac: hi there | 13:25 |
| bac | cprov: is this the one you've queued up? https://code.edge.launchpad.net/~cprov/launchpad/bug-421364-build-publishing-status/+merge/11751 | 13:25 |
| cprov | bac: yes, that's it | 13:26 |
| === bac changed the topic of #launchpad-reviews to: on call bac: - || reviewing: -cprov|| queue: [-] | ||
| bac | i'll get right on it | 13:26 |
| cprov | bac: thank you. | 13:26 |
| bac | cprov: your branch has a merge conflict | 13:44 |
| === bac changed the topic of #launchpad-reviews to: on call bac: - || reviewing: cprov|| queue: [-] | ||
| cprov | bac: uhm, sorry, let me fix it, one sec | 13:45 |
| bac | cprov: np. lots of branches hitting fast and furious | 13:46 |
| BjornT | bac: hi. i have two branches ready for review. one is on +activereviews already, and one should appear there soon | 13:52 |
| bac | BjornT: ok | 13:52 |
| === BjornT changed the topic of #launchpad-reviews to: on call bac: - || reviewing: cprov|| queue: [BjornT, BjornT] | ||
| cprov | bac: conflict fixed, branch pushed. | 14:03 |
| bac | thanks cprov | 14:03 |
| bac | cprov: i'm wrapping yours up. need to be afk for a few minutes. brb | 14:06 |
| === bac changed the topic of #launchpad-reviews to: on call bac: - || reviewing: BjornT || queue: [BjornT] | ||
| === bac changed the topic of #launchpad-reviews to: on call bac: - || reviewing: BjornT || queue: [BjornT] | ||
| === bac changed the topic of #launchpad-reviews to: on call bac || reviewing: BjornT || queue: [BjornT] | ||
| barry | bac: hiya! up for a review this fine morning? | 14:29 |
| bac | barry: throw it on the pile | 14:32 |
| barry | bac super! | 14:32 |
| bac | hey BjornT could you fix the conflicts in your windmill branch and repush please? | 14:32 |
| === barry changed the topic of #launchpad-reviews to: on call bac || reviewing: BjornT || queue: [BjornT, barry] | ||
| BjornT | bac: sure | 14:35 |
| === sinzui changed the topic of #launchpad-reviews to: on call bac || reviewing: BjornT || queue: [BjornT, barry, sinzui] | ||
| BjornT | bac: done. i'll resolve the conflicts in the other branch as well; turned out my RF copy was old | 14:43 |
| BjornT | bac: both branches are clean now | 14:44 |
| bac | thanks BjornT | 14:44 |
| bac | BjornT: when i try to merge your windmill branch r9244 into RF r9446 i still get two conflicts | 14:48 |
| BjornT | bac: well, i guess i should push up the new revision as well :) done | 14:50 |
| bac | BjornT: that magically worked! | 14:51 |
| adeuring | bac: can I add an MP to the queue? | 14:57 |
| bac | adeuring: sure | 14:57 |
| adeuring | https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-parse-submission-udev-node/+merge/11783 | 14:57 |
| adeuring | bac: thanks! | 14:57 |
| bac | adeuring: please add me to the MP | 14:57 |
| === adeuring changed the topic of #launchpad-reviews to: on call bac || reviewing: BjornT || queue: [BjornT, barry, sinzui, adeuring] | ||
| bac | sinzui: did i have a ui=sinzui on https://code.edge.launchpad.net/~bac/launchpad/bug-429455-team-pages/+merge/11739 ? | 15:11 |
| sinzui | yes | 15:11 |
| bac | sinzui: thanks | 15:12 |
| === danilo-afk is now known as danilos | ||
| === bac changed the topic of #launchpad-reviews to: on call bac || reviewing: BjornT || queue: [barry, sinzui, adeuring] | ||
| bac | hi BjornT | 15:44 |
| bac | BjornT: in test.in you say "the option probably wasn't specified". why the uncertainty? | 15:45 |
| BjornT | bac: i'm on a call now | 15:46 |
| bac | BjornT: ok, i'm here all day. :) | 15:47 |
| adeuring | bac: can I add another small branch to your queue? | 15:58 |
| bac | adeuring: sure | 15:59 |
| adeuring | bac: thanks! | 15:59 |
| adeuring | beuno: may I ask you for a small ui review: https://code.edge.launchpad.net/~adeuring/launchpad/bug-430054-hassprints-sprints.pt-lp3-layout/+merge/11795 ? | 16:02 |
| beuno | adeuring, sure | 16:02 |
| adeuring | beuno: thanks! | 16:02 |
| beuno | adeuring, done | 16:03 |
| adeuring | beuno: wowm, that was fast ! | 16:03 |
| beuno | adeuring, the 3.0 train is now going at 400 km/h | 16:06 |
| adeuring | beuno: ;) | 16:06 |
| === bac changed the topic of #launchpad-reviews to: on call bac || reviewing: barry || queue: [sinzui, adeuring] | ||
| bac | beuno: that 3.0 train isn't Amtrak... | 16:15 |
| bac | just ask barry | 16:15 |
| barry | let's hope not. otherwise 3.0 will be 50% over time and have backed up toilets for half the ride. but at least you won't be mid-air suspended in a flimsy aluminum tube breathing other people's swine flu for 1/10th the time | 16:16 |
| BjornT | bac: i'm back now. so, there's some uncertainty, since it might be that the user specified the real default value (as specified in zope.testing.testrunner.options) | 16:18 |
| bac | BjornT: i sent the review and asked for more info | 16:18 |
| BjornT | bac: for example, if someone did bin/test --tests_pattern=^tests$, we would replace that with our --tests-pattern default. i'd say it's a minor issue | 16:19 |
| bac | BjornT: ok | 16:20 |
| bac | BjornT: that might warrant a small explanation in the comment. seeing stuff like "probably" makes people nervous. | 16:21 |
| BjornT | bac: yeah, i guess :) | 16:22 |
| BjornT | bac: as for the other review. what's your use case for building on the current default options. what are you trying to do? | 16:23 |
| bac | BjornT: unsure. i'm just noting you're changing the behavior | 16:24 |
| BjornT | bac: indeed. but i haven't come up with any feasible use cases for the current behaviour. | 16:24 |
| === danilos is now known as danilo-afk | ||
| jtv | bac: got one for you, and the next OCR I guess is myself. :) can I chuck it on the queue? | 16:35 |
| bac | jtv: yes. | 16:35 |
| jtv | bac: thanks | 16:35 |
| === jtv changed the topic of #launchpad-reviews to: on call: bac || reviewing: barry || queue: [sinzui, adeuring, jtv] | ||
| === matsubara is now known as matsubara-lunch | ||
| === salgado is now known as salgado-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| bigjools | abentley: did my review response look ok? if so can you approve it please :) | 16:51 |
| abentley | bigjools: So far, I haven't received an email, but I'll go find it. | 16:52 |
| bac | sinzui: review done. thanks. | 16:52 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: barry || queue: [adeuring, jtv] | ||
| === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: barry || queue: [adeuring, jtv,sinzui] | ||
| sinzui | bac: I just sent another one | 16:52 |
| bac | one step forward... | 16:53 |
| bigjools | abentley: it doesn't list you as a review, that's why... | 16:53 |
| bigjools | abentley: https://code.edge.launchpad.net/~julian-edwards/launchpad/ppa-copy-to-main-bug-426163/+merge/11705 | 16:53 |
| bac | sinzui: could you mark the MP approved: https://code.edge.launchpad.net/~bac/launchpad/bug-429455-team-pages/+merge/11739 | 16:53 |
| sinzui | done | 16:54 |
| abentley | bigjools: r=me | 16:56 |
| bigjools | abentley: cheers | 16:56 |
| BjornT | bac: could you take another look at lp:~bjornt/launchpad/bug-429375? i've addressed your comments | 16:56 |
| bac | BjornT: ok | 16:57 |
| adeuring | bac: can I add another small MP? | 17:02 |
| bac | adeuring: sure | 17:02 |
| adeuring | bac: thanks! | 17:02 |
| bac | barry: after the merge TeamInvitationView has two label properties | 17:03 |
| bac | barry: and two page_titles | 17:03 |
| bac | :( | 17:03 |
| barry | bac: dang. let me work on that | 17:03 |
| beuno | adeuring, why is there an edit page to delete something? | 17:06 |
| beuno | refering to http://people.canonical.com/~adeuring/spec-branch.png | 17:06 |
| adeuring | beuno: I have no idea... As I wrote in the MP, there was also a button "update" on that page. Perhaps it had some time ago some field that could be edited | 17:07 |
| beuno | I've heard rumours from flacoste that anything in blueprints is ui=rs, but I don't know how true that is | 17:07 |
| beuno | adeuring, how much work would it be to change it to reflect reality? (eg, rename it to "delete") | 17:07 |
| adeuring | beuno: should be easy. Give me a few minutes... | 17:08 |
| flacoste | beuno: blueprints UI reviews are rs= | 17:09 |
| barry | bac: fix pushed | 17:10 |
| bac | thanks | 17:10 |
| adeuring | flacoste, beuno: OK, will rs=... further brnaches ;) | 17:10 |
| beuno | adeuring, the second bext iluminati player in Canonical has spoken | 17:10 |
| beuno | s/bext/best | 17:10 |
| beuno | adeuring, I'm still happy to help out if you need me | 17:10 |
| adeuring | beuno: the heading is changed | 17:12 |
| adeuring | screenshot uploaed (old URL) | 17:12 |
| beuno | adeuring, thanks | 17:12 |
| beuno | land! | 17:13 |
| adeuring | beuno: I'm waiting for the code reiview... Brad has a lot to do today... | 17:14 |
| * adeuring notices that the heading is still nonsensical ("Delete specification nranch summary")... | 17:17 | |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: bjornt || queue: [adeuring, adeuring,jtv,sinzui, adeuring] | ||
| bac | BjornT: done | 17:23 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adeuring || queue: [adeuring,jtv,sinzui, adeuring] | ||
| bac | adeuring: the diff for this MP is messed up: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-parse-submission-udev-node/+merge/11783 | 17:25 |
| bac | adeuring: never mind, i generated a new one | 17:26 |
| adeuring | bac: OK, was going to paste-bin one... | 17:26 |
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| leonardr | gary_poster: i have to leave for dinner in 1/2 hour, no way i'm getting through that queue. are you interested in reviewing https://code.edge.launchpad.net/~leonardr/wadllib/optional-field? | 17:50 |
| gary_poster | leonardr: looking now | 17:50 |
| leonardr | look at bug 430152, working on a merge proposal now | 17:50 |
| mup | Bug #430152: Multipart representation creation crashes when an "optional" field has no value specified <wadllib:New> <https://launchpad.net/bugs/430152> | 17:50 |
| gary_poster | ok | 17:50 |
| gary_poster | leonardr: yes | 17:51 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adeuring || queue: [jtv,sinzui, adeuring] | ||
| leonardr | gary, i just pushed another branch that updates version.txt | 17:56 |
| gary_poster | leonardr: | 17:57 |
| gary_poster | ok | 17:57 |
| === deryck[lunch] is now known as deryck | ||
| bac | adeuring: another done | 18:09 |
| adeuring | bac: thanks! | 18:09 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: <lunch> || queue: [jtv,sinzui, adeuring] | ||
| === gary_poster is now known as gary-afk | ||
| === gary-afk is now known as gary | ||
| === gary is now known as Guest64403 | ||
| === Guest64403 is now known as gary_poster | ||
| gary_poster | leonardr: r=gary. I'd have used self as the missing flag, rather than creating a "missing" object for this because it looks like it is part of a loop that might be run a lot. However, that may be completely unnecessary, and the "missing" name makes the usage clear. | 18:22 |
| gary_poster | leonardr: about to run out for lunch | 18:22 |
| leonardr | gary: ok. fwiw, 'missing' is defined outside the loop | 18:23 |
| gary_poster | leonardr: I saw that, but this method is not called as part of a loop (for each tag or something?) | 18:23 |
| leonardr | gary: no, it's called when you want to invoke the operation | 18:24 |
| gary_poster | leonardr: ...from lazr.restful's perspective, every time? or is this a one time parsing? (Again, really just curious.) | 18:25 |
| gary_poster | (one-time parsing for the process) | 18:25 |
| leonardr | gary: every time, because it's processing the values you provided when you invoked it | 18:26 |
| gary_poster | leonardr: oh. ok. thanks. | 18:26 |
| gary_poster | have a nice evening. | 18:26 |
| leonardr | thanks | 18:26 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue: [jtv, adeuring] | ||
| noodles775_ | bac: It's fine if you don't get to it, but can I put one on the queue even though I won't be around for question? | 18:51 |
| === deryck changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue: [jtv, adeuring, deryck] | ||
| noodles775_ | bac: https://code.launchpad.net/~michael.nelson/launchpad/429353-site-message-to-footer/+merge/11813 | 18:58 |
| === noodles775_ changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue: [jtv, adeuring, deryck, noodles] | ||
| bac | noodles775_: ok | 18:59 |
| noodles775_ | Thanks. | 19:00 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: adeuring || queue: [jtv, deryck, noodles] | ||
| === barry is now known as barry_ | ||
| bac | sinzui: are you doing a ui=rs for your oath branch? | 19:18 |
| === barry is now known as barry_ | ||
| === barry_ is now known as barry | ||
| sinzui | hmm | 19:20 |
| sinzui | bac: I am for blueprints (all blueprints are rd) | 19:21 |
| sinzui | bac: I am for blueprints (all blueprints are rs) | 19:21 |
| bac | sinzui: but what about the oath branch? if you aren't getting a UI review i'll mark the MP as approved | 19:21 |
| sinzui | bac: sorry. I am on a call | 19:22 |
| sinzui | Yes I want to two UI reviews. | 19:22 |
| salgado | sinzui, my branch converting person-index.pt is up for (code/UI) grabs. the diff has around 1000 lines, can you take it? | 19:24 |
| sinzui | salgado: yes. I would love to stop | 19:24 |
| sinzui | salgado: yes. I would love to stop coding for the day | 19:24 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [deryck, noodles] | ||
| bac | adeuring: review done | 19:26 |
| adeuring | bac: thanks! | 19:26 |
| salgado | thanks sinzui! | 19:27 |
| sinzui | barry: rockstar: Can either/both of you take a look at the pictures for my branch. The work was mechanical https://code.edge.launchpad.net/~sinzui/launchpad/person-review-oath/+merge/11801 | 19:37 |
| === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [deryck, noodles,sinzui] | ||
| barry | sinzui: sure | 19:38 |
| barry | sinzui: although, you don't need a ui review for mechanical changes | 19:39 |
| sinzui | barry: correct, but there was something wired in these pages... | 19:39 |
| barry | sinzui: give me the urls and i'll look | 19:39 |
| sinzui | https://code.edge.launchpad.net/~sinzui/launchpad/person-review-oath/+merge/11801/comments/30656/+reply | 19:41 |
| sinzui | ^ I think you want to read this to understand that IAccount is not traversable, so it does not get tabs | 19:41 |
| sinzui | barry: ^ | 19:41 |
| barry | sinzui: hmm. why does it follow that if IAccount is not traversable, the page gets no app tabs? | 19:47 |
| sinzui | barry: We gave LOSAs a hack to manage user accounts...this is outside of launchpad. To make tabs we need to made a facet menu and a canonical URL. We will never make the later | 19:48 |
| barry | sinzui: that makes better sense :) ui=barry* | 19:49 |
| sinzui | thanks | 19:49 |
| rockstar | barry, thanks for getting to that. I'm trying to get lots of stuff done. | 19:50 |
| barry | rockstar: no worries | 19:50 |
| barry | bac: shite. another text conflict found :( | 19:51 |
| sinzui | salgado: ping | 20:05 |
| salgado | sinzui, pong | 20:05 |
| sinzui | salgado: I like the treatment of links (related projects ...) | 20:06 |
| sinzui | salgado: can we add a link for the owner to mange is oauth-tokens to it | 20:06 |
| salgado | sinzui, on the heading slot? | 20:06 |
| sinzui | salgado: I was thinking of adding the link to the list that has Related projects and PPA packages | 20:07 |
| salgado | right, that's in the heading slot | 20:08 |
| salgado | I can do that | 20:08 |
| sinzui | salgado: nothing should use the heading-slot. maybe I misunderstand you. I am sure you know the list | 20:09 |
| sinzui | salgado: this is the bug I was thinking of https://bugs.edge.launchpad.net/launchpad-registry/+bug/316731 | 20:10 |
| mup | Bug #316731: provide a link to the +oauth-tokens page on users page <api> <feature> <ui> <Launchpad Registry:Triaged> <https://launchpad.net/bugs/316731> | 20:10 |
| salgado | sinzui, team-index.pt (and now person-index.pt) are filling the heading slot with these links | 20:11 |
| sinzui | I see | 20:12 |
| sinzui | salgado: barry's work deprecated the slot. I think we need to move them. | 20:13 |
| sinzui | salgado: they can move before the first <div class="yui-g"> like the distro and product page | 20:14 |
| salgado | <div | 20:15 |
| salgado | class="description" | 20:15 |
| salgado | tal:condition="context/homepage_content" | 20:15 |
| salgado | tal:content="structure context/homepage_content/fmt:text-to-html" | 20:15 |
| salgado | sinzui, that's in the heading slot too. should it be moved to the 'main' slot? | 20:15 |
| sinzui | yep | 20:15 |
| sinzui | I saw that. The markup will look a lot like the distro and product page after the move | 20:15 |
| bac | sinzui: you have two branches on +activreviews. which would you like me to review? | 20:21 |
| sinzui | both | 20:22 |
| bac | er, first? | 20:22 |
| sinzui | do the blueprint first | 20:22 |
| === sinzui changed the topic of #launchpad-reviews to: on call: bac || reviewing: jtv || queue: [deryck, noodles,sinzui,sinzui] | ||
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue: [deryck, noodles,sinzui] | ||
| bac | sinzui: i'm letting you jump b/c deryck's is super long (but easy) and the others are absentee | 20:23 |
| sinzui | bac: blueprint changes are auto ui=rs so I think it will be quick | 20:23 |
| bac | sinzui: thanks for the screenshots | 20:24 |
| sinzui | bac I should have take before examples so that you could see the overlaping text I was seeing. | 20:24 |
| bac | sinzui: before captures are handy for the reviewer and as reference for me when i'm working, so i got into the habit of doing them for all pages | 20:26 |
| bac | sinzui: i know you didn't touch it, but at line 109 the use of the plural "them" to mean "the person whose gender we don't know" is grating. could you have a go at rewording that? | 20:29 |
| sinzui | I can | 20:30 |
| sinzui | bac: I need to pick my children up. I'll be back in 30 minutes | 20:33 |
| bac | ok | 20:33 |
| bac | sinzui: the branch for https://code.edge.launchpad.net/~sinzui/launchpad/person-blueprint-templates/+merge/11753 has already landed? | 20:36 |
| salgado | sinzui, I've updated both templates to not fill the heading slot | 20:37 |
| === henninge changed the topic of #launchpad-reviews to: on call: bac || reviewing: sinzui || queue: [deryck, noodles, sinzui, henninge] | ||
| henninge | bac: I added a branch of mechanical 3.0 changes if that is ok? | 20:55 |
| bac | henninge: ok | 20:55 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: deryck || queue: [noodles, henninge] | ||
| sinzui | bac: It has? | 20:59 |
| * sinzui looks | 20:59 | |
| bac | sinzui: yeah, it landed just before i approved it... | 21:00 |
| sinzui | bac: I see. My test fix has not... | 21:00 |
| bac | sinzui: you've been landing so much stuff, perhaps your fingers just typed it while you weren't looking | 21:00 |
| sinzui | bac: I am sorry, I sent the wrong window off to PQM | 21:01 |
| sinzui | and my text change was not in it of course | 21:01 |
| bac | sinzui: no worries. it's approved anyway | 21:01 |
| bac | sinzui: perhaps you can bundle it up elsewhere... | 21:01 |
| sinzui | My test re-enable branch comes to mind. | 21:02 |
| henninge | bac: thanks. I have to go to sleep now, so please email any questions. | 21:02 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: deryck || queue: [noodles, henninge, <ask before adding any more>] | ||
| bac | henninge: will do | 21:03 |
| henninge | cheers | 21:03 |
| sinzui | salgado: I do not think you add person-portlet-involvement.pt to the tree | 21:07 |
| salgado | sinzui, I didn't. I renamed portlet-details to portlet-involvement and later removed it | 21:08 |
| salgado | does the diff say I added that? | 21:08 |
| sinzui | salgado:config says it does not exist | 21:08 |
| sinzui | salgado: I cannot start the server | 21:08 |
| salgado | sinzui, oh, right, I forgot to remove it from zcml | 21:08 |
| salgado | sinzui, please merge/push again and it will work | 21:09 |
| bac | hi deryck | 21:18 |
| deryck | hi bac | 21:18 |
| bac | deryck: in bug 427928 you said anecdotal evidence said no one used mentorship. did you run a query to confirm that? i'm just curious. | 21:19 |
| mup | Bug #427928: Templates for mentoring should be removed in 3.0 conversion <Launchpad Bugs:In Progress by deryck> <https://launchpad.net/bugs/427928> | 21:19 |
| deryck | bac, no, I didn't. See flacoste's recent stats on the bug page redesign which do confirm this. | 21:20 |
| bac | ok | 21:20 |
| bac | deryck: i'm unclear how complete this removal aims to be. I see BugTaskView still extends CanBeMentoredView | 21:25 |
| deryck | bac, it's not meant to be complete at all. it's just to remove links to the feature and templates. the least possible to do that. | 21:26 |
| deryck | bac, still a long diff to do that, though :) | 21:26 |
| bac | deryck: sure. do we have a bug to get rid of the rest of the cruft? i'd hate for 'out of sight, out of mind' to mean that we don't clean up completely | 21:26 |
| deryck | bac, no, not yet. but flacoste and kfogel are tracking the idea with stats and an upcoming blog post. So if all that turns out as expected, a bug will be filed at that point. | 21:28 |
| bac | deryck: ok | 21:28 |
| bac | deryck: will you swear on bear bryant's hat that you'll run this through ec2test? | 21:28 |
| deryck | bac, yeah, but since I'm an Auburn guy, that doesn't gain you much ;) | 21:29 |
| deryck | bac, but I don't commit without ec2test. | 21:30 |
| bac | fair enough | 21:30 |
| bac | deryck: i recall seeing auburn play once. cotton bowl, 1986 | 21:32 |
| deryck | bac, probably not a bad year for Auburn then, IIRC. | 21:33 |
| bac | deryck: cold and icy. 1st and goal on about the five and they ran bo jackson up the middle four times into a brick wall. | 21:33 |
| deryck | heh | 21:33 |
| deryck | bac, ah, the good ol' days ;) | 21:33 |
| bac | deryck: for auburn and a&m | 21:34 |
| bac | deryck: the branch looks good. r=bac | 21:35 |
| === bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: noodles || queue: [henninge, <ask before adding any more>] | ||
| deryck | bac, thanks | 21:35 |
| === salgado_ is now known as salgado | ||
| kfogel | bac: posted that blog post, btw | 22:03 |
| bac | kfogel: which? | 22:04 |
| kfogel | http://blog.launchpad.net/general/removing-mentoring | 22:04 |
| kfogel | bac: the one deryck was mentioning | 22:04 |
| bac | kfogel: ah, right. thanks | 22:04 |
| kfogel | bac: by the way, I had tried to put an image into that post (see http://www.red-bean.com/kfogel/canonical/mentoring-button.png) but couldn't get it to show up. | 22:05 |
| kfogel | bac: any idea how to do that? I uploaded it twice; I was looking at the HTML codes, and they seemed reasonable to me. But it was never visible. | 22:05 |
| bac | kfogel: i don't. mrevell would be the answer man | 22:08 |
| === bac changed the topic of #launchpad-reviews to: on call: - || reviewing: [-] | ||
| * bac calls it a day | 22:11 | |
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
