/srv/irclogs.ubuntu.com/2009/09/16/#launchpad-dev.txt

kfogeljml: morning!00:08
mwhudsonthumper: https://bugs.edge.launchpad.net/launchpad-code/+bug/43035400:08
mupBug #430354: BazaarBrachStore needs to use push --overwrite <Launchpad Bazaar Integration:New> <https://launchpad.net/bugs/430354>00:08
thumpermwhudson: ta00:08
mwhudsonjml: the bzr-git tests are failing in that not-really-failing way :(00:08
jml:(00:09
jmlkfogel, hi :)00:09
mwhudsonjml: do you know how i can find out what the failure actually is?00:11
jmlmwhudson, what are the circumstances?00:12
jmlmwhudson, I'm afraid I know next to nothing about the problem.00:12
mwhudsonjml: https://pastebin.canonical.com/22151/00:13
jmloh _those_00:13
jmlmwhudson, I'll need a coffee to help you properly, but I think I've put most of the relevant info in a bug report00:15
mwhudsonjml: can you remember which bug report ?00:15
jmlmwhudson, I'm looking for it now.00:16
jmlmwhudson, http://twistedmatrix.com/trac/ticket/400300:17
jmlthere's one in Launchpad...00:18
mwhudsoni've found the launchpad one00:18
jmlmwhudson, what is it?00:18
mwhudsonhttps://bugs.edge.launchpad.net/launchpad-foundations/+bug/42511300:18
mupBug #425113: Some tests can fail without detection <build-infrastructure> <Launchpad Foundations:Triaged> <Twisted:Unknown> <https://launchpad.net/bugs/425113>00:18
mwhudsonit wasn't triaged (!)00:18
jmllaunchpad overall is rather poor at triage00:20
mwhudsonman wtf00:20
mwhudsonoh00:21
jmlmwhudson, it's a nasty problem.00:22
jmlmwhudson, I can try to address it if you'd like, but I'd really also like to finish off the permissions branch I've started.00:22
mwhudsonjml: i'll dig for a moment myself00:22
jmlmwhudson, ok. let me know if you want context or to bounce ideas.00:23
thumpermwhudson: how do you invoke ec2test now it is a module in the tree?00:29
mwhudsonthumper: ./utilites/ec2test.py is still tehre00:30
thumpermwhudson: ok00:30
thumpermwhudson: I noticed the move, but not the addition00:30
thumpermwhudson: :(00:31
mwhudsonthumper: :( ?00:31
thumpermwhudson: my "hack" of using an alias for ec2test doesn't work00:31
thumpernow it needs a path00:31
* thumper changes the symlink to an alias00:33
barrythumper: ping00:38
mwhudsonjml: a fairly small hack to zope.exception gets things working again00:40
jmlmwhudson, oh nice.00:41
jmlmwhudson, diff?00:41
mwhudsonjml: well what's in eggs isn't in a bzr branch of course :/00:41
mwhudsonjml: but it's "f.f_locals" -> getattr(f, 'f_locals', {})00:41
jml*nod*00:42
thumperbarry: hi00:42
jmlmwhudson, I still suggest twisted should change...00:42
barrythumper: hi will you be around for a while?  i need to run out before the stores close00:42
thumperbarry: yeah, although I might head out for coffee and lunch soon00:42
barrythumper: no worries.  it's gonna be 45m-1h anyway i'm guessing00:42
barrythumper: will ping you when i get back00:43
thumperok00:43
mwhudsonjml: yes, but in the interests of not having undetected failures in our test suite...00:44
jmlmwhudson, oh yes.00:44
jmlmwhudson, I'm very happy to have urgent bandaids applied00:44
mwhudsonjml: maybe this is a cleaner/easier band-aid:00:48
mwhudsonfrom twisted.python.failure import _Frame00:48
mwhudson_Frame.f_locals = property(lambda self: {})00:48
jmlmwhudson, yeah, I think so.00:48
jmlmwhudson, is there anything you'd like me to do wrt this?01:10
mwhudsonjml: review this branch in a bit, i guess01:11
jmlmwhudson, ok, thanks.01:15
jmlmaxb, your unittest branch is up for review01:19
maxbok01:20
maxbor was that a question?01:21
maxbI know it's up for review, I marked the MP as such01:21
maxbkarmic appears safe again, btw, on amd64 and i386, at least if you're using archive or gb.archive01:22
mwhudsonoh, phew, the failures in the bzr-git tests are really shallow01:28
jmlmaxb, sorry, yes it was a question.01:31
jmlmaxb, I'll review it :)01:31
jmloh, in fact I have01:32
jmlhurrah01:32
maxbYou reviewed it without realising?01:32
maxb:-)01:32
maxbjml: "peculiarly" as in "why repeat an operation that your base class is already doing?"01:34
jmlmaxb, it's been a very distracted morning01:34
jmlmaxb, iirc, it's there for Python 2.3 support01:35
jmlbut I can't recall exactly.01:35
* jml does a science thing01:35
maxbfair enough (and that'll be 2.4 support)01:35
jmlmaxb, Twisted supports python 2.3 :)01:35
maxbok, 2.4 and earlier01:36
maxbIt's just a different way of providing such compatibility to which other TestCase subclasses have taken, and less intrinsically clear that it's there for compatibility01:36
maxbhmm, I need to write more branches, that's my last one :-)01:37
jmlright.01:38
jml"WARNING: The following packages cannot be authenticated!"01:40
jmlthe list includes libc6.. wtf01:40
mwhudsonsadness is submitting a merge proposal at ??:?5:?? o clock01:46
jmlyeah.01:49
jmlSomebody should do Something about that.01:49
maxbWhat's special about ??:?5:?? o clock ?01:50
jmlmaxb, the diff on MP pages is generated by a cron job that runs at ??:05:??01:52
jmlrather than by, say, some daemon that's listening for events01:53
mwhudsonjml: thanks for the review01:55
jmlmwhudson, np01:55
barrythumper: ping02:35
thumperbarry: pong02:36
barrythumper: is this a good time to talk?02:36
thumperbarry: lets talk titles :)02:36
thumperyes02:36
barrythumper: cool.  skype?02:36
thumperyep02:36
barryfiring it up02:36
jmlbarry, hey02:37
barryjml: hi02:37
jmlbarry, I know you're talking to thumper right now, but do you know what's going on with the '+filebug' thing appearing in page titles?02:37
jmlactually what I mean to say is... look at the bug I'm about to link to :)02:37
barryjml: salgado was supposed to be landing a branch that allowed views to fix this.  don't know if it landed yet02:38
jmlbarry, but individual views must fix this?02:38
barryjml: i haven't looked at his branch, but i believe this is the case.  there was some talk about labels getting in the act but dunno what the state of that is02:39
jmlbarry, ok, thanks.02:40
jmlbarry, it's a little sad that the default is quite so wrong02:40
barryjml: agreed02:42
jmlbarry, is there something we can do to improve the default?02:53
jml(also, would it be more convenient for me to raise this on the list?)02:54
barryjml: i think it would be better to raise it on the list.  i'm not sure what the state of salgado's branch is, or exactly what it changes02:54
jmlbarry, ok, thanks.02:54
=== abentley1 is now known as abentley
=== barry` is now known as barry
* jml away for a bit03:38
wgrantErm.03:52
wgrantWhy do I see tests for the new braindead titles?03:52
sinzuiwgrant: because we are out of time to do page conversions. It is faster for me to convert pages and send people to add the need breadcrumb adapter afterward04:04
sinzuiwgrant: salgado has a branch that fixes most of the bad breadcrumbs, that will also fix the titles04:04
wgrantsinzui: Ah, thanks.04:14
sinzuiwgrant: I think I can send every team member to fix breadcrumbs after tomorrow04:14
wgrantlaunchpad-project 3.0 is timing out: OOPS-1355EB14604:16
wgrantAh, there we go.04:18
wgrant    At least 1397 queries issued in 15.77 seconds04:19
wgrantAh.04:19
thumperphew04:27
thumperwow04:27
thumperwhich project?04:27
thumperlaunchpad-project?04:28
wgrantthumper: launchpad-project?04:28
wgrants/?/./04:28
* thumper wonders where all the queries are :)04:32
ajmitch1397? that's a little high04:34
wgrantthumper: Doesn't the OOPS tell you?04:35
thumperwgrant: well, yes04:35
thumperwgrant: well, yes and no04:36
thumperit'll tell you what they are, but not where they are called from04:36
wgrantthumper: Ah.04:36
wgrantI haven't looked extensively at the OOPS format.04:36
thumperSELECT BugTag.bug, BugTag.id, BugTag.tag FROM BugTag WHERE BugTag.bug = %s ORDER BY BugTag.tag repeated 700 times04:38
wgrantAh, of course.04:38
thumperSELECT OfficialBugTag.distribution, OfficialBugTag.id, OfficialBugTag.product, OfficialBugTag.tag FROM OfficialBugTag WHERE OfficialBugTag.product = %s ORDER BY tag 394 times04:38
thumperI'm sure it is fast with no data04:38
thumper:)04:38
wgrantIndeed.04:38
* wgrant files a bug.04:39
wgrantIs that malone or launchpad-registry?04:39
sinzuiwgrant: is that the 3.0 milestone page?04:40
wgrantsinzui: Yes.04:40
sinzuirock04:40
sinzuiThat is my excuse to remove the tags04:40
wgrantThat does not follow.04:40
wgrantAh.04:40
sinzuiI think it makes the list hard to read, and I do think they help me understand the bugs I am seeing04:41
wgrantsinzui: Did you mean "I do not think they help me[...]"?04:41
sinzuiwgrant: yes.04:42
wgrantsinzui: They should be useful, but are not in their current location.04:42
wgrantsinzui: And why do I have an empty sidebar on that page?04:42
sinzuiright04:42
wgrantIt takes up some large horizontal fraction of my screen, and is empty.04:42
sinzuiwgrant: You cannot subscribe to bugs on that page?04:43
* sinzui liked the page without the side bar04:43
wgrantsinzui: I can't. That seems like a bug.04:43
sinzuiIt is04:43
wgrantOh.04:43
wgrantIt's the project, not product, milestone page.04:43
wgrantSo it's not a real thing to be subscribed to.04:43
sinzuiright...04:44
sinzuiI can make the side discretional in the template.04:45
wgrantsinzui: But that leaves a largely useless sidebar on other milestones.04:45
wgrantIs there nowhere better to put the link?04:46
sinzuiI can use a horizontal list after the description. It breaks style and may confuse user, but *I* think it makes the page usable.04:47
stubhuh. I killed rocketfuel-get at the wrong point and managed to lock lp:~launchpad/lp-source-dependencies/trunk. Surprised pulling that branch requires a lock!04:47
wgrantsinzui: Possibly put it at the bottom of the Activities portlet, with the bug stats?04:47
sinzuiwgrant: Edit and delete do not belong there.04:48
wgrantsinzui: It's not editing in the traditional sense.04:48
sinzuiagreed, certainly not when the milestone has a release04:49
sinzuiI can make something that looks like the side portlets and float it to the right.04:50
wgranthttps://edge.launchpad.net/~wgrant/+archive/ppa/+packages does something not too bad.04:50
wgrantAlthough I'm sure it breaks the guidelines.04:51
wgrantIt might be better if it had the same gray background.04:51
sinzuiIt does, but a side portlet with one item is dumb04:52
sinzuiYea. I will try that after I sleep04:52
wgrantGreat.04:52
thumpersinzui: what's the status of the page_title breadcrumb?04:57
sinzuisalgdao is doing test fixes to the branch. I think I can land tomorrow04:58
sinzuithumper: we have made it hard on him since we keep landing pages04:58
* thumper nods04:59
thumperhow come no one told me I needed to create a named IBreadcrumb adapter for "code"?04:59
thumperI spent ages chasing why I wasn't seeing breadcrumbs04:59
sinzuithumper: I'll ask salgado to explain what is happening05:01
thumpersinzui: I think it'll help, but I understand it now05:02
sinzuibarry and salgado had a few meeting about this. I do not think their work plays well together05:02
thumpersinzui: what would help is knowing how to add additional breadcrumbs05:02
thumpersinzui: like "Active reviews for XYZ"05:02
thumperI can create custom IHierarchy adapters (like we have now)05:03
thumperI'm wondering if there is a simpler way05:03
sinzuithumper, interesting problem. since crumb is a traversed object, I think you need to pop an object onto the stack, or ...05:03
thumperit is a view, not an object05:04
thumperI need to have a fake object that has a breadcrumb relating to the page05:04
sinzuithumper: views are an object, that is why the view name is in the crumbs05:04
thumperyeah, yeah05:04
thumper...05:04
thumperI'm trying to fix my last few pages first05:05
=== poolie1 is now known as poolie
* sinzui stumbles to bed05:05
thumperI want to have a view that is registered against two interfaces05:05
thumperthe problem is that one object implements both interfaces05:05
thumper:(05:05
* thumper wonders how helpful the #zope channel is05:06
* sidnei raises an eyebrow05:07
sidneithumper: you might get better help on #plone05:07
thumpersidnei: really?05:08
sidneithumper: surely05:08
thumpersidnei: ta05:08
BjornTthumper: i don't see where the problem is. can you give an example of what you're trying to do?05:09
thumperBjornT: normally zope complains if there are two directives that can apply to one context object05:09
thumperBjornT: I have a view that I want for the majority of implements of IHasMergeProposals05:10
jmlback05:10
thumperBjornT: but I want a special one for IPerson05:10
thumperBjornT: and a person implements IHasMergeProposals05:10
BjornTthumper: hmm, ok. i guess zope doesn't complain, but you don't know which of the views will get used for Person?05:12
thumperI think it does complain05:13
* thumper checks05:13
BjornTthumper: one solution would be to make IPerson inherit from IHasMergeProposal, except that registry shouldn't depend on code...05:14
wgrantBut Registry depends on *everything*... is that wrong?05:14
thumperBjornT: it does right now05:14
jmlwgrant, it's a work in progress.05:14
stubYou might be able to do it by registering an adapter for Person -> view rather than IPerson -> view05:15
wgrantjml: How will that work? Adapting things to ICodeProduct or whatever?05:15
jmlwgrant, well, we already do a great deal of that in lp.code05:15
jmlwgrant, see IBranchTarget, etc.05:15
wgrantTrue.05:15
BjornTwgrant: yes. in an ideal world, everything can depend on registry, but registry shouldn't depend on code, bugs, soyuz, etc.05:15
thumperBjornT: however our API decisions violate that05:15
wgrantBjornT: But that seems impractical unless a huge amount of adaption is involved.05:15
jmlwgrant, how it will work with the REST APIs is another, and much more interesting, question.05:15
wgrantjml: True.05:16
thumperBjornT: as we mix everything in05:16
jmlwgrant, "impractical"?05:16
jmlwgrant, dumping huge amounts of responsibility on Person and Product is equally impractical.05:16
thumperBjornT: if there is interface inheritance, does it take the most derived?05:16
wgrantjml: That's not impractical at all. It makes sense, unless you start splitting the apps up.05:17
BjornTthumper: yes. i wonder, why do you need breadcrumbs for IHasMergeProposals? what does that view look like?05:17
thumperBjornT: the breadcrumbs that beuno wanted was to show "Active reviews for XYZ" when looking at a bmp05:18
thumperI'm not yet convinced05:18
thumperbut at least now I know more what I need to do to fix the breadcrumbs05:18
thumperBjornT: I'm actually looking at the +activereviews registration05:18
thumperBjornT: if I can register +activereviews against IHasMergeProposals, but specialise for IPerson05:18
thumperBjornT: then that is a good thing05:19
jmlwgrant, I disagree.05:19
wgrantjml: Why does it not make sense to have the methods of a Person on IPerson?05:19
jmlwgrant, it violates the principle of single responsibility05:19
wgrantjml: A distribution has lots of binary packages. Distribution.searchBinaryPackages should not exist, simply because Soyuz owns BinaryPackageRelease?05:20
jmlwgrant, and they are not, intrinsically, methods of a person05:20
stubthumper: You can avoid importing code into registry if you want. Create IPersonHasMergeProposals in code and attach that marker interface to Person in code's zcml.05:21
jmlwgrant, I'm not completely happy with the way we've decided to arrange our tree05:21
jmland soyuz / registry seems a particularly thorny case05:21
wgrantIt is.05:21
wgrantSome structural things ended up in Registry.05:22
wgrantBut others didn't.05:22
wgrantAnd they're all very tightly bound to the rest of Soyuz.05:22
thumperstub: but it adds a method that a person must implement05:22
thumperstub: it uses the mixin idiom we use05:22
jmlwgrant, so I would love to hear of better ways to split up the tree05:22
stuboic.05:22
thumperalthough05:22
thumper...05:23
wgrantjml: Run away!05:23
thumperwe could just adapt...05:23
stubIndeed05:23
thumperwe have the technology05:23
BjornTthumper: i think you can only do that, if IPerson inherits from IHasMergeProposals. looking at it, it looks like it does do that already. we have to think about how to handle this case with our new code structure05:23
thumperstub: but right now, with the API, to give a person the abiltiy to getBranches we need a mixin05:23
thumperBjornT: what are the planned changes?05:24
BjornTthumper: IPerson is in registry, so it can no longer inherit from application-specific interfaces, like IHasMergeposals, IHasSpecifications, and so on05:25
wgrantHow is lazr.restful going to work?05:25
thumperBjornT: I'd be happy for the change if we can work out the API05:26
thumperit seems kinda kludgy right now05:27
BjornTthumper: yeah. it's a nice idea in theory, but we don't yet know how to actually do it practically05:27
thumper:)05:27
thumperthinking is easy05:28
thumperdoing is hard05:28
jmlmeh.05:29
jmlthumper, if you don't know what to do, you haven't finished thinking yet.05:29
thumper:)05:30
thumpertrue05:30
thumperkeep thinking jml05:30
jml(but a good way to push thinking along is to do something!)05:30
lifelesssounds like you want an Extension concept05:51
thumper:(05:53
thumperbuild failed05:53
thumperno space left on device05:53
thumpermwhudson: just rekick?05:53
mwhudsonthumper: yeah :(05:53
* mwhudson is reorganizing ec2tests command line parsing code05:56
* mwhudson is going to the pub later05:56
mwhudsonthis is merely a happy coincidence05:57
jmlmwhudson, :D06:00
jmlwhich database are the tests using?06:05
mwhudsonlaunchpad_ftest06:06
mwhudsonwhich iirc doesn't actually exists apart from when a test is running06:06
mwhudsonit's copied from launchpad_ftest_template06:06
jmlthanks.06:07
jmlI'm trying to figure out why this apparently correct code isn't working.06:07
mwhudsonjml: soyuz hates you?06:10
jmlyes.06:11
jmlone day, I hope to make it afraid of me.06:11
thumpersometimes zope is very cool06:13
jmlthumper, what's it done now?06:14
thumperjml: registering views against IHasMergeProposals :)06:15
thumperjml: what zope is good at06:15
jmlthumper, ahh yeah.06:15
thumperjml: that with branch collection adaptation FTW06:15
jmlheh :)06:16
jmlthumper, jkakar has been sending me interesting emails about use of a similar pattern in landscape06:16
jmlI really must get around to actually reading them and maybe even replying.06:16
* thumper has just fixed (deleted) the last remaining old style template for code06:19
* thumper EODs for now06:19
jmlthumper, yay06:20
jmlthumper, have a good evening06:20
jmlthe relationships between soyuz objects are very complicated.06:35
mwhudson(+1, understatement)06:37
jmlI just hope that this actual behaviour I'm reaching for makes sense.06:38
mwhudsonflymake-mode has changed my life06:41
jmlmwhudson, heh :)06:41
jmlmwhudson, any particular instance this time?06:42
mwhudsonjml: just help when refactoring06:42
mwhudsonjml: copy paste block of code into function06:42
mwhudsonjml: add arguments to function until pink goes away06:42
jmlmwhudson, yeah.06:42
jmlthat's a nice thing06:42
jmlalthough it always makes me wonder how much more automated it could get06:43
lifelessbrm06:43
jmlnever really made my life any better when I used it06:44
=== henninge is now known as henninge-bbl
* mwhudson EODifies07:04
mwhudsonjml: want to review this branch chock full of fun tomorrow?07:05
mwhudsonit's here for now bzr+ssh://bazaar.launchpad.net/~mwhudson/launchpad/ec2-entrypoints07:05
jmlmwhudson, yes.07:08
jmlmwhudson, I might even review it today...07:08
mwhudsonjml: it needs docstrings, i know that much07:09
jmlheh heh07:14
mwhudsonoh and copyright headers and __all__ and so on07:15
jml*nod*07:20
wgrantjml: What are you fighting with Soyuz about this time?07:22
jmlwgrant, permissions, still.07:26
jmlwgrant, but I think I've won this battle07:26
maxbjml: what was your feel on my py2.5-unittest-compatibility? You did "review approve" but not "merge approve"07:33
jmlmaxb, I review approved.07:35
jmlmaxb, but I confess I forgot that you can't land branches yourself :)07:35
jmlmaxb, so I was expecting you to change the comment or not at your discretion and then land it :)07:35
* maxb reminds jml that self-landing is not an option :-)07:36
jmlmaxb, do you want to tweak the comment? if yes, please do so and poke me. if not, I'll land your patch now.07:36
lifelessmaxb: what is the thing you find odd?07:37
lifelessmaxb: or rather what makes it odd to you?07:37
maxbthat it should redo logic that its base class's __init__ does too07:37
maxbok, one edited comment coming right up07:38
jmlmaxb, heh, thanks :)07:38
maxbI'd lost track of whether the "peculiarly" was in the BMP or the code itself07:38
lifelessurgggle, unitteset._CmpToKey07:39
lifelessthat really should be in e.g. list.something07:39
jmlI'm doing too many tasks at once. Please give me a moment while I serialize a few of them.07:40
maxbjml: "chooses to write to it .... as part of its own method of arranging for pre-2.5 compatibility" ?07:40
jmlmaxb, perfect.07:41
lifelessI must admit to curiousity about why the property is needed07:41
lifelessI'm guessing something is being naughty07:42
maxbpushed, many thanks for the attention during this branch's bumpy path to this point07:43
jmlmaxb, np. I'll land that now.07:43
mwhudsongood grief, ec2 demo works07:46
jmlzomg.07:46
pooliejml https://bugs.edge.launchpad.net/launchpad/+bug/43050407:47
poolie(no action needed)07:47
mwhudson(which probably isn't true on trunk btw)07:47
jmlmwhudson, has your headless improving branch landed on stable yet?07:48
mwhudsonjml: dunno about stable, it's in devel though07:49
jmlmwhudson, ok. I'll run from there, see how things work out. :)07:50
maxbwhat's ec2 demo? make run, in an ec2 instance?07:52
wgrantYep.07:54
wgrantWoah. ec2test is split.07:54
jmlheck yes07:55
jmlmwhudson has skills.07:55
jmlalso, ec2test --headless takes much less time. hurrah.07:56
jmlmaxb, your branch is submitted. you'll get an email when the test run finishes.07:57
wgrant"# Perl allows for inplace editing unlike sed."07:57
wgrantsed -i?07:57
* jml shrugs07:58
maxbthanks07:58
maxbbye07:58
jmlmaxb, bye.07:58
jmlwgrant, you wouldn't happen to be rewriting it in Python, would you?07:58
wgrantjml: Can't really do that without a public AMI!07:59
wgrantAnd no.07:59
jmloh. pity.08:00
adeuringgood morning08:24
jmladeuring, hello08:53
adeuringhi jml!08:53
mrevellGuten morgen09:26
jmlg'night all :)09:31
wgrantbigjools: Available for a few ddeb-related questions?09:54
bigjoolswgrant: yes, ask away, but I am pretty busy and have a call in 5m so I'll do what I can09:55
wgrantbigjools: Great, thanks.09:56
wgrantbigjools: process-death-row currently crashes on copy/debug archives, because they lack an archive_url.09:56
wgrantI guess it's important for debug archives, but not copy archives as they're not published.09:56
wgrantShould I define an archive_url for debug archives?09:56
bigjoolswgrant: yes, sounds sane09:57
bigjoolswgrant: https://bugs.edge.launchpad.net/soyuz/+bug/24414509:58
mupBug #244145: process-death-row script chokes on rebuild archives <derivation> <Soyuz:Triaged by al-maisan> <https://launchpad.net/bugs/244145>09:58
wgrantbigjools: Ah!09:58
wgrantbigjools: Second one: ddebs really want to follow their debs around very closely. I plan to adjust the ftpmaster-tools and various internal methods to search for binaries owned by a source inside the debug archive as well, and possibly add some extra magic to change-override and lp-remove-package to drag the ddebs along when their debs are operated upon directly.10:00
wgrantSounds sane?10:01
wgrantThird: Copies are going to get pretty broken and confusing after this. Argh.10:01
bigjoolswgrant: gimme a few mins, I have a call10:03
wgrantbigjools: Sure.10:03
wgrantI wonder whether forcing the archive in newSourcePublication is enough, or if it should be done at a higher level...10:04
wgrantTime to write lots of tests, I guess!10:04
=== bigjools-afk is now known as bigjools_
bigjools_wgrant: it would be good if you could send email to -dev to enumerate all the places you need to fix for ddebs in the separate archive, then we can have a think about it, it's a somewhat scary change10:37
=== bigjools_ is now known as bigjools
wgrantbigjools: I shall prepare an email -- I hadn't thought about this aspect of it until yesterday.10:41
bigjoolswgrant: great, thanks10:42
deryckMorning.10:58
bigjoolsbeuno, deryck: https://bugs.edge.launchpad.net/malone/+bug/43059311:07
mupBug #430593: New milestone listing page's bug tags are easily confused with the description <Launchpad Bugs:New> <https://launchpad.net/bugs/430593>11:07
=== al-maisan_ is now known as al-maisan
deryckbigjools, yeah, that is confusing.11:10
bigjoolsderyck: right-floating them would help, but ideally a separate column on the same line11:13
deryckbigjools, ok.11:14
bigjoolsderyck: and if you can fix bug 262545 at the same time that'd be *great* :)11:15
mupBug #262545: Milestone listings should show the bugs' titles/descriptions in a tool tip <milestone-management> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/262545>11:15
deryckheh11:15
wgrantBonus points for reducing the query count (OOPS-1355EB146)11:15
bigjools:)11:16
bigjoolsoh wgrant, what's the issue with package copies and ddebs again?11:16
wgrantbigjools: I guess delayed copies should be fine, but a direct copy with binaries between distroseries or to a PPA is going to require Magic to both pick up the right binaries, and put them in the right place.11:17
bigjoolswgrant: right11:18
bigjoolswgrant: reminder: you have until next wednesday to give me your top three 4.0 wishes11:24
wgrantbigjools: I'd remembered that, but have so far received zero responses on the mailing list. I will send a reminder.11:24
bigjoolsok :/11:25
wgrantSomething like that.11:25
bigjoolsif I don't get anything, then I'll proceed with what *we* think is important, which may not be the same as what you guys think11:25
wgrantOf course.11:25
bigjoolsta very much11:27
wgrantI'll hopefully be able to give you something, but I can't unless others give me something.11:27
bigjoolsif you don't hear anything, your opinion would still be better than nothing11:31
wgrantPossibly.11:31
BjornTcan someone with a recent SUCCESS mail from a ec2test run tell me how many tests were run?12:20
simon-oHi, I tried to send an email to launchpad-dev@lists.launchpad.net but got an error message. Is this a known error?12:29
barrysimon-o: what error did you get?12:30
simon-obarry: http://paste.ubuntu.com/272035/12:31
simon-oIf I try to connect to lists.launchpad.net on port 25, I get a "Connection refused"12:32
barrysimon-o: yep, i just tried the same thing and got the same error12:32
barrysimon-o: thanks for letting us know.  i'll ping our admins12:32
simon-obarry: thanks12:33
danilosbigjools, I see you commented on the last buildbot failure: do you know what that might be about?12:34
bigjoolsdanilos: the usual out of disk space12:36
bigjoolsno idea why, our buildbot expert needs to take a lookl12:36
danilosbigjools, heh, ok, figured that much out myself... ok, thanks12:36
danilosbigjools, would it be worth retrying the build?12:36
bigjoolsdanilos: that one was the result of re-trying... but no harm in doing it again12:37
barrysimon-o: try it now.  mta on that box was just restarted and i can telnet to it okay12:40
simon-obarry: telnet works fine and the email got through. thanks12:42
barrysimon-o: cool12:48
=== matsubara-afk is now known as matsubara
=== mrevell is now known as mrevell-lunch
danilosgmb, intellectronica: is there a known problem with bug description editing ("Entity body is not a well formed JSON object")?13:37
jtvIt's failing on staging as well.13:37
gmbUrrr...13:37
gmbNot one that I'm familiar with.13:37
* gmb looks13:37
danilosgmb, I think I've seen this yesterday as well, but attributed it to my epiphany-webkit usage... having tried again today with firefox, it's really not working for me13:37
jtvHmm... I tried editing another bug on staging and replacing the description with just "x".  That worked.13:38
wgrantThere's a bug for that.13:38
jtv(At least I hope I did that on staging ;)13:38
danilosgmb, perhaps intellectronica added something like if user.inTeam(rosetta_admins): no fancy ajax editing for you13:38
daniloswgrant, ah, ok, I thought I'd ask first13:38
gmbHeh.13:38
wgrantBug #42462513:38
mupBug #424625: use native python for manipulating images <Photo Frame Prep:New> <https://launchpad.net/bugs/424625>13:38
wgrantNot that one.13:38
wgrantBug #42464513:39
mupBug #424645: Entity-body was not a well-formed JSON document. <Launchpad itself:Confirmed> <https://launchpad.net/bugs/424645>13:39
gmbwgrant: Ah, thanks.13:39
daniloswgrant, thanks13:39
danilosand it's "Confirmed"... we don't use "confirmed" :)13:39
gmbdanilos, jtv: Can't reproduce it on staging or edge atm, but I believe you :)13:40
jtvweirdly enough, on staging, I can enter the same text in a different bug.13:40
jtvA-hah!13:40
danilosgmb, reassiging the bug to malone, fwiw, you guys can take it from there13:41
jtvI was adding it to another bug.  If I put it at the top, it seems to break.13:41
gmbdanilos: Righto.13:41
danilosallenap, the base branch is devel, you can look at the diff for now, but I'll take a look at what's going on there13:44
allenapdanilo-afk: Don't do anything! It was my fault.13:44
danilosallenap, ok, and sorry about the wrong channel (though, we might be making kfogel happy :)13:45
allenapdanilo-afk: I pulled devel this morning, but it was on a different machine.13:45
danilosallenap, heh, multiple machines are bad for your health13:45
allenapdanilos: Yes, I've not heard that one before, but I'll take your word for it :)13:46
intellectronicadanilos: that's a known problem. i think deryck might know a bit more about this13:46
danilosintellectronica, cool, thanks13:46
intellectronicadanilos: and no, i have no objection for clerks from other departments using ajax, as long as they fill in the correct forms (in three copies)13:47
deryckintellectronica, danilos -- yeah, entity body bug is known.  I thought the bug was triaged for this cycle.  But the one I was just subscribed to isn't.13:48
* deryck looks13:48
deryckbug 423924 is the one that will be fixed.13:49
mupBug #423924: Entity-body was not a well-formed JSON document when updating bug description <Launchpad Bugs:Triaged by deryck> <https://launchpad.net/bugs/423924>13:49
deryckand geez, it's wednesday, I need to hunker down on some bugs.13:50
deryckbarry, ping13:50
barryderyck: pong13:53
=== mrevell-lunch is now known as mrevell
* gmb -> out for a while; back later14:14
bachi sinzui -- i'm looking for templates.  the page shows 8 outstanding.  any taken?  any suggestions?14:20
sinzuibac: yes. We have a dependency issue with these last templates14:21
barrybac: i will be looking for more templates to convert too14:21
sinzuibac: barry: lets discuss how to land these during our call. Lots of things breack when person +edit changes14:23
bacsinzui: ok14:23
barrysinzui: +114:23
BjornTbarry: ping?14:26
barryBjornT: pong14:26
BjornTbarry: why does AppServerLayer start an smtp server?14:26
barryBjornT: originally it was because the mailman integration tests need to talk to a real smtp server.  it's possible we could move that into the MailmanLayer now though (i'm not sure what, if anything else not in that layer depends on it)14:27
BjornTbarry: hmm. registry/tests/test_mlists.py seems to use the smtp server. could it use MailmanLayer, instead of AppServerLayer? or do you have any suggestion of an easy way of not hard coding the smtp port number?14:33
barryBjornT: i don't think we want to move that to MailmanLayer.  One problem with that layer is that it doesn't run by default and we have an open bug on running it in a cron14:37
barryi'll have to think about the port hardcoding; it was difficult last time so i punted ;)14:38
barrygary_poster: we suck again ;/  let's just admit we won't get to this until after 3.014:40
mrevellgary_poster: ping14:40
barrygary_poster: and by "we" i probably mean "me" ;)14:40
gary_posterbarry: are you talking about the reviewer bits?14:44
gary_postermrevell: pong (sorry was on call)14:44
barrygary_poster: yep14:44
henningebarry: has the heading situation changed, again?14:48
henningebarry: on normal pages, I provide a 'label' that is placed as an H1 *above* the breadcrumbs, right?14:48
kfogeldanilos: you made me happy :-)14:48
barryhenninge: not for 2 days now afaik :)14:49
barryhenninge: you need a label on your view yes, but it maybe be an h1 or an h214:50
barryhenninge: depending on whether your view implements IMajorHeading or not14:50
barryhenninge: and it should only implement that marker interface if your page is the +index page of the root context14:50
henningebarry: yes, but I am not talking about the latter14:51
=== salgado_ is now known as salgado
henningebarry: does this look correct? http://people.canonical.com/~henninge/screenshots/pofile-details.png14:51
henningebarry: or this http://people.canonical.com/~henninge/screenshots/pofile-translate.png14:52
barryhenninge: yep, that looks right14:52
barryhenninge: second one looks right too14:52
henningebarry: all I do is provide a 'label', nothing else.14:52
henningebarry: cool, thanks14:52
barryhenninge: right.  for most pages, the default just DTRT14:52
barrywell, default + 'label'14:52
flacosteRegistry has 8 templates left!14:52
flacostewow, this was a marathon!14:53
BjornTbarry, flacoste: does this patch look sane? http://pastebin.ubuntu.com/272138/15:03
barryreviewers -> #launchpad-meeting15:04
flacosteBjornT: if it actually solves the problem, r=me!15:07
flacostelooks sane to me anyway15:07
BjornTflacoste: thanks, it does solve the problem! well, i'll try to run the mailman tests, to make sure it didn't break anything15:08
barrybeuno: do you want to join us over in #launchpad-meeting?15:09
jmlmaxb, you around?15:19
allenapintellectronica: On https://bugs.launchpad.net/ubuntu/+source/debhelper/+bug/427356 (and almost certainly every other bug index), lp.picker and lazr.activator get run multiple times. By that I mean that the message "loading lp.picker" (and "loading lazr.activator") are logged many times.15:48
mupBug #427356: Boot Performance Updates <acpid (Ubuntu):Fix Released> <anacron (Ubuntu):Fix Released> <apport (Ubuntu):Fix Released> <at (Ubuntu):Fix Released> <avahi (Ubuntu):Fix Released> <cron (Ubuntu):Fix Released> <cryptsetup (Ubuntu):Fix Released> <cups (Ubuntu):Confirmed> <dbus (Ubuntu):Fix Released> <debhelper (Ubuntu):Fix Released> <gdm (Ubuntu):Fix Released> <hal (Ubuntu):Fix Released> <hostname (Ubuntu):Fix Released> <ifupdown (Ubuntu)15:48
allenapintellectronica: I've tried to figure out why, but can't, unless YUI().use(..., 'lp.picker',...) is not using the already loaded version.15:52
allenapintellectronica: Ah, YUI().use(...) creates a new Y, so I guess it must run each module again. That would explain things. Seems a shame to do this so many times in a page load though.15:53
maxbjml: for a few minutes15:53
intellectronicaallenap: that's not a problem, other the annoying logging15:55
intellectronicaallenap: there are multiple pickers because there are multiple rows15:56
=== deryck is now known as deryck[lunch]
allenapintellectronica: Yes. The thing is that the lp.picker library code is being run ~20 times. If we did all the initialisation of the bugtask rows in a single YUI().use() block, then it would only be run once.15:57
intellectronicaallenap: i'm not sure i understand. the module is only loaded once (yui takes care of that). the widget is being initialized 20 times if there are 20 widgets (two for each bugtask). i don't see any way around that, nor do i think this is a problem. am i missing something?15:58
henningeSince when did test_suite become obsolete in unit tests? Does anybody know anything about this?15:59
henningeAre tests added automagically now?15:59
allenapintellectronica: I think YUI is running the lp.picker module ~20 times, rather than just once, because the "loading lp.picker" message is within the Y.add() in lp/picker.js.15:59
allenapintellectronica: And lazr.activator is being run ~20 times too because it's required by lp.picker.16:00
intellectronicaallenap: oh wow, you're right. that is truly bizarre!16:01
bacsinzui: call?16:01
=== carlos__ is now known as carlos
intellectronicaallenap: i would have expected yui to only load the module once. that's the whole point, innit?16:02
BjornTflacoste: call?16:03
allenapintellectronica: Yeah. The file is cached by the browser at least. I think, to create the Y that's passed into the function(Y) {...}, it has to run each of the modules mentioned in the use(...) call.16:03
sinzuibac yes16:04
intellectronicaallenap: it doesn't make any sense to me. sounds like a bug. if you have to run all modules each time yui use() them, then it means that you should have as few uses as you can. but that means that it really doesn't make sense to do it the way we do, where we isolate every call16:05
allenapintellectronica: Put another way: YUI().use('mod', 'another_mod', function(Y) {...}) creates an empty Y object then runs mod and another_mod in that namespace.16:05
flacosteBjornT: yes16:05
intellectronicaallenap: more annoyingly, to get around that, we'll need to somehow pass all row data in one go. that's doable, but we can no longer rely on the template to do that16:06
allenapintellectronica: Yeah, agreed. I don't think it's a bug, but perhaps the amount we use it is excessive.16:06
sidneiintellectronica: it is possible to cache the global YUI object, by doing 'Y = YUI().use()....' and then pass 'Y' into your function16:06
intellectronicasidnei: aha! that's a nice solution16:07
intellectronicaallenap: i think that's definitely worth doing on the bug page, since there are so many call sites16:07
allenapintellectronica: The other way of doing this is to put the row data in a hidden <span class="row-data">{...json...}</span>, then the setup can run once, find these and use them.16:08
intellectronicaallenap: that's a pretty nasty workaround. if we have to do that we might as well generate it all in the view, no?16:09
intellectronicai mean the top-leve view, not the row view16:10
allenapintellectronica: Yeah, you're right. Probably easier to test too.16:10
intellectronicasidnei, allenap: you should totally write about that to the rhinos ml. i had no idea, and this is likely to become an issue as we add more ajax to pages16:10
sidneiintellectronica: good idea16:11
allenapsidnei: You or me then?16:12
sidneiallenap: you? :)16:12
allenapsidnei: Okay :) I might do it tomorrow, but sure.16:12
intellectronicamy appreciation of YUI3 just dropped significantly (though of course it was based on completely bogus premises)16:12
=== deryck[lunch] is now known as deryck
=== matsubara is now known as matsubara-lunch
deryckintellectronica, allenap -- admittedly I'm only scanning scrollback just now, but I wonder if this is better in the beta release, i.e. that modules are more smartly re-used?17:00
deryckI'm talking about the YUI discussion17:01
intellectronicaderyck: no idea. i also thought that this is a feature yui3 provides, and so i'm inclined to believe that this is improved in future versions, but maybe i simply expect too much from yui17:02
allenapderyck: It might be. I'll write to the list; maybe someone there will either know or find out. However, owing to how the Y objects are created, I doubt there's a ton that can be done.17:02
allenapderyck: Well, not really how they're created, but the fact that a new one has to be built for each invocation of YUI().use().17:03
deryckintellectronica, allenap -- ok, thanks for chasing this down.17:05
=== danilos is now known as danilos-afk
allenapderyck, intellectronica: By the way, although this stuff is slowing down the bug page, I don't think it's what's causing bug 430288, unless there's a very indirect cause and effect.17:06
mupBug #430288: Major page load time regression in 3.0-dev for many-bugtask bugs <Launchpad Bugs:Triaged by allenap> <https://launchpad.net/bugs/430288>17:06
deryckallenap, but your comments on the bug do indicate where you think the troubles might lie?17:07
intellectronicaallenap: also, if by 'load times' what is meant is really 'initialization time' it's worth changing the bug summary. i thought it's about the time it takes to render the page and send back the response17:08
=== salgado is now known as salgado-lunch
allenapderyck: Yes.17:08
deryckallenap, cool17:08
deryckI think of load time as the whole process -- server response through browser render.17:09
deryckbut maybe that is just me17:09
allenapintellectronica: Good point. I've updated the description and title.17:09
intellectronicanah, maybe i'm just not used to thinking about it because that wasn't traditionally a problem on LP (while rendering the page has)17:10
allenapderyck: Me too, but in this case it's probably worth being specific because the server time is roughly the same between lpnet and edge.17:10
deryckyeah, definitely agree we should be more specific.  Was more just thinking out loud about the phrase "load time"17:11
intellectronicai think we can conclude that if you can think out loud of the phrase "load time" and the page still hasn't loaded then we've got a problem :)17:14
bigjoolshow do I get an email with a diff in it from the MP page?17:16
bigjoolsabentley? ^^17:18
abentleybigjools: There isn't a way.  See bug #307461.  However, you should have received it from your launchpad-reviews subscription.17:19
mupBug #307461: Provide a way to start doing a review by email from web page. <code-review> <confusing-ui> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/307461>17:19
bigjoolsabentley: ah forgot about that, thanks17:20
mrevellnight all, back on later17:57
keesI have an API search that seems to be hanging forever18:03
keesthe UI works fine:18:03
keeshttps://bugs.launchpad.net/ubuntu/+bugs?field.searchtext=Signal%3A+11&orderby=datecreated&search=Search&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.component-empty-marker=1&field.status_upstream-empty-marker=1&field.omit_dupes.used=&field.omit_dupes=on&field.has_patch.used=&field.has_cve.used=&field.tag=apport-crash&field.tags_combinator=ANY&field.has_no_package.used=18:03
kees    tasks = lp.distributions['ubuntu'].searchTasks(tags='apport-crash', order_by='-datecreated', omit_duplicates=True, search_text="Signal: 11")18:03
keesbut the API never returns18:03
kees(or rather, it seems to be loading them ALL before returning....)18:05
keesstrace shows activity18:05
=== matsubara-lunch is now known as matsubara
keesis there something that can be done about this, or a way to report back progress?18:09
=== salgado-lunch is now known as salgado
rockstarbarry, do you know if it's safe to upgrade karmic packages yet?18:37
barryrockstar: i haven't upgraded today.  i got lucky yesterday though; upgrading before the fubar18:39
barryrockstar: you feeling brave? :)  i probably won't attempt it until after i finish the next branch i'm working on18:39
rockstarbarry, well, I'm getting weirdness, so I almost did it before I remembered what maxb said yesterday.  I'm just going to ignore it and try my best to get my work done.18:40
barryrockstar: i'm pretty sure maxb said it was safe to upgrade late last night18:41
maxbYesterday's fubar was past by around 0200 UTC IIRC18:41
barrymaxb: thanks!18:41
maxbI'm not ruling out *new* weirdness, though :-)18:41
barry:)18:42
rockstarmaxb, can you get identical hardware to me and test before I upgrade in the future?  kthxbai18:42
rockstar:)18:42
maxbjml: PQM sulked, I take it? :-)18:54
rockstarmaxb, jml is .au - so he is probably sleeping right now.18:58
maxbah, ok. I've just got a second ec2test success email for a branch, so I'm assuming the first submission to PQM vanished somehow18:59
maxbOn that topic, how long is normal from ec2test submitting to PQM, to it actually landing?19:00
maxbShould someone remind Florian Effenberger on launchpad-dev@ about the image licensing terms?19:10
intellectronicamaxb: depends what machine size you're using, but i believe it's somewhere around 4h these days19:16
maxbno, I mean from when ec2test completes and hands off to PQM19:16
intellectronicamaxb: oh, maybe i didn't read the question right. once ec2 submits to pqm it's only about 5 minutes, unless there's stuff in the queue before that19:16
maxbI guess the queue's busy today19:17
intellectronicamaxb: the queue itself is variable. some branches need a test suite run, others don't (and only take about 5 minutes)19:17
intellectronicamaxb: there are two branches in front of yours in pqm. neither need a test suite run, so you can expect yours to land soon19:18
maxbrevisions seem to be going into devel at about 20 minute intervals right now19:18
dhillon-v10deryck: hi how are you19:23
deryckdhillon-v10, hi, on call :)  Sorry19:24
dhillon-v10finally got a hold of you :)19:24
deryckdhillon-v10, were we supposed to chat today?19:25
dhillon-v10i have some time do you?19:25
dhillon-v10if not then we can talk later19:25
deryckdhillon-v10, on call right now19:25
deryckdhillon-v10, let me email you later19:25
dhillon-v10oh, sorry19:25
derycknp19:25
flacostegary_poster: that's what i get when running python bootstrap.py in lazr.restful: http://pastebin.ubuntu.com/272305/19:49
flacosteany idea?19:49
flacostehttp://pastebin.ubuntu.com/272306/19:49
flacosteand that's what i get if I try python2.5 bootstrap.py19:49
gary_posterflacoste: not off hand no19:50
gary_posterhave not seen that19:50
gary_posterflacoste: karmic?19:50
flacostegary_poster: no, Jaunty19:51
gary_posterflacoste: ...python2.4 bootstrap.py works fine on karmic for me.19:53
flacostegary_poster: still fails here19:54
flacostepython2.4 gives the same error than python2.519:54
flacostepython-setuptools isn't installed19:55
flacostebut was in the past19:55
flacostei'll install again and try agian19:55
flacostegary_poster: with python-setuptools installed, python2.5 works19:56
gary_posterflacoste: setuptools is not installed for me19:56
flacostebut you are on karmic on a new install19:56
gary_posterflacoste: it may be that installing and uninstalling leaves something unpleasant around.  would you like me to try that?19:56
gary_posteri.e., do you want me to investigate?19:57
flacostegary_poster: nah, i'm moving on19:57
gary_posterok19:57
flacosteif it happens again, i'll investigate19:57
flacostegary_poster: lazr.youpkg still has19:57
flacostesys.path.insert(0, 'src')19:57
flacostefrom lazr.yourpkg import __version__19:57
flacostein it, is that correct?19:57
gary_posterprobably.  we've fixed everything else19:59
flacostegary_poster: ok, i thought we didn't want to do this import try from setup.py anymore19:59
flacostebut since you've fixed buildout19:59
flacostemaybe we don't care anymore19:59
gary_posterwell, ubuntu still doesn't like it20:00
gary_posterso it is worth changing20:00
gary_posterI'll get to it20:00
flacostegary_poster: what's the new thing to do? use a static version in setup.py?20:01
flacosteand no __version__?20:01
gary_postersee how it is done in lazr.restful: version.txt in package, setup.py loads the value into __version__ by reading the file, and __init__.py uses pkg_resources20:02
gary_posterto load it into __version__20:02
gary_posterflacoste: actually, note that the __init__.py still has some old cruft: the try:except is no longer necessary20:03
flacosteok, thanks20:05
=== cprov is now known as cprov-afk
barrysinzui: ping20:31
gary_postersalgado: ping20:33
salgadohi gary_poster20:34
gary_postersalgado: hi :-) .  I need to convert the logintoken pages to the new templates.  I'm trying to figure out how to duplicate that locally so I can get a visual "before and after" check to make sure I have converted everything OK.  Do you have an idea on how I might do that?20:35
keeshow do I turn off caching in python-launchpadlib ?20:38
salgadogary_poster, I think the fastest way would be to create logintokens of all different kinds inside a 'make harness' session and for each of them load 'https://launchpad.dev/token/<token>' for each of them before and after you convert.  does that answer your question?20:39
gary_postersalgado: I think so, yes, thanks!  I'll do what I see at the beginning of logintoken-pages.txt20:41
barryrockstar: ping20:42
barryintellectronica: ping20:42
barryEdwinGrubbs: ping20:42
rockstarbarry, hi20:43
salgadogary_poster, np20:43
EdwinGrubbsbarry: pong20:43
barryrockstar, EdwinGrubbs : hi.  can you do a quick ui review for a somewhat redesigned ~/person/+editemails page?20:43
EdwinGrubbsbarry: do you have screenshots?20:44
barryEdwinGrubbs: yes: http://people.canonical.com/~barry/editemails.png20:44
rockstarbarry, if you have screenshots, I can do it now, otherwise it'll have to be a bit.20:44
barryrockstar: ^^20:44
barryEdwinGrubbs, rockstar it's not perfect.  i wish i could put that Add button next to the input field, but that page is kind of a hack and it's not feasible given timeboxing20:45
barryEdwinGrubbs, rockstar still, i think it's better and i get to close an old bug 180349 as a bonus20:46
mupBug #180349: mailing list subscriptions page should link to team <mailing-lists> <Launchpad Registry:In Progress by barry> <https://launchpad.net/bugs/180349>20:46
intellectronicahi barry20:46
salgadogary_poster, btw, I have a question for you.  we have some tests that generate a request and append objects into request.traversed_objects, but having the tests define that is far from ideal so I'm wondering if it'd be possible to pass just the URL into the request and feed it to the publisher so that traversed_objects gets updated appropriately.  is that possible?20:46
barryintellectronica: hi. sorry to bother you.  was looking for a ui review, but rockstar and EdwinGrubbs ponged me first ;)20:46
thekornkees, I'm turning off the cache at runtime for one of my scripts, let me try to find how I'm doing it20:47
intellectronicabarry: you are always welcome to bother me if someone else picks up the work eventually ;)20:47
thekornkees, wow, it is as simple as    launchpad._browser._connection.cache = None20:48
barryintellectronica: :)20:48
EdwinGrubbsbarry: it seems like the displayname of the team should also be linkified. Actually, shouldn't you use the tales fmt:link which will give it a nice icon?20:48
barryEdwinGrubbs: good point.  i'll see if i can fix that20:49
EdwinGrubbsbarry: ui=me20:49
barryEdwinGrubbs: thanks20:49
gary_postersalgado: ...yes, that should probably be doable, though I haven't tried it.  I would first try a test request and then do what zope.publisher.publish.publish does (get the publication, process inputs, and so on through maybe the "afterTraversal" call.  You might need to get your own publication...20:49
salgadogary_poster, ok, I'll give that a try20:50
gary_postercool20:50
keesthekorn: okay, thanks20:52
barryEdwinGrubbs, rockstar http://people.canonical.com/~barry/editemails2.png20:53
EdwinGrubbsbarry: looking good, Mr. Carter20:54
barryEdwinGrubbs: :)  thanks!  rockstar?20:54
rockstarbarry, I agree that the add button should be next to the input field, but that's a problem with FormView, not you.  r=me20:55
barryrockstar: thanks man20:55
sinzuibarry: I think  "but that page is kind of a hack". Is an understatement. The page is a hack We need to reinvent it for 4.021:03
barrysinzui: yeah ;)21:05
sinzuibarry, have you really solved bug 18034921:07
mupBug #180349: mailing list subscriptions page should link to team <mailing-lists> <Launchpad Registry:In Progress by barry> <https://launchpad.net/bugs/180349>21:07
barrysinzui: did you see the screenshot?21:07
sinzuiI am21:07
sinzuibarry: how did you get the label linked?21:08
barrysinzui: i hacked the view to give me the team and the widget, disabling the widget.label.  then i render the team/fmt:link in one column and the widget in the second column21:08
sinzuiinteresting. I will have to study this21:09
barrysinzui: for some reason, it was a lot easier to manage this time around.  it mean it kind of surprised me.21:10
sinzuiI think the work with the license widget taught you all the options.21:11
mwhudsonmorning21:14
thumpersalgado: has your page_title fix landed?21:36
salgadothumper, no21:36
thumpersalgado: ETA?21:36
thumpersalgado: I'm wanting to work on the breadcrumbs for branches21:37
thumpersalgado: but I don't want all the "correct" stuff21:37
thumperoops21:37
thumperI want the "correct" stuff to start with21:37
thumperrather than land stuff, then be told it is wrong or overridden with something else21:37
salgadothumper, the only thing that will be overridden is the text of the last breadcrumb when you're on a page which is not the default one for that context21:39
salgadowe're currently using the page's name (as defined in the zcml) and after my fix lands we'll use the page's title (either view.page_title or the entry in pagetitles.py)21:39
sinzuisalgado: I do not think it should support pagetitles since we want to remove that file in 10 days21:40
salgadosinzui, we're removing that file and moving all the titles there as view attributes or what?21:42
sinzuisalgado: We want to remove the module. No 3.0 page should use it. We will know on day 1 of week 0 if someone cheated21:43
thumpersinzui: +1 on not falling back to pagetitles.py21:43
sinzuisalgado: I don't think you need to change your code, but i would delete a test for that feature rather than fix it21:44
salgadosinzui, that's just not practical.  have you seen how many pages still take their titles from pagetitles.py?21:44
sinzuisalgado: yes. Sometime people do this right thing when threated with violence21:45
mwhudsonwow, markup flamewar on launchpad-dev!21:45
sinzuisalgado: I think a lot of developers have not cleaned out the pagetitle that is not being used21:45
sinzuimwhudson: this is just a prelude for when we build wikis for user. Most probably know mediawiki, not moin21:46
gary_postersalgado: most of these token pages use context/@@main_template/master .  The conversion guidelines suggest main_side or main_only for these, but locationless seems more appropriate.  Do you agree?21:46
* sinzui thinks investment in a gui editor will alleviate the need to fight the markup war21:47
salgadogary_poster, yes, they should be locationless21:48
gary_postersalgado: cool thank you21:48
maxbWhat is the purpose of the ~launchpad-hackers team?21:49
kfogelgary_poster: hey, I've got matsubara's branch that ports lp-bug-ifier to launchpadlib.  Do you do anything history-preserving when you port stuff from lp-dev-utils to launchpadlib/contrib/, or do you just copy the script?  If the latter, maybe I can save you some time?22:01
kfogelmaxb: some hysterical raisins, and I can't remember exactly what now...22:02
gary_posterkfogel: just copy.  yeah, thanks, I won't get to that today, and I have some other things ahead of that for tomorrow too, though I might get to it then.22:02
kfogelgary_poster: launchpadlib is not PQM-governed anyway, right?  I.e., if I can just push this in myself, I will; otherwise, I'll make a branch of launchpadlib and leave it for you.22:03
=== salgado is now known as salgado-afk
gary_posterkfogel: it is not governed by pqm.  I found out recently that the desired way to handle these is to "co" the branch, merge in the changes from your branch, and commit the merge with the appropriate "[r=foo] bar" message22:04
kfogelgary_poster: hmmm.  doing "bzr branch launchpadlib foo; cd foo; cp .../lp-bug-ifier.py .; bzr add lp-bug-ifier.py; bzr ci -m '[r=notsureyet] bar'; bzr push lp:launchpadlib"    is not the way?22:06
gary_posterkfogel: no22:07
kfogelgary_poster: I confess I'm surprised they would even have different effects; what's worse, I remember having this exact discussion (perhaps with you?) last week, and yet I still am expecting those two have the same effect.22:07
kfogelgary_poster: anyway, diogo is the one who ported it, and you're the one I'm discussing this with.  Should I put "[r=gary]" ?22:09
kimusshould I file a bug for the statistics module see: https://lists.launchpad.net/launchpad-users/msg05474.html or it's ok in ML only?22:11
kfogelkimus: reading22:11
gary_posterkfogel: not with me.  you are probably right that it would have the same effect--to bzr.  It does not have a review in there--unless you are the reviewer, which is quite possibly your intent (effectively you are reviewing Diogo's work).22:12
gary_posterIf you wanted someone else to be the reviewer you would need to push your branch publicly first to have it reviewed, and then the process I described would be the right way.22:12
kfogelkimus: yes, please, and feel free to include as many specific examples of useful stats in the bug as you can think of.22:12
kfogelkimus: if the bug could contain a link to the archive URL above, that'd be great; that way we can get from the bug to the thread.22:13
kimussure kfogel22:13
kfogelgary_poster: well, I think I'm not officially a reviewer, so [r=kfogel] is probably never formally correct, though in this case I did review his change of course.22:13
kimuskfogel: what model? launchpad it self?22:14
kfogelgary_poster: or when you said "does not have a review in there" did you mean "does not have to have a review in there" ?22:14
kfogelkimus: yes22:14
gary_posterkfogel: no I meant "does not have a review step in there."  In this case, I'd just use yourself as a reviewer, under the circumstances.  Not letting you be a reviewer for this feels...wrong.22:15
kfogelheh22:15
kfogelgary_poster: not all changes in the launchpadlib logs have a reviewer at all.  Is the r= even necessary?  I'm going to show up as the committer already.22:15
mwhudsonthumper: standup?  in a few minutes would be ok, then i could eat the toast i just made :)22:16
thumperok22:16
kfogelthumper: don't let him eat the toast -- he gets violent22:17
mwhudsonthumper: ok to which part?22:17
thumpermwhudson: eat your toast, we can wait a few minutes22:17
mwhudsonok22:17
gary_posternot all changes have "[r=...]" because people such as myself were bad, bad committers.  Or, well, we didn't know the desired result.  This commit message should be a "[r=kfogel] (merged for matsubara) add another internal file newly ported to launchpadlib" or something like that, AIUI.22:17
kfogelgary_poster: I'll JFDI.  If it's a mistake, this is the way to find out.  Thanks!22:18
gary_posterkfogel: well, we don't have automation here.  the way to find out that you did something is wrong is for a colleague to inform you of that...22:18
kimuskfogel: done: https://bugs.launchpad.net/launchpad/+bug/43101122:19
mupBug #431011: Launchpad statistics <statistics> <Launchpad itself:New> <https://launchpad.net/bugs/431011>22:19
kfogelgary_poster: that's what I meant22:20
kfogelkimus: thank you22:20
gary_posterkfogel: ok.   what I meant was, I was trying to inform you before a mistake was made :-)  but if we're on the same page then cool, all in favor of jfdi22:21
kfogelkimus: I changed the summary to be more accurate22:21
kfogelgary_poster: AH, gotcha22:21
kimuskfogel: fine :-)22:21
kfogelgary_poster: I just tested his script -- it works perfectly.  Review enough for me!22:21
gary_posterkfogel: +122:21
mwhudsonthumper: ready now22:22
* rockstar is ready too22:23
thumperrockstar: skype doesn't think so22:24
mwhudsonrockstar: you didn't pick up ?22:24
rockstarmwhudson, thumper, skype sucks?22:24
mwhudsonrockstar: yes22:25
mwhudsonmy skype doesn't think you're online, but we know what that's worth22:25
thumperrockstar: you still aren't picking up :)22:25
rockstarthumper, call now, sound sorted.22:25
=== sidnei is now known as sidnei-away
bachi mwhudson -- i just launched an ec2test --headless and it took 66 minutes to get it running and let go.  has something changed...for the worse?22:55
mwhudsonbac: !!!22:55
rockstarbac, I definitely didn't see that just not when I launched 2 ec2tests22:56
jmlhello22:56
mwhudsonbac: that's terrible, did you notice which steps were taking the time?22:56
bacmwhudson: i've got another coming up that i'll double check22:56
rockstar...and I pulled pretty recently.22:56
mwhudsonbac: also what machine version did it say you were using?22:56
bacmwhudson: didn't specify a machine.  i thought the default was changed to be XL22:56
mwhudsonbac: i meant "Using machine image version %d\n'"22:57
kfogeljml: hi22:57
mwhudsonbac: it's one of the first things the script prints22:57
* bac scrolls bac22:57
bacer, back22:57
jmlheh heh22:58
jmlkfogel, hello :)22:58
jmlkfogel, want to join skype?22:58
bacmwhudson: this it?  Using machine image version 1622:58
bacmwhudson: i don't see anything that identifies the machine.22:59
mwhudsonbac: yes, that's what it should say22:59
kfogeljml: yup, getting the headphones now22:59
jmlkfogel, cheers.22:59
baci wish the output had timestamps23:00
kfogeljml: skype just dumped core23:00
kfogeljml: no kidding23:00
jmlkfogel, :(23:00
kfogeljml: yup, did it again23:00
kfogeljml: let me see if there's an update real quick23:00
jmlkfogel, ok23:01
mwhudsonbac: yeah, i'd like that too23:02
=== matsubara is now known as matsubara-afk
kfogeljml:  on23:03
mrevellGood ol' Skype just died on me23:04
jmlmrevell, :(23:04
kfogelmrevell: I had to upgrade at skype.com23:04
mrevelljml: I'm back.23:05
mrevellkfogel: seems ok now23:05
kfogeljml: did you drop?23:06
kfogeljml: I think we should set this up via canonical conf calling...23:06
kfogeldo you have a code?23:06
jmlkfogel, no I don't.23:07
mrevellI'm getting crazy amounts of static23:07
mrevellI *lurve* Skype23:07
kfogeljml: we could hijack kiko's, maybe23:07
kfogeljml: (action item: get you a code)23:08
jmlkfogel, heh23:08
kfogeljml: (not a joke!)23:08
thumperkfogel: you have several outstanding approved branches23:08
thumperkfogel: are you going to land them?23:08
kfogelthumper: I do?23:08
jmlkfogel, you were dumping a bunch of noise onto the line23:08
kfogelthumper: I wonder what they are; I didn't know I had anything outstanding.23:08
kfogelthumper: will look after this call23:08
kfogeljml: uh23:08
thumperkfogel: check out the approved section in https://code.edge.launchpad.net/launchpad/+activereviews23:08
kfogelthumper: thx23:08
kfogeljml, mrevell: um.  let's hijack kiko's code, and then jml can get a code of his own later.  thoughts?23:09
jmlkfogel, ok, sure.23:09
kfogeljml: okay, I'll dial in.  If I'm first, I'll set it up.23:09
jmlkfogel, privmsg details please23:09
kfogeljml: will do, one sec23:10
barryjml, thumper, mwhudson, rockstar wanna meet today?23:28
mwhudsonbarry: guess so23:28
thumperbarry: yes23:28
barry-> #launchpad-meeting in 2m23:28
thumperrockstar: lets have a call after the reviewer meeting23:29
rockstarthumper, I'll probably have to walk the dog, but after that, sure.23:29
thumperrockstar: ok23:30
* rockstar is assuming reviewer meeting is now.23:30
* thumper really hates pagetests23:54
wgrant3.0 is a week away now, isn't it?23:57
mwhudsonwgrant: that's the plan i think23:58
wgrantEek.23:59
mwhudsoni guess a delay is possible...23:59
wgrantIt's still all very unpolished, there is a big unresolved root context issue, and there is no UI designer.23:59

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!