=== abentley1 is now known as abentley === barry` is now known as barry [05:09] Simple review needed: https://code.edge.launchpad.net/~stub/launchpad/opstats/+merge/11774 [06:05] stub: don't we already have code for telling a robot apart from a browser? [06:05] stub: the oops reports make this distinction somehow or other... [06:07] mwhudson: The oops reports use a list of known robots. I was thinking that for the losas use case, it is better to have false negatives (requests from unknown browsers ignored) than false positives (requests from robots counted because they are unknown) [06:07] stub: ok, fair enough [06:08] I toyed with parsing one of the databases (the oops reports just uses values scraped from our web logs), but it seemed overkill. [06:08] yeah, looks good enough for a first cut [06:10] stub: reviewed [06:10] ta === henninge is now known as henninge-bbl [07:19] stub: what about api scripts? shouldn't they be treated as browsers as well? [07:24] henninge-bbl: the comment you ported over from pagetitles.py to the POFileTranslateView label property does not, in actuality, make sense. Might as well drop it. [07:29] henninge-bbl: Also, in menu-pages.txt, afaics the nav link from the +details page back to the +details page seems to be linkified now... is that right? [07:33] BjornT: That would be up to the losas I guess. They requested this for their monitoring. I suspect not, as I think the goal is to filter out the noise that can be generated from automation like robots and scripts etc. [07:53] stub: the api is used by real application as well, though, so if the api doesn't work, it has a direct effect to users. but sure, it's up to the losas to decide, it depends on what exactly they intend to measure === danilos changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo] === danilos changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo, danilo] [09:03] allenap, jtv: three lovely UI branches for your enjoyment on +activereviews === adeuring changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo, danilo, adeuring] === bigjools-afk is now known as bigjools_ === noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo, danilo, adeuring, noodles] === noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo, danilo, adeuring] === bigjools_ is now known as bigjools === adeuring changed the topic of #launchpad-reviews to: on call: - || reviewing: [danilo, danilo, danilo, adeuring, noodles, adeuring] === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: [danilo, danilo, danilo, adeuring, noodles, adeuring] [11:15] allenap: you're back [11:15] intellectronica: Yes! Thanks for passing on my message. [11:16] allenap: can you review my patch before danilo danilo and danilo? i expect preferential treatment because we're team mates [11:16] also it's a one-liner [11:16] lol [11:16] intellectronica: Of course. [11:16] allenap: http://pastebin.ubuntu.com/271996/ [11:16] allenap: this is for turning ubuntu +filebug off on edge === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: [danilo, danilo, danilo, adeuring, adeuring] [11:17] intellectronica: r=me and soon Ubuntu will be bug free, at least in the same way that Windows and MacOSX are bug free. [11:17] ha ha [11:17] allenap: thanks === adeuring changed the topic of #launchpad-reviews to: on call: allenap || reviewing: [danilo, danilo, danilo, adeuring, adeuring, adeuring] [12:22] allenap: looks like you have a pretty full plate today [12:23] barry: Yeah :) And I've hardly even started. [12:23] ouch ;) [12:23] s'okay. i'll harass sinzui when he wakes up :) [12:24] barry: Cool, okay, thanks for that. Once I get into the flow it'll go okay, so maybe I'll get to you if sinzui isn't able to help. [12:24] allenap: cool, thanks. i'll put myself on the queue just in case === barry changed the topic of #launchpad-reviews to: on call: allenap || reviewing: [danilo, danilo, danilo, adeuring, adeuring, adeuring, barry] === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: lunch || queue: [danilo, danilo, danilo, adeuring, adeuring, adeuring, barry] [12:30] intellectronica, hehe, btw, we are all teammates :) [12:31] danilos: i'm sorry, which department exactly are you? [12:31] intellectronica, dammit, the office right below you! [12:32] :) [12:32] intellectronica, second floor, where it says "soft launching pads" [12:33] oh right, i remember, i always go there to get my pink 83B5 forms [12:33] there you go :) we've got all stuff pink in here! [13:00] allenap: can I add another review (like the other, a trivial layout conversion)? === matsubara-afk is now known as matsubara [13:05] bigjools, want to review: https://code.edge.launchpad.net/~beuno/launchpad/bug-423105/+merge/11871 [13:05] I'm not really here though [13:07] beuno: r=me === mrevell is now known as mrevell-lunch [13:18] adeuring: Sure, please put it on the end. I may not get to it today though. [13:27] bigjools, thanks === adeuring changed the topic of #launchpad-reviews to: on call: allenap || reviewing: lunch || queue: [danilo, danilo, danilo, adeuring, adeuring, adeuring, barry, adeuring] [13:41] eew, the review queue is scary ... [13:43] cprov, then just add to it [13:44] danilos: right, why not ? === cprov changed the topic of #launchpad-reviews to: on call: allenap || reviewing: lunch || queue: [danilo, danilo, danilo, adeuring, adeuring, adeuring, barry, adeuring, cprov] [13:46] allenap, also, I'll try to get henninge to review one of my branches (430455), so if I do, I'll get it out of the queue [13:47] danilos: Thanks :) === henninge changed the topic of #launchpad-reviews to: on call: allenap || reviewing: lunch || queue: [danilo, danilo, adeuring, adeuring, adeuring, barry, adeuring, cprov] [13:53] sinzui: would you have time to review a branch for me? allenap has a full dance card [13:54] I can [13:55] allenap, btw, blueprints branch is mostly removing templates and replacing them with generic-edit [13:56] danilos: Yep, I'm just approving it now. [13:56] sinzui, btw, I wanted to ask you about some thing... I've also migrated sprint-edit.pt to generic-edit.pt, but it used to have an old contextmenu with "Change branding" link; should I keep that template as is if you want to have "Change branding" link only once you are already on "Change details" form? [13:56] sinzui: thanks: https://code.edge.launchpad.net/~barry/launchpad/430068-person/+merge/11832 [13:56] allenap, cool, thanks [13:58] danilos: I changed a few context menus into navigation menus. I agree that is slow [13:59] danilos The change branding should be in the global action menu after Change details. [13:59] sinzui, right, I am wondering if it was intentional that the object-branding.txt pagetest was doing getLink('Change details').click() and immediately after getLink('Change branding').click() [14:00] sinzui, with my conversion, I've removed the first getLink because 'Change branding' is available on the sprint page as well, is that fine? [14:00] danilos ah. that is because of the old design. and that hack we kept in place so that we could change pages before the index pages are complete [14:01] sinzui, ok, cool, then I'll be removing 12 blueprints templates shortly [14:01] danilos: registry has a similar problem. Lots of tests will break when we fix person +edit. We need the +index to land first with all the new links in it. [14:02] sinzui, right === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: danilo || queue: [adeuring, adeuring, adeuring, barry, adeuring, cprov] === mrevell-lunch is now known as mrevell [14:30] Hi bac - sorry, I had to update that branch you reviewed yesterday. Do you think you'll get time to look at the incremental? [14:31] noodles775: yes. i've got a standup, then the reviewers meeting, then a 11EDT call. i'll try to squeeze it in the cracks [14:32] Thanks bac! === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [adeuring, adeuring, adeuring, barry, adeuring, cprov] === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: - || queue: [adeuring, adeuring, adeuring, barry, adeuring, cprov] === salgado_ is now known as salgado [14:55] gary, whenever you have time, https://code.edge.launchpad.net/~leonardr/lazr.restful/new-version/+merge/11882 and then https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/new-restful/+merge/11881 [14:58] https://code.edge.launchpad.net/~leonardr/lazr.restful/new-version/+merge/11882 : do you think we ought to have migration instructions, or is that unnecessary? [14:59] gary: old services will still work, so no migration necessary [14:59] i could be persuaded to write something about how to use the new stuff [15:01] leonardr: heh. how long would such usage instructions be, on a guess? [15:03] gary: i'd do it by rewriting lazr/restful/example/wsgi/README.txt [15:03] it'd end up a little shorter than it is now [15:03] take me a couple hours to write [15:03] leonardr: that feels appropriate to me. WDYT? [15:04] sure, i'll finish off the day with that. can i have a provisional r=gary if that's stipulated? [15:04] yes, done. I'll mark it as such and move on. [15:04] salgado: I have one question. The picture show the IRC nicks wrapping together. I was going to suggest making each nick a

, but I see in your diff that they are

. Was the picture made before you switch to a

? [15:04] all right [15:05] leonardr: one other question here actually. is this change appropriate for a 0.9.6 (bugfix)or a 0.10.0 (feature)? This feels like a 0.10.0 to me. [15:07] sinzui, what do you mean by wrapping together? in the shot they are rendered inside

s [15:07] ah! [15:07] sinzui, IRC nicks are rendered like "nick on network" [15:07] * sinzui drinks more coffee. [15:07] it will look better with nicks that don't have spaces [15:09] salgado: If we change each nick to be a

they will get a few pixels of whitespace between them. Your decision. r=me. start landing this [15:09] thanks sinzui. I'll see how that looks [15:18] leonardr: also approved the other one [15:30] great === deryck is now known as deryck[lunch] === adeuring changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: - || queue: [adeuring, adeuring, adeuring, barry, adeuring, cprov, adeuring] [16:24] allenap, EdwinGrubbs: could one of you take a look at one of my MPs (all boring conversions of blueprint templates...) [16:25] adeuring: sure [16:25] EdwinGrubbs: thanks! [16:25] adeuring: Sorry I haven't started on yours yet. === allenap changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [adeuring, adeuring, adeuring, barry, adeuring, cprov, adeuring] [16:25] allenap: np. Must be a terribla day for you... === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: adeuring || queue: [adeuring, adeuring, barry, adeuring, cprov, adeuring] [16:26] adeuring: It's not terrible, but I have many things on the go at the same time :( [16:33] ni noodles775 [16:33] hi bac [16:34] noodles775: i was just about to have a look at your changes when i talked to sinzui and he mentioned bug 430784 [16:34] Bug #430784: The launchpad branding in the base-layout footer should be linked [16:34] noodles775: is there anyway you could include that in your current branch? [16:34] noodles775: btw, that bug says footer but i don't think it's correct [16:34] bac: Sure - but from the jml's email to lp-dev, he's already got an MP there for it? [16:35] noodles775: ah, i didn't see that yet [16:35] * bac looks [16:35] ok. [16:35] noodles775: right you are [16:36] noodles775: nm, then [16:43] noodles775: in the ==Launchpad Edge== test you say "each page will" but one of the criteria you mentioned was not being locationless. shouldn't that part of the narrative mention the locationless exclusion? [16:43] noodles775: gah, i see it is the next section [16:44] :) great. [16:44] noodles775: still i think s/each page will/most pages will and then later show why locationless is the exception [16:45] bac: yep, I agree. [16:45] (the current narrative reflects the fact that I only came across the locationless exception after writing it :/ ). [16:45] noodles775: the new changes look good. thanks [16:45] bac: great! Ta. [16:47] barry: r=me [16:48] sinzui: noodles775 pointed out that jml already has an approved MP for bug 430784 [16:48] Bug #430784: The launchpad branding in the base-layout footer should be linked [16:49] rock [16:55] EdwinGrubbs: may i add to your growing queue? it's a pretty straightforward fix to +review-licenses === bac changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: adeuring || queue: [adeuring, adeuring, barry, adeuring, cprov, adeuring,bac] === deryck[lunch] is now known as deryck [16:59] bac: sure, I have no idea how many of the items are tiny so I may or may not get to it. [16:59] EdwinGrubbs: np. === matsubara is now known as matsubara-lunch === danilos is now known as danilos-afk === salgado is now known as salgado-lunch [17:59] EdwinGrubbs: before you review my branch, check with sinzui [17:59] barry: did you ask him to review it, also? [18:00] EdwinGrubbs: yes [18:00] barry: I reviewed your code of conduct branch [18:00] sinzui: thanks! === barry changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: adeuring || queue: [adeuring, adeuring, adeuring, cprov, adeuring,bac] === matsubara-lunch is now known as matsubara [18:08] barry, sinzui: If I'm reviewing a template conversion, and the view class is used by several different urls, should I recommend that they create a subclass so they can implement appropriate page_title and label attributes, or should the developer just use the heading slot to speed things along? [18:09] EdwinGrubbs: That is what I have done in all cases. I believe other have created views from mixins [18:09] EdwinGrubbs: it would be better to refactor mega view classes, use a mixin or a subclass, probably in that order [18:10] EdwinGrubbs: it is better not to use the heading slot [18:10] EdwinGrubbs: The only reason to subclass is if two pages that make titles use it. It is fine for 200 portlets to share a view that make a single page [18:11] sinzui, barry: cool, I just wasn't sure how urgent the rubberstamping was, but I like the cleaner solution. [18:12] EdwinGrubbs: subclassing is pretty trivial. I am sure you can always suggest that === salgado-lunch is now known as salgado [18:29] sinzui, the link to +related-software is no longer present on person-index.pt, so there's no way to get to that page. is it ok if I put it together with the ones we have before the first yui portlets? [18:30] Oh. Please do [18:38] salgado: to prepare for your page title fix, should the View.page_title="Foo Bar" or View.page_title="Foo Bar: %s" % self.context.displayname [18:41] EdwinGrubbs, I'd say just "Foo Bar" if context.displayname is in breadcrumbs before that [18:42] EdwinGrubbs, this should not override the entire page_title [18:44] salgado: ^^^^ [18:44] EdwinGrubbs, ? [18:44] salgado: sorry, I forgot that you probably don't see the relavent info, since you were disconnected. [18:45] salgado: to prepare for your page title fix, should the View.page_title="Foo Bar" or View.page_title="Foo Bar: %s" % self.context.displayname [18:47] EdwinGrubbs, whatever you'd do if not preparing for this fix. there's really nothing we should be doing in preparation for it [18:47] just like before, though, it's a good idea to move stuff from pagetitles.py into the view classes [18:50] salgado: Currently, the page I'm reviewing shows "+documentation : Kubuntu". I would normally change the page_title to "Current documentation: %s" % self.context.displayname however, it sounded like that would yield "Current documentation : Kubuntu : Kubuntu" [18:56] EdwinGrubbs, I'd say don't change the page_title there, as the rules for the title are not yet finished and may change really soon [18:59] salgado: ok, so I should just live with "+documentation: Kubuntu". [18:59] yes, that will change when my branch lands === cprov is now known as cprov-afk [20:15] Holy shit. Is the queue really this long? [20:45] abentley, ping [20:45] rockstar: pong [20:46] abentley, given the length of the current review queue, could you do a review for me? [20:46] rockstar: quid pro quo, clarise [20:47] abentley, I'm assuming that's a reference to Silence of the Lambs, but it's meaning is unknown to me. [20:47] rockstar: I will review yours if you review mine. [20:48] abentley, that's a deal. [20:49] rockstar: Okay, could you review https://code.edge.launchpad.net/~abentley/launchpad/preview-on-create/+merge/11906 please? [20:49] rockstar: what would you like me to review? [20:49] abentley, cool. I'll send mine out and request you review it. I have to upload these screenshots still. [20:50] rockstar: Sure thing. [20:53] bac: it doesn't look like you are testing that all six date fields can be passed in as date objects. It also seems like you could test all six in a single forReview() call and still have it match the bzr project. [20:53] EdwinGrubbs: i did not test all six, just a representative. i reasoned this regresssion was unlikely to occur again [20:54] EdwinGrubbs: but i can add it if you feel it is useful and will be happy to do so [20:58] bac: if this can be done without bloating the test with multiple forReview() calls, I think it would be a good idea, even though it is rediculously unlikely. [20:59] EdwinGrubbs: ok. i'll just create a very early and very late date object and pass as the other fields. working on it now. [21:05] EdwinGrubbs: your suggested fix plus the lint changes: http://people.canonical.com/~bac/bug-430748-team-mailinglist/ [21:05] er, http://pastebin.ubuntu.com/272333/ [21:06] bac: r=me [21:06] EdwinGrubbs: cool, thanks [21:08] EdwinGrubbs: if you'll mark the MP i'll send it off to ec2 for landing: https://code.edge.launchpad.net/~bac/launchpad/bug-396585-review-license/+merge/11897 [21:09] bac: done [21:09] schweet [21:09] sinzui: did you already review barry's branch? [21:09] EdwinGrubbs: yes. it landed [21:10] EdwinGrubbs: Not the one he just added for UI [21:11] cprov-afk: I'm starting to review your branch. Are you around? [21:20] abentley, having troubles with bzr send. It's trying to bundle 358 revisions, which this branch definitely doesn't have. Chasing now. === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: cprov || queue: [] [21:21] rockstar: roger [21:40] EdwinGrubbs: can i add a single template conversion branch? it's only 56 lines. https://code.edge.launchpad.net/~bac/launchpad/bug-430748-team-mailinglist/+merge/11924 [21:41] bac: sure === bac changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: cprov || queue: [bac] === salgado is now known as salgado-afk [22:06] EdwinGrubbs: I have a branch of almost-entirely mechanical template changes. May I add that to your queue? https://code.edge.launchpad.net/~gary/launchpad/launchpad-templates/+merge/11930 [22:06] (launchpad 3.0 stuff) [22:06] gary_poster: sure [22:07] thank you === gary_poster changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: cprov || queue: [bac, gary] [22:12] abentley, so we're creating a review diff AND a preview diff on creation now? [22:14] rockstar: correct. On phone. [22:18] abentley, okay. Ignore my questions then until you have bandwidth to answer them. [22:18] Why don't we just get rid of the review diff altogether then, and just use the preview diff? Generating two diffs might not be too big of a deal, I guess. [22:18] Or maybe that's the plan for another branch. [22:20] EdwinGrubbs: do you have room on your queue for a 514 line branch? [22:29] barry: I doubt it, but I could always finish it up tomorrow if that's ok. [22:30] EdwinGrubbs: don't worry about it. we have a lot of folks on ocr tomorrow. i'll be up early gettin' on the queue === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: bac || queue: [gary] [22:50] sinzui: are you up for doing a review tonight? [22:50] barry: I can when I get back from a school meeting at 9:00 [22:50] abentley, did you see my questions above? [22:51] sinzui: cool. if it looks good i'll land it first thing in the morning: https://code.edge.launchpad.net/~barry/launchpad/430065-person/+merge/11935 [22:51] rockstar: Only the first one. [22:52] barry, sinzui: i can do that review now [22:52] bac: that would be great! [22:52] rockstar: We were continuing to generate the review diff to be cautious. [22:53] rockstar: We will disable review diff generation, but possibly not until after 3.0 [22:53] abentley, okay. r=me [22:54] rockstar: thanks. === matsubara is now known as matsubara-afk [23:10] EdwinGrubbs: i realize i forgot to remove the page title from pagetitles.py. i've done so now. [23:24] barry: review down. sinzui i see you claimed it too. hope you don't mind... [23:25] bac thanks! bac, sinzui i requested sinzui's review, but he doesn't have to do it now [23:33] thanks EdwinGrubbs === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: gary || queue: [] [23:35] EdwinGrubbs: that zcml issue confuses me. why does it currently work? [23:37] bac: because of something either added to the __init__.py or to the importer when sinzui started migrating stuff, so that he wouldn't have to fix every last import by hand that the script wouldn't fix for him. [23:37] EdwinGrubbs: right [23:38] EdwinGrubbs: we should start turning those off to find the stragglers [23:38] yep [23:39] but not tonight. :)