| === sinzui changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: gary || queue: [sinzui] | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: adeuring || queue: [sinzui] | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: sinzui || queue: [] | ||
| jtv1 | henninge_: again you've got a label property with a docstring saying that it returns a page. | 09:03 |
|---|---|---|
| henninge_ | oops | 09:04 |
| === henninge_ is now known as henninge | ||
| henninge | aargh!! | 09:04 |
| henninge | I just pushed 'q' in 'less' to loose the output from the test run .... | 09:05 |
| henninge | :( | 09:05 |
| henninge | but it was only one failed test (I think) | 09:05 |
| jtv1 | henninge: another thing... you've got the nav links inline in the template. Since this is a set of common links, isn't it better to move them out to a template of their own? | 09:20 |
| henninge | jtv1: how do you mean | 09:21 |
| === jtv1 is now known as jtv | ||
| henninge | jtv: this is the way it's done on pofile-translate, too (which has landed) so I will most likely not change that now. | 09:21 |
| jtv | henninge: I see. Probably something we'll want to fix later though. | 09:22 |
| henninge | jtv: oh, oh, now I get it ... | 09:22 |
| henninge | ;-) | 09:22 |
| henninge | You mean common between pofile-translate and tm-translate? Move them to a macro, basically. | 09:23 |
| henninge | I'd still like to postpone that as a clean-up for later since I am redoing those pages anyway. | 09:23 |
| jtv | henninge: Fine with me, as long as you're aware of it. | 09:26 |
| henninge | jtv: https://bugs.edge.launchpad.net/rosetta/+bug/431249 | 09:31 |
| mup | Bug #431249: Put navigation links in a seperate template/macro. <Launchpad Translations:Triaged by henninge> <https://launchpad.net/bugs/431249> | 09:31 |
| jtv | henninge: perfect, thanks | 09:31 |
| henninge | jtv: official mp coming your way! | 09:50 |
| jtv | henninge: you sent the MPs after me? Dude, that's harsh. | 09:50 |
| henninge | jtv: yup, I'd so anything to keep you on your toes ... ;-) | 09:50 |
| * jtv has his toes nicely up on the couch, thank you | 09:50 | |
| henninge | ;-) | 09:51 |
| henninge | jtv: oh, I forgot to take a stab at pagetitles.py. Funny I didn't get a complaint ... | 09:54 |
| jtv | Easy to forget an optional removal. :) Nothing automatically complains when you don't do that, because plenty of pages still share views so that it becomes hard to produce the right title from there. | 09:55 |
| henninge | pagetitles.py just got shorter ... | 09:59 |
| jtv | +1 | 10:00 |
| jtv | henninge: r=jtv, kind but optional request for xx-pofile-details.txt to "print" its title instead of dumping it with quotes and all. Otherwise, enjoy your birthday! | 10:25 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775-afk || reviewing: sinzui || queue: [] | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775-afk || reviewing: - || queue: [] | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [] | ||
| noodles775 | If there's anyone able to do a ui review of the following, please let me know: https://code.edge.launchpad.net/~michael.nelson/launchpad/429353-site-message-to-footer/+merge/11813 | 12:21 |
| === mrevell is now known as mrevell-dejeuner | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [noodles775] | ||
| === matsubara-afk is now known as matsubara | ||
| noodles775 | A really simple code-review if anyone is available: https://code.launchpad.net/~michael.nelson/launchpad/429551-view-package-details-link/+merge/11961 | 13:05 |
| === bigjools-afk is now known as bigjools_ | ||
| === mrevell-dejeuner is now known as mrevell | ||
| salgado | sinzui, http://paste.ubuntu.com/272777/ are the changes I had to do to my person-three-o branch to make sure the page still works when LP is in read-only mode | 13:55 |
| sinzui | salgado: I expected that you would need to define master or slave. Just switching to Storm is the answer? | 13:56 |
| salgado | sinzui, yes -- we just need to use the store that is currently in use. when we use the SQLObject compatibility layer, it forces the use of the master store | 13:58 |
| sinzui | oh. I must remember that | 13:58 |
| sinzui | r=me | 13:58 |
| salgado | sinzui, thanks! | 14:00 |
| BjornT | noodles775: got time for a small and simple review? | 14:10 |
| noodles775 | BjornT: of course :) | 14:10 |
| BjornT | noodles775: cool. the mp should appear in lp soon... | 14:13 |
| noodles775 | Great. | 14:13 |
| BjornT | noodles775: https://code.edge.launchpad.net/~bjornt/launchpad/bug-430813/+merge/11967 | 14:16 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: BjornT || queue: [noodles775] | ||
| === gmb_ is now known as gmb | ||
| noodles775 | BjornT: is it expected that when I now run `make jscheck` that lots (perhaps all? it's still going) non-js testcases are run? | 14:37 |
| BjornT | noodles775: no. did you grab the branch, or simply apply the patch? | 14:40 |
| noodles775 | BjornT: I merged the branch. | 14:40 |
| BjornT | noodles775: you probably have an old version of bin/test. remove bin/buildout, run 'make', and then try again | 14:43 |
| noodles775 | BjornT: ah, ok. Doing so now. | 14:43 |
| sinzui | barry: take a look at https://code.edge.launchpad.net/~sinzui/launchpad/milestone-design-oops/+merge/11946 | 14:49 |
| barry | noodles775: hiya! i'm going to have a really simple one for you; 41 lines | 14:49 |
| === barry changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: BjornT || queue: [noodles775,barry] | ||
| noodles775 | barry: great! You wouldn't be able to look at a ui-review or two would you? | 14:50 |
| barry | noodles775: i could do some ui reviews | 14:51 |
| noodles775 | barry: or if rockstar will be on OCR, I can wait for him instead... | 14:51 |
| barry | sinzui: the difference there is the full-page-width sections | 14:51 |
| barry | noodles775: cool, either way | 14:51 |
| sinzui | yes...and the fact you cannot see there is an empty sidebar for the IProject | 14:51 |
| barry | sinzui: very nice. ui=me* | 14:52 |
| sinzui | thanks barry | 14:52 |
| === henninge is now known as henninge-bbl | ||
| noodles775 | barry: yeah, I'll need two ui-reviews anyway, so if you could take a look at the 3 screenshots in my last comment at: | 15:02 |
| noodles775 | https://code.edge.launchpad.net/~michael.nelson/launchpad/429353-site-message-to-footer/+merge/11813 | 15:02 |
| === danilo_ is now known as danilos | ||
| noodles775 | ... that would be wonderful. | 15:02 |
| barry | noodles775: sure thing | 15:03 |
| barry | noodles775: i almost completely love it :) | 15:08 |
| noodles775 | heh... but? | 15:08 |
| barry | noodles775: question: if you disable redirects, would the green link chang e to "Enable edge redirects"? | 15:08 |
| barry | noodles775: question: when you click on the minty green "Disable" link, do you get an overlay (confirmation window?) or does it just happen? | 15:09 |
| barry | noodles775: on http://people.canonical.com/~michaeln/tmp/site-msg-footer-on-3.0-narrow.png is there any way to avoid the icky wrapping? | 15:09 |
| barry | noodles775: EOT | 15:09 |
| noodles775 | barry: 1. no - currently that'll still be done via the lp.net root page - but would be good to do (at first I thought it wouldn't be useful to have it on edge, but perhaps it would.) | 15:10 |
| noodles775 | barry: 2. No overlay, still the ugly alert box that you see currently (I didn't change any of the actual workings as part of this - just moving the site_message and adding the link). | 15:11 |
| noodles775 | barry: 3. I couldn't find one - I created that image to show the worst-case scenario, any suggestions? | 15:11 |
| barry | noodles775: 1. could you file a bug on that? i think it would be really cool to be able to enable/disable easily from the footer (clearly out of scope for this branch) | 15:12 |
| barry | noodles775: 2. i wonder then if the link should be minty green. isn't that a meme for "inline edit or overlay window coming"? or it could be my monitor doesn't see the green quite right | 15:13 |
| noodles775 | barry: it'd be easy to add - I'll check, if it's a 10min I'l just do it now. otherwise yes. | 15:13 |
| barry | noodles775: awesome | 15:13 |
| barry | noodles775: 3. if possible, in the worst case scenario, put the whole "Disable edge redirect" right aligned on the following line (i.e. visually on the same line as the search box) | 15:14 |
| barry | noodles775: other than that, it looks fantastic | 15:14 |
| noodles775 | barry: 2. aiui the green is for any js action (ie. usually link that doesn't actually go somewhere) | 15:15 |
| noodles775 | barry: 3. I don't see how I can do that - i've used a yuigrid, but i've no way of knowing whether the text will wrap? | 15:15 |
| barry | noodles775: you're right | 15:15 |
| barry | noodles775: cool. it's not a big deal | 15:16 |
| noodles775 | OK, thanks barry! | 15:16 |
| barry | noodles775: ui=me* and thanks! | 15:16 |
| barry | noodles775: https://code.launchpad.net/~barry/launchpad/431859-wikinames/+merge/11972 | 15:16 |
| noodles775 | barry: yep, merging now... | 15:17 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: barry || queue: [noodles775] | ||
| barry | noodles775: btw, re: ~cprov/+archive/ppa. i think you've done it exactly the right way. currently IEditableContextTitle can only handle the watermark heading as you've seen. i think you've found a good reason to fill the heading slot. might be worth an email to the list and/or some text in the wiki | 15:24 |
| noodles775 | barry: great, thanks for that. | 15:24 |
| barry | np | 15:24 |
| noodles775 | I'll update the wiki. | 15:24 |
| barry | great, thaks | 15:24 |
| barry | thanks even | 15:24 |
| noodles775 | barry: review sent. | 15:32 |
| barry | noodles775: thanks | 15:32 |
| noodles775 | barry: feel free to say no, but I've one other branch that just adds an in-context link, ready with screenshot, at https://code.launchpad.net/~michael.nelson/launchpad/429551-view-package-details-link/+merge/11961 | 15:34 |
| noodles775 | needing ui review too. | 15:34 |
| barry | noodles775: np. i need to go afk for a few minutes, but i'll look when i'm back | 15:35 |
| noodles775 | Thanks. | 15:35 |
| === danilos is now known as danilo-afk2 | ||
| barry | noodles775: ui=me* | 15:48 |
| noodles775 | Thanks barry. BTW: could you add that to those two MP's? | 15:50 |
| barry | oops, right | 15:50 |
| === bigjools_ is now known as bigjools | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] | ||
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: - || queue: [] | ||
| gary_poster | EdwinGrubbs: I have two views that share the same view class but have different templates. I'm trying to figure out the right way to do the "label" attribute for these. | 16:42 |
| gary_poster | An obvious approach is to subclass the view class and make another one for the second view, only overriding the label. | 16:42 |
| gary_poster | I don't love that because I seem to have some got desire to not make another class just to change a label, but maybe that's silly. Do you have any recommendations? | 16:42 |
| gary_poster | s/got/gut/ | 16:44 |
| intellectronica | gary_poster: property with a conditional return? not very elegant, but less code than subclassing | 16:46 |
| EdwinGrubbs | gary_poster: I know it seems silly, but it seems to be the price we pay to put it in the view instead of in the template. | 16:47 |
| gary_poster | intellectronica: right, thought of that too, but then the conditional return is based on the request url which feels fragile (what if the url is changed in the zcml? then everything still works except the label no longer knows to switch) | 16:47 |
| gary_poster | EdwinGrubbs: ok thanks | 16:47 |
| intellectronica | gary_poster: don't you have something like a context you can examine? if you have to look at the request url then it indeed feels wrong | 16:48 |
| gary_poster | intellectronica: context is the same for both (a token)--oh...hm, I could maybe look at the LoginTokenType constant, assuming I can get to that somehow. Will investigate, thanks! | 16:49 |
| gary_poster | yes, self.context.tokentype | 16:49 |
| === salgado is now known as salgado-lunch | ||
| === henninge-bbl is now known as henninge | ||
| abentley | rockstar: Could you please review https://code.launchpad.net/~abentley/launchpad/comment-free-for-all/+merge/11987 ? | 17:27 |
| gary_poster | EdwinGrubbs: I tried to remove the information in pagetitles.py as you requested. I added the label attribute. Now when I try to go to the page I see this: AssertionError: No .page_title or pagetitles.py found for /home/gary/launchpad/lp-branches/launchpad-templates/lib/canonical/launchpad/zcml/../templates/logintoken-resetpassword.pt | 17:29 |
| gary_poster | EdwinGrubbs: does that mean that I need to add a page_title too? | 17:29 |
| gary_poster | (presumably the same value) | 17:29 |
| gary_poster | oh | 17:30 |
| gary_poster | I see @property for page_title in the example | 17:30 |
| EdwinGrubbs | gary_poster: Let's ask salgado. He may be in the process of working on a branch that eliminates the need to add a page_title attribute, but will use it if it's there. | 17:31 |
| EdwinGrubbs | salgado-lunch: ^^^? | 17:31 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: abentley || queue: [] | ||
| gary_poster | EdwinGrubbs: If you mean that breadcrumb branch, I just did a pre-review of it. It still uses page_title. I asked him on the channel he asked for a prereview how label and page_title should interact | 17:32 |
| gary_poster | (but he's at lunch) | 17:32 |
| rockstar | abentley, is isMergable used anywhere else? | 17:33 |
| abentley | rockstar: Yes. For example, it's used to prevent requesting further reviews. | 17:34 |
| EdwinGrubbs | gary_poster: I thought page_title became optional, but maybe it alternates between setting the last breadcrumb and the entire title based on override_title_breadcrumbs. | 17:34 |
| gary_poster | EdwinGrubbs: maybe so. I'm not really sure what the story is. I'll add a @property as shown in the example on the UI page for now. | 17:35 |
| rockstar | abentley, ah, okay. | 17:36 |
| rockstar | abentley, there were no tests that you had to change? Or have you not run the whole test suite yet? | 17:37 |
| abentley | rockstar: Haven't run the whole suite yet. | 17:37 |
| rockstar | abentley, okay. | 17:37 |
| abentley | rockstar: Gotta meet a friend for lunch in a few minutes. I can ping you when I get back. | 17:39 |
| rockstar | abentley, I think I'm just about done. | 17:39 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: - || queue: [] | ||
| === BjornT_ is now known as BjornT | ||
| salgado-lunch | EdwinGrubbs, gary_poster, my branch still expects to find a .page_title in views (or an entry in pagetitles.py). we might be able/want to combine label and page_title in the future, but for now all pages still have to provide a title | 18:10 |
| === salgado-lunch is now known as salgado | ||
| gary_poster | salgado: ok thank you | 18:10 |
| === salgado changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: - || queue: [salgado] | ||
| salgado | rockstar, can you take mine? it's not trivial but I'll be around to answer any questions you might have | 18:19 |
| rockstar | salgado, I can. Link? | 18:20 |
| salgado | rockstar, https://code.edge.launchpad.net/~salgado/launchpad/breadcrumbs-for-leafs/+merge/11985 | 18:20 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: salgado || queue: [] | ||
| === cprov changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: salgado || queue: [] | ||
| deryck | rockstar or cprov -- I've got a template delete and mechanical change branch for review, if one of you can look. | 18:40 |
| === deryck changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: salgado || queue: [deryck] | ||
| cprov | deryck: I can | 18:40 |
| deryck | cprov, thanks! https://code.edge.launchpad.net/~deryck/launchpad/remove-bugs-templates-in-lp-431916/+merge/11992 | 18:41 |
| === cprov changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: salgado, deryck || queue: [] | ||
| cprov | deryck: looks good, one question though, what did you have to consider when setting override_title_breadcrumbs ? | 18:43 |
| cprov | deryck: why is it not ok to let the breadcrumb set the weirdo (reversed nav path) title ? | 18:45 |
| rockstar | salgado, you have a few XXX comments without bugs referenced. | 18:45 |
| deryck | cprov, the title was something like "+subscribe : Bugs in Foo : Foo", so if I waited for upcoming changes to the +foo part, I could make it something like "Subcribe : Bugs in Foo : Foo" and I just thought the label of "Subscribe to Bugs in Foo" was better for the page and the page title. | 18:46 |
| kfogel | cprov: can I send you a quick-n-easy one (https://code.edge.launchpad.net/~kfogel/launchpad/add-ldu-externally-copyrighted-scripts/, just adds some scripts from lp-dev-utils). | 18:46 |
| kfogel | ? | 18:46 |
| cprov | kfogel: yes | 18:46 |
| kfogel | cprov: done -- https://code.edge.launchpad.net/~kfogel/launchpad/add-ldu-externally-copyrighted-scripts/+merge/11995 | 18:47 |
| deryck | cprov, but I'm record not liking the reverse breadcrumbs for most bug pages like this. :) | 18:47 |
| salgado | rockstar, yeah, I've agreed with gary_poster that the one on line 54 should be a regular comment, but I'm happy to file bugs for the others | 18:48 |
| cprov | deryck: yes, that's what I thought ... if the default pagetitle was better we wouldn't have to override it. is anyone still working on it ? | 18:48 |
| rockstar | salgado, okay. | 18:49 |
| deryck | cprov, no. We'll have to do it the way I've done it if we want page_title in the <title> for now and we'll revisit after we get 3.0 done. | 18:49 |
| cprov | deryck: cool, fair enough, r=me. I will have to do the same in one of my branches. | 18:50 |
| deryck | cprov, cool. thanks! (And I know, we have several bug pages we need to revisit now, but I don't think we have time. So reversed breadcrumbs will abound. | 18:50 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| cprov | kfogel: I never had a chance to use the migration script, but you change looks good, thanks for adding it to the tree. | 18:56 |
| === cprov changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: salgado, - || queue: [] | ||
| rockstar | salgado, I'm pretty happy with this branch. If you file bugs for those XXX comments, please land it. | 18:58 |
| rockstar | salgado, I've always wondered how the breadcrumbs worked. | 18:58 |
| salgado | rockstar, there's actually just one XXX that will be left there -- the other will be removed | 18:59 |
| salgado | rockstar, I'll file the bug, though. thanks a lot for the review | 18:59 |
| rockstar | salgado, ah yes, you're right. | 18:59 |
| kfogel | cprov: thx | 18:59 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: -, - || queue: [] | ||
| * rockstar goes to lunch | 19:31 | |
| bac | sinzui: you still on your call? | 19:57 |
| sinzui | yep | 19:58 |
| bac | sinzui: ok, i'll just add you to the MP | 19:58 |
| bac | https://code.edge.launchpad.net/~bac/launchpad/bug-432026-person-edit/+merge/11999 | 19:58 |
| === Edwin-lunch is now known as Edwin-afk | ||
| === Edwin-afk is now known as EdwinGrubbs | ||
| kfogel | cprov: in the queue now, thank you. | 20:04 |
| kfogel | (I mean the PQM queue.) | 20:04 |
| cprov | kfogel: cool, thank you. | 20:06 |
| barry | rockstar, cprov either of you have time for a lazr-js related (though not specifically lazr-js) branch? 68 lines; all ui (demo, no test)? | 20:07 |
| cprov | barry: ehe, the no-test part is interesting ... I can. | 20:08 |
| barry | cprov: cool. see what you think ;) | 20:08 |
| barry | cprov: writing the mp now... | 20:09 |
| gary_poster | EdwinGrubbs: did you notice the review reply? | 20:09 |
| EdwinGrubbs | gary_poster: oh, no. Looking at it now. | 20:09 |
| gary_poster | EdwinGrubbs: thank you | 20:09 |
| EdwinGrubbs | gary_poster: r=me | 20:23 |
| gary_poster | Thanks Edwin. | 20:23 |
| barry | cprov: mp sent. i'll paste the url when lp processes it | 20:24 |
| cprov | barry: k | 20:25 |
| barry | cprov: https://code.launchpad.net/~barry/launchpad/413793-inline/+merge/12002 | 20:33 |
| cprov | barry: I'm on it | 20:34 |
| barry | cprov: thanks man | 20:37 |
| cprov | barry: it looks good ... so, '9em' == 'magic value', huh ? | 20:37 |
| barry | cprov: yep :) | 20:38 |
| cprov | barry: I don't mind really, since it can be fixed in the callsite | 20:38 |
| barry | cprov: that was a happy revelation :) | 20:38 |
| salgado | cprov, can you review http://pastebin.ubuntu.com/273054/ for me? it fixes https://bugs.edge.launchpad.net/launchpad-foundations/+bug/429194 by simply removing code | 20:38 |
| mup | Bug #429194: Breadcrumbs shouldn't have icons in them <Launchpad Foundations:In Progress by salgado> <https://launchpad.net/bugs/429194> | 20:38 |
| * barry was so glad not to have to diddle around in lazr-js | 20:39 | |
| salgado | cprov, actually, that's the wrong diff | 20:39 |
| salgado | cprov, http://pastebin.ubuntu.com/273056/ is the correct one | 20:40 |
| cprov | salgado: okay | 20:40 |
| barry | cprov: rock. thanks | 20:41 |
| cprov | salgado: so, no icons in breadcrumb anymore ? | 20:41 |
| cprov | barry: you are welcome. | 20:41 |
| salgado | cprov, yep, no more | 20:42 |
| cprov | salgado: okay, you did a pre-impl call , right ? | 20:42 |
| salgado | cprov, no. why should I? | 20:42 |
| cprov | just for avoiding surprises so close to the 3.0 release ;) | 20:43 |
| cprov | if you are sure not one is expecting it to work, it's okay | 20:43 |
| rockstar | cprov, I'm back from lunch, so you're free to shirk your reviewer responsibilities to me if you'd like. :) | 20:43 |
| salgado | cprov, well, the surprise are the icons showing up when nobody was expecting them. and it was beuno who filed the bug and assigned it to me | 20:44 |
| cprov | rockstar: cool, thanks | 20:44 |
| cprov | salgado: oh, great! that's what I wanted to hear. r=me | 20:45 |
| EdwinGrubbs | sinzui: the http://launchpad.net/rdf page seems completely worthless. | 20:45 |
| sinzui | EdwinGrubbs: that page is awe inspiring | 20:45 |
| sinzui | The link is broken too | 20:46 |
| sinzui | EdwinGrubbs: does anything link to it? Can we remove it? | 20:46 |
| EdwinGrubbs | sinzui: I'll check | 20:46 |
| salgado | thanks cprov | 20:47 |
| cprov | salgado: np | 20:47 |
| cprov | sinzui: can you take a quick looks at https://code.edge.launchpad.net/~cprov/launchpad/bug-412715-registration-info-in-base-layout/+merge/11874, it's ready to land. | 20:48 |
| * sinzui looks | 20:48 | |
| cprov | rockstar: actually, you have a very good timing, I have 2 branches for you. | 20:49 |
| cprov | rockstar: https://code.edge.launchpad.net/~cprov/launchpad/bug-430336-builder-status/+merge/11980 | 20:49 |
| cprov | err, the other MP is arriving ... slowly | 20:50 |
| bac | sinzui: when you get a chance can you have a look at my MP? i'm going to be out for a bit. | 20:54 |
| sinzui | bac: I sent my reply. r=me + a few suggestions | 20:54 |
| bac | sinzui: really? i just looked... | 20:54 |
| * bac looks again. | 20:54 | |
| sinzui | I really did just do it | 20:54 |
| bac | ah so you did. thanks! | 20:55 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: cprov, - || queue: [] | ||
| cprov | rockstar: the other one is https://code.edge.launchpad.net/~cprov/launchpad/bug-422965-archive-permission-api/+merge/12006 | 20:56 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar, cprov || reviewing: cprov, - || queue: [cprov] | ||
| === cprov changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: cprov, - || queue: [cprov] | ||
| cprov | rockstar: thank you. | 20:57 |
| sinzui | cprov: the images I was show place the registration information above the line, on the same line as the application buttons | 21:01 |
| * sinzui looks for image | 21:01 | |
| sinzui | cprov: This is the image beuno showed me: https://devpad.canonical.com/~beuno/LP_new_design_Bugs_v3.1.png | 21:02 |
| sinzui | ^ Since we know the app buttons are a fixed size, we are pretty certain that they will not collide with the registration info | 21:03 |
| cprov | sinzui: yes, that's why I remember too | 21:07 |
| cprov | sinzui: but since the application bar doesn't always refer to the context I though it would be strange to put the context registering information there | 21:07 |
| sinzui | cprov: You have a good argument | 21:08 |
| sinzui | oh | 21:08 |
| cprov | sinzui: do you think we should wait martin and discuss this properly ? | 21:09 |
| sinzui | No. He can file a bug. | 21:09 |
| cprov | right, moving the slot isn't hard. | 21:09 |
| sinzui | cprov: I was going to say to remove the italics, but since I think your point is valid, I think the italics are helpful | 21:10 |
| sinzui | I'm glad we talked. I think you should land this as is. We can fix this next week if Martin can solve the context question | 21:10 |
| cprov | yes, it seemed to be necessary to distinguish it from the page label | 21:10 |
| cprov | sinzui: cool, will land and talk to martin next week. | 21:11 |
| gary_poster | EdwinGrubbs: if I have a template that does not currently have a class, I need to add one for the label, right? There's no exception? | 21:11 |
| gary_poster | a view class I mean | 21:11 |
| cprov | sinzui: thanks for your comments, it's on ec2. | 21:13 |
| === cprov is now known as cprov-afk | ||
| EdwinGrubbs | gary_poster: I don't think there is any exception for the page_title, but you should be able to put the <h1> in the "heading" slot. Check with sinzui. | 21:13 |
| cprov-afk | rockstar: I will be back later to address your comments. | 21:13 |
| gary_poster | ok sinzui wdyt? I was just proceeding to make a view class. It will have a label and page_titlle and that's it | 21:14 |
| sinzui | gary_poster: is this a root object? | 21:15 |
| gary_poster | yeah, /+graohics | 21:15 |
| gary_poster | graphics | 21:15 |
| rockstar | cprov-afk, sounds good. | 21:15 |
| sinzui | you can same time by defining a label and forcing it to be the title...it wont get bradcrumbs | 21:15 |
| * sinzui looks to the secret property | 21:15 | |
| sinzui | gary_poster: you can use override_title_breadcrumbs=True on the view to make the label the authoritative title | 21:17 |
| sinzui | gary_poster: I did not know that page existed until I scanned the uncompleted work yeterday | 21:18 |
| gary_poster | sinzui: :-) is "override_title_breadcrumbs=True" any better than "label = page_title = 'my label and title'" for some reason? | 21:18 |
| barry | sinzui: ping | 21:19 |
| sinzui | gary_poster: In this case no. page_title has been demoted to mean the last part of the bread crumb. | 21:19 |
| sinzui | Hi barry | 21:19 |
| barry | gary_poster: yes, only because we're not changing any of this until after 3.0 :) | 21:19 |
| barry | gary_poster: just to have some stability. after 3.0 we should refine the rules a bit | 21:20 |
| barry | sinzui: hi | 21:20 |
| * gary_poster is confused :-) | 21:20 | |
| sinzui | listen to baryy | 21:20 |
| sinzui | barry | 21:20 |
| gary_poster | ok | 21:20 |
| sinzui | gary_poster: listen to barry. He knows what we are going to change | 21:20 |
| gary_poster | thank you, all | 21:20 |
| barry | sinzui: so, i can either work on bug 403606 or bug 429663 or some templates | 21:20 |
| mup | Bug #403606: ExpatError errors should be handled to not generate the OOPSes <oops> <Launchpad Registry:Triaged by barry> <https://launchpad.net/bugs/403606> | 21:20 |
| mup | Bug #429663: ~team/+invitation/team does not have breadcrumbs <Launchpad Registry:Triaged by barry> <https://launchpad.net/bugs/429663> | 21:20 |
| barry | sinzui: its back to school night tonight, so i have about an hour before i have to disappear | 21:21 |
| sinzui | barry: I think you have a better chance of completing the breadcrumb | 21:21 |
| barry | sinzui: any blueprint mechanicals perhaps? | 21:21 |
| sinzui | barry: yes, I do not know the wiki page at the moment | 21:22 |
| * barry looks | 21:22 | |
| barry | sinzui: there are 19 unconverted blueprint pages. why don't i take a few of those? | 21:23 |
| sinzui | please do | 21:24 |
| barry | coolio | 21:24 |
| barry | sinzui: i'm guessing there are no bugs for those yet | 21:24 |
| sinzui | no, flacoste left us to create the bugs. I have gotten a lot of bug mail form blueprints this week since I am subscribed | 21:25 |
| barry | sinzui: no worries. i'll file bugs as i go | 21:25 |
| flacoste | barry: first thing you could do is finish up abel's branch | 21:26 |
| barry | flacoste: oh? what's that one? | 21:26 |
| flacoste | barry: he's sick today and edwin made a review | 21:26 |
| flacoste | asking for some fix-ups | 21:26 |
| flacoste | he might not be in tomorrow to finish this up | 21:26 |
| flacoste | so it's worth finishing and landing | 21:26 |
| barry | flacoste: do you have a url handy? otherwise i could search for it | 21:27 |
| flacoste | barry: lp:~adeuring/launchpad/bug-430590-specificationgoal-setgoals.pt-3.0-layout | 21:28 |
| flacoste | barry: lp:~adeuring/launchpad/bug-430558-specificationtarget-documentation.pt-3.0-layout | 21:28 |
| * barry looks | 21:28 | |
| flacoste | barry: lp:~adeuring/launchpad/bug-430610-sprint-settopics.pt-3.0-layout | 21:28 |
| flacoste | barry: lp:~adeuring/launchpad/bug-430663-sprint-register.pt-3.0.-layout | 21:28 |
| flacoste | barry: and lp:~adeuring/launchpad/bug-430739-sprintspecification-decide.pt-3.0-layout | 21:29 |
| barry | flacoste: ah. blueprint branches | 21:29 |
| flacoste | see the associated merge proposal | 21:29 |
| barry | flacoste: k | 21:29 |
| flacoste | thanks | 21:30 |
| gary_poster | barry, sinzui: override_title_breadcrumbs=True *forces* use of the page_title. False is the default. I continue to be confused (and wantd to jfdi by setting label to page_title ad move on) | 21:32 |
| gary_poster | am I missing something? | 21:33 |
| barry | gary_poster: yes :) | 21:33 |
| gary_poster | kewl | 21:33 |
| barry | gary_poster: so, right *now* the rule is that page_title is the last component of the breadcrumb, label is the H1/H2, and to completely override the reverse-breadcrumb-in-<title> you need to set the override_title_breadcrumbs=True | 21:34 |
| barry | gary_poster: what we've talked about (after 3.0!) is that label would become the last component in the breadcrumb, and setting page_title would do the override | 21:34 |
| barry | gary_poster: but we did not want to change the rules yet again so close to the cut off | 21:34 |
| gary_poster | I set it to False, and the page rendered. I guess it inherited a True somewhere. So is that OK? | 21:34 |
| barry | gary_poster: it should default to False in LaunchpadView | 21:35 |
| gary_poster | (override_title_breadcrumbs I mean) | 21:35 |
| barry | gary_poster: is your view inheriting from LV? | 21:35 |
| gary_poster | barry: sorry for taking so long, but I wasted some time today not being careful, so was trying to double check. So first, I was wrong: False fails also. It had worked because I had set page_title to label in a fit of pique. When I removed that, it gave "AssertionError: No .page_title or pagetitles.py" just like with the original view class: | 21:39 |
| gary_poster | class LaunchpadGraphics(LaunchpadView): | 21:39 |
| gary_poster | label = 'Overview of Launchpad graphics and icons' | 21:39 |
| gary_poster | override_title_breadcrumbs = True | 21:39 |
| barry | gary_poster: ah, i didn't realize you were hitting the assertion | 21:39 |
| gary_poster | So, the above class is what I have now, and what I thought I was supposed to use, and breaks. | 21:39 |
| barry | (sorry, i probably didn't read the scrollback far enough) | 21:39 |
| barry | gary_poster: you basically hit that assertion when you have no pagetitles.py entry (and you shouldn't :) and no +hierarchy adapter can be found for your view | 21:40 |
| gary_poster | no, it was all theoretical when I asked--I was asking if I really needed a view class just to set a label (answer: yes) | 21:40 |
| gary_poster | right | 21:40 |
| barry | gary_poster: currently, yes | 21:41 |
| gary_poster | I removed the value from pagetitles.py | 21:41 |
| barry | gary_poster: great! pagetitles.py should die | 21:41 |
| gary_poster | barry: So, what should I do? :-) | 21:41 |
| barry | gary_poster: let's skype. it'll be quicker | 21:42 |
| gary_poster | ok | 21:42 |
| === salgado is now known as salgado-afk | ||
| barry` | EdwinGrubbs: ping | 22:20 |
| EdwinGrubbs | barry`: hi | 22:21 |
| barry` | EdwinGrubbs: hi. i've finished abel's bug 430558 branch. would you like to review it? | 22:21 |
| mup | Bug #430558: convert specificationtarget-documentation.pt to 3.0 layout <Launchpad Blueprints:In Progress by barry> <https://launchpad.net/bugs/430558> | 22:21 |
| barry` | EdwinGrubbs: one caveat. it's back to school night and i will be leaving in about 5 minutes. when i get back i'm going to try to update his other branches, but i'll try to get friday's ocr to do the reviews of those | 22:22 |
| EdwinGrubbs | barry`: sure, I'll review it. | 22:23 |
| barry` | EdwinGrubbs: thanks. mp is on its way | 22:23 |
| barry` | EdwinGrubbs: thanks. mp is on its way. it should show up soon and it should be pretty straightforward. i'll check back in a few hours | 22:26 |
| gary_poster | EdwinGrubbs: I am flailing. I've forgotten the secret place to find out the users and passwords to use in dev. sample data has accounts but I don't see passwords and "test" only works for no-priv. Where do I look for these values again? | 22:32 |
| EdwinGrubbs | gary_poster: isn't it the accountpassword table? | 22:33 |
| gary_poster | EdwinGrubbs: ah yes, thanks. | 22:35 |
| EdwinGrubbs | barry`: did you remove the entry in pagetitles.py for that page? | 22:39 |
| gary_poster | EdwinGrubbs: would you be willing to review my new template branch (three templates): https://code.edge.launchpad.net/~gary/launchpad/launchpad-templates-2/+merge/12012 ? | 23:09 |
| EdwinGrubbs | gary_poster: sure | 23:10 |
| gary_poster | thank you very much | 23:10 |
| === rockstar changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] | ||
| EdwinGrubbs | gary_poster: what is +storeblob useful for? | 23:47 |
| wgrant | It's used by apport, Ubuntu's bug reporting tool. | 23:52 |
| gary_poster | wgrant: thank you, I would have had no idea. EdwinGrubbs ^^^ | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
