| === kiko is now known as kiko-afk | ||
| poolie | hi kiko | 00:11 |
|---|---|---|
| thumper | mwhudson: got a few minutes to talk about code imports? | 00:20 |
| wgrant | jml: Is there any point catching exceptions in the sprout/pull, or should I just do it around the open where the problems are actually going to occur? | 00:24 |
| maxb | # cat /usr/share/pyshared/lazr.uri-1.0-nspkg.pth | 00:25 |
| maxb | import sys,new,os; p = os.path.join(sys._getframe(1).f_locals['sitedir'], *('lazr',)); ie = os.path.exists(os.path.join(p,'__init__.py')); m = not ie and sys.modules.setdefault('lazr',new.module('lazr')); mp = (m or []) and m.__dict__.setdefault('__path__',[]); (p not in mp) and mp.append(p) | 00:25 |
| maxb | gary_poster: ^ uhm, yikes :-/ | 00:25 |
| * maxb glares spiky death at pycentral and namespace packages in general | 00:27 | |
| gary_poster | maxb: yeah, welcome to setuptools :-/ | 00:27 |
| gary_poster | I like namespace packages as an idea myself. implementation leaves a bit to be desired, but bringing core features to a language without a language's consent sometimes does that IME | 00:28 |
| maxb | "a bit" | 00:28 |
| gary_poster | :-) | 00:28 |
| ajmitch | maxb: so, that's not perl there, I take it? :) | 00:29 |
| maxb | heh | 00:30 |
| maxb | This is so screwed up. How on earth do you support namespace packages mixed between PYTHONPATH and the system dirs !? | 00:32 |
| wgrant | Run. Away. | 00:32 |
| mwhudson | thumper: ok | 00:35 |
| maxb | Sadly that's not going to result in a running Launchpad | 00:35 |
| mwhudson | the problem with setuptools is that people use it | 00:36 |
| maxb | maxb@z61p:~$ python -c 'import sys; print sys.modules["lazr"]' | 00:36 |
| maxb | <module 'lazr' (built-in)> | 00:36 |
| * maxb boggles | 00:36 | |
| mwhudson | unlike other pje-projects, which people have been insprired by | 00:36 |
| mwhudson | generally usefully | 00:37 |
| jml | wgrant, sorry... | 00:41 |
| gary_poster | maxb: I'm not really around--I need to do some 3.0 stuff, but otherwise not be here. But our general goal has been to keep the system namespace packages at the very end of the pythonpath, so that we don't see them. | 00:42 |
| gary_poster | PYTHONPATH might not be sufficient for that, if it tacks things at the end of the path--and that's what we use for running some scripts. | 00:42 |
| gary_poster | Feel free to do more of course, but if you send me a note with what's calling the codehosting scripts--the mechanism, so I can duplicate it outside of the tests--I'll be happy to do the surgery. | 00:42 |
| jml | wgrant, exceptions are going to occur in open & sprout/pull | 00:42 |
| gary_poster | "happy" ;-) | 00:42 |
| gary_poster | If our approach to bin/py (PYTHONPATH) is at fault, then we'll have to use a faux-interpreter, which will be fine, but will involve some Makefile surgery. | 00:42 |
| jml | wgrant, so catch around both. | 00:42 |
| gary_poster | (done) | 00:42 |
| maxb | I will do some research, I guess | 00:43 |
| gary_poster | maxb: Minimally, if you give me dupe instructions (which maybe are as simple as "install lazr.enum and run the failing tests") then I'll get around to it eventually. | 00:45 |
| maxb | bin/py -c 'import lazr.uri; print lazr.enum' | 00:45 |
| maxb | ^ dupe instructions | 00:45 |
| maxb | oops | 00:45 |
| maxb | I mean bin/py -c 'import lazr.enum' | 00:45 |
| maxb | that's all :-) | 00:46 |
| gary_poster | maxb: yup. I think I had already set up my karmic to try to look like your installation in this regard. ok, that's good enough. thank you, I can go from there. | 00:48 |
| maxb | bin/py -S -c 'import lazr.enum' works | 00:49 |
| maxb | as does bin/py -S scripts/mirror-branch.py -h | 00:49 |
| gary_poster | unsurprising that the import would work. More surprising that the mirror-branch works, but I guess it doesn't need lxml and so on that we have in dist-packages | 00:50 |
| maxb | lp doesn't use lxml anyway :-) | 00:54 |
| mwhudson | screw it, early lunch, focus after hopefully... | 00:55 |
| gary_poster | maxb: no? I thought we did. and there are some other bits that I think we need. | 01:02 |
| wgrant | jml: But exceptions that occur after the open are probably real, even if it's an optional sourcedep. | 01:15 |
| jml | wgrant, ummm... let me think about that for a bit (on a call still) | 01:17 |
| wgrant | jml: OK, sorry. | 01:17 |
| jml | wgrant, no problem at all. | 01:19 |
| jml | ok. | 01:27 |
| jml | I'm back. | 01:27 |
| jml | wgrant, that's a good point. sadly, I don't actually know what the semantics of the 'optional' field in the config file actually are. | 01:28 |
| wgrant | jml: Its intent and use is clear, however. | 01:28 |
| jml | wgrant, you think? | 01:29 |
| jml | wgrant, if it's optional (e.g. shipit), and we can open it, but something happens to prevent us pulling it, what should happen? | 01:29 |
| jml | and why :) | 01:30 |
| wgrant | I think it should die. | 01:30 |
| wgrant | They are optional to prevent things dieing if the user has insufficient privileges. | 01:30 |
| jml | hmm. | 01:31 |
| jml | ok. fair enough. | 01:31 |
| wgrant | If the open succeeds, the user has permission. | 01:31 |
| wgrant | So any subsequent failure is real. | 01:31 |
| jml | wgrant, so, are you preparing a patch for this, or shall I? | 01:36 |
| wgrant | jml: It's sufficiently trivial that it would probably be less work for you to do it. | 01:36 |
| jml | wgrant, heh, ok. | 01:37 |
| thumper | mwhudson: proposal made for import branches | 01:37 |
| wgrant | Just wrapping the Branch.open for new branches is sufficient, but the same should probably be done for the updating thing. | 01:37 |
| jml | thumper, why are you disabling auto-upgrade? | 01:42 |
| thumper | jml: because going from packs -> 2a takes a long! time | 01:46 |
| thumper | jml: a more orderly upgrade would be good | 01:47 |
| thumper | jml: especially with 2.5k imports | 01:47 |
| jml | thumper, *nod* | 01:47 |
| jml | thumper, do you have any plans for how to upgrade the imports to 2a? | 01:47 |
| thumper | jml: nothing concrete yet | 01:48 |
| thumper | jml: we have some ideas for the git imports | 01:48 |
| thumper | jml: I'd like to get the upgrade job done properly | 01:48 |
| thumper | jml: and then probably use that | 01:48 |
| jml | thumper, that makes sense. | 01:48 |
| thumper | jml: but no concrete plans | 01:48 |
| jml | thumper, it'd be good to have some. | 01:49 |
| thumper | jml: yes, it would | 01:49 |
| thumper | jml: but my planning brain has been full with lp 3.0 | 01:49 |
| jml | since as long as they are out of date, we're making Bazaar look slower than it actually is. | 01:49 |
| jml | thumper, understood! :) | 01:49 |
| * jml afk | 02:12 | |
| jml | mwhudson, do I have to do anything wrt ec2-entrypoins? | 02:33 |
| mwhudson | jml: no | 02:33 |
| jml | mwhudson, thanks. | 02:33 |
| mwhudson | jml: i am slaving away to get it ready for review | 02:33 |
| jml | :) | 02:34 |
| mwhudson | jml: will you be able to review it this afternoon? | 02:34 |
| jml | mwhudson, quite possibly | 02:34 |
| mwhudson | jml: excellent | 02:34 |
| jml | away again | 02:38 |
| jml | launchpad probably doesn't need five IRC channels. | 02:57 |
| wgrant | jml: Are you counting an internal one, or am I missing one? | 02:59 |
| jml | wgrant, an internal one, yes. | 02:59 |
| wgrant | But aren't there lots of internal ones? | 02:59 |
| jml | not that I know of. | 03:00 |
| jml | mwhudson, can we import from svn that requires http auth? | 03:01 |
| mwhudson | jml: yes, you have to get a losa to faff around on the slaves though | 03:02 |
| wgrant | If only svn was less braindead and allowed one to specify credentials in the URL like... everything else. | 03:03 |
| jml | I wish every whiteboard were a wall | 03:04 |
| jml | or something | 03:04 |
| mwhudson | jml: it's a strange repo too, it contains a zip file | 03:13 |
| jml | hmm | 03:13 |
| mwhudson | thumper: cscvs branch landed | 03:19 |
| thumper | mwhudson: cool | 03:20 |
| jml | thumper, can a product branch be linked to a product series for a different product? | 03:35 |
| thumper | jml: it shouldn't be able to | 03:35 |
| thumper | jml: I think we check when they try to link it | 03:35 |
| thumper | jml: but if it is linked, then moved, I don't think we check | 03:35 |
| jml | thumper, ahh, that'll explain it | 03:35 |
| jml | (also, is there a bug for that?) | 03:35 |
| thumper | don't think so | 03:36 |
| jml | https://code.edge.launchpad.net/~vcs-imports/schooltool/main | 03:36 |
| jml | I can't delete that branch because I'm not a project driver for obsolete-junk | 03:36 |
| thumper | wgrant: around? | 04:03 |
| thumper | wgrant: bug 407643 | 04:04 |
| mup | Bug #407643: CodeImportNewView confusing after form changes <Launchpad Bazaar Integration:In Progress by thumper> <https://launchpad.net/bugs/407643> | 04:04 |
| rockstar | mwhudson, buying you a beer (or some single malt) is now on my todo list. ec2test --headless is quick now. | 04:22 |
| wgrant | thumper: Hi. | 04:22 |
| thumper | wgrant: hey, take a look at my image attached to the bug | 04:23 |
| thumper | wgrant: I'm getting that reviewed | 04:23 |
| * wgrant looks. | 04:23 | |
| wgrant | thumper: Much better. Thanks. | 04:23 |
| thumper | np | 04:23 |
| thumper | BjornT: you up yet? | 04:24 |
| * thumper thinks optimistically | 04:24 | |
| mwhudson | rockstar: :) | 04:28 |
| mwhudson | jml: hi | 04:30 |
| jml | mwhudson, hi | 04:30 |
| mwhudson | jml: testing anything in ec2test is going to be hard because of python 2.4/2.5 fun-ness | 04:30 |
| mwhudson | though, hah, testrunner doesn't import boto | 04:32 |
| jml | mwhudson, it took me a while to parse that :) | 04:32 |
| mwhudson | jml: sorry :) | 04:33 |
| mwhudson | also bzr plugin path issues :( | 04:33 |
| jml | mwhudson, so, what therefore shall we do? | 04:35 |
| mwhudson | jml: land this branch sans tests? | 04:35 |
| mwhudson | (i haven't actually written any yet) | 04:36 |
| jml | mwhudson, I think that's fair enough. | 04:36 |
| * thumper afk for a few minutes | 04:36 | |
| wgrant | ... Person.t_shirt_size? ahaha. | 04:38 |
| stub | Where did you find that? I thought I managed to kill off that idea. | 04:44 |
| wgrant | In some branch that I happened to come across. | 04:46 |
| mwhudson | jml: you have mail | 04:58 |
| jml | mwhudson, thanks. | 04:58 |
| jml | mwhudson, I'm just going out to lunch. I'll review it when I get back. | 04:59 |
| jml | I'll try to be quick | 04:59 |
| mwhudson | jml: ok, thanks | 04:59 |
| wgrant | Argh. There's no way from the outside to tell whether two LFAs with the same content actually have the same LFC, is there? | 05:15 |
| jml | wgrant, LFA? | 05:38 |
| mwhudson | librarianfilealias, i presume | 05:39 |
| wgrant | Right. It will let me find all LFAs with a particular SHA1, but won't tell me which LFC they point to. | 05:41 |
| wgrant | But I found the relevant code lurking deep in Soyuz, so no matter. | 05:41 |
| wgrant | nascentupload is too big, confusing and scary. | 05:44 |
| jml | yes. | 05:56 |
| jml | I've made it smaller recently | 05:56 |
| jml | and will probably make it smaller again soon. | 05:56 |
| wgrant | Very good. | 05:56 |
| jml | (if ever I get a moment to start working on my top priority tasks!) | 06:24 |
| thumper | yay, bzr 2.0rc2 landed | 06:40 |
| jml | yay | 06:41 |
| rockstar | Man, I'm currently in the mood to replace all the code page tests with unittests. | 06:43 |
| mwhudson | rockstar: possibly not on friday of week 3, but +1 in general | 06:44 |
| rockstar | mwhudson, yes, this is a large reason why I'm not doing it. However, working with the pagetests fills me with vigor that will hopefully last until the weekend. | 06:45 |
| mwhudson | heh | 06:46 |
| rockstar | Also, I will worship at the feet of anyone who will delete notfound-traversals.txt | 06:46 |
| rockstar | Not just worship, but like, sacrifice people and everything. You know, REAL worship. | 06:46 |
| jml | mwhudson, I'm so glad you've done this ec2 command refactoring | 06:56 |
| jml | mwhudson, not just because it makes ec2 better, but also it will make my future command-line apps easier to write :) | 06:56 |
| mwhudson | jml: heh heh | 06:57 |
| mwhudson | jml: bzrlib needs to change a bit to make them truly easy, i think | 06:58 |
| jml | mwhudson, agreed. | 06:58 |
| mwhudson | but i'm not sure i understand how the parts interact sufficiently yet to see precisely how | 06:58 |
| jml | mwhudson, but at least I now have mental hooks into how to begin thinking about it :) | 06:58 |
| mwhudson | otoh, it's 6pm on a friday, i don't understand anything very precisely now | 06:58 |
| jml | heh :) | 07:04 |
| jml | gosh I hate CHR | 07:11 |
| jml | it makes me want to fix about a dozen bugs | 07:12 |
| jml | which is partly the point of doing it | 07:12 |
| * mwhudson EOWs | 07:12 | |
| jml | but I don't think I'll have any time between now & Christmas to do so :\ | 07:12 |
| mwhudson | jml: and then you realize how hard it is to make changes to launchpad | 07:13 |
| jml | mwhudson, see you around | 07:13 |
| mwhudson | jml: good luck with the move | 07:13 |
| jml | mwhudson, I might change code import branches to be owned by their actual owners rather than vcs-imports, just to surprise you :P | 07:13 |
| jml | mwhudson, thanks! | 07:13 |
| mwhudson | jml: that would be awesome | 07:13 |
| jml | mwhudson, although maybe deleting comments would make me more friends :) | 07:14 |
| mwhudson | jml: deleting comments would make you friends in more ... authorized ... places, for sure | 07:35 |
| jtv | connection blinking... I need coffee. | 08:00 |
| jtv | hi mwhudson, thanks for your help; I slept wonderfully | 08:00 |
| mwhudson | jtv: hooray | 08:00 |
| jtv | Does noone take things out of context anymore? | 08:10 |
| wgrant | Sadly I read the earlier conversation, so could not help you. | 08:12 |
| jtv | A sad day for puerile office humor | 08:20 |
| henninge | Hi! | 08:20 |
| henninge | Does anybody know how to display a projects logo? | 08:20 |
| henninge | <img tal:attributes="src project/... | 08:21 |
| henninge | ? | 08:21 |
| henninge | Like the new template does on the top left | 08:21 |
| wgrant | henninge: project/image:logo? | 08:23 |
| wgrant | I think that should work. | 08:24 |
| * henninge tries | 08:24 | |
| henninge | wgrant: does that give me the url or the full tag? | 08:24 |
| wgrant | henninge: I presume the full tag, but I don't know. | 08:25 |
| * wgrant checks the formatter. | 08:25 | |
| wgrant | The whole tag. | 08:25 |
| henninge | yup, just found out, too. | 08:26 |
| wgrant | If you want the URL, you might just have to use project/logo/fmt:url, I guess. | 08:26 |
| henninge | Thanks! | 08:26 |
| henninge | nope, that's what I tried first ... | 08:26 |
| wgrant | I guess LFAs are special. | 08:27 |
| henninge | looks beautiful ... ;-) | 08:27 |
| wgrant | What are you doing with it? | 08:28 |
| * jtv heads for lunch | 08:46 | |
| mrevell | Morning | 09:02 |
| jml | good morning | 09:03 |
| * jml is about to EOW | 09:03 | |
| jml | (last week in .au) | 09:03 |
| mrevell | Man, are you nervous jml? | 09:03 |
| jml | not yet. | 09:04 |
| jml | I tend to get nervous at the last minute. | 09:04 |
| bigjools | morning all | 09:04 |
| wgrant | bigjools: I will reply to your ddeb email more thoroughly later, but did you really mean to suggest that ddebs shouldn't skip NEW? | 10:11 |
| wgrant | That will make archive admins very sad. | 10:11 |
| bigjools | wgrant: yes, of sorts, they should do what debs do, it will make it *much* easier | 10:11 |
| wgrant | bigjools: If they're going to follow the corresponding deb, there's no point sending them through NEW. | 10:12 |
| wgrant | Because they should always inherit the same override. | 10:12 |
| bigjools | wgrant: I am assuming that they are always in step with the corresponding deb | 10:12 |
| bigjools | yes, you won't *see* them in NEW, you just accept the deb | 10:12 |
| wgrant | But should they be sufficient to send a binary upload into NEW? | 10:13 |
| bigjools | not on their own | 10:13 |
| bigjools | that decision should be based on the deb | 10:13 |
| wgrant | Right. | 10:13 |
| wgrant | So they should skip NEW. | 10:13 |
| bigjools | depends how you look at it :) | 10:14 |
| wgrant | Except not quite in the way they do now, perhaps. | 10:14 |
| bigjools | yeah, that part's confusing | 10:14 |
| bigjools | it would help if I knew more about how and when they are generated | 10:14 |
| wgrant | I need to look at how overrides work in the queue. | 10:14 |
| bigjools | I can help you with that, it's quite easy | 10:15 |
| wgrant | I haven't really looked at the queue stuff all that much. | 10:15 |
| bigjools | I have :( | 10:15 |
| bigjools | the +queue page is the bane of my soyuz life | 10:15 |
| wgrant | Heh. | 10:15 |
| wgrant | What do you need to know about ddebs that would help? | 10:16 |
| bigjools | from what you said, you implied that they can be NEW where the corresponding deb is not? | 10:16 |
| wgrant | Basically, they're automatically generated for and will accompany binaries with compiled binaries. | 10:17 |
| wgrant | So once all my glue is in place, and the switch is turned on... | 10:17 |
| bigjools | this is as I expect, so far | 10:17 |
| wgrant | The first build for each arch of each source that compiles things will produce NEW binaries. | 10:18 |
| wgrant | This only happens the first time for each (source, arch) after the switch is flipped. | 10:18 |
| wgrant | Or when a binary begins to contain compiled code. | 10:18 |
| bigjools | but we'll not put them through NEW since their debs are not NEW | 10:19 |
| wgrant | Right. | 10:19 |
| bigjools | only when the DEB is new | 10:19 |
| bigjools | err wrong caps :) | 10:19 |
| wgrant | But without the ddeb-specific hacks, we'd have a hundred thousand builds in NEW because of the ddebs. | 10:19 |
| wgrant | Hmm. Dinner. | 10:20 |
| * wgrant departs for a little while. | 10:20 | |
| bigjools | wgrant: indeed | 10:20 |
| bigjools | I need more caffeine | 10:20 |
| === henninge_ is now known as henninge | ||
| henninge | How do I get the urls to the application homepages? | 10:33 |
| henninge | https://bugs.launchapd.net/, bugs.edge.lp.net ... | 10:34 |
| henninge | from tal, ideally | 10:34 |
| henninge | maybe, this is too obvious ... ? | 10:37 |
| intellectronica | henninge: just a guess, but can you pass the application object to canonical_url ? | 10:37 |
| henninge | intellectronica: oh right, from python i could use canonical_url with rootsite and an empty url? | 10:38 |
| * henninge tries | 10:38 | |
| intellectronica | henninge: i was more thinking of the top-level application object, but i'm really just guessing. let me know when you find out, i'm curious now | 10:39 |
| henninge | intellectronica: right, I need an application object. I have that (its the root view after all) | 10:40 |
| henninge | so it's context | 10:40 |
| intellectronica | huh, of course :) | 10:41 |
| henninge | bigjools: does soyuz have an application home page? | 10:47 |
| bigjools | henninge: no, it's homeless | 10:47 |
| bigjools | soyuz is a hobo | 10:47 |
| henninge | sleeps under bridges ... | 10:47 |
| bigjools | are you trolling? | 10:47 |
| bigjools | ba. dum. tish. | 10:48 |
| henninge | intellectronica: I've got this in the view now http://paste.ubuntu.com/273353/ | 10:51 |
| intellectronica | nice | 10:53 |
| === mpt_ is now known as mpt | ||
| deryck | Morning, all. | 10:59 |
| === henninge is now known as henninge-lunch | ||
| wgrant | Fancy new profile page. | 12:03 |
| wgrant | Even fixes the edit form mess. | 12:03 |
| === henninge-lunch is now known as henninge | ||
| jmux | Hi. I want to work on bug #188564 (Non-Ubuntu a.k.a. Debian PPAs). I already have some ideas about the implementation and I saw that there is already an (empty) blueprint registered with the bug. Where should I put my ideas (new page on dev.launchpad.net), so we can discuss my ideas, before I start an implementation? | 12:43 |
| mup | Bug #188564: Build also packages for Debian in PPA's <feature> <ppa> <soyuz-core> <Soyuz:Triaged> <https://launchpad.net/bugs/188564> | 12:43 |
| bigjools | jmux: hi | 12:43 |
| wgrant | That's a hard one. | 12:44 |
| jmux | Ok - just happens some more people think about it :-) | 12:44 |
| wgrant | Although it already mostly works. | 12:44 |
| bigjools | jmux: that would be great, somewhere under http://dev.launchpad.net/Soyuz/ and link to it from the blueprint | 12:44 |
| jmux | bigjools: ok | 12:45 |
| wgrant | jmux: I've got notes locally on the issues that I identified a few weeks ago. | 12:51 |
| wgrant | But I imagine that there are further non-technical barriers to this, eg. buildd time, librarian disk, germanium disk, chroot administration time. | 12:52 |
| === danilo_ is now known as danilos | ||
| jmux | wgrant: Can you send me your notes? I'm jmglogow in launchpad. | 12:58 |
| wgrant | jmux: Sure. | 13:00 |
| wgrant | jmux: Sent. | 13:04 |
| === mrevell is now known as mrevell-lunch | ||
| gmb | intellectronica: In the new bug page, should we show "Report another bug" and "List all open bugs" with the other actions (mark dupe, convert to question, etc)? | 13:22 |
| gmb | Or should we just get rid of them? | 13:22 |
| intellectronica | gmb: we should definitely have the report another bug (see discussion on the ml). the question is whether to just include it in the involvement portlet style or as something less prominent | 13:24 |
| gmb | intellectronica: I'll re-read that thread; must've missed that part of the discussion. (I wish that Google had invented "highlight the text relevant to my brain2) | 13:24 |
| intellectronica | i think the 'list all open bugs' link is not necessary, though | 13:24 |
| gmb | intellectronica: Agreed on both counts. I'll put the report a bug link in the portlet for now; we can always move it later. | 13:25 |
| intellectronica | gmb: i'd say an action link like for the 'report another bug'. the involvement portlet is too prominent | 13:25 |
| gmb | Hmm. | 13:25 |
| gmb | intellectronica: Maybe we should just leave it at the foot of the page then. | 13:25 |
| intellectronica | and it would be a bit weird because the context isn't the target, it's the bugtask | 13:26 |
| gmb | Yeah. | 13:26 |
| intellectronica | gmb: i really can't decide on that. ot1h putting it at the bottom kinda' makes sense because it communicates that you should read everything before filing another bug. otoh, part of the redesign is an attempt to move the actions back together so users don't have to search for them all over the page | 13:27 |
| gmb | Right. | 13:27 |
| intellectronica | maybe leaving both links at the bottom is the path of least resistance, though | 13:28 |
| intellectronica | gawd, i'm not really helping, am i :-/ | 13:28 |
| gmb | intellectronica: It's Friday week 3. PoLR is my favourite route today. | 13:28 |
| intellectronica | gmb: yeah, i agree | 13:28 |
| gmb | intellectronica: Design is hard. This is why we employ Argentinians. | 13:28 |
| gmb | (And mpt, but hey, that spoils the gag) | 13:29 |
| gmb | Hah. Failure in tests: Just about everything under lp.bugs.stories. What a surprise. | 13:31 |
| mpt | gmb, I could pretend to be Argentinian. I eat meat. | 13:32 |
| gmb | mpt: You might need to talk faster and gesticulate more, but hey, this is IRC... | 13:33 |
| mpt | \o_ | 13:34 |
| gmb | Hah. | 13:34 |
| henninge | mrevell-lunch, noodles775: Can you please look at bug 431244, my last comment? I need some input UI-wise (and a review eventually) and content-wise (new blog posts!). | 13:35 |
| mup | Bug #431244: Launchpad homepage needs conversion to 3.0 design. <story-ui-3> <Launchpad Foundations:In Progress by henninge> <https://launchpad.net/bugs/431244> | 13:35 |
| henninge | I will be relocating now but will be back soon. | 13:36 |
| noodles775 | k | 13:36 |
| henninge | thanks | 13:36 |
| === mrevell-lunch is now known as mrevell | ||
| wgrant | Somebody might want to point henninge at bug #429247 when he returns. | 13:53 |
| mup | Bug #429247: Locationless <h1>s block login/out widgets <story-ui-3> <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/429247> | 13:53 |
| wgrant | henninge: Bug #429247 | 14:07 |
| mup | Bug #429247: Locationless <h1>s block login/out widgets <story-ui-3> <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/429247> | 14:07 |
| henninge | wgrant: thanks! | 14:09 |
| henninge | wgrant: now I am wondering if it should really be "low" ... | 14:09 |
| wgrant | henninge: Not if the homepage is locationless, no. | 14:10 |
| henninge | yup | 14:10 |
| henninge | wgrant: I don't see another way to do the home page, at least not if I stick to Martin's design... | 14:10 |
| henninge | mrevell, noodles775: I am back btw. | 14:11 |
| henninge | ;-) | 14:11 |
| wgrant | henninge: Right. | 14:12 |
| flacoste | sinzui, barry, bac, salgado, EdwinGrubbs: Registry conversion is complete, awesome job!!! | 14:17 |
| sinzui | flacoste: rockstar: what is the status of the final 3 answers pages? | 14:20 |
| flacoste | sinzui: only rockstar knows and it's a little early for him yet | 14:21 |
| rockstar | sinzui, it's approved to land, but tests keep failing. I'm working on them now. | 14:21 |
| sinzui | :( | 14:22 |
| rockstar | sinzui, yea, tell me about it. | 14:22 |
| sinzui | rockstar: how can you be on American East Coast Time and keep time with NZ? | 14:23 |
| rockstar | sinzui, I sleep 40 minutes every few hours. | 14:23 |
| rockstar | ...give or take. | 14:23 |
| rockstar | (especially when I have a deadline) | 14:24 |
| noodles775 | henninge: yep, I'll be taking a look shortly (just had lunch-break) :) | 14:29 |
| henninge | noodles775: fine | 14:29 |
| rockstar | sinzui, ping | 14:50 |
| sinzui | hi rockstar | 14:50 |
| rockstar | sinzui, so my tests were all passing, but I apparently had conflicts, so I merged in trunk, and now my templates are throwing TraversalError in the MenuAPI on context. Would you know what changed to do this? | 14:51 |
| sinzui | yes | 14:53 |
| sinzui | rockstar: There is python error in one of the links | 14:53 |
| sinzui | rockstar: you can see the real error in a unittest, browser tests hide it | 14:53 |
| rockstar | sinzui, okay, I'll take a gander. | 14:54 |
| sinzui | rockstar: I had a bad experience a few months ago when I discovered I wrote a link the correct way (pass the name to canonical_url). and the link failed because the view was not registered for IProject. | 14:55 |
| rockstar | sinzui, well, it was working before the merge. If I revert, everything is fine, but then I have conflicts. | 14:55 |
| sinzui | rockstar: The link was canonical_url(something) + '/+view-name' | 14:55 |
| sinzui | rockstar: I have a simple test tool | 14:56 |
| * sinzui looks for example | 14:56 | |
| rockstar | sinzui, usedfor = IBranch should make it work, right? | 14:56 |
| sinzui | That is perfect | 14:56 |
| sinzui | rockstar: You can check_menu to verify the links http://pastebin.ubuntu.com/273506/ | 14:59 |
| sinzui | rockstar: it instantiates the link and verifies there is a view for it. It will die when the link logic is bad of the view is not registered | 15:00 |
| rockstar | Alright, I'll give it a whack. | 15:00 |
| sinzui | rockstar: ^ I added this because I discovered that there were two bad links that were very old in that menu | 15:01 |
| sinzui | bac: I just assigned bug 422334 to you. I do think it is trivial, but it may be easy do since person-index does it | 15:02 |
| mup | Bug #422334: "Contact this team" link should be in the action menu <Launchpad Registry:Triaged by bac> <https://launchpad.net/bugs/422334> | 15:02 |
| bac | ok | 15:02 |
| sinzui | bac: Oh, person-index did it by not putting it in the action menu, we just put it in the side bar. that is much easier | 15:03 |
| maxb | barry: Re your 14 failures and 2 errors on Karmic - I attribute 13 failures and 2 errors to the lazr import mess mentioned on LaunchpadOnKarmic - I added a rather crude workaround to that page this morning | 15:05 |
| barry | maxb: cool. i haven't looked into it in detail, but thanks for working on it | 15:05 |
| maxb | I am hugely jealous of having a machine that can get through bin/test in 2 hours :-) | 15:10 |
| barry | maxb: i earned it though. the machine i had been using was painful, loud, hot, and unreliable. :) | 15:12 |
| maxb | I ran it on an Aspire One netbook once. Took 9¼ hours :-) | 15:13 |
| barry | ouch. before this box, i had nothing newer than circa 2006 and my main dev box was a 3ghz p4. otoh, i don't get as many naps now <wink> | 15:15 |
| * gmb -> out BBIAB. | 15:40 | |
| EdwinGrubbs | sinzui: did I use the wrong milestone for bug 432516? | 15:47 |
| mup | Bug #432516: Convert /rdf page to UI 3.0 <Launchpad Foundations:In Progress by edwin-grubbs> <https://launchpad.net/bugs/432516> | 15:47 |
| sinzui | EdwinGrubbs: wrong project. the file is owned by launchpad-foundations | 15:48 |
| EdwinGrubbs | sinzui: oh, that probably changed the milestone automatically, and I didn't notice anything else in the email. | 15:48 |
| sinzui | yes, it does. | 15:49 |
| === EdwinGrubbs is now known as Edwin-afk | ||
| rockstar | sinzui, if the context of a page is an IQuestionSet, and I register a menu with usedfor IQuestionSet, the view should be able to get to the menu, right? | 16:39 |
| sinzui | rockstar: yes in a manner is speaking | 16:40 |
| sinzui | rockstar: views and context can both have a menu, since you have both objects, you have two menus. | 16:41 |
| sinzui | rockstar: <context|view>/@@+global-action | 16:41 |
| rockstar | sinzui, so I have a menu that works for the view when the context is ISearchableByQuestionOwner, but not when the context is IQuestionSet. | 16:41 |
| rockstar | sinzui, this is an application menu. | 16:41 |
| sinzui | so context/menu:answers will work. since they are not associated with a view, you need to ensure the menu is registered for both. | 16:43 |
| sinzui | rockstar: I have done a lot of subclassing that modifies one or two lines like label, page_title, usefor to update everything to 3.0 | 16:44 |
| rockstar | sinzui, so, I seem to have fucked these menus up beyond recognition. I'm feeling pretty frustrated. Can we have a call? | 16:47 |
| sinzui | yes | 16:47 |
| sinzui | rockstar: I am ready | 16:47 |
| === salgado is now known as salgado-lunch | ||
| EdwinGrubbs | jml: ping | 16:54 |
| EdwinGrubbs | rockstar: ping | 16:54 |
| rockstar | EdwinGrubbs, on the phone. | 16:54 |
| EdwinGrubbs | deryck: ping | 16:55 |
| flacoste | barry: did you land all of adeuring branches? | 16:58 |
| deryck | EdwinGrubbs, pong | 16:58 |
| barry | flacoste: i could only get the first one landed | 16:58 |
| EdwinGrubbs | deryck: do you need help converting the hwdb pages on https://dev.launchpad.net/VersionThreeDotO/UI/TemplateToDoList since Abel is out? | 16:58 |
| barry | flacoste: the others are still up for grabs | 16:58 |
| flacoste | EdwinGrubbs: could you finish adeuring branches? | 16:59 |
| EdwinGrubbs | flacoste: sure | 16:59 |
| deryck | EdwinGrubbs, yes, please. | 16:59 |
| === matsubara is now known as matsubara-lunch | ||
| rockstar | sinzui, I'm not entirely sure the question-listing and faq-listing are going to get done today. The tests are making me realize they are bigger than I thought. | 17:13 |
| rockstar | If PQM doesn't close until tomorrow, I may be able to get it done tonight. | 17:14 |
| rockstar | flacoste, when is PQM closing? | 17:17 |
| sinzui | rockstar: do what you can. I can help fix tests, change code, do reviews. I have a only a few tomorrow because I leave for a sprint | 17:18 |
| rockstar | sinzui, I think I'm going to quit on this branch, and do a really minimal mechanical change, and then come back to this and do it proper. | 17:20 |
| sinzui | rockstar: push the branch. I'll try to pick it up. I am going to assist salgado first | 17:21 |
| rockstar | sinzui, the problem is that question-listings can by applied to LOTS of different Interfaces, and they all need different items in their menus. | 17:21 |
| intellectronica | henninge: not that i'm any authority on this, but i think the new homepage is great. there's lots of stuff that can be improved, but as it is it's already a great improvement and i would be proud to have it as our 3.0 homepage | 17:22 |
| henninge | intellectronica: thank you so much ! | 17:23 |
| flacoste | rockstar: i'm thinking of closing it on Sunday when spm starts | 17:43 |
| rockstar | flacoste, okay. That actually gives me a little breathing room. I was thinking it'd close in about 7 hours, and so that means I have to be off to ec2 in 3. | 17:44 |
| === deryck is now known as deryck[lunch] | ||
| sinzui | salgado-lunch: how can I help you | 17:57 |
| rockstar | sinzui, so, I changed the menus in answers, and for some reason, the titles of the pages all broke. Would you happen to know why? | 18:04 |
| sinzui | rockstar: I think titles broke when barry landed his branch on Saturday. Did you see the bug I reported about FAQs | 18:05 |
| sinzui | rockstar: titles are the inverse of breadcrumbs, but I think there is something missing form the view (labels and or page_titles) because neither is being used. FAQs to not have a title or a heading | 18:07 |
| mrevell | night all | 18:08 |
| rockstar | sinzui, I did. | 18:09 |
| sinzui | rockstar: I see. FAQ does not have a view. That is why is is screwed up. You may want to verify if everything you are working with has a view in configure.zcml | 18:09 |
| rockstar | sinzui, the thing is, without my patch, the tests are fine, but with my patch, the tests aren't fine. | 18:09 |
| sinzui | because all the page titles changed form sane to crack? | 18:10 |
| sinzui | I see the FAQ is an easy fix | 18:10 |
| EdwinGrubbs | sinzui: is the ISprintSpecification/+decide page even used now? It seems to be superseded by the ISprint/+settopics page that lets you decide on multiple ISprintSpecifications at once? I can't even figure out how to load +decide since there are no tests. | 18:11 |
| rockstar | sinzui, yeah, it shouldn't be hard. I'm talking about listings now though, not the bug you file (although I can probably fix that too) | 18:11 |
| sinzui | EdwinGrubbs: I do not know the answer. | 18:12 |
| sinzui | rockstar: I see that question-listing use LaunchpadView, not a subclass to define a page_title or label | 18:13 |
| sinzui | rockstar: in 3.0 every page needs unique view. | 18:14 |
| rockstar | sinzui, wait, what? | 18:14 |
| rockstar | sinzui, maybe I should get on the phone with you again, if that's agreeable. | 18:15 |
| sinzui | rockstar: For a page to be a full page (a page title) it must have a view to define that. I can see in my copy of RF that it does not: | 18:16 |
| sinzui | <browser:pages | 18:16 |
| sinzui | for="lp.answers.interfaces.question.IQuestion" | 18:16 |
| sinzui | class="canonical.launchpad.webapp.LaunchpadView" | 18:16 |
| sinzui | permission="zope.Public"> | 18:16 |
| sinzui | <browser:page | 18:16 |
| sinzui | name="+listing-detailed" | 18:16 |
| sinzui | template="../templates/question-listing-detailed.pt" /> | 18:16 |
| rockstar | sinzui, question-listing-detailed isn't a full page though. | 18:17 |
| rockstar | It's a fragment. | 18:17 |
| sinzui | rockstar: ^ subclass LaunchpadView and give it a label (and maybe a page_title). barry says it needs a label, salgado-lunch says it needs a page_title. I decided the two can fight it out in a caged match next week | 18:17 |
| sinzui | rockstar: okay, my misunderstanding | 18:18 |
| sinzui | rockstar: when template and view is the issue | 18:18 |
| rockstar | sinzui, this my diff that somehow breaks page titles : http://pastebin.ubuntu.com/273626/ | 18:18 |
| * barry prefers silly string and water balloons, but is up for anything | 18:18 | |
| sinzui | two men enter, one man leaves | 18:18 |
| === salgado-lunch is now known as salgado | ||
| sinzui | rockstar: your diff does not show that you added SearchQuestionsView.page_title | 18:22 |
| salgado | sinzui, until we have some time for the caged match I've changed the code to be happy with either a label or a page_title | 18:23 |
| salgado | sinzui, and all the failing tests seem to be fixed, according to ec2 | 18:24 |
| sinzui | rockstar: in fact, I see it was only added to ManageAnswerContactView. I think all views in the browser modules need a label or a page_title | 18:24 |
| rockstar | sinzui, lable and page_title are and/or? | 18:24 |
| sinzui | salgado: You more than rock! | 18:24 |
| sinzui | rockstar: try a label first and see what happens. I expect you to get something since barry guarantees a title form the breadcrumbs | 18:26 |
| barry | rockstar: if you're getting breadcrumbs already, that will be used as the default title, but currently label is required | 18:27 |
| rockstar | It looks like I just needed to move pageheading to be page_title. We'll see what happens. | 18:28 |
| sinzui | rockstar: Yes! that was what I was thinking when I created the page_title attribute. That is also why I wanted to do answers, I could cheat with a global find and replace | 18:30 |
| rockstar | sinzui, :) I still need a label though, right? Can it be the same as the page_title? | 18:33 |
| gary_poster | bigjools: is sources-list.pt (from the launchad list of templates) soyuz? Or can we ignore it? | 18:33 |
| gary_poster | deryck[lunch]: I'm still thinking that bugs will be doing the hwdb stuff from https://dev.launchpad.net/VersionThreeDotO/UI/TemplateToDoList | 18:34 |
| gary_poster | is that right? | 18:34 |
| sinzui | rockstar: given what salgado said about label/page_title I don't think it needs a label if the page is displaying the page_title in the heading and title. If they are not displayed, I would make lable = page_title | 18:36 |
| sinzui | rockstar: I think in 3.1.10, we will remove the heading-slot and page_title. We will just use label. The mater is being discussed | 18:36 |
| EdwinGrubbs | salgado: I thought it was possible to override just the +foo part of the page_title? | 18:36 |
| sinzui | EdwinGrubbs: do not think about that matter | 18:37 |
| sinzui | EdwinGrubbs: we need to wait for salgado's branch to land before we can judge what needs to be changed. the +foo = view.label or view.page_title | 18:38 |
| rockstar | sinzui, and failures like this are to be expected and changed? http://pastebin.ubuntu.com/273636/ | 18:38 |
| sinzui | rockstar: :( yes. that is the new page title rules that landed 6 days ago | 18:39 |
| rockstar | sinzui, great, that's all I needed to know. At least now I know they are supposed to break and be fixed, and it's not something I did unintentionally. | 18:39 |
| sinzui | EdwinGrubbs: keep this in mind as you make changes. An ugly page title is easy to fix in the future. but every 2.0 page will have broken navigation. we need the pages converted now. No blueprint or launchapd page is worth more than 1 hour of hacking time | 18:41 |
| === deryck[lunch] is now known as deryck | ||
| deryck | gary_poster, I believe EdwinGrubbs was going to take care of the hwdb templates if he could. | 18:46 |
| gary_poster | oh ok | 18:47 |
| gary_poster | EdwinGrubbs: I'm working on low-priority templates--actually I will update the todo list--so I can do that instead if you are booked. | 18:47 |
| EdwinGrubbs | gary_poster: I was going to try, but right now I'm working on Abel's branches that were already review but needed a few changes, so if you want to take them, go for it. | 18:47 |
| gary_poster | EdwinGrubbs: ok. I'll finish my current bits and then check in with you. thanks | 18:48 |
| barry | does anybody know what the hell ABE is and how to shut it off for all of launchpad.dev? | 18:50 |
| gary_poster | barry: do you mean those log messages? | 18:51 |
| gary_poster | starting with A and B and E and with dates and stuff? | 18:51 |
| barry | gary_poster: it's a firefox thing and it stops me from hitting certain launchpad.dev urls, though it seems to be completely random about what it complains about | 18:51 |
| barry | ABE = (apparently) application boundaries enforcer | 18:51 |
| gary_poster | barry: oh, sorry, then no. :-/ | 18:51 |
| barry | gary_poster: ;) | 18:52 |
| barry | ah. it's a noscript thing | 18:52 |
| gary_poster | noodles775 (redirected from asking bigjools): is sources-list.pt (from the launchad list of templates) soyuz? Or can we ignore it? | 18:55 |
| * sinzui takes specification-index | 18:58 | |
| bac | hi salgado | 19:02 |
| salgado | hi bac | 19:02 |
| bac | salgado: when i run 'bin/test -vvm lp.registry' now i get http://paste.ubuntu.com/273651 . it was introduced by the branch you landed for jamal | 19:03 |
| salgado | bac, are you sure? the changes I reviewed didn't have anything related to that | 19:04 |
| * salgado checks the diff from the revision email | 19:04 | |
| bac | salgado: i don't know what is happening. the error does mention lp.registry.browser.test.test_person_view, which that branch introduced | 19:05 |
| bac | salgado: i have isolated it to that revision - 9521 | 19:05 |
| maxb | LP looks a bit plain now the colour-coded applications aren't any more | 19:05 |
| sinzui | maxb: your meeting the team leads in London at the end of the month aren't you? | 19:06 |
| salgado | bac, that's weird; I submitted the branch through ec2, but it's possible it conflicts with something that landed while it was in ec2. let me check | 19:07 |
| maxb | Yes | 19:07 |
| sinzui | maxb: I'll introduce you to beuno. You can talk colour with him | 19:07 |
| bac | salgado: wait, i may have the wrong revision | 19:07 |
| rockstar | barry, I still seem to be getting +faqs in my title, even though I have label and page_title defined. | 19:07 |
| salgado | bac, looks like 9517 touched stuff related to ArchiveAdminView | 19:08 |
| sinzui | rockstar: that is correct. the page titles are the inverse of breadcrumbs | 19:08 |
| flacoste | gary_poster: do you know what would cause http://pastebin.ubuntu.com/273658/ ? | 19:08 |
| rockstar | sinzui, so it saying +faqs is okay? | 19:08 |
| sinzui | rockstar: salgado's recent work will use the page_title/label to replace the +faq | 19:08 |
| bac | salgado: yeah, but if i revert to -r 9520 the failure happens. -r 9519 does not have it | 19:09 |
| rockstar | sinzui, okay, I'll leave that to him then. | 19:09 |
| sinzui | rockstar: If he lands first, you need to update the test. | 19:09 |
| bac | salgado: can you reproduce the problem? | 19:09 |
| salgado | sinzui, rockstar, my branch is on PQM | 19:09 |
| rockstar | sinzui, yes, it's a race. | 19:09 |
| === ursula_ is now known as Ursinha | ||
| rockstar | salgado, dammit! :) | 19:10 |
| salgado | bac, let me try something slightly different | 19:10 |
| gary_poster | flacoste: there could be a variety of reasons. If you are not using our custom buildout, try using a clean, non-system Python. That's the only way it is likely to work. | 19:11 |
| rockstar | salgado, what's the url of your branch? I'd like to merge it. | 19:11 |
| bac | salgado: with the latest devel, if i 'rm lib/lp/registry/browser/tests/test_person_view.py' the warning goes away | 19:12 |
| flacoste | gary_poster: what do you mean? that package is not installed in site-packages | 19:12 |
| salgado | rockstar, bzr+ssh://bazaar.launchpad.net/~salgado/launchpad/breadcrumbs-for-leafs | 19:12 |
| rockstar | salgado, ah yes, I reviewed that yesterday... | 19:12 |
| flacoste | gary_poster: i think it's because their archive is screwed-up | 19:13 |
| gary_poster | flacoste: I'd try a clean Python myself. The other thing to do is look at the package you downloaded. If the setup.py doesn't deliver what the egg promises, you'll get problems. | 19:13 |
| flacoste | gary_poster: the tar file is gviz_api_py, untarring it leaves only a google-visualization-python directory | 19:13 |
| gary_poster | huh | 19:13 |
| flacoste | gary_poster: and the setup.py in that file has name="gviz_api.py" | 19:13 |
| flacoste | do these google folks actually knows what they are doing? | 19:14 |
| gary_poster | yeah, sounds broken | 19:14 |
| gary_poster | :-) | 19:14 |
| salgado | bac, do you have an ArchiveAdminView class in your lp/soyuz/browser/archive.py? | 19:15 |
| bac | salgado: yes | 19:15 |
| bac | salgado: can you reproduce it? | 19:15 |
| flacoste | gary_poster: redoing a python sdist and using the resulting archive worked | 19:16 |
| gary_poster | lol | 19:16 |
| salgado | bac, './bin/test -vvt test_person_view' just passed here | 19:16 |
| salgado | bac, should I do something else to reproduce it or is that how you're doing it? | 19:16 |
| bac | salgado: bin/test -vvm lp.registry | 19:17 |
| bac | salgado: i don't think test_person_view is the culprit, but it causes the problem to show up | 19:18 |
| bac | salgado: but i'm anxious to see if it happens in your environment | 19:18 |
| salgado | bac, reproduced | 19:18 |
| bac | salgado: weird, no | 19:18 |
| salgado | it makes absolutely no sense | 19:19 |
| salgado | the name is defined in the module and the error is only triggered when we do -vvm lp.registry | 19:20 |
| bac | yep | 19:21 |
| bac | sinzui: you have any ideas? ^^^ | 19:21 |
| sinzui | bac: No ideas | 19:23 |
| bac | sinzui: drats. | 19:23 |
| sinzui | bac: well I have ideas, but they are ideas from previous single test nonsense where a test does not cleanup or worse, a test expects the predessor to not cleanup, so when the test order changes, the test fails | 19:24 |
| bac | sinzui: yeah, but this isn't a data issue. it's an import failure | 19:25 |
| bac | salgado: can you try something else, unrelated? see if you can 'make iharness' | 19:25 |
| sinzui | bac: oh does my branch that I pulled from review fix the issue? https://code.edge.launchpad.net/~sinzui/launchpad/import-person/+merge/12060 | 19:25 |
| sinzui | bac ^ I was triaging the bug and fixed it at the same time | 19:26 |
| salgado | bac, I can't, but that's because of some windmill crap | 19:26 |
| bac | salgado: yeah, i think bjornt's branch (r 9499) introduced it | 19:26 |
| bac | sinzui: your branch does not help | 19:28 |
| bac | salgado, sinzui: ArchiveAdminView is a red herring. if i comment out the first line of c/l/browser/__init__.py it complains about lp.soyuz.browser.build.BuildContextMenu | 19:38 |
| bac | by 'it', i mean bin/test -vvm lp.registry | 19:38 |
| sinzui | bac: We is this really stopping you from working on templates. Can you run the test another way? | 19:40 |
| bac | sinzui: no, the next change is ready to review. i'll let it go... | 19:40 |
| salgado | bac, if you move the import of PersonView into the method where it's used, the warning/error goes away | 19:42 |
| bac | salgado: this problem smells of a lurking circular dependency or something similar | 19:42 |
| bigjools | gary_poster: did you figure it out yet? looking inside the file makes it obvious :) | 19:42 |
| gary_poster | bigjools: no, I was moving on, plenty of other stuff to do ;-) should I look? | 19:43 |
| salgado | bac, agreed, and we'll probably see it often if we're correct | 19:43 |
| bigjools | gary_poster: heh, no, I can tell you it's Code | 19:43 |
| gary_poster | bigjools: oh ok thank you :-) | 19:43 |
| bigjools | gary_poster: sourcepackagerelease-body-summary can be removed though | 19:46 |
| * gary_poster tries to figure out what bigjools means. it's not on conversions.html; not in sources-list.pt ... | 19:48 | |
| bigjools | gary_poster: sorry, sourcepackagerelease-body-summary.pt | 19:48 |
| gary_poster | bigjools: oh ok. yeah, not registered in any zcml...and not in pagetitles.pt. So do you want me to just remove that template in one of my branches? Happy to do it | 19:51 |
| bigjools | gary_poster: removing dead files always gets rs=me :) | 19:52 |
| gary_poster | I meant pagetitles.py | 19:52 |
| gary_poster | ;-) ok cool | 19:52 |
| Tonny | Hi | 19:54 |
| Tonny | launchpad can install on a Debian Lenny ? | 19:54 |
| Tonny | I suggested to use multiverse | 19:55 |
| Tonny | Please enable the 'universe' component in /etc/apt/source.list' | 19:55 |
| gary_poster | flacoste or EdwinGrubbs: I've gone through the "change or remove" files on https://dev.launchpad.net/VersionThreeDotO/UI/TemplateToDoList that are in my section of the page. notification-test.pt was a pretty standard change, no problem. | 20:05 |
| gary_poster | launchpad-addform and launchpad-editform are registered in widgets.zcml but are only used as macros. The rest of them are not registered at all. | 20:05 |
| gary_poster | Can I rm all the files that are not registered in zcml (the ones I don't mention specifically here)? | 20:05 |
| gary_poster | If I don't rm them, I'll just make the simplest mechanical change to the html tag and move on I guess. I'm doing that now. | 20:08 |
| rockstar | salgado, when I merge your branch, my titles end up something like "FAQs for $displayname : Questions for Mozilla Firefox : Mozilla Firefox" Is that right? | 20:15 |
| gary_poster | rockstar or abentley: l/c/l/templates/sources-list.pt is something from code (./lib/lp/code/browser/configure.zcml). Could I ask one of you to look at it and do the conversion (and maybe move it to lp/code/templates if that makes sense)? | 20:15 |
| salgado | rockstar, probably not | 20:16 |
| rockstar | gary_poster, I'm pretty swamped right now, but abentley might be able to do it. | 20:16 |
| gary_poster | ok thanks rockstar | 20:16 |
| rockstar | salgado, do you have any suggestions for what I should do about it? | 20:16 |
| salgado | rockstar, not really, but I'll come up with something | 20:18 |
| rockstar | salgado, looking at it through the browser has the same issue. | 20:19 |
| gary_poster | salgado: I asked something of flacoste and EdwinGrubbs above. Do you think I could rm the files I talk about? (template-form.pt, message-add.pt, teamplate-page.pt, template-addform.pt, template-editform.pt, default-ediform.pt, all in l/c/l/templates) | 20:19 |
| gary_poster | as I said above, they are not registered in zcml | 20:19 |
| rockstar | salgado, when you say "I'll come up with something" does that mean "land what you have, and I'll make a fix"? | 20:20 |
| EdwinGrubbs | gary_poster: sorry, I don't know. | 20:20 |
| gary_poster | EdwinGrubbs: np, thank you for looking | 20:20 |
| salgado | rockstar, if your branch is ready, yes. otherwise you can wait for the fix | 20:22 |
| salgado | gary_poster, looking | 20:22 |
| gary_poster | salgado: thank you very much | 20:22 |
| rockstar | salgado, actually, I think this might be my problem. Hold on. | 20:22 |
| salgado | rockstar, it's not. the problem is that the code that generates titles doesn't know how to deal with zope.i18nmessageid.message.Message | 20:23 |
| rockstar | salgado, ah, it's a replacement problem. | 20:23 |
| rockstar | salgado, ah, okay. I'll get my stuff reviewed and you can land your fix when you need. | 20:23 |
| salgado | rockstar, do the breadcrumbs have the same problem on those pages? | 20:25 |
| gary_poster | deryck: hwdb-fingerprint-submissions.pt is not registered in zcml anywhere. Does that mean I can rm it? Or would you prefer I just do the mechanical changes and move on, because of time? | 20:25 |
| rockstar | salgado, nope, doesn't look like it. | 20:26 |
| deryck | gary_poster, yeah, I don't think it can be removed. It | 20:26 |
| deryck | gary_poster, It's used in a view class somewhere, if memory of greping holds. | 20:26 |
| deryck | gary_poster, this is why I was leaving it to abel because I couldn't really work out how to verify the changes looked ok. | 20:26 |
| deryck | gary_poster, so change the macro so it qualifies, commit, and move on, I guess. :) | 20:27 |
| salgado | gary_poster, yes, please kill them all! | 20:27 |
| gary_poster | deryck: ah, gotcha. FWIW, "find . -name '*.py' -exec grep -Hn 'person-hwdb-submissions.pt' {} \;" gives no results. But I'll make the mechanical changes. Thank you! | 20:27 |
| gary_poster | salgado: woohoo! thank you! | 20:28 |
| salgado | gary_poster, no, thank you! | 20:28 |
| gary_poster | :-) | 20:28 |
| deryck | gary_poster, ok, I could be recalling incorrectly then. I guess we could kill it and see if ec2test complains. | 20:28 |
| gary_poster | deryck: ah, deryck, I was grepping for the wrong string. It is actually used here: ./lib/canonical/launchpad/browser/hwdb.py:260 . I'll make the mechanical change as you suggested and move on. Thanks again. | 20:31 |
| deryck | gary_poster, np | 20:31 |
| deryck | gary_poster, thank you for doing those templates! | 20:31 |
| gary_poster | :-) np | 20:31 |
| deryck | kees, I'm taking a look at your branch now. | 20:35 |
| bac | sinzui: the link to +mugshots has been removed from the team index page. was that intentional? | 20:47 |
| sinzui | no | 20:47 |
| sinzui | I believe it should be in the same portlet that has the members link. Is it conditional by accident? | 20:47 |
| * bac looking | 20:48 | |
| bac | sinzui: would that be TeamOverviewMenu? | 20:50 |
| sinzui | It is missing from the menu? | 20:51 |
| bac | sinzui: it is in TeamOverviewMenu with launchpad.View condiotional | 20:51 |
| sinzui | bac: it is provides by TeamMenuMixin | 20:52 |
| sinzui | bac: I bet that guard is on the link so that we do not get timeouts from bots | 20:53 |
| bac | sinzui: same guard as the +members link | 20:53 |
| bac | sinzui: the 'Show all members' is rendered in person-portlet-memberships.pt. no mention of +mugshots there | 20:54 |
| bac | or is it? | 20:55 |
| sinzui | bac: team-portlet-membership is 1) missing +mugshots and 2) "Show all members" => "All members" | 20:58 |
| sinzui | bac: do you have time to work on this? | 20:58 |
| bac | sinzui: i do | 20:58 |
| bac | sinzui: i don't understand your => comment | 20:59 |
| sinzui | the link in he <h2> is not the correct language | 20:59 |
| bac | sinzui: should it not get it as defined in the link? | 21:00 |
| sinzui | bac: "show" is not to appear in those links. they are verbless | 21:00 |
| bac | sinzui: right. so shouldn't it be fixed in the menu and then used here? | 21:00 |
| sinzui | no | 21:00 |
| sinzui | the menu is correct because the link is used in many plackes. the portlet hack is is an exception that will probably be removed in 4.0 | 21:01 |
| bac | sinzui: http://people.canonical.com/~bac/team-index.png | 21:05 |
| bac | sinzui: i suspect we want those stacked? | 21:06 |
| sinzui | no | 21:06 |
| bac | sinzui: then you like it as shown? | 21:07 |
| sinzui | bac we do not encourage the heading link crack. Use the real link. | 21:07 |
| sinzui | (i) Show member photos | 21:07 |
| sinzui | ^ We commonly show menu in <ul class="horizontal"> | 21:07 |
| sinzui | bac I would put the link above the Recently approved because I think the lists in this portlet are optional | 21:09 |
| bac | sinzui: for both or just mugshots? | 21:09 |
| sinzui | just mugshots. bac: this should look like portlets used on pillars. There is nothing special about this portlet | 21:10 |
| sinzui | The portlet is missing a <h2> now that I look again at the picture. We can guess it is about members | 21:10 |
| sinzui | This wacked | 21:11 |
| sinzui | bac: look at https://edge.launchpad.net/~bac portlets need a <h2> with a .see-all hack in it. There is some information, then links to relataed pages or actions you can take | 21:13 |
| sinzui | bac: this has some good examples too: https://edge.launchpad.net/launchpad-registry | 21:14 |
| sinzui | ^ I think VIew fill history is wrong because the link text makes sense in the case | 21:14 |
| rockstar | sinzui, there is supposed to be a slot to the right of the title for creation date, etc. Does that exist? | 21:25 |
| sinzui | <tal:registering metal:fill-slot="registering"> | 21:26 |
| sinzui | rockstar: I just used it for the first time a moment ago | 21:26 |
| sinzui | It works | 21:26 |
| rockstar | sinzui, great, thanks. | 21:28 |
| bac | sinzui: how's this? http://people.canonical.com/~bac/team-index.png | 21:34 |
| bac | sinzui: i used the icon as defined in the link, not the (i) | 21:34 |
| sinzui | r=me | 21:34 |
| sinzui | bac: you are correct | 21:35 |
| bac | sinzui: i'll land it with my contact team branch | 21:35 |
| sinzui | fab | 21:35 |
| sinzui | EdwinGrubbs: did you ever find the decline a blueprint part of sprint | 21:37 |
| EdwinGrubbs | sinzui: I could not find the url for ISprintSpecification/+decide | 21:38 |
| sinzui | EdwinGrubbs: I add a few specs to a sprint, and now I cannot remove them. I am glad this feature is well hidden | 21:39 |
| EdwinGrubbs | gary_poster: I was going to start to work on sources-list.pt unless there is something else that is more important. | 21:40 |
| gary_poster | EdwinGrubbs: thank that would be great. I'm working on a MP now, which I will send your way, if you are willing. | 21:41 |
| EdwinGrubbs | gary_poster: sure, I can review it | 21:42 |
| gary_poster | thank you | 21:42 |
| sinzui | EdwinGrubbs: Add /<sprint-name> to the end of the spec url (I assume after you have add one or more sprints) eg | 21:46 |
| sinzui | https://blueprints.launchpad.dev/firefox/+spec/canvas/futurista | 21:46 |
| EdwinGrubbs | sinzui: ok, thanks | 21:46 |
| sinzui | I wonder if I should add a link to it from the index | 21:47 |
| kfogel | danilo-afk: you're landing patches as danilon {AT} babaroga, and it's screwing up our community-contributions.py script :-) | 21:51 |
| * kfogel adjusts the script | 21:51 | |
| kees | deryck: cool; let me know if I can help at all | 21:54 |
| deryck | kees, this isn't going to be able to land this cycle, sorry man. There's some zcml weirdness with the permissions, and actually there will be a number of lines failing in the test now. | 22:05 |
| deryck | kees, and I just don't have time to chase it all down today. sorry. | 22:06 |
| kees | deryck: ok, cool. thanks for taking a look | 22:08 |
| === salgado is now known as salgado-afk | ||
| deryck | kees, no problem. I can probably get it next week some time and land it soon as pqm opens the week after. | 22:11 |
| deryck | gotta run. later on, all. | 22:12 |
| lamalex | Hi guys, the "getting the code" part of getting lp is broken | 22:19 |
| lamalex | the file you bzr cat doesn't seem to exist | 22:20 |
| lamalex | or the link format changed | 22:21 |
| jamalta | lamalex: which step are you having an issue with? | 22:31 |
| jamalta | nvm it is an issue | 22:32 |
| lamalex | :) i mean i figured it out | 22:32 |
| jamalta | ahh | 22:32 |
| lamalex | but i figured you guys would like to know about it | 22:33 |
| jamalta | yeah they probably do | 22:33 |
| === matsubara is now known as matsubara-afk | ||
| === abentley1 is now known as abentley | ||
| rockstar | sinzui, around? | 23:09 |
| sinzui | I am | 23:09 |
| rockstar | sinzui, so, I'm moving all the page_titles around, and there's one case that I can't see how it ever worked. | 23:10 |
| rockstar | sinzui, if you go to answers.launchpad.dev and search there, it's trying to take the title from IQuestionSet.displayname which doesn't exist. | 23:10 |
| sinzui | right | 23:10 |
| rockstar | The logic hasn't changed, I just renamed from pageheading to page_title and removed the fallback from pagetitles.py | 23:10 |
| rockstar | sinzui, since I can't see how this ever worked, I don't have many ideas on how to fix it. | 23:11 |
| sinzui | It worked because the template was god. now it is not | 23:11 |
| sinzui | rockstar: does the url have a special view? | 23:12 |
| rockstar | sinzui, no, it's one that's reused for all search. | 23:12 |
| sinzui | hmm | 23:13 |
| rockstar | sinzui, I think I have a fix. | 23:14 |
| rockstar | sinzui, how do I check that a class is of a certain interface? | 23:15 |
| sinzui | IMYInterface.providedBy(self.context) | 23:16 |
| wgrant | lamalex: Is rocketfuel-setup working for you? There's a bug at the moment where unless you're a Canonical employee it will probably not download all the stuff you need. | 23:24 |
| wgrant | lamalex: If you run into that, I have a patch. | 23:24 |
| wgrant | Which I must get merged soon! | 23:24 |
| lamalex | wgrant: i think it's not working | 23:52 |
| lamalex | the script finished running make schemas fails | 23:52 |
| wgrant | lamalex: Run 'rocketfuel-get', and see what it says. | 23:52 |
| lamalex | ... running but .. | 23:52 |
| wgrant | Something about shipit? | 23:52 |
| wgrant | If rocketfuel-get does give you a traceback, try applying http://pastebin.ubuntu.com/273832/. | 23:54 |
| lamalex | wgrant: is this the trace you're expecting? http://paste2.org/p/429284 | 23:57 |
| wgrant | lamalex: Urgh. No. | 23:59 |
| wgrant | That's much worse. | 23:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
