| rockstar | Anyone want to take a really mechanical branch? | 00:22 |
|---|---|---|
| rockstar | sinzui, maybe you're still around? ^^ | 00:22 |
| sinzui | yes | 00:22 |
| rockstar | sinzui, alright, running tests now, will send it your way. | 00:23 |
| sinzui | okay. Thanks | 00:23 |
| rockstar | sinzui, proposal sent. | 00:37 |
| sinzui | I will watch for it | 00:37 |
| sinzui | rockstar: r=me Good to land as it is. | 01:27 |
| wgrant | Any reviewers around for a fix for bug #432832? | 02:05 |
| mup | Bug #432832: update-sourcecode broken for people without access to shipit and c-i-p <Launchpad Foundations:In Progress by wgrant> <https://launchpad.net/bugs/432832> | 02:05 |
| rockstar | wgrant, hi | 02:06 |
| rockstar | wgrant, where's you patch? | 02:07 |
| wgrant | rockstar: Pushing. Give me a moment. | 02:07 |
| wgrant | Slooow push. | 02:14 |
| wgrant | ... and I of course stuffed up the MP. | 02:24 |
| wgrant | rockstar: https://code.edge.launchpad.net/~wgrant/launchpad/bug-432832/+merge/12109 | 02:24 |
| rockstar | wgrant, you know you can just send the bundle, right? | 02:33 |
| wgrant | rockstar: That relies on me having email set up properly. | 02:33 |
| wgrant | I've never actually used bzr-send before. | 02:33 |
| wgrant | I probably should work out how to do it. | 02:33 |
| rockstar | wgrant, if you plan on submitting patches as regularly as you have been, I suggest you learn to. :) | 02:34 |
| rockstar | If there are holes in our documentation, feel free to bug me and I'll fix them. | 02:34 |
| rockstar | wgrant, how have you tested this? | 02:35 |
| wgrant | rockstar: lamalex installed LP with a very similar patch, and I ran rocketfuel-get with it on both existing and new installations. I haven't tested how it goes with shipit and c-i-p available, of course. | 02:39 |
| rockstar | wgrant, how can I test it, since I have both available? | 02:40 |
| wgrant | rockstar: Run 'utilities/update-sourcecode ../../lp-sourcedeps' to verify it works on an existing one. Then maybe uncommit a revision or two from a branch, remove another branch, run it again, and verify that they're all up to date. | 02:42 |
| wgrant | You should not see any errors, since you have access to shipit and c-i-p. | 02:44 |
| rockstar | I never knew about this script. | 02:55 |
| wgrant | rockstar: rf-get, so by extension rf-setup, use it. | 02:56 |
| wgrant | However it was just rewritten. | 02:56 |
| rockstar | wgrant, ah, okay. I eventually wrote my own script because my folder layout was different, and rf-setup/rf-get only supported one installation location. | 02:57 |
| wgrant | rockstar: By overriding the LP_PROJECT_ROOT envvar I'm able to have it working on three different installations. | 02:58 |
| rockstar | wgrant, yeah, it used to not support that. | 02:59 |
| rockstar | Also, AIUI, it still doesn't support separate branches and trees. | 02:59 |
| wgrant | Probably not. | 02:59 |
| wgrant | I don't normally use it either, but that's because it was terribly slow. | 02:59 |
| wgrant | Now it only takes a couple of minutes. | 02:59 |
| wgrant | rockstar: Thanks. Can you land that for me? | 03:02 |
| rockstar | wgrant, yeah. I'll have to figure out how to do that. | 03:02 |
| wgrant | utilities/ec2test.py --headless -s "[r=rockstar][ui=none] fix update-sourcecode in the case that optional branches are inaccessible" lp:~wgrant/launchpad/bug-432832 --email=me@williamgrant.id.au | 03:05 |
| wgrant | Maybe throw a ' (wgrant)' just after the '[ui=none]'. | 03:05 |
| wgrant | Some people do, some people don't. | 03:05 |
| rockstar | Yea, I'm not sure I need to run that through ec2test. | 03:06 |
| wgrant | True. | 03:06 |
| rockstar | I don't see a direct way of doing it with bzr-pqm, so off to ec2 it went. | 03:07 |
| wgrant | OK, thanks. | 03:07 |
| wgrant | I'll leave the big rocketfuel-setup breakage (bug #432830) to somebody more qualified. | 03:08 |
| mup | Bug #432830: rocketfuel-setup does not work <Launchpad Foundations:New> <https://launchpad.net/bugs/432830> | 03:08 |
| rockstar | Man, I currently have your ec2 runs going. My wife is going to think I'm buying crap on Amazon again. | 03:08 |
| rockstar | s/your/four/ | 03:08 |
| wgrant | Heh. | 03:08 |
| rockstar | wgrant, I killed the ec2 instance and figured out how to just pqm submit it. | 03:18 |
| wgrant | rockstar: Great, thanks! | 03:52 |
| rockstar | wgrant, thanks for your patch. | 03:52 |
| bac | henninge: could i trouble you for a trivial review? it's about a four line change. | 12:47 |
| bac | if not i'll rs it | 12:47 |
| henninge | bac: sure, bring it on | 12:48 |
| gary_poster | henninge, btw happy late bday :-) | 12:50 |
| henninge | gary_poster: thank you ;-) | 12:50 |
| bac | henninge: MP sent. waiting for it to show up | 12:54 |
| bac | hi gary_poster. do you know about http://www.sparkcon.com/ ? it sounds fun but i've never been -- all the way in raleigh... | 12:55 |
| gary_poster | bac: lol, no, looks cool! | 12:56 |
| bac | henninge: https://code.edge.launchpad.net/~bac/launchpad/import_error/+merge/12115 | 12:56 |
| * henninge looks | 12:56 | |
| bac | gary_poster: some friends of mine started it a few years ago. it's really grown huge. | 12:56 |
| gary_poster | bac: wow, cool! I wish there were a better "keep track of the actually cool events in the triangle" feed. The ones I've seen don't include the stuff I want to see. ;-) until the most exciting thing I knew about this weekend was a greek festival. ;-) | 12:59 |
| gary_poster | until now I mean | 12:59 |
| bac | gary_poster: yeah, i'm thinking i may have to break my 'no raleigh' rule today and wander down there | 13:00 |
| henninge | bac: are you keeping the commented-out import for documentation purposes? Is that common practice so that people know what it means? | 13:00 |
| bac | henninge: no, it was an oversight. i'll remove it | 13:02 |
| henninge | bac: ok, r=me then ;-) | 13:02 |
| bac | henninge: danke | 13:02 |
| henninge | bitte! | 13:02 |
| === henninge is now known as henninge-afk | ||
| bac | hi abentley | 14:25 |
| abentley | bac: Happily, this is only a problem with the test, and yes, I caused it. | 14:57 |
| bac | abentley: great. if you can get a fix in rs=bac it would be great! | 14:57 |
| abentley | bac: Will do. | 14:59 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!