gary_posterbac or anyone else around for an r or rs to disable the spurious test failure?01:30
gary_posterflacoste, jml, mwhudson ^^^ ?01:31
gary_posterjfdi-ing it...01:33
jmlgary_poster, I can do a post-hoc review01:34
gary_posterjml thank you.  01:34
gary_posterjml: http://pastebin.ubuntu.com/274444/ and https://bugs.edge.launchpad.net/launchpad-registry/+bug/43332301:35
mupBug #433323: test_proponent_is_stored causes a spurious test failure <spurious-test-failure> <Launchpad Registry:New> <https://launchpad.net/bugs/433323>01:35
jmlgary_poster, changing the test name to disabled_test_foo is more common, I think.01:37
jmlbut no big deal01:37
gary_posterjml: oh, ok.  I can change it--you caught me just as I was signing my gpg key :-)01:38
jmlgary_poster, that'd be good, thanks.01:38
jmlmakes for easier greppage01:38
jmlgary_poster, also, thanks for demonstrating that it is spurious (rather than actually broken code) on the bug report.01:38
gary_postercool.  (bah, I don't have privs to see https://launchpad.canonical.com/PolicyandProcess/XXXPolicy which is the current link from https://wiki.canonical.com/Launchpad/PolicyandProcess)01:39
jmlalso, man, that test does way too much01:40
jmland shouldn't be doing cleanup after assertions that way01:40
jmlbut not relevant to this patch.01:40
jmlgary_poster, there's a public XXX policy on the real wiki :)01:40
jmlgary_poster, https://dev.launchpad.net/XXXPolicy01:41
jmlgary_poster, See also https://dev.launchpad.net/SpuriousFailures01:41
gary_posterjml: a thing of beauty, thanks.  I tend to go to https://wiki.canonical.com/Launchpad/PolicyandProcess still.  I updated with those.  Would be nice if there were an dev.launchpad.net equivalent--or is there?  /me looks01:44
gary_posteramusingly, https://dev.launchpad.net/PolicyAndProcess/ReleaseManagerRotation , but not the parent01:45
jmlgary_poster, there's https://dev.launchpad.net/StyleGuides01:45
gary_posterhm, but spurious test failure policy does not fit easily under the title of "style guide"...01:46
gary_posterjml: new diff (entire, not incremental) is http://pastebin.ubuntu.com/274445/ .  r=you?01:48
gary_posterputting an rs=barry01:51
gary_posterthank you jml!  talk to you later01:53
jmlgary_poster, np.01:54
jmlgary_poster, thanks for patching it.01:54
bacgary_poster: thanks02:16
wgrantAnybody have time to review a tiny tiny fix? https://code.edge.launchpad.net/~wgrant/launchpad/bug-433385/+merge/1213411:25
gmbwgrant: I'll take a look in a few minutes.11:50
wgrantgmb: Thanks muchly.11:50
gmbwgrant: Urgh... removeSecurityProxy(). I'm not happy about that, but the alternative is to write an "inEmailAddress(str)" method for IEmailAddress and that seems like an awful lot of work for this little change.12:01
gmbwgrant: r=me, though... it's pointless going round the houses on this one.12:02
gmbwgrant: Want me to ec2 and land that for you? Should make it in before PQM closes for 3.0 unless a test breaks.12:02
wgrantgmb: rSP is already used in that view for a similar purpose, so I thought it should be OK.12:03
wgrantgmb: Thanks. Please do.12:03
gmbwgrant: Ah, right. Fair enough then. I didn't look too hard at the rest of the view :)12:03
gmbwgrant: I'll fire it off now.12:03
gmbwgrant: Running. I'll let you know if it breaks.12:15
wgrantgmb: Thanks.12:15

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!