[01:30] <gary_poster> bac or anyone else around for an r or rs to disable the spurious test failure?
[01:31] <gary_poster> flacoste, jml, mwhudson ^^^ ?
[01:33] <gary_poster> jfdi-ing it...
[01:34] <jml> gary_poster, I can do a post-hoc review
[01:34] <gary_poster> jml thank you.  
[01:35] <gary_poster> jml: http://pastebin.ubuntu.com/274444/ and https://bugs.edge.launchpad.net/launchpad-registry/+bug/433323
[01:35] <mup> Bug #433323: test_proponent_is_stored causes a spurious test failure <spurious-test-failure> <Launchpad Registry:New> <https://launchpad.net/bugs/433323>
[01:37] <jml> gary_poster, changing the test name to disabled_test_foo is more common, I think.
[01:37] <jml> but no big deal
[01:38] <gary_poster> jml: oh, ok.  I can change it--you caught me just as I was signing my gpg key :-)
[01:38] <jml> gary_poster, that'd be good, thanks.
[01:38] <jml> makes for easier greppage
[01:38] <jml> gary_poster, also, thanks for demonstrating that it is spurious (rather than actually broken code) on the bug report.
[01:39] <gary_poster> cool.  (bah, I don't have privs to see https://launchpad.canonical.com/PolicyandProcess/XXXPolicy which is the current link from https://wiki.canonical.com/Launchpad/PolicyandProcess)
[01:40] <jml> also, man, that test does way too much
[01:40] <jml> and shouldn't be doing cleanup after assertions that way
[01:40] <jml> but not relevant to this patch.
[01:40] <jml> gary_poster, there's a public XXX policy on the real wiki :)
[01:41] <jml> gary_poster, https://dev.launchpad.net/XXXPolicy
[01:41] <jml> gary_poster, See also https://dev.launchpad.net/SpuriousFailures
[01:44] <gary_poster> jml: a thing of beauty, thanks.  I tend to go to https://wiki.canonical.com/Launchpad/PolicyandProcess still.  I updated with those.  Would be nice if there were an dev.launchpad.net equivalent--or is there?  /me looks
[01:44] <gary_poster> nope
[01:45] <gary_poster> amusingly, https://dev.launchpad.net/PolicyAndProcess/ReleaseManagerRotation , but not the parent
[01:45] <jml> gary_poster, there's https://dev.launchpad.net/StyleGuides
[01:46] <gary_poster> hm, but spurious test failure policy does not fit easily under the title of "style guide"...
[01:48] <gary_poster> jml: new diff (entire, not incremental) is http://pastebin.ubuntu.com/274445/ .  r=you?
[01:51] <gary_poster> putting an rs=barry
[01:53] <gary_poster> thank you jml!  talk to you later
[01:54] <jml> gary_poster, np.
[01:54] <jml> gary_poster, thanks for patching it.
[02:16] <bac> gary_poster: thanks
[11:25] <wgrant> Anybody have time to review a tiny tiny fix? https://code.edge.launchpad.net/~wgrant/launchpad/bug-433385/+merge/12134
[11:50] <gmb> wgrant: I'll take a look in a few minutes.
[11:50] <wgrant> gmb: Thanks muchly.
[12:01] <gmb> wgrant: Urgh... removeSecurityProxy(). I'm not happy about that, but the alternative is to write an "inEmailAddress(str)" method for IEmailAddress and that seems like an awful lot of work for this little change.
[12:02] <gmb> wgrant: r=me, though... it's pointless going round the houses on this one.
[12:02] <gmb> wgrant: Want me to ec2 and land that for you? Should make it in before PQM closes for 3.0 unless a test breaks.
[12:03] <wgrant> gmb: rSP is already used in that view for a similar purpose, so I thought it should be OK.
[12:03] <wgrant> gmb: Thanks. Please do.
[12:03] <gmb> wgrant: Ah, right. Fair enough then. I didn't look too hard at the rest of the view :)
[12:03] <gmb> wgrant: I'll fire it off now.
[12:15] <gmb> wgrant: Running. I'll let you know if it breaks.
[12:15] <wgrant> gmb: Thanks.