[10:01] <intellectronica> hey henninge
[10:01] <intellectronica> wie leuft's?
[10:02] <henninge> Hallo intellectronica
[10:02] <henninge> es ist ruhig
[10:02] <henninge> ;)
[10:02] <intellectronica> can i ask you to review a very small branch for me? a fix for the bugs page redesign which i hope to get r-c for?
[10:04] <intellectronica> henninge: ^^^
[10:04] <henninge> sure
[10:05] <intellectronica> henninge: https://code.edge.launchpad.net/~intellectronica/launchpad/hot-bugs-summary/+merge/12150
[10:06] <intellectronica> henninge: http://pastebin.ubuntu.com/275130/ if you don't want to wait for lp to generate the diff
[10:10] <henninge> intellectronica: line 13 of the diff: s/display/displayed/
[10:10] <henninge> intellectronica: other than that: r=me ;-)
[10:12] <intellectronica> henninge: thanks!
[10:56] <wgrant> Huh. Does the new project bugs page show the bugtask ID?
[10:56] <wgrant> Er, wrong chan.
[11:25] <henninge> intellectronica: I have a branch, too ;-)
[11:25] <henninge> it's a bit longer than yours, though...
[11:27] <henninge> intellectronica: would you please be so kind? :)
[11:27] <henninge> https://code.edge.launchpad.net/~henninge/launchpad/bug-433824/+merge/12152
[11:27] <intellectronica> henninge: you don't scare me
[11:27] <henninge> lol
[11:29] <intellectronica> henninge: what's with the extra linebreak in the docstring of initialize?
[11:29] <henninge> just saw that myself ...
[11:29] <henninge> intellectronica: I had meant to write a bit more in the docstring ...
[11:29] <henninge> forgot.
[11:31] <intellectronica> henninge: so where does self.featured_projects come from, now that you've removed it?
[11:31] <intellectronica> is it in the superclass?
[11:32] <henninge> intellectronica: no, it's initialized in initialize
[11:32] <intellectronica> ah right, i can see now
[11:33] <intellectronica> henninge: space between operator and operands
[11:33] <henninge> right
[11:33] <intellectronica> so you've added assume_date just for testing?
[11:34] <cprov> henninge: hi, can you review a trivial UI fix (RC) ?
[11:34] <henninge> cprov: yes, sure!
[11:34] <henninge> trivial is always good ...
[11:34] <cprov> henninge: https://code.edge.launchpad.net/~cprov/launchpad/bug-432979-copy-archives/+merge/12136
[11:34] <cprov> henninge: thank you.
[11:35] <intellectronica> henninge: could you not avoid that by creating data on the fly using the object factory, instead of relying on sample data?
[11:36] <henninge> intellectronica: the view uses time.gmtime() to select a project from the list. So the test depends on what day it is run.
[11:37] <henninge> intellectronica: *would depend*
[11:38] <intellectronica> right, but if you generated the data in the test, then that wouldn't matter, no?
[11:38] <intellectronica> henninge: ^^^
[11:39] <henninge> intellectronica: I don't see the difference. I am not checking and date in the test data.
[11:39] <henninge> s/and/any/
[11:40] <intellectronica> henninge: right, but you've added quite a lot of code just for testing. i'm trying to understand if we could do without these additions
[11:40] <henninge> intellectronica: the only way I see it could be done is doing the same selection in the test as the view does and compare the output programmatically.
[11:41] <henninge> intellectronica: but that would mean parsing the output of the page test into a list ...
[11:41] <henninge> intellectronica: "a lot of code"?
[11:41] <henninge> intellectronica: I see three lines ...
[11:42] <intellectronica> yes, but if you could do without them, would it not be preferable?
[11:42] <intellectronica> b.t.w if you leave it there, at least add a comment explaining that it's just for testing
[11:43] <henninge> I just don't see how without making the test much more complicated and not readable.
[11:43] <henninge> It could be more easily tested in  unit test for the view, I guess.
[11:44] <henninge> But that would still make the current page test meaningless.
[11:44] <henninge> at least for the list.
[11:44] <intellectronica> henninge: tbh i think it would be better to even just remove that test
[11:44] <henninge> ok ...
[11:45] <henninge> intellectronica: there should still be a test for the admin interface, though...
[11:46] <intellectronica> henninge: i mean just the part that uses assume_date
[11:46] <henninge> intellectronica: btw, having the assume_date parameter might also serve other purposes ...
[11:47] <intellectronica> yeah, what purposes?
[11:47] <intellectronica> time travel? :)
[11:47] <henninge> henninge: kind of
[11:47] <henninge> intellectronica: 2
[11:47] <henninge> intellectronica: ^
[11:47] <henninge> me and my keyboard ...
[11:48] <henninge> intellectronica: Well, if you ever want to demonstrate or check how a certain project looks when it is featured, or show it to the maintainers etc...
[11:48] <henninge> length of summary, logo ...
[11:49] <allenap> intellectronica: Fancy reviewing a fix for the iharness breakage? https://code.edge.launchpad.net/~allenap/launchpad/fix-iharness-bug-432665/+merge/12154
[11:49] <intellectronica> henninge: it would be better to just be able to pass the project, then, instead of the date
[11:49] <intellectronica> allenap: sure. but i can't test it - i don't use ipython
[11:51] <intellectronica> henninge: so, basically, i think we're in disagreement :) i really don't want that parameter and you really don't want to change it
[11:51] <henninge> intellectronica: only because I don't see a way around it ...
[11:51] <henninge> but yes, agree to differ ...
[11:52] <henninge> intellectronica: is passing the project name a compromise, then?
[11:52] <intellectronica> henninge: just don't do the test. i rather it landed without that particular test than with that specialized code for pretending that the date is different in a particular context
[11:53] <henninge> intellectronica: Could I check in the view if it is running in a test?
[11:53] <intellectronica> henninge: i don't understand
[11:53] <allenap> intellectronica: Okay, I'll ask someone who does. Thanks anyway.
[11:54] <henninge> intellectronica: Those were two suggestions, not related ... ;-)
[11:54] <intellectronica> allenap: i can still review it, just wanted to point that i won't know what to do with it
[11:54] <henninge> intellectronica: for the latter I think of somthing like:
[11:55] <henninge> if running_in_test: Always pick first project.
[11:55] <allenap> intellectronica: Heh, actually it doesn't matter about using it or not. The changes are to buildout.cfg, so you need to sanity check those.
[11:55] <henninge> else: pick by date.
[11:55] <intellectronica> allenap: r=me
[11:55] <allenap> intellectronica: Thanks :)
[11:56] <intellectronica> henninge: i already like that better, but how will you know if you're running in a test?
[11:56] <henninge> intellectronica: yes, that's what I am wondering, too. What's the host name in the test, is it .dev, too?
[11:57]  * henninge tries
[11:57] <henninge> oh, it is. I just remembered ...
[11:58] <intellectronica> henninge: you know what you should do? move the code that selects the project into a method, and monkey-patch that method in your test
[12:00] <henninge> intellectronica: oh, is that possible from a page test? I'd have to patch the class, not the instance, I guess. But it could work.
[12:00] <intellectronica> henninge: why not from a pagetests? and why do you have to patch the class and not the instance?
[12:01] <henninge> intellectronica: how do I get the view instance, then?
[12:01] <intellectronica> ah good point
[12:01] <intellectronica> that would work if you created your own view
[12:01] <intellectronica> but not in a pagetest
[12:02] <intellectronica> still, patching the class might work
[12:13] <cprov> henninge: any problem with my review ? 
[12:15] <henninge_> intellectronica: It Works. ;)
[12:15] <intellectronica> yay!
[12:21] <henninge_> intellectronica: http://paste.ubuntu.com/275184/
[12:22] <intellectronica> henninge_: that's great, just add a docstring to that method (explaining that it's there so that you can override it) and r=me
[12:23] <henninge> intellectronica: thanks a lot! Great idea, btw ;)
[12:23] <intellectronica> i'm like that, good with monkeys
[12:25] <henninge> ;-)
[12:26]  * henninge lunches now
[12:47] <noodles775> salgado: if you've a minute, can I get you to take a look at the patch that I've attached to bug 433852?
[12:48] <mup> Bug #433852: Breadcrumbs display for IHasMajorHeading views <Launchpad Foundations:In Progress by michael.nelson> <https://launchpad.net/bugs/433852>
[12:49] <salgado> noodles775, sure, checking now
[12:50] <noodles775> salgado: thanks!
[12:52] <salgado> noodles775, what is the definition of a root context?
[12:53] <noodles775> salgado: As far as I understand, pillars + a few things - I'm not sure why sprints are one of them?
[12:53]  * noodles775 looks for an email from sinzui
[12:54] <noodles775> salgado: I think I've written something incorrect in the description of that bug...
[12:55] <noodles775> salgado: so the issue is nothing to do with IRootContext, but just the fact that the breadcrumbs display when IMajorHeadingView is provided.
[12:56] <salgado> noodles775, and is that against the rules?
[12:57] <salgado> or is it something we didn't account for, which is now causing some pages to look ugly?
[12:59] <noodles775> salgado: yes, barry thought so... (see the first section of the rules)
[12:59] <noodles775> salgado: and I just checked - ISprint does indeed inherit IRootContext.
[12:59] <salgado> I see that ISprint inherits from IRootContext, but according to the docstring of IRootContext, ISprint should not be one
[13:00] <noodles775> salgado: hrm - I'm not sure why/who decided that, but it seems to make sense of the application tabs at https://edge.launchpad.net/sprints/uds-l
[13:01] <noodles775> ie, being able to switch between blueprints/overview.
[13:01] <salgado> I don't see what you mean, sorry
[13:02] <noodles775> salgado: if you go to that url, you can use the application buttons to switch between the 'blueprints' app (for that sprint) and the 'overview' of the sprint
[13:05] <salgado> noodles775, right, but is that because sprints provide IRootContext?
[13:07] <noodles775> salgado: I'm assuming it's *why* sprints provide IRootContext - but I'm far from certain. Perhaps sinzui can clarify later.
[13:08] <salgado> noodles775, a distro source package, for example, does not provide IRootContext but still has (some of) the application tabs
[13:09] <noodles775> salgado: yeah, you're right 
[13:09] <salgado> I think we may want sprints to be IRootContexts, but currently they aren't
[13:10] <salgado> maybe BjornT knows more about this.  BjornT?
[13:10] <salgado> do you know why sprints provide IRootContext?
[13:10] <noodles775> Yep, good idea.
[13:18] <BjornT> salgado: i would guess because sprints aren't contained in anything
[13:19] <BjornT> salgado: Product also implements IRootContext. that interface seems to be used to determine which headings and icons to display in the top of the page, but i'm not sure exactly what it's useful for
[13:19] <noodles775> sinzui: Hi, sorry to jump on you like this, but from memory you've thought about the IRootContext for things like sprints. If you've time, can you take a look at bug 433852?
[13:19] <mup> Bug #433852: Breadcrumbs display for IHasMajorHeading views <Launchpad Foundations:In Progress by michael.nelson> <https://launchpad.net/bugs/433852>
[13:20] <noodles775> sinzui: salgado and I were unsure if ISprint is really meant to provide IRootContext (it inherits from it but isn't mentioned in the def of IRootContext).
[13:21] <salgado> and neither is it served off of the root, as IRootContexts should
[13:21] <sinzui> noodles775: I think the issue pertains to now verses future.
[13:22] <sinzui> noodles775: sprints are always shown under sprints, but they do have icons and they are independent of pillars and people. So I think they should not have breadcrumbs. savvy users who read the url know that the sprint is beneath /sprints
[13:24] <sinzui> salgado: noodles775: sprints are unique also in that in we sould be making a breadcrumb to a collection, not to a pillar/person...that seems extraordinary
[13:24]  * sinzui back to sprint
[13:24] <noodles775> ;), thanks.
[13:43] <allenap> intellectronica: Fancy reviewing a vocab picker performance thing? https://code.edge.launchpad.net/~allenap/launchpad/bug-index-performance-bug-430288-vocab-picker/+merge/12156
[13:45] <intellectronica> allenap: yes!
[13:46] <intellectronica> allenap: test?
[13:47] <allenap> intellectronica: There isn't one so far, afaik.
[13:47] <intellectronica> oh well, we just have to test it will manually
[13:49] <intellectronica> allenap: and how is var picker isolated? is it simply enclosed in the use body?
[13:49] <allenap> intellectronica: Yep, which should be fine even if we start sharing Y instances.
[13:50] <intellectronica> cool
[13:50] <intellectronica> there's a lot that can be done to improve this. why are we repeating all that javascript code inlined in a template?!
[13:50] <intellectronica> but as a performance improvement, this is fantastic. r=me
[13:51] <intellectronica> allenap: ^^^
[13:51] <allenap> intellectronica: Yep. I guess this plumbing code seems better to not be in a library.
[13:51] <allenap> intellectronica: Thanks :)
[13:52] <noodles775> intellectronica: I've got an incremental to a branch that barry had approved, but I've just realised that he might be sprinting (is the registry team sprinting this week?). If so, do you mind looking at it for me?
[13:52] <intellectronica> noodles775: sure
[13:52] <noodles775> intellectronica: thanks - it's the blueprint conversion at: https://code.launchpad.net/~michael.nelson/launchpad/sprint-index-and-attend-3.0/+merge/12044
[13:55] <intellectronica> noodles775: looks good to me
[13:56] <noodles775> intellectronica: great - thanks. Now who's available to approve rc's?
[13:58] <intellectronica> noodles775: i guess francis will be around any minute now
[14:00] <noodles775> flacoste: Hi! When you're available can you pls check the above MP (converts sprint-index + attend to 3.0) for RC? It's got a fix for a heading rule bug - which I'd ideally like barry to check, but i'm not sure if he'll be around.
[14:05] <flacoste> morning noodles775
[14:06] <noodles775> Hi :)
[14:10] <flacoste> noodles775: you should discuss this with bac i think ;-)
[14:11] <flacoste> noodles775: but i agree that remaining 3.0 template conversion are r-c material
[14:12] <noodles775> flacoste: great! bac - can you take a look at the above MP, particularly the last incremental (I was keen for barry to check it, but am not sure if he'll be around - flacoste thinks you might also be a good person to check?)
[14:12] <flacoste> noodles775: hmm, did you want me to review the thing, or approve the r-c aspect of it?
[14:13] <flacoste> noodles775: bac is release manager this week, so primary person to contact for r-c
[14:13] <noodles775> flacoste: it's already reviewed, I was just keen for r-c.
[14:13] <noodles775> flacoste: oh, sorry!
[14:15] <bac> noodles775: please add me as a reviewer with 'release-critical' as the review type
[14:17] <noodles775> bac: Thanks! Done.
[14:30] <henninge> intellectronica: can you please approve my MP from before lunch? I added the incremental diff.
[14:33] <henninge> intellectronica: https://code.edge.launchpad.net/~henninge/launchpad/bug-433824/+merge/12152
[14:34] <intellectronica> henninge: done
[14:34] <henninge> cheers
[14:36] <henninge> intellectronica: sorry, but you need to go to your reviewer line on that page to approve it ... ;-)
[14:37] <henninge> intellectronica: I guess you are usually using the email interface, right? ;-)
[14:40] <intellectronica> henninge: there you go
[14:40] <intellectronica> and no, i rarely use the email interface
[14:41] <henninge> intellectronica: Thank you! ;) Now bac will have it easier ... ;)
[14:45] <henninge> cprov: you realize that for an RC you will have to merge into db-devel, don't you?
[14:46] <henninge> bac: is that still correct? ^
[14:46] <cprov> henninge: yes, Sunday branches ... sorry 
[14:47] <cprov> henninge: I will re-base it.
[14:47] <bac> henninge: according to https://dev.launchpad.net/PolicyAndProcess/ReleaseManagerRotation we only are required to land directly on db-devel on the last day before the rollout
[14:48] <henninge> cprov: ^
[14:49] <intellectronica> henninge: devel gets merged regularly into db-devel, so unles it's very late in the game, it should be fine to land in devel
[14:49] <cprov> okay, that's better, thx guys
[14:50] <henninge> intellectronica: I was just repeating from memory. I didn't know if that stops when pqm closes.
[14:50] <henninge> that=stable->db-devel updates
[14:52] <henninge> cprov: have you tried simply adding the tal:condition to the 'metal:ppa-upload-hint' tag?
[14:52] <henninge> cprov: I am not sure if that works but would be less noise.
[14:54] <cprov> henninge: I can try, one sec
[14:59] <cprov> henninge: <metal:... tal:condition=...> doesn't work, pitty.
[14:59] <henninge> cprov: ok, thanks for trying.
[15:00] <henninge> cprov: r=me
[15:06] <bac> barry: when you have a moment could you do a follow-up on https://code.edge.launchpad.net/~michael.nelson/launchpad/sprint-index-and-attend-3.0/+merge/12044
[15:07] <barry> bac:  sure
[15:09] <cprov> henninge: thank you.
[15:16] <bac> henninge, intellectronica, abentley: please do not mark any MPs that are RC candidates as 'approved'.  leave them in the 'Needs Review' state.
[15:17] <abentley> bac: Okay.
[15:17] <henninge> bac: understood
[15:17] <abentley> bac: Will they have separate RC review requests for flacoste?
[15:18] <henninge> abentley: bac is doing the rc's
[15:18] <bac> abentley: i am doing release-critical for this release.  flacoste only as my backup
[15:18] <henninge> bac: He was scared to hear the answer ... ;-)
[15:18] <bac> :)
[15:18] <intellectronica> bac: ok
[15:28] <bac> henninge: rc=bac.  as i note in the MP, please submit to devel.
[15:29] <henninge> bac: yes, thank you
[15:29] <noodles775> bac: did you get a chance to look at my sprint conversion RC? (sorry, had connection issues earlier)
[15:29] <bac> henninge: please add to https://dev.launchpad.net/CurrentRolloutBlockers also
[15:33] <bac> cprov: approved
[15:34] <bac> cprov: please add an entry under 'in progress' on CurrentRolloutBlockers
[15:34] <cprov> bac: ok
[15:35] <bac> noodles775: is there a bug open for your work on sprint-index and sprint-attend?
[15:35] <noodles775> bac: no - I didn't create one - but can do so now.
[15:36] <bac> noodles775: please.  thanks.
[15:43] <noodles775> bac: bug 434038
[15:43] <mup> Bug #434038: convert sprint-index and sprint-attend to 3.0 <Launchpad Blueprints:In Progress by michael.nelson> <https://launchpad.net/bugs/434038>
[15:43] <cprov> bac: thanks for the RC, playing on ec2
[15:43] <bac> cprov: cool
[15:56] <intellectronica> henninge, abentley: if it's cool with you guys i'd like to take myself off for today. i have a phone call and then only a bit more time left to work
[15:56] <abentley> intellectronica: okay by me.
[15:57] <henninge> intellectronica: I can't believe that you are leaving us alone out here with *that* long a queue!
[15:57] <henninge> ... ;-)
[15:57] <henninge> intellectronica: sure, enjoy the evening ;)
[15:57] <intellectronica> cheers
[15:58]  * henninge notices that there actually is an entry in the queue ...
[16:00] <henninge> ok, I give up....
[16:00] <henninge> How do I land a release-critical branch?
[16:00] <abentley> noodles775: What merge proposal do you want reviewed?
[16:01] <noodles775> abentley: sorry - I was waiting for the mp to arrive:
[16:01] <noodles775> https://code.launchpad.net/~michael.nelson/launchpad/434000-copy-archive-ui/+merge/12164
[16:01] <abentley> henninge: I believe you need to put rc=kiko/flacoste in the message.
[16:02] <henninge> The commit_re does not mention that, though ...
[16:02] <henninge> [(?is)^\\s*(:?\\[testfix\\])?\\[(?:release-critical|rs?=[^\\]]+)\\]\\[ui=(?:.+)\\]]
[16:03] <abentley> henninge: Okay, it's release-critical, not rc.  Been a while.
[16:03] <henninge> abentley: but I tried that ...
[16:05] <abentley> henninge: It looks like the release-critical in that regex doesn't accept an =
[16:05] <henninge> abentley: I tried these: http://paste.ubuntu.com/275316/
[16:06] <henninge> abentley: isn't that "release-critical OR rs" followed by a "="?
[16:07] <henninge> flacoste: Help! ;-)
[16:07] <abentley> henninge: Yes, that's how it looks.  Though I can't actually get python to compile the re.
[16:07] <henninge> bac: any clues?
[16:07] <flacoste> henninge: what is your commit messag?
[16:07] <henninge> flacoste: tried these http://paste.ubuntu.com/275316/
[16:08]  * bac looks
[16:08] <bac> henninge: what did the error message say
[16:08] <bac> henninge: ah, i see it up there
[16:09] <henninge> bac: that it did not match the commit_re
[16:09]  * bac remembers we had this problem before...
[16:10] <bac> does it think we're in testfix?
[16:11] <BjornT> henninge: this should work: [r=intellectronica][ui=none][release-critical=bac][bug=433824] Implemented foo.
[16:11] <henninge> BjornT: thanks, I'll try that ...
[16:12] <abentley> noodles775: Is your change valid yui Grid?
[16:14] <noodles775> abentley: yui-u (the unit) is only re-positioned if it's inside a grid. So without the yui-gc, it's just a div with a class.
[16:14] <abentley> noodles775: And we know that it's not itself int a yui-u?
[16:14] <abentley> s/int a/in a/
[16:15] <henninge> BjornT: looking good ...
[16:19] <noodles775> abentley: yep - the yui-gc div there is a child of the main slot.
[16:22] <abentley> r=me
[16:22] <abentley> noodles775: Are you wanting an RC for this?
[16:22] <noodles775> abentley: yes.
[16:23] <abentley> Okay, I'll leave it at "needs review", and you can request an RC.
[16:23] <noodles775> Thanks abentley... I'll do that now, so you can mark it approved if you like.
[16:24] <abentley> noodles775: The person who gives the RC can change the status, or you can, after you get the RC.
[16:24] <noodles775> ah, gotcha. Thanks.
[16:25] <abentley> henninge: Are you the "I" in "I am happily reviewing blueprint conversions"?
[16:25] <henninge> abentley: yes, that was first thing this morning ... ;-)
[16:26] <henninge> abentley: but since bac is putting them on the rollout blockers list now, that phrase can go.
[16:26] <abentley> henninge: cool
[16:30] <henninge> bac, BjornT, abentley: now I get this :( http://paste.ubuntu.com/275331/
[16:31] <bac> henninge: i'd ask mthaddon in #launchpad-code
[16:31] <henninge> ah, them losas ...
[16:31] <bac> noodles775: if the MP is marked approved it doesn't show up in my list of things to do.
[16:32] <bac> henninge: when you figure out the magic incantation let me know!
[16:34] <noodles775> bac: so the MP is here: https://code.edge.launchpad.net/~michael.nelson/launchpad/434000-copy-archive-ui/+merge/12164/comments/31501
[16:34] <noodles775> bac: but it might be best waiting to barry goes over the branch...
[16:34] <noodles775> bac: (I didn't realise he'd be around today).
[16:35] <henninge> bac, abentley: "you can't submit to devel - only db-devel"
[16:35] <noodles775> bac: but in the mean-time, I've got another one ready for RC which is correctly marked as pending :)
[16:35] <bac> henninge: that's what tom said?
[16:35] <henninge> yup
[16:36] <bac> henninge: that's interesting
[16:36] <henninge> bac: just like I suspected earlier: when pqm closes, commit to devel are closed, too.
[16:36] <bac> flacoste: ^^
[16:37] <flacoste> hmm
[16:37] <flacoste> salgado: why did you land your breadcrumb branch on db-devel?
[16:38] <salgado> flacoste, I didn't
[16:39] <flacoste> you didn't, rockstar said you did
[16:39] <flacoste> and since he was depending on your branch he landed it on db-devel
[16:39] <flacoste> also
[16:39] <rockstar> salgado, when I merged your branch in, it was definitely based on db-devel.
[16:42] <salgado> rockstar, I don't see how that'd have happened
[16:42] <salgado> I based it on devel and landed it on devel
[16:43] <salgado> if it was based on db-devel I wouldn't be able to land it on devel
[16:46] <henninge> rockstar: since you are a code guy I asume that you do know that we *stack* on db-devel for all branches? .. ;)
[16:47] <rockstar> henninge, that's unrelated though.
[16:47] <rockstar> salgado, no idea, but when I proposed for merge to abentley, there was obvious db-devel stuffs in there.
[16:49] <salgado> rockstar, that's really weird.  the revision email of my branch's landing doesn't show anything from db-devel
[16:49] <rockstar> salgado, hm.  I'll sort it out in about an hour.
[16:50] <abentley> rockstar: skype?
[16:53] <rockstar> abentley, skype - it doesn't see you.
[16:53] <rockstar> abentley, I can't hear/see you.
[16:56] <noodles775> bac: so barry is happy with all the changes in my first RC request (the one that's already in the approved state) at:
[16:56] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/sprint-index-and-attend-3.0/+merge/12044
[16:57] <noodles775> bac: thanks again!
[16:58] <bac> noodles775: just approved the RC on that one
[16:58] <noodles775> bac: heh, too quick :)
[16:58] <bac> noodles775: please hold off on landing until we get a decision on the devel/db-devel issue
[16:59] <noodles775> bac: Will do.
[17:07] <salgado> henninge, how does http://pastebin.ubuntu.com/275350/ look as a fix for https://bugs.edge.launchpad.net/launchpad-foundations/+bug/433991 ?
[17:07] <mup> Bug #433991: Reverse breadcrumb titles don't expand zope.i18nmessageid.message.Message strings <Launchpad Foundations:Triaged> <https://launchpad.net/bugs/433991>
[17:12] <henninge> salgado: are you asking for i18n expertise or for a review?
[17:13] <salgado> henninge, just a review
[17:14] <henninge> salgado: I am not sure what the test is showing, especiall using the "mapping" feature of the message.
[17:14] <henninge> -ly
[17:15] <henninge> salgado: I don't see any actual translation happening.
[17:15] <salgado> that's it -- it shows that the mapping is used
[17:15] <henninge> but that is not translating ...
[17:15] <bac> noodles775: don't you need a UI review for https://code.edge.launchpad.net/~michael.nelson/launchpad/434000-copy-archive-ui/+merge/12164
[17:15] <bac> noodles775: or are you going to ui=rs it?
[17:16] <salgado> henninge, we just happen to use the i18n.translate() method to do the interpolation, if one day we localize LP, things should be translated
[17:17] <henninge> salgado: ah, I understand
[17:17]  * henninge reads bug again
[17:18] <henninge> salgado: the code looks fine to me, r=me
[17:18] <henninge> salgado: but I will have to understand better how that works ...
[17:19] <salgado> henninge, there's one thing I forgot to tell you
[17:19] <henninge> salgado: you *will* need an mp though and add bac as another reviewer of type "release-critical"
[17:19] <henninge> salgado: yes?
[17:21] <salgado> henninge, the fmt:pagetitle formatter in webapp/tales.py joins all the breadcrumbs' texts in a single string, but it assumes that they're all unicode objects.  when it does that, we end up with a title containing non-interpolated strings
[17:21] <salgado> that may help you understand how this works
[17:23] <henninge> salgado: yes, I always thought _() produces an unicode string ...
[17:23] <henninge> maybe it can simply be casted?
[17:23] <salgado> this is what happens when it is casted
[17:24] <salgado> ''.join() will implicitly cast it, and that's when the bug bites
[17:29] <henninge> salgado: I just tried that out. But this behviour still does not make sense to me ...
[17:30] <salgado> henninge, you mean that casting it to unicode doesn't do the interpolation?
[17:30] <henninge> salgado: yes, like you described.
[17:30] <henninge> salgado: btw, I find the page_title much too verbose in the first place. It should just be "Ask a question"
[17:31] <henninge> it will be "Evolution >> Answers >> Ask a question"
[17:31] <henninge> I mean, should be
[17:31] <henninge> it *will* be "Evolution >> Answers >> Ask a question about Evolution"
[17:31] <henninge> which is tmi
[17:31] <henninge> or worse :
[17:32] <henninge> "Evolution >> Answers for Evolution >> Ask a question about Evolution"
[17:32] <henninge> Argh!
[17:32] <salgado> henninge, agreed, but this is the standard for 3.0
[17:32] <henninge> No, it is not.
[17:32] <henninge> salgado: it is a matter of what you put in the page_title property.
[17:33] <salgado> oh, you mean just the first bit of the actual <title>
[17:33] <henninge> no need to mention that translations pages are a shining example of that ... ;-)
[17:34] <henninge> we have "label" which takes the actual heading of the page above the bread crumb and it can be verbose.
[17:35] <henninge> we have "page_title" which goes into the bread crumb and must be consise, not repeating information found in the breadcrumbs anyway - like the name of the project.
[17:35] <salgado> henninge, agreed, but this is out of the scope of this branch, I'm afraid.  these are nice improvements but not really RC
[17:35] <henninge> finally, the <title> is the invers bread crumb be default. I don't have a problem with that ... ;)
[17:36] <henninge> salgado: oh, I already said r=me, didn't I? :-P
[17:36] <salgado> good point. ;)
[17:41] <salgado> henninge, can you say so in https://code.launchpad.net/~salgado/launchpad/bug-433991/+merge/12170 ? :)
[17:42] <henninge> salgado: done
[17:42] <salgado> bac, I've got one for you: https://code.edge.launchpad.net/~salgado/launchpad/bug-433991/+merge/12170
[17:42] <salgado> thanks henninge!
[17:46] <henninge> abentley: I am moving out ...
[18:18] <noodles775> bac: regarding the ui-review for the copy-archives change - yes, thanks (I was in ui=rs mode from blueprints :) ).
[18:19] <bac> salgado-lunch: looks
[18:20] <noodles775> barry: sorry, would you mind doing a really easy ui-review - screenshots there as well as instructions for setting it up locally: https://code.edge.launchpad.net/~michael.nelson/launchpad/434000-copy-archive-ui/+merge/12164
[18:20] <barry> noodles775: sure, just a few minutes
[18:21] <noodles775> barry: no rush at all. Thanks!
[18:21] <barry> abentley: i have a really easy one for ya
[18:21] <abentley> barry: lay it on me.
[18:21] <barry> abentley: mp'ing it now, thanks
[18:29] <barry> abentley: sent.  i requested you so you should see it shortly
[18:42] <abentley> barry: r=me
[18:42] <abentley> barry: I assume you'll be getting an RC for this?
[18:43] <barry> abentley: thanks!  and yep
[18:43] <barry> bac: ^^
[18:44] <bac> barry:  i'll look in a sec
[18:59] <bac> barry: did you fix the lint issue?
[19:00] <bac> or was it fake?
[19:00] <barry> bac: i fixed it
[19:00] <salgado> bac, should my branch go to devel or db-devel?
[19:00] <bac> barry: cool.  i'll approve it.  on future ones please add me to the MP with 'release-critical' as the review type.
[19:00] <bac> salgado, barry:  until tomorrow at 2200Z everything goes to devel
[19:01] <bac> well, unless it is db stuff, which it isn't
[19:01] <salgado> ok
[20:14] <barry> abentley: i'll have a 150 line diff for ya in a few minutes if that's cool
[20:14] <abentley> barry: Sure.
[20:24] <barry> abentley: mp sent
[20:33] <abentley> barry: r=me.
[20:34] <noodles775> Hi barry, do you reckon you'll have time soon to do that quick ui-review? If not, no probs, but if you can I can send it off before I go to bed :)
[20:34] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/434000-copy-archive-ui/+merge/12164
[20:35] <barry> noodles775: gah, totally forgot sorry!  will do that now
[20:35] <barry> abentley: thanks!
[20:35] <noodles775> Thanks barry!
[20:35]  * noodles775 should have requested it on the MP - always forget.
[20:35] <bac> noodles775: did you get my email re: the blueprint conversion
[20:36] <noodles775> bac: yep, just replied - that'll be great.
[20:36] <bac> noodles775: thanks a ton!
[20:36] <noodles775> np :)
[20:36] <barry> noodles775: what does "copy archive generic-string18 for person-name16" even mean? :)
[20:37] <bac> mrevell-dinner: ping
[20:37] <barry> noodles775: so there's no archive description yet on that screenshot?
[20:42] <noodles775> barry: sorry - yes, I used the factory to create and populate the copy-archive, hence all the generic names.
[20:43] <noodles775> barry: and yes, I didn't add a description either.
[20:43] <noodles775> barry: (I used the exact script in the test/demo section of the MP).
[20:44] <barry> noodles775: cool.  ui=me* it looks great
[20:44] <noodles775> barry: great, thanks!
[20:47] <abentley> jtv: ping
[20:47] <jtv> abentley: pong
[20:48] <abentley> jtv: wrt your bug-146855, I think it would be a good idea to run the unit tests under the new database user.
[20:48] <abentley> jtv: I often find I miss necessary permissions if I don't do that.
[20:48] <jtv> abentley: sounds good... forgive me but it's late and hot here: self.layer.switchDbUser?
[20:49] <jtv> abentley: I was worrying about the same thing.
[20:49] <abentley> jtv: That's right.
[20:49]  * jtv fiddles
[20:49] <mrevell-dinner> bac: I'm more "mrevell-putting-son-to-bed" at the moment. Gimme twenty mins. Will you still be around?
[20:49] <abentley> jtv: I think you also missed my question "Is FAILED really a terminal status? It seems like it's possibly not terminal, and that's why you're delaying 30 days"
[20:50] <jtv> abentley: oh, sorry, I read through everything before starting to answer that one.  Yes, FAILED is a terminal status—but an entry can get out of any status by being "refreshed" with a new upload.
[20:50] <jtv> So I'm not counting that.  :-)
[20:51] <abentley> Okay, so r=me, modulo switching the db user.
[20:51] <bac> barry: rc=bac.  remember land on devel
[20:51] <jtv> abentley: working on that now.  Thanks!
[20:51] <bac> mrevell-dinner: sure
[20:52] <abentley> jtv: You'll probably need to commit the transaction before switching the db user.
[20:54] <barry> bac: thanks
[20:54] <bac> mrevell-dinner: https://launchpad.dev/+tour/images/community/3.png
[20:54] <mrevell-dinner> bac: ah thanks, I'll fix that. Handsome devil..
[20:55] <mrevell-dinner> right, I'm not here  for a few mins
[20:55] <bac> mrevell-dinner: there's another too
[20:55] <bac> mrevell-dinner: no worries
[20:55] <bac> mrevell-dinner: and this one looks a little dated:  https://launchpad.dev/+tour/images/blueprints/3.png
[21:44] <rockstar> abentley, howzabout a review?  It's something I'm going to get an RC on.
[21:45] <abentley> rockstar: Sure thing.
[21:45] <rockstar> abentley, coming up.
[22:03] <rockstar> abentley, did my proposal arrive?
[22:03] <abentley> rockstar: Yeah, about 3 minutes ago.
[22:04] <abentley> rockstar: r=me.
[22:04] <rockstar> abentley, hooray.
[22:04] <rockstar> bac, did you see my rc review request?
[22:05] <rockstar> bac, https://code.edge.launchpad.net/~rockstar/launchpad/sourcelist-template/+merge/12195
[22:06] <bac> rockstar: no.  thanks for pinging me abt it
[22:07]  * bac looks
[22:07] <rockstar> bac, it's all mechanical, closes off the two templates you and I talked about this morning.
[22:10] <bac> rockstar: will you be landing this via ec2?
[22:11] <rockstar> bac, absolutely.  It seems stupid not to.
[22:11] <bac> alrighty, then
[22:11] <bac> rc=bac
[22:13] <rockstar> bac, thanks.
[22:14] <rockstar> bac, in the pqm regex, is rc= before r= ?
[22:17] <bac> rockstar: [release-critical=bac][r=abentley]
[22:17] <bac> rockstar: look at some of the landing messages from today
[22:33] <mrevell> bac: I've just pushed a new version of the tour images branch. I've made extensive updates to the images and I've removed mentoring and sprints from the text. The first for obvious reasons, the second because it was always a bit of a struggle to justify its presence and even harder now there's not a pretty picture (silly, I know). All of this is pending a major and thorough re-do of the tour this comign cycle.
[22:40] <mrevell> having said that, I shall be bowing out now. G'night