| === jtv changed the topic of #launchpad-reviews to: on call: — || reviewing: [] || queue: [jtv] (pqm is release-critical) | ||
| === stub1 is now known as stub | ||
| === jtv is now known as jtv-eat | ||
| === henninge_ is now known as henninge | ||
| noodles775 | henninge: I've just reviewed jtv's work on the specificationtarget-assignments.pt, can you take a look and see if you agree? | 09:56 |
|---|---|---|
| noodles775 | https://code.edge.launchpad.net/~jtv/launchpad/mechanical-specificationtarget-assignments/+merge/12203 | 09:56 |
| noodles775 | He'll be needing the same menu/portlet that you're currently doing, so it might be easiest for you just to merge his branch and do the small update to the template to ensure it's consistent. | 09:57 |
| noodles775 | Then you guys will only need one rc too. | 09:57 |
| henninge | jtv: are you back? | 10:19 |
| jtv | henninge: yes | 10:19 |
| henninge | jtv: did you read noodles review? | 10:19 |
| jtv | henninge: not yet, no | 10:19 |
| henninge | jtv: I am working on the menus for hasspeci... | 10:20 |
| jtv | henninge: then michael's suggestion makes sense | 10:20 |
| henninge | jtv: he suggests I merge your branch | 10:20 |
| henninge | noodles775: still, I cannot get the global actions to work ... | 10:20 |
| jtv | henninge: shall I just fix up the things he remarked on, and then ping you so you can merge? | 10:21 |
| noodles775 | henninge: did you take a look at the mp I linked? If it's still not working push it and I'll take a look. | 10:21 |
| henninge | jtv: yes, please | 10:21 |
| henninge | noodles775: I did. | 10:21 |
| jtv | henninge: I ran mine through EC2, so should be okay. Feel free to merge now. | 10:26 |
| henninge | jtv: ok | 10:26 |
| jtv | noodles775: thanks for a understanding and constructive review. :) | 10:27 |
| noodles775 | jtv: np! | 10:27 |
| allenap | gmb: Are you OCR today? Cause I've got a nice RC candidate for you :) | 10:30 |
| gmb | allenap: Yep. | 10:32 |
| gmb | Goferit | 10:32 |
| allenap | gmb: https://code.edge.launchpad.net/~allenap/launchpad/convert-blueprints-bug-434056/+merge/12210 | 10:33 |
| allenap | gmb: Thanks. | 10:33 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: allenap || queue: [jtv] (pqm is release-critical) | ||
| gmb | jtv: Do you have a branch in the queue or is that reference stale? | 10:34 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: gmb || reviewing: allenap || queue: [] (pqm is release-critical) | ||
| gmb | That answers that question then :) | 10:34 |
| jtv | gmb: I have another one, but the reference was for an older one. | 10:34 |
| noodles775 | gmb: sorry, didn't see your question - just theh topic ;) | 10:34 |
| jtv | Sorry, for another one | 10:34 |
| gmb | allenap: Can you file a bug for the SpecificationGoalDecideView tests please? We should probably, like, write some. | 10:36 |
| gmb | jtv: Understood. | 10:36 |
| allenap | gmb: Heh, you professional you. | 10:37 |
| gmb | Oh, is that what it is? Hmm. | 10:37 |
| gmb | allenap: I hereby grant you Instant Hero status for getting rid of SpecificationFeedbackClearingView.process_form() | 10:38 |
| allenap | gmb: Cool. It's so old I didn't know how it worked. | 10:39 |
| gmb | allenap: Everything looks fine. r=me. Nice job! | 10:39 |
| allenap | gmb: Thanks! | 10:40 |
| allenap | gmb: Fwiw, bug 434555 is the SFDV-tests-pls bug. | 10:40 |
| mup | Bug #434555: SpecificationGoalDecideView is not tested <Launchpad Blueprints:New> <https://launchpad.net/bugs/434555> | 10:40 |
| gmb | Okiedoke. | 10:41 |
| === danilo-afk is now known as danilos | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: gmb || reviewing: allenap || queue: [noodles] (pqm is release-critical) | ||
| noodles775 | gmb: I've got a small MP which should hit your inbox any minute, for when you've time. | 11:17 |
| gmb | noodles775: Sure, I'll look shortly. | 11:17 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: noodles775 || queue: [] (pqm is release-critical) | ||
| gmb | noodles775: Can you give me a link to the mp? It's not showing up in my inbox. | 11:31 |
| noodles775 | gmb: https://code.launchpad.net/~michael.nelson/launchpad/missing-distro-ppas-heading/+merge/12211 | 11:33 |
| gmb | Ta | 11:35 |
| gmb | noodles775: Looks good. r=me | 11:37 |
| noodles775 | gmb: great, thanks. | 11:37 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue: [] (pqm is release-critical) | ||
| bac | noodles775: rc=bac | 11:51 |
| noodles775 | bac: great, thanks. | 11:51 |
| === mrevell is now known as mrevellunch | ||
| intellectronica | gmb: i've got a branch for you. pretty simple stuff | 12:08 |
| gmb | intellectronica: Sure, diff me. | 12:08 |
| intellectronica | gmb: https://code.edge.launchpad.net/~intellectronica/launchpad/webkit-ajax-disables/+merge/12215 http://pastebin.ubuntu.com/275790/ | 12:09 |
| gmb | intellectronica: Looks good. r=me. | 12:12 |
| intellectronica | gmb: thanks for a speedy review! | 12:12 |
| gmb | intellectronica: I seem to be good at diffs today. I wonder if htat means I'll suck at Python... | 12:12 |
| bac | gmb: please leave RC candidate MPs in 'Needs Review' and remind the dev to add a 'release-critical' request so the MP workflow works. | 12:13 |
| intellectronica | bac: i just made such a request | 12:13 |
| gmb | bac: Okay, duly noted. | 12:13 |
| bac | intellectronica: cool | 12:13 |
| bac | thanks graham | 12:13 |
| gmb | noodles775, allenap ^^ please do the above if you haven't already. | 12:13 |
| intellectronica | bac: i'm sure that as a safari user you'll be glad to approve it :) | 12:13 |
| * bac looks! | 12:13 | |
| allenap | gmb: Thanks, done. | 12:13 |
| bac | intellectronica: is it our ugly red error box? | 12:13 |
| noodles775 | gmb: yep, done. Thanks. | 12:14 |
| intellectronica | bac: not quite. the ugly red error box is a fairly complicated bug to do with the interaction of webkit and lazr.restful, and i don't feel that i can cover it for r-c. for now i just made the controls usable in webkit by navigating to the boomerang form. i'll ask leonard for help fixing the real bug later on | 12:15 |
| intellectronica | bac: there's also a fix to make editing duplicates in webkit work in that branch | 12:15 |
| bac | intellectronica: got it | 12:15 |
| * gmb -> lunch | 12:20 | |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: lunch || queue: [] (pqm is release-critical) | ||
| === henninge is now known as henninge-lunch | ||
| === bigjools changed the topic of #launchpad-reviews to: on call: gmb || reviewing: lunch || queue: [bigjools] (pqm is release-critical) | ||
| bac | intellectronica: why did you disable the ajax assignee for webkit? i never had a problem with that | 12:43 |
| intellectronica | bac: i thought it has the same problem as the product ajax control. if it doesn't then i can revert that. let me validate | 12:44 |
| bac | intellectronica: also, on your branch i went to https://bugs.launchpad.dev/firefox/+bug/5 and tried to make it a duplicate of bug 1 | 12:44 |
| mup | Bug #1: Microsoft has a majority market share <ubuntu> <Clubdistro:Confirmed> <Computer Science Ubuntu:Confirmed for compscibuntu-bugs> <Ichthux:Confirmed for raphink> <JAK LINUX:Confirmed> <Linux Mint:Won't Fix> <OpenOffice:Confirmed for lh-maviya> <Launchpad Translations:Invalid> <Tabuntu:Confirmed for tinarussell> <Ubuntu:In Progress> <bum (Ubuntu):Invalid> <casper (Ubuntu):Invalid> <djplay (Ubuntu):Invalid> <firefox (Ubuntu):Invalid> <u | 12:44 |
| bac | i got an error popup that had an embedded traceback. | 12:45 |
| bac | intellectronica: i'm sure that isn't due to your fix but can you try to replicate that? | 12:45 |
| intellectronica | bac: you're right about the assignee. i'll revert that change | 12:46 |
| bac | intellectronica: cool | 12:46 |
| intellectronica | bac: the error you're seeing is an error from the server that you can't mark the bug as a duplicate because it's a duplicate itself. that's a terrible way of showing that error, but fixing that is out of scope for an r-c | 12:48 |
| bac | intellectronica: i guess the traceback will either only be shown on lp.dev or only to lp developers on lp.net | 12:49 |
| intellectronica | bac: i've reverted the change to the assignee field. see http://pastebin.ubuntu.com/275807/ | 12:49 |
| bac | intellectronica: cool | 12:49 |
| intellectronica | bac: yes, the error itself is just the stuff you see at the top | 12:50 |
| bac | intellectronica: can you confirm for me that a normal user on lp.net doesn't get the embedded traceback? i believe us but i'd like to see proof. | 12:50 |
| bac | intellectronica: marking your MP rc=bac | 12:50 |
| intellectronica | bac: thanks | 12:51 |
| === henninge-lunch is now known as henninge | ||
| === mrevellunch is now known as mrevell | ||
| === matsubara-afk is now known as matsubara | ||
| === bigjools is now known as bigjools-lunch | ||
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: bigjools || queue: [] (pqm is release-critical) | ||
| gmb | bigjools-lunch: You might want to check that you don't have some massive collisions with allenap's blueprint template conversions. | 13:39 |
| allenap | gmb: We've had words :) | 13:40 |
| gmb | Ah, okay. | 13:40 |
| gmb | As long as it not go boom on merge. | 13:40 |
| intellectronica | gmb: can you review another tiny branch? | 13:44 |
| gmb | intellectronica: Sure, stick it on the queue and I'll take a look when I've finished with bigjools-lunch's branch | 13:44 |
| intellectronica | let me see if anyone else can do it earlier. it's only 36 lines with context | 13:46 |
| intellectronica | http://pastebin.ubuntu.com/275836/ | 13:46 |
| intellectronica | allenap: maybe you can take a look? ^^^ | 13:46 |
| allenap | intellectronica: Sure. | 13:46 |
| intellectronica | thanks | 13:46 |
| allenap | intellectronica: What does it do? | 13:46 |
| intellectronica | allenap: https://code.edge.launchpad.net/~intellectronica/launchpad/tags-cloud-improvement/+merge/12220 | 13:46 |
| intellectronica | allenap: it makes it so that the tags portlet only shows official tags and the ten most popular unofficial ones, like it used to be | 13:47 |
| intellectronica | allenap: so, what do you think? | 13:53 |
| gmb | bigjools-lunch: Your branch looks good. Please file an rc request if this is an RC candidate. r=me. | 13:53 |
| allenap | intellectronica: I was just finishing off an email, looking now. | 13:54 |
| === bigjools-lunch is now known as bigjools | ||
| bigjools | gmb: ta very much | 13:58 |
| bigjools | gmb: the only gotcha is that I know it will conflict with allenap's branch, but the changes are tiny, I don't think they need re-reviewing. | 13:59 |
| intellectronica | allenap: any luck with my patch? it's tiny | 14:05 |
| allenap | intellectronica: I know, but I have some questions about it. I'm writing a very quick review. | 14:06 |
| intellectronica | why don't you just ask me the questions? | 14:06 |
| intellectronica | wow, half hour for a review of one little display method | 14:15 |
| intellectronica | allenap: i'm going to get something to eat. hopefully when i'm back you can let me know whether my patch is ok and if not what questions you have about it? | 14:16 |
| bac | allenap: 1 rc, 1 not rc. thanks for the work on both. | 14:17 |
| allenap | bac: Thanks, cool | 14:18 |
| gmb | bigjools: Righto; if it's just for conflict resolution purposes I'm not that concerned. | 14:21 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: || queue: [] (pqm is release-critical) | ||
| bac | bigjools: rc approved with one minor fix | 14:45 |
| bac | bigjools: and one optional fix | 14:46 |
| bigjools | bac: ok - you are thorough :) | 14:46 |
| bigjools | allenap: do you have a special commit message you want me to use when I land your branch? | 14:50 |
| bigjools | you got it rc-ed right? | 14:50 |
| allenap | bigjools: Yes. "I am allenap's bitch". | 14:50 |
| bigjools | :) | 14:51 |
| allenap | bigjools: That's a no :) | 14:51 |
| * bigjools goes prone | 14:51 | |
| allenap | bigjools: Thanks! | 14:51 |
| cprov | gmb: I have an RC candidate, can you review it ? | 14:51 |
| intellectronica | allenap: thanks for the review. i'll change the name of the array of dicts to indicate what it contains. i'm not concerned about performance in this case and there's no point using a generator expression instead of a list if you're going to iterate over it immediately | 14:52 |
| === cprov changed the topic of #launchpad-reviews to: on call: gmb || reviewing: || queue: [cprov] (pqm is release-critical) | ||
| allenap | intellectronica: Okay, cool. | 14:52 |
| gmb | cprov: Sure | 14:54 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: cprov || queue: [] (pqm is release-critical) | ||
| gmb | cprov: Is there an MP? | 14:54 |
| cprov | gmb: thx, https://code.edge.launchpad.net/~cprov/launchpad/soyuz-missing-heading/+merge/12226 | 14:55 |
| * gmb looks | 14:55 | |
| cprov | gmb: I have to go afk for a bit, please add your comments to the MP I will address then when I'm back | 14:57 |
| gmb | cprov: Ok. | 14:57 |
| cprov | gmb: the branch is already playing on ec2, just in case it breaks other tests. | 14:57 |
| bac | cprov: please add your r-c request to the MP before you go | 14:58 |
| cprov | bac: ehe, already done ;) | 14:58 |
| bac | sweet | 14:58 |
| intellectronica | bac: hi, i've asked for https://code.edge.launchpad.net/~intellectronica/launchpad/tags-cloud-improvement/+merge/12220 to be considered for release-critical. it's not really a blocker but it's a very simple fix and we'd really like to have it as part of 3.0 | 14:58 |
| cprov | bac: it's a little big for a RC, but let me know what you think | 14:58 |
| === cprov is now known as cprov-afk | ||
| bac | intellectronica: ok, i'll look | 15:02 |
| bac | deryck: in your new milestone portlet the counts are not right-aligned. looking at https://bugs.launchpad.dev/debian/+bugs the counts for the three different portlets are all over the place, though internally consistent. ideas? | 15:05 |
| deryck | bac, on phone, just a moment | 15:05 |
| deryck | bac, sorry | 15:05 |
| bac | np | 15:05 |
| bac | intellectronica: rc=bac, with mods | 15:26 |
| intellectronica | bac: thanks | 15:26 |
| bac | intellectronica: that's some action-packed code in a few lines! | 15:26 |
| intellectronica | heh, yes, it's easy to do long expressions with list comprehensions | 15:27 |
| gmb | cprov-afk: Your branch looks good to land. r=me. | 15:30 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || queue: [] (pqm is release-critical) | ||
| bac | henninge: i am going to disapprove the r-c for jtv's MP since you will be doing a combined landing. i like his change but an RC is not appropriate. | 15:31 |
| henninge | bac: ok | 15:31 |
| henninge | bac: I am currently struggling with some stray changes in my branch. | 15:31 |
| henninge | dunno were they came from. they are in answers. | 15:32 |
| bac | noodles775: will you mark your review of https://code.edge.launchpad.net/~jtv/launchpad/mechanical-specificationtarget-assignments/+merge/12203 as approved per jtv's changes, if you agree. | 15:32 |
| noodles775 | bac: Done. | 15:33 |
| bac | noodles775: thanks | 15:34 |
| bac | thanks cprov-afk | 15:36 |
| deryck | bac, concerning the alignment issue, the problem is because the portlets use table cells, and the filters have long word to push the number cell far to the right. | 15:39 |
| deryck | bac, the fix requires either making the number cell a fixed width, which I don't particularly like, or converting to not use tables and float the number, which is a lot of templates to touch. | 15:40 |
| deryck | bac, but this is a problem regardless of my fix to add a milestone links portlet. | 15:40 |
| bac | deryck: thanks for the explanation. we can fix them together later | 15:51 |
| deryck | bac, ok. so rc on this branch is ok? Or wait for it to land? | 15:52 |
| bac | deryck: rc=bac | 15:52 |
| deryck | bac, awesome,thanks! | 15:52 |
| mrevell | gmb: Fancy a review? https://code.edge.launchpad.net/~matthew.revell/launchpad/3.0-tour-images/+merge/12174 | 15:59 |
| === rockstar` is now known as rockstar | ||
| gmb | mrevell: Sure, I'll take a look in five minutes or so. | 16:02 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: mrevell || queue: [] (pqm is release-critical) | ||
| gmb | mrevell: Looks fine to me... I see that bac has already r-c'd this, so go ahead and land it :) | 16:07 |
| mrevell | thanks gmb | 16:08 |
| cprov-afk | gmb, bac: thanks for your review | 16:40 |
| bac | cprov-afk: np, thanks for the branch | 16:40 |
| allenap | gmb: Are you accepting new reviews? Specifically, reviews for external bug tracker fixes? Like https://code.edge.launchpad.net/~allenap/launchpad/external-bugzilla-3.4-api-bug-434580/+merge/12230 | 16:42 |
| gmb | allenap: I think I might :0 | 16:43 |
| gmb | :) even. | 16:43 |
| * gmb waits for the diff to generate. | 16:43 | |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: allenap || queue: [] (pqm is release-critical) | ||
| === henninge changed the topic of #launchpad-reviews to: on call: gmb || reviewing: allenap || queue: [henninge] (pqm is release-critical) | ||
| henninge | gmb: I appended my branch, too, but maybe I can get noodles775 to do it. | 16:44 |
| henninge | noodles775: do you have time to review my branch, seeing that you were involved earlier? | 16:45 |
| henninge | bac: my branch is up for review now. Sorry, that took much longer. | 16:45 |
| henninge | bac: I had to clean up some mess in the branch. I will eventually submit through ec2 because now I am not sure *what* I was testing there ... :( | 16:46 |
| bac | henninge: ok. i'll look now | 16:46 |
| intellectronica | hey henninge, want to review a tiny fix i want to r-c while you wait? | 16:47 |
| henninge | intellectronica: like a snack? sure! | 16:47 |
| bac | henninge: you need to get a code review first | 16:47 |
| gmb | allenap: that looks perfic. r=me. Thanks! | 16:47 |
| bac | henninge: ah, i see you're in the queue | 16:47 |
| henninge | bac: I know, sorry to have been unclear ... | 16:47 |
| allenap | gmb: Splendid, thanks! | 16:47 |
| gmb | allenap: Please to be doing the rc dance :) | 16:48 |
| henninge | gmb: that was quick ;) looks like noodles775 is gone ... | 16:48 |
| intellectronica | henninge: lovely. http://pastebin.ubuntu.com/275928/ fixes https://bugs.edge.launchpad.net/malone/+bug/434115 i'll create an mp for you now | 16:48 |
| mup | Bug #434115: ubuntu/series/+source/package/+filebug?no-redirect redirects any way <Launchpad Bugs:In Progress by intellectronica> <https://launchpad.net/bugs/434115> | 16:48 |
| === gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: henninge || queue: [] (pqm is release-critical) | ||
| gmb | henninge: Looking at yours now. | 16:48 |
| henninge | gmb: thanks a lot! | 16:48 |
| gmb | henninge: Or I would... can you give me the URL of the MP please? (Yes, that's lazy of me) | 16:49 |
| henninge | gmb: https://code.edge.launchpad.net/~henninge/launchpad/bug-434055-combined/+merge/12229 | 16:49 |
| gmb | Ta | 16:49 |
| gmb | henninge: Don't the methods of HasSpecificationsMenuMixin need to be properties? (That's usually the case for no-arg methods called by templates). | 16:52 |
| gmb | henninge: Also, how much effort would it be to PEP8ify their names, e.g.: list_all, list_accepted, etc? | 16:52 |
| intellectronica | henninge: and here's the mp: https://code.edge.launchpad.net/~intellectronica/launchpad/distroseries-source-package-filebug-no-redirect/+merge/12232 | 16:57 |
| intellectronica | henninge: is the patch ok? | 16:57 |
| gmb | henninge: Otherwise the branch looks good. I'm not terribly worried about the PEP8 thing but I think that those methods should be properties. | 16:58 |
| henninge | gmb: let me look for those properties ... | 17:01 |
| henninge | gmb: no, not properties, they are methods (at least on translation NavigationMenus) | 17:02 |
| henninge | gmb: changing the names now might break more tests. I have seen it when I changed 'addspec' to 'new' ... So I'd rather not. | 17:04 |
| gmb | henninge: Okay. | 17:05 |
| henninge | intellectronica: r=me | 17:06 |
| henninge | gmb: thanks | 17:06 |
| gmb | henninge: They are properties on other NavigationMenus | 17:06 |
| gmb | I think for consistency they should be here, too. | 17:06 |
| gmb | (Since anything that the template uses should be a property or an attribute, not a no-arg method) | 17:06 |
| intellectronica | henninge: thanks a bunch | 17:06 |
| gmb | henninge: So please add the @properties. Leave the renaming though. | 17:07 |
| gmb | henninge: r=me with that change. | 17:08 |
| intellectronica | bac: i've requested your consideration of https://code.edge.launchpad.net/~intellectronica/launchpad/distroseries-source-package-filebug-no-redirect/+merge/12232 for release-critical. it's a blocker for us | 17:08 |
| bac | intellectronica: no test? | 17:10 |
| === deryck is now known as deryck[lunch] | ||
| intellectronica | bac: i guess i can try and add a test, but i'm not really sure how. i don't think it will work with the test browser, so i have to find out how to test it | 17:12 |
| henninge | gmb: I am sorry, but I have been doing some greping here and I cannot verify that statement. There are *some* methods marked as property but the bulk of them is not. or so it seems. | 17:13 |
| henninge | gmb: so are they all wrong? Just say it, I'll believe you .. ;-) | 17:13 |
| gmb | henninge: Hmm. Actually, you're right. I've mistaken a @property for a link in a NavigationMenu. | 17:14 |
| bac | intellectronica: can you puzzle over it for a timeboxed period and let me know? | 17:14 |
| gmb | henninge: So leave them as they are.. we can take this to the reviewers list. It's not relevant for RC> | 17:14 |
| === matsubara is now known as matsubara-lunch | ||
| intellectronica | bac: sure | 17:14 |
| henninge | gmb: ok, thanks. Sorry for being so stubborn ... ;) | 17:14 |
| gmb | henninge: Stubborn is good. It's how we make everyone else learn :). | 17:15 |
| henninge | ;-) | 17:15 |
| * gmb goes off-call | 17:17 | |
| === gmb changed the topic of #launchpad-reviews to: on call: - || reviewing: || queue: [] (pqm is release-critical) | ||
| henninge | bac: code-review is done ;-) | 17:18 |
| henninge | bac: https://code.edge.launchpad.net/~henninge/launchpad/bug-434055-combined/+merge/12229 | 17:18 |
| bac | ok | 17:18 |
| mrevell | Anyone care to review a help update? https://code.edge.launchpad.net/~matthew.revell/launchpad/home-page-staging-popup-help/+merge/12233 | 17:21 |
| henninge | mrevell: me! me! me! | 17:24 |
| * henninge waits for diff to see how much it is ... | 17:24 | |
| henninge | ;) | 17:24 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| mrevell | :) | 17:29 |
| intellectronica | bac: turns out there's no problem whatsoever doing the test you requested with the test browser. see http://pastebin.ubuntu.com/275955/ | 17:32 |
| mrevell | henninge: the diff's there. Want to do it? :) | 17:34 |
| bac | intellectronica: excellent | 17:35 |
| intellectronica | bac: are you happy for this branch to land for r-c with the addition of the patch? | 17:37 |
| intellectronica | of the test, that is | 17:37 |
| henninge | mrevell: sorry, distracted. looking now. | 17:38 |
| mrevell | danke | 17:38 |
| henninge | mrevell: is href="+help..." ok? or shouldn't it be href="/+help..." ? | 17:39 |
| mrevell | henninge: Yes, probably. I'll fix that. | 17:40 |
| henninge | mrevell: you are saying "What is staging?" but never mention the term before that. | 17:41 |
| henninge | Maybe it should be "... in our staging environment. (What is staging?)" ? | 17:42 |
| mrevell | henninge: Hmm, yes. I misread "sandbox" for staging. Will fix that too. | 17:42 |
| allenap | beuno: Can you review a download icon fix? You've done some work on this previously so you've got context. https://code.edge.launchpad.net/~allenap/launchpad/remove-too-many-download-icons-bug-423105/+merge/12237 | 17:42 |
| henninge | mrevell: don't we do tests for help pop-ups? | 17:43 |
| mrevell | henninge: Not AFAIK | 17:43 |
| henninge | mrevell: ok ... ;) | 17:43 |
| henninge | mrevell: r=me with the discussed changes ;-) | 17:43 |
| bac | intellectronica: yes. i'll update the MP | 17:43 |
| mrevell | henninge: Does that mean you'd like to see a test? :) | 17:43 |
| beuno | allenap, yes | 17:43 |
| henninge | mrevell: having a test is always better but if we don't have examples of how to test that, I think it's too much work atm. | 17:44 |
| mrevell | henninge: Okay, thanks. | 17:44 |
| henninge | mrevell: maybe file a bug like "Help pop-ups should have tests." ? | 17:45 |
| mrevell | henninge: Okay, will do | 17:45 |
| beuno | allenap, approved. I know I can't *really* approve code, but, well, you know. | 17:45 |
| allenap | beuno: Oh, go on :) Thanks! | 17:45 |
| jml | allenap, I've done a code review. | 17:46 |
| allenap | Thanks jml! | 17:46 |
| mrevell | bac: I've requested your review but it wouldn't let me add "release-critical" ... am gonna see if it's a bug. It's for the "sandbox" help change on the front page. https://code.edge.launchpad.net/~matthew.revell/launchpad/home-page-staging-popup-help/+merge/12233 | 17:46 |
| bac | mrevell: thanks | 17:47 |
| salgado | https://code.launchpad.net/~salgado/launchpad/bug-434349/+merge/12239 | 17:53 |
| salgado | sinzui, do you have time to review ^ or should I try to find somebody else? it's rather trivial | 17:54 |
| * sinzui looks | 17:54 | |
| sinzui | salgado: r=me, no changes | 17:56 |
| === mrevell is now known as mrevell-dinner | ||
| salgado | thanks sinzui | 17:57 |
| === deryck[lunch] is now known as deryck | ||
| bac | henninge: rc=bac | 18:01 |
| henninge | bac: cheers | 18:02 |
| henninge | just in time for me ... ;-) | 18:02 |
| bac | henninge: thanks for hanging around | 18:02 |
| henninge | bac: np, you have your hands full, I can see that. ;) | 18:02 |
| bac | hi mrevell-dinner | 18:05 |
| === henninge is now known as henninge-afk | ||
| bac | mrevell-dinner: rc=bac | 18:11 |
| bac | allenap: thanks for waiting around. rc=bac * 2 | 18:16 |
| === matsubara-lunch is now known as matsubara | ||
| * bac grabbing some lunch. RCs to flacoste for the next bit | 18:26 | |
| === danilos is now known as danilo-afk | ||
| === salgado is now known as salgado-lunch | ||
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === salgado-lunch is now known as salgado | ||
| gary_poster | bac, I have a branch that does not fix blueprints but fixes the other bits AFAIK: answers, bugs, code. tests matching the pattern '[bB]read[cC]rumb' pass :-) . ec2 is running tests now. Can you review, or should you/I try to rustle up someone else? https://code.edge.launchpad.net/~gary/launchpad/breadcrumbs/+merge/12246 | 19:57 |
| bac | gary_poster: i'll do it | 19:57 |
| gary_poster | bac, thank you. the diff is a bit longer than it needs to be because my editor decided to do some whitespace cleanup in the zcml | 19:58 |
| bac | gary_poster: good for your editor | 19:58 |
| gary_poster | :-) | 19:58 |
| bac | gary_poster: it's a very pretty diff | 20:00 |
| gary_poster | bac: a bit early for christmas, but red and green stripes are nicely complementary | 20:01 |
| bac | gary_poster: i understand why they had HasBranchesBreadcrumb. you think standardizing on the rootsite name is better? | 20:02 |
| gary_poster | bac: I didn't understand and thought it was simply irregular. Having regular names certainly helps with mass changes like this. Why did they have the old name? And/or, if you simply want me to change it back, just say so. | 20:03 |
| bac | gary_poster: no, the fix is more standard. they could argue it is for IHasBranches so the old name is better | 20:04 |
| bac | gary_poster: approved as is. if you're going through ec2 you'd best target it to db-devel | 20:04 |
| gary_poster | bac: thank you. oh, good point. /me CTRL-C's the current run... | 20:05 |
| bac | gary_poster: check to see that instance is killed! ctl-c left me some zombies last week that were eating money | 20:05 |
| rockstar | Can I get a review from someone? | 20:05 |
| gary_poster | bac ack, thanks | 20:05 |
| bac | rockstar: yes | 20:06 |
| rockstar | bac, on its way. | 20:06 |
| bac | rockstar: rc candidate? | 20:06 |
| rockstar | bac, yea, it's the one you and thumper talked about last night. | 20:07 |
| bac | ok | 20:07 |
| gary_poster | bac: are you a ui reviewer too ([ui=bac]) or should I do a [ui=rs] or do something else? | 20:08 |
| bac | gary_poster: i am not a ui. i'd do ui=rs | 20:09 |
| gary_poster | ok thanks | 20:09 |
| === henninge-afk is now known as henninge | ||
| barry | gary_poster: rockstar flacoste abentley salgado anybody available a review of changes for bug 434761? this is a redesign of the home page requested by beuno | 21:39 |
| mup | Bug #434761: Make the home page pretty <story-ui-3> <Launchpad Registry:In Progress by barry> <https://launchpad.net/bugs/434761> | 21:39 |
| rockstar | barry, sure. | 21:39 |
| barry | rockstar: cool, thanks. i'll push up an mp for ya straight away | 21:40 |
| rockstar | barry, great. | 21:40 |
| barry | rockstar: i have a couple of test failures i need to investigate first... | 21:43 |
| === salgado is now known as salgado-brb | ||
| bac | barry: do let me have a look after the code review. | 21:49 |
| barry | bac: oh, definitely | 21:49 |
| bac | barry: i was a bit ambigous earlier | 21:49 |
| barry | bac: do you want me to just request a release-critical review of the branch from you? | 21:50 |
| === salgado-brb is now known as salgado | ||
| barry | rockstar: mp sent | 22:04 |
| rockstar | barry, ack | 22:04 |
| barry | rockstar: gah! i think i spelled the reviewer request incorrectly | 22:12 |
| barry | https://code.edge.launchpad.net/~barry/launchpad/434761-homepage/+merge/12252 | 22:12 |
| rockstar | barry, yeah, was just about to say I hadn't seen it. | 22:13 |
| barry | rockstar: i'm requesting them old skool | 22:13 |
| barry | bac: beuno just gave me ui approval | 22:17 |
| bac | barry: great. you know he's been drinking, though. | 22:17 |
| barry | :-D | 22:17 |
| * rockstar can also UI review | 22:17 | |
| rockstar | :) | 22:17 |
| barry | rockstar: have you been drinking? | 22:18 |
| bac | grape nehi | 22:18 |
| rockstar | barry, only water, although I'm wondering if booze would give me my voice back. :) | 22:18 |
| bac | rockstar: it's too bad you don't drink beer. i like that Fat Tire you've got up there | 22:18 |
| rockstar | bac, everyone does. :) You need a sprint here if you really like beer. #2 in the nation for microbrews next to Portland. | 22:19 |
| bac | nice | 22:19 |
| barry | rockstar: unfortunately i only request ui reviews from intoxicateds | 22:19 |
| bac | new belgium has *taken over*. in a year they ramped up massive distribution | 22:20 |
| rockstar | Really? I guess I never noticed since they are so big here. | 22:20 |
| rockstar | barry, r=me | 22:20 |
| barry | rockstar: thanks. bac it's up to you now | 22:21 |
| bac | barry: land it, dano | 22:22 |
| bac | barry: i'd be remiss if i didn't remind you to point ec2 to db-devel | 22:23 |
| barry | bac: yes, i will land it through ec2. do you remember the magic incantation to send it through db-devel? | 22:23 |
| bac | barry: check my email to lp-dev | 22:24 |
| barry | bac: +1 (been under an email blizzard) | 22:24 |
| barry | bac: got it | 22:25 |
| bac | barry: props to gary for the magic | 22:25 |
| gary_poster | heh | 22:25 |
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| === jamalta is now known as jamalta-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!