| === jamalta-afk is now known as jamalta | ||
| === jamalta is now known as jamalta-afk | ||
| === Ursinha is now known as Ursinha-afk | ||
| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: sinzui || queue: [] (pqm is release-critical) | ||
| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: — || queue: [] (pqm is release-critical) | ||
| jtv | hi sinzui, r=me | 08:52 |
|---|---|---|
| sinzui | jtv: thanks. | 08:53 |
| jtv | Very nice change. | 08:53 |
| jtv | BTW you also had a branch with two db reviews... does it need a code review as well? | 08:53 |
| sinzui | jtv: no code | 08:54 |
| jtv | ok | 08:54 |
| sinzui | I got jml's approval so that edge uses (which most of the UDS participants are) get access to the feature so that Jorge can plan the logistics | 08:54 |
| sinzui | So I will add the code next week so that we can have a successful UDS | 08:55 |
| noodles775 | Good morning jtv. Are you ready for another? | 08:56 |
| noodles775 | https://code.launchpad.net/~michael.nelson/launchpad/435023-getPubXX-oops-db-devel/+merge/12266 | 08:56 |
| jtv | noodles775: coming up | 08:57 |
| noodles775 | Thanks! | 08:57 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: jtv || reviewing: — || queue: [noodles] (pqm is release-critical) | ||
| jtv | noodles775: was answering a question. Back now. | 09:05 |
| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: noodles || queue: [] (pqm is release-critical) | ||
| jtv | man, it's cold here | 09:06 |
| === mrevell-dinner is now known as mrevell | ||
| === allenap changed the topic of #launchpad-reviews to: on call: jtv, allenap || reviewing: noodles, - || queue: [] (pqm is release-critical) | ||
| jtv | I can hear the wind howling and I _know_ it's calm outside. It's the aircon. | 09:06 |
| allenap | Morning jtv :) | 09:06 |
| jtv | hi allenap! | 09:07 |
| jtv | noodles775: in this error condition you're fixing, what happens currently? | 09:07 |
| noodles775 | jtv: the webservice 500's with a trace - as shown in the bug. | 09:08 |
| noodles775 | jtv: (and generates an oops of course) | 09:08 |
| jtv | noodles775: are we getting that a lot? RC for this seems a bit radical | 09:09 |
| noodles775 | jtv: I wasn't sure - but checked with bigjools - apparently anything that generates an oops is worthy? | 09:09 |
| jtv | wow | 09:10 |
| bigjools | it's a simple fix and it should go in if it ticks off an oops | 09:10 |
| jtv | It certainly is a simple fix, and properly tested. | 09:11 |
| jtv | The new exception type is _very_ specific... Was there no "no package specified" exception anywhere that would suit this case? | 09:13 |
| jtv | Also, maybe it should be derived from InvalidArguments? | 09:15 |
| bigjools | yes, there is an unknown package name one somewhere, but InvalidArgs is better and is something that should be in Foundations if it's not already? | 09:17 |
| jtv | Well, "unknown" package would be a very different error from a "none specified" | 09:18 |
| bigjools | that's fine. Considering that this error is a programmer error, they will only be reading the exception text | 09:19 |
| bigjools | but anyway, InvalidArgs FTW | 09:19 |
| noodles775 | jtv: as I mentioned in the MP, I did search for InvalidArgs and other general exceptions for api usage - and didn't find any. I can create one if it's worthwhile as part of the rc branch? | 09:19 |
| noodles775 | OK, will do. | 09:19 |
| jtv | noodles775: ah, I read your MP as meaning that you'd found one called InvalidArguments but decided against using it. | 09:19 |
| noodles775 | jtv: ah, no. I checked for one expecting to find one. | 09:20 |
| jtv | that changes everything | 09:20 |
| bigjools | I say add one and mail the list | 09:21 |
| jtv | There ought to be one in the Python standard lib. | 09:21 |
| noodles775 | jtv: it needs to be decorated as a web service exception. | 09:21 |
| jtv | Right, I'm only saying there must be a more specific base class than Exception to base yours on. | 09:22 |
| * jtv digs through library docs | 09:22 | |
| jtv | Amazingly, there isn't. | 09:24 |
| jtv | Then the current arrangement is fine; adding an InvalidArguments would be a good thing, but not in an RC candidate. | 09:25 |
| noodles775 | Great... I'll start straight on this release blocker for beuno then. | 09:25 |
| jtv | Sure. I could go bikeshed the wording of everything but not worth the time in this case. r=me | 09:26 |
| noodles775 | Taa. | 09:27 |
| jtv | np | 09:27 |
| === jtv changed the topic of #launchpad-reviews to: on call: jtv, allenap || reviewing: — || queue: [] (pqm is release-critical) | ||
| jtv | allenap: I'm relocating to a different office, so will be afk for a bit. | 10:12 |
| allenap | jtv: Cool. | 10:13 |
| jtv | allenap: actually, that's exactly what I'm hoping to get away from. Freezing in here! | 10:13 |
| allenap | jtv: :) | 10:13 |
| === danilo-afk is now known as danilos | ||
| bac | noodles775: rc=bac. please make sure that bug is tracked on CurrentRolloutBlockers | 11:02 |
| noodles775 | bac: ok, thanks. | 11:02 |
| intellectronica | bac: can i still get r-c for http://pastebin.ubuntu.com/276303/ ? it's a pretty simple change (r=gmb) to fix https://bugs.edge.launchpad.net/malone/+bug/432088 which is quite important to the ubuntu developers | 11:29 |
| mup | Bug #432088: Disable +filebug redirection for ~ubuntu-bugcontrol <Launchpad Bugs:In Progress by intellectronica> <https://launchpad.net/bugs/432088> | 11:29 |
| bac | intellectronica: yes. i'd really like a MP for tracking, even though it is a small fix | 11:32 |
| intellectronica | bac: https://code.edge.launchpad.net/~intellectronica/launchpad/bug-supervisor-no-redirect/+merge/12269 | 11:34 |
| intellectronica | gmb: would you mind stamping https://code.edge.launchpad.net/~intellectronica/launchpad/bug-supervisor-no-redirect/+merge/12269 since you code-reviewed it? | 11:34 |
| bac | intellectronica: thanks tom | 11:34 |
| bac | gmb: please add your mark and set the whole MP to approved when done. | 11:35 |
| bigjools | jtv, allenap: I have a short r-c branch if one of you can take it please? | 11:43 |
| allenap | bigjools: Sure. | 11:44 |
| bigjools | allenap: fab thanks, the MP will appear soon when the email gets through the tubes | 11:44 |
| allenap | bigjools: Cool. | 11:45 |
| jtv | allenap: I'm back. | 11:45 |
| allenap | jtv: Hi! | 11:45 |
| jtv | no sudden rushes while I was away? | 11:45 |
| bigjools | allenap: grrrrrrrrr it seems that using bzr send against db-devel doesn't work | 11:52 |
| === cprov-afk is now known as cprov | ||
| bigjools | allenap: https://code.edge.launchpad.net/~julian-edwards/launchpad/no-udev-diff/+merge/12270 | 11:57 |
| allenap | bigjools: On it now :) | 11:57 |
| bigjools | posting diff now | 11:57 |
| === allenap changed the topic of #launchpad-reviews to: on call: jtv, allenap || reviewing: —, bigjools || queue: [] (pqm is release-critical) | ||
| gmb | bac, intellectronica: Done. | 12:01 |
| intellectronica | gmb: cheers | 12:01 |
| allenap | bigjools: Approved. Nasty, nasty udev :) | 12:03 |
| === allenap changed the topic of #launchpad-reviews to: on call: jtv, allenap || reviewing: —, - || queue: [] (pqm is release-critical) | ||
| bigjools | allenap: nasty diffutils more like! | 12:03 |
| bigjools | thanks! | 12:03 |
| bigjools | bac: can you r-c that one as well, you're on the MP | 12:04 |
| allenap | bigjools: Oh yes. That is a bit of a pain. | 12:04 |
| jtv | allenap: you don't like emdashes? :-) | 12:04 |
| allenap | jtv: I don't have an emdash key on my keyboard :) | 12:04 |
| allenap | jtv: And I'm too lazy to copy and paste. | 12:04 |
| jtv | allenap: <compose> and three dashes :) | 12:04 |
| allenap | jtv: I don't know what a <compose> key is. | 12:05 |
| jtv | allenap: it's like a doorway into a bigger world. In my case it's a key with a weird little kind of swastika flag on it, but it's configurable. | 12:05 |
| allenap | jtv: Ah, okay, I'll look it up. Still, that's four key strokes versus my one. | 12:06 |
| jtv | allenap: but you _get_ so much more for it! | 12:06 |
| bigjools | jtv: like RSI? | 12:09 |
| === henninge is now known as henninge-lunch | ||
| === allenap changed the topic of #launchpad-reviews to: on call: jtv, allenap || reviewing: —, lunch || queue: [] (pqm is release-critical) | ||
| === mrevell is now known as mrevell-lunch | ||
| allenap | jtv: I'm off for ~3 hours, but I'll be back later. | 12:23 |
| bac | bigjools: looking | 12:43 |
| bac | noodles775: done | 12:51 |
| noodles775 | Ta. | 12:52 |
| === henninge-lunch is now known as henninge | ||
| === Ursinha-afk is now known as Ursinha | ||
| bac | bigjools: rc=bac with minor mods | 13:03 |
| bigjools | bac: got 'em, ta | 13:04 |
| === mrevell-lunch is now known as mrevell | ||
| === matsubara-afk is now known as matsubara | ||
| bac | intellectronica: are you going to have allenap look at the MP you submitted? i can't run it now but i'd like someone to. | 13:26 |
| deryck | jtv -- could you review a branch for me? The last of the template conversions! :) | 13:27 |
| jtv | deryck: if it's small! | 13:28 |
| deryck | jtv, 179 lines ok? | 13:28 |
| jtv | deryck: ok | 13:28 |
| deryck | jtv, https://code.edge.launchpad.net/~deryck/launchpad/person-bug-page-ui-update-434794/+merge/12275 | 13:28 |
| === jtv changed the topic of #launchpad-reviews to: on call: allenap || reviewing: deryck (by jtv, who is quiescing) || queue: [] (pqm is release-critical) | ||
| jtv | deryck: you filled the heading slot. | 13:33 |
| deryck | jtv, indeed I did. | 13:34 |
| jtv | Bad, bad deryck. | 13:34 |
| jtv | Also, you're using getSearchPageHeading as page_titles, but they're basically labels AFAICS | 13:35 |
| jtv | A label should give broad context; today's page_titles should only identify the page within the context of the preceding breadcrumb. | 13:36 |
| deryck | jtv, ah | 13:37 |
| jtv | You don't want the breadcrumbs to go "Deryck H » Bugs » Bugs commented on by Deryck H" | 13:37 |
| deryck | jtv, so that's why page_title didn't show up and I had to fill heading slot. | 13:37 |
| jtv | You want them to go "Deryck H » Bugs » Commented" or somesuch | 13:37 |
| jtv | The page_title doesn't go in the heading. It doesn't go into the h1. It goes into the <title>, followed by the rest of the breadcrumbs. | 13:38 |
| jtv | (Because it also goes at the end of the breadcrumbs) | 13:38 |
| jtv | This was changed in week 3 | 13:38 |
| jtv | So: label becomes h1, page_title becomes a breadcrumb, breadcrumbs reversed become title. | 13:39 |
| deryck | right, I follow now. And I knew it changed. I'll plead laziness for not going to read the rules again. | 13:39 |
| jtv | That's why your pagetest at the end has these nasty repetitive titles. | 13:39 |
| jtv | deryck: Re-reading rules is generally futile. | 13:39 |
| deryck | and people say defining a page title manually is more work. ;) | 13:40 |
| * deryck ducks | 13:40 | |
| deryck | jtv, I'll do a quick update now | 13:41 |
| jtv | thanks | 13:41 |
| bac | gmb: could you get a code review on your branch before requesting the r-c? | 13:41 |
| jtv | deryck: doing it right can be surprisingly hard, and this kind of fix generally pays off for multiple pages. | 13:41 |
| jtv | deryck: and once you get this implemented consistently, you may be amazed at how clear it is. | 13:41 |
| gmb | bac: I've already requested one; sorry for jumping the gun on the rc. | 13:42 |
| bac | gmb: np. | 13:42 |
| bac | intellectronica has done the same. i'm trying to avoid a trend. :) | 13:42 |
| gmb | Heh. | 13:42 |
| gmb | bac: It's the first time we've tracked RCs this way; maybe we need to write down some guidelines. | 13:43 |
| deryck | jtv, it feels like editor wars to me. some of us like our page title code to be an operating system. ;) | 13:43 |
| jtv | deryck: you know the rule: whoever mentions emacs first... :) | 13:44 |
| deryck | heh | 13:44 |
| * deryck mubles somthing about being able to read email and rss and do irc from our page title code | 13:44 | |
| jtv | deryck: I have to go; I fear allenap may have to take up the rest of this review. Another point is that the actions menu really doesn't belong in the sidebar in the new design afaics. | 13:47 |
| jtv | It ought to be a horizontal <ul> of links, each with an info icon, at the top or bottom. | 13:47 |
| deryck | jtv, I followed registry template examples there, or so I thought. but I can follow up with allenap | 13:47 |
| jtv | I suspect there's no time to fix that anyway. | 13:48 |
| jtv | So at best, it's a bug waiting to be filed. | 13:48 |
| jtv | deryck: I really have to go. I'll vote Needs Fixing and let allenap work on this, OK? | 13:48 |
| bac | gmb: yeah, we're just making it up as we go along. i think r-c's were done via MPs at least once before, though maybe not exclusively | 13:48 |
| deryck | jtv, that's good, thanks | 13:49 |
| jtv | OK, g'night! | 13:49 |
| gmb | bac: I only ever remember using the pester-kiko-until-he-says-yes approach. Actually having a procedure for it is weird. | 13:49 |
| bac | gmb: :) -- i do remember kiko sending me back to the MP before. | 13:49 |
| === jtv changed the topic of #launchpad-reviews to: on call: allenap || reviewing: — || queue: [deryck: The Lasts Template Conversion, in Needs Fixing now] (pqm is release-critical) | ||
| bac | gmb: we need to figure out how to get rid of the dumb CRB wiki | 13:50 |
| gmb | Yeah. | 13:50 |
| gmb | allenap: When you're back from lunch, can you take a look at https://code.edge.launchpad.net/~gmb/launchpad/enable-bz-3.4-bug-415779/+merge/12276 for me? It's the last of the Bugzilla work. | 14:02 |
| gmb | allenap: I need to step out for a bit myself, so if I'm not back please just comment on the MP. | 14:02 |
| gmb | deryck: FTR, I'll take over your review from jtv. Not that I actually have anything to add at this point... looking nwo. | 14:07 |
| deryck | gmb, thanks. Almost have an updated diff now. | 14:07 |
| gmb | deryck: Cool. I don't have anything to add to jtv's comments. | 14:08 |
| bac | intellectronica: i'm looking at your branch with the search box spacing | 14:09 |
| bac | intellectronica: it looks like it is worse to me | 14:11 |
| bac | deryck: heads up that PQM is closing in 2:45. you've not got much time to land via ec2 | 14:14 |
| deryck | bac, I already ran through ec2test last night. I know which tests to watch as I update this. | 14:15 |
| bac | deryck: great! | 14:16 |
| bac | deryck: please bin/test -vvm lp.bugs too | 14:16 |
| === jamalta-afk is now known as jamalta | ||
| deryck | bac, ok | 14:19 |
| gmb | bac: Will you be able to do my code review too or are you too loaded at the moment? | 14:20 |
| bac | gmb: i'm looking now | 14:21 |
| gmb | bac: Awesome, thanks. It's already playing in ec2, FTR. | 14:21 |
| deryck | gmb, can you look at my updated diff, please? | 14:21 |
| gmb | deryck: Sure. Is it on the MP or can you paste it for me? | 14:22 |
| deryck | gmb, I added it to the MP | 14:22 |
| gmb | Hmm, I don't see it. | 14:22 |
| gmb | deryck: It's not showing up for me. Can you paste it for the sake of speed? | 14:23 |
| deryck | gmb, sure. | 14:23 |
| intellectronica | bac: why? i prefer the details to wrap if necessary. how do you suggest fixing this? | 14:23 |
| deryck | gmb, http://pastebin.ubuntu.com/276403/ | 14:23 |
| * gmb looks | 14:24 | |
| gmb | deryck: Looks good to me. | 14:25 |
| deryck | gmb, awesome, thanks. | 14:25 |
| deryck | gmb, one more test fix, too. | 14:26 |
| gmb | Ok... | 14:26 |
| deryck | gmb, http://pastebin.ubuntu.com/276406/ | 14:26 |
| gmb | deryck: Looks good too. | 14:27 |
| deryck | gmb, thanks | 14:27 |
| deryck | bac, can you look at this for rc approval? https://code.edge.launchpad.net/~deryck/launchpad/person-bug-page-ui-update-434794/+merge/12275 | 14:28 |
| bac | deryck: i will | 14:28 |
| deryck | bac, thanks! | 14:29 |
| * deryck is running tests now | 14:29 | |
| bac | gmb: land it | 14:37 |
| gmb | bac: Awesome, thanks. | 14:38 |
| bac | intellectronica: i ran your new code and what is on trunk. both wrap as i make the browser smaller but the changed version has the details section wider and thus wraps sooner. perhaps i'm missing the point. | 14:38 |
| bac | intellectronica: what is the status of the fix for bug 432088 ? | 14:38 |
| mup | Bug #432088: Disable +filebug redirection for ~ubuntu-bugcontrol <Launchpad Bugs:In Progress by intellectronica> <https://launchpad.net/bugs/432088> | 14:38 |
| intellectronica | bac: just finished ec2 and is on the patch queue | 14:39 |
| bac | intellectronica: great! | 14:39 |
| bac | intellectronica: as to the search box, i see the details portlet shifted to the left, creating extra space on the right. this causes the search box to be pushed down on browser widths for which it doesn't happen on trunk | 14:41 |
| bac | intellectronica: so what i see is the details portlet always increasing in width. | 14:42 |
| intellectronica | bac: oh. is that using safari? that's not what i see in firefox | 14:42 |
| bac | no, in FF | 14:42 |
| bac | but, admittedly, FF in os x | 14:42 |
| * bac looks at FF in jaunty | 14:44 | |
| intellectronica | bac: it wraps as i expect in chromium too for me, but it does eventually still cause the search box to move down if you resize smaller | 14:45 |
| bac | intellectronica: right. but my point is your branch actually causes it to push down sooner as the browser gets narrower | 14:47 |
| bac | intellectronica: and i confirmed the same in FF on jaunty | 14:47 |
| intellectronica | bac: let me think. i might just move the details back to the side bar for now | 14:48 |
| bac | intellectronica: tom TBH if you have other work to do i'd recommend it. i'm not inclined to think this is an r-c issue regardless of the solution. | 14:49 |
| bac | deryck: looking at your branch now | 14:51 |
| intellectronica | bac: i would really like to solve this before the release, though i realise it's not a real blocker | 14:51 |
| deryck | bac, cool, thanks | 14:51 |
| bac | intellectronica: i understand. but at this late hour i don't think it is worth the risk of another branch in the mix. | 14:52 |
| bac | intellectronica: there will be re-roll opporunities, i'm quite sure. | 14:53 |
| bac | deryck: i don't see any breadcrumbs | 14:54 |
| deryck | bac, yeah, the first page doesn't have them. I don't get what's required to enable them, and meant to ask, but forgot. | 14:55 |
| bac | deryck: now i see breadcrumbs on all pages but 'list all related pages' | 14:55 |
| bac | hey barry! | 14:56 |
| deryck | bac, right. I poked at it a bit last night, but never could work out what I needed to do for that one page, so I just forgot to come back to it. | 14:56 |
| bac | deryck: hound barry or salgado. there is a very specific fix for this type page | 14:57 |
| deryck | barry, ping. Can you help me work out why one page doesn't have breadcrumbs? | 14:57 |
| bac | deryck: the 'action' portlet looks very LP 1.0. we can land as is but please immediately start work to have it redone for the first re-roll | 14:58 |
| salgado | deryck, which page is that? | 14:59 |
| deryck | hi salgado, thanks. let me get an MP link if you need. It's the person bug page. bugs.lp.dev/~name16 for example | 15:00 |
| deryck | salgado, https://code.edge.launchpad.net/~deryck/launchpad/person-bug-page-ui-update-434794/+merge/12275 | 15:00 |
| deryck | bac, so should the links not be in the side slot? They should be in the main page? Or just the look of the sidebar is wrong to you? | 15:01 |
| bac | deryck: look is wrong. perhaps they shouldn't be there. no icons | 15:01 |
| salgado | deryck, can you tell me what you'd expect for the breadcrumbs and what you see instead? | 15:01 |
| deryck | bac, right, I thought they needed icons, but that position was ok. | 15:01 |
| bac | deryck: it smells funny but i'd defer to beuno for the corrective action | 15:02 |
| bac | deryck: i'm thrilled we've gotten this page where it is, don't get me wrong | 15:02 |
| deryck | salgado, there is no breadcrumbs at all. I would expect "Foo Bar: Related bugs" or something similar. | 15:02 |
| deryck | bac, right, me too. We need to get what needs to be fixed documented, too. If I come off frustrated, it's only because I feel like I have to relearn the rules everytime I do a conversion. | 15:04 |
| bac | deryck: understood | 15:04 |
| beuno | bac, deryck, what's up? | 15:05 |
| deryck | I jump from conversions to other things a lot lately, too. So maybe it's just me. | 15:05 |
| salgado | deryck, you need a Breadcrumb adapter similar to BugTargetOnBugsVHostBreadcrumb (in lib/lp/bugs/browser/bugtarget.py), but for IPerson | 15:05 |
| bac | beuno: here's the current look of the person bug page: http://people.canonical.com/~bac/bug-page.png | 15:05 |
| beuno | right | 15:05 |
| beuno | wrong | 15:06 |
| beuno | how about a drop down as a filter | 15:06 |
| deryck | salgado, but the other views in browser/person.py for these bug views have breadcrumbs, so shouldn't this already exist? | 15:06 |
| beuno | which is kind of what it is? | 15:06 |
| beuno | on top of the listing | 15:06 |
| bac | beuno: it has issues with breadcrumbs on that page and the actions look incorrect. it just got converted so i'm inclined to have it land and fix it first opportunity | 15:06 |
| beuno | View: [INPUT BOX THAT NAVIGATES ON CHANGE] | 15:06 |
| salgado | deryck, the other views have because they're not the default view for IPerson on that layer | 15:07 |
| bac | beuno: we have little time for any but the most simple changes | 15:07 |
| beuno | bac, it's a pretty important page to land this way, no? | 15:07 |
| beuno | also | 15:07 |
| beuno | the format of the listing is different than other places, I think | 15:07 |
| salgado | deryck, and they lack an intermediate breadcrumb pointing to bugs.lp.dev/~person | 15:07 |
| deryck | salgado, ok, I'll take another stab at it. I tried a breadcrumb adapter last night and ended up with zcml errors. | 15:09 |
| salgado | deryck, it's got to be a named adapter, like in the zcml declaration of BugTargetOnBugsVHostBreadcrumb | 15:09 |
| deryck | beuno, bac -- so how much time do I left to work on this? | 15:09 |
| deryck | salgado, ok | 15:10 |
| bac | beuno: if we want this page fixed for our deadline we'll need some prescriptive help from you ASAP. | 15:10 |
| beuno | bac, drop down | 15:10 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: — || queue: [deryck: The Lasts Template Conversion, in Needs Fixing now, noodles] (pqm is release-critical) | ||
| beuno | and use the same formatting for the list as everywhere else | 15:11 |
| beuno | that's it | 15:11 |
| beuno | or is there something I'm missing | 15:11 |
| beuno | those option s are a filter | 15:11 |
| beuno | lets show them as such | 15:11 |
| noodles775 | Hi allenap, if/when you have time, another RC: https://code.launchpad.net/~michael.nelson/launchpad/sprint-index-should-hide-heading-db-devel/+merge/12284 | 15:11 |
| bac | deryck: PQM closes at 16:00 UTC -- less than two hours from now | 15:11 |
| beuno | bac, deryck, I'm 100% available for you guys | 15:12 |
| bac | beuno: thanks | 15:12 |
| bac | beuno: i don't know what you mean by 'dropdown' | 15:13 |
| deryck | bac, beuno -- I worry that adding a drop down menu and changing the fields will take a bit of time, and also cause test failures which will take a bit of time. | 15:13 |
| deryck | well the fields change isn't hard, but the test failures are real if the fields are tested | 15:13 |
| bac | beuno: should "List assigned bugs" become (i) Assigned bugs? | 15:14 |
| deryck | plus I have to now get the breadcrumbs right for the page. | 15:14 |
| beuno | bac, yes | 15:14 |
| beuno | deryck, the listing should look like this: https://bugs.edge.launchpad.net/bzr/ | 15:14 |
| bac | beuno: and should the be <ul horizontal> ? | 15:14 |
| beuno | well, if a drop down is out of the question | 15:15 |
| beuno | then lets move it from the side bar | 15:15 |
| beuno | use the whole page | 15:15 |
| beuno | and have something like: "See all bugs: assigned to me, I've commented on, reported..." | 15:15 |
| deryck | beuno, can you do me a sketch or mockup so I can picture how you want it? Is that possible? | 15:15 |
| beuno | above the listing | 15:16 |
| beuno | deryck, for which of the two options? :) | 15:16 |
| beuno | I'll do whatever you need | 15:16 |
| deryck | beuno, so just a paragraph of links basically? Or a list? | 15:16 |
| deryck | beuno, the related pages links I'm asking about | 15:16 |
| bac | beuno: are you suggesting the list side bar have those counts? | 15:16 |
| beuno | deryck, I'd have links in a phrase, one line, above the table | 15:16 |
| beuno | well | 15:17 |
| bac | beuno: i think your example page is misleading then | 15:17 |
| beuno | if you want to make it inconsistent with launchpad, but consistent with the bug page | 15:17 |
| beuno | add the counts | 15:17 |
| bac | beuno: something more like https://edge.launchpad.net/~bac | 15:17 |
| beuno | then yeah | 15:17 |
| beuno | bac, deryck, like: https://code.edge.launchpad.net/~beuno | 15:18 |
| beuno | 93 owned branches, 101 registered branches, 103 subscribed branches | 15:18 |
| deryck | beuno, ok. | 15:18 |
| beuno | if you can't do the counts, no counts | 15:18 |
| deryck | beuno, bac -- is there an easy way to get the elements in context/@@+global-actions or do I have to build this by hand? | 15:18 |
| beuno | deryck, and making the listing look the same format as the rest is the most important | 15:18 |
| deryck | I can always look at the branches code, too. | 15:19 |
| beuno | have bug icons, #, etc | 15:19 |
| beuno | like the listing in: https://bugs.edge.launchpad.net/bzr/ | 15:19 |
| * beuno doesn't know about contexteses | 15:19 | |
| deryck | beuno, you don't want the "In" column in these listings? | 15:20 |
| beuno | well... | 15:20 |
| beuno | damn | 15:20 |
| beuno | yes | 15:20 |
| beuno | so just displau the bug # the same way :) | 15:21 |
| deryck | beuno, ok :) | 15:21 |
| bac | beuno: ok | 15:21 |
| beuno | \o/ | 15:21 |
| beuno | group hug | 15:22 |
| deryck | beuno, bac -- so breadcrumbs on the first page, links above bug list, and bug number formatted the same in bug list. yes? | 15:22 |
| beuno | deryck, yes | 15:22 |
| intellectronica | beuno: as for the bugtarget homepage, would you be ok with me moving the details portlet back into the sidebar? there are various problems with its current location which i can't seem to solve, and i think this will be a reasonable compromise | 15:22 |
| deryck | beuno, bac -- I'll work on this, but I think it's going to be quite close for an hour and a half work. | 15:23 |
| beuno | deryck, ignore IRC, and may the force be with you | 15:24 |
| beuno | intellectronica, let me look... | 15:24 |
| noodles775 | bac: you should have just received an rc-request for a branch of mine (not yet reviewed), but from what you've said, it won't make pqm (by the time I get it through ec2test etc.). So should I remove the rc-request? Or is it worth going ahead in case things are delayed? | 15:24 |
| bac | noodles775: i'll look at it. | 15:25 |
| beuno | intellectronica, it's not my favorite thing, but if it has to be, it has to be. If you do, make sure that label and value are on 2 different lines, with enough vertical spacing between the next st of label:value | 15:25 |
| noodles775 | bac: ok, thanks. | 15:25 |
| intellectronica | beuno: yes | 15:26 |
| barry | deryck: still need help? | 15:27 |
| deryck | barry, I think I'm ok now. thanks | 15:28 |
| bac | intellectronica: is the testing for the change guaranteed to be isolated to lp.bugs? | 15:28 |
| intellectronica | bac: it's a template of the bugs application, but i can't guarantee that it's not used in the test suite of other applications | 15:29 |
| noodles775 | bac: I forgot to mention two things on that mp: (1) the second h1 heading that is displayed is actually incorrect - it refers to blueprints, (2) I also fixed the icon issues for attendees as you'll see in the screenshots. | 15:30 |
| * noodles775 adds that to the mp | 15:30 | |
| barry | deryck: cool | 15:30 |
| bac | intellectronica: PQM closes in 90 minutes. i cannot accept the risk of test failures. make the change now if you, as noodles775 has done, but it probably won't get included. | 15:32 |
| intellectronica | bac: ok, yes, this is not enough time | 15:32 |
| bac | intellectronica: i appreciate your desire to get this fixed! | 15:32 |
| bac | noodles775: your fix is good too. i wish we could squeeze it in. luckily it is a rarely visited page. | 15:34 |
| noodles775 | bac: thanks. OK, I'll send it off to ec2test just in case something happens to delay things :) | 15:35 |
| bac | noodles775: do we know if other pages that inherit from HasSpecificationView are affected by the <h1> problem | 15:35 |
| noodles775 | bac: as far as I know, there are not any other IMajorHeadingView views that inherit from HasSpecificationView - the sprint is quite unique in that way. But I'll check. | 15:36 |
| bac | noodles775: good to know. thanks for looking. | 15:36 |
| allenap | deryck: Has your branch already been reviewed? | 15:40 |
| deryck | allenap, yes, thanks | 15:41 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [] (pqm is release-critical) | ||
| bac | allenap: what is the status for bug 423105 | 15:47 |
| mup | Bug #423105: Duplicate download icons in many places <Launchpad Foundations:Fix Committed by beuno> <Launchpad Bugs:In Progress by allenap> <https://launchpad.net/bugs/423105> | 15:47 |
| allenap | bac: Landed in db-devel. | 15:47 |
| allenap | bac: I'll update CRB | 15:47 |
| bac | thanks | 15:47 |
| === ursula_ is now known as Ursinha | ||
| bac | gary_poster: rc=bac. land on db-devel at your leisure | 15:51 |
| bac | deryck: how's it coming? | 15:51 |
| gary_poster | bac thank you | 15:51 |
| deryck | bac, painfully ;) | 15:52 |
| deryck | bac, links are done, working on list format now | 15:52 |
| bac | noodles775, intellectronica, gmb, gary_poster: can you update CRB as required to reflect current statuses | 15:52 |
| gary_poster | bac yes | 15:53 |
| deryck | bac, there will most certainly be tests broken with these changes. I don't see with running tests to find spots and fixing how I can make it in an hour from now. | 15:53 |
| bac | noodles775, intellectronica: please move your branches that won't make it to 'not blockers' | 15:53 |
| bac | deryck: push your branch as soon as you can | 15:53 |
| deryck | bac, ok | 15:53 |
| bac | we can manually parallelize the test suite | 15:53 |
| bac | you can run lp.bugs, i can run lp.registry, etc | 15:54 |
| deryck | bac, gotcha | 15:54 |
| bac | barry and his massive new machine can run the rest | 15:54 |
| kiko | fe fi fo fum | 16:02 |
| beuno | look! a kiko! | 16:02 |
| * gary_poster doesn't have blood of englishman. | 16:02 | |
| gary_poster | well, maybe just a bit. | 16:02 |
| kiko | just a wee bit | 16:08 |
| kiko | as they say | 16:08 |
| noodles775 | allenap: thanks. | 16:10 |
| allenap | noodles775: Welcome. | 16:10 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] (pqm is release-critical) | ||
| bac | noodles775: i like your test to ensure no <h1> is in the main content. is that something that should be applicable to all pages? | 16:22 |
| bac | noodles775: would've come in handy to spread that around a few weeks ago. | 16:23 |
| jml | https://code.edge.launchpad.net/~jml/launchpad/code-to-branches/+merge/12288 | 16:23 |
| noodles775 | bac: hmmm... I'd just added that as a regression for that bug, as it doesn't apply generally (most pages *should* have an h1 in the main content above the breadcrumbs) | 16:24 |
| noodles775 | bac: it's only views that implement IHasMajorHeading that should not have an h1 in the main content. | 16:24 |
| bac | noodles775: ah, right. i was thinking of a restriction below the line. | 16:24 |
| bac | jml: are you proposing that branch for inclusion in the release? | 16:26 |
| noodles775 | bac: I've got my branch on ec2test to land on db-devel just in case it's still open (unlikely), but in the off-chance, could you approve the rc if you agree? | 16:27 |
| jml | bac, yes. | 16:28 |
| bac | noodles775: we have no intention of delaying the closing atm. i've already looked at your changes and can give you an RC quickly should the circumstance arise. | 16:28 |
| bac | jml: has it been through ec2? | 16:28 |
| noodles775 | bac: k. great. | 16:28 |
| jml | bac, it has, but there were failures. I fixed all of the failures, but there is a chance that I missed some. | 16:29 |
| jml | note also that there were unrelated failures from previous branches, which I mentioned on #launchpad-dev | 16:29 |
| bac | jml: PQM closes in 31 minutes. | 16:29 |
| jml | bac, shall I propose it for the next rollout then? :) | 16:29 |
| bac | jml: there is no time. yes, please queue up for a re-roll in the very unlikely event that should happen. :) | 16:30 |
| jml | bac, will do. | 16:35 |
| bac | jml: would you add it to the non-blocker section of https://dev.launchpad.net/CurrentRolloutBlockers | 16:36 |
| jml | bac, added, but left disposition blank | 16:39 |
| === salgado is now known as salgado-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado-lunch is now known as salgado | ||
| === flacoste is now known as flacoste_lunch | ||
| === flacoste_lunch is now known as flacoste | ||
| === mrevell is now known as mrevell-dinner | ||
| === deryck[lunch] is now known as deryck | ||
| === bac changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] (pqm is release-critical) This channel is logged: http://irclogs.ubuntu.com/ || | ||
| === bac changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| === Ursinha is now known as Ursinha-brb | ||
| === danilos is now known as danilos-afk | ||
| === mrevell-dinner is now known as mrevell | ||
| === Ursinha-brb is now known as Ursinha | ||
| === jamalta is now known as jamlata-afk | ||
| === jamlata-afk is now known as jamalta-afk | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
