| === jamalta-afk is now known as jamalta | ||
| === jamalta is now known as jamalta-afk | ||
| === jamalta-afk is now known as jamalta | ||
| === jtv1 is now known as jtv | ||
| === henninge_ is now known as henninge | ||
| jtv | allenap: I hope you're not still ocr'ing... :) | 09:42 |
|---|---|---|
| === jtv changed the topic of #launchpad-reviews to: on call: — || reviewing: — || queue: [jtv] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| noodles775 | oh, it's thursday... | 09:44 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: — || queue: [jtv] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| jtv | o/ | 09:44 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: jtv || queue: [-] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| noodles775 | jtv: which of your two do you want me to start with? | 09:46 |
| jtv | noodles775: db-bug-435655, but turns out my last push (minor test fixup) failed. | 09:47 |
| jtv | Let me check that the diff is at least reasonably representative. | 09:47 |
| jtv | Oh well, the meat of the branch is there, just not a few removed lines. | 09:48 |
| jtv | noodles775: pretend the import at the very top of the diff isn't there (I ended up not needing it), and that one line of output has disappeared from the doctest. :) | 09:49 |
| noodles775 | :) I'll merge your branch locally anyway - so just let me know when you've pushed the latest change. | 09:49 |
| * jtv tries to break-lock... | 09:51 | |
| jtv | noodles775: pushed. Review at your convenience! | 09:57 |
| noodles775 | ta | 09:57 |
| allenap | jtv: Ah, no. Thanks :) | 09:59 |
| jtv | allenap: did deryck get his template conversion through yesterday? | 10:00 |
| === henninge is now known as henninge-brb | ||
| noodles775 | jtv: r=me, sent. | 10:29 |
| jtv | noodles775: thanks! Got another one coming up. | 10:30 |
| jtv | (Much more important than the one I had on the queue from last week) | 10:30 |
| noodles775 | jtv: ok, does that mean there will be a re-roll? | 10:30 |
| jtv | noodles775: dunno, but if not, I'm going for 2 CPs. | 10:30 |
| noodles775 | k. | 10:30 |
| jtv | Frankly, for this particular one, it'd be pretty impressive if we didn't need a re-roll... | 10:31 |
| jtv | noodles775: great suggestion to test for the Committed notice, thanks. I'm using regex search to find it. | 10:37 |
| noodles775 | jtv: why couldn't you just use assertIn() as you've done for the others? | 10:40 |
| jtv | noodles775: mostly because of the spacing between INFO and Committing. | 10:40 |
| jtv | If that changes, this test won't break—but it will no longer have any value as proof that the commit doesn't happen. | 10:41 |
| noodles775 | k. | 10:41 |
| jtv | I could search for just Commit, but that's much too brittle for my taste. I like tests that break when something important changes, not as superficialities change. | 10:42 |
| noodles775 | Yup. | 10:42 |
| noodles775 | jtv: Sorry, I still don't see why self.assertIn('Committed 0 file(s)', stderr) isn't what you want... what did I miss there? | 10:43 |
| jtv | Has no value as proof if the number isn't 0. | 10:44 |
| === henninge-brb is now known as henninge | ||
| noodles775 | jtv: but in that specific case, you want to ensure that the number is zero right? | 10:45 |
| jtv | I want to assure that the message isn't there. | 10:46 |
| noodles775 | of course... I was thinking of checking that it was. | 10:46 |
| jtv | Or a message that would be in its place if things went wrong. | 10:46 |
| jtv | OIC... for that check I'm much less picky! | 10:46 |
| noodles775 | Yep. | 10:46 |
| jtv | noodles775: my other critical MP is: https://code.edge.launchpad.net/~jtv/launchpad/bug-435699/+merge/12338 | 10:52 |
| noodles775 | jtv: yep, already started. | 10:52 |
| jtv | oh, sorry | 10:52 |
| noodles775 | np! | 10:53 |
| === danilos-afk is now known as danilos | ||
| noodles775 | jtv: in _setUpDistro, you've replaced some lines with calls to _makeTemplateForDistroSeries... is it intended that this will not change the test at all (ie. just refactoring)? | 11:17 |
| noodles775 | jtv: or, the other way around, is it relevant that now a POTemplateSubset is created for each template, where as before the same one was used twice? | 11:18 |
| jtv | noodles775: it's purely a refactoring, yes. POTemplateSubset is stateless. | 11:18 |
| noodles775 | jtv: great. | 11:21 |
| noodles775 | jtv: r=me for the second one :) | 11:35 |
| jtv | noodles775: thanks! | 11:35 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: - || queue: [-] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| bac | jtv: rc=bac on bug 435655. please add to CRB. has it gone through ec2 yet? | 12:03 |
| mup | Bug #435655: Export to branch fails: unsupported operand type(s) for -: 'float' and 'datetime.timedelta' <Launchpad Translations:In Progress by jtv> <https://launchpad.net/bugs/435655> | 12:03 |
| jtv | bac: no, still in there, but has been for a while | 12:04 |
| bac | jtv: thanks. no decision has been made about a re-roll but this should be a candidate | 12:07 |
| bac | hi noodles775 | 12:07 |
| jtv | bac: thanks for that. Pretty urgent stuff. | 12:08 |
| bac | BjornT: ping | 12:08 |
| BjornT | hi bac | 12:08 |
| bac | jtv: how long will you be around | 12:08 |
| jtv | bac: a while, I can check in at night. | 12:09 |
| bac | hi BjornT -- i have to leave in just a few minutes for a dental appt. can i ask you to be RM until i return in a few hours? | 12:09 |
| BjornT | bac: sure | 12:09 |
| bac | BjornT: there are 4 MPs with r-c requests. thanks! | 12:10 |
| BjornT | bac: ok. what's the status of bug 434519? it's fixed released, but is still on CRB | 12:11 |
| mup | Bug #434519: Text in overlay is now centered <Launchpad Foundations:Fix Released by michael.nelson> <LAZR Javascript Library:Fix Released by michael.nelson> <https://launchpad.net/bugs/434519> | 12:11 |
| leonardr | noodles775, care to review a javascript branch? (not release critical) https://code.edge.launchpad.net/~leonardr/launchpad/get-field-uri/+merge/12344 | 12:24 |
| bac | BjornT: could you have noodles775 update CRB for that bug? | 12:34 |
| BjornT | noodles775: ^^^ | 12:36 |
| BjornT | noodles775, bac: nm, i was looking at the wrong wiki | 12:41 |
| === matsubara-afk is now known as matsubara | ||
| noodles775 | leonardr: sure! | 13:34 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: leonardr || queue: [-] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| noodles775 | leonardr: actually, I'll just do cprov's first if that's ok... looks urgent. | 13:52 |
| leonardr | noodles775, sure | 13:52 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: cprov || queue: [leonardr] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| cprov | thx, noodles775 | 13:52 |
| noodles775 | np | 13:53 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: jml || queue: [leonardr] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| henninge | noodles775: Hi! | 14:56 |
| noodles775 | Hi henninge :) | 14:56 |
| henninge | noodles775: Can you please do a code and ui review here? : | 14:56 |
| henninge | https://code.edge.launchpad.net/~henninge/launchpad/bug-435712/+merge/12347 | 14:56 |
| noodles775 | henninge: sure - is it an rc? if so, I'll do it before leonardr's otherwise after? | 14:57 |
| * noodles775 checks | 14:57 | |
| henninge | noodles775: yes, I plan to r-c it. | 14:57 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: jml || queue: [henninge, leonardr] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| noodles775 | henninge: usually I'd leave it unclaimed until I start, just in case others join reviewing soon. | 14:58 |
| henninge | noodles775: ah, sorry. I just requested the ui part from you personally. It's really easy, too. | 14:59 |
| noodles775 | Great! | 14:59 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: henninge || queue: [leonardr] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| noodles775 | jml: r=me - it might be worth adding an r-c request to your MP now. | 15:14 |
| noodles775 | Hi henninge - there's no leaf breadcrumb on that question page - is that intentional or it just hasn't been done yet? | 15:34 |
| noodles775 | (ie. outside of the scope of this branch) | 15:34 |
| henninge | noodles775: the latter, I filed a seperate bug about it. FAQ pages seem to suffer from that, too. | 15:36 |
| noodles775 | aha | 15:36 |
| henninge | noodles775: bug 435743, just fyi ... ;) | 15:39 |
| mup | Bug #435743: Bread crumb missing for question and FAQ <Launchpad Answers:New> <https://launchpad.net/bugs/435743> | 15:39 |
| noodles775 | Great. | 15:39 |
| jml | noodles775, which one? | 16:08 |
| noodles775 | jml: Code->Branches? | 16:08 |
| jml | noodles775, ahh, thanks. | 16:09 |
| noodles775 | jml: just see the note I added about other branches introducing print_location... | 16:09 |
| jml | noodles775, yeah, I just saw that. | 16:09 |
| jml | noodles775, really the best thing to do with that is land it asap | 16:09 |
| noodles775 | jml: yes, but even then there are risks (like my branch which I updated). | 16:10 |
| jml | noodles775, well I guess I mean land via ec2test | 16:11 |
| noodles775 | jml: but with a re-roll - even if we both sent off our branches again to ec2test - to land, they'd both pass (as they wouldn't have each others changes right). | 16:12 |
| noodles775 | it would only be the integration that would fail. | 16:12 |
| noodles775 | jml: I guess what I'm trying to say (but doing so poorly) is that the issue here is us all landing these branches for the re-roll at the same time. | 16:13 |
| * jml misses pqm | 16:14 | |
| noodles775 | henninge: code=me, but I'd like someone else to look at the ui as I had a few questions. | 16:14 |
| noodles775 | jml: heh, yeah, that'd solve it :) | 16:14 |
| jml | noodles775, sure. I can take a reasonable amount of care to check for that. | 16:14 |
| noodles775 | Great. | 16:14 |
| jml | noodles775, but in those cases, our present build system basically says "be ready to apply a [testfix]" | 16:14 |
| henninge | noodles775: so do I find somebody else for ui? | 16:14 |
| henninge | or do you? | 16:15 |
| jml | noodles775, which I'm happy to do, as long as it doesn't screw the release. | 16:15 |
| henninge | noodles775: thanks anyway ... ;-) | 16:15 |
| noodles775 | jml: yep, I guess we could just try to avoid an extra 4hrs. | 16:15 |
| jml | yeah. | 16:16 |
| noodles775 | henninge: np. And yes, I was about to ping someone... rockstar could you give a second opinion on the ui for henninge's branch: | 16:17 |
| noodles775 | https://code.edge.launchpad.net/~henninge/launchpad/bug-435712/+merge/12347 | 16:17 |
| rockstar | noodles775, sure. | 16:17 |
| noodles775 | Thanks! | 16:17 |
| rockstar | henninge, ah! Thanks for doing this! When I fixed this page, that slot didn't exist. | 16:18 |
| rockstar | henninge, a big +1 from me. | 16:18 |
| henninge | rockstar: pleasure | 16:18 |
| noodles775 | henninge: did my question about the status make sense? I wasn't sure if it should be included there in the rego info, but maybe it's something you discussed with beuno et al? | 16:19 |
| rockstar | noodles775, it was discussed with beuno. It allowed us to remove on entire superfluous portlet. | 16:20 |
| noodles775 | OK, great! | 16:20 |
| henninge | noodles775: yes, makes sense. | 16:21 |
| === stub is now known as drunken_master | ||
| === drunken_master is now known as stub | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles775 || reviewing: henninge || queue: [leonardr,mrevell/bac] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| === rockstar changed the topic of #launchpad-reviews to: on call: noodles775, rockstar || reviewing: henninge, leonardr || queue: [mrevell/bac] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| rockstar | leonardr, I presume your branch is a lazr-restful branch, correct? | 16:29 |
| rockstar | Can you point me to it? | 16:29 |
| === cprov is now known as cprov-lunch | ||
| leonardr | rockstar: no, it's a launchpad branch | 16:29 |
| noodles775 | ah great - I was just about to apologise to leonard for not getting to it! | 16:30 |
| noodles775 | https://code.edge.launchpad.net/~leonardr/launchpad/get-field-uri/+merge/12344 | 16:30 |
| leonardr | though i do have a lazr.restful branch coming up in just a minute--writing the mp now | 16:30 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: henninge, leonardr || queue: [mrevell/bac] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| rockstar | noodles775, I got your back. :) | 16:32 |
| noodles775 | Thanks rockstar - about to EOD. | 16:34 |
| bac | rockstar: are the reviews you are working on RC re-roll candidates? | 16:40 |
| rockstar | bac, not sure. | 16:41 |
| bac | rockstar: please ask. jump mrevell and any others to the top, please. | 16:41 |
| mrevell | thanks bac | 16:41 |
| rockstar | bac, I assumed since there was no one on duty when I started, no one needed theirs ASAP. | 16:42 |
| bac | rockstar: mrevell's will take 2 seconds | 16:42 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: mrevell/bac || queue: [] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| bac | rockstar: sure, that's reasonable. | 16:42 |
| rockstar | I don't see one in here from mrevell | 16:42 |
| mrevell | rockstar: it may be under bac | 16:43 |
| rockstar | Ah, I see it. It's yours bac. :) | 16:43 |
| mrevell | rockstar: https://code.edge.launchpad.net/~bac/launchpad/lp-blog/+merge/12351 | 16:43 |
| rockstar | bac, r=me | 16:44 |
| mrevell | thanks rockstar | 16:44 |
| bac | tahnks rockstar. sorry for the disruption. | 16:44 |
| rockstar | I'm a little confused on why we're copying the blog instead of aggregating it though. | 16:44 |
| rockstar | bac, I'm done now anyway. :) | 16:44 |
| leonardr | rockstar, here's the lazr.restful branch: https://code.edge.launchpad.net/~leonardr/lazr.restful/431986-field-resource-link/+merge/12357 | 16:44 |
| bac | rockstar: that's coming soon | 16:44 |
| mrevell | rockstar: we'll be aggreagting soon | 16:44 |
| rockstar | bac, okay. | 16:44 |
| mrevell | or even aggregating | 16:44 |
| mrevell | bac I'll send it to pqm | 16:45 |
| mrevell | if I get rc from you bac | 16:45 |
| bac | mrevell: thanks | 16:45 |
| mrevell | heh | 16:45 |
| bac | mrevell: using your new dbsubmit alias | 16:45 |
| mrevell | thanks abc | 16:45 |
| mrevell | bac | 16:45 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: leonardr || queue: [] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| henninge | noodles775: oops, I was so preocupied with the ui issue that I didn't see your suggestions in the code. Seeing that this is r-c, I will not do too much here, though. | 16:58 |
| noodles775 | henninge: yep - np! | 16:59 |
| bac | henninge: re: your redirect patch. can you add a comment better nailing down what "old stable release" means? how long do we need to support it? hardy + 5 years? | 17:09 |
| rockstar | leonardr, r=me | 17:12 |
| henninge | danilos: ^^ | 17:12 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: - || queue: [] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| henninge | bac: AFAIUI it just changed in Karmic, so hardy +5 years would seem right. | 17:12 |
| danilos | bac: in general, we are not exactly sure what was the first release with these links, and how long do we want to support them | 17:13 |
| bac | danilos: normal releases only 2 years, as i understand. LTS for 5. that's why hardy+5 was my suggestion. | 17:13 |
| henninge | bac: but Karmic is mentioned in the test as the release where it changed, so anything before Karmic would be considered "old" then. | 17:14 |
| danilos | bac: yeah, I am not sure if we need to support dapper still, but hardy+5 is probably sane | 17:14 |
| danilos | of course, hardy+5 covers dapper+5 | 17:14 |
| bac | well dapper+5 < hardy+5 | 17:14 |
| bac | :) | 17:14 |
| danilos | also, 5 years is server only, but I'd definitely not try to determine when we can drop the support for these links now :) | 17:15 |
| bac | best would be to just leave the redirect in there for a good long while | 17:15 |
| danilos | bac: yep, but since it's an otherwise dead page, I wanted a comment in that would help us in the future determine if we can drop it | 17:15 |
| bac | ok | 17:15 |
| bac | henninge: so how about something to the effect of "This redirect must be supported for at least five years after the release of Hardy, which is 2013-04. Please consult with the XYZ team before removing." | 17:18 |
| henninge | bac: sounds great! | 17:19 |
| stub | Open a bug to remove the link, create a milestone for LP 10.0 and target it. | 17:19 |
| stub | (not serious) | 17:19 |
| bac | henninge: rc=bac conditional on submission via ec2 to db-devel | 17:20 |
| henninge | bac: thanks, it is already running through ec2. | 17:21 |
| bac | henninge: super! | 17:21 |
| henninge | bac: I have another one as you may have noticed ... | 17:28 |
| henninge | https://code.edge.launchpad.net/~henninge/launchpad/bug-435712/+merge/12347 | 17:28 |
| bac | henninge: ok | 17:28 |
| bac | will look soon | 17:28 |
| henninge | bac: thanks a lot | 17:29 |
| === cprov-lunch is now known as cprov | ||
| === matsubara is now known as matsubara-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === salgado is now known as salgado-lunch | ||
| cprov | sinzui: can you please take a quick look at https://code.edge.launchpad.net/~cprov/launchpad/bug-408528-ensurePerson-again/+merge/12356 ? | 18:09 |
| === ursula_ is now known as Ursinha | ||
| cprov | bac: the death-row fix is a 'go', worked fine in production. | 18:38 |
| === danilos is now known as danilo-afk | ||
| bac | cprov: will look now | 18:40 |
| cprov | bac: https://code.edge.launchpad.net/~cprov/+activereviews | 18:40 |
| cprov | err | 18:40 |
| cprov | https://code.edge.launchpad.net/~cprov/launchpad/bug-430552-unblock-death-row/+merge/12346 | 18:41 |
| bac | yep | 18:41 |
| === matsubara-lunch is now known as matsubara | ||
| cprov | bac: it's on pqm, thanks. | 18:51 |
| bac | cprov: thanks. please update CRB when it lands. put it under the re-roll section | 18:52 |
| === deryck[lunch] is now known as deryck | ||
| cprov | I wonder what PQM is doing during the 20 minutes it takes to process a request. | 19:06 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === ursula_ is now known as Ursinha | ||
| deryck | rockstar, ping | 19:38 |
| rockstar | deryck, hi | 19:38 |
| deryck | rockstar, I've got something to fix an oops that needs to go in. Can you look at it? One thing, though -- I have to leave in 5 minutes or so to pickup kids at school. | 19:39 |
| deryck | rockstar, so I'm asking for offline, while I'm away. | 19:39 |
| rockstar | deryck, cool. | 19:40 |
| deryck | rockstar, thanks! https://code.edge.launchpad.net/~deryck/launchpad/filebug-redirect-package-oops-435628/+merge/12366 | 19:41 |
| rockstar | deryck, that's actually really straightforward. | 19:42 |
| rockstar | deryck, r=me | 19:42 |
| deryck | yeah, I think so, too. | 19:43 |
| deryck | excellent, thanks! | 19:43 |
| rockstar | deryck, wait, why is it going to the tour? | 19:43 |
| rockstar | Is this the change to the bug filing policy I saw recently for Ubuntu? | 19:43 |
| deryck | rockstar, that's the test. earlier in the test, it sets the redirect url to the tour. I assume to make the test not hit network for a live URL. | 19:44 |
| rockstar | deryck, alright, that's fine. | 19:44 |
| deryck | cool | 19:45 |
| === salgado-lunch is now known as salgado | ||
| henninge | bac: the +translations redirect patch is about to land! | 20:07 |
| bac | excellent henninge. when it does will you move it to the re-roll section of CRB and note the revno? thanks. | 20:08 |
| henninge | bac: I will | 20:08 |
| kiko | bac, I'm seeing an issue with the homepage, where it misrendered /and/ the beta testers redirect is being displayed as a box instead of the inline ajax thing? | 20:14 |
| * bac looks | 20:15 | |
| bac | kiko: what kind of bad rendering? | 20:16 |
| bac | i don't see anything that looks off | 20:17 |
| kiko | the search box to the right hand side | 20:17 |
| kiko | blog posts to the left, search to the right | 20:17 |
| kiko | instead of search in the middle | 20:17 |
| kiko | bac, at any rate, there should be no beta testers redirect box up there -- it's in the footer everywhere | 20:17 |
| bac | kiko: i know it is in the footer for other pages. i don't know what the design intent for the front page was. barry can you explain? | 20:19 |
| bac | kiko: i'll agree its fugly | 20:19 |
| bac | beuno: you around? | 20:19 |
| * barry reads back | 20:19 | |
| kiko | beuno, please help | 20:19 |
| bac | beuno is probably on the floor at morpeth arms about now | 20:20 |
| barry | kiko, bac that's the design i was given by beuno | 20:20 |
| barry | kiko, bac as for the beta-box, i didn't touch that (wasn't part of the design change) | 20:21 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| bac | barry: so the search box is placed as intended | 20:21 |
| barry | bac: as beuno intended, yes | 20:21 |
| kiko | hmm, okay then | 20:22 |
| bac | i know noodles moved the beta message and disable to the footer for internal pages but don't know about killing off the beta box | 20:22 |
| bac | (sounds like sushi) | 20:22 |
| kiko | needs to happen :-) | 20:22 |
| barry | bac: i reviewed noodles' branch. iirc, it did not touch the beta-box on the home page, just added to the footer of internal pages | 20:23 |
| bac | barry: my recollection too | 20:23 |
| === cprov is now known as cprov-afk | ||
| bac | shall i open a bug 'kiko hates the beta box'? | 20:23 |
| barry | :) | 20:23 |
| kiko | the bug is "MARK hates the beta box" | 20:23 |
| kiko | and asked a month ago to get it gone | 20:23 |
| barry | kiko: mark hates > beuno loves | 20:24 |
| bac | oh, that's even better | 20:24 |
| bac | ok, will do | 20:24 |
| bac | kiko: bug 436124 | 20:29 |
| mup | Bug #436124: Beta user warning on Launchpad homepage needs to go away <Launchpad itself:New> <https://launchpad.net/bugs/436124> | 20:29 |
| kiko | thanks bac | 20:29 |
| bac | np | 20:30 |
| === kiko is now known as kiko-afk | ||
| beuno | kiko-afk, bac, hi | 20:48 |
| beuno | it does need to go away | 20:49 |
| flacoste | cprov-afk: it's running make build | 21:02 |
| barry | rockstar: ping | 21:08 |
| rockstar | barry, hi | 21:16 |
| barry | rockstar: do you have time to review a critical fix? | 21:16 |
| barry | rockstar: it's slightly over the 800 line limit but mostly because there's a big delete in there | 21:16 |
| rockstar | barry, only for you. | 21:17 |
| barry | rockstar: you have once again earned your nick | 21:17 |
| rockstar | :) | 21:17 |
| barry | sending the mp now :) | 21:17 |
| rockstar | barry, my new band is playing our first show on Halloween. | 21:17 |
| barry | very cool! and what are you going as? :) | 21:18 |
| rockstar | Well, the dressing up thing happens AFTER the set. :) | 21:19 |
| rockstar | Otherwise, I'd be going as "it's too hot from the lights to wear much of anything..." | 21:20 |
| barry | rockstar: oh, so you're going as the red hot chili peppers | 21:24 |
| rockstar | :) | 21:24 |
| * rockstar is glad his mental firewall silently dropped that last few proposed responses | 21:25 | |
| barry | rockstar: mp is sent. ping me if you have any questions about the test specifics. running the MailmanLayer tests are um, "fun" | 21:25 |
| rockstar | Oh man. You didn't tell me it was a Mailman fix. | 21:25 |
| barry | rockstar: gotta send me a link to the music when you have something. i'd love to hear it | 21:25 |
| rockstar | Deal is off, I can't review it. | 21:25 |
| rockstar | :) | 21:25 |
| barry | rockstar: not much mailman in there :) | 21:25 |
| barry | rockstar: mostly integration issues, but i'm here to answer any questions | 21:26 |
| barry | rockstar: those lint warnings are bogus. ignore 'em | 21:34 |
| rockstar | barry, so this was cowboyed into production already? | 21:35 |
| barry | rockstar: not that exact patch, but something very similar. this is cleaner | 21:36 |
| rockstar | barry, okay. | 21:37 |
| rockstar | barry, why the change from "Configure a mailing list" to "Create a mailing list" | 21:39 |
| barry | rockstar: the link text on the team index page has changed | 21:39 |
| rockstar | barry, was that part of the issue, or a "while I'm in here" change. | 21:40 |
| barry | rockstar: it was a 'while i'm here' change ;) | 21:40 |
| rockstar | barry, okay. | 21:40 |
| barry | rockstar: these tests are not run automatically (there's an open bug on that) so whenever i mess around in them i first try to get them running again | 21:40 |
| rockstar | barry, I don't have a problem with that, but I would think usually RC patches are the minimal to fix the "holy shits" | 21:41 |
| barry | rockstar: you might be right; i'll fight that out with bac :) | 21:41 |
| rockstar | I guess I've never thought about how much of our test suito is Mailman integration tests. | 21:42 |
| rockstar | + launchpad_top = os.path.dirname( | 21:43 |
| rockstar | + os.path.dirname(os.path.dirname(canonical.__file__))) | 21:43 |
| rockstar | barry, ^^ that's sub-optimal. | 21:43 |
| barry | rockstar: this is warsaw's extension to zawinksi's law | 21:43 |
| rockstar | Which is? | 21:43 |
| barry | rockstar: yeah. we need to get to the top of the tree | 21:43 |
| barry | rockstar: http://catb.org/jargon/html/Z/Zawinskis-Law.html | 21:44 |
| barry | “Every program attempts to expand until it can read mail. Those programs which cannot so expand are replaced by ones which can.” | 21:44 |
| rockstar | And your extension is? | 21:45 |
| rockstar | barry, have you run this through ec2? | 21:45 |
| barry | rockstar, essentially s/mail/mailman/ :) | 21:45 |
| rockstar | :) | 21:45 |
| barry | rockstar: no. it wouldn't help anyway because none of the MailmanLayer tests are run automatically | 21:45 |
| rockstar | barry, oh snap. | 21:46 |
| barry | rockstar: yeah. there's an open bug about adding them to a separate buildbot, but it hasn't been done yet | 21:46 |
| rockstar | barry, how confident are you that this patch isn't going to explode everything? | 21:46 |
| barry | rockstar: i'm pretty confident. the essential change is to add an import of _pythonpath to make sure it can find the eggs. everything else is inconsequential to production | 21:47 |
| rockstar | barry, okay, r=me | 21:47 |
| barry | rockstar: but don't worry, i will work closely with the losas to make sure its application goes smoothly | 21:47 |
| barry | rockstar: thanks! | 21:48 |
| rockstar | barry, you are welcome. | 21:48 |
| barry | bac: rc needed for https://code.edge.launchpad.net/~barry/launchpad/435604-mailman/+merge/12380 | 21:49 |
| bac | hi barry -- good timing. i just got back. | 21:49 |
| barry | bac: cool. rockstar just reviewed and approved it | 21:49 |
| bac | barry: are all of those lint message fake? | 21:54 |
| barry | bac: they are | 21:55 |
| barry | bac: they're doctest globals for convenience | 21:55 |
| bac | barry: i agree with rockstar that this fix should've been limited to a minimal change. that said i know you can't see a test without convert it to ReST | 22:01 |
| bac | but it does make sussing out the good parts hard | 22:01 |
| barry | bac: yeah | 22:01 |
| bac | but let's land this thing | 22:02 |
| barry | bac: against devel, db-devel, or ...? | 22:02 |
| bac | db-devel | 22:03 |
| barry | bac: okay. i'm submitting this straight to pqm since none of these tests are run by ec2 automatically | 22:03 |
| bac | barry: but you've run them locally, right? | 22:04 |
| barry | bac: lots :) | 22:04 |
| bac | great | 22:04 |
| bac | hey barry when you get a landing message would you update CRB and move it down to the 're-roll' section with the revno? | 22:05 |
| barry | bac: yepper! | 22:05 |
| rockstar | mwhudson, could you do a small review for me? | 22:07 |
| mwhudson | rockstar: sure! | 22:15 |
| rockstar | mwhudson, https://code.edge.launchpad.net/~rockstar/launchpad/fix-bmp-links/+merge/12384 | 22:16 |
| mwhudson | rockstar: after the standup i guess | 22:16 |
| mwhudson | rockstar: reviewed, that was easy :) | 22:31 |
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| === rockstar changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] (pqm is release-critical) || This channel is logged: http://irclogs.ubuntu.com/ || | ||
| === flacoste is now known as flacoste_afk | ||
| === Ursinha is now known as Ursinha-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!