[02:46] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/bmp-notification-recipients/+merge/12399
[02:53] <mwhudson> thumper: replied
[02:54] <thumper> mwhudson: ta
[04:23] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/log-diffstat-error-and-continue/+merge/12400
[04:28] <mwhudson> thumper: replied
[04:44] <thumper> mwhudson: thanks, updated
[04:45] <mwhudson> hm, not showing yet
[04:45] <mwhudson> mumble mumble message queues
[04:45] <thumper> :)
[09:22] <allenap> BjornT: Are you CHR today? If so, do you fancy reviewing a branch that'll make your life better? :) https://code.edge.launchpad.net/~allenap/launchpad/just-comment-on-question-bug-114710/+merge/12403
[09:27] <BjornT> allenap: indeed i am. i doubt that branch will be useful for me today, though, unless you plan to cowboy it to production :)
[09:28] <allenap> BjornT: I hoped you wouldn't realise that though ;)
[09:28] <BjornT> allenap: i'd rather not review such a big branch now, i want to get started with my CHR duties first. but maybe later
[09:28] <allenap> BjornT: Sure. I'll see if anyone else can be roped in then.
[09:29] <allenap> Actually, I'll wait for OCR later, that's probably less disruptive.
[09:30] <BjornT> allenap: btw, why did you change the case of all the buttons? i though those should be Headline Case? (https://dev.launchpad.net/UserInterfaceWording)
[09:36] <allenap> BjornT: Oh blast. There is a bit of a mix in LP at the moment, but that (headline) does seem to be the dominant form. Rats. Okay, I'll remove all that then!
[09:40] <allenap> BjornT: Thankfully that part I did with a sed script, so I only spent about 5 minutes doing it.
[11:22] <james_w> is requesting a review from ~lazr-developers not the thing to do?
[11:23] <james_w> https://code.edge.launchpad.net/~james-w/lazr.restful/lazr.restful.fix_test_suite/+merge/8559
[11:23] <james_w> https://code.edge.launchpad.net/~james-w/wadllib/fix-doctests/+merge/8476
[11:55] <allenap> james_w: I'll review those.
[11:56] <allenap> james_w: Both approved, thanks. Are you able to land those?
[12:21] <james_w> thanks allenap, I am not
[14:39] <allenap> salgado, barry: Fancy reviewing an answers branch? https://code.edge.launchpad.net/~allenap/launchpad/just-comment-on-question-bug-114710/+merge/12405
[14:40] <allenap> salgado, barry: Also, either of you up for a lazr.restful branch? https://code.edge.launchpad.net/~allenap/lazr.restful/james_w/+merge/12414
[14:41] <salgado> allenap, I can take the latter
[14:41] <salgado> barry, can you take the former?  if not I'll do it afterwards
[14:41] <allenap> salgado: Thanks.
[14:44] <barry> salgado, allenap i can do it
[14:44] <allenap> barry: Thanks.
[14:45] <barry> allenap: is this a release-critical branch?
[14:45] <allenap> barry: No, so put it aside if there's something more pressing to do.
[14:46] <barry> allenap: cool.  nothing yet, so i should be able to do it
[14:46] <allenap> barry: I think it'll be a quick one; very repetitive, nothing fancy.
[14:54] <allenap> james_w: I'm having trouble running the tests in wadllib. Is there any trick to it? They work fine in lazr.restful which appears to be similarly set up.
[14:57] <allenap> james_w: Hold that; my trunk seemed to have been pointing at the wrong thing.
[15:00] <james_w> I just ran setup.py test I think
[15:03] <allenap> james_w: I just commented on the mp for your fix-doctests branch. I think tests seem to run okay without it.
[15:04] <allenap> salgado: Thanks for the review.
[15:04] <james_w> I have a suspicion there may have been an alternate fix in the meantime now you mention it
[15:05] <james_w> it was definitely needed back when I proposed it
[15:06] <allenap> james_w: Yeah, I assumed as much. Cool. Thanks for the fix anyway :)
[15:09] <allenap> james_w: BTW, I tried to figure out how we missed the mp for so long. I think most of us use https://code.edge.launchpad.net/launchpad/+activereviews to discover reviews, but we should also look at https://code.edge.launchpad.net/lazr/+activereviews. I'll write to the list about it.
[15:09] <james_w> thanks
[15:18] <barry> allenap: any chance you have a screenshot of the changed answer page?
[15:20] <allenap> barry: I'll get one for you.
[15:20] <barry> allenap: great!  might as well get you a ui review while i'm at it :)
[15:22] <allenap> barry: http://people.canonical.com/~gavin/answers.png
[15:23] <allenap> barry: The only change is the addition of the Add Comment button I think, so not much to see :)
[15:23] <barry> allenap: right.  question: which do you think will be the most common action?
[15:23] <allenap> barry: Hopefully Add Answer, then Add Information.
[15:24] <allenap> s/Add Information/Add Information Request/
[15:28] <barry> allenap: do you think the buttons should be ordered from most common to least common action?
[15:29] <allenap> barry: I think they should be ordered from most "disruptive" to least. If someone adds a comment, they can always go and change the status, and the result is similar to pressing one of the other buttons...
[15:30] <allenap> barry: The same argument could be used to say that we should encourage the workflow to move forwards, so make "Add Answer" or "Add Information Request" more prominent, because the user can always go an set the status back.
[15:31] <barry> allenap: that's what i'm thinking.  we want to encourage people to answer the question, and putting 'Add Answer' first subtly sends that message
[15:31] <barry> allenap: so i think: Add Answer, Add Information Request, Add Comment
[15:31] <allenap> barry: However, the reason I want the "Add Comment" button is to prevent that flip-flopping.
[15:31] <barry> allenap: that would be my thought anyway
[15:32] <barry> allenap: the middle one will probably always be the least chosen button
[15:32] <allenap> barry: That's a good reason. I'm happy to change it.
[15:32] <barry> allenap: cool.  final question...
[15:33] <barry> allenap: do you think people will understand the difference between 'add answer' and 'add information request'?
[15:33] <barry> allenap: iow, do we need a legend or a (?) help popup?
[15:35] <allenap> barry: Yeah, it could do with a reference. I'm reluctant to actually do it though, because I've already spent far more time on this branch that I ought to have done :)
[15:36] <barry> allenap: :)  cool.  i'll mention it in my review but let's let users file a bug if they find it confusing :)
[15:36] <allenap> barry: I like the cut of your jib :)
[15:37] <barry> my jib likes it too! :)
[15:39] <barry> allenap: r=me
[15:39] <allenap> barry: Thanks :)
[15:40] <barry> allenap: my future chr'ing self thanks you!
[16:22] <bac> hi salgadoor barry:  https://code.edge.launchpad.net/~bac/launchpad/retest/+merge/12421 for review at your convenience
[16:22] <bac> uh, salgado -or- barry
[16:25] <bac> hi allenap
[16:29] <barry> bac: i can do it
[16:29] <bac> barry: thanks
[16:30] <barry> bac: omg, you are my best friend :)
[16:30] <bac> it's pretty simple but someone had to do it
[16:38] <barry> bac: review sent
[16:38] <bac> thanks
[16:39] <bac> nice comments barry
[16:39] <bac> it's hard converting a hacked up script into something others will see without missing a few things
[16:47] <barry> bac: no worries!
[20:34] <kiko> james_w, have I missed you?
[20:34] <kiko> I wanted to ask you why the bzr-nightly-ppa doesn't have karmic uploads -- any reason?
[20:45] <james_w> kiko: stupidity
[20:45] <kiko> james_w, heh, mark was asking me about it today and I thought it was just an oversight
[20:45] <james_w> yeah
[20:46] <james_w> I'd written the recipes, just not actually included them
[20:46] <kiko> james_w, heh, okay then :)
[20:46] <james_w> fixed and triggered
[20:47] <james_w> thanks to you and Mark
[21:00] <kiko> james_w, awesome man
[21:00] <kiko> :-)
[21:43] <EdwinGrubbs2> salgado, barry: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-436229-distroseries-page-titles/+merge/12439
[21:44] <salgado> barry, can you take this one?  I'm helping Danny with a shipit branch right now...
[21:47] <barry> i can
[22:03] <barry> EdwinGrubbs: r=me
[22:03] <EdwinGrubbs> barry: thanks
[22:04] <EdwinGrubbs> barry: oh, I assume that I don't get an easy ui=rs now that the rollout has passed and this isn't really an RC candidate.
[22:05] <barry> EdwinGrubbs: i think that's right.  i gave you a ui=me* and afaik the policy is that you need two ui reviews again.  i'm actually not sure though, so we should talk to beuno about
[22:06] <EdwinGrubbs> barry: ok, I'll track someone down to do the secondary review if I can't find beuno.
[22:06] <EdwinGrubbs> beuno: ping
[22:34] <EdwinGrubbs> rockstar: ping
[22:36] <rockstar> EdwinGrubbs, hi.
[22:37] <rockstar> EdwinGrubbs, it looks like you need a ui-review.  Can I do that for you? </paperclip>
[22:37] <EdwinGrubbs> rockstar: can you do an easy secondary ui review, yes, that's the one.
[22:37] <EdwinGrubbs> rockstar: are you trying to be clippy?
[22:38] <rockstar> EdwinGrubbs, something like that.  :)
[22:38] <rockstar> EdwinGrubbs, link to screenshot and MP?
[22:38] <EdwinGrubbs> rockstar: I think you need to reduce your helpfullness to do it right.
[22:38] <EdwinGrubbs> rockstar: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-436229-distroseries-page-titles/+merge/12439
[22:39] <rockstar> :)
[22:39] <EdwinGrubbs> rockstar: sorry, I don't have screenshots, but I have direct links to the four pages whose <title> and <h1> have slight changes.
[22:40] <rockstar> EdwinGrubbs, okay.  It's usually faster when I have screenshots, as I don't  actually have to run your branch.  Just a note.
[22:52] <EdwinGrubbs> abentley: Here is the branch with a working return value in javascript: lp:~edwin-grubbs/launchpad/bmp-inline
[22:53] <EdwinGrubbs> abentley: I don't know if you need the date_created off of the IMessage, but that is also not exported. ugh.
[22:53] <abentley> EdwinGrubbs: Thanks!
[22:54] <EdwinGrubbs> rockstar: I have to go offline for about ten minutes to drive home.
[23:14] <EdwinGrubbs2> rockstar: I'm back. Any questions for me?
[23:14] <rockstar> EdwinGrubbs, nope, r=me