| === jamalta-afk is now known as jamalta | ||
| rockstar | mwhudson, going to find dinner, will be back to handle any more reviews in just a bit. | 00:30 |
|---|---|---|
| mwhudson | rockstar: i think i'm done with the trivial stuff for now, thanks | 00:30 |
| === abentley1 is now known as abentley | ||
| al-maisan | Good morning! | 06:42 |
| === abentley1 is now known as abentley | ||
| === abentley1 is now known as abentley | ||
| === Ursinha is now known as Guest94977 | ||
| === ursula is now known as Guest88648 | ||
| === Ursinha is now known as Ursinha-sprint | ||
| stub | Trivial review needed to close a 4 digit bug: https://code.edge.launchpad.net/~stub/launchpad/bug-3050/+merge/12977 | 10:11 |
| jml | stub, already done. | 10:11 |
| stub | jml: Just saw that :) ec2test already run so its just pqm submit for this one. | 10:12 |
| jml | stub, ok, thanks. | 10:12 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === henninge is now known as henninge-sprint | ||
| stub | jtv: np. Do you need me to land any of my branch or are you still going to be working with 8.3 for the time being? | 11:42 |
| jtv | stub: No need; I left the issues that your branch resolves untouched, and that avoids any conflicts. | 12:00 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | Hi allenap - a really easy one for you: https://code.launchpad.net/~michael.nelson/launchpad/add-soyuz-windmill-layer/+merge/12983 | 12:01 |
| noodles775 | (well, short :) ). | 12:01 |
| allenap | noodles775: On it :) | 12:02 |
| noodles775 | Thanks! | 12:02 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [EdwinGrubbs] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | noodles775: r=me | 12:03 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | Thanks again :) | 12:04 |
| allenap | noodles775: Heh, you're welcome :) | 12:04 |
| === Ursinha-sprint is now known as Ursinha-nom | ||
| BjornT | noodles775, allenap: i have some remarks on that last review | 12:28 |
| noodles775 | BjornT: yep? | 12:28 |
| BjornT | noodles775: why did you change jstest.in? | 12:28 |
| noodles775 | BjornT: because I moved the old functional test to lp.soyuz.windmill, so I assumed (perhaps wrongly) that the change in jstest.in was required? | 12:29 |
| BjornT | noodles775: or rather, why did you bother to move the old-style test? | 12:29 |
| noodles775 | BjornT: because that seems to be what all the other apps had done? | 12:29 |
| noodles775 | s/had/have | 12:29 |
| BjornT | noodles775: well, yes. but you should also convert it, which requires it to be moved to another location again | 12:30 |
| noodles775 | BjornT: yes, but it's dependent on a registry base class to test the inlineeditor, and I didn't have time to update that now, so I just did what all the other apps had done. | 12:30 |
| BjornT | noodles775: i still think it's easy to convert that one. might not be the best solution, but should be enough for now | 12:32 |
| === mrevell is now known as mrevell-lunch | ||
| noodles775 | BjornT: great, thanks. | 12:33 |
| BjornT | noodles775: have you tested to create a test that creates a widgets.InlineEditorWidgetTest instances, and calls it? | 12:33 |
| noodles775 | BjornT: I did not look at updating that test at all - as I assumed that I'd need to update the InlineEditorWidgetTest itself (which would affect lots of other tests). | 12:34 |
| noodles775 | But your idea would be much simpler. | 12:35 |
| BjornT | noodles775: please try it. if it works, it's not much work at all. to be extra clear, i meant something like this: http://pastebin.ubuntu.com/287744/ | 12:37 |
| noodles775 | BjornT: Great - will do (after finishing my current MP) :) | 12:38 |
| === mrevell-lunch is now known as mrevell | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | just off to lunch, but in case you get time allenap : https://code.launchpad.net/~michael.nelson/launchpad/436182-newlines-in-sources-fix-without-workaround/+merge/12988 | 13:22 |
| noodles775 | tia! | 13:22 |
| allenap | noodles775: Okay. | 13:22 |
| === Ursinha-nom is now known as Ursinha | ||
| leonardr | allenap, can you add me to the queue? https://code.edge.launchpad.net/~leonardr/lazr.authentication/initial-implementation/+merge/12989 | 13:28 |
| allenap | leonardr: Sure. | 13:28 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr] || This channel is logged: http://irclogs.ubuntu.com | ||
| leonardr | allenap, i have two more branches that go along with that one. a lazr.restful branch and a lazr.restfulclient branch | 14:01 |
| leonardr | https://code.edge.launchpad.net/~leonardr/lazr.restful/remove-authentication/+merge/12991 and https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/use-lazr-authentication/+merge/12990 respectively | 14:01 |
| leonardr | if it gets confusing, let me know | 14:01 |
| allenap | leonardr: Gah! Okay, I'll try to get to them :) | 14:01 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr*3] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | hi jml | 14:04 |
| jml | bac, hello | 14:06 |
| bac | jml yesterday i fiddled with ec2 land a bit. i made it figure out where the MP is based on the public branch. would you care to look at the changes as a "mid-implementation"? | 14:07 |
| jml | bac, yeah, I'd love to. | 14:08 |
| adeuring | allenap: can I add myself to your review queue? | 14:09 |
| adeuring | https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-1/+merge/12992 | 14:09 |
| jml | bac, I'm on a call right now, and I'm going to help vds with some trial stuff later. | 14:09 |
| allenap | adeuring: It's getting pretty busy, but I'll try. | 14:09 |
| bac | jml: whenever you can get to it. no rush. | 14:09 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr*3, adeuring] || This channel is logged: http://irclogs.ubuntu.com | ||
| adeuring | allenap: thanks! | 14:09 |
| jml | bac, cool, thanks. | 14:09 |
| bac | jml: http://pastebin.ubuntu.com/287803/ | 14:12 |
| bac | jml: lp:~bac/launchpad/gmp | 14:12 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [leonardr*3, adeuring] || This channel is logged: http://irclogs.ubuntu.com | ||
| === barry is now known as barry_ | ||
| === barry_ is now known as barry | ||
| noodles775 | BjornT: so http://pastebin.ubuntu.com/287819/ worked perfectly. Thanks! | 14:45 |
| BjornT | noodles775: cool! | 14:49 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: leonardr || queue: [leonardr*2, adeuring] || This channel is logged: http://irclogs.ubuntu.com | ||
| === abentley1 is now known as abentley | ||
| === ursula is now known as Guest82960 | ||
| === Guest82960 is now known as Ursinha | ||
| === gary_poster is now known as gary-phone | ||
| === matsubara is now known as matsubara-lunch | ||
| === beuno is now known as beuno-lunch | ||
| === deryck is now known as deryck[lunch] | ||
| === EdwinGrubbs is now known as Edwin-afk | ||
| === gary-phone is now known as gary_poster | ||
| jml | bac, you still around? | 17:14 |
| allenap | leonardr: In lp:~leonardr/lazr.authentication/initial-implementation, revision 47, it looks like you moved the code from src/lazr/authentication/__init__.py to wsgi.py, but didn't add wsgi.py to the branch. Is that right? | 17:21 |
| leonardr | let's see... | 17:21 |
| leonardr | yes, indeed | 17:22 |
| leonardr | pushing a new version now | 17:22 |
| allenap | leonardr: Cool :) | 17:22 |
| leonardr | allenap: pushed | 17:22 |
| === beuno-lunch is now known as beuno | ||
| === matsubara-lunch is now known as matsubara | ||
| === allenap changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | adeuring: I'm really sorry, I didn't get to your branch. | 18:03 |
| adeuring | allenap: no problem. I must admit that I found some quirks in the branch anyway. Fixing them at present... | 18:04 |
| allenap | adeuring: Ah, just as well then :) Have a good evening. | 18:04 |
| === deryck[lunch] is now known as deryck | ||
| leonardr | deryck, maybe you want to review my forward-port of intellectronica's branch? https://code.edge.launchpad.net/~leonardr/lazr.restful/forward-port/+merge/13009 | 18:16 |
| deryck | leonardr, sure, looking in 2 minutes. | 18:16 |
| leonardr | ok | 18:17 |
| intellectronica | leonardr: your diff contains lots of unrelated stuff | 18:21 |
| leonardr | intellectronica: i merged with another branch i did this morning because i wanted to have a unified NEWS file. i'll give you a clean diff | 18:22 |
| leonardr | intellectronica, deryck: https://pastebin.canonical.com/23066/ | 18:23 |
| intellectronica | looks fine to me | 18:23 |
| deryck | leonardr, looks good to me, too. | 18:24 |
| leonardr | all right, i'll land it after my prerequisite branches land | 18:25 |
| intellectronica | leonardr: thanks for taking care of this | 18:25 |
| deryck | leonardr, indeed, thanks so much! | 18:26 |
| leonardr | don't get excited yet :) i haven't figured out the launchpad side of things | 18:27 |
| deryck | heh | 18:27 |
| bac | hi jml | 18:34 |
| === abentley1 is now known as abentley | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: EdwinGrubbs || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| leonardr | gary, care to review https://code.edge.launchpad.net/~leonardr/lazr.restful/work-on-2.4/+merge/13015 ? | 19:57 |
| gary_poster | leonardr: sure :-) | 19:58 |
| leonardr | gary, confirmed that it still works with 2.6 | 20:06 |
| gary_poster | leonardr: great. r=gary | 20:06 |
| leonardr | gary: who do i need to talk to to get launchpad to pick up the new version? | 20:14 |
| leonardr | gary: sorry, i typed that and then did research myself | 20:14 |
| gary_poster | leonardr: heh, yeah, cool. someone with commit privs. can I answer any questions? It should be pretty easy. | 20:15 |
| leonardr | it looks like i need to do a launchpad branch | 20:15 |
| gary_poster | yes | 20:15 |
| leonardr | i'll follow the instructions and see how far i get--i'll probably finish tomorrow | 20:15 |
| gary_poster | leonardr: cool. I hope to leave RSN myself | 20:16 |
| === abentley1 is now known as abentley | ||
| === abentley1 is now known as abentley | ||
| === jamalta is now known as jamalta-afk | ||
| bac | hi EdwinGrubbs -- time for a 213 line MP? | 21:52 |
| EdwinGrubbs | bac: sure | 21:52 |
| bac | EdwinGrubbs: ok. i just sent it. i'll paste here when it arrives | 21:52 |
| bac | EdwinGrubbs: https://code.edge.launchpad.net/~bac/launchpad/bug-341935-captcha/+merge/13022 | 21:58 |
| EdwinGrubbs | bac: review sent | 23:11 |
| === matsubara is now known as matsubara-afk | ||
| === sinzui changed the topic of #launchpad-reviews to: on call: EdwinGrubbs || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | thanks EdwinGrubbs | 23:49 |
| bac | EdwinGrubbs: that was indeed a typo | 23:49 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!