=== jamalta-afk is now known as jamalta [00:30] mwhudson, going to find dinner, will be back to handle any more reviews in just a bit. [00:30] rockstar: i think i'm done with the trivial stuff for now, thanks === abentley1 is now known as abentley [06:42] Good morning! === abentley1 is now known as abentley === abentley1 is now known as abentley === Ursinha is now known as Guest94977 === ursula is now known as Guest88648 === Ursinha is now known as Ursinha-sprint [10:11] Trivial review needed to close a 4 digit bug: https://code.edge.launchpad.net/~stub/launchpad/bug-3050/+merge/12977 [10:11] stub, already done. [10:12] jml: Just saw that :) ec2test already run so its just pqm submit for this one. [10:12] stub, ok, thanks. === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com === henninge is now known as henninge-sprint [11:42] jtv: np. Do you need me to land any of my branch or are you still going to be working with 8.3 for the time being? [12:00] stub: No need; I left the issues that your branch resolves untouched, and that avoids any conflicts. === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com [12:01] Hi allenap - a really easy one for you: https://code.launchpad.net/~michael.nelson/launchpad/add-soyuz-windmill-layer/+merge/12983 [12:01] (well, short :) ). [12:02] noodles775: On it :) [12:02] Thanks! === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [EdwinGrubbs] || This channel is logged: http://irclogs.ubuntu.com [12:03] noodles775: r=me === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [] || This channel is logged: http://irclogs.ubuntu.com [12:04] Thanks again :) [12:04] noodles775: Heh, you're welcome :) === Ursinha-sprint is now known as Ursinha-nom [12:28] noodles775, allenap: i have some remarks on that last review [12:28] BjornT: yep? [12:28] noodles775: why did you change jstest.in? [12:29] BjornT: because I moved the old functional test to lp.soyuz.windmill, so I assumed (perhaps wrongly) that the change in jstest.in was required? [12:29] noodles775: or rather, why did you bother to move the old-style test? [12:29] BjornT: because that seems to be what all the other apps had done? [12:29] s/had/have [12:30] noodles775: well, yes. but you should also convert it, which requires it to be moved to another location again [12:30] BjornT: yes, but it's dependent on a registry base class to test the inlineeditor, and I didn't have time to update that now, so I just did what all the other apps had done. [12:32] noodles775: i still think it's easy to convert that one. might not be the best solution, but should be enough for now === mrevell is now known as mrevell-lunch [12:33] BjornT: great, thanks. [12:33] noodles775: have you tested to create a test that creates a widgets.InlineEditorWidgetTest instances, and calls it? [12:34] BjornT: I did not look at updating that test at all - as I assumed that I'd need to update the InlineEditorWidgetTest itself (which would affect lots of other tests). [12:35] But your idea would be much simpler. [12:37] noodles775: please try it. if it works, it's not much work at all. to be extra clear, i meant something like this: http://pastebin.ubuntu.com/287744/ [12:38] BjornT: Great - will do (after finishing my current MP) :) === mrevell-lunch is now known as mrevell === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com [13:22] just off to lunch, but in case you get time allenap : https://code.launchpad.net/~michael.nelson/launchpad/436182-newlines-in-sources-fix-without-workaround/+merge/12988 [13:22] tia! [13:22] noodles775: Okay. === Ursinha-nom is now known as Ursinha [13:28] allenap, can you add me to the queue? https://code.edge.launchpad.net/~leonardr/lazr.authentication/initial-implementation/+merge/12989 [13:28] leonardr: Sure. === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr] || This channel is logged: http://irclogs.ubuntu.com [14:01] allenap, i have two more branches that go along with that one. a lazr.restful branch and a lazr.restfulclient branch [14:01] https://code.edge.launchpad.net/~leonardr/lazr.restful/remove-authentication/+merge/12991 and https://code.edge.launchpad.net/~leonardr/lazr.restfulclient/use-lazr-authentication/+merge/12990 respectively [14:01] if it gets confusing, let me know [14:01] leonardr: Gah! Okay, I'll try to get to them :) === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr*3] || This channel is logged: http://irclogs.ubuntu.com [14:04] hi jml [14:06] bac, hello [14:07] jml yesterday i fiddled with ec2 land a bit. i made it figure out where the MP is based on the public branch. would you care to look at the changes as a "mid-implementation"? [14:08] bac, yeah, I'd love to. [14:09] allenap: can I add myself to your review queue? [14:09] https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-1/+merge/12992 [14:09] bac, I'm on a call right now, and I'm going to help vds with some trial stuff later. [14:09] adeuring: It's getting pretty busy, but I'll try. [14:09] jml: whenever you can get to it. no rush. === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: EdwinGrubbs || queue: [noodles, leonardr*3, adeuring] || This channel is logged: http://irclogs.ubuntu.com [14:09] allenap: thanks! [14:09] bac, cool, thanks. [14:12] jml: http://pastebin.ubuntu.com/287803/ [14:12] jml: lp:~bac/launchpad/gmp === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [leonardr*3, adeuring] || This channel is logged: http://irclogs.ubuntu.com === barry is now known as barry_ === barry_ is now known as barry [14:45] BjornT: so http://pastebin.ubuntu.com/287819/ worked perfectly. Thanks! [14:49] noodles775: cool! === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: leonardr || queue: [leonardr*2, adeuring] || This channel is logged: http://irclogs.ubuntu.com === abentley1 is now known as abentley === ursula is now known as Guest82960 === Guest82960 is now known as Ursinha === gary_poster is now known as gary-phone === matsubara is now known as matsubara-lunch === beuno is now known as beuno-lunch === deryck is now known as deryck[lunch] === EdwinGrubbs is now known as Edwin-afk === gary-phone is now known as gary_poster [17:14] bac, you still around? [17:21] leonardr: In lp:~leonardr/lazr.authentication/initial-implementation, revision 47, it looks like you moved the code from src/lazr/authentication/__init__.py to wsgi.py, but didn't add wsgi.py to the branch. Is that right? [17:21] let's see... [17:22] yes, indeed [17:22] pushing a new version now [17:22] leonardr: Cool :) [17:22] allenap: pushed === beuno-lunch is now known as beuno === matsubara-lunch is now known as matsubara === allenap changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [18:03] adeuring: I'm really sorry, I didn't get to your branch. [18:04] allenap: no problem. I must admit that I found some quirks in the branch anyway. Fixing them at present... [18:04] adeuring: Ah, just as well then :) Have a good evening. === deryck[lunch] is now known as deryck [18:16] deryck, maybe you want to review my forward-port of intellectronica's branch? https://code.edge.launchpad.net/~leonardr/lazr.restful/forward-port/+merge/13009 [18:16] leonardr, sure, looking in 2 minutes. [18:17] ok [18:21] leonardr: your diff contains lots of unrelated stuff [18:22] intellectronica: i merged with another branch i did this morning because i wanted to have a unified NEWS file. i'll give you a clean diff [18:23] intellectronica, deryck: https://pastebin.canonical.com/23066/ [18:23] looks fine to me [18:24] leonardr, looks good to me, too. [18:25] all right, i'll land it after my prerequisite branches land [18:25] leonardr: thanks for taking care of this [18:26] leonardr, indeed, thanks so much! [18:27] don't get excited yet :) i haven't figured out the launchpad side of things [18:27] heh [18:34] hi jml === abentley1 is now known as abentley === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: EdwinGrubbs || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [19:57] gary, care to review https://code.edge.launchpad.net/~leonardr/lazr.restful/work-on-2.4/+merge/13015 ? [19:58] leonardr: sure :-) [20:06] gary, confirmed that it still works with 2.6 [20:06] leonardr: great. r=gary [20:14] gary: who do i need to talk to to get launchpad to pick up the new version? [20:14] gary: sorry, i typed that and then did research myself [20:15] leonardr: heh, yeah, cool. someone with commit privs. can I answer any questions? It should be pretty easy. [20:15] it looks like i need to do a launchpad branch [20:15] yes [20:15] i'll follow the instructions and see how far i get--i'll probably finish tomorrow [20:16] leonardr: cool. I hope to leave RSN myself === abentley1 is now known as abentley === abentley1 is now known as abentley === jamalta is now known as jamalta-afk [21:52] hi EdwinGrubbs -- time for a 213 line MP? [21:52] bac: sure [21:52] EdwinGrubbs: ok. i just sent it. i'll paste here when it arrives [21:58] EdwinGrubbs: https://code.edge.launchpad.net/~bac/launchpad/bug-341935-captcha/+merge/13022 [23:11] bac: review sent === matsubara is now known as matsubara-afk === sinzui changed the topic of #launchpad-reviews to: on call: EdwinGrubbs || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com [23:49] thanks EdwinGrubbs [23:49] EdwinGrubbs: that was indeed a typo