| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com | ||
| nhandler | I wanted to try my hands at patching a few bugs in LP. Following https://dev.launchpad.net/PatchSubmission, I am coming here first to discuss it prior to beginning work. I was thinking about trying to fix Bug #296469 | 01:26 |
|---|---|---|
| mup | Bug #296469: "to describe the type of review your doing" on merge proposal submit form <code-review> <trivial> <ui> <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/296469> | 01:26 |
| sinzui | hi nhandler | 01:54 |
| rockstar | hi nhandler | 01:56 |
| nhandler | Hell sinzui and rockstar. I think the bug looks pretty straight forward. Other than the stuff outlined in the dev wiki, is there anything special that I need to do prior to beginning work on it? | 02:04 |
| rockstar | nhandler, It's a pretty straightforward patch. If you get stuck, just ping me, I'd be happy to help. | 02:05 |
| sinzui | nhandler: This text change may no have a test. We do not normally test for grammar | 02:05 |
| nhandler | Ok. I'll follow the steps on the wiki and see how far I can get. So far, I've managed to get a working copy of LP on my local machine without any difficulty | 02:06 |
| nhandler | Who would be the project lead (for the contributor agreement) ? | 02:07 |
| sinzui | hmm | 02:08 |
| sinzui | nhandler: flacoste is the acting lead | 02:08 |
| sinzui | Francis Lacoste | 02:08 |
| nhandler | Thanks | 02:08 |
| sinzui | nhandler: I just searched for part of the text fragment. Looks like you want to edit lp/code/interfaces/codereviewvote.py | 02:09 |
| nhandler | Thanks sinzui. I was just about to do a grep for that string ;) | 02:09 |
| nhandler | Does flacoste have an email address I should use? There is no email address on launchpad.net/~flacoste (but there is a gmail account listed under Jabber) | 02:10 |
| sinzui | hmm | 02:16 |
| mwhudson | i guess it's not a state secret that firstname.lastname@canonical.com works pretty well ? | 02:44 |
| === abentley1 is now known as abentley | ||
| rockstar | mwhudson, yeah, I was just about to mention that. | 02:45 |
| sinzui | mwhudson: yes. I used private message | 02:46 |
| mwhudson | sinzui: ah, cool | 02:46 |
| rockstar | Although it does reveal that people don't know where to send contributor agreements. | 02:46 |
| nhandler | mwhudson: I wasn't sure if they wanted mail sent to their @canonical.com address. I usually try and use whatever address people specify on their LP page | 02:47 |
| mwhudson | oh | 02:47 |
| mwhudson | nhandler: have you seen this page yet? http://www.canonical.com/contributors | 02:47 |
| nhandler | mwhudson: Yes. That is why I was asking about the project lead. Reading it again, it looks like I completely missed the table at the bottom (which should also be updated to reflect the new name of the Ubuntu Software store and to only list 1 irc nick for David Barth) | 02:50 |
| nhandler | Would someone here be willing to review the merge request (I need a name for the merge proposal according to https://dev.launchpad.net/PatchSubmission) | 02:52 |
| mwhudson | nhandler: sure | 02:53 |
| nhandler | Thanks mwhudson | 02:54 |
| === jamalta-afk is now known as jamalta | ||
| nhandler | I'm working on the Demo and Q/A section of the cover letter. Unless I missed something, I do not remember seeing any mention of Sample Person (test@canonical.com:test) up until now. I saw the admin@canonical.com account, but never test@. It might be a good idea to mention this account on one of the other pages | 03:19 |
| nhandler | And is there a package I was meant to install for the restful module? I'm getting a few warnings about 'No module named restful' from make lint | 03:23 |
| mwhudson | nhandler: not necessarily, that might just be pylint being stupid | 03:26 |
| nhandler | mwhudson: So should I just ignore the warnings this time? | 03:27 |
| sinzui | ignore it | 03:27 |
| nhandler | It might also be a good idea to demonstrate enclosing the diff in triple-braces in the diff section of the DetailedCoverLetterTemplate wiki page | 03:28 |
| nhandler | Just to make sure that people use the correct format | 03:28 |
| sinzui | There are several lazr.* false warnings | 03:28 |
| nhandler | Should the cover letter go to the launchpad-dev mailing list? The wiki did not mention an address to send it to | 03:48 |
| mwhudson | nhandler: it should go into the merge proposal | 03:51 |
| nhandler | mwhudson: Alright thanks. I just submitted the merge proposal (https://code.launchpad.net/~nhandler/launchpad/bugfix296469/+merge/13034). Hopefully, everything is correct. | 04:00 |
| mwhudson | nhandler: unfortunately life is never easy :/ | 04:37 |
| nhandler | mwhudson: Very true. Although, preparing that patch and merge request was not too bad. | 04:42 |
| mwhudson | nhandler: the problem is you've change the text on the page where you do a review too | 04:43 |
| mwhudson | nhandler: review sent | 04:47 |
| nhandler | Thanks for the review mwhudson. I'll see what I can do. | 04:49 |
| mwhudson | nhandler: i forgot to thank you for your contribution! | 04:49 |
| mwhudson | that's remiss of me | 04:49 |
| mwhudson | nhandler: thank you for helping to make launchpad better! | 04:49 |
| nhandler | You are welcome. Thank you for taking the time to help me (and other people) through the process ;) | 04:50 |
| mwhudson | nhandler: no problem at all! | 04:57 |
| === ursula is now known as Guest12181 | ||
| === Guest12181 is now known as Ursinha | ||
| === ursula is now known as Guest26488 | ||
| === ursula_ is now known as Guest91305 | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com | ||
| adeuring | noodles775: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-1/+merge/13051 ? | 09:41 |
| noodles775 | adeuring: sure - just in a standup, but will start it straight after. | 09:41 |
| adeuring | noodles775: thanks! | 09:41 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: - || queue: [sinzui, adeuring] || This channel is logged: http://irclogs.ubuntu.com | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: adeuring || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | adeuring: I'm trying to merge your branch but get: $ bzr pull lp:~adeuring/launchpad/hwdb-class-udev-device-1 | 10:22 |
| noodles775 | bzr: ERROR: These branches have diverged. Use the missing command to see how. | 10:22 |
| noodles775 | Use the merge command to reconcile them. | 10:22 |
| adeuring | noodles775: interesting... | 10:23 |
| adeuring | noodles775: let me merge trunk | 10:24 |
| noodles775 | adeuring: in case it helps: http://pastebin.ubuntu.com/288466/ | 10:24 |
| adeuring | noodles775: odd... I can't reproduce the errors you are seeing.... | 10:28 |
| noodles775 | adeuring: did you try merging your branch into a new rf branch? | 10:28 |
| adeuring | noodles775: ah, let me try | 10:29 |
| adeuring | noodles775: that work too for me... | 10:30 |
| adeuring | noodles775: ah, could you try "bzr merge" instead of "bzr pull"? | 10:37 |
| noodles775 | adeuring: gar, sorry - I'd just pulled devel :/ | 10:37 |
| adeuring | noodles775: "bzr branch lp:~adeuring/launchpad/... review-branch" works also quite fast for me | 10:39 |
| noodles775 | yes, my mistake... sorry. | 10:43 |
| noodles775 | mrevell: shoot :) | 11:31 |
| mrevell | noodles775: https://code.edge.launchpad.net/~matthew.revell/launchpad/status-link/+merge/13054 | 11:33 |
| mrevell | :) | 11:33 |
| * noodles775 waits for the branch to be scanned... | 11:35 | |
| mrevell | tis there now noodles775 | 11:36 |
| noodles775 | mrevell: r=me,ui=me. | 11:41 |
| mrevell | thanks noodles775 | 11:42 |
| noodles775 | adeuring: is it really necessary to be patching class methods in _setupUdevConsistencyCheckTests()? | 11:54 |
| adeuring | noodles775: that is a pattern I used elsewhere too in that file. The advanatge is that you don't need to setup more or less complex or convoluted test data. | 11:55 |
| adeuring | noodles775: the method checkConsistentUdevDeviceData() will be extended in future branches | 11:57 |
| noodles775 | adeuring: I'm all for using fakes/doubles/stubs/mocks, but not by manually patching object methods like that... | 11:58 |
| noodles775 | it looks scary ;) | 11:59 |
| adeuring | noodles775: what would you suggest instead? | 11:59 |
| noodles775 | adeuring: ideally I'd like us to have a standard helper library for that type of thing (actually, from memory stub added one a while back?) | 12:00 |
| adeuring | noodles775: really? any idea where I can find it? | 12:01 |
| noodles775 | adeuring: No, I'm hoping stub might remember - but if not, in this case, the sample data required doesnt' look too tedious? | 12:02 |
| * noodles775 looks a bit closer. | 12:02 | |
| stub | mocker was added to the buildout config | 12:02 |
| noodles775 | Thanks stub. | 12:02 |
| adeuring | stub: thanks | 12:02 |
| adeuring | noodles775: the point is that checkConsistentUdevDeviceData() will in the future call at least two more methods, and setting up data that lets one of these clled methods fail will become tedious | 12:05 |
| noodles775 | adeuring: right. So that's exactly where mocker should be able to help right? I'm just checking for exactly what we need here. | 12:06 |
| adeuring | noodles775: I couldn't find yet stub's mocker ... | 12:07 |
| noodles775 | "Mocking via temporary patching of existent classes and instances." | 12:07 |
| noodles775 | From http://labix.org/mocker | 12:07 |
| * noodles775 checks the branch - I'm not sure that anyone has actually used in in LP yet - it was added after a discussion around this exact issue. | 12:08 | |
| stub | eggs/mocker-0.10.1-py2.4.egg for the source | 12:08 |
| === nhandler_ is now known as nhandler | ||
| BjornT | noodles775, adeuring: i don't see a reason for using mocker to do that. can't you simply subclass SubmissionParser and override the methods in the new class? | 12:11 |
| adeuring | BjornT: nice idea, thanks! | 12:11 |
| noodles775 | BjornT: yep - that sounds like a good option. | 12:11 |
| BjornT | adeuring, noodles775: that's what we do elsewhere, for example when testing ExternalBugTracker | 12:13 |
| noodles775 | BjornT: although it's happening *lots* in adeurings file - and creating separate classes for all the different examples used in the test could be overkill? (using mocker, it would be just setting up the results you want from your proxied object, like this: http://labix.org/mocker#head-f372c49a9d1b56832e42d5a1ccc960ff75b0b096) | 12:26 |
| * noodles775 checks the ExternalBugTracker tests to see what it's like there. | 12:27 | |
| adeuring | noodles775: http://paste.ubuntu.com/288544/ | 12:28 |
| noodles775 | adeuring: great - that works well :) | 12:29 |
| BjornT | noodles775: well, it depends. i'd like to see the code before commenting. the advantage of creating a class, is that you can give it a meaningful name and a docstring, explaining what it does. it's also easier to debug. | 12:29 |
| adeuring | right | 12:30 |
| noodles775 | BjornT: yep - agreed. | 12:30 |
| noodles775 | adeuring: *phew* r=me. Sorry it took me so long to get through it! | 12:36 |
| adeuring | noodles775: thanks! | 12:36 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: lunch || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com | ||
| === allenap changed the topic of #launchpad-reviews to: on call: noodles || reviewing: lunch || queue: [sinzui, allenap*2] || This channel is logged: http://irclogs.ubuntu.com | ||
| === matsubara-afk is now known as matsubara | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: allenap || queue: [sinzui, allenap] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | allenap: so the previous mp failed on buildbot because it didn't have paramiko? | 13:43 |
| allenap | noodles775: Yes, the buildbot AMI seems to be out of date, which is another bug. However, I thought it was a good idea to put the dep into the tree anyway. | 13:49 |
| noodles775 | allenap: ok, and where is pycrypto used? | 13:49 |
| allenap | noodles775: It's required by paramiko :) | 13:50 |
| noodles775 | allenap: r=me | 13:50 |
| allenap | noodles775: Thanks :) | 13:50 |
| intellectronica | noodles775: hi, i need a ui and code review. fairly simple stuff. shall i get in line after sinzui and allenap? | 13:52 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: bac || queue: [sinzui, allenap] || This channel is logged: http://irclogs.ubuntu.com | ||
| sinzui | My branch is small | 13:52 |
| noodles775 | intellectronica: pop it in the queue - I'm doing reviews for people who are around first.. | 13:52 |
| intellectronica | i'm around | 13:53 |
| noodles775 | :) | 13:53 |
| === intellectronica changed the topic of #launchpad-reviews to: on call: noodles || reviewing: bac || queue: [sinzui, allenap, intellectronica] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | noodles775: Sorry I took a while to answer earlier. My wife had smashed her finger and I had to soothe her and put a plaster on it :) (It was tiny.) | 13:53 |
| * sinzui note to self that intellectronica bot has been replaced by a human | 13:53 | |
| noodles775 | lol on two counts. | 13:54 |
| allenap | sinzui: Or a self-aware bot. | 13:54 |
| jml | bac, hi | 13:56 |
| jml | bac, I was going to talk to you about your patch yesterday, but I didn't get the chance. | 13:56 |
| sinzui | bac wont be available for a few hours | 13:56 |
| noodles775 | oh, I assumed he was around too. | 13:56 |
| sinzui | he is offline for about 2 hours | 13:57 |
| noodles775 | sinzui: and are you around? If so, I'll grab your branch now (your status is still away?) | 13:58 |
| noodles775 | s/around/around for questions etc. :) | 13:58 |
| * sinzui stabs pidgin | 13:58 | |
| sinzui | irc/messaging is not the same in karmic | 13:58 |
| noodles775 | I'm still using xchat... I looked at empathy and pidgin, but went back :/ | 13:59 |
| sinzui | I tried empathy for a day. It is not suitable for irc | 14:00 |
| intellectronica | noodles775: https://code.edge.launchpad.net/~intellectronica/launchpad/bugmail-ui-fixes/+merge/13067 | 14:01 |
| noodles775 | Thanks intellectronica. | 14:01 |
| intellectronica | sinzui: indeed. a shame, because i would like to use it for jabber/msn, but i also like having all my communication going on in one program | 14:01 |
| === mrevell is now known as mrevell-lunch | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: sinzui || queue: [allenap, intellectronica] || This channel is logged: http://irclogs.ubuntu.com | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: bac || queue: [sinzui, allenap, intellectronica] || This channel is logged: http://irclogs.ubuntu.com | ||
| EdwinGrubbs | noodles775: can you do a ui review of https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-399554-timeline-improvements/+merge/12952 | 14:33 |
| noodles775 | EdwinGrubbs: pop it in the queue - rockstar will be around soon too to help out. | 14:33 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: noodles || reviewing: bac || queue: [sinzui, allenap, intellectronica, Edwin-ui] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | noodles775: BTW, just in case you're waiting for diff generation on <https://code.edge.launchpad.net/~allenap/lp-source-dependencies/ec2-test-race-bug-422433-the-revenge/+merge/13063>, it isn't going to happen, as the only changes are two new files, a zip and a tarball. | 14:41 |
| allenap | noodles775: Of course, I'm not at the front of the queue either :) | 14:41 |
| noodles775 | allenap: yeah, I'm currently looking at bac's ui review as beuno is around to chat about it etc., but will be back to the queue in a tick. | 14:42 |
| === mrevell-lunch is now known as mrevell | ||
| noodles775 | sinzui, allenap: is either of your MPs mega urgent? Otherwise, will you be upset if I focus on UI reviews for the rest of the day while beuno is around and leave your code reviews to the US reviewers? | 14:51 |
| sinzui | I have all day since I am CHR | 14:52 |
| allenap | noodles775: No, do UI :) | 14:52 |
| noodles775 | Thanks guys. | 14:52 |
| === allenap changed the topic of #launchpad-reviews to: on call: noodles || reviewing: bac || queue: [sinzui, intellectronica, Edwin-ui] || This channel is logged: http://irclogs.ubuntu.com | ||
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: intellectronica-ui || queue: [sinzui, intellectronica, Edwin-ui] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | bac: Could I bother you for a very quick review of https://code.edge.launchpad.net/~allenap/lp-source-dependencies/ec2-test-race-bug-422433-the-revenge/+merge/13063? It's just adding two distribution files to lp-source-dependencies. | 14:54 |
| noodles775 | beuno: so in case you want to chat about it - I'm looking at the ui for intellectronica at https://code.edge.launchpad.net/~allenap/lp-source-dependencies/ec2-test-race-bug-422433-the-revenge/+merge/13063? | 14:55 |
| beuno | noodles775, cool, looking | 14:55 |
| intellectronica | wrong branch | 14:55 |
| beuno | :) | 14:55 |
| noodles775 | https://code.edge.launchpad.net/~intellectronica/launchpad/bugmail-ui-fixes/+merge/13067 | 14:56 |
| noodles775 | sorry. | 14:56 |
| beuno | intellectronica, could I bother you for screenshots on your MP? | 14:58 |
| beuno | my rf is borked | 14:58 |
| intellectronica | beuno: np, just a sec | 14:59 |
| intellectronica | beuno, noodles775: https://devpad.canonical.com/~tom/bugmail-subscription-links.png | 15:04 |
| beuno | intellectronica, thanks | 15:04 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: noodles || reviewing: Edwin-ui || queue: [sinzui, intellectronica, Edwin-ui] || This channel is logged: http://irclogs.ubuntu.com | ||
| beuno | EdwinGrubbs, could you provide me with screenshots for your timeline MP? | 15:24 |
| EdwinGrubbs | beuno: sure | 15:24 |
| beuno | thanks | 15:24 |
| allenap | intellectronica: Could I bother you for a very quick review of https://code.edge.launchpad.net/~allenap/lp-source-dependencies/ec2-test-race-bug-422433-the-revenge/+merge/13063? It's just adding two distribution files to lp-source-dependencies. | 15:24 |
| intellectronica | allenap: sure, i'll review it | 15:25 |
| allenap | intellectronica: Thanks. | 15:25 |
| EdwinGrubbs | beuno: | 15:30 |
| EdwinGrubbs | Screenshot of https://launchpad.dev/firefox | 15:30 |
| EdwinGrubbs | https://chinstrap.canonical.com/~egrubbs/project_index_page_timeline.png | 15:30 |
| EdwinGrubbs | Screenshot of https://launchpad.dev/firefox/+series | 15:30 |
| EdwinGrubbs | https://chinstrap.canonical.com/~egrubbs/project_full_history_timeline.png | 15:30 |
| beuno | EdwinGrubbs, thanks much | 15:31 |
| intellectronica | noodles775: are you reviewing the code too, or are you moving on to other ui reviews? | 15:34 |
| noodles775 | intellectronica: yeah, I'm doing other ui reviews while beuno is here at the same time. | 15:34 |
| intellectronica | cool. allenap, would you mind reviewing the code in my branch, then? it's quite simple stuff | 15:35 |
| allenap | intellectronica: Sure. | 15:35 |
| intellectronica | allenap: also, for reasons i don't understand, i still don't get a diff for your branch on the mp. care to paste the diff? | 15:35 |
| noodles775 | EdwinGrubbs: I'm guessing you guys are already aware of timeout errors on https://edge.launchpad.net/bzr/+series ? | 15:36 |
| intellectronica | allenap: thanks a lot. the mp is at https://code.edge.launchpad.net/~intellectronica/launchpad/bugmail-ui-fixes/+merge/13067 | 15:36 |
| allenap | intellectronica: You won't get one; OOPS-1377MPCJ1. It's just two binary files anyway, paramiko-xxx.zip and pycrypto-xxx.tar.gz, or something like that. | 15:37 |
| intellectronica | allenap: what am i supposed to be reviewing, then? | 15:38 |
| intellectronica | allenap: maybe just explain to me what you're doing, i'll pretend to understand and then you can land it with r=me | 15:38 |
| noodles775 | EdwinGrubbs: actually, someone just commented on #lp - perhaps it's related to the bzr project rather than the page itself. | 15:38 |
| allenap | intellectronica: You're just rubberstamping that I've added the correct files to the source dependencies. | 15:38 |
| allenap | intellectronica: Heh :) | 15:38 |
| intellectronica | allenap: unfortunately i don't have a rubber stamp. is a stamp made from a potato good too? | 15:39 |
| allenap | intellectronica: I added a couple of dependencies (http://pastebin.ubuntu.com/288542/) and these files have to be added so that lp can build. | 15:40 |
| intellectronica | allenap: i'm very much in favour of anything that ensures LP can build. r=me | 15:40 |
| allenap | intellectronica: From you, any kind of stamp is good. | 15:40 |
| BjornT | allenap: fwiw, i think you're the first one to request a review for a change to lp:lp-source-dependencies, the rest of us simply add the files without asking :) | 15:40 |
| allenap | BjornT: Ah, okay, I'll do that in the future :) | 15:41 |
| allenap | intellectronica: Apologies if I've wasted your time wrt. BjornT's comment. | 15:41 |
| bac | hi noodles775, beuno: thanks for the review. noodles775 i like your second suggestion and will go with it. | 15:41 |
| noodles775 | bac: great. | 15:42 |
| intellectronica | allenap: no waste of time. i had a lot of fun | 15:42 |
| allenap | intellectronica: Me too. Phew, cold shower time. | 15:42 |
| EdwinGrubbs | noodles775: is there a bug for the timeouts? I thought we had fixed the problem on the +series page by not tallying bug counts for obsolete series. I don't know anything about the slowness on the +index page, though. | 15:44 |
| bac | jml: ping | 15:45 |
| noodles775 | EdwinGrubbs: not sure - I just tried to follow the link on the bug related to your MP. BTW, is there an easy way for me to setup all those series and milestones shown in your screenshots locally? | 15:45 |
| jml | bac, hi | 15:45 |
| jml | bac, so, we were going to talk about the patch to ec2 land? | 15:46 |
| bac | jml: you wanted to discuss the ec2 branch? | 15:46 |
| bac | :) | 15:46 |
| jml | bac, yeah. | 15:46 |
| EdwinGrubbs | noodles775: yep, here's the script: http://pastebin.ubuntu.com/288669/ | 15:47 |
| noodles775 | EdwinGrubbs: thanks! | 15:47 |
| jml | bac, the Right Way To Do It, I think, is for bzrlib to have a way to get a launchpadlib branch based on a Bazaar branch | 15:48 |
| jml | bac, there's a command in bzr called 'lp-open' which does something similarish to your command... | 15:48 |
| bac | jml: ok, that's the kind of thing i wanted to know. i've limited experience using bzrlib | 15:49 |
| jml | bac, cool. | 15:50 |
| jml | bac, the stuff that's in bzrlib right now isn't very good, IMO | 15:50 |
| jml | bac, bzrlib itself doesn't have any launchpadlib stuff yet... | 15:50 |
| jml | so the code that's there is about "guessing the Launchpad branch URL based on the public_location and push_branch values." | 15:51 |
| bac | jml: i'll see what i can do. but it'll have to wait until the weekend. you sure what i've done isn't Working And Good Enough until bzrlib grows the needed support? | 15:56 |
| jml | bac, I was just wondering that myself | 15:57 |
| bac | jml: i'm not tasked to work on this branch | 15:57 |
| jml | bac, but I've lost the diff :) | 15:57 |
| jml | no | 15:57 |
| jml | got it | 15:57 |
| jml | bac, if you change get_merge_proposal_from_branch to try the push_location after the public_branch, ... | 15:59 |
| bac | jml: that's a good idea | 15:59 |
| jml | bac, and change the call to BzrDir.open_containing_tree_or_branch to pass '.' rather than '', then I think this is good to go. | 16:00 |
| bac | jml: cool. i'll make those changes and submit it for a proper review. | 16:00 |
| === henninge is now known as henninge-sprint | ||
| jml | bac, thank you. | 16:01 |
| bac | noodles775: based on your second screenshot, were you still advocating for a pop-up help? | 16:09 |
| bac | noodles775: https://code.edge.launchpad.net/~bac/launchpad/bug-341935-captcha/+merge/13022 | 16:09 |
| noodles775 | bac: no, after seeing that it really belongs in the step 2 text, I don't think a popup is necessary - what do you think? | 16:11 |
| === deryck is now known as deryck[lunch] | ||
| noodles775 | s/it/the explanation of the captcha field | 16:11 |
| bac | noodles775: i agree it is not necessary | 16:11 |
| bac | noodles775: this should look familiar: http://people.canonical.com/~bac/captcha-2.png | 16:12 |
| bac | noodles775: diff at http://pastebin.ubuntu.com/288678/ | 16:12 |
| === ursula is now known as Ursinha | ||
| noodles775 | bac: great, thanks for that! | 16:13 |
| bac | noodles775: cool. update the MP for me please? | 16:13 |
| noodles775 | bac: erm, I'd already approved it - it's beuno who marked it needs-fixing... beuno? | 16:14 |
| === ursula is now known as Ursinha | ||
| bac | beuno: could you have a look at https://code.edge.launchpad.net/~bac/launchpad/bug-341935-captcha/+merge/13022 and update the review to 'Approved' if you agree? | 16:30 |
| beuno | bac, sure | 16:31 |
| bac | thx | 16:31 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [sinzui, intellectronica] || This channel is logged: http://irclogs.ubuntu.com | ||
| beuno | bac, noodles775, approved, thanks guys | 16:32 |
| noodles775 | beuno: great. I've just done EdwinGrubbs's ui review too. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-399554-timeline-improvements/+merge/12952 | 16:32 |
| * beuno looks | 16:33 | |
| beuno | EdwinGrubbs, noodles775, done | 16:43 |
| allenap | intellectronica: I really like your bugmail-ui-fixes branch :) | 17:08 |
| allenap | intellectronica: Two questions. | 17:08 |
| allenap | intellectronica: Line 49, when it does self.context.context, is that because self.context is a view? | 17:09 |
| intellectronica | allenap: exactly. context can be either the target itself or a view | 17:09 |
| allenap | intellectronica: Could you add a comment to the else: clause to say that? | 17:10 |
| intellectronica | allenap: sure, that's a good idea | 17:10 |
| allenap | intellectronica: Question the second. The zcml. Is there an common interface where you can declare the permissions for userHasBugSubscriptions, rather than doing it 7 times? | 17:11 |
| intellectronica | allenap: i wish. but no, that's not possible because of the stupid way in which zcml handles the interaction between permissions specified by interface and byb attributes | 17:12 |
| allenap | intellectronica: Okay. r=me :) | 17:13 |
| intellectronica | allenap: thanks! | 17:13 |
| === beuno is now known as beuno-lunch | ||
| allenap | intellectronica: I missed it first time. What does byb mean? | 17:14 |
| intellectronica | allenap: sorry, it's nsfw | 17:17 |
| allenap | intellectronica: Hehe, okay, I'll use the Google. | 17:18 |
| === deryck[lunch] is now known as deryck | ||
| === matsubara is now known as matsubara-lunch | ||
| barry | nobody on call? :( | 17:42 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: sinzui || queue: [intellectronica] || This channel is logged: http://irclogs.ubuntu.com | ||
| === intellectronica changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | hi rockstar -- room for another? | 18:31 |
| barry | rockstar: hi! can i get on your queue? | 18:34 |
| rockstar | bac, barry, yup. | 18:34 |
| bac | rockstar: https://code.edge.launchpad.net/~bac/launchpad/gmp/+merge/13083 | 18:35 |
| === bac changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: sinzui || queue: [bac, barry] || This channel is logged: http://irclogs.ubuntu.com | ||
| barry | rockstar: thanks! i'm experimenting with pipes so i'll push the main branch, but i have a smaller clean up branch as a follow on | 18:35 |
| rockstar | barry, okay. Do you know about sync-branches? | 18:35 |
| barry | rockstar: is that different than sync-pipeline? | 18:36 |
| rockstar | barry, er, sync-pipeline | 18:36 |
| barry | rockstar: that's what i'm trying now! :) | 18:36 |
| barry | rockstar: hmm: | 18:37 |
| barry | % bzr sync-pipeline lp:~barry/launchpad/445713-menu | 18:37 |
| barry | bzr: ERROR: Pipeline has no pipe named "445713-menu". | 18:37 |
| barry | so that's clearly wrong | 18:37 |
| === matsubara-lunch is now known as matsubara | ||
| === beuno-lunch is now known as beuno | ||
| rockstar | sinzui, "The TeamInvitationView allows a team admin accept or decline an invitation" looks like you're missing a "to" in there. | 18:45 |
| sinzui | hmm | 18:45 |
| sinzui | yes that might help | 18:45 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: bac || queue: [barry] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | rockstar: i messed up on the review type. can you change it to 'code'? | 19:28 |
| rockstar | bac, does it matter? | 19:29 |
| bac | rockstar: yes | 19:29 |
| bac | rockstar: using ec2 land pulls that info from the MP so that is what gets fed to PQM | 19:29 |
| bac | rockstar: thx | 19:30 |
| rockstar | bac, ah, I didn't notice it was specified as 'ui' | 19:30 |
| bac | rockstar: my bad | 19:30 |
| rockstar | bac, although if nothing was specified, it shouldn't matter. | 19:30 |
| rockstar | bac, whether it does or not, I don't know, but that seems like a heck of a constraint. | 19:30 |
| bac | rockstar: oops, i think that may be a regression in the work i just did. let me fix that. | 19:31 |
| rockstar | "code" review should be implied unless otherwise noted. | 19:31 |
| EdwinGrubbs | beuno: noodles suggested moving the series name to the end of the horizontal line, so that it will show up when it is auto-scrolled to the right. | 19:32 |
| beuno | EdwinGrubbs, I think that sounds like a good idea. Also, I think there may be no harm in repeating it | 19:33 |
| EdwinGrubbs | beuno: Should the series just appear once on the right, or should it appear in the center and perhaps the left for really long series. | 19:33 |
| beuno | :) | 19:33 |
| beuno | see, you don't even need me anymore | 19:33 |
| bac | rockstar: http://pastebin.ubuntu.com/288781/ | 19:34 |
| rockstar | bac, ah, much better. | 19:35 |
| rockstar | barry, where is your mp? | 19:38 |
| barry | rockstar: got waylaid with a phone call. coming soon | 19:38 |
| rockstar | barry, okay. | 19:39 |
| === rockstar changed the topic of #launchpad-reviews to: on call: rockstar || reviewing: barry || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === leonardr is now known as leonardr-lunch | ||
| barry | rockstar: finally! mp sent | 20:15 |
| barry | rockstar: lovely. my mp's oopsed | 20:19 |
| rockstar | barry, those are my favorite kind. | 20:20 |
| barry | rockstar: wtf: https://lp-oops.canonical.com/oops.py/?oopsid=1377CMP1 | 20:21 |
| barry | rockstar: and differently: https://lp-oops.canonical.com/oops.py/?oopsid=1377CMP2 | 20:21 |
| barry | i guess launchpad hates pipes :( | 20:22 |
| rockstar | abentley, ^^ | 20:22 |
| barry | abentley: i guess i will try to mp it the old fashion way | 20:26 |
| EdwinGrubbs | beuno: here's what it looks like on the project page: https://chinstrap.canonical.com/~egrubbs/multi_labels_project_page.png | 20:26 |
| EdwinGrubbs | beuno: in this screenshot, you can see that I only show the left and right labels if the series line is longer than the viewport (iframe). https://chinstrap.canonical.com/~egrubbs/multi_labels_project_page.png | 20:27 |
| abentley | barry: The first one looks like an error in the branch name. | 20:27 |
| rockstar | abentley, yeah, that's what I was thinking. | 20:27 |
| abentley | barry: The second is probably due to a known bug that when the target has revisions not present in the source, creating the source branch from the merge directive blows up. | 20:28 |
| barry | abentley, rockstar so i probably don't quite understand how to push and mp my pipes | 20:29 |
| barry | i think i followed the directions here: http://bazaar-vcs.org/BzrPipeline | 20:29 |
| barry | abentley, rockstar but maybe i screwed up. what do you suggest i do now? repush? re-mp? | 20:30 |
| abentley | barry: Could you forward the message that caused the first failure, please? | 20:30 |
| beuno | EdwinGrubbs, looks great to me | 20:30 |
| EdwinGrubbs | thanks | 20:31 |
| barry | abentley: done | 20:31 |
| rockstar | barry, I need to go eat something before I pass out. Will be back in 30. | 20:31 |
| abentley | barry: It looks as though you've run reconfigure-pipeline, but that's not a good choice for launchpad developers. | 20:33 |
| barry | :-o | 20:33 |
| abentley | barry: Launchpad devels should just create their branches where they normally do, and then create a lightweight checkout. | 20:34 |
| barry | abentley: i create branches in my shared repo with 'bzr branch devel 123456-foo' | 20:34 |
| barry | abentley: then normally i just cd to 123456-foo, hack, commit, push, send | 20:34 |
| barry | abentley: i don't quite grok how that workflow should change with pipes | 20:35 |
| barry | abentley: you're right that this time i did a reconfigure-pipeline, then i hacked, committed, pushed, send (but the last three after switching to the appropriate pipe) | 20:36 |
| abentley | barry: The smallest change would be running "checkout --lightweight 123456-foo work", and then doing your hacking in "work". | 20:36 |
| barry | abentley: so once i've done that checkout, i'm basically going to do everything else for this bug in 'work' and not in 123456-foo? (i'm asking stupid questions because i've never used lightweight checkouts; they don't quite fit my model of how to work) | 20:37 |
| abentley | barry: Correct. | 20:38 |
| barry | abentley: when i commit in 'work' it will change 123456-foo though, right? | 20:38 |
| barry | abentley: or iow, i do not want to just do a lightweight checkout of my local devel | 20:38 |
| abentley | barry: It will change the branch at 123456-foo, but not the working tree there. | 20:38 |
| barry | abentley: gotcha. all the working tree changes will be in work | 20:39 |
| abentley | barry: Right. | 20:39 |
| barry | abentley: okay! thanks. i'm assuming i can unfsck myself by doing what you suggest and merging in each pipe from my existing branch, right? | 20:40 |
| abentley | barry: I guess you could, but you can just move the branches out of 445713-menu/pipes. | 20:40 |
| barry | abentley: oh, cool. and then i don't need reconfigure-pipeline, right? | 20:41 |
| abentley | barry: And then in 445713-menu, run "bzr switch --force ../05-cleanup" | 20:41 |
| abentley | barry: Right. You won't want to use reconfigure-pipeline, because it puts your branches at a different location, and that screws up your locations.conf rules. | 20:43 |
| abentley | barry: That's why your source branch location is bzr+ssh://bazaar.launchpad.net/~barry/launchpad/445713-menu/pipes/05-cleanup | 20:44 |
| barry | abentley: gotcha. thanks for all this help. i think i have my blogging work cut out for me tonight :) one last question: for hacking lp, sync-pipeline isn't really useful, right? | 20:45 |
| abentley | barry: Yes, it is. | 20:45 |
| barry | abentley: oh. i guess i don't really understand what sync-pipeline does then | 20:45 |
| abentley | barry: It will push all the branches in your pipeline to Launchpad, and include metadata so that other users can see the pipeline. | 20:46 |
| barry | abentley: so i use that instead of 'bzr push'? | 20:47 |
| abentley | barry: Yes. | 20:47 |
| barry | abentley: okay cool. thanks, that was very helpful. i'll give all of this a try now. rockstar it might be a little while before those mps get sent. | 20:48 |
| === leonardr-lunch is now known as leonardr | ||
| mwhudson | nhandler: did you get a chance to look at that branch yet? | 21:53 |
| barry | rockstar: okay. i think i have smoked the crack pipeline and have something ready to review. i'm going to try the mp's again, okay? | 22:04 |
| rockstar | barry, it's your song, sing it. | 22:05 |
| barry | rockstar, abentley wow. i think it worked! | 22:10 |
| barry | bac: remember yesterday when i requested a ui review of the +review-licenses page? there's a screenshot here: http://launchpadlibrarian.net/33318909/review.png | 22:14 |
| barry | bac: that's the mp i requested you ui review with rockstar | 22:14 |
| barry | rockstar, bac gotta go get my flu shot now. will be back in about 60m. | 22:20 |
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
