| rockstar | Anyone around for a review? | 00:31 |
|---|---|---|
| rockstar | It's not very big, and pretty trivial. | 00:32 |
| rockstar | It's 72 lines small. | 00:33 |
| rockstar | sinzui, maybe you? | 00:33 |
| sinzui | sure | 00:33 |
| rockstar | sinzui, pushing now, I'll get you a pastebin you the diff while I propose for merge. | 00:33 |
| sinzui | okay | 00:34 |
| rockstar | sinzui, http://pastebin.ubuntu.com/289680/ The generated diff is going to be misleading, since it's based on a branch that barry already reviewed. | 00:34 |
| rockstar | sinzui, https://code.edge.launchpad.net/~rockstar/launchpad/fix-code-js-tests/+merge/13156 | 00:37 |
| sinzui | rockstar: I think you decided that testing for a url was not as interesting as testing for the link that uses the url | 00:38 |
| rockstar | sinzui, yes. I was using the url because it worked, but for some reason, it didn't anymore. I just went for any way that would allow me to click the link. | 00:39 |
| * sinzui nods | 00:40 | |
| rockstar | sinzui, basically, we should use the factory instead of doing this by hand, but canonical_url is still pretty silly for windmill yet. | 00:40 |
| sinzui | r=me | 00:40 |
| rockstar | sinzui, great, thanks. | 00:40 |
| sinzui | now if I could just find someone who would explain why karmic broke my autogen.sh | 00:43 |
| nhandler | I got a buildbot failure email from canonical-launchpad@ today. It links to lpbuildbot.canonical.com, but I am unable to view the details of the build. What should I do? | 04:39 |
| wgrant | nhandler: It's already fixed. | 04:55 |
| wgrant | nhandler: Sadly at the moment we just have to hope it wasn't us. | 04:55 |
| nhandler | I was looing at Bug #231168. The +addsubscriber page for bugs says "The person you would like to subscribe to this blueprint. They will be notified of the subscription by e-mail, if they have an active Launchpad account. Should that be updated as well? | 18:13 |
| mup | Bug #231168: Subscribe someone else says: "...if they have an active account." <trivial> <ui> <Launchpad Blueprints:Triaged> <https://launchpad.net/bugs/231168> | 18:13 |
| jml | nhandler, parsing... | 18:29 |
| nhandler | I copied/pasted the wrong message. The +addsubscriber for bugs reallys says "The person's Launchpad ID or e-mail address. You can only subscribe someone who has a Launchpad account." | 18:29 |
| jml | nhandler, ahh ok, so the bugs one is basically ok then, AIUI? | 18:30 |
| nhandler | jml: The statement is correct that you can only subscribe someone who has a Launchpad account, but is it really needed? I would think that it would make more sense to have that show up as an error message instead of "Invalid value" | 18:32 |
| jml | nhandler, ahh, good old "Invalid value" | 18:35 |
| jml | nhandler, I'm going to search to see if there's a bug that was marked "Fix Released" precisely because that text got added to the dialog :) | 18:36 |
| jml | nhandler, so, it doesn't look like the text was added as a reaction to a bug | 18:42 |
| jml | nhandler, I would rather the text stay there until the error message can be fixed, because I personally would read that text as allowing me to subscribe non-launchpad users. | 18:43 |
| nhandler | jml: So to make sure I am understanding you correctly, for the message on the bug page, you are fine having the text modified after the error is fixed, correct? And what about the message for blueprints (the one mentioned in the actual bug report)? | 18:45 |
| jml | nhandler, sorry, back. | 18:50 |
| jml | nhandler, yes that's correct. | 18:50 |
| jml | nhandler, allow me to form an opinion on blueprints first :) | 18:50 |
| jml | https://bugs.edge.launchpad.net/malone/+bug/344459 is an interesting, related bug | 18:50 |
| mup | Bug #344459: Subscribe someone to this bug link should send the person a subscription request if they do not currently have an account <feature> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/344459> | 18:50 |
| jml | hmm. | 18:51 |
| jml | nhandler, maybe you should remove that message for bugs. | 18:51 |
| nhandler | jml: I have to run out for a little bit. I'll look into this issue more when I return. | 18:54 |
| jml | nhandler, ok, thanks. | 18:55 |
| jml | nhandler, sorry for being so laggy :) | 18:55 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!