=== abentley1 is now known as abentley === ursula is now known as Ursinha === jtv changed the topic of #launchpad-reviews to: on call: — || reviewing: — || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com === mrevell is now known as mrevell-lunch === bigjools is now known as bigjools-phone [13:09] rockstar: Do you want to review https://code.edge.launchpad.net/~stub/launchpad/replication/+merge/13203 since it is your bug? === bigjools-phone is now known as bigjools === mrevell-lunch is now known as mrevell === EdwinGrubbs2 is now known as EdwinGrubbs === barry` is now known as barry === barry` is now known as barry === stub1 is now known as stub === intellec` changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: — || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com === intellec` changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: adeuring || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com === intellec` is now known as intellectronica [16:20] adeuring: why `device['E'].get('SUBSYSTEM')` and not `device['E']['SUBSYSTEM']` ? [16:20] adeuring: or is it not a get from a dictionary-like object? [16:21] intellectronica: it is a dict. Let me check, if we can guaraty if SUBSYSTEM is always defined.... [16:21] right [16:22] intellectronica: no, SUBSYSTEM is _not_ always defined. [16:22] intellectronica: to reproduce: udevadm info --export-db [16:22] ah ok, so get might return None [16:22] intellectronica: exactly [16:22] I'd supply the extra parameter, just for readability [16:23] intellectronica: do you mean a sort of an explicit marker? [16:23] adeuring: device['E'].get('SUBSYSTEM', None) [16:24] intellectronica: hrmm... I am not generally opposed to that, but IÄ'd gues that other reviewers might suggest to remove the second parameter ;) [16:24] adeuring: the docstring of is_scsi_device can terminate on the first line, no? [16:24] intellectronica: right, changed [16:24] adeuring: you think so? i'll leave it for you to decide, but i think explicit is better than implicit [16:25] intellectronica: as I said, I don't have a definite opinion on this. Something for the reveiwer meeting? [16:26] sure, or we can even ask barry what he thinks [16:27] * barry thinks it's all wrong! oh wait... [16:27] i don't feel strongly about this, it meant literally what i would do [16:28] barry: abel writes dict.get('sumfin') and i like dict.get('sumfin', None) [16:28] because i always forget what the default behaviour is [16:28] intellectronica: i don't think you need that. every python developer knows .get() returns None by default if the key is missing :) [16:28] intellectronica: that's deeply ingrained in python dna :) [16:29] however, if it's possible that 'sumfin' is in the dict with a value of None, then it's much better to do something like: [16:29] missing = object() [16:29] dict.get('sumfin', missing) [16:29] barry: that's not the case here [16:29] adeuring: cool. in that case .get('foo') is fine [16:30] adeuring: you see, i'm talking nonsense. clearly i'm not (genetically speaking) a python developer :) [16:30] intellectronica: ;) the point is that you can deevelop Python genes ;) [16:30] intellectronica: too much javascript will rot your brain [16:35] adeuring: other than that docstring it all looks great. r=me [16:35] intellectronica: thanks! === intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue: [jtv] || This channel is logged: http://irclogs.ubuntu.com === intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com [16:38] Does anyone know what file sets the 'Invalid value' error message for the subscription fields? === intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [16:39] bigjools: would you like me to review first-ppa-name-bug-439305 ? [16:40] intellectronica: ah yes please, forgot to ask about that! I have a couple possible changes though, perhaps I can discuss them with you after you've looked at it [16:41] bigjools: sure === andrea-bs_ is now known as andrea-bs [16:49] bigjools: your branch looks fine to me. what changes did you want to make? [16:50] first, I was considering filling the "name" field with "ppa" if it's the first PPA [16:50] so it's a sensible default [16:50] second, I might change the interface description to make it more obvious that the name will be part of the repo URL [16:51] and also possibly change the displayname description so the user knows it will be part of the GPG key descriptiojn [16:55] bigjools: yes, all three changes sound like very good ideas [16:56] intellectronica: okay, thanks, do you want to see another diff with that in? [16:58] bigjools: ye [16:58] yes [16:58] coming right up [16:59] intellectronica: what's the right way of pre-filling a form field? [17:00] bigjools: in the view, default_values is a dict with an entry for every field you want to pre-fill [17:00] cool, ta [17:05] intellectronica: hmm is it possible to conditionally change the field descriptions on the form? part three above only applies to the first created PPA [17:06] bigjools: yes, but it's hackish. you need to create a new field, and then create a new fields object with the original field omitted and the new one inserted instead of it [17:07] urg [17:07] IIRC there is another way to add more text on the form? [17:08] bigjools: nothing i can think of [17:08] intellectronica: I'm guessing you'll be finishing soon too, but if I'm wrong, there'll be an MP of mine arriving in a minute if you've time. [17:08] maybe ask one of the resident zope mavens? [17:09] noodles775: i can fit one more review [17:09] intellectronica: thanks! Note - I won't be around, so feel free to re-prioritise :) === noodles775 changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com [17:09] noodles775: np [17:10] * bigjools looks for a maven [17:11] I think they all have a holiday === intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com [17:21] bigjools: i think gary_poster is around [17:22] intellectronica: default_values didn't work [17:23] maybe it's called something different? let me find an example for you [17:23] thanks [17:24] bigjools: sorry, i've misled you. it's actually called initial_values. see lib/lp/bugs/browser/bugtarget.py for example [17:25] intellectronica: got it, thanks [17:25] bigjools: not sure what I'm a maven of, but I am around. I am kind of trying to sneak lunch in though. But if you ask me something or other I'll try to get back quickly [17:26] gary_poster: real quick one! is there a way to conditionally get some extra text on a form, or preferably change the value of a form field's description === EdwinGrubbs is now known as Edwin-lunch [17:27] gary_poster: i suggested creating a new field and and a new fields collection with the new field replacing the old one, but we didn't know if there's an easier way to do it [17:31] bigjools, intellectronica: what intellectronica said sounds like the right basic idea. it's possible we are already creating a one-off field collection for the request, in which case you can just change it in place, which would make it shorter, at least. [17:31] but that would just be an optimization of the same basic idea [17:32] gary_poster: is there a property on the field I can poke then? [17:34] * bigjools boggles at the number of requests in .dev for a simple page [17:35] intellectronica: is there a trick to getting the initial_values property called? Mine isn't :/ [17:35] oh fuck [17:35] I need to spell it right of course [17:39] noodles775: r=me. it would be great to convert that sqlo query to storm, but that's beyond the scope of the branch. everything else looks great [17:41] heh the BUDQ [17:42] ? === intellectronica changed the topic of #launchpad-reviews to: on call: intellectronica || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [17:45] Big Ugly Dispatcher Query [18:02] intellectronica: http://pastebin.ubuntu.com/291713/ [18:04] bigjools: i suspect that the way you've written initial_values, the value will be overridden even if filled by the user before submissions (say if there's an error in another field). is that the behaviour you want? [18:04] intellectronica: I don't understand [18:06] bigjools: if you submit the form and make an error, the form is displayed again with the values you've used before. if you always override initial_values, the previously entered value won't be retained (which is the default behvaiour), because you're looking at the value on the context, which hasn't changed [18:06] ah i see [18:06] bigjools: i suspect that's what wil happen. i'm not 100% sure, but i haven't tried [18:07] I'll check it out and see what happens [18:07] cool [18:07] everything else looks fine. i take you've decided that manipulating the field's description dynamically is to much of a hassle? [18:08] yes, the return on investment is small [18:08] i agree [18:09] intellectronica: actually the value is retained, despite initial_values [18:09] so it's all good! [18:09] bigjools: excellent. r=me then [18:09] intellectronica: great, thanks for your advice and review [18:10] and with that i shall end my review shift. i think i've been more trouble than help as a reviewer today :-/ [18:10] hehe === intellectronica changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [18:10] fud time here === bigjools is now known as bigjools-afk [18:25] bigjools-afk: if you can get to a widget then you are home free: set the .label or the .hint, depending on what you want. [18:26] if that doesn't do what you want, back to the drawing board. You can do a custom widget easily-ish. === EdwinGrubbs2 is now known as EdwinGrubbs [21:46] gary, can you review this tiny lazr.restful diff so i can make a new release for launchpad? [21:46] https://pastebin.canonical.com/23226/ [21:46] yes [21:46] i've also got a small launchpad branch coming up. (my ec2 test just passed) [21:46] leonardr: r=gary [21:46] great [21:47] can i commit my changes to the download cache? [21:47] leonardr: yes [21:47] all right [21:47] i love it when a plan comes together [21:47] :-) [21:48] gary: fyi, here's what i'm adding [21:48] added: [21:48] dist/grokcore.component-1.6.tar.gz [21:48] dist/lazr.restful-0.9.11.tar.gz [21:48] dist/martian-0.11.tar.gz [21:48] dist/wsgiref-0.1.2.zip [21:48] leonardr: cool [22:02] gary: https://code.edge.launchpad.net/~leonardr/launchpad/help-me-gary/+merge/13245 [22:04] heh [22:04] that's what it was called when i couldn't figure out what those tarballs were for [22:04] heh, I see [22:07] leonardr: r=gary [22:08] all right [22:08] * leonardr has not pqm-submitted a branch for months. does it still work the same way? [22:08] it can still work with bzr pqm-submit. There are other new tricks, but that should be fine. [22:08] all right [22:09] i'm off, i'll see you tomorrow [22:09] see you [22:09] thanks