| === salgado-afk is now known as salgado | ||
| === mrevell is now known as mrevell-lunch | ||
| barry | #startmeeting | 15:00 |
|---|---|---|
| MootBot | Meeting started at 09:00. The chair is barry. | 15:00 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 15:00 |
| barry | hello everyone and welcome to this week's ameu reviewers meeting. who's here today? | 15:00 |
| allenap | me | 15:00 |
| noodles775 | me | 15:00 |
| EdwinGrubbs | me | 15:01 |
| gmb | me | 15:01 |
| intellectronica | me | 15:01 |
| bac | me | 15:02 |
| barry | gary_poster leonardr bigjools salgado sinzui BjornT ping | 15:02 |
| sinzui | me | 15:02 |
| salgado | me | 15:02 |
| gary_poster | me and hiya | 15:02 |
| * sinzui is still having problems with that cat | 15:02 | |
| leonardr | me | 15:02 |
| barry | [TOPIC] agenda | 15:02 |
| MootBot | New Topic: agenda | 15:02 |
| barry | * Roll call | 15:02 |
| barry | * Action items | 15:02 |
| barry | * UI review call update | 15:02 |
| barry | * ''Adding a check for pop-up help to reviews [mrevell]'' | 15:02 |
| barry | * Test dependencies in setup.py [gary] | 15:02 |
| barry | * "Have you added pop-up help? If not, why not?" [mrevell, barry] | 15:02 |
| barry | * Peanut gallery (anything not on the agenda) | 15:03 |
| barry | 15:03 | |
| barry | [TOPIC] * Action items | 15:03 |
| MootBot | New Topic: * Action items | 15:03 |
| barry | * barry to get with mrevell on guidelines migration from old wiki to new | 15:03 |
| adeuring | me | 15:03 |
| barry | i have not done that, but i've pinged mrevell-lunch about it so maybe we'll actually chat about it today ;) | 15:03 |
| barry | * intellectronica and barry to draft guidelines for drive-by cleanups | 15:03 |
| barry | also not done, but i have a little more information | 15:03 |
| barry | so i've been trying to use bzr-pipelines, which seem pretty cool (in a similar way as looms, but better). i do think they can help with drive-bys | 15:04 |
| barry | but they aren't a perfect solution, mostly because diff'ing sometimes gets things wrong-ish | 15:05 |
| barry | or at least not quite what you want | 15:05 |
| barry | i was working on a branch, then realized i had some drive byes i should get independently reviewed | 15:05 |
| barry | i created a lower pipe and merge -i 'd the changes into that branch | 15:06 |
| barry | then i got the main branch reviewed and ask for a look at the drive byes in the same mp | 15:06 |
| barry | this seemed to work well, except... | 15:06 |
| barry | sometimes chunks produced by merge -i contained both drive by and substantive differences | 15:07 |
| barry | in that case i just left them in the main branch | 15:07 |
| barry | EOT. any thoughts, comments? | 15:07 |
| gary_poster | +1 on pipeline | 15:08 |
| barry | gary_poster: have you used them? | 15:08 |
| gary_poster | +1 on getting the pipeline tweaked for what we need | 15:08 |
| abentley | Oh, that was an unfortunate time to walk in. Guess I'll read the notes. | 15:08 |
| barry | abentley: hi. i was just relating my experience with pipelines wrt drive-byes | 15:08 |
| gary_poster | I've read about them. I've used looms. pipelines look good. I like abentley. ;-) | 15:08 |
| barry | :-D | 15:09 |
| barry | abentley: out of context, but... <barry> sometimes chunks produced by merge -i contained both drive by and | 15:09 |
| barry | substantive differences | 15:09 |
| barry | abentley: i don't know what if anything can be done about that | 15:09 |
| abentley | merge -i into something already containing the drive-bys? | 15:10 |
| barry | abentley: no, sorry. merging into a new pipe | 15:10 |
| barry | abentley: i'll try to post this to the mailing list, it's fine to respond there instead | 15:11 |
| abentley | barry: So this is just wanting better than per-hunk granularity. I have a branch for that. | 15:11 |
| barry | abentley: oh! yes, and once again, you rock | 15:11 |
| gary_poster | see? :-) | 15:11 |
| barry | :-D | 15:12 |
| barry | abentley: thanks. let's move on then... | 15:12 |
| barry | * ''Adding a check for pop-up help to reviews [mrevell]'' | 15:12 |
| barry | mrevell-lunch: are you around? | 15:12 |
| barry | i guess not | 15:13 |
| barry | anyway, my understanding of this is that mrevell-lunch wants us to ask about adding pop-up help when reviewing a branch | 15:13 |
| barry | he says it's easy to add | 15:13 |
| barry | i'll leave this on the agenda for now though in case he wants to say more | 15:14 |
| barry | * Test dependencies in setup.py [gary] | 15:14 |
| barry | gary_poster: you're up | 15:14 |
| gary_poster | I sent an email Oct 8 about "test what you fly, fly what you test". The subject was "Including test dependencies in our package releases," sent to the launchpad-dev list. It only started getting replies yesterday (thanks barry!). | 15:14 |
| gary_poster | I won't repeat it here unless someone requests it. It would be nice to have a consensus that what I proposed is our expected/desired approach for our standalone libraries. | 15:14 |
| gary_poster | I'm hopeful it is not contentious, since the only concrete reply was Barry's, which seemed to agree with me. Maybe we can agree now, or maybe we can give the email another week for replies, and then declare it policy. | 15:14 |
| gary_poster | Thoughts? | 15:14 |
| * barry only thought is that gary_poster types fast | 15:15 | |
| gary_poster | :-) | 15:15 |
| abentley | gary_poster: In the absence of a recognized test-dependencies concept, I'm all for it. | 15:15 |
| barry | me too | 15:16 |
| gary_poster | abentley, we can do that. setuptools and/or distutils has that support. So perhaps there's room for contention afterall. | 15:16 |
| gary_poster | after all | 15:16 |
| sinzui | In my latest release for another project, is did this because the user are willing to provide good debugging information if you remove the barriers | 15:16 |
| jml | +1 to more contention. | 15:16 |
| gary_poster | heh | 15:16 |
| * jml relurks | 15:16 | |
| sinzui | s/is/I/ | 15:16 |
| abentley | gary_poster: So, it worries me that we might depend on something without having deliberately chosen to. | 15:16 |
| abentley | gary_poster: But it's more of a theoretical thing. | 15:17 |
| === mrevell-lunch is now known as mrevell | ||
| gary_poster | abentley: "we" the user of the library, or "we" the creator of the library? Not quite sure I understand | 15:18 |
| abentley | gary_poster: We the user of the library. | 15:18 |
| sinzui | gary_poster: I think the problem here is the dependency can be large, or complex. In my case, I had to use fakes to make the test deps portable. I do not think we want to do this. (but man, is the test fast!) | 15:18 |
| abentley | gary_poster: For example, I'd be scared if Mocker was a real dependency of Launchpad. | 15:18 |
| abentley | gary_poster: But if it was a test dependency, that would be fine. | 15:19 |
| barry | abentley: how would that work in practical terms? when would the dependencies get pulled in? | 15:19 |
| gary_poster | abentley: I can understand that from a theoretical perspective. From a practical perspective, if we regard automated tests as our primary tool for quality (as opposed to, say, manual QA) then I don't see a way around it | 15:20 |
| gary_poster | that is | 15:20 |
| gary_poster | I don't see a reasonable way to guarantee that Mocker is a test dependency and not a "real" dependency | 15:20 |
| abentley | barry: Sorry, I didn't even know setuptools supported test dependecies. I certainly don't know how they work. | 15:21 |
| gary_poster | You said "But it's more of a theoretical thing," so does that mean we are on at least similar pages? | 15:21 |
| abentley | gary_poster: Yes, it's more of a niggle than a real concern. | 15:22 |
| gary_poster | cool | 15:22 |
| gary_poster | and understood | 15:22 |
| barry | gary_poster, abentley thanks. for now, i think we're agreed including the test dependency (in the usual case) is about the best we can do | 15:23 |
| gary_poster | cool | 15:23 |
| barry | mrevell: is !away. mrevell do you want to have a word about pop-up help? | 15:23 |
| mrevell | Hi barry, sorry I had to run out. Yes, I'd love to please if that's okay. | 15:24 |
| mrevell | My apologies. | 15:24 |
| barry | mrevell: no worries, and the floor is yours | 15:24 |
| mrevell | I'd like to propose that a check for in-line help be added to code reviews. Maybe it should be ui reviews. | 15:24 |
| mrevell | I think that when we add a new | 15:25 |
| mrevell | feature/page we should consider whether everything on that page is self-evident to our less-experienced users. | 15:25 |
| mrevell | If not, we should consider adding in-line help using the pop-up system. I'd be more than happy to write that help or review any help. | 15:25 |
| mrevell | Any thoughts? | 15:25 |
| barry | mrevell: +1 | 15:26 |
| mrevell | Great :) Heh. | 15:26 |
| barry | mrevell: i had a review last week (maybe bac's branch?) where i asked for a popup help. mrevell tell them how easy it is to add such help <wink> | 15:26 |
| mrevell | barry: Ah yes, it is very easy indeed. | 15:27 |
| mrevell | All you have to do is add an HTML file in the right place (there's a template and there are instructions at | 15:27 |
| mrevell | https://dev.launchpad.net/PopUpHelp) | 15:27 |
| mrevell | and then place a link in your page with a target of "help" | 15:27 |
| mrevell | that automatically brings in the JS to create the pop-up and call in your help page in that pop-up. | 15:28 |
| mrevell | So, I'd like to say that I see this as a real priority for my time so if you need my help or review or whatever when producing pop-up help, please do ask me. | 15:28 |
| sinzui | I have used this. It is very easy to create help | 15:28 |
| mrevell | Or suggest that the person whose branch you're reviewing contact me. | 15:28 |
| barry | mrevell: how would you like to flesh out https://dev.launchpad.net/DeveloperDocumentation/UserInterfaceChecklist which is linked off of https://dev.launchpad.net/StyleGuides but empty? | 15:29 |
| mrevell | barry: I'll do that! Thanks very much everyone. | 15:29 |
| barry | mrevell: thanks! | 15:30 |
| barry | [ACTION] mrevell to flesh out UserInterfaceChecklist | 15:30 |
| MootBot | ACTION received: mrevell to flesh out UserInterfaceChecklist | 15:30 |
| barry | [TOPIC] peanut gallery | 15:30 |
| MootBot | New Topic: peanut gallery | 15:30 |
| barry | that's all i have for today. do you have anything on your mind? | 15:30 |
| abentley | Does anyone else find they're creating a lot of HTML fragment URLs? | 15:31 |
| intellectronica | yeah | 15:31 |
| intellectronica | well, i did in the past, but there's plans for more of them | 15:31 |
| abentley | I think it would be nice if we could retrieve particular IDs as HTML, or maybe address views directly. | 15:32 |
| abentley | By particular ids, I mean HTML IDs. | 15:32 |
| intellectronica | abentley: what do you mean by 'retrieve particular IDs'? | 15:32 |
| noodles775 | mrevell: there might be some overlap between that UI checklist page above and https://dev.launchpad.net/UI/Reviews | 15:32 |
| intellectronica | ah, you mean addressing an element within a page on the server? | 15:32 |
| abentley | So where you have <body><p id='lobster>I am a lobster</p></body>, you could retrieve just the lobster. | 15:33 |
| intellectronica | abentley: how will you use that? | 15:33 |
| barry | noodles775, abentley maybe that link should just be updated? | 15:33 |
| intellectronica | in all the cases i've used fragments it was to load separately complex pages. rendering the entire page for each fragment would not work for me | 15:33 |
| noodles775 | barry, mrevell - yep. | 15:34 |
| abentley | intellectronica: There's a page that displays a comment, but I need the comment's HTML fragment, so I'd retrieve just that. | 15:34 |
| intellectronica | abentley: surely, rendering all the comments just to get one of them doesn't make much sense | 15:34 |
| intellectronica | or are you suggesting somehow only rendering the requested fragment? | 15:34 |
| abentley | intellectronica: Right, but as I said, there's a page that displays a comment, not all of them. | 15:35 |
| intellectronica | abentley: also, for this particular use case, you should use the api | 15:35 |
| intellectronica | ah right, missed that | 15:35 |
| intellectronica | abentley: have you seen how it's done for bug comments? | 15:35 |
| intellectronica | b.t.w this isn't really a reviews-related topic, is it? | 15:36 |
| abentley | intellectronica: Yes, and that approach was the first thing I tried. | 15:36 |
| intellectronica | abentley: i remember from the list thread that you didn't like having to have a retrieve operation subsequent to posting, but assuming that's fixed, why not continue with this approach? | 15:37 |
| abentley | intellectronica: The approach I'm continuing with is retrieving an HTML fragment. | 15:37 |
| abentley | intellectronica: So I have to create a URL for the fragment to live at. | 15:38 |
| intellectronica | abentley: but why are you using that approach? ideally we should do things the same way across LP | 15:38 |
| abentley | intellectronica: I' | 15:38 |
| abentley | intellectronica: I'm using that approach because it works, and the bugs approach did not. | 15:39 |
| barry | abentley, intellectronica i do think we're leaving the realm of reviewer topics, so let's continue this on-list | 15:39 |
| abentley | barry: Okay. | 15:39 |
| mrevell | noodles775: Did you just kill the UIChecklist page? | 15:39 |
| intellectronica | abentley: what didn't work about it? maybe we should aim at fixing whatever that was rather than create another way of doing things? | 15:39 |
| intellectronica | barry: yeah, sorry | 15:39 |
| abentley | intellectronica: This is hardly another way of doing things. | 15:39 |
| barry | no worries | 15:39 |
| barry | do we have any other topics for today? | 15:40 |
| noodles775 | mrevell: nope? didn't touch it... just pointed out that https://dev.launchpad.net/UI/Reviews has lots of this info. barry said earlier that the other page was empty? | 15:40 |
| mrevell | noodles775: Ah, yeah, it seems to be. | 15:40 |
| mrevell | I'll pop in a redirect | 15:40 |
| barry | okay, i think we're done | 15:40 |
| barry | #endmeeting | 15:40 |
| MootBot | Meeting finished at 09:40. | 15:40 |
| barry | thanks everybody! | 15:41 |
| intellectronica | thanks barry | 15:41 |
| === salgado is now known as salgado-lunch | ||
| === salgado-lunch is now known as salgado | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| === Edwin-lunch is now known as EdwinGrubbs | ||
| mwhudson | hi | 22:01 |
| barry | #startmeeting | 22:01 |
| rockstar | ni! | 22:01 |
| MootBot | Meeting started at 16:01. The chair is barry. | 22:01 |
| MootBot | Commands Available: [TOPIC], [IDEA], [ACTION], [AGREED], [LINK], [VOTE] | 22:01 |
| barry | hi! | 22:01 |
| barry | how are things going today? | 22:01 |
| rockstar | Good. | 22:01 |
| mwhudson | yes, not bad so far | 22:01 |
| barry | i've been playing with pipelines a lot lately | 22:02 |
| barry | they seem very cool, once i sorta wrapped my head around lightweight checkouts | 22:02 |
| rockstar | barry, awesome. abentley and I have talked a few times about how to make them better with launchpad. Ideas are welcome. | 22:02 |
| barry | rockstar: very cool. i'm working on some notes and i've filed one bug so far | 22:03 |
| barry | the python2.5/2.6 sprint is going well. we're making lots of progress. i think we might actually finish 2.5 migration this week | 22:03 |
| barry | which would give us all next week to do 2.6 | 22:03 |
| mwhudson | barry: _awesome_ | 22:04 |
| barry | mwhudson: yeah. i am /highly/ motivated to get this done :) | 22:04 |
| barry | and we're getting excellent community participation from maxb and simon-o | 22:04 |
| barry | so let's see. at ameu we talked about including test dependencies (gary's test what you fly, fly what you test) | 22:05 |
| barry | we talked about popup help | 22:05 |
| barry | and we talked about html fragments (which i think abentley emailed the list about) | 22:06 |
| barry | any of that interesting? do you have anything else you want to talk about? | 22:06 |
| mwhudson | the problem with test dependencies kinda boils down to "zope' | 22:07 |
| mwhudson | s packaging is ridiculous" doesn't it? | 22:08 |
| barry | yeah ;) | 22:08 |
| barry | mwhudson: did you know lazr.restful pulls in zodb3?! | 22:08 |
| mwhudson | barry: only because you've mentioned it a few tiems | 22:08 |
| barry | :) it just amazes me | 22:09 |
| rockstar | I think abentley's discussion, since it's on the list, should continue on the list, but I have things to say about it. | 22:09 |
| mwhudson | yeah, i don't have any thing to bring up i think | 22:09 |
| barry | rockstar: +1 | 22:10 |
| barry | cool. if there's nothing else, shall we call it? | 22:10 |
| rockstar | barry, sure. | 22:10 |
| === salgado is now known as salgado-afk | ||
| barry | cool. thanks guys | 22:11 |
| barry | #endmeeting | 22:11 |
| MootBot | Meeting finished at 16:11. | 22:11 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!