| thumper | mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/script-error-reporting-utility/+merge/13329 perchance? | 03:07 |
|---|---|---|
| mwhudson | thumper: why not run all diff tests in the zopeless layer> | 03:09 |
| mwhudson | ? | 03:09 |
| mwhudson | i guess some of the code runs in the webapp | 03:09 |
| thumper | umm... | 03:09 |
| thumper | possibly? | 03:09 |
| thumper | I could do I gess | 03:09 |
| * thumper smacks forehead | 03:10 | |
| mwhudson | thumper: did you know https://code.edge.launchpad.net/launchpad-project/+activereviews is oopsing? | 03:10 |
| thumper | no | 03:10 |
| mwhudson | TypeError: can't compare datetime.datetime to NoneType<br /> | 03:10 |
| thumper | fuck | 03:10 |
| mwhudson | something to do with the sorting, i think | 03:10 |
| thumper | ya think? | 03:10 |
| thumper | and no losa :( | 03:11 |
| thumper | was hoping for a db query | 03:11 |
| mwhudson | thumper: pjdc can do them | 03:12 |
| thumper | who is pjdc? | 03:12 |
| thumper | mwhudson: do you think it better to run all the tests in the zopeless layer? | 03:16 |
| thumper | all the diff ones anyway | 03:16 |
| mwhudson | thumper: wellington based sysadmin | 03:17 |
| thumper | ah, I forgot about him | 03:17 |
| * mwhudson looks at the diff testsx | 03:17 | |
| mwhudson | thumper: i guess it makes sense to divide up the tests depending on whether they'll be running in a script or the webapp | 03:29 |
| mwhudson | thumper: (and in the medium term, let's kill more and more of the zopeless/webapp description) | 03:30 |
| mwhudson | distinction! | 03:31 |
| mwhudson | not description | 03:31 |
| * mwhudson says stuff on the mp | 03:33 | |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | Hi allenap, got time for this one: https://code.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334 | 11:25 |
| === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com | ||
| allenap | noodles775: Yeah, sure. | 11:25 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| noodles775 | Thanks allenap | 12:22 |
| allenap | noodles775: You're welcome. | 12:23 |
| allenap | noodles775: Do you know where we use YUI 2.7? | 12:25 |
| noodles775 | allenap: yep - the date/time picker :/ | 12:25 |
| noodles775 | allenap: see the inclusion in templates/sprint-new.pt for example. | 12:26 |
| allenap | noodles775: Thanks. By the way, it's in reference to https://code.edge.launchpad.net/~sinzui/launchpad/canonical-fonts-bug-435356/+merge/13318 where sinzui has updated the font-family definitions in the YUI 2.7 code. I wondered if it was necessary. | 12:27 |
| noodles775 | allenap: right. fwiw, afaik we're only using yui2.7 for the calendar, so updating those two css files would be necessary, not sure about the others. | 12:29 |
| allenap | noodles775: I'll add that to the review. Thanks. | 12:30 |
| noodles775 | np. | 12:30 |
| === matsubara-afk is now known as matsubara | ||
| === salgado-afk is now known as salgado | ||
| achuni | hi, I'm looking for a reviewer for https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13309 | 13:58 |
| achuni | it's a huge monster of a diff | 13:58 |
| achuni | bac started on it yesterday but didn't get round to finish it | 13:59 |
| achuni | I was wondering if some kind soul could look at it, or if we'll need to set out and split it up | 14:00 |
| allenap | achuni: I'll take a look. | 14:10 |
| allenap | achuni: Ah, I don't have permission to see that. | 14:10 |
| achuni | allenap: I'll subscribe you in a sec | 14:10 |
| === mrevell is now known as mrevell-lunch | ||
| achuni | allenap: subscribed | 14:12 |
| allenap | achuni: Thanks. | 14:12 |
| allenap | achuni: I think it would be better if you could break it up into three changes, two at least. There's a lot of new stuff there, and it's not to a codebase that I'm intimately familiar with. On another day I might feel brave and do it, but my history on mammoth reviews is that the time spent shoots up as the diff gets bigger, and the quality goes down. | 14:19 |
| allenap | achuni: Do you think you'll be able to break it up? | 14:19 |
| achuni | allenap: I'll do my best | 14:20 |
| allenap | achuni: Cool, and sorry for now :-/ | 14:22 |
| achuni | allenap: np, it's all for the best | 14:23 |
| sinzui | allenap: Thanks for the review. noodles775: I updated all the YUI css because mt reopened the bug for U1 because the JS widgets were not in the official style. I think it is safer to convert them all in the off chance we use another 2.0 widget. | 14:35 |
| allenap | sinzui: You're welcome, and that sounds reasonable. | 14:36 |
| === mrevell-lunch is now known as mrevell | ||
| noodles775 | allenap: I don't seem to be getting an email notification - so maybe you didn't either, but jfyi, I've added an incremental after your review to https://code.edge.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334 | 16:06 |
| allenap | noodles775: I'll have a look. I haven't received an email either. | 16:07 |
| allenap | noodles775: Still r=me :) | 16:09 |
| noodles775 | allenap: thanks. | 16:09 |
| allenap | noodles775: Thanks for replying; not everyone does if I have some comments but +1 anyway. | 16:09 |
| noodles775 | allenap: np - I always like to know how people finish up branches too - after having poured over the code :) | 16:10 |
| adeuring | allenap: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-5/+merge/13350 ? | 16:18 |
| allenap | adeuring: Sure. | 16:19 |
| adeuring | allenap: thanks! | 16:19 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === flacoste_afk is now known as flacoste | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| al-maisan | jml: it would be nice if we could make some headway wrt bug #347768 | 16:56 |
| mup | Bug #347768: Allow anyone with upload rights to write to a package branch <package-branches> <Launchpad Bazaar Integration:In Progress by jml> <https://launchpad.net/bugs/347768> | 16:56 |
| jml | al-maisan, yes, I very strongly agree. | 16:58 |
| al-maisan | would you have time for a call? | 16:58 |
| jml | al-maisan, yes I would. Can you give me 5-10 minutes to gather my thoughts? | 16:59 |
| al-maisan | jml: most certainly! | 17:00 |
| allenap | adeuring: The diff is rather long; I assume it's meant to be against devel rather than db-devel? | 17:02 |
| adeuring | allenap: argh, of course... Let me paste te real diff | 17:02 |
| allenap | adeuring: It's okay, I have it. | 17:02 |
| adeuring | allenap: ok, thanks | 17:02 |
| jml | al-maisan, ok, let's do it. | 17:08 |
| al-maisan | jml: yup | 17:08 |
| === matsubara is now known as matsubara-lunch | ||
| jml | al-maisan, nothing is happening. | 17:10 |
| al-maisan | jml: I tried calling but got a "call refused" | 17:10 |
| allenap | adeuring: All looks good. | 17:16 |
| === allenap changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| adeuring | allenap: thanks! | 17:16 |
| === allenap changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === beuno is now known as beuno-lunch | ||
| jml | al-maisan, http://pastebin.ubuntu.com/293241/ | 17:23 |
| adeuring | allenap: could you add your review to my MP? | 17:33 |
| allenap | adeuring: I sent an email review... | 17:33 |
| adeuring | allenap: Ah, OK. Seems that processing needs some time... | 17:34 |
| allenap | adeuring: Mmm, I sent it nearly 20 minutes ago. | 17:34 |
| === salgado is now known as salgado-lunch | ||
| leonardr | edwin, i'd like your views on https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358 | 17:46 |
| === beuno-lunch is now known as beuno | ||
| === matsubara-lunch is now known as matsubara | ||
| === salgado-lunch is now known as salgado | ||
| rockstar | EdwinGrubbs, may I stick a branch in your queue. It's seriously a one line change. | 18:35 |
| EdwinGrubbs | rockstar: sure | 18:56 |
| achuni | allenap: I've split the merge out in to three MP: | 18:58 |
| achuni | https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip1/+merge/13351 | 18:58 |
| achuni | https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip2/+merge/13362 | 18:58 |
| achuni | https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13363 | 18:58 |
| achuni | I'm afraid the second one is still quite large | 18:58 |
| leonardr | EdwinGrubbs, did you see my review request? | 19:01 |
| EdwinGrubbs | leonardr: no | 19:01 |
| leonardr | edwingrubbs: https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358 | 19:01 |
| EdwinGrubbs | rockstar: where is your MP? | 19:04 |
| rockstar | EdwinGrubbs, still prepping it. leonardr can go first. | 19:04 |
| EdwinGrubbs | leonardr: reviewing it now | 19:06 |
| leonardr | great | 19:07 |
| bac | hi edwin -- can i add a super simple one to your queue? | 19:20 |
| EdwinGrubbs | bac: sure | 19:20 |
| === bac changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [bac] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | EdwinGrubbs: https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368 | 19:40 |
| bac | beuno: UI review? https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368 | 19:40 |
| beuno | bac, sure | 19:40 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: leonardr || queue: [rockstar, bac] || This channel is logged: http://irclogs.ubuntu.com | ||
| bac | beuno: scroll down for screenshots | 19:40 |
| beuno | bac, reviewed | 19:43 |
| bac | beuno: fast! | 19:43 |
| bac | thanks | 19:43 |
| EdwinGrubbs | leonardr: Is BaseWSGIWebServiceConfiguration supposed to be used somewhere, or is it just a resource for other applications? | 19:54 |
| leonardr | edwingrubbs: it's just for other applications, but it is used in the wsgi example service | 19:55 |
| EdwinGrubbs | leonardr: I see that it sets set_hop_to_hop_headers to False, but that variable defaults to true in the tests. Is it not using that base in class in that test? | 19:56 |
| leonardr | edwin: right. all the tests except the ones in wsgi/example/tests use the default behavior | 19:57 |
| leonardr | the tests in wsgi/example/tests will have it set to false, but as i mentioned in the merge proposal, it doesn't seem to make a difference, because my test wsgi server is less strict than real wsgi servers | 19:57 |
| leonardr | i can add a test that shows that the TE header is ignored in wsgi services | 19:58 |
| EdwinGrubbs | leonardr: I don't think that's necessary. I was just confused. | 19:59 |
| leonardr | ok | 19:59 |
| rockstar | EdwinGrubbs, https://code.edge.launchpad.net/~rockstar/launchpad/fix-ensure-login/+merge/13373 | 20:11 |
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing:- || queue: [bac] || This channel is logged: http://irclogs.ubuntu.com | ||
| EdwinGrubbs | rockstar: it's a good thing you told me it was one line, since I almost went to lunch. r=me | 20:17 |
| === EdwinGrubbs is now known as Edwin-lunch | ||
| rockstar | Edwin-lunch, thanks! | 20:17 |
| === Edwin-lunch is now known as EdwinGrubbs | ||
| === salgado is now known as salgado-afk | ||
| nhandler | Does anyone know where the error message 'Invalid value' that you get when you try to subscribe a non-existant user to a bug is defined? | 22:11 |
| mwhudson | nhandler: it's something terrible deep in the zope form machinery i think | 22:55 |
| mwhudson | nhandler: do you know what a 'vocabulary | 22:55 |
| mwhudson | ' is in the context of launchpad? | 22:55 |
| nhandler | mwhudson: Not really. I'm still learning as I go. I was working on bug #231168, and in order to properly fix it, the error message should really be modified | 22:58 |
| mup | Bug #231168: Subscribe someone else says: "...if they have an active account." <trivial> <ui> <Launchpad Blueprints:In Progress by nhandler> <https://launchpad.net/bugs/231168> | 22:58 |
| mwhudson | nhandler: ok | 22:59 |
| mwhudson | nhandler: basically, i can't remember | 22:59 |
| mwhudson | nhandler: but i think i knew once, so i can probably find out quicker than you :) | 23:00 |
| nhandler | :) | 23:00 |
| nhandler | Thanks a lot mwhudson | 23:00 |
| mwhudson | nhandler: can you tell me where the view class is for this form? | 23:00 |
| nhandler | mwhudson: The view class? My python abilities are very minimal I'm afraid. | 23:01 |
| mwhudson | nhandler: it's ok, i think i found it | 23:01 |
| mwhudson | nhandler: i *think* you need to specify a validator for the "person" Field in IBugSubscription | 23:04 |
| nhandler | mwhudson: Thanks. Now I have somewhere to work from. My goal is to get this bug fixed and ready to be reviewed/merged by the end of the week | 23:06 |
| === ursula is now known as Ursinha | ||
| === matsubara is now known as matsubara-afk | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!