[03:07] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/script-error-reporting-utility/+merge/13329 perchance?
[03:09] <mwhudson> thumper: why not run all diff tests in the zopeless layer>
[03:09] <mwhudson> ?
[03:09] <mwhudson> i guess some of the code runs in the webapp
[03:09] <thumper> umm...
[03:09] <thumper> possibly?
[03:09] <thumper> I could do  I gess
[03:10]  * thumper smacks forehead
[03:10] <mwhudson> thumper: did you know https://code.edge.launchpad.net/launchpad-project/+activereviews is oopsing? 
[03:10] <thumper> no
[03:10] <mwhudson> TypeError: can't compare datetime.datetime to NoneType<br /> 
[03:10] <thumper> fuck
[03:10] <mwhudson> something to do with the sorting, i think
[03:10] <thumper> ya think?
[03:11] <thumper> and no losa :(
[03:11] <thumper> was hoping for a db query
[03:12] <mwhudson> thumper: pjdc can do them
[03:12] <thumper> who is pjdc?
[03:16] <thumper> mwhudson: do you think it better to run all the tests in the zopeless layer?
[03:16] <thumper> all the diff ones anyway
[03:17] <mwhudson> thumper: wellington based sysadmin
[03:17] <thumper> ah, I forgot about him
[03:17]  * mwhudson looks at the diff testsx
[03:29] <mwhudson> thumper: i guess it makes sense to divide up the tests depending on whether they'll be running in a script or the webapp
[03:30] <mwhudson> thumper: (and in the medium term, let's kill more and more of the zopeless/webapp description)
[03:31] <mwhudson> distinction!
[03:31] <mwhudson> not description
[03:33]  * mwhudson says stuff on the mp
[11:25] <noodles775> Hi allenap, got time for this one: https://code.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334
[11:25] <allenap> noodles775: Yeah, sure.
[12:22] <noodles775> Thanks allenap 
[12:23] <allenap> noodles775: You're welcome.
[12:25] <allenap> noodles775: Do you know where we use YUI 2.7?
[12:25] <noodles775> allenap: yep - the date/time picker :/
[12:26] <noodles775> allenap: see the inclusion in templates/sprint-new.pt for example.
[12:27] <allenap> noodles775: Thanks. By the way, it's in reference to https://code.edge.launchpad.net/~sinzui/launchpad/canonical-fonts-bug-435356/+merge/13318 where sinzui has updated the font-family definitions in the YUI 2.7 code. I wondered if it was necessary.
[12:29] <noodles775> allenap: right. fwiw, afaik we're only using yui2.7 for the calendar, so updating those two css files would be necessary, not sure about the others.
[12:30] <allenap> noodles775: I'll add that to the review. Thanks.
[12:30] <noodles775> np.
[13:58] <achuni> hi, I'm looking for a reviewer for https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13309
[13:58] <achuni> it's a huge monster of a diff
[13:59] <achuni> bac started on it yesterday but didn't get round to finish it
[14:00] <achuni> I was wondering if some kind soul could look at it, or if we'll need to set out and split it up
[14:10] <allenap> achuni: I'll take a look.
[14:10] <allenap> achuni: Ah, I don't have permission to see that.
[14:10] <achuni> allenap: I'll subscribe you in a sec
[14:12] <achuni> allenap: subscribed
[14:12] <allenap> achuni: Thanks.
[14:19] <allenap> achuni: I think it would be better if you could break it up into three changes, two at least. There's a lot of new stuff there, and it's not to a codebase that I'm intimately familiar with. On another day I might feel brave and do it, but my history on mammoth reviews is that the time spent shoots up as the diff gets bigger, and the quality goes down.
[14:19] <allenap> achuni: Do you think you'll be able to break it up?
[14:20] <achuni> allenap: I'll do my best
[14:22] <allenap> achuni: Cool, and sorry for now :-/
[14:23] <achuni> allenap: np, it's all for the best
[14:35] <sinzui> allenap: Thanks for the review. noodles775: I updated all the YUI css because mt reopened the bug for U1 because the JS widgets were not in the official style. I think it is safer to convert them all in the off chance we use another 2.0 widget.
[14:36] <allenap> sinzui: You're welcome, and that sounds reasonable.
[16:06] <noodles775> allenap: I don't seem to be getting an email notification - so maybe you didn't either, but jfyi, I've added an incremental after your review to https://code.edge.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334
[16:07] <allenap> noodles775: I'll have a look. I haven't received an email either.
[16:09] <allenap> noodles775: Still r=me :)
[16:09] <noodles775> allenap: thanks.
[16:09] <allenap> noodles775: Thanks for replying; not everyone does if I have some comments but +1 anyway.
[16:10] <noodles775> allenap: np - I always like to know how people finish up branches too - after having poured over the code :)
[16:18] <adeuring> allenap: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-5/+merge/13350 ?
[16:19] <allenap> adeuring: Sure.
[16:19] <adeuring> allenap: thanks!
[16:56] <al-maisan> jml: it would be nice if we could make some headway wrt bug #347768
[16:56] <mup> Bug #347768: Allow anyone with upload rights to write to a package branch <package-branches> <Launchpad Bazaar Integration:In Progress by jml> <https://launchpad.net/bugs/347768>
[16:58] <jml> al-maisan, yes, I very strongly agree.
[16:58] <al-maisan> would you have time for a call?
[16:59] <jml> al-maisan, yes I would. Can you give me 5-10 minutes to gather my thoughts?
[17:00] <al-maisan> jml: most certainly!
[17:02] <allenap> adeuring: The diff is rather long; I assume it's meant to be against devel rather than db-devel?
[17:02] <adeuring> allenap: argh, of course... Let me paste te real diff
[17:02] <allenap> adeuring: It's okay, I have it.
[17:02] <adeuring> allenap: ok, thanks
[17:08] <jml> al-maisan, ok, let's do it.
[17:08] <al-maisan> jml: yup
[17:10] <jml> al-maisan, nothing is happening.
[17:10] <al-maisan> jml: I tried calling but got a "call refused"
[17:16] <allenap> adeuring: All looks good.
[17:16] <adeuring> allenap: thanks!
[17:23] <jml> al-maisan, http://pastebin.ubuntu.com/293241/
[17:33] <adeuring> allenap: could you add your review to my MP?
[17:33] <allenap> adeuring: I sent an email review...
[17:34] <adeuring> allenap: Ah, OK. Seems that processing needs some time...
[17:34] <allenap> adeuring: Mmm, I sent it nearly 20 minutes ago.
[17:46] <leonardr> edwin, i'd like your views on https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358
[18:35] <rockstar> EdwinGrubbs, may I stick a branch in your queue.  It's seriously a one line change.
[18:56] <EdwinGrubbs> rockstar: sure
[18:58] <achuni> allenap: I've split the merge out in to three MP:
[18:58] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip1/+merge/13351
[18:58] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip2/+merge/13362
[18:58] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13363
[18:58] <achuni> I'm afraid the second one is still quite large
[19:01] <leonardr> EdwinGrubbs, did you see my review request?
[19:01] <EdwinGrubbs> leonardr: no
[19:01] <leonardr> edwingrubbs: https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358
[19:04] <EdwinGrubbs> rockstar: where is your MP?
[19:04] <rockstar> EdwinGrubbs, still prepping it.  leonardr can go first.
[19:06] <EdwinGrubbs> leonardr: reviewing it now
[19:07] <leonardr> great
[19:20] <bac> hi edwin -- can i add a super simple one to your queue?
[19:20] <EdwinGrubbs> bac: sure
[19:40] <bac> EdwinGrubbs: https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368
[19:40] <bac> beuno: UI review?  https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368
[19:40] <beuno> bac, sure
[19:40] <bac> beuno: scroll down for screenshots
[19:43] <beuno> bac, reviewed
[19:43] <bac> beuno: fast!
[19:43] <bac> thanks
[19:54] <EdwinGrubbs> leonardr: Is BaseWSGIWebServiceConfiguration supposed to be used somewhere, or is it just a resource for other applications?
[19:55] <leonardr> edwingrubbs: it's just for other applications, but it is used in the wsgi example service
[19:56] <EdwinGrubbs> leonardr: I see that it sets set_hop_to_hop_headers to False, but that variable defaults to true in the tests. Is it not using that base in class in that test?
[19:57] <leonardr> edwin: right. all the tests except the ones in wsgi/example/tests use the default behavior
[19:57] <leonardr> the tests in wsgi/example/tests will have it set to false, but as i mentioned in the merge proposal, it doesn't seem to make a difference, because my test wsgi server is less strict than real wsgi servers
[19:58] <leonardr> i can add a test that shows that the TE header is ignored in wsgi services
[19:59] <EdwinGrubbs> leonardr: I don't think that's necessary. I was just confused.
[19:59] <leonardr> ok
[20:11] <rockstar> EdwinGrubbs, https://code.edge.launchpad.net/~rockstar/launchpad/fix-ensure-login/+merge/13373
[20:17] <EdwinGrubbs> rockstar: it's a good thing you told me it was one line, since I almost went to lunch. r=me
[20:17] <rockstar> Edwin-lunch, thanks!
[22:11] <nhandler> Does anyone know where the error message 'Invalid value' that you get when you try to subscribe a non-existant user to a bug is defined?
[22:55] <mwhudson> nhandler: it's something terrible deep in the zope form machinery i think
[22:55] <mwhudson> nhandler: do you know what a 'vocabulary
[22:55] <mwhudson> ' is in the context of launchpad?
[22:58] <nhandler> mwhudson: Not really. I'm still learning as I go. I was working on bug #231168, and in order to properly fix it, the error message should really be modified
[22:58] <mup> Bug #231168: Subscribe someone else says: "...if they have an active account." <trivial> <ui> <Launchpad Blueprints:In Progress by nhandler> <https://launchpad.net/bugs/231168>
[22:59] <mwhudson> nhandler: ok
[22:59] <mwhudson> nhandler: basically, i can't remember
[23:00] <mwhudson> nhandler: but i think i knew once, so i can probably find out quicker than you :)
[23:00] <nhandler> :)
[23:00] <nhandler> Thanks a lot mwhudson 
[23:00] <mwhudson> nhandler: can you tell me where the view class is for this form?
[23:01] <nhandler> mwhudson: The view class? My python abilities are very minimal I'm afraid.
[23:01] <mwhudson> nhandler: it's ok, i think i found it
[23:04] <mwhudson> nhandler: i *think* you need to specify a validator for the "person" Field in IBugSubscription
[23:06] <nhandler> mwhudson: Thanks. Now I have somewhere to work from. My goal is to get this bug fixed and ready to be reviewed/merged by the end of the week