[03:07] mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/script-error-reporting-utility/+merge/13329 perchance? [03:09] thumper: why not run all diff tests in the zopeless layer> [03:09] ? [03:09] i guess some of the code runs in the webapp [03:09] umm... [03:09] possibly? [03:09] I could do I gess [03:10] * thumper smacks forehead [03:10] thumper: did you know https://code.edge.launchpad.net/launchpad-project/+activereviews is oopsing? [03:10] no [03:10] TypeError: can't compare datetime.datetime to NoneType
[03:10] fuck [03:10] something to do with the sorting, i think [03:10] ya think? [03:11] and no losa :( [03:11] was hoping for a db query [03:12] thumper: pjdc can do them [03:12] who is pjdc? [03:16] mwhudson: do you think it better to run all the tests in the zopeless layer? [03:16] all the diff ones anyway [03:17] thumper: wellington based sysadmin [03:17] ah, I forgot about him [03:17] * mwhudson looks at the diff testsx [03:29] thumper: i guess it makes sense to divide up the tests depending on whether they'll be running in a script or the webapp [03:30] thumper: (and in the medium term, let's kill more and more of the zopeless/webapp description) [03:31] distinction! [03:31] not description [03:33] * mwhudson says stuff on the mp === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [11:25] Hi allenap, got time for this one: https://code.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334 === noodles775 changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [noodles] || This channel is logged: http://irclogs.ubuntu.com [11:25] noodles775: Yeah, sure. === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: noodles || queue: [] || This channel is logged: http://irclogs.ubuntu.com === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [12:22] Thanks allenap [12:23] noodles775: You're welcome. [12:25] noodles775: Do you know where we use YUI 2.7? [12:25] allenap: yep - the date/time picker :/ [12:26] allenap: see the inclusion in templates/sprint-new.pt for example. [12:27] noodles775: Thanks. By the way, it's in reference to https://code.edge.launchpad.net/~sinzui/launchpad/canonical-fonts-bug-435356/+merge/13318 where sinzui has updated the font-family definitions in the YUI 2.7 code. I wondered if it was necessary. [12:29] allenap: right. fwiw, afaik we're only using yui2.7 for the calendar, so updating those two css files would be necessary, not sure about the others. [12:30] noodles775: I'll add that to the review. Thanks. [12:30] np. === matsubara-afk is now known as matsubara === salgado-afk is now known as salgado [13:58] hi, I'm looking for a reviewer for https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13309 [13:58] it's a huge monster of a diff [13:59] bac started on it yesterday but didn't get round to finish it [14:00] I was wondering if some kind soul could look at it, or if we'll need to set out and split it up [14:10] achuni: I'll take a look. [14:10] achuni: Ah, I don't have permission to see that. [14:10] allenap: I'll subscribe you in a sec === mrevell is now known as mrevell-lunch [14:12] allenap: subscribed [14:12] achuni: Thanks. [14:19] achuni: I think it would be better if you could break it up into three changes, two at least. There's a lot of new stuff there, and it's not to a codebase that I'm intimately familiar with. On another day I might feel brave and do it, but my history on mammoth reviews is that the time spent shoots up as the diff gets bigger, and the quality goes down. [14:19] achuni: Do you think you'll be able to break it up? [14:20] allenap: I'll do my best [14:22] achuni: Cool, and sorry for now :-/ [14:23] allenap: np, it's all for the best [14:35] allenap: Thanks for the review. noodles775: I updated all the YUI css because mt reopened the bug for U1 because the JS widgets were not in the official style. I think it is safer to convert them all in the off chance we use another 2.0 widget. [14:36] sinzui: You're welcome, and that sounds reasonable. === mrevell-lunch is now known as mrevell [16:06] allenap: I don't seem to be getting an email notification - so maybe you didn't either, but jfyi, I've added an incremental after your review to https://code.edge.launchpad.net/~michael.nelson/launchpad/450124-findBuildCandidate_improvements/+merge/13334 [16:07] noodles775: I'll have a look. I haven't received an email either. [16:09] noodles775: Still r=me :) [16:09] allenap: thanks. [16:09] noodles775: Thanks for replying; not everyone does if I have some comments but +1 anyway. [16:10] allenap: np - I always like to know how people finish up branches too - after having poured over the code :) [16:18] allenap: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-5/+merge/13350 ? [16:19] adeuring: Sure. [16:19] allenap: thanks! === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com === flacoste_afk is now known as flacoste === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: adeuring || queue: [] || This channel is logged: http://irclogs.ubuntu.com [16:56] jml: it would be nice if we could make some headway wrt bug #347768 [16:56] Bug #347768: Allow anyone with upload rights to write to a package branch [16:58] al-maisan, yes, I very strongly agree. [16:58] would you have time for a call? [16:59] al-maisan, yes I would. Can you give me 5-10 minutes to gather my thoughts? [17:00] jml: most certainly! [17:02] adeuring: The diff is rather long; I assume it's meant to be against devel rather than db-devel? [17:02] allenap: argh, of course... Let me paste te real diff [17:02] adeuring: It's okay, I have it. [17:02] allenap: ok, thanks [17:08] al-maisan, ok, let's do it. [17:08] jml: yup === matsubara is now known as matsubara-lunch [17:10] al-maisan, nothing is happening. [17:10] jml: I tried calling but got a "call refused" [17:16] adeuring: All looks good. === allenap changed the topic of #launchpad-reviews to: on call: allenap, Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com [17:16] allenap: thanks! === allenap changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com === beuno is now known as beuno-lunch [17:23] al-maisan, http://pastebin.ubuntu.com/293241/ [17:33] allenap: could you add your review to my MP? [17:33] adeuring: I sent an email review... [17:34] allenap: Ah, OK. Seems that processing needs some time... [17:34] adeuring: Mmm, I sent it nearly 20 minutes ago. === salgado is now known as salgado-lunch [17:46] edwin, i'd like your views on https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358 === beuno-lunch is now known as beuno === matsubara-lunch is now known as matsubara === salgado-lunch is now known as salgado [18:35] EdwinGrubbs, may I stick a branch in your queue. It's seriously a one line change. [18:56] rockstar: sure [18:58] allenap: I've split the merge out in to three MP: [18:58] https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip1/+merge/13351 [18:58] https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip2/+merge/13362 [18:58] https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13363 [18:58] I'm afraid the second one is still quite large [19:01] EdwinGrubbs, did you see my review request? [19:01] leonardr: no [19:01] edwingrubbs: https://code.edge.launchpad.net/~leonardr/lazr.restful/optional-compression/+merge/13358 [19:04] rockstar: where is your MP? [19:04] EdwinGrubbs, still prepping it. leonardr can go first. [19:06] leonardr: reviewing it now [19:07] great [19:20] hi edwin -- can i add a super simple one to your queue? [19:20] bac: sure === bac changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: - || queue: [bac] || This channel is logged: http://irclogs.ubuntu.com [19:40] EdwinGrubbs: https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368 [19:40] beuno: UI review? https://code.edge.launchpad.net/~bac/launchpad/bug-436978-pg-index/+merge/13368 [19:40] bac, sure === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing: leonardr || queue: [rockstar, bac] || This channel is logged: http://irclogs.ubuntu.com [19:40] beuno: scroll down for screenshots [19:43] bac, reviewed [19:43] beuno: fast! [19:43] thanks [19:54] leonardr: Is BaseWSGIWebServiceConfiguration supposed to be used somewhere, or is it just a resource for other applications? [19:55] edwingrubbs: it's just for other applications, but it is used in the wsgi example service [19:56] leonardr: I see that it sets set_hop_to_hop_headers to False, but that variable defaults to true in the tests. Is it not using that base in class in that test? [19:57] edwin: right. all the tests except the ones in wsgi/example/tests use the default behavior [19:57] the tests in wsgi/example/tests will have it set to false, but as i mentioned in the merge proposal, it doesn't seem to make a difference, because my test wsgi server is less strict than real wsgi servers [19:58] i can add a test that shows that the TE header is ignored in wsgi services [19:59] leonardr: I don't think that's necessary. I was just confused. [19:59] ok [20:11] EdwinGrubbs, https://code.edge.launchpad.net/~rockstar/launchpad/fix-ensure-login/+merge/13373 === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: Edwin || reviewing:- || queue: [bac] || This channel is logged: http://irclogs.ubuntu.com [20:17] rockstar: it's a good thing you told me it was one line, since I almost went to lunch. r=me === EdwinGrubbs is now known as Edwin-lunch [20:17] Edwin-lunch, thanks! === Edwin-lunch is now known as EdwinGrubbs === salgado is now known as salgado-afk [22:11] Does anyone know where the error message 'Invalid value' that you get when you try to subscribe a non-existant user to a bug is defined? [22:55] nhandler: it's something terrible deep in the zope form machinery i think [22:55] nhandler: do you know what a 'vocabulary [22:55] ' is in the context of launchpad? [22:58] mwhudson: Not really. I'm still learning as I go. I was working on bug #231168, and in order to properly fix it, the error message should really be modified [22:58] Bug #231168: Subscribe someone else says: "...if they have an active account." [22:59] nhandler: ok [22:59] nhandler: basically, i can't remember [23:00] nhandler: but i think i knew once, so i can probably find out quicker than you :) [23:00] :) [23:00] Thanks a lot mwhudson [23:00] nhandler: can you tell me where the view class is for this form? [23:01] mwhudson: The view class? My python abilities are very minimal I'm afraid. [23:01] nhandler: it's ok, i think i found it [23:04] nhandler: i *think* you need to specify a validator for the "person" Field in IBugSubscription [23:06] mwhudson: Thanks. Now I have somewhere to work from. My goal is to get this bug fixed and ready to be reviewed/merged by the end of the week === ursula is now known as Ursinha === matsubara is now known as matsubara-afk