/srv/irclogs.ubuntu.com/2009/10/15/#launchpad-dev.txt

adeuringgood morning08:28
mrevellHi!09:12
wgrantbigjools: Morning...09:12
bigjoolsmorning!09:12
wgrantSo, I found something in Dominator this morning which is indeed rather similar to the ddeb issue - atomic arch-indep domination, which I didn't really know existed before reading the code.09:13
bigjoolsyeah I've not delved into that code09:14
wgrantTurns out it suffer(s|ed) from the same problems I identified with the ddeb situation: bug #178102, bug #192547.09:14
mupBug #178102: (Pro|De)motion loses arch: all binaries <Soyuz:Fix Released by cprov> <https://launchpad.net/bugs/178102>09:14
mupBug #192547: Doubly-overridden binaries get eaten <Soyuz:Triaged> <https://launchpad.net/bugs/192547>09:14
bigjoolsaha09:14
wgrant(I reported both, but forgot about them, funnily enough)09:14
bigjools:)09:14
wgrantThe first was fixed by doing what you suggested last night: matching component/section/priority.09:15
bigjoolsoh jeez, see #lanchpad :)09:15
wgrantHahha.09:15
wgrantThe second was marked as a duplicate of another bug, but I do not understand how a fix for one fixes the other.09:17
bigjoolsI'm just reading it09:18
wgrantPresumably Celso had some idea, but there is no public record of that.09:18
bigjoolsit's ok I know where he lives, I can kidnap his dog09:20
wgrantHeh.09:20
bigjoolswgrant: the duped one could be un-duped and fixed as easily as you suggest09:23
bigjoolsI don't quite understand why it's a dupe wither09:24
wgrantbigjools: But I didn't suggest...09:24
bigjoolseither09:24
bigjoolswgrant: in the description for it you suggest not allowing identical overrides09:24
wgrantThat was before I saw the code.09:24
wgrantThat's not feasible.09:24
bigjoolslol09:24
bigjoolsok I think I see why it's a dupe09:25
wgrantIn the initial case that I saw, the binary had been consecutively overriden identically twice.09:25
wgrantBut the same problem will occur even if there are intermediate overrides.09:25
wgrantOh, really? Please explain!09:25
wgrantI considered that the override could instead mutate an existing Pending publication, which would probably fix this.09:26
wgrantBut that seems a bit evil.09:26
bigjoolsyeah can't do that09:26
bigjoolsor the publisher would have some issues09:26
wgrantNo, there are no publisher problems there.09:26
wgrantBut you seem to have a better solution.09:27
bigjoolswell it would need to re-write indexes09:27
wgrantIf it's Pending, it hasn't written it out in the first place.09:27
bigjoolsanyway I don't have a solution09:27
wgrantOh, right, you just had a reason for it to be a dupe. What is that?09:28
bigjoolsif it's published, it has09:28
wgrantIf it's published, it won't cause itself to be dominated. => not a problem09:28
wgrantHmm.09:28
wgrantAnyway. Why is it a dupe?09:28
bigjoolsI am not particularly familiar with the code there, but you'd surely need to know where it was overridden from09:29
bigjoolsI think it's to do with the fact that the whole overriding mechanism is a bit bong and has many race conditions09:30
bigjoolsI'm still getting it straight in my head09:30
wgrantIf this problem hadn't popped up in ddeb territory too, I would be more likely to place the blame on the fairly strange way that arch-indep publications work.09:31
jmlwgrant, "should be pretty easy" -- famous last words :)09:41
* bigjools nods09:41
wgrantjml: Pfft.09:44
wgrantAdmittedly I didn't see ddeb stuff getting even close to this hairy.09:44
simon-oHi, when I merge a branch is and push it. Is the status of the branch I merged from automatically set to merged?10:05
jmlsimon-o, I think so.10:07
jmlsimon-o, but I think it depends on the branch that was merged into.10:07
simon-ojml: thanks, I guess it just takes some time10:07
jmlsimon-o, only a few minutes, normally.10:07
BjornTjml: it depends on into which branch you're merging into, no?10:07
jmlBjornT, yes, that's what I meant to say :)10:08
jmlalso, we don't mark series branches as merged, since that turns out to be a real pain.10:08
BjornTsimon-o: which two branches did you merge?10:09
simon-oBjornT: I merged lp:~simono/launchpad/xx-links into lp:~launchpad-dev/launchpad/python-migration10:10
simon-oand the MP was set to merged and I wondered what happens to my branch now10:11
BjornTsimon-o: i suspect the status won't change. it's a bit odd, though, since the MP was set to merged, so i would file a bug about it.10:12
wgrantI don't think it's safe to automatically change the branch status in that cas.e10:14
wgrantOr I will start hiding everybody's branches by merging them into mine.10:14
jmlyeah.10:15
simon-owgrant: that's correct, but in which case can you change the status automatically? Because I never changed the status of my branches myself10:15
jmlthe "Merged" status sucks.10:15
jmlsimon-o, when they are merged into trunkp.10:15
BjornTwgrant: why not? he said was intending to merge the branch.10:16
simon-ojml: ok, that makes sense. And it explains why I never saw this before, because I nearly always merge into trunk10:16
wgrantBjornT: Perhaps, but that may not be final. I think it's best to be conservative when making branches disappear.10:17
BjornTwgrant: i said it was odd because there was an MP indicating the intention to merge. if you would merge my branch, without there being an MP to merge into your branch, we should definitely not change the status10:17
jmlsimon-o, right :)10:17
jmljust to be clear10:17
jmlhaving a status of a branch called "Merge" is a misfeature.10:17
jml"Merged", rather.10:17
BjornTwgrant: why show the branch, if there are no new revisions in that branch?10:17
BjornTjml: i agree that the branch status story needs a bit of a re-design10:18
wgrantBjornT: define "new"10:18
BjornTwgrant: revisions in A that aren't in branch B (where B is the branch that branch A was to be merged into)10:19
wgrantPerhaps. It all needs a big rethink.10:20
noodles775thumper: did you mention something recently about counting queries during tests? If so, where can I find it?10:36
noodles775(sorry to disturb your evening if you're already gone!)10:36
jmlnoodles775, it's in the base TestCasue10:40
jmllp.testing.TestCase10:40
noodles775jml: great, thanks.10:40
jmlnoodles775, np.10:40
mwhudsonhello jml10:48
mwhudson(and everyone else!)10:49
jmlmwhudson, hi10:51
jmlmwhudson, mwhudson, http://code.mumak.net/2009/10/command-line-apps.html11:54
=== mpt_ is now known as mpt
=== bigjools is now known as bigjools-lunch
=== matsubara-afk is now known as matsubara
=== mrevell-lunch is now known as mrevell
jmlsinzui, I'm working on a script that maybe will make reviewing projects easier14:03
sinzuiDo you want mine? auto-approve does a lot of nice things14:03
jmlsinzui, http://pastebin.ubuntu.com/293935/ is the output of the first chunk of work: a nice display of useful bits of a project14:04
jmlsinzui, oh, yes please.14:04
jmlsinzui, I couldn't find it in lp-dev-utils.14:04
sinzuiIt is very personal. I codified the rules I observed I used14:04
jmloh.14:04
jmlsinzui, well that's good. I was planning on making something that was still manual, just less manual than the web ui.14:05
sinzuijml: http://pastebin.ubuntu.com/293940/ <- The one aspect that is missing is announcements, They are not exposed in the UI, but I tend to approve when I see them.14:06
=== bigjools-lunch is now known as bigjools
jmlsinzui, what's lpapi?14:09
sinzuijml, the undecided license scenario should be automated in Launchpad because we really need to communicate with the owner that they can easily violate the terms of hosting if they write or choose a non-standard license.14:09
jmlsinzui, agreed.14:09
sinzuijml: lpapi came from launchpadlib14:10
jmlsinzui, is projects.licensing_search restricted in some way?14:38
sinzuiIt is the same search that is used on the review page?14:38
jmlsinzui, it's what auto-approve uses.14:39
jmlsinzui, I don't know if it's what the review page uses.14:39
sinzuithe page that lists the projects uses the license search.14:40
jmlsinzui, I'm getting a 401 Unauthorized error when I try to use it in APIs14:41
jmldoes it require lp.Edit maybe?14:41
jmlahhh, yes it does.14:41
jmlthat's probably a bug.14:41
sinzuiit certainly is if you can use the page, but not the api14:42
jmlsinzui, well, I can use the API, but I need to grant my application "Change" permissions on the oauth page.14:44
jmlsinzui, I shouldn't have to do that to run a search.14:44
sinzuihmm14:44
sinzuiThat script I sent does lots of changes.14:45
jmlsinzui, yes, but me doing a search shouldn't require any changes15:01
=== danilo_ is now known as danilos
sinzuiagreed. I do not think that feature reveals confidential information, but that may need to be vetted15:01
jmlsinzui, even so...15:02
jmlsinzui, that's not what launchpad.Edit is for.15:02
sinzuijml: consider this feature was for a very restricted team of two users until recently15:03
sinzuiI am sure we want to review the rules given that we have opened it up to more users15:03
jmlsinzui, fair enough.15:04
jmlsinzui, the script I've written downloads the entire list of projects to review, and then lets you select '(s)kip (a)pprove (q)uit (d)one'15:05
sinzuisweet.15:05
jmlsinzui, and then, when you are done, it will (not done yet) submit all of the changes to Launchpad15:05
sinzuiDoes it send emails? yet?15:06
jmlsinzui, I'm assuming that the "Approve" action is just "mark approved, mark reviewed, clear whiteboard"15:06
jmlsinzui, do we need to send emails for approval?15:06
sinzuiNo15:06
jmlsinzui, ok. then we'll worry about that when I add a '(r)eject' option :)15:07
sinzuiNor do I think we should send emails to feedback if we want the user to provide more information, but we approved it anyway...because we do not intend to followup wit that15:07
jmlsinzui, yeah. there should be a more info action too.15:10
matsubaragary_poster, rockstar, bigjools, danilos, sinzui, allenap, Chex: LP production meeting in 14 min @ #launchpad-meeting15:46
gary_posterty15:46
danilosmatsubara: if I must, sure :)15:47
matsubaradanilos, you can send someone else, if the timing is not good for you15:49
danilosmatsubara: nah, everybody else (apart from Ursula and me) is on vacation, I am just not feeling too good, but IRC meeting should be something I can handle15:50
matsubaradanilos, ok15:51
jmlbeuno, sinzui, is there any particular reason that we didn't put the series / milestone graph on distros?16:29
sinzuijml: development time16:29
beunojml, IIRC, missing API16:29
sinzuibeuno: API + code16:30
jmlwhat we like to call "work" :)16:30
beunoyes, missing work16:31
sinzuijml: we did not consciously reject it. it is a matter of thousands of project verses 6 distros16:31
jmlsinzui, I guess this means that distros & projects present substantially different interfaces re series & milestones?16:31
* sinzui thinks more code needs to move into PillarMixin and SeriesMixin16:31
jmlsinzui, well, I was thinking more that there should be an ISeries interface that the graph could be written in terms of16:32
sinzuijml ^ Not at all, We need to dismantle the impelmentation into their common parts16:32
jmlhmm.16:32
jmlsinzui, when you implement a series- or milestone-related feature now, do you in general have to do the work twice: once for projects, once for distros?16:33
sinzuijml: I did not focus on distros, but distros, projects, and series all use the same milestone mixin to implement IHadMilestone16:34
jmlok.16:35
sinzuijml: I think you need to keep in mind that these very early objects need more than love, sometimes bombs are needed to remove the cruft. Once the team faltered in February, we focused on the greatest need16:36
jmlsinzui, *nod*16:37
jmlsinzui, my questions were aimed at figuring out whether we should allocate time to cleaning up the model here16:37
sinzuijml: They really do need to be dismantled to bring consistency. There are blocking issues too, like I cannot make compatible urls for distros, projects, and projectgroups without very invasive work16:37
jmlsinzui, I am interested in your ideas and wish to subscribe to your newsletter.16:38
sinzuijml: 15% of registry bugs about removing unused features, or reconcilling behaviour16:38
sinzuijml: Removing the cruft from the models will make launchpad easier to learn because it is consistent. We are maintaining this cruft too.16:41
jmlsinzui, easier to learn is good, but it's not quite as interesting to me as "faster to develop" or "harder to miss things"16:42
jmlsinzui, although they aren't exactly mutually exclusive :)16:43
sinzuijml: my team was create to think about this. It did take me a year to digest every bug and touch all the code to see the big problem. It can also be challenging since these are core object that other teams are making assumptions about16:44
jmlsinzui, I'll bet! :)16:44
jmlsinzui, I imagine that sometimes the other areas of the app are making crappy assumptions.16:45
jmlsinzui, do you have a roadmap for cleaning up the registry, or is it mostly in your head still?16:45
sinzuiyes. but there is still the case were one team does a fab implementation for one pillar, but does not consider that it can be applied to all pillars16:45
sinzuiNo map. My hopes were dashed in March. I really thought the series and project work would let me fix the models16:46
jml*nod*16:47
sinzuiThe bugs are tagged with cleanup, tech-debt, infrastructure.  I can get you a report (using tags) for next week16:48
jmlsinzui, ok. no rush, but it'd be nice to have by UDS.16:48
jmlsinzui, regarding good implementations for one pillar, but not for others16:48
sinzuifor some reason these core bugs keep showing up in my searches. maybe that is why I think they are core16:48
jmlsinzui, that's a problem we really need to solve exactly once.16:49
sinzuiyep16:49
jmlsinzui, where we = you, BjornT & I and whoever else is interested16:49
bigjoolssinzui: so where did you get to with the script failure?16:51
sinzuibigjools: I am subscribed to the list.16:52
bigjoolswhat list?16:53
sinzuiMy filter is on nightly and on (Daemon|script-failures)16:54
sinzuibigjools: I cannot find how I am getting the email. I recall subscribing to a list and configuring to to send only certain classes of emails16:58
bigjoolsisn't it sent to the internal list?16:58
=== salgado is now known as salgado-lunch
=== dpm is now known as dpm-afk
=== beuno is now known as beuno-lunch
mrevellokay, g'night friends18:02
=== matsubara is now known as matsubara-lunch
=== beuno-lunch is now known as beuno
=== salgado-lunch is now known as salgado
sinzuibarry, bac, EdwinGrubbs: release meeting in 2 minutes18:59
=== matsubara-lunch is now known as matsubara
dobeyhrmm20:09
dobeykfogel: ping20:09
=== salgado_ is now known as salgado
=== ursula_ is now known as Ursinha
barrythumper, mwhudson ping20:36
mwhudsonbarry: good morning20:36
barrymwhudson: hi.  do you have a few minutes to join a discussion going on in #launchpad-sprint?20:37
barrywe're working on the py2.4 -> 2.5 upgrade and there are soem questions about a codehosing test20:37
barryer, code hosting20:37
barry:)20:37
mwhudsonjml: did you get my twisted talk slides?21:13
EdwinGrubbssinzui: ping21:34
sinzuiHi EdwinGrubbs21:34
mwhudsonrockstar, abentley: i feel like i'm lagging horribly on this call21:34
mwhudsonback to os x tomorrow then i guess21:35
EdwinGrubbssinzui: I was thinking about removing the "PPA Packages" link from the person/team index page since there is already a link next to it to the "Related projects" page, and that page has a menu with a link to the "PPA Packages".21:36
sinzuihmm21:36
sinzuiThere are two problems here isn't there? One link is to *related* PPAs which I do not own and *Owned* PPAs21:37
EdwinGrubbssinzui: correct. The related PPAs are ones that contain a package that was created by that person, although it may have been copied into that PPA by someone else.21:39
sinzuiyes, so we need to keep those links distinct. I would prefer to remove all *related* paages since no one can say what they are for21:39
EdwinGrubbssinzui: that sounds like a soyuz bug to me.21:40
sinzuiEdwinGrubbs: they say we own it, which is why I think I have the right to remove them21:40
bigjoolssinzui: I21:41
bigjools'm sure I told you a few times21:41
sinzuiEdwinGrubbs: https://edge.launchpad.net/~launchpad <- the links under kiko need to read21:42
sinzui    (i) Related project  (i) Related PPA packages21:42
sinzuibigjools: You have said that user can see packages and software. But since there are no actions that can be taken from that information I do not value it21:43
bigjoolssinzui: I said that the MOTUs use it to review new MOTU applicants' work21:44
sinzuibigjools: https://edge.launchpad.net/~sinzui/+related-software21:44
sinzui^ is a bug fat lie and I do not want anyone to every see that lie21:44
sinzuibigjools: so do we need to see projects and PPAs? Packages are the motu work?21:45
sinzuibigjools: And what is the action item? Add this user to the motu team?21:45
bigjoolsyes21:45
bigjoolsor not add21:45
bigjoolsbut I suggest you talk to wgrant about it as he's our MOTU contact21:46
sinzuiSurprisingly I did not get a persuasive reason.21:46
bigjoolsand dare I say it, ScottK21:47
sinzuiGiven that wgrants opinions are viable/doable items, I took the ambiguity to  mean it is not important21:48
bigjoolswhat is it you want to remove exactly?21:48
sinzui+uploaded-packages,  +ppa-packages, +related-projects because they seem to guess wrong most of the time about what is truely related21:49
sinzuiIf I had a real story/use case, I think I would create an very different feature from how these fail to operate21:50
bigjoolsok well my advice is to talk to more people first, since I had some very irate users in the past complaining about the performance of those pages21:50
sinzuiEdwinGrubbs: I do not think you can trust the related portlet to always display. I only appears if a team owns a project, but a team can manage packages and PPAs with out ever owning a project21:56
EdwinGrubbssinzui: I was referring to the "Related projects" link and not the portlet. According to the sourcecode, the "Related projects" link is always displayed above the yui grid.22:03
sinzuiThat is true22:03
EdwinGrubbssinzui: do you want me to track down the people involved or just send out an email to launchpad-dev?22:09
sinzuiEdwinGrubbs: Fixing those pages are out of scope for this release. I think packaging is in scope for 3.1 and we should fix that feature22:11
EdwinGrubbssinzui: are you talking about packaging as in the planning meeting we just had or as in the "PPA packages" link?22:13
sinzuiEdwinGrubbs: be mindful when we remove links or information from a page because there is no information, users then file bugs that they spent 2 hours searching launchpad for the information. When I reply that is because there was nothing to be found, the user states if we knew that we should have made that clear before he wasted 2 valuable hours of his life.22:13
sinzuiEdwinGrubbs: You are working on a UI bug and we need to keep the scope at that. We start new work next release22:14
EdwinGrubbssinzui: it sounds like you are saying, "don't spend a lot of time on it, but don't just remove the link." This brings us back to your suggestion to use "Related PPA packages", which sounds fine to me, but the conversation after that confused me.22:19
sinzuisorry22:20
sinzuiEdwin: there are two issue with the bug. 1) two links with the same name. we need to fix the name of +ppa-packages. The other +archive/ppa should not be shown if there the user does not own a PPA22:22
sinzuiEdwinGrubbs: and the +archive/ppa can be empty22:23
sinzuiEdwinGrubbs: we might able to remove all but the related software links from person and teams. We rename the single link (i) Related software and packages.22:25
=== ursula is now known as Ursinha
jmlmwhudson, I did.22:26
mwhudsonjml: great22:26
jmlmwhudson, I've replied to exactly three emails that required thinking today.22:26
EdwinGrubbssinzui: the +archive/ppa link only appears if that ppa exists. Compare /~launchpad and /~launchpad-dev. An empty PPA needs to be listed just like an empty series does. +1 on the "Related software and packages" link.22:26
mwhudsonjml: :)22:27
mwhudsonjml: no real hurry22:27
mwhudsonwell, the conference guy wants slides by monday, but i have a long and proud history of ignoring deadlines like that22:28
sinzuiEdwinGrubbs: I am sure we are showing all the links to avoid changing lots of tests that test their presence from the old nav menu. Feel free to delete the redundant tests22:28
EdwinGrubbsok, cool22:29
=== salgado is now known as salgado-afk
=== matsubara is now known as matsubara-afk
wgrantsinzui, EdwinGrubbs: +uploaded-packages is critical to Ubuntu developer review workflows.23:27
sinzuiwgrant: great how is it used what should link to it and what should it link to or actions it should contain23:28
EdwinGrubbswgrant: our current plan is just to have a single link to +related-software, and that page will keep its links to +uploaded-packages, +ppa-packages, and +related-projects.23:28
wgrantsinzui: It just needs to be somehow accessible, and needs to contain links to all SPRs in the primary archive where the person is mentioned in Changed-By.23:30
wgrantSo exactly what it does now.23:30
sinzuiWhy do you want to see it?23:30
wgrantSo that the MOTU Council (or new Developer Membership Board) can see what a prospective developer has done.23:31
sinzuiwgrant: Fab23:31
sinzuiDo you use the ppa or releated software views?23:32
wgrantPPA occasionally.23:33
wgrantBut projects are not relevant, and usually incorrect.23:33
sinzuiwgrant: I think these pages might be better if they contained information about motu with links about how to become a motu.23:34
wgrantsinzui: I don't think so.23:34
wgrantThat's not the sort of thing LP does.23:35
sinzuimaybe it should. Launchpad has packaging and package linking features that do a poor job of explaining their value. Launchpad could do  a better job mobilising users and getting bug and code upstream23:36
sinzuimaybe the person and team page should include latest packages uploaded like it should include latest branches and merge proposals23:38
wgrantThat would indeed make sense.23:39
sinzuiThe distroseries page is not what I wanted to do. The top of the right column should be something that needs to be done or can be done right now to contribute. I think  linking package to upstream might be what belongs there.23:40
sinzuiI wonder how much labour is needed to repurpose the sparkline code to show other activities link package uploads, linking, bug fixes.23:42
mwhudson!!23:50
mwhudsonno gpg-agent in karmic?23:50
maxb?23:53
mwhudsonwell, not installed any more it seems23:53
sinzuimwhudson: I had some issues with it a few days ago. I need a good kick. bac also had issues with it23:57

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!