[09:29] <noodles775> bigjools: just looking at the comment that you added to DistributionPPASearchView - "There really should be a way for the form to reject unexpected...." - isn't the issue there really that we're not using an LPForm?
[09:30] <noodles775> (ie. we'er using request.get - which is accessing the data directly from the GET dict?)
[09:31] <bigjools> noodles775: what else could it do?
[09:31] <noodles775> bigjools: if the view was inheriting from LaunchpadFormView we could be using request.form?
[09:31] <noodles775> ... at least - I think - checking now.
[09:43] <noodles775> OK, so if we used a safe_action in an LPFormView the validation would take care of this automatically (as it validates against the form schema).
[10:30] <noodles775> bigjools: r=me (just a question about the comment).
[10:33] <bigjools> noodles775: umm I have no answer to that :)
[10:33] <noodles775> bigjools: no answer (as to whether we should use LPFormView)?
[10:33] <bigjools> it seemed like a follow-on from the part above so it made sense at the time to run on the comment
[10:34] <noodles775> Ah, I'd forgotten about that question :), ok.
[10:34] <bigjools> :)
[10:38] <adeuring> noodles775: could you review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-6/+merge/13402 ?
[10:38] <noodles775> adeuring: sure!
[10:38] <adeuring> noodles775: thanks!
[11:15] <bigjools> noodles775: I have changed the comment in that code
[11:15] <noodles775> bigjools: k.
[11:15] <bigjools> I removed the XXX and explained that it's better to be helpful and join the terms
[11:16] <noodles775> bigjools: ah - great.
[11:17] <bigjools> http://pastebin.ubuntu.com/293807/ if you're interested
[12:54] <noodles775> adeuring: r=me - sent with a few comments :)
[12:54]  * noodles775 -> lunch
[13:19] <adeuring> noodles775: thanks!
[14:20] <salgado> noodles775, no need to review that branch of mine.  barry's on it
[14:20] <noodles775> salgado: ah ok - I was just about to start :) Thanks.
[14:21] <noodles775> aw, and it's so small :)
[14:25] <barry> ocr's: you don't have to review any merge into lp:~launchpad-dev/launchpad/python-migration.  we're sprinting on that in #launchpad-sprint
[14:26] <noodles775> k, thanks barry.
[15:26] <adeuring> noodles775: fancy to review a sequel of my last branch?
[15:26] <noodles775> adeuring: sure!
[15:26] <adeuring> noodles775: thanks! https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-class-udev-device-7/+merge/13413
[15:27] <noodles775> adeuring: yikes, 1070 lines - I'm hoping that includes the -6 branch?
[15:28] <noodles775> *phew* looks like it.
[15:28] <adeuring> noodles775: sigh, I screwed up the "bzr send" command. Should 273 lines...
[15:28] <noodles775> aha, np.
[15:29] <adeuring> noodles775: clould you use the diff between revisions 9694 and 9695?
[15:29] <noodles775> adeuring: yep, np.
[15:29] <adeuring> noodles775: (the branch is based on the one you reviewed earlier. Has not yet landed)
[16:03] <noodles775> adeuring: r=me, there was one change that I was unsure of (see the comment). Thanks!
[16:03] <adeuring> noodles775: thanks!
[16:03] <noodles775> np
[17:40] <adeuring> rockstar: fancy a review of a branch with 20 line diff?
[17:42] <rockstar> adeuring, oh yeah, it's thursday, I forgot...
[17:42] <adeuring> rockstar: no problem ;) https://code.edge.launchpad.net/~adeuring/launchpad/bug-446600/+merge/13430
[17:42] <rockstar> adeuring, shoot it on over.
[17:49] <rockstar> adeuring, r=me
[17:49] <adeuring> rockstar: thanks!
[18:15] <gary_poster> rockstar: you up for a 46-line lazr.restful diff?  https://code.edge.launchpad.net/~gary/lazr.restful/fix-wadl-root-template/+merge/13429
[18:16] <rockstar> gary_poster, sure.
[18:16] <gary_poster> thanks
[18:18] <rockstar> gary_poster, r=me, come back when you have a real diff.  :)
[18:18] <gary_poster> rockstar lol thanks :-)
[18:53] <gary_poster> salgado: ping?