[09:55] <allenap> jml: Are you still part of the OCR rotation? In any case, https://dev.launchpad.net/ReviewerSchedule still has you down for AsicPac.
[10:02] <jml> allenap, I'm taking a temporary leave of absence
[10:03] <jml> allenap, I'll reschedule myself sometime soon.
[12:21] <danilos> adeuring: hi, I've got a branch up for review, can you take it? :)
[12:21] <adeuring> danilos: sure
[12:22] <danilos> adeuring: thanks, it's https://code.edge.launchpad.net/~danilo/launchpad/bug-435398/+merge/13462 (I've hit a bug submitting via email, so diff should be there in a minute or two if not already up)
[12:52] <adeuring>  danilos: nice work! just one question about a change you did not describe: In line 205 of the diff you remove "/+translations" from a link. Is this intentional, and if so, why?
[12:53] <danilos> adeuring: yes, it doesn't make much difference in practice, because that's the default anyway, but would allow us to change the default easier in the future without worrying of breaking unrelated tests (such as this one)
[12:54] <adeuring> danilos: ah, thanks. So, r=me
[12:56] <noodles775> Hi adeuring! I've got a straight-forward view/template change that should arrive in your inbox in a minute or two.
[12:56] <adeuring> noodles775: ok
[12:57] <noodles775> adeuring: how are you going with those hwdb changes? Looks like a huge change (great to see lots of small branches!)
[12:57] <noodles775> it's been going for a couple of weeks now right?
[12:58] <adeuring> noodles775: I noticed that I made some embarassingly wrong assumptions in the test data, so I'm updating tests again ;)
[12:58] <adeuring> noodles775: yes, I'm working on this tsuff since two weeks or so. I hope that the changes will be finished next week
[12:58] <noodles775> adeuring: is there anyone else who's familiar with all the udev stuff that could review those type of things for you?
[12:59] <adeuring> noodles775: i don't think so...
[12:59] <noodles775> s/that/who
[12:59] <noodles775> ok.
[12:59] <danilos> adeuring: thanks
[13:01] <noodles775> adeuring: here it is: https://code.launchpad.net/~michael.nelson/launchpad/430459-link-build-failures-updates-portlet/+merge/13463
[13:01] <noodles775> thanks!
[13:02] <noodles775> intellectronica: would you have time for a UI review? It's "quite straight forward". See ^^^ before you answer :)
[13:02] <intellectronica> noodles775: sure
[13:02] <noodles775> Thanks!
[13:04] <intellectronica> noodles775: it looks really nice. the only problem i have with it is that the error icon looks just like the remove icon. i guess that's out of scope for this branch, though?
[13:04] <intellectronica> is this icon new, or something that is all over the place in soyuz?
[13:05] <noodles775> intellectronica: do you mean the failed to build icon?
[13:05] <intellectronica> noodles775: yes
[13:05] <noodles775> intellectronica: yes, according to https://edge.launchpad.net/+graphics it's specifically for build-failed...
[13:06] <noodles775> so we use it wherever we indicate failed builds. (part of the new icons that landed during 3.0)
[13:07] <intellectronica> noodles775: well, it's worth asking beuno what he thinks of that critique of the icon. i know he's been focusing on icon semantics quite a lot lately. other than that the change looks really good, so ui=me*
[13:07] <noodles775> intellectronica: thanks. It's one of the set that beuno introduced a few months ago, but yep, it'd be good to let him know of that confusion.
[13:13] <adeuring> noodles775: r=me
[13:13] <noodles775> thanks adeuring !
[13:20] <noodles775> hey jml: just noticed that you're a ui* reviewer? Would you have 5mins to do a second ui* review for me (it already has ui*=intellectronical, but most of the other ui reviewers are sprinting/not here yet).
[13:20] <noodles775> https://code.launchpad.net/~michael.nelson/launchpad/430459-link-build-failures-updates-portlet/+merge/13463
[13:21] <noodles775> s/tronical/tronica ;)
[13:21] <jml> noodles775, sure thing. fwiw, I don't get it done in the next 30 mins, I won't be able to get around to it today.
[13:22] <jml> _if_ I don't get it done, rather.
[13:22] <noodles775> jml: thanks. np, if you're too busy - just leave it - I can grab one of the US guys later.
[13:26] <jml> noodles775, well, I'd like to at least _try_ to do it :)
[13:53] <jml> noodles775, sorry, I've failed.
[13:53] <noodles775> jml: no probs, thanks for trying :)
[14:00] <noodles775> rockstar: are you able to do a second ui review for me?
[14:00] <noodles775> https://code.launchpad.net/~michael.nelson/launchpad/430459-link-build-failures-updates-portlet/+merge/13463
[14:13] <barry> adeuring: i'm not sure how much reviewing salgado and i are going to do today.  we're sprinting.  if it's okay with you i'd like to avoid non-sprint related reviews at least until you go offline
[14:13] <barry> adeuring: but ping me if the queue gets too long
[14:13] <adeuring> barry: OK, thnkas for the heads-up. But up to now it was a really quit day
[14:35] <noodles775> adeuring: could you look at another trivial branch for me?
[14:35] <noodles775> https://code.edge.launchpad.net/~michael.nelson/launchpad/219222-edit-ppa-dependencies-rename/+merge/13468
[14:36] <adeuring> noodles775: sure
[14:36] <noodles775> intellectronica: would you mind doing a ui review for the above too? (sorry, no one else is around)
[14:36] <noodles775> adeuring: thanks.
[14:37] <noodles775> s/around/around or available due to sprints etc.
[14:48] <bac> adeuring: may i add a small branch to your queue?
[14:48] <adeuring> bac:  sure
[14:48] <bac> adeuring: great.  i'll paste the MP when it arrives
[14:50] <adeuring> noodles775: r=me
[14:50] <noodles775> Thanks again adeuring.
[14:50] <adeuring> welcome :)
[15:06] <adeuring> bac: bug 436986 says that the map is already limited to 24 items. You set self.limit = 24 for class TeamMapLtdData. Couldn't you recycle the constant mentioned in the bug?
[15:06] <mup> Bug #436986: Person:+index (map_portlet_html) timeout <post-3-ui-cleanup> <timeout> <Launchpad Registry:In Progress by bac> <https://launchpad.net/bugs/436986>
[15:07] <bac> adeuring: the limit mentioned in the bug was being realized at line 62 of the diff, but it did not work
[15:08] <bac> adeuring: i should have a constant so i don't re-use 24 at lines 84 and 99
[15:08] <adeuring> bac: Ah, thanks, I missed that line in the diff. And right, please use a constant for both classes.
[15:09] <bac> gladly
[15:12] <adeuring> bac: one more question: your tests do not really show that the map is indeed limited to 24 items. Could you change the test in team-map.txt so that we really see that no more than TeamMap.limit items are returned? (probably with a modified version of TeamMap, where limit is 2)
[15:13] <adeuring> ...erm, I meant class TeamMapData....
[15:14] <bac> adeuring: i should have worded that test more clearly.  i'd like to use it to show the URL works but not necessarily the limit.  the limit is exercised in the team-views.txt test. with additional explanation in the first do you think that'd be sufficient?
[15:15] <adeuring> bac: well, you show the constant there, but you don't show that the constant has any effect ;)
[15:15] <bac> which there?
[15:15] <bac> in team-views.txt the constant is there.  it is then set to 1 to show it does have affect?
[15:15] <adeuring> bac: Ahhh, I missed that.
[15:16] <adeuring> bac: thanksfor the explanantions. r=me
[15:16] <bac> adeuring: np.  thanks for the review!
[15:25] <bac> with non-batched email from LP it is weird to see the email arrive before the web page refreshes when you update a MP
[16:48] <sinzui> adeuring: barry: I have a mechanical branch for review: https://code.edge.launchpad.net/~sinzui/launchpad/package-link-validation/+merge/13484
[16:48] <adeuring> sinzui: I'll look
[16:49] <barry> adeuring: thanks.  i'm doing a hairy one for gary on #launchpad-sprint (barry does hairy gary branch?  ewwee)
[16:49] <gary_poster> heh
[17:15] <adeuring> sinzui: r=me
[17:21] <sinzui> adeuring: thank you very much
[17:22] <adeuring> sinzui: welcome :)
[17:35] <bac> adeuring: you have time for another or should i wait for barry?  it's complicated by the fact i'm about to leave for lunch.
[17:35] <adeuring> bac: one more branch is fine, but after that I'll leavem I think ;)
[17:36] <bac> hey barry are you going to be reviewing after lunch?
[17:38] <bac> thanks abel.  i'll answer any questions you have when i return.
[18:14] <adeuring> bac: r=me
[18:25] <abentley> adeuring: Could you please review https://code.launchpad.net/~abentley/launchpad/ignore-md-diff/+merge/13491 ?
[18:26] <adeuring> abentley: sure
[18:28] <abentley> adeuring: Thanks.  Btw, have you tried the inline reviewing?
[18:29] <adeuring> abentley: no. How do I do this?
[18:30] <abentley> There is a comment/review box below the comments.
[18:32] <adeuring> abentley: ah, that's what you meant ;) I'll try it
[18:34] <adeuring> abentley: r0me
[18:34] <abentley> adeuring: Thanks!
[19:00] <bac> thanks adeuring
[20:43] <bac> hi beuno, can you do a UI review?  i've got screenshots!
[20:43] <beuno> bac, hit me
[20:43] <bac> https://code.edge.launchpad.net/~bac/launchpad/bug-452491-captcha2-boogaloo/+merge/13487
[20:44] <bac> beuno: it's adding a captcha to the 'i forgot my password' page.  also fixes some spacing on the error message from the login page
[20:45] <beuno> bac, why are the forms different than everywhere else?
[20:45] <beuno> where the label is on top
[20:45] <beuno> I know, I know, nothing to do with your branch
[20:45] <bac> beuno: don't know.  these pages do not use LaunchpadFormView -- they do everything by hand.  a huge PITA
[20:46] <beuno> bac, gotcha
[20:46] <bac> beuno: converting them to LPFV would be a good tech-debt branch
[20:46] <beuno> approved