[01:03] <wgrant> sinzui: +uploaded-packages did not show superseded packages for a time. It *needs* to continue to show superseded packages.
[01:03] <wgrant> +ppa-packages should probably do the same (for consistency), but it is not as important.
[01:04] <wgrant> But your argument that you would expect to see downloadable packages isn't really valid; if I wanted to see downloadable packages I would go to the PPA's page.
[03:14] <thumper> https://code.edge.launchpad.net/~thumper/launchpad/branch-no-active-reviews/+merge/13610 anyone?
[05:21] <mwhudson> thumper: can you review https://code.edge.launchpad.net/~mwhudson/launchpad/in-memory-launchpad-server/+merge/13613 ?
[05:21]  * thumper looks
[05:25] <thumper> mwhudson: https://code.edge.launchpad.net/~thumper/launchpad/branch-no-active-reviews/+merge/13610 ?
[05:25] <thumper> mwhudson: there were two other BMPs created in the two hours between these
[05:26] <mwhudson> thumper: my question about that was "why do branches implement icanhaslinkedbranch then?"
[05:26] <mwhudson> but i guess i probably don't want to know
[05:26] <mwhudson> thumper: yeah, that's lame
[05:26] <thumper> mwhudson: branches implement IHasMergeProposals
[05:26] <thumper> because you can get the merge proposals for a branch
[05:27] <mwhudson> oh right
[05:27] <mwhudson> maybe you should be able to adapt ibranch to ibranchcollection in some sense?
[05:27] <mwhudson> never mind
[05:27]  * mwhudson approves
[05:28] <mwhudson> although i think i broke some js somehow
[05:28] <thumper> mwhudson: maybe
[05:29] <thumper> perhaps that is the better option
[05:29] <thumper> although it seems a bit artificial to create a branch collection for exactly one branch
[05:30] <mwhudson> well, i guess a question is, is $branch_url/+activereviews going to be a useful thing?
[05:31] <mwhudson> (and how would it be different from +merges?)
[05:47] <thumper> mwhudson: I've started looking through your change, but I need to go make dinner
[05:48] <thumper> it is quite long :)
[05:48] <mwhudson> thumper: yeah, it's fairly hairy
[05:48] <mwhudson> thumper: if you don't get to it can you send jml a mail about it?
[05:48] <thumper> ok
[05:49] <thumper> hmm.. ec2 land can't find the public branch location
[05:49] <thumper> bzr info can
[05:50] <thumper> pebkac
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== henninge_ is now known as henninge
[11:44]  * gmb -> afk for a bit
=== mrevell is now known as mrevell-lunch
=== matsubara-afk is now known as matsubara
=== mrevell-lunch is now known as mrevell
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -|| queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:04] <bac> good morning
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,jtv || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:24] <abentley> gmb, bac: Could I have a review of https://code.edge.launchpad.net/~abentley/launchpad/parse-binary/+merge/13600 please?
[14:24] <intellectronica> gmb: can i interest you in a very short patch>
[14:24] <bac> abentley: sure
[14:24] <gmb> intellectronica: Certainly.
=== bac changed the topic of #launchpad-reviews to: on call: gmb,bac || reviewing: -,jtv || queue: [abentley] || This channel is logged: http://irclogs.ubuntu.com
[14:24] <abentley> bac: tx
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: abentley, intellectronica || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:25] <intellectronica> gmb: http://pastebin.ubuntu.com/297491/ disables the filebug redirection for ubuntu packages
[14:26] <gmb> intellectronica: r=me.
[14:26] <intellectronica> gmb: thanks
[14:30] <gmb> bac: I'm going to go off-call to deal with a pressing OOPS problem with +filebug. If it gets busy, please ping me and I'll come back.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: abentley || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:31] <bac> gmb: righto
[14:34] <intellectronica> with the current version of utilities/ec2 i can't submit a branch, because it complains about bzr's pqm plugin missing. any idea what's going on?
[14:34] <intellectronica> i can run without a problem with older versions
[14:42] <intellectronica> bac: maybe you have a clue? ^^^^^
[14:42] <bac> intellectronica: haven't seen it.  have you asked allenap, our build engineer?
[14:43] <intellectronica> no, allenap would be a good person to ask indeed
[14:43]  * allenap looks
[14:43] <bac> intellectronica: curious to hear what you find out.  was there a new version from yesterday?  it worked for me yesterday morning.
[14:43] <allenap> intellectronica: Can you paste the failure?
[14:44] <intellectronica> bac: the latest revisions are from yesterday and the day before. i don't know when it happens because i was using old versions on those days
[14:45] <intellectronica> allenap: http://pastebin.ubuntu.com/297511/
[14:47] <allenap> intellectronica: I have an idea.
[14:48] <intellectronica> allenap: b.t.w don't tell anyone, but the machine i'm running this on is running jaunty. could it be that the update to make it work with karmic broke working with a previous version?
[14:49] <allenap> intellectronica: Only yesterday a change was made to utilities/ec2 to make it use python2.4.
[14:49] <allenap> intellectronica: Mmm, I don't know if that will matter...
[14:50] <allenap> Okay, so maybe /usr/bin/python could see the pqm plugin okay, but /usr/bin/python2.4 can't.
[14:51] <bac> thanks abentley.  r=bac
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:52] <allenap> intellectronica: Try /usr/bin/python2.4 -m bzrlib.plugins.pqm
[14:52] <allenap> intellectronica: And the same with just /usr/bin/python.
[14:52] <abentley> bac: Thanks!
[14:53] <allenap> gary_poster: I think you changed the interpreter in utilities/ec2 to be python2.4. I thought that boto didn't work with python2.4?
[14:54] <gary_poster> allenap: uh, dunno, working for me. you encountering a problem?
[14:54] <gary_poster> allenap: btw thank your for buildbot config fix.  will review asap
[14:55] <allenap> gary_poster: I haven't looked at it on karmic yet (only upgraded yesterday), but I seem to remember that boto used some python2.5+ features. Of course, I can't remember what now. If it works then I shouldn't complain :)
[14:57] <allenap> intellectronica: Anyway, try doing /usr/bin/python utilities/ec2
[14:58] <gary_poster> allenap: :-) ok.  I'm on karmic and it is working for me.  We have a LP Python 2.5 branch with passing tests also, btw, but can't land it till LOSAs have bandwidth.  We're trying to make it to 2.6.
[14:59] <gary_poster> allenap: I changed the ec2 script because it wasn't working for me without that change...I'll dig into it if you need me to.
[14:59] <allenap> gary_poster: If you can remember, I'm interested to know why, but don't spend time digging.
[15:00] <allenap> gary_poster: Though I suspect that, like for intellectronica, it won't work for me now :-/
=== danilo__ is now known as danilos
[15:01] <gary_poster> allenap: I don't remember and have four other conversations pending. ;-) If you take out the change and it works for you, revert that bit with my blessing.  We may need to look at it more closely later, but not blocking is important, and I'd prefer not to consume the bandwidth on it ATM
[15:01] <allenap> gary_poster: That works for me.
[15:01] <gary_poster> allenap: thank you
[15:04] <intellectronica> allenap: with /usr/bin/python i get a different error
[15:04] <allenap> intellectronica: Progress :)
[15:05] <intellectronica> yeah, that's what theoretical scientists call "problem shift" :)
[15:05] <allenap> I need to remember that :)
[15:05] <intellectronica> allenap: http://pastebin.ubuntu.com/297523/ is what i get
[15:06] <allenap> intellectronica: Oh my.
[15:06] <adeuring> bac: could you please review this MP: https://code.edge.launchpad.net/~adeuring/launchpad/hwdb-build-udev-device-list/+merge/13644 ?
[15:07] <bac> adeuring: i'm on it!
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: abel || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:07] <adeuring> bac: thanks!
[15:12] <allenap> intellectronica: Okay, I'm clutching at straws now, but could you try: rm _pythonpath.py && bin/buildout && utilities/ec2
[15:13] <intellectronica> allenap: i find it hard to believe that this would matter in a new branch, but let me try
[15:13] <intellectronica> allenap: yeah, that didn't help
[15:13] <allenap> intellectronica: Oh, a new branch.
[15:18] <gary_poster> intellectronica, allenap: I think I know what the problem is, in vague terms, though I don't know why the current version works for me and breaks for intellectronica.  I can at least do a quick call with allenap to share the details and maybe also come up with a solution.  Again, I'm also fine with a revert (of just this file, he said nervously!) if that helps
[15:19] <intellectronica> gary_poster: it's not urgent to fix this, since i can continue using the older revision locally. i just wanted to alert you guys to the problem
[15:19] <gary_poster> intellectronica: got it, thank you
[15:20] <allenap> gary_poster: If intellectronica is okay for now then it sounds like you've got more pressing things to do. I'll see if I can figure something out anyway; I have other suspicions.
[15:21] <achuni> bac: if you really have the time, thanks:
[15:21] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip1/+merge/13351
[15:21] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip2/+merge/13362
[15:21] <achuni> https://code.launchpad.net/~canonical-isd-hackers/canonical-identity-provider/wip/+merge/13363
[15:21] <achuni> https://code.launchpad.net/~canonical-isd-hackers/shipit/sso-test-fixes/+merge/13643
[15:21] <achuni> (in that order)
[15:22] <gary_poster> allenap: ok cool, thank you.  Is it failing for you?
[15:22] <allenap> gary_poster: No, actually, it seems fine.
[15:25] <gary_poster> allenap: ah. :-/  yeah, diagnosing is hard when it works locally.  The error looked like bzr was not finding its site-packages plugins, which makes sense, because launchpad's bzr version would mask the site-packages version.  
[15:25] <gary_poster> I'm not exactly sure why it *is* working for me (and others) now.  It would be interesting to try adding the pqm-submit plugin to launchpad's bazaar-plugins directory and then have ec2 set the bzr environ variable to look there for plugins.  That's a hack though.  ...again, being able to dupe would be nice.
[15:27] <intellectronica> oh, are we now using a bzr version other than the site-installed one?
[15:27] <allenap> gary_poster: I've just realised that I have the pqm plugin installed in ~/.bazaar/plugins, which might account for why it's finding it for me.
[15:28] <allenap> intellectronica: The change to utilities/ec2 made it use the bzrlib in the lp tree, via the egg.
[15:28] <gary_poster> allenap, intellectronica: yes
[15:29] <gary_poster> (a nice advantage is that ec2 can now be put somewhere in your path (I have a symlink in ~/bin) and it works)
[15:29] <allenap> intellectronica, gary_poster: Perhaps we should add bzr-pqm to setup.py and let it take care of it.
[15:29] <allenap> s/it/buildout
[15:30] <gary_poster> allenap: maybe.  I don't think bzr-pqm is available as a python package; Martin Pool and I were going to talk about that at some point
[15:31] <gary_poster> allenap: if we were going to do that, I'd be tempted to do that in a slightly different way so that lp itself doesn't depend on the egg, just the script
[15:38] <bac> achuni: can you subscribe me to those branches?  i don't have access.
[15:38] <sidnei> heya, any candidate for a lazr-js review? 
[15:38] <sidnei> https://code.edge.launchpad.net/~sidnei/lazr-js/jstestdriver-support/+merge/13645
[15:38] <achuni> bac: sure, one sec
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:42] <achuni> bac: subscribed
[15:42] <allenap> intellectronica: As a work-around, it'll probably be enough to bzr branch lp:bzr-pqm ~/.bazaar/plugins/pqm
[15:42] <bac> achuni: thanks.  i can see it now.
[15:42] <achuni> great
[15:44] <intellectronica> allenap: aha! problem shift, once again :) http://pastebin.ubuntu.com/297560/
[15:46] <allenap> intellectronica: Ah! This version of boto won't work with python2.4.
[15:46] <allenap> intellectronica: Can you do python -c 'import boto; print boto.Version'
[15:46] <allenap> intellectronica: I have 1.8d
[15:47] <allenap> I'm on karmic.
[15:47] <intellectronica> allenap: 1.5b
[15:47] <intellectronica> what a strange versioning scheme
[15:48] <allenap> intellectronica: Yeah! I wonder if 1.8d is python2.4 compatible, and 1.5b not.
[15:48] <intellectronica> it sounds unlikely that an older version will be less compatible with an older version of python, but who knows
[15:51] <allenap> intellectronica: The README says "Efforts are made to keep boto compatible with Python 2.4.x but no guarantees are made."
[15:51] <allenap> intellectronica: So it could go back and forth.
[15:53] <allenap> intellectronica: Let's bypass utilities/ec2 altogether! PYTHONPATH=lib python -c 'from devscripts.ec2test.entrypoint import main; main()'
[15:54] <allenap> intellectronica: In the next week or so LP will be python2.5 at least so this problem will go away... I hope.
[15:54] <intellectronica> allenap: yeah, that works
[15:55] <allenap> intellectronica: Woohoo! I'll send an email to the list for anyone else who is suffering.
[15:55] <intellectronica> allenap: thanks
[16:05] <sidnei> i wonder if i should append myself to the queue ;)
[16:32] <bac> sidnei: you have a branch?  append away
[16:32] <bac> achuni: i've done wip1 with some comments.
=== sidnei changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei] || This channel is logged: http://irclogs.ubuntu.com
=== salgado is now known as salgado-lunch
[16:35] <bac> sidnei: do you have an URL for your branch?  i don't see it on +activereviews for lp
[16:35] <sidnei> bac: it's a lazr-js branch https://code.edge.launchpad.net/~sidnei/lazr-js/jstestdriver-support/+merge/13645
[16:35] <bac> sidnei: thanks.  i'll get right on it but will break for lunch in a bit
[16:35] <sidnei> bac: no hurry
[16:35] <achuni> bac: thanks
[16:36] <bac> sidnei: if i'm uncomfortable with the javascript i may defer.  just letting you know.
[16:36] <sidnei> bac: that's fine, yeah.
[16:37] <bac> sidnei: er, the diff is 3500 lines.  is that a mistake?
[16:38] <sidnei> bac: it's based on https://code.edge.launchpad.net/~bjornt/lazr-js/buildoutification, which might have not been merged yet
[16:38] <bac> sidnei: can i get you to make an accurate diff and paste it?
[16:38] <sidnei> bac: supposedly yeah :)
=== matsubara is now known as matsubara-lunch
=== bac changed the topic of #launchpad-reviews to: on call: bac-lunch || reviewing: achuni || queue: [sidnei] || This channel is logged: http://irclogs.ubuntu.com
[16:51] <sidnei> bac: here https://pastebin.canonical.com/23563/
=== deryck is now known as deryck[lunch]
=== salgado-lunch is now known as salgado
=== matsubara-lunch is now known as matsubara
=== beuno is now known as beuno-lunch
[18:11] <leonardr> bac-lunch, please add https://code.edge.launchpad.net/~leonardr/lazr.restful/2.6/+merge/13653 to your queue
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei] || This channel is logged: http://irclogs.ubuntu.com
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei, leonard] || This channel is logged: http://irclogs.ubuntu.com
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei, leonardr] || This channel is logged: http://irclogs.ubuntu.com
[18:40] <gary_poster> bac, leonardr I already reviewed that one.  changing topic
=== gary_poster changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei] || This channel is logged: http://irclogs.ubuntu.com/
[18:41] <bac> thank gary_poster
[18:41] <gary_poster> :-) welcome
[18:46] <bac> sidnei: why did you change the DOCTYPE spec to have 'http:///' with three slashes?
[18:46] <sidnei> bac: might have been a bad search & replace.
[18:47] <bac> sidnei: ok.  yeah, it looks pretty funny
[18:52] <sidnei> ok, fixed those
[19:02] <bac> sidnei: where did yui.patch.js come from?  is it an official YUI patch?  should you include some attribution or reference?
[19:03] <sidnei> bac: it was from jstestdriver itself. maybe there should be some attribution yeah.
[19:07] <bac> sidnei: done
[19:07] <sidnei> bac: you rock. thanks!
[19:18] <EdwinGrubbs> bac: Can I put this in your queue? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-435260-duplicate-links/+merge/13657
[19:18] <bac> EdwinGrubbs: soitanly
[19:18] <EdwinGrubbs> bac: BTW, I have to go to lunch now.
=== EdwinGrubbs is now known as Edwin-lunch
=== Edwin-lunch changed the topic of #launchpad-reviews to: on call: bac || reviewing: achuni || queue: [sidnei, Edwin] || This channel is logged: http://irclogs.ubuntu.com/
[19:19] <bac> Edwin-lunch: too bad.  i was going to jump you to the front since no one else who wants a review is around atm
=== beuno-lunch is now known as beuno
[20:14] <bac> Edwin-lunch: done.  nice work.  that's some fancy CSS you got there.
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/
=== Edwin-lunch is now known as EdwinGrubbs
[20:28] <EdwinGrubbs> bac: thanks
[20:28] <bac> np
[21:16] <henninge> bac: I have a review for you, if you don't mind.
[21:16] <henninge> https://code.edge.launchpad.net/~henninge/launchpad/bug-456498/+merge/13668
=== henninge changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue: [henninge] || This channel is logged: http://irclogs.ubuntu.com/
[21:33] <bac> hi henninge
[21:33] <bac> henninge: i'll look at it now
[21:33] <henninge> bac: thank you
[21:36] <bac> henninge: can you reword the last sentence at lines 11&12?  i think you have an extra word or are missing some.
=== salgado is now known as salgado-afk
[21:37] <henninge> bac: yes, the "detect" should go
[21:42] <bac> henninge: why didn't you make trans_credit_type an enum?
[21:42] <henninge> bac: to keep it simple, actually
[21:43] <bac> henninge: to make this patch simple, maybe, but i don't think the code is going to be in the long run.  i just hate seeing all of those magic strings.
[21:44] <bac> henninge: and to a translations outsider, a value of 'Your emails' seems odd
[21:44] <henninge> bac: true
[21:44] <bac> henninge: otherwise this is a lovely patch
[21:46] <bac> henninge: could i get you to take a stab and making those an enum and seeing if it really is that much more complicated?
[21:47] <henninge> bac: yes you can ;)
[21:47] <bac> henninge: thanks!  i've got a few other niggly things i'll put in the MP.
[21:47] <henninge> bac: thank you, too
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/
=== bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue: [-] || This channel is logged: http://irclogs.ubuntu.com/
=== matsubara is now known as matsubara-afk
[22:58] <EdwinGrubbs> beuno: Can you do a UI review of the branch you already pre-reviewed? New screenshots are in the last comment. https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-435260-duplicate-links/+merge/13657
[22:59] <beuno> EdwinGrubbs, on it
[23:04] <beuno> EdwinGrubbs, done
[23:22] <intellectronica> who wants to review a little branch?
[23:22] <intellectronica> a windmill fix
[23:22] <intellectronica> it's quite minimal
[23:22] <intellectronica> mwhudson: how about you?
[23:23] <intellectronica> or maybe rockstar?
[23:23] <mwhudson> intellectronica: sure
[23:23] <mwhudson> i'm probably the most ignorant team member about js though
[23:23] <rockstar> mwhudson, I'd be happy the grab it if you're uncomfortable taking it.
[23:23] <intellectronica> mwhudson: you rock. http://pastebin.ubuntu.com/297838/
[23:24] <intellectronica> or rockstar, who's got rock in his own very name
[23:24] <intellectronica> there's not much js there, though. it's written in python
[23:24] <intellectronica> it's a fix for https://bugs.edge.launchpad.net/malone/+bug/456315
[23:24] <mup> Bug #456315: Windmill test test_bug_tags_entry errors <js> <Launchpad Bugs:Triaged by intellectronica> <https://launchpad.net/bugs/456315>
[23:24] <rockstar> intellectronica, this is just moving it the BugsWindmillLayer?
[23:25] <intellectronica> rockstar: pretty much. i also converted some setupd code that used the ui to use the object factory, it makes it much shorter and nicer
[23:25] <intellectronica> rockstar: see lines 33 - 45
[23:26] <rockstar> intellectronica, lines 41 and 42 - abentley also had this problem.  Can you file a bug about canonical_url not being good for windmill tests?
[23:26] <rockstar> intellectronica, I think the solution is ugly, but there's currently no way around it.
[23:27] <intellectronica> rockstar: sure, doing that now. the solution is ugly because you must specify the port, but i'd like to extend canonical_url to take the scheme and port as parameters
[23:27] <rockstar> intellectronica, essactly.
[23:30] <intellectronica> rockstar: https://bugs.edge.launchpad.net/launchpad-foundations/+bug/456773
[23:30] <mup> Bug #456773: Make canonical_url work nicely in Windmill tests <Launchpad Foundations:New> <https://launchpad.net/bugs/456773>
[23:30] <rockstar> intellectronica, I see your comment about the click event not firing the js event but actually moving.  Have you found anything that can be done about this?
[23:31] <rockstar> intellectronica, I ask because I now suspect that must be happening the branch subscriber tests -- They fail randomly at different places when the whole CodeWindmillLayer tests are run, but not when run by themselves.
[23:32] <intellectronica> rockstar: i must admit i haven't looked at it lately. it's possible that with the new test infrastructure things have improved, but i'm not too hopeful
[23:36] <rockstar> intellectronica, is there an mp somewhere?
[23:37] <intellectronica> rockstar: no, let me create one
[23:38] <rockstar> intellectronica, okay, when you create it, link me and I'll r=me
[23:39] <intellectronica> rockstar: cheers. https://code.edge.launchpad.net/~intellectronica/launchpad/fix-test-bug-tags-entry/+merge/13678
[23:41] <rockstar> intellectronica, done.
[23:41] <intellectronica> lovely. thanks a bunch, rockstar
[23:41] <rockstar> intellectronica, no problem.