=== Ursinha is now known as Ursinha-afk
[06:12] <al-maisan> Good morning
=== henninge changed the topic of #launchpad-reviews to: henninge on call || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[10:17] <henninge> jtv: could you do a review for me? That stupid OCR refured to take it ...
[10:18] <henninge> refused
[10:18] <jtv> henninge: the german bastard!  Sure.
[10:18] <jtv> Where is it?
[10:18] <henninge> jtv: I may have typed faster than I was thinking. Let me check if I have already created the MP or not ...
[10:19] <henninge> jtv: no, so you are off the hook for another 15 min or so ... ;)
[10:19] <jtv> ok, I'll go concentrate on some problem-solving here
=== intellectronica changed the topic of #launchpad-reviews to: henninge and intellectronica on call || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
=== henninge_ is now known as henninge
[10:44] <adeuring> henninge, intellectronica: could one of you please review this MP: https://code.edge.launchpad.net/~adeuring/launchpad/bug-460935-hwdb-better-consistency-check-udev-usb-devices/+merge/13942?
[10:44] <intellectronica> adeuring: sure
[10:45] <adeuring> intellectronica: thanks!
[10:45] <henninge> intellectronica: thanks, too.
[10:45] <intellectronica> henninge: and it won't be complete without thanking you as well. thank you!
[10:46] <henninge> ;-)
[10:50] <intellectronica> adeuring: r=me
[10:50] <adeuring> intellectronica: thanks!
[11:06] <jtv> henninge: this MP is taking rather longer than 15 minutes!
[11:06] <henninge> jtv: yes, sorry.
[11:07] <henninge> jtv: I had to get back into the matter and now try to explain it. Also, I had an interesting issue on #launchpad.
[11:09] <jtv> henninge: ah, the bzr import attribution issue.  We've seen that before, I think.
=== matsubara-afk is now known as matsubara
[11:28] <henninge> jtv: ok, here is the proposal. https://code.edge.launchpad.net/~henninge/launchpad/bug-128324/+merge/13946
[11:28] <henninge> jtv: If you still want to take it, you can claim it. But I could ask intellectronica now, too. ;-)
[11:29] <jtv> henninge: no worries, I'll take it.  Bit slow to load though.
[11:29] <henninge> jtv: it's HUGE ... ;)
[11:30] <jtv> henninge: let me see if I can reset that router...
[12:01] <adeuring> henninge, intellectronica: can I pester you with another MP? https://code.edge.launchpad.net/~adeuring/launchpad/bug-460976-noise-reduction-for-hwdb-processing-log/+merge/13950
[12:01] <intellectronica> adeuring: sure
[12:02] <adeuring> intellectronica: thanks!
[12:03] <wgrant> noodles775, al-maisan: Can one of you please do a simple review for me? https://code.edge.launchpad.net/~wgrant/launchpad/archive-debug-archive/+merge/13949
[12:03] <wgrant> I'm collecting far too many ddeb-related branches :(
[12:04] <al-maisan> wgrant: I can but probably won't get to it today .. is that OK?
[12:04] <henninge> al-maisan, wgrant: any reason I could not do it?
[12:04]  * al-maisan takes a look at the branch
[12:05] <wgrant> henninge: That'd be fine, but I'd like to get at least a glance from a Soyuz guy.
[12:06] <wgrant> (it's not urgent; I might not finish the dependent branches in 3.1.10. but I'd like to minimise the queue)
[12:08] <al-maisan> wgrant: this only affects the primary archive and not the partner archive?
[12:08] <wgrant> al-maisan: partner is small and not mirrored, so it's not a concern. Also note that I'm just moving the existing logic.
[12:15] <al-maisan> wgrant: right .. looks OK to me.
[12:18] <al-maisan> wgrant: please have it formally reviewed by either henninge or intellectronica.
[12:19] <intellectronica> wgrant: i can have a look as soon as i'm done with adeuring's branch
[12:19] <wgrant> intellectronica: Thanks.
[12:21]  * henninge is in the stand-up call now and will go to lunch after that.
[12:28] <wgrant> intellectronica: I need to sleep now. If you get to my branch, thanks!
[12:28] <intellectronica> wgrant: i can start now. which branch?
[12:28] <wgrant> intellectronica: https://code.edge.launchpad.net/~wgrant/launchpad/archive-debug-archive/+merge/13949
[12:28] <intellectronica> wgrant: cool. sweet dreams
[12:29] <wgrant> intellectronica: Thanks.
=== Ursinha-afk is now known as Ursinha
[12:44]  * henninge lunches
=== henninge is now known as henninge-lunch
=== sinzui changed the topic of #launchpad-reviews to: henninge and intellectronica on call || reviewing: - || queue: [sinzui] || This channel is logged: http://irclogs.ubuntu.com/
[12:57] <sinzui> henninge-lunch: intellectronica: can one of you review https://code.edge.launchpad.net/~sinzui/launchpad/prf-flavor-loop/+merge/13919
[12:57] <intellectronica> sinzui: sure
=== intellectronica changed the topic of #launchpad-reviews to: henninge and intellectronica on call || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
=== abentley changed the topic of #launchpad-reviews to: henninge, intellectronica and abentley on call || reviewing: sinzui || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[13:09] <intellectronica> sinzui: r=me
=== intellectronica changed the topic of #launchpad-reviews to: henninge, intellectronica and abentley on call || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[13:10] <sinzui> intellectronica: thank
[13:11] <intellectronica> henninge-lunch, abentley: if it's cool with you, i'm going to stop reviewing for now. i've done quite a lot of reviews so far, and have plenty of other work. if things get very bust later, though, give me a shout and i'll come back to help
=== intellectronica changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: - || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[13:11] <abentley> intellectronica: Cool.
=== salgado changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: - || queue: [salgado] || This channel is logged: http://irclogs.ubuntu.com/
[13:22] <salgado> mine is https://code.launchpad.net/~salgado/launchpad/bug-452525/+merge/13873
[13:22] <salgado> any takers? :)
[13:29] <abentley> salgado: I'll have a look.
=== abentley changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: -, salgado || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[13:34] <abentley> salgado: did you consider testing the view directly, rather than through th browser?
[13:36] <salgado> I don't remember
[13:36] <salgado> on a call now, will be out shortly
[13:37] <abentley> salgado: Okay.
[13:55] <matsubara> hi, could I get a review for https://code.edge.launchpad.net/~matsubara/lp-production-configs/update-oops-prefix/+merge/13954 ? It's a one-line config change to avoid generating conflicting oops reports.
[13:56] <matsubara> that change has been cowboyed btw
=== EdwinGrubbs is now known as Edwin-afk
=== mrevell is now known as mrevell-lunch
=== henninge-lunch is now known as henninge
[14:24] <matsubara> henninge, can you take a look at https://code.edge.launchpad.net/~matsubara/lp-production-configs/update-oops-prefix/+merge/13954?
[14:24] <henninge> matsubara: sure
[14:24] <matsubara> thanks henninge 
[14:24] <henninge> matsubara: what do "M" and "N" stand for?
=== abentley changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: -,-  || queue: [salgado] || This channel is logged: http://irclogs.ubuntu.com/
[14:25] <matsubara> henninge, nothing. it's the oops prefix used by the lpnet configuration files. they are in alphabetical order
[14:28] <matsubara> henninge, so basically lpnet1 == A, lpnet2 == B, etc
[14:28] <salgado> abentley, so, I didn't consider writing a view test for that fix, but it probably is a good idea.  I'll give it a try
[14:29] <henninge> matsubara: ah, that makes sense. r=me
[14:29] <abentley> salgado: I meant rather than a browser test, because view tests are less fragile and test the code in question more directly.
[14:29] <matsubara> thanks henninge 
[14:30] <salgado> abentley, yep, I know what you mean, and I think it will probably make for a simpler and more robust test
[14:31] <salgado> maybe even a bit faster
=== abentley changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: -,salgado  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[14:32] <abentley> salgado: Is AccountStatus.DEACTIVATED already being tested?
[14:33] <abentley> salgado: Why is lib/devscripts/ec2test/instance.py changed by the branch?
[14:33] <salgado> abentley, I think there's a page test for the AccountStatus.DEACTIVATED case.  let me check
[14:34] <abentley> salgado: (because obviously it would be easy to expand the test to cover both)
=== mrevell-lunch is now known as mrevell
[14:34] <salgado> abentley, nothing related to the branch.  just that I found a bug in it while using ec2
[14:35] <abentley> salgado: Okay.  Just wanted to make sure it wasn't accidental, since you didn't mention it in the description.
[14:35] <salgado> the test for DEACTIVATED accounts is in stories/foaf/xx-resetpassword.txt
[14:37] <abentley> salgado: Okay, so I think this is landable as-is, but would be even better if the test was a view test.
[14:37] <salgado> abentley, cool, I'll send you an incremental diff changing the test into a view test
[14:38] <abentley> salgado: Cool.
[14:38] <henninge> Hey jtv! I am done lunching, are you stuck in my branch? ;-)
[14:39] <jtv> henninge: didn't my vote come through?
[14:39] <jtv> I'm pretty sure it did.
[14:39] <henninge> jtv: oh, sorry. scroll error ... ;)
=== abentley changed the topic of #launchpad-reviews to: henninge and abentley on call || reviewing: -,-  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[14:40] <jtv> henninge: one of those things you probably should be able to manage when you work as a software engineer.  :-P
[14:40] <henninge> jtv: ssshhh
[14:41]  * jtv ssshhhes
[14:41] <henninge> jtv: and thanks for the review. I will do as you requested.
[14:41] <jtv> yeah, bitch!  you'd better!
[14:41] <jtv> sorry, couldn't resist
[14:41]  * jtv goes back go ssshhhing
[14:50] <bac> sinzui: will you re-review https://code.edge.launchpad.net/~bac/launchpad/bug-436259-add-member/+merge/13875
[14:51] <bac> sinzui: i don't have a diff as i merged in RF but i backed out the tests and made the link change you requested
[14:54] <sinzui> bac: r=me
[14:54] <bac> thanks
[15:01] <salgado> abentley, http://paste.ubuntu.com/302109/ is the incremental diff.  looks much better, IMO
=== matsubara is now known as matsubara-lunch
[15:02] <abentley> salgado: Looks good.  Land it!
[15:02] <salgado> abentley, thanks
=== salgado is now known as salgado-lunch
[15:21] <henninge> jtv: For the new "ec2 land" command to work, you need to set the review type to "code" as the script checks for that.
[15:22] <henninge> jtv: np, though, I already ec2 tested it, so I can just  submit.
[15:22] <jtv> henninge: is that it?  I thought the docs also said (thought it wasn't very clear to me) that it defaults to code if no review type is given.
[15:22] <henninge> jtv: ah
[15:22] <henninge> jtv: I think this is what happened on Friday:
[15:23] <jtv> henninge: (hang on, still in call)
[15:23] <jtv> henninge: (...and done)
[15:24] <henninge> jtv: There was a pending review from Launchpad Engineering of type "code" and my reviewer added a new review "Approved" without a type.
[15:24] <henninge> jtv: so the script saw the (unused) pending line.
[15:34] <jtv> henninge: it could well be that that is why I got the "get an approval vote" error for some reviews.
[15:34] <henninge> jtv: that's how I understand that error
[15:57] <henninge> jtv: should I review your branch scale-message-sharing-migration?
=== salgado-lunch is now known as salgado
=== matsubara-lunch is now known as matsubara
[16:25] <deryck> leonardr, you've pretty much already reviewed https://code.edge.launchpad.net/~deryck/launchpad/better-html-handling-description-editing/+merge/13963 for me as I did it.  Care to sign off on it?
[16:25] <leonardr> sure
[16:26] <deryck> leonardr, thanks.  And here's the related lazr-js branch:  https://code.edge.launchpad.net/~deryck/lazr-js/multine-editor-xhtml-handling/+merge/13967
=== deryck is now known as deryck[lunch]
=== beuno is now known as beuno-lunch
=== salgado is now known as salgado-brb
[17:09] <bac> sinzui: i've submitted a MP for my palindromic bug 461164.  would you care to review it if/when it shows up on LP?
[17:09] <mup> Bug #461164: Project +download page has extra vertical space <Launchpad Registry:New> <https://launchpad.net/bugs/461164>
[17:11] <sinzui> bac: my pleasure
[17:17] <al-maisan> abentley: I have a mini-branch, could you please take a look: https://code.edge.launchpad.net/~al-maisan/launchpad/bq/+merge/13971
[17:18] <abentley> al-maisan: Sorry, on a call.
[17:18] <al-maisan> abentley: np, maybe when you finish the call?
=== deryck[lunch] is now known as deryck
=== al-maisan changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [al-maisan<http://tinyurl.com/yfqmr45>] || This channel is logged: http://irclogs.ubuntu.com/
[17:26] <sinzui> bac: font-size: 1.2em; is not supported by YUI-font. I think you should pick a percentage from the table in style-3.0.css. Do you know why the  <h2> font size an exception?
[17:28] <sinzui> bac: can we replace the first with the second
[17:28] <sinzui> tal:condition="python: release.release_notes or release.changelog"
[17:28] <sinzui> tal:condition="release/release_notes|release/changelog|nothing"
=== salgado-brb is now known as salgado
[17:33] <barry> abentley: have time for a quick review?
[17:34] <abentley> barry: sure.
[17:34] <barry> abentley: thanks. mp coming
=== abentley changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [al-maisan<http://tinyurl.com/yfqmr45>, rockstar, barry] || This channel is logged: http://irclogs.ubuntu.com/
=== abentley changed the topic of #launchpad-reviews to: abentley on call || reviewing: al-maisan<http://tinyurl.com/yfqmr45>  || queue: [rockstar, barry] || This channel is logged: http://irclogs.ubuntu.com/
[17:37] <abentley> al-maisan: r=me
=== abentley changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [rockstar, barry] || This channel is logged: http://irclogs.ubuntu.com/
[17:42] <al-maisan> abentley: thanks
=== beuno-lunch is now known as beuno
=== abentley changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/
[17:54] <bac> sinzui: i don't know why the h2 has a different size
[17:55] <sinzui> bac: I just updated the review: https://code.edge.launchpad.net/~bac/launchpad/bug-461164-downloadfix/+merge/13969
[17:57] <sinzui> bac: I do not think the <h2> font exception is needed. I see <h2> is set to 123.1%, which is about 1.2em
[17:57] <bac> sinzui: yes, i fixed the phantom border but failed to mention it in the cover letter
[17:57] <bac> sinzui: i'll gladly kill the font size
[17:57] <sinzui> bac: I am pleased nonetheless
[17:58] <sinzui> I think those font-sizes were added as beuno was planning the 3.0 style. +downloads was foreshadowing the current style rules
[17:59]  * sinzui is impressed he worked 'foreshadowing' into the conversation
[17:59]  * sinzui will try for 'prescient' next 
[18:00]  * beuno blinks
[18:00] <beuno> have we dropped the pre-3.0 stylesheet yet?
[18:00] <beuno> or mochikit?  :)
[18:01] <bac> sinzui: the release notes are truncated to 800 char so i'll do the same with changelog
[18:03] <sinzui> +1
[18:03] <sinzui> beuno: I looked at that bug a week ago
[18:04] <sinzui> beuno: I think we need to test that the some of the folding/expansion still start on page load
[18:05] <bac> sinzui: note the h2 looks no different and the changelog is nicely truncated http://people.canonical.com/~bac/download-fix.png
[18:05] <sinzui> sweet
[18:06] <beuno> sinzui, to drop the stylesheet or mochikit?
[18:07] <sinzui> bac: so font is gone, changelog clamped, portlet-border fixed. What do you think about the python condition? If my suggestion does not work, keep it as it is so, I think this review is r=me
[18:07] <sinzui> beuno: mochikit
[18:07] <bac> sinzui: i killed the py condition too
[18:08] <bac> sinzui: i think i got all of your issues
[18:08] <bac> sinzui: diff http://pastebin.ubuntu.com/302205/
[18:08] <sinzui> bac: you rock. definite r=me
[18:10] <sinzui> beuno: looking at the default page scripts, I think mochikit is safe to remove
[18:10] <bac> ugh, got an error adding a comment to my MP: The following errors were encountered:
[18:10] <bac> (, 'createComment', 'launchpad.AnyPerson')
[18:10] <bac> OK
[18:10] <sinzui> bac: you are not just AnyPerson, you are a rocket scientist
[18:11] <beuno> sinzui, do you want to be a hero?
[18:12]  * sinzui checks the default script before answering
[18:12] <bac> adding MP comments works in FF.  :(
[18:17] <sinzui> beuno: we cannot remove mochikit. Many of the expand/collapse/fold functions are using its getElementsByTagAndClassName and swapElementClass functions
[18:17] <beuno> sinzui, really?  garrrrr...
[18:18] <sinzui> beuno: we need to YUI-iffy  500 lines in lp.js
[18:18] <beuno> sinzui, is there a bug for that?
[18:18] <sinzui> beuno: Just the remove mochikit bug
[18:19] <beuno> sinzui, could you comment on it with this new information?
[18:19] <beuno> I want to try and get gary_poster to sneak it in at some point
[18:19] <beuno> drop 30-50kb from each request
[18:20] <intellectronica> sinzui: getElementsByTagAndClassName is trivial to rewrite with the css selector capabilities of yui, innit?
[18:20] <sinzui> beuno: I suspect that if we provide yu substitute functions we can cust the mochikit was
[18:20] <sinzui> hmm
[18:20] <sinzui> wow my last sentence really fell apart. I have no idea where I was going with that
[18:21] <sinzui> intellectronica: I agree that we can provide some simple class/tag manipulation functions to remove mochikit
[18:21] <beuno> sinzui, Monday is a little early to kick off breakfeast with vodka
[18:22] <sinzui> It was mixed with orange juice
[18:22] <intellectronica> you really shouldn't eat on an empty liver
[18:24] <beuno> ...and that's how we make Launchpad kids!
[18:25] <sinzui> I think some alternate substances were involved in some of the code I have read, but maybe it was the result of a bad merge
[18:41] <sinzui> beuno: I updated bug 294656. I also added bugs and translations targets because they are the primary users of the legacy code. Bugs functions look like simple changes. Translations may be more substantial.
[18:41] <mup> Bug #294656: Every page requests two JavaScript libraries (remove MochiKit) <tech-debt> <Launchpad Foundations:Triaged> <Launchpad Bugs:New> <Launchpad Translations:New> <https://launchpad.net/bugs/294656>
[18:41] <beuno> sinzui, you rock man, thank you
[19:01] <bac> sinzui: my serieses-series branch is now fixed up and ready to land.
[19:01] <sinzui> bac: May the god of grammar remain  steadfast by your side
[19:01] <bac> was that an r=sinzui?
[19:02] <sinzui> it is an r=me
=== abentley changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
=== abentley is now known as abentley-lunch
[19:45] <rockstar> abentley-lunch, I have a branch headed your way, but you seem to be eating late.  I'll just wait patiently.
=== rockstar changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [rockstar] || This channel is logged: http://irclogs.ubuntu.com/
[20:08] <EdwinGrubbs> sinzui, beuno: I posted a question on this mp concerning sinzui's suggestion. What do you think about it? https://code.edge.launchpad.net/~edwin-grubbs/launchpad/bug-436507-distro-sourcepackage-link/+merge/13878
[20:09] <beuno> EdwinGrubbs, I'll take a peak in a minute
=== salgado is now known as salgado-afk
=== abentley-lunch is now known as abentley
[20:36] <sinzui> EdwinGrubbs: I did not realise the link was a see-all. See-all was intended for portlets that show a limited count of a larger list. this case does not look like reason to use see-all
[20:37] <rockstar> abentley, do you think you'll be able to get to that review today?
[20:38] <abentley> rockstar: Signs point to no.
[20:38] <abentley> rockstar: But I can do it tomorrow morning.
[20:38] <rockstar> abentley, awesome.  Thank you.
[20:38] <EdwinGrubbs> sinzui: originally, I had put the link at the bottom of the first portlet, but Julian thought that the see-all would be better. Is the bottom of the first portlet good then?
[20:39] <EdwinGrubbs> sinzui, beuno: or should it go in the side portlet?
[20:40] <sinzui> We have lots of pages with links that precede the main content. We use <ul class="horizontal">
[20:40] <EdwinGrubbs> ok
[20:41] <sinzui> I do not think side portlet is correct it is not about the context, in fact it switches the context, 
=== sinzui changed the topic of #launchpad-reviews to: abentley on call || reviewing: -  || queue: [rockstar,sinzui] || This channel is logged: http://irclogs.ubuntu.com/
=== matsubara is now known as matsubara-afk
=== Ursinha is now known as Ursinha-afk
=== abentley changed the topic of #launchpad-reviews to: - on call || reviewing: -  || queue: [] || This channel is logged: http://irclogs.ubuntu.com/
[22:43] <mwhudson> thumper: can you review a very small branch¿
[22:43] <mwhudson> ?
[22:44] <thumper> mwhudson: ok
[22:45] <thumper> mwhudson: how'd you get the upside down ?
[22:45] <mwhudson> thumper: compose - ?
[22:45] <mwhudson> or something like that
[22:45] <thumper> I don't have a compose key
[22:53] <thumper> mwhudson: done
[23:49] <mwhudson> thumper: http://pastebin.ubuntu.com/302425/ fixes https://bugs.edge.launchpad.net/launchpad-code/+bug/457999 in the way sinzui suggests, do you know if this link is tested anywhere?
[23:49] <mup> Bug #457999: verify download link is broken <Launchpad Bazaar Integration:Triaged> <https://launchpad.net/bugs/457999>