[00:06] thumper: heh [00:07] mwhudson: want to review it? [00:07] thumper: yeah alright [00:07] * thumper sends [00:13] mwhudson: sent, now just flowing through the ether [00:16] thumper: ok [00:25] * thumper heading afk for a while [00:28] mwhudson: hmm, my bzr send caused an oops :( [00:28] I'll look at that later [00:28] mwhudson: did a manual propose [00:29] ok [00:30] thumper: i'm going to get this script running with spm and then break for lunch though [00:30] mwhudson: it may take a while; that's a huge patch for my itsy network connection. [00:31] spm: 75k? [00:32] mwhudson: your irony detector is broken. ;-) [00:32] i see :) [00:32] it needs lunch too, it seems [00:32] that'd do it. [01:40] Uhoh. [01:40] Some bits of LP use string sorting on version numbers. [01:40] (DistributionSourcePackageView.active_series is the most obvious so far) [01:58] i guess we've got one more release before that bites us on the arse? [02:25] mwhudson: No. Lucid exists now. [02:25] eg. see https://edge.launchpad.net/ubuntu/+source/dpkg [02:26] Just display glitches, fortunately. [02:26] But still had me confused that Lucid wasn't yet initialised. [02:28] wgrant: oh yeah [03:11] * Ursinha looks at spm [03:11] Ursinha: yo! [03:11] :) [03:12] spm, hey :) are you busy now? [03:12] terribly-dying busy? [03:12] mind you - that's an impressive 15000km stare you have :-D [03:12] hahaha [03:12] Ursinha: nothing that can't be put aside; what's up? [03:12] spm, it's a simple question, that maybe has a simple answer :) [03:13] spm, I see emails of a garbo-hourly script failing [03:13] do you know why is it happening? [03:13] hahahahaa oh the irony. [03:13] why? :) [03:13] I was just chasing that and emailed stub about 15 mins ago :-) [03:13] oh, hehe [03:13] afaict, it is working; but isn't logging to scriptacivity. [03:13] hmmm, I see [03:14] there's an error in the log file; that may be glitching the "success"; but locks are opened and removed; so it looks good. [03:14] checkwatches was hung - if that's the next question? :-) [03:15] Of course. It's checkwatches. It hasn't worked for ages. [03:38] spm: how's our script going? [03:39] thumper: branch-distro ? you've not read mwh's email? [03:39] thumper: it's not :( [03:39] ah [03:39] bum [03:41] yes [04:05] mwhudson: so... my review? [04:05] thumper: sorry forgot, am on it now [04:05] or would be if launchpad was behaving [04:06] mwhudson: so... my oops with send oopsed due to a branch lock [04:07] thumper: bzr lock or database lock? [04:07] "!" either way mind [04:07] bzr lock [04:07] mwhudson: the scanner acquires a branch lock [04:07] so... [04:07] no it doesn't [04:07] * thumper thinks [04:07] ah [04:07] or at least, it's only a read lock [04:07] I'm pretty sure it does [04:07] it access the branch over read only http [04:07] * thumper looks [04:08] if it can obtain an exclusive lock over that transport something very strange is going on! :) [04:08] yep, lock-read [04:08] so... [04:08] how does that work then? [04:09] a read lock just means that the bzr client assumes the branch won't change under it [04:09] it caches revnos & probably some other things [04:10] so... [04:10] thumper: i would guess the lock was from the puller [04:10] hmm... [04:10] possibly [04:11] I guess there isn't much else that tries to lock it [04:12] mwhudson: no, it doesn't assume it won't change [04:12] mwhudson: it presents a stable view of the data to the holder of the read lock [04:13] er i guess that's more accurate yes [04:13] e.g. successive calls to last_revision() are the same within a read lock [04:13] old formats did mutually exclude writers [04:13] when we used os locks for reads of branch/repository [04:14] * thumper goes to purchase many pizzas to feed a gaggle of girls [04:14] thumper: i'll have your branch reviewed when you get back i hope [04:44] * thumper is back [04:47] thumper: ok i was wrong then [04:47] mwhudson: :) [04:47] I did look though [04:47] thumper: the only concern i have really is what it will look like if the attachment isn't actually a diff [04:48] mwhudson: the diff formatter looks at the first character [04:48] to decide how to colour it [04:48] thumper: oh ok [04:48] but yes [04:48] I did consider possibly doing text/plain different [04:49] thumper: what would happen with say image/jpeg? [04:49] do they get filtered somewhere else? [04:49] but decided against it [04:49] the diff formatter is pretty dumb [04:52] most likely you'll get line numbers and everything plain [04:52] for things that aren't actually diffs [05:03] mwhudson: yes, not shown [05:03] thumper: cool [05:03] mwhudson: that is a different bug [05:03] :) [05:03] or feature [05:03] not displaying random binaries as text is definitely a feature [05:10] mwhudson: there is a filter on text/plain, text/x-diff, text/x-patch [05:10] cool [05:10] * mwhudson EOWs [05:11] mwhudson: have a good weekend [05:11] thumper: you too! === Ursinha is now known as Ursinha-afk [05:32] stub: I think I've got my memory hog. Essentially the same as in phase 2 of the algorithm. Generalizing the same solution to re-apply it. Care to review it in a few? === lifeless_ is now known as lifeless === mzz_ is now known as mzz [06:26] stub: got my branch ready... would you be willing to (1) do a test run and (2) review it? [06:26] stub: you already know a lot of what goes on in there, so you're probably the best reviewer at this point. [06:36] k [06:36] jtv: k [06:37] jtv: What was the branch again? [06:37] http://bazaar.launchpad.net/~jtv/launchpad/scale-message-sharing-migration/ [06:38] jtv: I'll need to know the last unreviewed revision too === jelmer is now known as Guest85358 [07:11] hi henninge [07:11] stub: I must be off... any news? === Guest85358 is now known as jelmer === jelmer is now known as Guest78392 === Guest78392 is now known as jelmer [07:50] Hi jtv, I somehow missed your hailing ... [07:58] henninge: never mind, I'm not here [07:59] jtv: oh right, that's why I didn't notice you, then ... ;) [07:59] henninge: no, no word [08:02] jtv: I'll be relocating now [08:27] good morning [09:34] Morning! [09:49] Hello! [09:49] Does anybody have an idea what this might be about? http://paste.ubuntu.com/304910/ [09:50] henninge: usually it means that you're not currently logged in? [09:50] noodles775: oh, that is true (that I am not logged in) [09:50] great. [09:50] noodles775: I am doing this in a pagetest [09:51] henninge: yep, so pop a login('foo.bar@canonical.com') before it (or with relevant user). [09:51] henninge: Some code expects you to be logged in, such as something trying to security wrap an object. [09:54] good morning [09:54] noodles775, stub: Thank you, that was it. I needed to logout, too, so that the rest of the test can run as before. [09:54] np. === jtv is now known as jtv-afk [11:59] Is there a standard procedure for updating the version number of Launchpad in the Launchpad sourcecode documented anywhere? [12:01] maxb, I don't think so. do you just want to know how to do it or are you planning to create such doc if one doesn't exist? [12:01] A bit of both. Mainly I think it sucks that some places still say 2.2.3 [12:02] really? where does it say that? [12:03] all places which mention the release should be using modules/canonical.launchpad.versioninfo/release [12:04] salgado: setup.py [12:04] and that call I pasted above would read the version number from /version.txt [12:12] maxb, would it be possible to change canonical/launchpad/versioninfo.py to read the version number from setup.py? that way we'd have that info in only one place [12:12] * wgrant wouldn't mind another set of eyes on bug #54730. [12:12] Bug #54730: launchpad buildd abort does not work as expected [12:13] Although I guess there are few left who know lp-buildd :( [12:16] salgado: How about doing this in setup.py instead: ? [12:16] import imp [12:16] versioninfo_module = imp.load_source('setup_py_versioninfo', [12:16] 'lib/canonical/launchpad/versioninfo.py') [12:16] __version__ = versioninfo_module.release [12:19] that adds one more level of indirection [12:19] the actual version would go version.txt -> versioninfo -> setup.py [12:19] if we move the version to setup.py, it'd go setup.py -> versioninfo.py [12:20] The problem with putting it in setup.py is that you need to be able to load it without executing any of the setuptools gumph [12:21] I guess we could move almost all of the current setup.py inside an if __name__ == '__main__' [12:22] yeah, that'd work [12:24] How do you get at setup.py from versioninfo.py? [12:25] Same way you get at bzr-version-info.py ? [12:26] Ah. I see. [12:27] Though maybe rather than moving all of setup.py into an if-block, it would be neater to have setup.py and c.l.versioninfo both get the version from a oneliner lp_version_info.py ? === mrevell is now known as mrevell-lunch === mrevell-lunch is now known as mrevell [14:14] Ursinha: what are you trying to achieve? [14:14] henninge, good! [14:15] henninge, I'm trying to add a Last Edited column to the +translations pages, like this one: https://translations.launchpad.dev/alsa-utils/trunk/+translations [14:16] oops, no dev running here atm [14:16] Ursinha: I think you are on the wrong track [14:16] so I've added it to the template, and am trying to use the fmt:datetime do display the date the same way it's displayed in this one: https://translations.edge.launchpad.net/ubuntu/karmic/+lang/pt_BR/+index [14:16] Ursinha: you are trying to format a datetime object [14:16] henninge, hmm [14:16] go ahead [14:16] wait [14:17] sure :) [14:18] so, what goes behind the colon (:) is not what you are trying to format, but *how* [14:18] let me look up what it's called again [14:18] henninge, I know that [14:18] :) [14:19] henninge, the point is what do I have to do for it to use the fmt:datetime [14:19] I couldn't find out what the other page does that I'm not doing [14:19] I'm getting a traversal error [14:19] Ursinha: sorry, I just saw that there is actually a formatter called datetime, didn't know that [14:19] :) [14:20] Ursinha: show me the code [14:20] ;) [14:20] henninge, sorry, sometimes I assume that you guys are translations code gods and know everything about it [14:20] henninge, let me try something else here, a moment, please :) [14:20] I have actually found out how to use a formatter from python and found that pretty cool [14:20] ;-) [14:21] henninge, mind to explain? :) [14:21] I am just saying that I am exploring these things myself in varying depths [14:24] henninge, oh, I see :) [14:26] henninge, I think I found out the problem [14:26] I have to have a Datetime object for it to let me use the formatter [14:27] I may be wrong, but so far is my best guess [14:27] Ursinha: I am pretty sure you need a Datetime object! [14:27] ;-) [14:27] Ursinha: what were you trying to use the formatter on? [14:28] henninge, in what I thought that was a Datetime object, but realize it's not :) [14:28] ah [14:28] realizeD [14:28] Ursinha: that's excusable ;-) [14:28] henninge, hehe :) [14:28] sinzui: ping [14:29] hi henninge [14:29] hi sinzui [14:29] sinzui: I am trying to triage bug 462891 [14:29] Bug #462891: TraversalError on +export [14:29] sinzui: the oops happens when trying to access user/preferredemail/email [14:30] it is not visible [14:30] the app genuinely does not have permission to see it [14:30] sinzui: does that happen when the user hides his/her email address? [14:31] sinzui: although I tried that and it did not reproduce [14:32] henninge: Yes. In many mail/login usage, we use something link removeSecurityProxy(user.preferredemail).email [14:32] henninge: in this tales example. we simply do not have permission to show it. we should not [14:33] sinzui: ok [14:33] sinzui: is there an easy way to check in tales if we have that permission of not? [14:33] |nothing helps [14:34] it swallows exceptions [14:34] sinzui: good idea, thanks [14:37] henninge: in tales you might also do [14:37] condition="context/owner/preferredemail/required:launchpad.View"> [14:37] () [14:37] [14:37] sinzui: cool, thanks [14:43] henninge, so, I think I'm missing something [14:43] it seems the thing I'm returning is a datetime object [14:43] * Ursinha just thought about make harness [14:43] anyway, it seems the object is correct [14:43] but I may be missing defining the property somewhere [14:45] henninge, are you dying busy? :) [14:46] Ursinha: sorry. Still trying to triage (reproduce) that traversal error [14:47] Ursinha: define which property? [14:47] the lastChangedDate that I want to add in that page [14:48] Ursinha: can you push the branch and let me have a look at it? [14:48] henninge, sure, but it's a mess, just a warning :) [14:49] * henninge is used to messes [14:52] mars, gary_poster: can any of you take a look at https://code.edge.launchpad.net/~bjornt/lazr-js/download-cache/+merge/14220? it's a quick fix, so that people won't have to know how to set up a download-cache [14:53] BjornT_: on call, will check back [14:53] BjornT_, on a call for a bit [14:53] :) [14:54] Ursinha: I cannot set the bug 462891 to triaged or set its importance. I have insufficient permissions for that. [14:54] Bug #462891: TraversalError on +export [14:55] Ursinha: ??? [14:55] henninge, how come? [14:55] dunno [14:55] The following errors were encountered: [14:55] * Only Bug Supervisors may change status to Triaged. [14:55] henninge, try again [14:55] henninge: are you logged in [14:55] eh eh [14:55] sinzui: oh, I was fooled [14:56] Ursinha: ^ [14:56] there should be something showing you're not logged in [14:56] like a different color [14:56] don't know [14:56] henninge, was that the problem? [14:56] I logged myself out in another tab [14:56] but the bug page still looked like I was logged in ... [14:57] henninge, oops :) [14:58] henninge, happens to me sometimes, and my brain always fail to realize that could be this simple before panicking [14:58] henninge, btw, thanks for triaging that bug [14:58] Ursinha: np [15:03] Ursinha: btw, where those the only two occurances of that particular OOPS? I have not been able to reproduce the bug and it would be interesting to know how often it occurs. [15:03] s/where/were/ [15:03] henninge, we had about 40 a day since I've reported the bug [15:03] oh! [15:05] henninge, see here: https://devpad.canonical.com/~lpqateam/oops-summaries/lpnet-2009-10-29.html#exceptions [15:05] for example === salgado is now known as salgado-lunch [15:15] Ursinha: oops.py should display the *account* name (which is unique), not the display name, which may appear gazillion times [15:15] Ursinha: who maintains oops.py? [15:16] henninge, matsubara-afk does [15:16] Ursinha: is there a branch somewhere? [15:16] henninge, yes, a moment, please [15:30] beuno, on a merge proposal, why is there a [Review] link and a [Claim Review] button? [15:30] Ursinha: did you ever push that branch of yours? [15:30] henninge, pushing, pushing [15:30] :) [15:30] mars, I wish I had a nice answer to that [15:30] danilos is alive, I'll rip him them :P [15:31] thanks henninge :) [15:32] Ursinha: oh, that would be nice. I have guests tonight and wanted to cut it short. Is that ok with you? [15:33] henninge, if it's fine with danilos than it's fine by me [15:33] :) [15:34] Ursinha: Oh, I thought you were already talking to him [15:34] henninge, she was, I'll be happy to take on bug 462891 (we should always show that address, so removeSecurityProxy should do) [15:34] Bug #462891: TraversalError on +export [15:35] henninge, however, I am worried that this might happen when there's no preferred email as well [15:35] danilos: I was not even trying to fix it, just to reproduce it [15:36] henninge, as you can see, we are trying to traverse into None.email, so that's probably why it happens [15:37] danilos, Ursinha: actually, I thought we were still talking about Ursinha's fmt:datetime problem ... [15:38] henninge, heh, I am not sure about what we are talking about now :) [15:49] danilos, I was asking henninge's help because I thought you weren't there, but about the bug I'm fixing, not the bug henninge is [15:49] :) [15:49] I am a bug? [15:50] henninge, no, you just look like one [15:54] abentley, hi [15:54] rockstar: Hi. [15:55] abentley, so, I'm trying to compare to jobs, using your implementation of __eq__ and it's complaining that context is a ForbiddenAttribute - is that by design? [15:56] rockstar: No. [15:56] abentley, so it's okay that I add it to the interface to be accessible? [15:57] rockstar: Doesn't forbidden mean it's not even on the underlying model object? [15:57] abentley, I don't think so. [15:58] rockstar: I thought it was unauthorized if you don't have permission, forbidden if it doesn't exist. [15:58] * rockstar checks [15:59] abentley, no, if if rSP an object, context is there. In fact, the context should always be there in this case, since the context is the BranchJob [16:00] sinzui, salgado-lunch, hey, just to confirm one thing: we can have logged in users into Launchpad with no preferred email set or no? (re bug 462891) [16:00] Bug #462891: TraversalError on +export [16:00] What is rSP? [16:00] abentley, removeSecurityProxy? [16:00] danilos: I do not think that is possible. [16:00] Okay, so expose it on the API. [16:01] danilos: I spoke to henninge about that [16:01] abentley, great, thanks. [16:01] danilos: User can set the email address to be hidden and we honour it [16:01] sinzui, I know you did, but the thing is that we try to show email only to users themselves, and we should have privileges to do it [16:02] sinzui, this page is rendered when user is requesting a download, and we display email address so they know where they'll get an email when the export is ready for download [16:02] danilos: have you tried the proven tales fraement to access a hidden email address [16:02] sinzui, however, the traversal error tries to get email property on None, meaning that preferredemail is None, and not inaccessible [16:03] danilos: hmm [16:03] sinzui, at least that's how I read it, maybe I need to look into preferredemail implementation [16:03] danilos: I still state that the login server should never let a user login without a preferred email address. I do not think anyone can login without creating a profile, and that step ensures a preferred email address. [16:04] danilos: do we know the user? [16:04] sinzui, we've had a few bugs with person/account split; this is happening with more than one user, and we haven't seen this ever before [16:06] I see the user just came from login [16:06] I cannot believe we let that launchpad id exist [16:08] sinzui, yeah, that was exactly my opinion when I saw the exclamation mark in the user ID, but that might be part of the displayname [16:09] danilos: i think we need to query the person table of staging to see if this a real user. I hope that id is person, not account [16:12] danilos: He has an email address https://edge.launchpad.net/~iqt [16:13] sinzui, yeah, so I guess you were right about preferred email being returned as None when it's hidden (though, shouldn't it be hidden from us as well?) [16:14] danilos: You are special. You are a registry admin [16:15] danilos: That means your related software report is 100% crack [16:15] sinzui, however, I see no person for this account [16:15] sinzui, heh, right :) [16:15] danilos: This page does not who accounts. only person [16:15] sinzui, I am looking at staging DB [16:16] danilos: there is only one page that can show an account and only a LOSA can see it [16:16] danilos: the account was created on the 27. maybe staging is old [16:16] sinzui, staging DB seems outdated though [16:16] sinzui, yep === salgado-lunch is now known as salgado [16:30] sinzui, just fyi, looking at the code, preferredemail has no restrictions by whether an address is hidden or not; and, all of these seem to have just logged in before that, and the account was created just a few minutes ago; I am guessing that launchpad_auth_master has some data that launchpad_main_master still doesn't [16:35] danilos, Ursinha: Enjoy the weekend, I am off now! === deryck is now known as deryck[lunch] [16:35] danilos: thank makes sense. We had a number is similar oopses a few months ago where there as a 20 minute lag [16:35] bye henninge :) you too [16:35] danilos: you'd better get all well! [16:37] henninge, cheers [17:02] Chex: ping [17:03] sinzui: hello there === beuno is now known as beuno-lunch [17:04] Chex: I want to test the product-release-finder on staging, but it just occurred to me that I do not know if the fix was pushed there this week [17:05] sinzui: ok, was this a cowboy fix, or a revno release [17:05] ? [17:05] * sinzui loks for revno [17:07] no it did not arrive [17:08] Chex: do you know what is blocking staging from a code update? [17:08] danilos: still there? [17:11] danilos: those windmill errors are strange, i don't know what are causing them. you can merge lp:~bjornt/launchpad/bug-430702 to work around them [17:12] sinzui: I am not sure, let me check [17:14] BjornT_, ok, thanks [17:15] BjornT_, also, thanks for looking into this, very much appreciated [17:31] abentley, what would it take to teach the scanner about bzr pipelines and the next and prev pipes? [17:31] abentley, (in the context of setting pre-req branches) [17:31] rockstar: A database patch. [17:32] rockstar: Why do you ask? [17:33] Chex: I think I am confused by the version of code on staging. I verified that other expected features were on staging, so...can you run cronscripts/product-release-finder.py on staging and paste/send the output? [17:34] sinzui: jinx. I just finally verified that staging should be up-to-date within the past 24 hours or less [17:34] sinzui: sure [17:34] fab [17:36] abentley, just curious, really. I figure if we're bringing back prereq branches, it'd be really cool to teach the scanner about pipes soon after. [17:36] rockstar: My plan is to teach pipelines about prereq branches first. [17:37] abentley, I aliased push to sync-pipeline for this very purpose a few weeks ago. === deryck[lunch] is now known as deryck [17:37] abentley, wait, that confuses me. Pipelines knows which branch came before. [17:37] Right, but right now, they can't propose a branch for merging. [17:38] abentley, ah, okay. Yeah, we've talked about that. [17:38] leonardr, is the patch you just posted something of a pre-cursor to a trusted gtk workflow? [17:38] So first pipelines is getting launchpad support. Launchpad might get pipelines support later. [17:39] jml: yes, i spent this week landing the branch i mentioned to you a while ago [17:39] leonardr, cool. [17:39] i am supposed to talk to rickspencer3 about porting his gtk workflow to this engine but i can't find him. maybe he took the day off now that karmic is released [17:39] abentley, okay. I've wanted to do something to the codehosting part of code, and mwhudson fixed the bug I was thinking I'd do, so I thought maybe I'd teach the scanner about pipelines. [17:39] abentley, just a thought in passing more than anything though. [17:41] leonardr, he's travelling back home [17:41] ah [17:41] i guess i'll talk to him on monday then [17:41] rockstar: Well, the hardest part is getting a database patch through review. After that, we can implement direct support for next_branch and prev_branch, or we can add the pipelines plugin to the codebase. [17:41] leonardr, trusted client for gtk would be very exciting. === leonardr is now known as leonardr-afk [17:48] sinzui: ok, the script stopped output about 15 mins ago, should I kill it? [17:48] know. I think this can take some time since I expect it to be finding a lot of new downloads [17:49] s/know/no/ [17:49] Chex: is it stuck on a specific url? [17:51] sinzui: yes : 2009-10-30 17:39:03 INFO Walking http://ftp.drupal.org [17:51] 2009-10-30 17:39:03 INFO Listing /files/projects/ [17:52] that is big [17:53] Chex: Let this run. if this has not moved on in 30 minutes, I think we should kill it and restart === beuno-lunch is now known as beuno [18:02] have a lovely weekend and a great week four, everyone. see you in texas [18:04] sinzui: oki doki.. still sitting there as of now. [18:04]