/srv/irclogs.ubuntu.com/2009/11/03/#launchpad-dev.txt

mwhudsoni was thinking of devel r969300:00
wgrantharness is the only place that uses script.zcml directly, so I think it's the right fix.00:00
mwhudsonso what was i doing?00:01
mwhudsonah yes, creating a bug with zillions of duplicates00:01
wgrant9693 looks innocent enough.00:02
thumperwgrant: I have a bug for you :)00:11
thumperwgrant: SourcePackage needs to be renamed to something like DistroSeriesSourcePackage00:12
wgrantthumper: It does. Everyone knows that :(00:12
thumper:)00:12
thumperand no-one wants to do it00:12
thumpermy JFDI juice is all used elsewhere I'm afraid00:13
* thumper signs off for a while00:13
wgrantmwhudson: My 300-dupe bug only takes a couple of seconds to render locally :(00:13
mwhudsonwgrant: same here!00:14
* wgrant checks subscriber counts on all of 417842's dupes.00:14
=== Edwin-lunch is now known as Edwin
* mwhudson adds a couple hundred subscribers to the bug too00:15
=== Edwin is now known as EdwinGrubbs
mwhudsonwgrant: do you want to submit a branch that comments out the script.zcml from harness?00:16
wgrantmwhudson: I will, once I work out if there are any tests.00:17
wgrantI presume not.00:17
mwhudsoni think you're probably right00:19
mwhudsonthanks00:19
mwhudsonstill <4s00:20
wgrantThere are only 454 (public) subscribers on the dupes.00:21
wgrantAnd 254 on the master.00:22
mwhudsonwell, i guess i'm going to apply my SEP field now00:24
mwhudsonwgrant: do you know if a bug is filed?00:24
wgrantThat sounds wise.00:24
wgrantI haven't seen one.00:24
wgrantAlright.00:25
wgrantWhy, exactly, has my query count jumped from 140 to 215 to 426.00:25
wgrantThe only change I made was unsubscribing from the master between the first two.00:25
wgrantAnd now down to 294 again.00:25
mwhudsonfrikking wifi00:30
mwhudsonwgrant: have you filed such a bug or shall i?00:30
wgrantmwhudson: Please do. I can't see the details of the OOPS.00:31
mwhudsonok00:31
mwhudsonhuh wow the bug loaded on prod00:32
wgrantHow quickly?00:32
mwhudsonnow was that because i'm not logged in on that machine, or because it's prod...00:32
mwhudsonheh00:32
mwhudsonaaadh00:33
mwhudson    At least 116 queries issued in 19.42 seconds00:33
mwhudsonso it just sneaked in :-)00:33
wgrant++oops++ it!00:33
mwhudsonyeah, it timed out the second time00:33
wgrant    At least 241 queries issued in 14.22 seconds00:33
mwhudsoni suspect the edge appservers are more loaded than the lpnet ones right now00:35
wgrantlpnet got some more added recently, didn't it?00:35
mwhudsonyar00:35
mwhudsonhm now it loaded for me on edge00:36
mwhudsonstill not logged in00:36
wgrantMy lpnet time was logged in.00:36
mwhudsonwgrant: https://bugs.edge.launchpad.net/malone/+bug/471974 fwiw00:46
mupBug #471974: bug timing out without much sql time <timeout> <Launchpad Bugs:New> <https://launchpad.net/bugs/471974>00:46
wgrantHmmm. I cannot branch devel locally; it fails with obscure bzr errors. I wonder if the FS corruption last night was more extensive than I suspected...01:09
* wgrant is amused that even UX people don't like indicator-applet.01:15
Ursinhaanyone online up to explain me a difference between zope.schema.Datetime and canonical.database.datetimecol.UtcDateTimeCol?01:46
Ursinhacan I make the first timezone aware? os is it already?01:46
Ursinhas/a difference/the difference/01:47
wgrantThe first is an interface field, the second is a Storm/SQLObject type?01:54
wgrantIIRC z.s.Datetime knows about timezones.01:55
wgrantActually, I guess it doesn't really have to care.01:56
Ursinhawgrant, I thought that was the inverse01:58
UrsinhaUtcDateTimeCol aware of tz and Datetime not01:58
Ursinha?01:58
wgrantUrsinha: They are not the same sort of thing,01:59
Ursinhawgrant, I'm trying to understand this error: TypeError: can't compare offset-naive and offset-aware datetimes01:59
wgrantUrsinha: Where does the z.s.Datetime come from?02:00
Ursinhaa field declared in an interface02:01
wgrantBut the data comes from a form?02:01
Ursinhawgrant, no, it's calculated02:01
wgrantUrsinha: I think your calculation is just returning a naive datetime.02:02
Ursinhawgrant, let me see02:03
Ursinhawgrant, my calculation is Max(POFile.date_changed)02:10
wgrantUrsinha: And what are you comparing it against?02:13
Ursinhawgrant, POFile.date_changed02:14
wgrantHuh.02:14
wgrantThey should both be tz-aware! pastebin the code?02:15
Ursinhahehe02:15
UrsinhaI'd have to paste a lot of code :) I'm doing a change in translations that adds a last changed column to the +translations list02:16
Ursinhaso I added a last_changed_date = Datetime in an interface and it carries that Max(foobar) later in the code02:17
wgrantUnless you're doing something pretty strange, the interface will not matter.02:19
wgrant('strange' including using form infrastructure or lazr.restful)02:19
Ursinhawgrant, self.assertEquals(type(psl.last_changed_date.tzinfo), type(pofile2.date_changed.tzinfo)) returned AssertionError: <type 'NoneType'> != <class 'pytz.UTC'>02:39
Ursinhawgrant, mission now is understand why02:40
wgrantUrsinha: What is this psl?02:40
Ursinhawgrant, productserieslanguage02:40
wgrantUrsinha: is last_changed_date a new property, or a new direct DB column?02:41
Ursinhawgrant, a new property02:41
wgrantUrsinha: What's the code behind it?02:43
wgrant(timezones suck. hate hate hate)02:43
Ursinhawgrant, the changes I did in interface/productserieslanguage.py: http://paste.ubuntu.com/308142/02:47
wgrantUrsinha: In non-Zopey Python, the interface does not matter except for security.02:48
Ursinhawgrant, this is the bit I've changed that calculates that property: http://paste.ubuntu.com/308148/03:04
Ursinhawgrant, weird thing is that for one template, the first case, it doesn't fail, for the second it does, so Max modifies or returns something different of what's stored? I'm trying to figure out where I am losing that bit of timezone03:06
wgrantUrsinha: Sorry, had to run off for a while. If you look at UtcDateTimeCol, you can see it injecting the timezone manually. I'm not sure how much of that class will be used when you're not actually retrieving an object, just a field.03:32
Ursinhawgrant, I could see here that max returns the datetime without tz set03:33
Ursinhawgrant, actually I thought that the tz info was stored in the database, but that in fact wouldn't make much sense, since the whole system is UTC03:36
wgrantUrsinha: Right, they are all just stored timezoneless as UTC.03:37
wgrantUrsinha: Aha. Have a look at lp.code.model.branch.BranchCloud.getProductsWithInfo03:37
* Ursinha looking03:37
wgrant(particularly the XXX at the end)03:38
wgrantThat suggests that you're not doing anything wrong.03:39
Ursinhawgrant, that was exactly what I thought I was doing03:39
Ursinhawgrant, thank you muchly03:39
Ursinhawgrant, are you going to uds?03:39
wgrantUrsinha: I'm not.03:40
Ursinhawgrant, I'll never meet you in person03:40
Ursinha:/03:40
wgrantUrsinha: I guess what I would do here is just set tzinfo to UTC before I use it.03:40
wgrantUrsinha: Maybe another UDS, I suppose.03:40
Ursinhawgrant, I wonder if setting this is needed to what I'm doing03:45
wgrantUrsinha: If you want to compare two datetimes, you need them to be either both naive or both not.03:47
Ursinhawgrant, I only do this in the tests03:48
Ursinhawgrant, with the assert03:48
wgrantstub: Around for a re-review?05:09
stubwgrant: yes05:23
stubwgrant: I'll need some details - don't see anything on my review list.05:24
wgrantstub: I'm finding a link. I haven't worked out how I'm meant to request your review yet.05:25
wgranthttps://code.edge.launchpad.net/~wgrant/launchpad/distroseries-source-format-selection-db/+merge/1430405:25
stubwgrant: You click on 'request another review', type my name (so it appears on my list) and type 'db' (although that doesn't really matter)05:26
stubAnd again for jml05:26
wgrantstub: Ah, thanks. Done.05:27
stubSo integer enum was ok or better than text for format?05:27
wgrantYes.05:27
wgrantThere are only three possible values, and it seems neater.05:28
stubTable name discussed with soyuz  and SourcePackageFormatSelection seems best?05:28
wgrantYes.05:29
wgrantThere is an existing SourcePackageFormat enum which will be renamed to SourcePackageType soon.05:29
wgrant(it's DPKG vs. RPM, which is obviously not particularly useful at this point)05:29
stubwgrant: All fine & reviewed. Need jml's approval too.05:32
wgrantstub: Great. I should renumber the patch now?05:33
stubAny time before landing is fine.05:33
stubIt won't worry jml's review05:33
wgrantThanks.05:33
=== Ursinha is now known as Ursinha-afk
=== stub1 is now known as stub
noodles775Morning06:52
adeuringgood moring08:27
jmlgood morning09:06
jmlwgrant, patch reviewed.09:22
noodles775yay, thanks jml.09:24
noodles775(and thanks wgrant *again* for your work!)09:25
wgrantThanks jml.10:02
bigjoolswgrant: did you by any chance check to see if my fix for the security hole worked?  no worries if not, I am doing some Q/A anyway10:14
wgrantbigjools: I didn't. I might as well try now.10:16
=== henninge is now known as henninge-bbl
wgrantbigjools: You didn't mark the fields readonly, then?10:19
=== danilos-afk is now known as danilos
bigjoolswgrant: no, just fixed the zope permissions10:22
wgrantbigjools: Still an insufficient fix in my opinion, as I can cause OOPSes.10:24
wgrantbigjools: staging is still broken, but I presume that's because db_lp is borked.10:26
bigjoolsit's not an oops though is it?10:27
wgranthttps://staging.launchpad.net/ubuntu/+source/e2fsprogs/1.41.9-1ubuntu3/+build/130711910:27
wgrantIt is.10:27
bigjoolspermission failures should not be oops, they're routine10:27
wgrantIf I set the status to something bad, I can make my builds OOPS.10:27
wgrantIt's not a permission failure.10:27
wgrantIt's just that normal users have launchpad.Edit over their builds.10:28
bigjoolsoh you can set your own builds10:28
bigjoolsright10:28
wgrantWhich means they can corrupt internal LP state.10:28
bigjoolshmmm10:28
bigjoolsok it can be fixed next cycle10:28
wgrantYup.10:28
wgrantThe big issue is fixed now, at least.10:28
bigjoolsthanks for checking!10:28
wgrantnp10:29
wgrantThanks for fixing.10:29
wgrantbigjools: Thanks for the review. Are you going to land it?10:30
bigjoolswgrant: stub will10:30
wgrantbigjools: Ah, great.10:30
bigjoolshe sometimes does a mega-landing of loads of patches10:30
bigjoolsactually that was before we had db-devel, so he's just being kind to you this time :)10:31
wgrantI see.10:32
wgrantnoodles775: Thanks.10:32
noodles775wgrant: ... to you too :)10:33
stubWhat am I landing?10:34
stubI've got nothing pending to land so no point blocking on me.10:35
bigjoolsstub: wgrant's db patch10:47
bigjoolsyou said you'd land it in the MP ...10:47
wgrantPresumably "[it] Can land", not "[I] Can land"10:48
* noodles775 lands it on db-devel.10:51
stubAnyone can land. I'll do it since ...10:51
stubor maybe someone will beat me too it while I'm typing ;)10:51
noodles775stub: oh, I hadn't started, but can continue... :)10:51
bigjoolsstub: I am too used to you landing db patches for us :)10:52
deryckMorning, all.10:54
noodles775Morning deryck10:55
wgrantThanks $LANDER!10:55
noodles775heh10:55
=== Ursinha-afk is now known as Ursinha
=== bigjools-afk is now known as bigjools
jtvWhat classes that we use are not in the lp or canonical modules but contain DBEnumVariable instances?13:00
Ursinhahi noodles775 :)13:04
noodles775Hi Ursinha!13:04
stubjtv: Storm stuff13:05
stubjtv: https://pastebin.canonical.com/24251/13:05
stubDoen't seem that helpful :-P13:05
jtvstub: because it strikes me that we simply don't have enough LP objects in memory to reference all those DBEnumVariables13:06
Ursinhanoodles775, I tagged the bugs that are rollout blockers properly, so we can check all status doing a lp search13:06
Ursinhanoodles775, do you think this is useful?13:06
Ursinhanoodles775, it's an old idea from matsubara and I13:07
jtvstub: it does eliminate a lot, I guess.13:07
Ursinhanoodles775, I've added the search url to the wiki page13:07
noodles775Ursinha: yeah, definitely - I've been using it since you updated the CRB page with the link. It's great for an overview, but doesn't allow me to annotate things (so I'm currently still finding the CRB page helpful)13:07
noodles775s/helpful/helpful too13:08
Ursinhanoodles775, right, I thought so13:08
Ursinhanoodles775, so you think it's worthy doing?13:08
noodles775Ursinha: yes definitely. It showed me which bugs I wasn't tracking! (the registry ones... :) ).13:09
jtvstub: it's as if we're cleaning up the orm-backed objects but keeping their contents13:10
Ursinhanoodles775, cool :)13:13
Ursinhanoodles775, are you taking care of talking to people about their outstanding QA items, or do I still have to do that? :)13:13
noodles775Ursinha: I'm trying, but there have been lots of other issues happening, so I would welcome any help, thanks!13:15
marssalgado, around?13:16
Ursinhanoodles775, all right, I'll put a branch of mine for review and get to help you :)13:16
salgadomars, yep13:16
noodles775Ursinha: thanks!13:16
Ursinhanoodles775, np :)13:16
marshi salgado, my YUI3 branch fixes up client.js so most of the launchpad functionality works again: lp:~mars/launchpad/yui-3final-upgrade13:18
salgadomars, cool.  what was the problem that we were seeing last week?13:18
marssalgado, I've found that windmill works well in this case13:18
marsthe problem last week was a change to an object, from Object() to an object literal has.  Y.extend() didn't know how to deal with it13:19
marsY.Plugin became Y.Plugin.Base - passing Y.Plugin to extend() didn't work any more.13:20
noodles775Ursinha: bigjools said that bug 293106 isn't a crb (just the related landing that you noticed).13:21
mupBug #293106: does not support debian v3 source formats <current-rollout-blocker> <feature> <motu> <ppa> <soyuz-upload> <Soyuz:In Progress by wgrant> <https://launchpad.net/bugs/293106>13:21
Ursinhanoodles775, I just saw that13:21
salgadomars, oh, I see.  glad you've figured it out13:22
Ursinhanoodles775, a true case where we still need that page :)13:22
Ursinhanoodles775, I've removed the tag13:23
noodles775:)13:23
noodles775Ursinha: thanks.13:23
jmlallenap, pushed to lp:~jml/launchpad/ec2-parry13:41
allenapjml: Thanks :)13:41
gmbDammit, why is the "m" key so close to the "e" key?13:44
marsBjornT, just checking the jscheck buildbout output: there appear to be two errors, but they weren't picked up by the test runner?  https://lpbuildbot.canonical.com/builders/jscheck/builds/91/steps/shell_7/logs/stdio13:46
BjornTmars: are you thinking of the 'test_results: ERROR' messages?13:56
marsBjornT, yes, one ERROR and one INFO13:57
marsBjornT, make that two ERROR messages13:57
marsah, three13:57
BjornTmars: right. the ERROR ones aren't really errors. we need to find some way of surpressing those log messages. they happen when you do an assert, and tell windmill not to really assert, just to return the result13:58
marsBjornT, ok, I understand.  Not straight-forward to fix though.  I was just looking at the code.13:59
leonardrbac, you're in luck. i had to upgrade the lazr.restfulclient in launchpad to test my new launchpadlib branch. so i'll be able to at least run the test before i go on vacation. once pqm opens back up you should be able to just submit my branch that changes the required version14:29
bacleonardr: great14:30
marsBjornT, is there any way to control the options passed to the bin/test windmill test runner?14:30
BjornTmars: what do you mean? how do you want to control them? and which options are you talking about?14:32
marsBjornT, the '-e' option tells windmill to not exit at the end of the test run, allowing you to poke around in the test suite.  Can I simulate that with bin/test?14:33
BjornTmars: no, you can't. so far i've been using -D, or using import pdb; pdb.set_trace(), but it'd would be nice to add a way to tell windmill not to shut down14:35
BjornTmars: why do you need to poke around, btw?14:36
marsBjornT, some tests are failing as a result of the YUI upgrade.  I can run individual tests, but they just die.  I need to jump through many hoops to recreate the windmill test fixture.14:37
marstest running works fine - test authoring is a royal pain14:38
BjornTmars: ok. the easiest atm is passing in -D, so that it breaks on the first failure14:39
marsright14:39
marsthanks BjornT14:39
BjornTmars: it shouldn't be too hard to hack BaseWindmillLayer to do what you want, though, like checking for an environment variable, and not call windmill_teardown() if the variable is there14:40
marsBjornT, ah, cool idea14:42
bacsinzui: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1402EB65614:48
bacEdwinGrubbs: https://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1402EB65614:58
marssalgado, hit a problem, looks like the 3.0final JS doesn't build for production?  So windmill doesn't run properly.14:59
marssomething is off in launchpad.js itself14:59
salgadomars, what do you mean by doesn't build for production?15:00
marssalgado, we combine all the JS together into one big launchpad.js for production and testing.  That file is messed up right now, so windmill won't run.15:01
salgadomars, oh, I see. and we don't do that with the default config?15:02
marsnope, the test config uses launchpad.js15:02
marsthe dev config uses individual JS files15:02
salgadoright15:06
marsit uses either testrunner or testrunner-appserver15:07
marsnot sure which15:07
BjornTmars: have you tried removing the lazr-js directory, and then run 'make' again?15:08
sinzuibac: Edwin: I still think bug 458169 is a dup of bug 455812. the root cause is the view/portlet that is working with the milestones. Should we mark the one as a dup?15:09
mupBug #458169: Distroseries:+index page timing out <current-rollout-blocker> <timeout> <Launchpad Registry:In Progress by edwin-grubbs> <https://launchpad.net/bugs/458169>15:09
mupBug #455812: distroseries milestone timeout <current-rollout-blocker> <timeout> <Launchpad Registry:In Progress by edwin-grubbs> <https://launchpad.net/bugs/455812>15:09
marsBjornT, trying now15:09
bacsinzui: i'm not sure what that buys us.  if one fix covers them both then that's great.  but it might be better to leave them both open to ensure any fix works for both scenarios.15:10
EdwinGrubbssinzui: that's fine15:10
sinzuibac: okay15:10
marsBjornT, did not work15:10
marsBjornT, looks like YUI 3.0.0 is in launchpad.js, but none of the on-page javascript is getting activated15:12
marsso, why would it work in dev, but not in testing?15:13
marslaunchpad.js vs. individual files is the only major difference I can think of15:13
BjornTmars: are there any js error messages in the browser?15:13
marsno15:14
marsthat would prevent processing the remainder of the file, true15:14
marsbut nothing in the console15:14
BjornTthat's odd15:15
marsit is15:15
marsanother subtle API change?15:15
marsI'll hack in on-page JS debug logging, might turn up something15:16
noodles775Hi EdwinGrubbs and sinzui: can you guys pls take a look at the three registry bugs listed as In progress at https://dev.launchpad.net/CurrentRolloutBlockers and update the status?15:16
noodles775or let me know and I'll update it - whichever.15:16
* sinzui updates15:17
* noodles775 just sees the scrollback...15:17
noodles775thanks sinzui15:17
Ursinhahey bigjools :)15:21
sinzuinoodles775: in summary, we are asking for an RC for the CSS that fixed some links in the side portlets. The entire team is working on the distroseries timeouts. The root cause relates to summarising milestones. there may be one  bug here.15:21
=== salgado is now known as salgado-lunch
sinzuibarry: We are meeting to discuss the software center in 16:00 UTC15:22
sinzuibarry: see the standup notes15:22
barrysinzui: +1  just saw that (email is starting to trickle in again)15:22
noodles775sinzui: um, the MP there is targeted to devel? (and has a diff of 2600 lines)15:25
noodles775https://code.edge.launchpad.net/~edwin-grubbs/launchpad/all-downloads-link-sprite/+merge/1433315:25
sinzuibarry, bac, EdwinGrubbs: Fixing the distroseries is our top priority. I think the milestone status summaries are the cause of the 90% python processing time. There may be gross inefficiencies in counting the status/assginees for bugs and blueprints. The caching of the bugs and blueprints in the view may not be good enough. Maybe we want to adapt the objects that are being counted into a simpler object that does less indire15:25
sinzuinoodles775: read the comment15:26
noodles775yeah, just did...15:26
barrysinzui: +115:28
noodles775sinzui: but that doesn't explain why it's targeted to devel... I'd expect it to still be targeted to db-devel?15:28
* sinzui struggle to organise two simultaneous meetings15:28
sinzuinoodles775: I am too busy, talk the the people involved15:29
noodles775EdwinGrubbs: ^^^15:29
bigjoolsUrsinha: hi15:29
Ursinhabigjools, guess you know what I'll ask :)15:29
EdwinGrubbsnoodles775: what is targeted to devel instead of db-devel? BTW, have all the devel revisions finally been merged into db-devel?15:30
marsBjornT, does the lpwindmill.py script still work?15:30
marsI should say, is it supposed to work?15:31
Ursinhabigjools, all untested items are from al-maisan, is he testing that or you split?15:31
al-maisanUrsinha: I am about to finish a LP API test script that tests all the open items.15:32
Ursinhaal-maisan, that's cool! :)15:32
Ursinhathanks al-maisan15:32
al-maisanUrsinha: you are welcome.15:33
BjornTmars: no, it's not. do want it to debug the js problems?15:33
bigjoolsUrsinha: what he said :)15:33
noodles775EdwinGrubbs: the above MP. And no they haven't, waiting for the next stable->db-devel.15:33
* noodles775 checks stable15:33
marsBjornT, it used to be the way to start the windmill environment so you could author tests.  It would start a server and set up the windmill test layer.15:34
marsBjornT, for some reason JS is not executing at all in firefox under windmill.  Great :(15:34
marsthat would explain why there are no errors!15:34
BjornTmars: you're the first one i know that would actually author a test using the windmill gui :)15:35
BjornTmars: does it work if you start the normal app server, with devmode turned off?15:36
EdwinGrubbsnoodles775: it just says devel instead of db-devel since I used the "bzr send" to submit the mp, and I was apparently missing an option.15:36
sinzuibarry: I have checked that db-devel does show teams. Staging is broken and it did not get a code update in the last 24 hours. Other than forcing an update we need to wait15:36
marsBjornT, how do you turn off devmode?  I tried setting LPCONFIG, but that did not work.15:36
noodles775EdwinGrubbs: yep, it just leaves me nervous seeing such a large diff ;), but r-c=me for the real diff that you've listed. Updating now.15:38
barrysinzui, noodles775 don't you think it's too risky to roll out to production without a stable staging environment to do testing on?  i know my comfort level with the mailman upgrade will go way up if i have a chance to test it on staging first15:39
EdwinGrubbsnoodles775: I would like to land it after devel gets merge into db-devel. How long do I have before pqm is closed on db-devel?15:39
BjornTmars: edit configs/development/launchpad.conf15:40
BjornTmars: although setting LPCONFIG=testrunner-appserver should work as well15:40
noodles775EdwinGrubbs: just over 8hrs (00:00 UTC). and the current devel should be landing in db-devel any minute now (lp is currently updating the branch).15:41
marstestrunner-appserver dies complaining about the missing ftest db15:41
marsBjornT, shutting off devmode did the trick - now I can do "make run", and see that the JS is not loading15:43
marsstill no errors though15:43
marsBjornT, salgado-lunch, something broken in the module machinery again.  This could take a while.15:48
marssalgado-lunch, for now you can just use devmode to test features by hand, should work fine.15:48
barrybac: is it insane to run your script with arg1 == 500?15:53
bacbarry: no, why?15:56
barrybac: just in an effort to get it to timeout15:56
sinzuibarry: bac: EdwinGrubbs: noodles775: I propose that we timebox the fix for distroseries. If we do not have a branch in the next 6 hours, we add an exception the the milestone logic to not count IBaseDistribution.15:57
barrybac: locally15:57
bacbarry: yes, using 500 should be very snappy.  i ran with 1000.  it did not cause a timeout, though15:57
noodles775flacoste: ^^^ as I'll not be around, I'll leave that in flacoste's hands.15:57
barrybac: ah15:58
bacsinzui: are we using the regular conf number?15:58
barrybac: that's interesting15:58
bacbarry: which part?15:58
sinzuibac: yes15:58
barrybac: that it didn't timeout locally15:59
flacostesinzui: the branch need to be reviewed and QAed on staging, and if you land it through ec2 test, you haver less time than that15:59
sinzuiflacoste: okay, we make the hack now, If we solve it later this week we can ask for CP16:00
flacostesinzui: that's even better!16:00
kiko_workhey there!16:01
kiko_workflacoste, yo16:01
bacsinzui: i'm in the call.   it is now, right?16:02
sinzuiyes16:02
flacostekiko_work: hi there (on the phone)16:05
kiko_workflacoste, cool, ping me when you are free16:05
=== salgado-lunch is now known as salgado
Ursinhasinzui, is bug https://bugs.edge.launchpad.net/launchpad-registry/+bug/462742 supposed to be fixed?16:12
mupBug #462742: OOPS getting a project index page as an anonymous user <oops> <Launchpad Registry:Fix Committed by intellectronica> <https://launchpad.net/bugs/462742>16:12
Ursinhasinzui, I've noticed several occurrences of the oops you mentioned in your comment in the last days, but none yesterday16:13
sinzuiUrsinha: I think you need to talk to intellectronica. The bug affects the registry, but the origin that I understand is bugs16:20
Ursinhasinzui, ok, I'll talk to him16:22
Ursinhathanks sinzui16:24
=== deryck is now known as deryck[lunch]
marssinzui, ping re: base-layout JS macros16:46
=== beuno is now known as beuno-lunch
sinzuihi mars16:47
marshi sinzui, I assume you wrote base-layout.pt?16:48
sinzuiI did16:48
marscool16:48
marsfirst, nice job, it is a beautifully clean file :)16:48
Ursinhabigjools, there are two items from wgrant that are soyuz16:48
Ursinhabigjools, I've moved them from lp general testplan to soyuz one16:48
marssinzui, just wondering which macros, if any, that sub pages should use to put their own JS files onto the page16:49
sinzuihmm16:49
marsI see you have load-javascript16:49
marsand page-javascript16:49
mars(which calls load-javascript)16:50
sinzuiThe first is for fragemetns/iframes, the later if for a full page16:50
sinzuiThe latter does the extra work to activate common UI behaviours for classes16:50
sinzuimars: I wonder if we could simplify that if we removed the old maintemplate16:51
marssinzui, is there a converted page in registry that loads it's own JS that I could look at?16:51
sinzuiThe timeline is an example16:51
marsok16:51
marssinzui, so object-timeline-graph and timeline-macros?16:53
sinzuiYes, those should like the two items16:54
sinzuimars: The design permits users to embed the timeline on their site16:54
marsright, I see that.  Nice.16:54
sinzuiThe credit goes to EdwinGrubbs16:55
marssinzui, I see that productseries-index still uses the header-epilogue16:55
marsto add the unique JavaScript files16:56
sinzuiDoes the distroseries-index?16:56
marshead_epilogue16:56
sinzuioh no, because the there is no timeline for that16:56
sinzuiIt would be nice to factor the epilogue out16:57
marshmm16:57
sinzuiIt would be nice if I did not need to register the calendar widget on som many pages16:57
marsMy "nice to have" front-end list is growing quickly... :)16:57
marssinzui, I bet there is a nice general solution here, just need to think about it16:58
marsand I wish it was easy to create custom TAL elements!  <lp:calendar>16:59
marsor <tal:use-js src="blah/blah"/>16:59
sinzuiMy reason for nice to have is that we will have fewer bugs about calendars not activating if we have a unified solution. If the calendar were in the compressed JS, it could connect itself every time time a calendar class is used17:00
marssinzui, or we could use our own loader.  That would work too17:00
sinzuiyes17:00
flacostekiko_work: i'm free17:01
marssrc="loader?launchpad.js=3.0&calendar.js=2.0" or something17:01
sinzuimars: we had (maybe still have) a flag on the view that states if the calendar is required. We use the same solution for gmap. Maybe we could have a property on a view that base-layout knows to set the JS requirements17:03
sinzuiEdwinGrubbs: barry: one of us needs to create a branch to stop loading the summaries on IBaseDistribution. Can either of you do that in the next two hours? I can try, but I have only 90 minutes.17:04
EdwinGrubbssinzui: I can start on that as soon as I get my branch into pqm.17:06
marssinzui, I see, you store the "I need this JS" flags on the request object.  Works, but could be better.17:06
sinzuiYes, the old calendar did that17:07
sinzuiI copied the approach for gmap17:07
sinzuigmap is at the request level, I do not think the calendar is17:07
marsnope, gmap and json are though17:08
sinzuiLet me restate that. gmap is *currently* at the request level because there are no cases where one fragment needs the gmap and another say it does not17:08
sinzuiOSM might be easier17:09
marsOSM?17:09
sinzuiOpenStreamMaps. That would permit us to test the script in the test runner17:09
marsah17:10
sinzuiThat would also be cheaper (secure gmap costs money)17:10
marsI seems the JS-to-template component glue needs some work17:10
kiko_workflacoste, you are so nice!17:10
kiko_workhow are you?17:10
marssinzui, ok, thanks for the overview.  Now I can try to figure out why the JS rollup is not loading.17:12
sinzuiEdwinGrubbs: I just realised that we have MilestoneView.is_distroseries_milestone. The template/portlet could use that attribute to know that it should not get the status counts.17:14
EdwinGrubbssinzui: ok, I'll use that17:15
flacostekiko_work: i'm great, now that the buildbot has started working again17:30
kiko_workflacoste, what was the issue17:31
kiko_workI am working on business papers17:31
flacostekiko_work: we don't know17:31
Ursinhaderyck[lunch], when you return, do you intend to fix bug 394097 for the rollout?17:32
mupBug #394097: accessing message 0 of bug 371281 gives wrong return type of IMessage <api> <bug-page> <oops> <Launchpad Bugs:Triaged> <https://launchpad.net/bugs/394097>17:32
flacostekiko_work: well, one of the issue is that the time it took to checkout the branch was longer than the timeout17:32
kiko_workflacoste, sounds like a bzr optim issue!17:32
flacostekiko_work: sounds like a missing repo, yeah17:32
kiko_workheh17:36
=== deryck[lunch] is now known as deryck
deryckUrsinha, no, I hadn't thought about trying to get something for that in the rollout.  Let me look into it more and see what would take to fix it.17:41
Ursinhathanks deryck17:44
bigjoolsUrsinha: those two outstanding needstest are done17:44
Ursinhabigjools, ice_cream++17:44
* bigjools eat++17:44
Ursinhathanks bigjools :)17:45
bigjoolsUrsinha: there will be one more later when al-maisan gets something landed17:45
Ursinhabigjools, right17:45
Ursinhaderyck, there's also bug 453203 happening quite frequently, guess because of ubuntu release and people filing more bugs through apport17:46
mupBug #453203: UnicodeDecodeError in +filebug: unexpected code byte <oops> <Launchpad Bugs:New> <apport (Ubuntu):New> <https://launchpad.net/bugs/453203>17:46
deryckUrsinha, ok, will look17:47
Ursinhaderyck, thanks17:49
deryckUrsinha, for your second one, bug 453203, is there anything for us to do?  I thought allenap was going to talk to pitti about that as it was on apport's end.17:56
mupBug #453203: UnicodeDecodeError in +filebug: unexpected code byte <oops> <Launchpad Bugs:New> <apport (Ubuntu):New> <https://launchpad.net/bugs/453203>17:56
deryckmaybe I'm recalling wrong though.  allenap ?17:56
Ursinhaderyck, well, I don't know, that's what I asked in the bug :)17:56
allenapderyck: Yes, I need to talk to pitti.17:57
deryckUrsinha, oh, sorry. :)  Didn't look down that far.17:57
Ursinhaderyck, :)17:57
deryckallenap, is there anything we can do on our end, or that's what is to be learned from chat with pitti?17:58
allenapderyck: To be honest, I just need to ask him if he recognises the problem. Perhaps it rings a bell, or perhaps he can help me trace where it might be happening.17:59
deryckallenap, ok, cool.18:00
deryckUrsinha, so given that, I don't see us getting anything on that one today.18:00
allenapderyck: I'm not sure that the problem is with apport, or that he'll be able to help, but it's a next step.18:00
deryckgotcha18:01
Ursinhaok deryck, thanks18:02
=== beuno-lunch is now known as beuno
Ursinhaderyck, one last question :) who's testing the last item in bugs' testplan?18:08
deryckUrsinha, I thought we were green. :)  Let me look.18:08
deryckoh that's me :)18:09
* deryck draws the lucky short straw18:09
deryckUrsinha, I'll catch that here in a minute.18:09
Ursinhathanks deryck!18:10
deryckleonardr, ping18:11
leonardrhi deryck18:12
deryckleonardr, trying a little api test script on .dev server locally.  I get this:  http://pastebin.ubuntu.com/308693/18:12
deryckI see a bug that this should be fixed, right?18:12
leonardrderyck: you need to update lazr.restfulclient to 0.9.1018:12
deryckleonardr, ok, cool.  thanks.18:13
deryckleonardr, there's no 0.9.10 in download-cache.  Should there be?18:14
leonardrderyck: i'm working on that now18:14
deryckah, ok.18:15
leonardri'll probably commit it on monday when i come back from vacation and pqm is ope18:16
=== Ursinha is now known as Ursinha-food
thumperrockstar, abentley, mwhudson: I'll be a little late for the standup today as I'm going to watch Jessie present her project to the class (will go on for 2 minutes).18:22
thumperI shouldn't be too late, but just a heads up18:22
rockstarthumper, ack.18:27
rockstarthumper, it's really odd to see you around in my AM.18:27
thumper:)18:27
rockstarmars, what is the python in lazr-js for?18:30
=== dpm is now known as dpm-afk
jmlg'night all18:33
* rockstar lunches18:34
marsrockstar, the Python scripts?  Those are our build system.18:35
marsAnd some useful utilities.18:35
sinzuiEdwinGrubbs: barry: bac: I just noticed that Specification.milestone is not indexed in the DB. Did anyone investigate this as a cause for the distroseries timeouts?18:38
* sinzui still thinks the issue is the counts in the python code18:38
EdwinGrubbssinzui: I was working on getting some explains for that query. There is an index for (distribution, milestone), so as long as the query specifies both of those columns in the WHERE clause, it will use that index.18:40
sinzuiThanks for the explanation18:40
sinzuiEdwinGrubbs: bac: looking carefully at the oops that bac provided, I believe only 2 milestones were iterated through before the timeout. We have a long way to go to improve performance18:44
barryEdwinGrubbs, sinzui how odd: 2 milestones?  this is not reproducible on launchpad.dev18:58
sinzuibarry: That is a lot of processing time for about 1000 bugs!19:00
sinzuihttps://lp-oops.canonical.com/oops.py/?oopsid=OOPS-1402EB65619:00
barrysinzui: it sure is19:01
sinzuibarry: we are iterating over the bugs about 8 times each milestone. We are doing the same for blueprints, but on a lesser scale19:01
sinzuiI assume a lesser scale, I do not see how many blueprints are involved.19:02
bacsinzui: i setup a test locally with 1 milestone and 100 bugs and 100 blueprints for that milestone.  i saw get_status_counts called twice, once for bugs and once for blueprints.19:10
barrybac: that would make some sense given productseries-milestone-table-row.pt19:11
sinzuibac: yes the calls are correct, what about the times? were some of the bugs private?19:11
bacsinzui: no private bugs19:12
bacsinzui: but your earlier statement made it sound like that method was called more often.19:12
bacsinzui, barry: might be worth setting up multiple milestones to see while throwing in some private bugs19:12
barrybac: your setup script doesn't create any bugs.  that might be interesting to add19:14
bacbarry: the one i shared on U1 does.  can you see it?19:14
barrybac: only in my browser19:15
barrybac: i'll run that one19:15
sinzuibac: the get_status_counts is a loop oer all items passed.19:15
bacyou mean "o'er"19:15
bacsinzui: right, but i saw it called only once for bugs and once for blueprints.  perhaps i misunderstood your earlier comment.19:16
sinzuiI think so. Iterating over all the bugs to get the status.19:18
deryckUrsinha-food, when you're back, just an FYI, I don't think we'll get a fix for the message 0 bug today either.  I think there's more to it that just IMessage vs. IBugMessage.19:20
marssidnei, around?19:21
sidneimars: iam19:21
marshi sidnei, just wondering if you helped with the yui-patch.js file in lazr-js?19:21
barrybac: just fyi: you should add "import _pythonpath" to the top of your script19:21
marssidnei, I'd like like to know if it does anything beyond simply short-circuiting the file download process19:22
sidneimars: i didn't help. but that's all it does (you can diff against loader.js)19:22
bacbarry: i was just invoking with 'bin/py'19:22
barryah19:22
barrythe #! threw me off19:22
bacbarry: sorry...19:23
bacbad form19:23
barrybac: TypeError: makeSpecification() got an unexpected keyword argument 'owner'19:25
barrythat makes no sense19:25
bacbarry: the version U1 worked for me.  don't know.19:25
marssidnei, you are right, thanks for the info19:25
mwhudsongood morning19:27
barrybac: i'm not doubting you but that seems impossible ;)19:27
bacbarry: perhaps i put up the wrong version.  tweak at will.19:28
barrybac: k19:28
marssidnei, ah, do you know if that patch is used directly by jsTestDriver in some way?  I can't find any string occurances of the yui-patch.js fine in lazr-js itself.19:28
marsmorning mwhudson19:28
sidneimars: yes, through widgets.conf, which loads all the javascript needed for the tests.19:29
marssidnei, and is that in JSTestDriver?  Such a file is also not in lazr-js :/19:30
marswait, maybe I have the wrong branch here....19:30
marsthis is Bjorn's buildout branch19:30
sidneimars: right. i added it to lazr-js in my branch19:34
rockstarmars, is it really necessary to have our lazr-js build system given its own setup.py19:40
barrylosa ping19:44
barrylosa unping19:44
* mbarnett runs in then back out very quickly19:45
marsrockstar, in order to use it via buildout, yes19:48
rockstarmars, sad.19:48
marsrockstar, we are kind of pretending that it is a python dependency instead of using some tarball or something19:48
abentleythumper: ack.19:48
marsrockstar, I don't know why19:48
marsrockstar, may a been the simplest path to taking advantage of the buildout versioning capabilities?19:49
rockstarmars, well, it just seems to clutter things up I guess.  It's not in my way or anything.19:50
marsthink about it this way: if it was a requirement of launchpad-developer-dependencies, we would be layering some debian/ stuff on top19:50
marsinstead, we are layering the Python eggs+zc.buildout stuff on top19:50
marsthey both serve the same role19:50
marsrockstar, after hanging out for a few years on distutils-sig, I've come to the conclusion that there is no good solution to this stuff.  Only pragmatic ones.19:51
rockstarmars, yeah, but it seems odd that a javascript library would be using a python specific build system.  Maybe that's not wrong, just odd.19:52
marsrockstar, kind of odd - we are not used to thinking of Python as build system glue.  Maybe it would be more normal to have a wrapper that takes the lazr-js tarball and builds that into an egg instead.19:54
marsinstead of putting the egg guts into the lazr-js source tree19:55
rockstarmars, well, that would require work. I prefer complaining.19:55
rockstar:)19:55
marslol19:55
marsyou know, that would be pretty clean, put everything zc.buildout and setuptools related under a pdist/ directory, just like apt packages have a debian/ directory.19:57
marswould hide setup.py, setup.cfg, .egg-info...19:59
=== abentley1 is now known as abentley
mwhudsonabentley: hi20:18
abentleymwhudson: Hi.20:18
rockstarmwhudson, did you see that the puller blew up again?20:19
mwhudsonabentley: am i going blind, or is BranchMergeProposalJobDerived.iterReady missing a join like BranchMergeProposalJob.branch_merge_proposal = BranchMergProposal.id ?20:19
mwhudsonrockstar: yeah :/20:19
mwhudsonabentley: i guess the distinct=True on the results means this doesn't actually give the wrong results...20:20
abentleymwhudson: I think you might be right.20:23
abentleymwhudson: We can't be sure that the Branch is the source_branch of the BranchMergeProposal for the job using this query, right?20:24
mwhudsonabentley: right20:24
mwhudsonabentley: i think it's a cross join (is that the word)?  you'll get every ready branchmergeproposaljob of the right type for every branch that's up to date with mirroring20:25
mwhudson*every branch that's the source of a merge proposal20:26
mwhudsonof course the reason i'm looking at this is that in my branch is that it doesn't return a job it should be returning20:26
mwhudsonoh, that's easy20:27
abentleymwhudson: That might explain why sometimes the merge proposal creation job dies with NotBranchError.20:27
mwhudsonabentley: yes it might20:27
* mwhudson makes a new branch20:28
thumpermwhudson: if it is getting it wrong, could be rc candidate20:28
thumperabentley, rockstar: one of you want to host the conf call?20:28
=== salgado is now known as salgado-afk
abentleythumper: I'll do it.20:28
mwhudsonthumper: i think it will be getting it wrong some of the time, will write some tests after the calls20:29
mwhudson-s20:29
=== EdwinGrubbs is now known as Edwin-lunch
marssidnei, since it looks like JSTestDriver wants to load everything and completely ignore the YUI loader, it may be better to bypass it entirely.20:35
marssidnei, I've checked the source: in 3.0final you can unbundle the loader, and the module dependencies should still work20:35
* mars heads over to #yui to ask20:35
sidneimars: interesting.20:35
sidneimars: if you figure that out let me know, i haven't merged my yui3 branch of lazr-js yet.20:36
marssidnei, when you have some time, could you try out this patch against your JSTestDriver branch?  It should remove the YUI loader21:15
marssidnei, http://pastebin.ubuntu.com/308823/21:16
sidneimars: awesome. will do.21:17
sidneimars: also need to figure out how to submit my branches to pqm, they failed on friday.21:17
=== sidnei is now known as sidnei-away
=== Ursinha-food is now known as Ursinha
mwhudsonabentley: is there a bug for "sometimes the merge proposal creation job dies with NotBranchError" ?21:30
abentleymwhudson: Yes, and I've linked your branch to it.21:30
mwhudsonabentley: oh right :)21:30
=== Edwin-lunch is now known as EdwinGrubbs
sinzuiChex: ping22:09
Chexsinzui: hello22:10
sinzuiChex: can you run the cronsripts/product-release-finder on staging ?22:10
sinzuibarry, did you remove then recreate the Ubuntu Haiku list?22:15
barrysinzui: nope22:15
Chexsinzui: sure22:16
barrysinzui, flacoste, mbarnett email to ~haibunku on staging looks great.  i feel good about the mailman upgrade22:21
mbarnettbarry: yay22:22
sinzuibarry: and new team members will get an email telling them *how* to subscribe to the list. Best update ever22:22
barry\o/22:22
jmlbarry, please fix the moderation link in emails.23:01
wgrantelmo: Don't worry, Soyuz isn't as insane as you seem to have assumed.23:28
elmowgrant: well23:28
elmowgrant: it's not so much an assumption but history/experience; I'd be happy to be wrong about it23:29
wgrantelmo: See my comment in bug #47107623:29
mupBug #471076: filecache-default corruption should not happen <Launchpad Auto Build System:New> <https://launchpad.net/bugs/471076>23:29
elmoblah23:31
wgrantHeh. Yes.23:31
elmofine, fine23:31
elmowell I can't hardly diagnose it now since launchpad helpfully removed the "bad" version from the cache23:31
wgrantOops.23:32
wgrantelmo: Are all the buildds on >= Hardy at the moment, or are the PPC ones still Dapper?23:33
wgrantBecause they are all going to need a dpkg backport very soon.23:33
elmowgrant: ppc are dapper still23:33
elmois dpkg-source run outside the chroot?23:34
wgrant:(23:34
wgrantIt is.23:34
wgrantEasiest might be to move it inside, then.23:34
elmowell that's freedom hating23:34
elmoI'm only running dapper because hardy epically fails on that hardware23:34
elmoif karmic works, I'd run that23:35
wgrantI'd really like to minimise the patches required against sbuild and run a less ancient unmaintained fork...23:35
elmoso would I :)23:35
wgrantI've just remembered that lp-buildd's ancient sbuild needs fixes to work with >= karmic dpkg-source, anyway. So it needs patching either way.23:38

Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!