=== Edwin-lunch is now known as Edwin
=== Edwin is now known as EdwinGrubbs
=== Ursinha is now known as Ursinha-afk
=== stub1 is now known as stub
[08:00] <noodles775> Hi stub, is your branch (bug 461800) already through ec2 test etc., and ready to land? (or is there other manual testing that you had to do?)
[08:00] <mup> Bug #461800: new-slave.py no longer works <current-rollout-blocker> <Launchpad Foundations:In Progress by stub> <https://launchpad.net/bugs/461800>
[08:01] <stub> noodles775: That script is only tested on staging - everything in database/replication is outside of our test suite.
[08:02] <noodles775> stub: great, so land away then :)
[08:02] <stub> noodles775: ok. It was a branch of db-devel - is that going to be a problem with the current buildbot situation?
[08:02] <noodles775> stub: strange? the MP says that it's for merging into devel... 
[08:03]  * stub double checks
[08:03] <stub> noodles775: Yes, you are right. It can land on launchpad/devel.
[08:03] <noodles775> stub: would it be quicker to get it qa'd if you land directly into db-devel?
[08:04] <noodles775> I'm about to try sending off a manual ec2 test run of db-devel...
[08:04] <stub> noodles775: Not really
[08:04] <noodles775> OK, then devel it is. Thanks!
[08:53] <al-maisan> hello gmb, when you start your day: I have a branch fixing an r-c bug for review: https://code.edge.launchpad.net/~al-maisan/launchpad/subsets/+merge/14343
=== al-maisan changed the topic of #launchpad-reviews to: on call: - || reviewing: - || (r-c candidates skip the queue) queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com/
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || (r-c candidates skip the queue) queue: [al-maisan] || This channel is logged: http://irclogs.ubuntu.com
[09:38] <gmb> al-maisan: Thanks. I'll get started on it shortly.
[09:39] <al-maisan> gmb: thanks
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: al-maisan || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[10:14] <gmb> al-maisan: Looks good. r=me. Go ahead and request an rc review for it.
[10:14] <al-maisan> gmb: thank you very much.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[10:15] <al-maisan> noodles775: ^^
[10:15] <noodles775> Thanks al-maisan 
=== henninge is now known as henninge-bbl
=== danilos-afk is now known as danilos
=== Ursinha-afk is now known as Ursinha
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: lunch || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[12:44] <al-maisan> gmb: here's another likely r-c candidate: https://code.edge.launchpad.net/~al-maisan/launchpad/getbyname-472608/+merge/14354
[12:44] <al-maisan> please take a look when you get back.
=== bigjools-afk is now known as bigjools
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: al-maisan || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[13:06] <gmb> al-maisan: Okay, looking now.
[13:07] <al-maisan> gmb: thanks!
[13:08] <gmb> al-maisan: Looks good, r=me.
[13:08] <al-maisan> gmb: thank you very much!
[13:09] <gmb> al-maisan: You know it's a good review day when you get small Soyuz branches ;)
[13:09] <al-maisan> gmb: :)
[13:12] <bac> gmb: quiet day?  i'll be joining you here after i grab a quick bite to eat.
[13:12] <gmb> bac: Very quiet. I've reviewed entirely 2 RC requests, so everything must be working perfectly and we need fix nothing ever again.
[13:13] <bac> gmb: your assessment is spot on IMO.  perhaps i'll take a longer breakfast in light of our accomplishments.
[13:14] <gmb> A wise move.
[13:14] <noodles775> hey bac! There's 3 'In progress' registry crb bugs listed at https://bugs.edge.launchpad.net/launchpad-project/+bugs?field.searchtext=&orderby=-importance&assignee_option=any&field.assignee=&field.bug_reporter=&field.bug_supervisor=&field.bug_commenter=&field.subscriber=&field.omit_dupes.used=&field.has_patch.used=&field.has_cve.used=&field.tag=current-rollout-blocker&field.tags_combinator=ANY&search=Search
[13:14] <noodles775> woops, sorry.
[13:15] <noodles775> But just wondering whether you know if they are really still in progress, or what their status is?
[13:16]  * bac looks
[13:17] <bac> noodles775: i know the two distroseries timeouts are being investigated.  i'm not sure about the other.
[13:18] <bac> noodles775: based on the last comment of bug 437184 i'd guess that edwin is working on it
[13:18] <mup> Bug #437184: New "See full publishing history" location is less useful <current-rollout-blocker> <post-3-ui-cleanup> <trivial> <Launchpad Registry:In Progress by edwin-grubbs> <https://launchpad.net/bugs/437184>
[13:19] <noodles775> bac: thanks - it's just getting quite late if they need QA on staging.
[13:21] <bac> noodles775: yes, i agree
[14:25] <leonardr> gmb, can you put https://code.edge.launchpad.net/~leonardr/launchpadlib/choose-your-client/+merge/14361 in the queue?
[14:27] <gmb> leonardr: Sure
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: leonardr || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:28] <gmb> leonardr: RC candidate?
[14:28] <leonardr> gmb: no
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: leonardr, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:39] <gmb> bac: Could you take a look at https://code.edge.launchpad.net/~gmb/launchpad/affects-me-spinner-bug-458766/+merge/14360 for me? It's not RC.
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: leonardr, gmb || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:41] <gmb> bac: I've just noticed that I've introduced some lint in the last hunk of the diff. Please ignore that; I'm fixing it now.
[14:41] <bac> ok
[14:42] <gmb> leonardr: Your branch looks good. r=me.
[14:42] <leonardr> gmb, that was quick, ok
[14:43] <gmb> leonardr: No, I'm just single-minded. I can review it again if you'd like ;)
[14:43] <leonardr> haha
[14:44] <gmb> I've also had two years of reviewing cprov's Soyuz patches. That makes you faster at reading code...
=== gmb changed the topic of #launchpad-reviews to: on call: gmb || reviewing: -, gmb || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, gmb || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[14:44] <gmb> argh
[14:45] <al-maisan> :)
=== Ursinha changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, gmb || (r-c candidates skip the queue) queue: [Ursinha] || This channel is logged: http://irclogs.ubuntu.com
[15:02] <gmb> Ursinha: Do you have an m-p for your branch?
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: Ursinha, gmb || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:03] <Ursinha> gmb, yes sir
[15:03] <Ursinha> gmb, https://code.edge.launchpad.net/~ursinha/launchpad/bug-391569-add-last-changed-column/+merge/14366
[15:03] <gmb> Ursinha: Thanks.
[15:03] <gmb> Ursinha: Is this RC?
[15:13] <bac> gmb: r=bac.  sorry it took so long, i got pulled into a long stand-up call
=== bac changed the topic of #launchpad-reviews to: on call: gmb, - || reviewing: Ursinha, gmb || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:13] <gmb> bac: No worries, it's not RC.
[15:13] <gmb> Thanks.
[15:14] <bac> gmb: it even works with webkit
[15:14] <gmb> bac: Glad you said so... I was wondering if it might just be for me that it worked. Webkit compatibility seems more'n a bit flaky in places.
[15:15] <bac> gmb: yeah, that's why i try testing stuff where possible
=== salgado is now known as salgado-lunch
=== bac changed the topic of #launchpad-reviews to: on call: gmb, bac|| reviewing: Ursinha, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:25] <gmb> Ursinha: r=me with some stylistic changes (see my comments, they're pretty minimal).
[15:25] <gmb> Nice job.
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac || reviewing: -, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: -, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[15:41] <gmb> bac: I'm going to go an try and get some hacking done. Give me a shout if the sky starts falling.
[15:42] <bac> gmb: ok.  have a call at the top of the hour that may last an hour or so.  can you keep on eye out here during that time?
[15:42] <gmb> Sure.
[15:42] <bac> gmb: thanks
[15:54] <adeuring> bac: could you please review this mp: https://code.edge.launchpad.net/~adeuring/launchpad/bug-435556/+merge/14368 ? (140 lines diff)
[15:56] <bac> adeuring: is this for an RC?
[15:56] <adeuring> bac: no
[15:57] <bac> adeuring: i have a call starting in 4 minutes.  i can review it or in an hour or you can ask gmb
[15:58] <adeuring> bac: sure, no problem. (i think gmb doesn't want to do more reviews today)
[16:01] <bac> adeuring: ok i'll get to it when i can
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || (r-c candidates skip the queue) queue: [abel] || This channel is logged: http://irclogs.ubuntu.com
[16:02] <adeuring> bac: sure, no hurry. (the branch will sit anyway around until PQM opens again)
[16:09] <gmb> bac, abel: I'll take it - I was OTP.
=== gmb changed the topic of #launchpad-reviews to: on call: bac || reviewing: abel, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[16:09] <gmb> adeuring: ^^
=== salgado-lunch is now known as salgado
[16:09]  * gmb curses nickname changes across servers
[16:10] <adeuring> gmb: thanks!
=== bac changed the topic of #launchpad-reviews to: on call: bac-otp || reviewing: abel, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== gmb changed the topic of #launchpad-reviews to: on call: gmb, bac-otp || reviewing: abel, - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[16:33] <Ursinha> gmb, thanks for your review and the tips
[16:33] <gmb> adeuring: Can you re-push your branch? There's no diff showing up and I can't branch from it; I get a "not a branch" error.
[16:35] <gmb> Ursinha: You're welcome.
[16:36] <adeuring> gmb: done. new branch, new MP
[16:36] <gmb> adeuring: Thanks.
[16:37]  * gmb goes to get a drink while the branch updates
=== deryck is now known as deryck[lunch]
[16:44] <gmb> adeuring: Weird; that branch still shows as "Not pushed to yet" Could you push it to another location on LP for me? I wonder if something in codehosting has gone *boing*
[16:44] <adeuring> gmb: what do you mean with "other location"?
[16:45] <gmb> adeuring: Try `bzr push lp:~adeuring/launchpad/foo` rather than just `bzr push`.
[16:45] <adeuring> gmb: ah, ok
[16:46] <adeuring> gmb:  lp:~adeuring/launchpad/review-435556
[16:47]  * gmb looks
=== beuno is now known as beuno-lunch
[16:49] <gmb> adeuring: Yep, I think something on codehosting is broken; both branches are showing as not having been pushed to.
[16:49] <adeuring> gmb: right, but you can branch from them.
[16:49] <gmb> adeuring: Interesting; I can't. 
[16:50] <adeuring> odd...
[16:50] <gmb> Ah, well, I can't *merge* from them. Hang on...
[16:51] <adeuring> gmb: here's the diff: http://paste.ubuntu.com/308634/
[16:52] <gmb> adeuring: Thanks.
[16:58] <gmb> adeuring: Your changes look good. r=me.
[16:58] <adeuring> gmb: thanks1
[16:58] <adeuring> erm, thanks!
=== gmb changed the topic of #launchpad-reviews to: on call: bac-otp || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[17:38] <adeuring> gmb: could you please formally give your review here: https://code.edge.launchpad.net/~adeuring/launchpad/bug-435556/+merge/14370 ?
=== deryck[lunch] is now known as deryck
=== bac changed the topic of #launchpad-reviews to: on call: bac-lunch || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== beuno-lunch is now known as beuno
[18:09] <gmb> adeuring: Done
[18:09] <adeuring> gmb: thanks!
=== Ursinha is now known as Ursinha-food
[18:23] <EdwinGrubbs> bac: can you review https://code.edge.launchpad.net/~edwin-grubbs/launchpad/disable-summaries-for-distroseries/+merge/14374
[18:24] <sinzui> EdwinGrubbs: thanks for getting this done so quickly
[18:51] <EdwinGrubbs> sinzui: bac doesn't seem to be around, can you review ^^^
[18:51] <sinzui> I will
[18:53] <sinzui> Edwin: I am not excited by the "Not displayed on distroseries page for performance reasons."
[18:53] <sinzui> Also, this is both distroseries +index and +milestone
[18:54] <sinzui> The change also removes the milestone summary
[18:55] <sinzui> EdwinGrubbs: You could replace the technical message with
[18:55] <sinzui>     <tal:summary          content="structure milestone/summary/fmt:shorten/80" /> 
[18:55] <sinzui> so that users can see something about the milestone
[18:56] <EdwinGrubbs> sinzui: are you saying that you don't want this change to affect both the distroseries +index and +milestone?
[18:58] <EdwinGrubbs> sinzui: oh, I see, you are saying that the comment about the "distroseries page" is inaccurate.
[18:58] <sinzui> correct.
[18:58] <sinzui> Your fix should fix both page :)
=== bac changed the topic of #launchpad-reviews to: on call: bac || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
[19:06] <EdwinGrubbs> sinzui: new diff posted: https://code.edge.launchpad.net/~edwin-grubbs/launchpad/disable-summaries-for-distroseries/+merge/14374
[19:08] <sinzui> EdwinGrubbs: Looks good to land.
[19:10] <EdwinGrubbs> sinzui: thanks
[19:10] <EdwinGrubbs> noodles775, flacoste: can I get an RC for https://code.edge.launchpad.net/~edwin-grubbs/launchpad/disable-summaries-for-distroseries/+merge/14374
[19:11] <al-maisan> hello bac, I have a branch that fixes an r-c bug: https://code.edge.launchpad.net/~al-maisan/launchpad/uploadurl-472929/+merge/14382
[19:11] <al-maisan> Could you please take a look?
[19:11] <bac> al-maisan: on it
[19:11] <al-maisan> bac: thanking you.
[19:12] <flacoste> EdwinGrubbs: done
[19:12] <EdwinGrubbs> thanks
[19:17] <bac> al-maisan: at line 16 of your diff, is self.context.distribution a dictionary?
[19:18] <al-maisan> bac: self.context is an IArchive instance
[19:18] <al-maisan> and distribution is one of its properties
[19:18] <bac> al-maisan: right but your indexing into it with ...distribution[series] so i wonder if that is a dict
[19:19] <bac> argh!  s/your/you're
[19:19] <al-maisan> bac, that's right, Archive implements a __get_item__() method
[19:20] <bac> al-maisan: so can you use .get(series) and avoid the try/NotFoundError ?
[19:20] <al-maisan> bac, wait, it's Distribution that has that method.
[19:20] <al-maisan> bac, let me look.
[19:20] <bac> al-maisan: yes, see if you can collapse lines 15-18 to
[19:21] <bac> series = self.context.distribution.get(series)
[19:21] <al-maisan> bac, ah, I see what you mean. Just treat it like a dict.
[19:22] <bac> yes
[19:23] <al-maisan> hmm ..
[19:23] <al-maisan>       File "/home/mhr/canonical/lp-branches/uploadurl-472929/lib/lp/soyuz/browser/archive.py", line 294, in _traverse_permission
[19:23] <al-maisan>         series = self.context.distribution.get(series)
[19:23] <al-maisan>     ForbiddenAttribute: ('get', <Distribution at 0xbbef1d0>)
[19:23] <al-maisan> bac ^^
[19:24] <al-maisan> I was trying http://pastebin.ubuntu.com/308740/
[19:24] <bac> al-maisan: ok then!
[19:24] <al-maisan> sorry
[19:26] <bac> al-maisan: i'm confused by the multiple checks at 13 and 19.  can 20-21 be moved under the check at 13?
[19:26]  * al-maisan looks
[19:27] <bac> perhaps not
[19:29] <al-maisan> bac: so, on lines 15-18 I am making sure that the series passed in by the user (via an URL param) is actually there.
[19:29] <al-maisan> if I can't find it, it is the same as if it was missing i.e. the result is a 404
[19:30] <al-maisan> otherwise I look up the package set, and, if I find that I attempt to find at least one archive permission
[19:32] <al-maisan> bac: please note also that I tested the branch on the Soyuz dogfood system.
[19:32] <bac> al-maisan: was there a reason for s/grouchy-thunderbird/thunderbird/ ?
[19:32] <al-maisan> bac: yes, I wanted 2 package sets with the same name
[19:33] <bac> ah, ok
[19:33] <al-maisan> in order to test that they are disambiguated on a distro series basis
[19:33] <bac> gotcha
[19:35] <bac> al-maisan: r=bac.  thanks!
[19:35] <al-maisan> bac: thanks a million
[19:35] <al-maisan> !!
[19:51] <bac> al-maisan: you going to try for an r-c from flacoste?
[19:51] <al-maisan> bac: I did ping him on lp-code
[19:52] <al-maisan> flacoste: the branch in question is: https://code.edge.launchpad.net/~al-maisan/launchpad/uploadurl-472929
[19:52] <al-maisan> could I please have an r-c for it?
[20:00] <al-maisan> flacoste: sorry for nagging but the midnight UTC deadline is drawing closer.
=== abentley1 is now known as abentley
[20:12] <flacoste> al-maisan: has this been QA-ed on dogfood yet?
[20:12] <al-maisan> flacoste: yes indeed.
[20:12] <flacoste> al-maisan: ok, rc=me, did you update LPS with your UPDATE query yet?
[20:13] <al-maisan> flacoste: I am working on it as we speak.
[20:13] <al-maisan> flacoste: thanks for the rc.
=== bac changed the topic of #launchpad-reviews to: on call: - || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com
=== salgado is now known as salgado-afk
=== EdwinGrubbs is now known as Edwin-lunch
[21:10] <mwhudson> abentley: want to review this branchmergeproposaljob join fix?
[21:10] <mwhudson> it's about 15 lines
[21:10] <abentley> mwhudson: Okay.
[21:18] <mwhudson> abentley: you should have an email by now
=== sidnei is now known as sidnei-away
[21:20] <abentley> mwhudson: r=me
[21:21] <mwhudson> abentley: thanks
=== Ursinha-food is now known as Ursinha
=== Edwin-lunch is now known as EdwinGrubbs