| === jtv changed the topic of #launchpad-reviews to: on call: jtv || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| jtv | stub: care to review this tiny reordering? https://code.edge.launchpad.net/~jtv/launchpad/message-sharing-rearrange-commits/+merge/14342 | 04:40 |
|---|---|---|
| stub | approved | 05:11 |
| jtv | hi mrevell! I've written up that article about trying out Translations on staging. Care to proof-read it? (Warning: it's pretty long). | 07:15 |
| mrevell | jtv, I'd love to, thanks man. Wanna email it or do you have a link? | 07:16 |
| jtv | mrevell: the email is on its way | 07:16 |
| jtv | mrevell: what does strike me about it is how long it all gets, what with the bzr setup. Wish there were some easy https-based way to get people started or something. It's liberally interspersed with links to your documentation though. | 07:17 |
| jtv | (14:16:36) jtv: mrevell: the email is on its way | 07:18 |
| jtv | (14:17:44) jtv: mrevell: what does strike me about it is how long it all gets, what with the bzr setup. Wish there were some easy https-based way to get people started or something. It's liberally interspersed with links to your documentation though. | 07:19 |
| === henninge is now known as henninge-bbl | ||
| === henninge-bbl is now known as henninge | ||
| === salgado-afk is now known as salgado | ||
| === jtv changed the topic of #launchpad-reviews to: n call: - || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === jtv changed the topic of #launchpad-reviews to: on call: - || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === danilo_ is now known as danilos | ||
| === abentley1 is now known as abentley | ||
| jtv | stub: removing the entire debug output stanza and gc.collect() from the script for production... that ok with you? | 14:07 |
| jtv | I mean, in the branch you reviewed | 14:07 |
| stub | jtv: Yup | 14:07 |
| jtv | thx | 14:07 |
| === sidnei-away is now known as sidnei | ||
| === EdwinGrubbs changed the topic of #launchpad-reviews to: on call: EdwinGrubbs || reviewing: - || (r-c candidates skip the queue) queue: [] || This channel is logged: http://irclogs.ubuntu.com | ||
| === sidnei is now known as sidnei-away | ||
| === salgado is now known as salgado-lunch | ||
| === matsubara is now known as matsubara-lunch | ||
| === danilo_ is now known as danilos | ||
| === salgado-lunch is now known as salgado | ||
| === EdwinGrubbs is now known as Edwin-lunch | ||
| sinzui | barry: ping | 17:01 |
| === matsubara-lunch is now known as matsubara | ||
| sinzui | barry: noodles775_: flacoste: I hope for a review and an RC for https://code.edge.launchpad.net/~sinzui/launchpad/full-page-width/+merge/14427 | 17:05 |
| flacoste | sinzui: why did you add a .full-page-width CSS class? | 17:20 |
| flacoste | sinzui: ignore me, i understand | 17:21 |
| flacoste | sinzui: can you add a comment above the CSS rule pointing to a test-case for it (what people should look at when they update it? | 17:21 |
| sinzui | There is no nest case for it. The behaviour was seen because the markup was invalid | 17:22 |
| === deryck is now known as deryck[lunch] | ||
| sinzui | flacoste: I considered not adding the CSS rule. The nesting experience as a surprise. It was not something obvious, so I added a rule to prevent it from happening again. It is like the clear rules in the CSS that define after rules to ensure the core rule is consistent | 17:24 |
| flacoste | sinzui: that in a comment would be enough | 17:24 |
| sinzui | okay | 17:25 |
| sinzui | /* The content is already full width; the content should remain full width. */ | 17:27 |
| sinzui | flacoste: The branch that landed the invalid markup was fixing the layout of two edit icons for webkit. There were no test changes, we just reviewed the UI | 17:34 |
| === flacoste is now known as flacoste_lunch | ||
| al-maisan | Hello EdwinGrubbs, could you please review https://code.edge.launchpad.net/~al-maisan/launchpad/parc-456551/+merge/14430 ? | 17:54 |
| al-maisan | It's a potential r-c candidate. | 17:54 |
| EdwinGrubbs | al-maisan: Im out of the office running an errand. Is this something i can review by just looking at the diff on my phone? | 17:57 |
| al-maisan | EdwinGrubbs: sure, http://pastebin.ubuntu.com/309759/ | 17:58 |
| al-maisan | EdwinGrubbs: please note: it is the first 20 lines of the diff that matter. | 17:58 |
| al-maisan | EdwinGrubbs: I need to grab dinner but will be back later. | 18:01 |
| EdwinGrubbs | al-maisan: What is the last else? | 18:02 |
| al-maisan | EdwinGrubbs: the last else are primary archive (ubuntu) uploads | 18:04 |
| al-maisan | else: | 18:04 |
| al-maisan | archives = [self.policy.archive] | 18:04 |
| EdwinGrubbs | al-maisan: i dont quite understand the difference between the archive for the elif and the one for the else | 18:09 |
| al-maisan | EdwinGrubbs: the 'elif' clause is for uploads to PPAs | 18:10 |
| EdwinGrubbs | al-maisan: r=me | 18:11 |
| al-maisan | EdwinGrubbs: thanks! | 18:11 |
| === danilos is now known as danilo-afk | ||
| === deryck[lunch] is now known as deryck | ||
| === flacoste_lunch is now known as flacoste | ||
| Ursinha | all: do I have to do something else besides filing a merge proposal to get a db review from stub? | 19:56 |
| === salgado is now known as salgado-afk | ||
| === matsubara is now known as matsubara-afk | ||
| === sidnei-away is now known as sidnei | ||
| === EdwinGrubbs2 is now known as EdwinGrubbs | ||
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!