[04:40] <jtv> stub: care to review this tiny reordering?  https://code.edge.launchpad.net/~jtv/launchpad/message-sharing-rearrange-commits/+merge/14342
[05:11] <stub> approved
[07:15] <jtv> hi mrevell!  I've written up that article about trying out Translations on staging.  Care to proof-read it?  (Warning: it's pretty long).
[07:16] <mrevell> jtv, I'd love to, thanks man. Wanna email it or do you have a link?
[07:16] <jtv> mrevell: the email is on its way
[07:17] <jtv> mrevell: what does strike me about it is how long it all gets, what with the bzr setup.  Wish there were some easy https-based way to get people started or something.  It's liberally interspersed with links to your documentation though.
[07:18] <jtv> (14:16:36) jtv: mrevell: the email is on its way
[07:19] <jtv> (14:17:44) jtv: mrevell: what does strike me about it is how long it all gets, what with the bzr setup.  Wish there were some easy https-based way to get people started or something.  It's liberally interspersed with links to your documentation though.
[14:07] <jtv> stub: removing the entire debug output stanza and gc.collect() from the script for production... that ok with you?
[14:07] <jtv> I mean, in the branch you reviewed
[14:07] <stub> jtv: Yup
[14:07] <jtv> thx
[17:01] <sinzui> barry: ping
[17:05] <sinzui> barry: noodles775_: flacoste: I hope for a review and an RC for https://code.edge.launchpad.net/~sinzui/launchpad/full-page-width/+merge/14427
[17:20] <flacoste> sinzui: why did you add a .full-page-width CSS class?
[17:21] <flacoste> sinzui: ignore me, i understand
[17:21] <flacoste> sinzui: can you add a comment above the CSS rule pointing to a test-case for it (what people should look at when they update it?
[17:22] <sinzui> There is no nest case for it. The behaviour was seen because the markup was invalid
[17:24] <sinzui> flacoste: I considered not adding the CSS rule. The nesting experience as a surprise. It was not something obvious, so I added a rule to prevent it from happening again. It is like the clear rules in the CSS that define after rules to ensure the core rule is consistent
[17:24] <flacoste> sinzui: that in a comment would be enough
[17:25] <sinzui> okay
[17:27] <sinzui> /* The content is already full width; the content should remain full width. */
[17:34] <sinzui> flacoste: The branch that landed the invalid markup was fixing the layout of two edit icons for webkit. There were no test changes, we just reviewed the UI
[17:54] <al-maisan> Hello EdwinGrubbs, could you please review https://code.edge.launchpad.net/~al-maisan/launchpad/parc-456551/+merge/14430 ?
[17:54] <al-maisan> It's a potential r-c candidate.
[17:57] <EdwinGrubbs> al-maisan: Im out of the office running an errand. Is this something i can review by just looking at the diff on my phone?
[17:58] <al-maisan> EdwinGrubbs: sure, http://pastebin.ubuntu.com/309759/
[17:58] <al-maisan> EdwinGrubbs: please note: it is the first 20 lines of the diff that matter.
[18:01] <al-maisan> EdwinGrubbs: I need to grab dinner but will be back later.
[18:02] <EdwinGrubbs> al-maisan: What is the last else?
[18:04] <al-maisan> EdwinGrubbs: the last else are primary archive (ubuntu) uploads
[18:04] <al-maisan>         else:
[18:04] <al-maisan>             archives = [self.policy.archive]
[18:09] <EdwinGrubbs> al-maisan: i dont quite understand the difference between the archive for the elif and the one for the else
[18:10] <al-maisan> EdwinGrubbs: the 'elif' clause is for uploads to PPAs
[18:11] <EdwinGrubbs> al-maisan: r=me
[18:11] <al-maisan> EdwinGrubbs: thanks!
[19:56] <Ursinha> all: do I have to do something else besides filing a merge proposal to get a db review from stub?