| === sinzui is now known as citrus | ||
| === allenap changed the topic of #launchpad-reviews to: on call: allenap || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com | ||
| wgrant | allenap: I have a slightly (~16 lines once you exclude the inherited sample data changes) oversized branch. Can you have a look at it? | 11:03 |
|---|---|---|
| allenap | wgrant: Sure. | 11:06 |
| wgrant | allenap: https://code.edge.launchpad.net/~wgrant/launchpad/distroseries-source-format-selection-part1/+merge/14729 | 11:07 |
| wgrant | I was assuming someone Soyuzy would review it, so if you need more explanation just ask. | 11:07 |
| allenap | wgrant: Actually, do you mind asking someone Soyuzy to look at this? I think this needs some domain knowledge to do it justice. bigjools, can you suggest someone to review wgrant's branch? | 11:10 |
| bigjools | just me really :/ | 11:12 |
| bigjools | but I am rather busy | 11:12 |
| wgrant | noodles is at lazr-js? | 11:12 |
| bigjools | yeah | 11:12 |
| bigjools | I'll try and get to it later wgrant | 11:13 |
| allenap | bigjools: Is Muharem away? | 11:14 |
| wgrant | bigjools: Thanks. | 11:15 |
| bigjools | he's not but he's busy too | 11:15 |
| bigjools | we've got stuff that needs to be done before Monday or we'll block others | 11:15 |
| allenap | bigjools: Okay, thanks. If you get an early impression that the approach is basically sound then I'm happy to review the boring bits, like style, docstrings, etc, if that'll help. | 11:18 |
| bigjools | allenap: that would be very useful, thank you | 11:19 |
| bigjools | E_notenoughpeopledoingsoyuz :( | 11:19 |
| wgrant | Found your fourth musketeer yet? | 11:20 |
| bigjools | yes | 11:20 |
| bigjools | all will be revealed by the end of the week I hope | 11:20 |
| wgrant | Aha. | 11:21 |
| bigjools | hmmm my 4 core could do with a faster disk | 11:21 |
| danilos | allenap, hi, I've got a CP candidate for review, it's very short :) if you have time, it's up at https://code.edge.launchpad.net/~danilo/launchpad/bug-479385/+merge/14742 | 12:16 |
| allenap | danilos: Sure :) | 12:16 |
| danilos | allenap, thanks :) | 12:21 |
| allenap | danilos: r=me. | 12:22 |
| danilos | allenap, thanks! | 12:22 |
| bigjools | wgrant: I'm going to start reviewing your branch now | 12:25 |
| danilos | bigjools, happy to hear you are ignoring anything else in life to unblock "others" :) thanks! | 12:26 |
| bigjools | danilos: I don't want the Serbian mafia on my case | 12:26 |
| danilos | bigjools, hehe, nobody does :) | 12:27 |
| === mrevell is now known as mrevell-lunch | ||
| === ursula is now known as Ursinha | ||
| bigjools | allenap: I reviewed wgrant's branch but it would be good if you also did as we agreed :) | 13:32 |
| === mrevell-lunch is now known as mrevell | ||
| allenap | bigjools: Sure, of course. | 14:19 |
| bigjools | allenap: thanks dude | 14:28 |
| === matsubara is now known as matsubara-lunch | ||
| === rockstar` is now known as rockstar | ||
| === matsubara-lunch is now known as matsubara | ||
| === ursula is now known as Ursinha | ||
| === allenap changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com | ||
| bigjools | allenap: argh, that regex is making my eyes bleed! | 17:39 |
| allenap | bigjools: Jolly good :) | 17:39 |
| bigjools | jwz got it right | 17:41 |
| citrus | regex is a black art. | 17:42 |
| * citrus likes regex | 17:43 | |
| bigjools | citrus me old fruit | 17:43 |
| citrus | I am just lurking today | 17:43 |
| bigjools | a lurking lemon | 17:43 |
| citrus | hoping for an itinerant UI reviewer to approve my Blueprints branch while I have on Answers | 17:44 |
| citrus | I am feeling more like a Lime to day | 17:45 |
| bigjools | green fingernail paint? | 17:45 |
| citrus | I guess I am very bruised fruit -- Very dark red (Moscow at midnight), purple (Lourve me Lourve me not), Blue (Yoga-ta Get this Blue) | 17:47 |
| citrus | Why did type that? no one on this channel knows nail lacquer colours | 17:48 |
| jtv | deryck: https://code.launchpad.net/~jtv/lazr-js/bug-412576/+merge/14754 | 18:38 |
| deryck | jtv, looking now. | 18:38 |
| jtv | ...if the branch scanner ever wakes up :) | 18:38 |
| jtv | thanks | 18:38 |
| deryck | jtv, yeah, just waiting on the diff here, and then will review. | 18:44 |
| jtv | deryck: you may want to extend an admonishing punch to your left and front. | 18:44 |
| === intellec` is now known as intellectronica | ||
| thumper | rockstar: you have two emails from me, any chance you are going to get a chance to reply? | 20:32 |
| === matsubara is now known as matsubara-afk | ||
| rockstar | thumper, I need a beuno before I can respond, and he's been a rare sight today. | 20:51 |
| thumper | rockstar: hmm.. ok | 20:51 |
| rockstar | thumper, I'm not convinced that scrolling the page is going to be something that will make beuno happy. | 20:52 |
| rockstar | thumper, worse comes to worse, you can just use a link and a page anchor to have it jump. | 20:52 |
| thumper | rockstar: perhaps jumping is the way to go | 20:52 |
| thumper | rockstar: I don't care particularly | 20:52 |
| thumper | rockstar: I just would like to get it to the diff, not load another file | 20:53 |
| rockstar | thumper, I've been wanting to make it some when people click [review] on an mp, it goes down to the form, instead of going to another form. | 20:53 |
| thumper | rockstar: so really just after UI guidance there | 20:53 |
| thumper | rockstar: beuno wants the form to appear where they click | 20:53 |
| rockstar | thumper, have it jump, land it that way, and I'll consult the beuno tonight sometime. | 20:53 |
| rockstar | thumper, does he want to overlay? I'm so sick of FormOverlays... | 20:54 |
| thumper | not sure | 20:54 |
| thumper | ask him | 20:54 |
| rockstar | Okay. | 20:54 |
| rockstar | thumper, what's the other email I have from you? I only see that one. | 20:54 |
| thumper | rockstar: it is a review https://code.edge.launchpad.net/~thumper/launchpad/bug-branch-proposal-view/+merge/14736 | 20:54 |
| rockstar | Ah, okay. | 20:55 |
| thumper | I have three more branches in that pipeline | 20:55 |
| rockstar | thumper, do you want me to ui AND code review? | 20:55 |
| thumper | rockstar: you could do | 21:04 |
| thumper | rockstar: it may speed some things up | 21:04 |
| rockstar | thumper, I can has screenshot then? | 21:04 |
| thumper | hmm... | 21:04 |
| thumper | I can't attach a screen shot to the review yet | 21:05 |
| thumper | rockstar: yes... | 21:05 |
| rockstar | thumper, have you tested this in IE, Safari, Chrome, and Firefox? | 21:06 |
| * rockstar kids | 21:06 | |
| thumper | rockstar: there is no js, just page details | 21:06 |
| * thumper stabs rockstar | 21:06 | |
| rockstar | thumper, I've been working in Windows all day. You'll have to find a place to stab that I haven't already stabbed. | 21:07 |
| rockstar | thumper, I've been working in Windows all day. You'll have to find a place to stab that I haven't already stabbed. | 21:07 |
| thumper | rockstar: awww.... | 21:08 |
| thumper | how sad | 21:08 |
| thumper | :( | 21:08 |
| rockstar | I couldn't even check out the lazr-js trunk because it used symlinks. I had to fix that. I still can't build just yet. | 21:11 |
| thumper | rockstar: the next pipe does the popup diff | 21:11 |
| thumper | rockstar: and the one after that changes the format of the diff link | 21:11 |
| thumper | rockstar: and the one after that will show the mp details on the bug page (with popup diff) | 21:12 |
| rockstar | thumper, I probably can't review all of them. I still owe intellectronica and urbanape a review. | 21:13 |
| thumper | rockstar: sure | 21:13 |
| === ursula is now known as Ursinha | ||
| rockstar | thumper, however, deryck and I are about to start hacking on a wizard widget. | 21:13 |
| thumper | awesome | 21:13 |
| thumper | rockstar: http://penhey.net/~tim/branch.png | 21:15 |
| rockstar | thumper, r=me for ui and code, but you'll still need another ui reviewer. | 21:17 |
| thumper | rockstar: anyone there? | 21:18 |
| rockstar | thumper, well, we're all pretty heads down. Let me bug someone. | 21:18 |
| thumper | ta | 21:18 |
| thumper | rockstar: just wave the picture at them | 21:18 |
| thumper | rockstar: deryck already has given +1 on jfdi | 21:19 |
| rockstar | thumper, deryck's not a ui reviewer. | 21:20 |
| thumper | :( | 21:21 |
| thumper | who is? | 21:21 |
| thumper | is barry? | 21:21 |
| thumper | is he there? | 21:21 |
| deryck | yeah, sorry, not a UI reviewer. | 21:21 |
| thumper | barry: are you around? | 21:21 |
| rockstar | thumper, I'll find barry when he gets back. He's not there right now. | 21:25 |
| thumper | rockstar: but barry is at the sprint? | 21:26 |
| rockstar | thumper, yes. | 21:29 |
| rockstar | thumper, also, it's a national holiday in the US. | 21:30 |
| thumper | :( | 21:30 |
| barry | plus i have irc open on a vm :) hi thumper | 21:41 |
| thumper | barry: hi | 21:41 |
| thumper | barry: just after a UI approval: http://penhey.net/~tim/branch.png | 21:41 |
| thumper | barry: showing more proposal details on the branch page (and soon the bug page) | 21:41 |
| thumper | barry: https://code.edge.launchpad.net/~thumper/launchpad/bug-branch-proposal-view/+merge/14736 | 21:42 |
| barry | thumper: looking | 21:43 |
| thumper | barry: this is only part of the final product | 21:43 |
| thumper | barry: FYI - next pipe adds popup diff viewing on the branch page, then next changes the format of the diff link rendering to be something like: 327 lines (+43/-120) 8 files modified | 21:44 |
| barry | thumper: ui*=me dunno how much more i can review atm | 21:46 |
| thumper | barry: that's fine, one at a time :) | 21:46 |
| thumper | barry: can you add a ui review to the mp? | 21:46 |
| beuno | rockstar, I'll go by in a bit and we can go over it | 21:47 |
| beuno | I'm in landscape land atm | 21:47 |
| rockstar | beuno, yes, I know. You are needed everywhere. | 21:47 |
| barry | thumper: done | 22:05 |
| thumper | barry: thansk | 22:06 |
Generated by irclog2html.py 2.7 by Marius Gedminas - find it at mg.pov.lt!
