[00:46] <thumper> rockstar: why is maris virtual?
[06:04] <al-maisan> Hello jml, how are things? Can we have a chat re. the schema patch today?
[06:05] <jml> al-maisan, hi. later today should be good.
[06:05] <al-maisan> jml: great! "later today" == ?
[06:08] <jml> al-maisan, thinking...
[06:08] <jml> al-maisan, probably 0700.
[06:09] <al-maisan> jml: your local time i.e. in approx. 2 hours?
[06:09] <jml> al-maisan, I meant UTC, sorry
[06:09] <jml> al-maisan, I'm in Australia at a sprint right now.
[06:09] <jml> brb
[06:10] <al-maisan> jml: OK, at the top of the hour then.. I see.
[07:01] <jml> al-maisan, I'll just start reading the thread that Julian started
[07:02] <jml> al-maisan, so I don't waste your time on the phone :)
[07:02] <al-maisan> jml: I like having conversations :) but do read the email thread first.
[07:03] <jml> al-maisan, ok thanks.
[07:14] <jml> al-maisan, just off to my room to grab my headset. back soon.
[07:15]  * al-maisan fires up skype
[07:17] <mwhudson_> al-maisan: can i see your patch?
=== mwhudson_ is now known as mwhudson
[07:18] <al-maisan> mwhudson: just a minute..
[07:19] <al-maisan> mwhudson: http://pastebin.ubuntu.com/317567/
[07:24] <jml> al-maisan, everything is ready
[07:24] <jml> (at last!)
[07:24] <jml> al-maisan, shall I skype you?
[07:24] <al-maisan> jml: please.
[07:25] <jml> al-maisan, I am told that you are unavailable.
[07:26] <al-maisan> jml: let me skype you then
[07:26] <jml> sure. fire away.
[07:26] <al-maisan> jml: I am being told that you went off-line
[07:27] <al-maisan> only getting your voice mail
[07:31] <jml> the internet sucks
[07:31] <al-maisan> always
[07:32] <al-maisan> +61 7 5665 4450
[07:33] <al-maisan> all lines busy
[07:34] <al-maisan> in holding queue
=== thumper changed the topic of #launchpad-reviews to: on call: - || reviewing: - || queue [https://code.edge.launchpad.net/~thumper/launchpad/diff-tal-change/+merge/14771] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[07:36] <jml> al-maisan, hmm
[07:36] <jml> al-maisan, let me consult others in the room.
[07:37] <al-maisan> a direct number would also be good
[07:37] <jml> al-maisan, +61 7 5444 7311
[07:37] <jml> al-maisan, you'll still need to ask for me @ room 63
[07:38] <al-maisan> ok
[07:39] <al-maisan> jml: I've been put through (".. one moment..") but don't hear anything
[07:39] <al-maisan> phone rings again
[07:40] <mwhudson> \o/
[07:40] <al-maisan> :)
[07:56] <al-maisan> jml: http://pastebin.ubuntu.com/317588/
[08:14] <al-maisan> jml: could you please approve https://code.edge.launchpad.net/~al-maisan/launchpad/builddsc-478919/+merge/14689 when you get to it?
[08:15] <jml> al-maisan, will do.
[08:15] <al-maisan> jml: thank you very much indeed.
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [https://code.edge.launchpad.net/~thumper/launchpad/diff-tal-change/+merge/14771] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== danilo-afk is now known as danilos
[11:04] <danilos> adeuring, hi, do you have time for another review? :)
[11:04] <adeuring> danilos: sure
[11:04] <adeuring> danilos: do you mean your mp from yesterday?
[11:04] <danilos> adeuring, yeah, https://code.edge.launchpad.net/~danilo/launchpad/bug-430702/+merge/14794
[11:05] <adeuring> danilos: ok, I'll look into it
[11:05] <danilos> adeuring, thanks
[11:05] <danilos> adeuring, I am around for any questions
=== matsubara-afk is now known as matsubara
[11:43] <adeuring> danilos: there is a call client.waitsForElementProperty(..., timeout=800000) in test_documentation_links.py . This value is a bit scary ;)
[11:49] <danilos> adeuring, ah, that was while testing, thanks for catching it :)
[11:49] <danilos> adeuring, with new windmill stuff, it's not so easy to stop an investigate what's failing
[11:49] <adeuring> danilos: OK, other that that, r=me
[11:51] <danilos> adeuring, thanks!
=== sinzui changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [sinzui, https://code.edge.launchpad.net/~thumper/launchpad/diff-tal-change/+merge/14771] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[12:14] <sinzui> adeuring: Do you have time to review https://code.edge.launchpad.net/~sinzui/launchpad/merge-mailing-list-bug-471770/+merge/14806
[12:14] <adeuring> sinzui: sure
[12:40] <adeuring> sinzui: r=me; only two spelling questions
[12:41] <sinzui> adeuring: thanks.
[13:02] <sinzui> adeuring: Do you have time to do the code review of https://code.edge.launchpad.net/~sinzui/launchpad/ask-a-question-bug-438467/+merge/14766
[13:09] <adeuring> sinzui: sure. Let me just grab somethine to eat first ;)
[13:54] <adeuring> sinzui: r=me
[13:54] <sinzui> thanks
[14:03] <sinzui> adeuring: I have a another branch that has a lot of UI changes. There are code changes that need review none-the-less. https://code.edge.launchpad.net/~sinzui/launchpad/answers-ui/+merge/14761
[14:04] <adeuring> sinzui: OK, i'll look at it
=== matsubara is now known as matsubara-lunch
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:23] <jtv> adeuring: if you're bored, I've got an oversized one on the queue.  :-)
[15:24] <adeuring> jtv: hmm, I've seen it... can't promise that I get it finisehed today, but I'll try ;)
=== adeuring changed the topic of #launchpad-reviews to:  on call: adeuring || reviewing: jtv || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[15:28] <jtv> adeuring: that's great, thanks!
=== barry is now known as barry_
=== barry_ is now known as barry
=== matsubara-lunch is now known as matsubara
=== bigjools changed the topic of #launchpad-reviews to:  on call: adeuring || reviewing: jtv || queue [bigjools (CP, again] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[16:15] <adeuring> jtv: you raise UnexpetecFormData in HasCustomLanguageCodesTraversalMixin. You are checking a plain URL component here, so wouldn't it be better to raise NotFound?
[16:16] <jtv> adeuring: looking up...
[16:16] <jtv> adeuring: you're right.
[16:17] <adeuring> great, that's better for our "zero oops policy" ;)
[16:17] <jtv> :)
[16:18] <jtv> Changed.
[16:18] <adeuring> jtv: and I think you can remove IDistribution.getCustomLanguageCode()
[16:19] <adeuring> at least the implementation is gone
[16:20] <jtv> Oh, did I miss that one?  Fixing...
[16:21] <adeuring> jtv: well, that's really easy to forget ;)
[16:21] <jtv> running tests
[16:21]  * adeuring would probably have left more cruft...
[16:46] <adeuring> jtv: r=me
[16:46] <jtv> adeuring: yay, thanks!
[17:21] <adeuring> bigjools: r=me
[17:21] <bigjools> thanks!
=== adeuring changed the topic of #launchpad-reviews to: on call: adeuring || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
[17:25] <bigjools> adeuring: fwiw, there is a bug
[17:25] <adeuring> bigjools: OK, so scrap my comment ;)
[17:26] <bigjools> it was a timely reminder
[17:26] <bigjools> need to fix that bug before the next LTS
=== barry` is now known as barry
=== adeuring changed the topic of #launchpad-reviews to:  on call: - || reviewing: - || queue [] || This channel is logged: http://irclogs.ubuntu.com || https://code.edge.launchpad.net/launchpad/+activereviews
=== matsubara is now known as matsubara-afk
=== EdwinGrubbs2 is now known as EdwinGrubbs